# HG changeset patch # User Doug Simon # Date 1368718576 -7200 # Node ID b27184f5f66ba4263d9a7a75c91a1439881c02fb # Parent c4b1aa93b9afdfd8871f954dcad32a7fd495b403 removed redundant parameter diff -r c4b1aa93b9af -r b27184f5f66b graal/com.oracle.graal.compiler/src/com/oracle/graal/compiler/gen/LIRGenerator.java --- a/graal/com.oracle.graal.compiler/src/com/oracle/graal/compiler/gen/LIRGenerator.java Thu May 16 17:23:44 2013 +0200 +++ b/graal/com.oracle.graal.compiler/src/com/oracle/graal/compiler/gen/LIRGenerator.java Thu May 16 17:36:16 2013 +0200 @@ -659,23 +659,24 @@ } @Override - public Variable emitForeignCall(ForeignCallLinkage linkage, CallingConvention callCc, DeoptimizingNode info, Value... args) { + public Variable emitForeignCall(ForeignCallLinkage linkage, DeoptimizingNode info, Value... args) { LIRFrameState state = info != null ? state(info) : null; // move the arguments into the correct location - frameMap.callsMethod(callCc); - assert callCc.getArgumentCount() == args.length : "argument count mismatch"; + CallingConvention linkageCc = linkage.getCallingConvention(); + frameMap.callsMethod(linkageCc); + assert linkageCc.getArgumentCount() == args.length : "argument count mismatch"; Value[] argLocations = new Value[args.length]; for (int i = 0; i < args.length; i++) { Value arg = args[i]; - AllocatableValue loc = callCc.getArgument(i); + AllocatableValue loc = linkageCc.getArgument(i); emitMove(loc, arg); argLocations[i] = loc; } - emitForeignCall(linkage, callCc.getReturn(), argLocations, callCc.getTemporaries(), state); + emitForeignCall(linkage, linkageCc.getReturn(), argLocations, linkageCc.getTemporaries(), state); - if (isLegal(callCc.getReturn())) { - return emitMove(callCc.getReturn()); + if (isLegal(linkageCc.getReturn())) { + return emitMove(linkageCc.getReturn()); } else { return null; } diff -r c4b1aa93b9af -r b27184f5f66b graal/com.oracle.graal.hotspot.amd64/src/com/oracle/graal/hotspot/amd64/AMD64HotSpotLIRGenerator.java --- a/graal/com.oracle.graal.hotspot.amd64/src/com/oracle/graal/hotspot/amd64/AMD64HotSpotLIRGenerator.java Thu May 16 17:23:44 2013 +0200 +++ b/graal/com.oracle.graal.hotspot.amd64/src/com/oracle/graal/hotspot/amd64/AMD64HotSpotLIRGenerator.java Thu May 16 17:36:16 2013 +0200 @@ -209,7 +209,7 @@ } @Override - public Variable emitForeignCall(ForeignCallLinkage linkage, CallingConvention callCc, DeoptimizingNode info, Value... args) { + public Variable emitForeignCall(ForeignCallLinkage linkage, DeoptimizingNode info, Value... args) { Stub stub = getStub(); HotSpotForeignCallLinkage hsLinkage = (HotSpotForeignCallLinkage) linkage; boolean destroysRegisters = hsLinkage.destroysRegisters(); @@ -235,7 +235,7 @@ append(new AMD64HotSpotCRuntimeCallPrologueOp()); } - Variable result = super.emitForeignCall(linkage, callCc, info, args); + Variable result = super.emitForeignCall(linkage, info, args); if (!hsLinkage.isLeaf()) { append(new AMD64HotSpotCRuntimeCallEpilogueOp()); diff -r c4b1aa93b9af -r b27184f5f66b graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/CRuntimeCall.java --- a/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/CRuntimeCall.java Thu May 16 17:23:44 2013 +0200 +++ b/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/CRuntimeCall.java Thu May 16 17:36:16 2013 +0200 @@ -53,7 +53,7 @@ for (int i = 0; i < args.length; i++) { args[i] = gen.operand(arguments.get(i)); } - Variable result = gen.emitForeignCall(linkage, linkage.getCallingConvention(), this, args); + Variable result = gen.emitForeignCall(linkage, this, args); if (result != null) { gen.setResult(this, result); } diff -r c4b1aa93b9af -r b27184f5f66b graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/MonitorEnterStubCall.java --- a/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/MonitorEnterStubCall.java Thu May 16 17:23:44 2013 +0200 +++ b/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/MonitorEnterStubCall.java Thu May 16 17:36:16 2013 +0200 @@ -48,7 +48,7 @@ @Override public void generate(LIRGenerator gen) { ForeignCallLinkage linkage = gen.getRuntime().lookupForeignCall(MONITORENTER); - gen.emitForeignCall(linkage, linkage.getCallingConvention(), this, gen.operand(object), gen.operand(lock)); + gen.emitForeignCall(linkage, this, gen.operand(object), gen.operand(lock)); } @NodeIntrinsic diff -r c4b1aa93b9af -r b27184f5f66b graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/MonitorExitStubCall.java --- a/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/MonitorExitStubCall.java Thu May 16 17:23:44 2013 +0200 +++ b/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/MonitorExitStubCall.java Thu May 16 17:36:16 2013 +0200 @@ -52,7 +52,7 @@ HotSpotLIRGenerator hsGen = (HotSpotLIRGenerator) gen; StackSlot slot = hsGen.getLockSlot(lockDepth); ForeignCallLinkage linkage = gen.getRuntime().lookupForeignCall(MonitorExitStubCall.MONITOREXIT); - gen.emitForeignCall(linkage, linkage.getCallingConvention(), this, gen.operand(object), gen.emitAddress(slot)); + gen.emitForeignCall(linkage, this, gen.operand(object), gen.emitAddress(slot)); } @NodeIntrinsic diff -r c4b1aa93b9af -r b27184f5f66b graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/NewArrayStubCall.java --- a/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/NewArrayStubCall.java Thu May 16 17:23:44 2013 +0200 +++ b/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/NewArrayStubCall.java Thu May 16 17:36:16 2013 +0200 @@ -63,7 +63,7 @@ @Override public void generate(LIRGenerator gen) { ForeignCallLinkage linkage = gen.getRuntime().lookupForeignCall(NEW_ARRAY); - Variable result = gen.emitForeignCall(linkage, linkage.getCallingConvention(), this, gen.operand(hub), gen.operand(length)); + Variable result = gen.emitForeignCall(linkage, this, gen.operand(hub), gen.operand(length)); gen.setResult(this, result); } diff -r c4b1aa93b9af -r b27184f5f66b graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/NewInstanceStubCall.java --- a/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/NewInstanceStubCall.java Thu May 16 17:23:44 2013 +0200 +++ b/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/NewInstanceStubCall.java Thu May 16 17:36:16 2013 +0200 @@ -61,7 +61,7 @@ @Override public void generate(LIRGenerator gen) { ForeignCallLinkage linkage = gen.getRuntime().lookupForeignCall(NEW_INSTANCE); - Variable result = gen.emitForeignCall(linkage, linkage.getCallingConvention(), this, gen.operand(hub)); + Variable result = gen.emitForeignCall(linkage, this, gen.operand(hub)); gen.setResult(this, result); } diff -r c4b1aa93b9af -r b27184f5f66b graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/NewMultiArrayStubCall.java --- a/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/NewMultiArrayStubCall.java Thu May 16 17:23:44 2013 +0200 +++ b/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/NewMultiArrayStubCall.java Thu May 16 17:36:16 2013 +0200 @@ -65,7 +65,7 @@ @Override public void generate(LIRGenerator gen) { ForeignCallLinkage linkage = gen.getRuntime().lookupForeignCall(NewMultiArrayStubCall.NEW_MULTI_ARRAY); - Variable result = gen.emitForeignCall(linkage, linkage.getCallingConvention(), this, gen.operand(hub), Constant.forInt(rank), gen.operand(dims)); + Variable result = gen.emitForeignCall(linkage, this, gen.operand(hub), Constant.forInt(rank), gen.operand(dims)); gen.setResult(this, result); } diff -r c4b1aa93b9af -r b27184f5f66b graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/ThreadIsInterruptedStubCall.java --- a/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/ThreadIsInterruptedStubCall.java Thu May 16 17:23:44 2013 +0200 +++ b/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/ThreadIsInterruptedStubCall.java Thu May 16 17:36:16 2013 +0200 @@ -52,7 +52,7 @@ @Override public void generate(LIRGenerator gen) { ForeignCallLinkage linkage = gen.getRuntime().lookupForeignCall(ThreadIsInterruptedStubCall.THREAD_IS_INTERRUPTED); - Variable result = gen.emitForeignCall(linkage, linkage.getCallingConvention(), this, gen.operand(thread), gen.operand(clearIsInterrupted)); + Variable result = gen.emitForeignCall(linkage, this, gen.operand(thread), gen.operand(clearIsInterrupted)); gen.setResult(this, result); } diff -r c4b1aa93b9af -r b27184f5f66b graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/VMErrorNode.java --- a/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/VMErrorNode.java Thu May 16 17:23:44 2013 +0200 +++ b/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/VMErrorNode.java Thu May 16 17:36:16 2013 +0200 @@ -58,7 +58,7 @@ Constant formatArg = Constant.forObject(format.intern()); ForeignCallLinkage linkage = gen.getRuntime().lookupForeignCall(VMErrorNode.VM_ERROR); - gen.emitForeignCall(linkage, linkage.getCallingConvention(), null, whereArg, formatArg, gen.operand(value)); + gen.emitForeignCall(linkage, null, whereArg, formatArg, gen.operand(value)); } @NodeIntrinsic diff -r c4b1aa93b9af -r b27184f5f66b graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/VerifyOopStubCall.java --- a/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/VerifyOopStubCall.java Thu May 16 17:23:44 2013 +0200 +++ b/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/VerifyOopStubCall.java Thu May 16 17:36:16 2013 +0200 @@ -46,7 +46,7 @@ @Override public void generate(LIRGenerator gen) { ForeignCallLinkage linkage = gen.getRuntime().lookupForeignCall(VerifyOopStubCall.VERIFY_OOP); - gen.emitForeignCall(linkage, linkage.getCallingConvention(), this, gen.operand(object)); + gen.emitForeignCall(linkage, this, gen.operand(object)); } @NodeIntrinsic diff -r c4b1aa93b9af -r b27184f5f66b graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/WriteBarrierPostStubCall.java --- a/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/WriteBarrierPostStubCall.java Thu May 16 17:23:44 2013 +0200 +++ b/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/WriteBarrierPostStubCall.java Thu May 16 17:36:16 2013 +0200 @@ -48,7 +48,7 @@ @Override public void generate(LIRGenerator gen) { ForeignCallLinkage linkage = gen.getRuntime().lookupForeignCall(WriteBarrierPostStubCall.WRITE_BARRIER_POST); - gen.emitForeignCall(linkage, linkage.getCallingConvention(), null, gen.operand(object), gen.operand(card)); + gen.emitForeignCall(linkage, null, gen.operand(object), gen.operand(card)); } @NodeIntrinsic diff -r c4b1aa93b9af -r b27184f5f66b graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/WriteBarrierPreStubCall.java --- a/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/WriteBarrierPreStubCall.java Thu May 16 17:23:44 2013 +0200 +++ b/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/nodes/WriteBarrierPreStubCall.java Thu May 16 17:36:16 2013 +0200 @@ -45,7 +45,7 @@ @Override public void generate(LIRGenerator gen) { ForeignCallLinkage linkage = gen.getRuntime().lookupForeignCall(WriteBarrierPreStubCall.WRITE_BARRIER_PRE); - gen.emitForeignCall(linkage, linkage.getCallingConvention(), null, gen.operand(object)); + gen.emitForeignCall(linkage, null, gen.operand(object)); } @NodeIntrinsic diff -r c4b1aa93b9af -r b27184f5f66b graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/replacements/AESCryptSubstitutions.java --- a/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/replacements/AESCryptSubstitutions.java Thu May 16 17:23:44 2013 +0200 +++ b/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/replacements/AESCryptSubstitutions.java Thu May 16 17:36:16 2013 +0200 @@ -97,7 +97,7 @@ @Override public void generate(LIRGenerator gen) { ForeignCallLinkage linkage = gen.getRuntime().lookupForeignCall(descriptor); - gen.emitForeignCall(linkage, linkage.getCallingConvention(), null, gen.operand(in), gen.operand(out), gen.operand(key)); + gen.emitForeignCall(linkage, null, gen.operand(in), gen.operand(out), gen.operand(key)); } } diff -r c4b1aa93b9af -r b27184f5f66b graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/replacements/CipherBlockChainingSubstitutions.java --- a/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/replacements/CipherBlockChainingSubstitutions.java Thu May 16 17:23:44 2013 +0200 +++ b/graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/replacements/CipherBlockChainingSubstitutions.java Thu May 16 17:36:16 2013 +0200 @@ -118,7 +118,7 @@ @Override public void generate(LIRGenerator gen) { ForeignCallLinkage linkage = gen.getRuntime().lookupForeignCall(descriptor); - gen.emitForeignCall(linkage, linkage.getCallingConvention(), null, gen.operand(in), gen.operand(out), gen.operand(key), gen.operand(r), gen.operand(inLength)); + gen.emitForeignCall(linkage, null, gen.operand(in), gen.operand(out), gen.operand(key), gen.operand(r), gen.operand(inLength)); } } diff -r c4b1aa93b9af -r b27184f5f66b graal/com.oracle.graal.nodes/src/com/oracle/graal/nodes/extended/ForeignCallNode.java --- a/graal/com.oracle.graal.nodes/src/com/oracle/graal/nodes/extended/ForeignCallNode.java Thu May 16 17:23:44 2013 +0200 +++ b/graal/com.oracle.graal.nodes/src/com/oracle/graal/nodes/extended/ForeignCallNode.java Thu May 16 17:36:16 2013 +0200 @@ -60,7 +60,7 @@ for (int i = 0; i < args.length; i++) { args[i] = gen.operand(arguments.get(i)); } - Value result = gen.emitForeignCall(linkage, linkage.getCallingConvention(), this, args); + Value result = gen.emitForeignCall(linkage, this, args); if (result != null) { gen.setResult(this, result); } diff -r c4b1aa93b9af -r b27184f5f66b graal/com.oracle.graal.nodes/src/com/oracle/graal/nodes/java/RegisterFinalizerNode.java --- a/graal/com.oracle.graal.nodes/src/com/oracle/graal/nodes/java/RegisterFinalizerNode.java Thu May 16 17:23:44 2013 +0200 +++ b/graal/com.oracle.graal.nodes/src/com/oracle/graal/nodes/java/RegisterFinalizerNode.java Thu May 16 17:36:16 2013 +0200 @@ -51,7 +51,7 @@ @Override public void generate(LIRGeneratorTool gen) { ForeignCallLinkage linkage = gen.getRuntime().lookupForeignCall(REGISTER_FINALIZER); - gen.emitForeignCall(linkage, linkage.getCallingConvention(), this, gen.operand(object())); + gen.emitForeignCall(linkage, this, gen.operand(object())); } @Override diff -r c4b1aa93b9af -r b27184f5f66b graal/com.oracle.graal.nodes/src/com/oracle/graal/nodes/spi/LIRGeneratorTool.java --- a/graal/com.oracle.graal.nodes/src/com/oracle/graal/nodes/spi/LIRGeneratorTool.java Thu May 16 17:23:44 2013 +0200 +++ b/graal/com.oracle.graal.nodes/src/com/oracle/graal/nodes/spi/LIRGeneratorTool.java Thu May 16 17:36:16 2013 +0200 @@ -101,7 +101,7 @@ void emitNullCheck(ValueNode v, DeoptimizingNode deopting); - Value emitForeignCall(ForeignCallLinkage callTarget, CallingConvention cc, DeoptimizingNode info, Value... args); + Value emitForeignCall(ForeignCallLinkage linkage, DeoptimizingNode info, Value... args); void emitIf(IfNode i);