# HG changeset patch # User Doug Simon # Date 1349782037 -7200 # Node ID b6eec91d81fbfcc9cc8af55994383f634eca6583 # Parent f938212e56abbb34b3e12ea425983e7122b125be renamed input for IfNode from 'compare' to 'condition' diff -r f938212e56ab -r b6eec91d81fb graal/com.oracle.graal.compiler/src/com/oracle/graal/compiler/gen/LIRGenerator.java --- a/graal/com.oracle.graal.compiler/src/com/oracle/graal/compiler/gen/LIRGenerator.java Mon Oct 08 19:46:12 2012 -0700 +++ b/graal/com.oracle.graal.compiler/src/com/oracle/graal/compiler/gen/LIRGenerator.java Tue Oct 09 13:27:17 2012 +0200 @@ -559,7 +559,7 @@ @Override public void emitIf(IfNode x) { - emitBranch(x.compare(), getLIRBlock(x.trueSuccessor()), getLIRBlock(x.falseSuccessor()), null); + emitBranch(x.condition(), getLIRBlock(x.trueSuccessor()), getLIRBlock(x.falseSuccessor()), null); } @Override diff -r f938212e56ab -r b6eec91d81fb graal/com.oracle.graal.loop/src/com/oracle/graal/loop/LoopTransformations.java --- a/graal/com.oracle.graal.loop/src/com/oracle/graal/loop/LoopTransformations.java Mon Oct 08 19:46:12 2012 -0700 +++ b/graal/com.oracle.graal.loop/src/com/oracle/graal/loop/LoopTransformations.java Tue Oct 09 13:27:17 2012 +0200 @@ -101,11 +101,11 @@ BeginNode tempBegin = graph.add(new BeginNode()); originalLoop.entryPoint().replaceAtPredecessor(tempBegin); double takenProbability = ifNode.probability(ifNode.blockSuccessorIndex(ifNode.trueSuccessor())); - IfNode newIf = graph.add(new IfNode(ifNode.compare(), duplicateLoop.entryPoint(), originalLoop.entryPoint(), takenProbability, ifNode.leafGraphId())); + IfNode newIf = graph.add(new IfNode(ifNode.condition(), duplicateLoop.entryPoint(), originalLoop.entryPoint(), takenProbability, ifNode.leafGraphId())); tempBegin.setNext(newIf); - ifNode.setCompare(graph.unique(ConstantNode.forBoolean(false, graph))); + ifNode.setCondition(graph.unique(ConstantNode.forBoolean(false, graph))); IfNode duplicateIf = duplicateLoop.getDuplicatedNode(ifNode); - duplicateIf.setCompare(graph.unique(ConstantNode.forBoolean(true, graph))); + duplicateIf.setCondition(graph.unique(ConstantNode.forBoolean(true, graph))); ifNode.simplify(simplifier); duplicateIf.simplify(simplifier); // TODO (gd) probabilities need some amount of fixup.. (probably also in other transforms) @@ -134,7 +134,7 @@ public static IfNode findUnswitchableIf(LoopEx loop) { for (IfNode ifNode : loop.whole().nodes().filter(IfNode.class)) { - if (loop.isOutsideLoop(ifNode.compare())) { + if (loop.isOutsideLoop(ifNode.condition())) { return ifNode; } } diff -r f938212e56ab -r b6eec91d81fb graal/com.oracle.graal.loop/src/com/oracle/graal/loop/LoopsData.java --- a/graal/com.oracle.graal.loop/src/com/oracle/graal/loop/LoopsData.java Mon Oct 08 19:46:12 2012 -0700 +++ b/graal/com.oracle.graal.loop/src/com/oracle/graal/loop/LoopsData.java Tue Oct 09 13:27:17 2012 +0200 @@ -99,7 +99,7 @@ } negated = true; } - BooleanNode ifTest = ifNode.compare(); + BooleanNode ifTest = ifNode.condition(); if (!(ifTest instanceof IntegerLessThanNode)) { if (ifTest instanceof IntegerBelowThanNode) { Debug.log("Ignored potential Counted loop at %s with |<|", loopBegin); diff -r f938212e56ab -r b6eec91d81fb graal/com.oracle.graal.nodes/src/com/oracle/graal/nodes/IfNode.java --- a/graal/com.oracle.graal.nodes/src/com/oracle/graal/nodes/IfNode.java Mon Oct 08 19:46:12 2012 -0700 +++ b/graal/com.oracle.graal.nodes/src/com/oracle/graal/nodes/IfNode.java Tue Oct 09 13:27:17 2012 +0200 @@ -37,20 +37,20 @@ public static final int FALSE_EDGE = 1; private final long leafGraphId; - @Input private BooleanNode compare; + @Input private BooleanNode condition; - public BooleanNode compare() { - return compare; + public BooleanNode condition() { + return condition; } - public void setCompare(BooleanNode x) { - updateUsages(compare, x); - compare = x; + public void setCondition(BooleanNode x) { + updateUsages(condition, x); + condition = x; } public IfNode(BooleanNode condition, FixedNode trueSuccessor, FixedNode falseSuccessor, double takenProbability, long leafGraphId) { super(StampFactory.forVoid(), new BeginNode[] {BeginNode.begin(trueSuccessor), BeginNode.begin(falseSuccessor)}, new double[] {takenProbability, 1 - takenProbability}); - this.compare = condition; + this.condition = condition; this.leafGraphId = leafGraphId; } @@ -101,7 +101,7 @@ @Override public boolean verify() { - assertTrue(compare() != null, "missing compare"); + assertTrue(condition() != null, "missing condition"); assertTrue(trueSuccessor() != null, "missing trueSuccessor"); assertTrue(falseSuccessor() != null, "missing falseSuccessor"); return super.verify(); @@ -109,8 +109,8 @@ @Override public void simplify(SimplifierTool tool) { - if (compare() instanceof ConstantNode) { - ConstantNode c = (ConstantNode) compare(); + if (condition() instanceof ConstantNode) { + ConstantNode c = (ConstantNode) condition(); if (c.asConstant().asBoolean()) { tool.deleteBranch(falseSuccessor()); tool.addToWorkList(trueSuccessor()); @@ -145,7 +145,7 @@ return; } if (trueValue.isConstant() && falseValue.isConstant()) { - MaterializeNode materialize = MaterializeNode.create(compare(), trueValue, falseValue); + MaterializeNode materialize = MaterializeNode.create(condition(), trueValue, falseValue); ((StructuredGraph) graph()).replaceFloating(singlePhi, materialize); removeEmptyIf(tool); return; diff -r f938212e56ab -r b6eec91d81fb graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/CheckCastEliminationPhase.java --- a/graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/CheckCastEliminationPhase.java Mon Oct 08 19:46:12 2012 -0700 +++ b/graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/CheckCastEliminationPhase.java Tue Oct 09 13:27:17 2012 +0200 @@ -264,24 +264,24 @@ Node pred = node.predecessor(); if (pred != null && pred instanceof IfNode) { IfNode ifNode = (IfNode) pred; - if (!(ifNode.compare() instanceof ConstantNode)) { + if (!(ifNode.condition() instanceof ConstantNode)) { boolean isTrue = (node == ifNode.trueSuccessor()); if (isTrue) { - state.trueConditions.put(ifNode.compare(), begin); + state.trueConditions.put(ifNode.condition(), begin); } else { - state.falseConditions.put(ifNode.compare(), begin); + state.falseConditions.put(ifNode.condition(), begin); } } - if (ifNode.compare() instanceof InstanceOfNode) { - InstanceOfNode instanceOf = (InstanceOfNode) ifNode.compare(); + if (ifNode.condition() instanceof InstanceOfNode) { + InstanceOfNode instanceOf = (InstanceOfNode) ifNode.condition(); if ((node == ifNode.trueSuccessor())) { ValueNode object = instanceOf.object(); state.knownNotNull.add(object); state.knownTypes.put(object, tighten(instanceOf.targetClass(), state.getNodeType(object))); metricInstanceOfRegistered.increment(); } - } else if (ifNode.compare() instanceof IsNullNode) { - IsNullNode nullCheck = (IsNullNode) ifNode.compare(); + } else if (ifNode.condition() instanceof IsNullNode) { + IsNullNode nullCheck = (IsNullNode) ifNode.condition(); boolean isNull = (node == ifNode.trueSuccessor()); if (isNull) { state.knownNull.add(nullCheck.object()); @@ -337,7 +337,7 @@ } else if (node instanceof IfNode) { IfNode ifNode = (IfNode) node; BooleanNode replaceWith = null; - BooleanNode compare = ifNode.compare(); + BooleanNode compare = ifNode.condition(); if (state.trueConditions.containsKey(compare)) { replaceWith = ConstantNode.forBoolean(true, graph); @@ -372,7 +372,7 @@ } } if (replaceWith != null) { - ifNode.setCompare(replaceWith); + ifNode.setCondition(replaceWith); if (compare.usages().isEmpty()) { GraphUtil.killWithUnusedFloatingInputs(compare); } diff -r f938212e56ab -r b6eec91d81fb graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/ConvertDeoptimizeToGuardPhase.java --- a/graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/ConvertDeoptimizeToGuardPhase.java Mon Oct 08 19:46:12 2012 -0700 +++ b/graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/ConvertDeoptimizeToGuardPhase.java Tue Oct 09 13:27:17 2012 +0200 @@ -78,7 +78,7 @@ } else if (deoptBegin.predecessor() instanceof IfNode) { IfNode ifNode = (IfNode) deoptBegin.predecessor(); BeginNode otherBegin = ifNode.trueSuccessor(); - BooleanNode conditionNode = ifNode.compare(); + BooleanNode conditionNode = ifNode.condition(); boolean negated = false; if (deoptBegin == ifNode.trueSuccessor()) { negated = true; diff -r f938212e56ab -r b6eec91d81fb graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/ConvertUnreachedToGuardPhase.java --- a/graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/ConvertUnreachedToGuardPhase.java Mon Oct 08 19:46:12 2012 -0700 +++ b/graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/ConvertUnreachedToGuardPhase.java Tue Oct 09 13:27:17 2012 +0200 @@ -58,7 +58,7 @@ delete = ifNode.falseSuccessor(); } if (insertGuard != null) { - GuardNode guard = graph.unique(new GuardNode(ifNode.compare(), BeginNode.prevBegin(ifNode), DeoptimizationReason.UnreachedCode, DeoptimizationAction.InvalidateReprofile, inverted, ifNode.leafGraphId())); + GuardNode guard = graph.unique(new GuardNode(ifNode.condition(), BeginNode.prevBegin(ifNode), DeoptimizationReason.UnreachedCode, DeoptimizationAction.InvalidateReprofile, inverted, ifNode.leafGraphId())); graph.addBeforeFixed(ifNode, graph.add(new ValueAnchorNode(guard))); GraphUtil.killCFG(delete); graph.removeSplit(ifNode, inverted ? IfNode.FALSE_EDGE : IfNode.TRUE_EDGE);