# HG changeset patch # User Tom Rodriguez # Date 1431371305 25200 # Node ID bea2f27524ba7308466e86fb5228de4b7380159e # Parent c3a6c85aec82c0b39a8de23f02c47c4102ac2e72 Don't allow JFR byte code instrumentation to interfere with PEA diff -r c3a6c85aec82 -r bea2f27524ba graal/com.oracle.graal.replacements/src/com/oracle/graal/replacements/StandardGraphBuilderPlugins.java --- a/graal/com.oracle.graal.replacements/src/com/oracle/graal/replacements/StandardGraphBuilderPlugins.java Mon May 11 11:55:43 2015 -0700 +++ b/graal/com.oracle.graal.replacements/src/com/oracle/graal/replacements/StandardGraphBuilderPlugins.java Mon May 11 12:08:25 2015 -0700 @@ -84,6 +84,7 @@ if (Options.UseBlackholeSubstitution.getValue()) { registerJMHBlackholePlugins(plugins); } + registerJFRThrowablePlugins(plugins); } private static final Field STRING_VALUE_FIELD; @@ -651,4 +652,18 @@ } } } + + private static void registerJFRThrowablePlugins(InvocationPlugins plugins) { + String name = "oracle.jrockit.jfr.jdkevents.ThrowableTracer"; + Class tracerClass = MethodSubstitutionPlugin.resolveClass(name, true); + if (tracerClass != null) { + Registration r = new Registration(plugins, tracerClass); + r.register2("traceThrowable", Throwable.class, String.class, new InvocationPlugin() { + public boolean apply(GraphBuilderContext b, ResolvedJavaMethod targetMethod, Receiver receiver, ValueNode throwable, ValueNode message) { + b.add(new VirtualizableInvokeMacroNode(b.getInvokeKind(), targetMethod, b.bci(), b.getInvokeReturnType(), throwable, message)); + return true; + } + }); + } + } } diff -r c3a6c85aec82 -r bea2f27524ba graal/com.oracle.graal.replacements/src/com/oracle/graal/replacements/nodes/VirtualizableInvokeMacroNode.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/graal/com.oracle.graal.replacements/src/com/oracle/graal/replacements/nodes/VirtualizableInvokeMacroNode.java Mon May 11 12:08:25 2015 -0700 @@ -0,0 +1,54 @@ +/* + * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ +package com.oracle.graal.replacements.nodes; + +import com.oracle.graal.api.meta.*; +import com.oracle.graal.graph.*; +import com.oracle.graal.nodeinfo.*; +import com.oracle.graal.nodes.CallTargetNode.InvokeKind; +import com.oracle.graal.nodes.*; +import com.oracle.graal.nodes.spi.*; + +/** + * A helper class to allow elimination of byte code instrumentation that could interfere with escape + * analysis. + */ +@NodeInfo +public class VirtualizableInvokeMacroNode extends MacroStateSplitNode implements Virtualizable { + + public static final NodeClass TYPE = NodeClass.create(VirtualizableInvokeMacroNode.class); + + public VirtualizableInvokeMacroNode(InvokeKind invokeKind, ResolvedJavaMethod targetMethod, int bci, JavaType returnType, ValueNode... arguments) { + super(TYPE, invokeKind, targetMethod, bci, returnType, arguments); + } + + @Override + public void virtualize(VirtualizerTool tool) { + for (ValueNode arg : arguments) { + State state = tool.getObjectState(arg); + if (state != null && state.getState() == EscapeState.Virtual) { + tool.delete(); + } + } + } +}