# HG changeset patch # User Thomas Wuerthinger # Date 1359649802 -3600 # Node ID c82170bb99361945f6424bbf9e24c1990c36daea # Parent 1ceb9aeb5ea4448901742aa34beb2acb7ccd13a6 Remove scratch register TODOs. diff -r 1ceb9aeb5ea4 -r c82170bb9936 graal/com.oracle.graal.compiler.amd64/src/com/oracle/graal/compiler/amd64/AMD64DeoptimizationStub.java --- a/graal/com.oracle.graal.compiler.amd64/src/com/oracle/graal/compiler/amd64/AMD64DeoptimizationStub.java Thu Jan 31 17:04:16 2013 +0100 +++ b/graal/com.oracle.graal.compiler.amd64/src/com/oracle/graal/compiler/amd64/AMD64DeoptimizationStub.java Thu Jan 31 17:30:02 2013 +0100 @@ -56,7 +56,6 @@ @Override public void emitCode(TargetMethodAssembler tasm, AMD64MacroAssembler masm) { - // TODO (cwimmer): we want to get rid of a generally reserved scratch register. Register scratch = tasm.frameMap.registerConfig.getScratchRegister(); masm.bind(label); @@ -64,12 +63,10 @@ masm.nop(); keepAlive.add(deoptInfo.toString()); AMD64Move.move(tasm, masm, scratch.asValue(), Constant.forObject(deoptInfo)); - // TODO Make this an explicit calling convention instead of using a scratch register AMD64Call.directCall(tasm, masm, tasm.runtime.lookupRuntimeCall(SET_DEOPT_INFO), info); } masm.movl(scratch, tasm.runtime.encodeDeoptActionAndReason(action, reason)); - // TODO Make this an explicit calling convention instead of using a scratch register AMD64Call.directCall(tasm, masm, tasm.runtime.lookupRuntimeCall(DEOPTIMIZE), info); AMD64Call.shouldNotReachHere(tasm, masm); } diff -r 1ceb9aeb5ea4 -r c82170bb9936 graal/com.oracle.graal.lir.amd64/src/com/oracle/graal/lir/amd64/AMD64Call.java --- a/graal/com.oracle.graal.lir.amd64/src/com/oracle/graal/lir/amd64/AMD64Call.java Thu Jan 31 17:04:16 2013 +0100 +++ b/graal/com.oracle.graal.lir.amd64/src/com/oracle/graal/lir/amd64/AMD64Call.java Thu Jan 31 17:30:02 2013 +0100 @@ -111,7 +111,6 @@ // offset might not fit a 32-bit immediate, generate an // indirect call with a 64-bit immediate Register scratch = tasm.frameMap.registerConfig.getScratchRegister(); - // TODO (cwimmer): we want to get rid of a generally reserved scratch register. masm.movq(scratch, 0L); masm.call(scratch); } else {