# HG changeset patch # User never # Date 1251177975 25200 # Node ID cdb8b7c37ac1157e16c13172c1c10ecc5cbfaa09 # Parent 82bd76d4d7f2a3bf48bdd98d49bfec72823f29bd 6875329: fix for 6795465 broke exception handler cloning Reviewed-by: kvn diff -r 82bd76d4d7f2 -r cdb8b7c37ac1 src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp --- a/src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp Mon Aug 24 11:13:46 2009 -0700 +++ b/src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp Mon Aug 24 22:26:15 2009 -0700 @@ -950,15 +950,17 @@ } // Evaluate state_for early since it may emit code. - CodeEmitInfo* info = state_for(x, x->state()); CodeEmitInfo* patching_info = NULL; if (!x->klass()->is_loaded() || PatchALot) { patching_info = state_for(x, x->state_before()); // cannot re-use same xhandlers for multiple CodeEmitInfos, so - // clone all handlers. + // clone all handlers. This is handled transparently in other + // places by the CodeEmitInfo cloning logic but is handled + // specially here because a stub isn't being used. x->set_exception_handlers(new XHandlers(x->exception_handlers())); } + CodeEmitInfo* info = state_for(x, x->state()); i = dims->length(); while (i-- > 0) { diff -r 82bd76d4d7f2 -r cdb8b7c37ac1 src/cpu/x86/vm/c1_LIRGenerator_x86.cpp --- a/src/cpu/x86/vm/c1_LIRGenerator_x86.cpp Mon Aug 24 11:13:46 2009 -0700 +++ b/src/cpu/x86/vm/c1_LIRGenerator_x86.cpp Mon Aug 24 22:26:15 2009 -0700 @@ -1047,16 +1047,17 @@ items->at_put(i, size); } - // need to get the info before, as the items may become invalid through item_free + // Evaluate state_for early since it may emit code. CodeEmitInfo* patching_info = NULL; if (!x->klass()->is_loaded() || PatchALot) { patching_info = state_for(x, x->state_before()); // cannot re-use same xhandlers for multiple CodeEmitInfos, so - // clone all handlers. + // clone all handlers. This is handled transparently in other + // places by the CodeEmitInfo cloning logic but is handled + // specially here because a stub isn't being used. x->set_exception_handlers(new XHandlers(x->exception_handlers())); } - CodeEmitInfo* info = state_for(x, x->state()); i = dims->length();