# HG changeset patch # User Tom Rodriguez # Date 1393362265 28800 # Node ID e34f406850e5ff3e38a319ab37c1e2167c99629f # Parent 5558674018506132145ef6eda6885d11ea0f27f6 ThreadLocals should be final diff -r 555867401850 -r e34f406850e5 graal/com.oracle.graal.debug/src/com/oracle/graal/debug/internal/DebugScope.java --- a/graal/com.oracle.graal.debug/src/com/oracle/graal/debug/internal/DebugScope.java Tue Feb 25 09:49:47 2014 -0800 +++ b/graal/com.oracle.graal.debug/src/com/oracle/graal/debug/internal/DebugScope.java Tue Feb 25 13:04:25 2014 -0800 @@ -87,10 +87,10 @@ } } - private static ThreadLocal instanceTL = new ThreadLocal<>(); - private static ThreadLocal lastClosedTL = new ThreadLocal<>(); - private static ThreadLocal configTL = new ThreadLocal<>(); - private static ThreadLocal lastExceptionThrownTL = new ThreadLocal<>(); + private static final ThreadLocal instanceTL = new ThreadLocal<>(); + private static final ThreadLocal lastClosedTL = new ThreadLocal<>(); + private static final ThreadLocal configTL = new ThreadLocal<>(); + private static final ThreadLocal lastExceptionThrownTL = new ThreadLocal<>(); private final DebugScope parent; private final DebugConfig parentConfig; diff -r 555867401850 -r e34f406850e5 graal/com.oracle.graal.debug/src/com/oracle/graal/debug/internal/TimerImpl.java --- a/graal/com.oracle.graal.debug/src/com/oracle/graal/debug/internal/TimerImpl.java Tue Feb 25 09:49:47 2014 -0800 +++ b/graal/com.oracle.graal.debug/src/com/oracle/graal/debug/internal/TimerImpl.java Tue Feb 25 13:04:25 2014 -0800 @@ -41,7 +41,7 @@ /** * Records the most recent active timer. */ - private static ThreadLocal currentTimer = new ThreadLocal<>(); + private static final ThreadLocal currentTimer = new ThreadLocal<>(); private final DebugValue flat; diff -r 555867401850 -r e34f406850e5 graal/com.oracle.graal.options/src/com/oracle/graal/options/OptionValue.java --- a/graal/com.oracle.graal.options/src/com/oracle/graal/options/OptionValue.java Tue Feb 25 09:49:47 2014 -0800 +++ b/graal/com.oracle.graal.options/src/com/oracle/graal/options/OptionValue.java Tue Feb 25 13:04:25 2014 -0800 @@ -128,7 +128,7 @@ return new MultipleOverridesScope(current, map); } - private static ThreadLocal overrideScopes = new ThreadLocal<>(); + private static final ThreadLocal overrideScopes = new ThreadLocal<>(); /** * The raw option value.