# HG changeset patch # User Thomas Wuerthinger # Date 1308132286 -7200 # Node ID ef7ceaf48b6fb404ac20412eb64558ed98128232 # Parent 0966a5a904ad3b39e89d21d9a16f45cbff6c7f35 Phi addInput clean up. diff -r 0966a5a904ad -r ef7ceaf48b6f graal/com.oracle.max.graal.compiler/src/com/oracle/max/graal/compiler/ir/Phi.java --- a/graal/com.oracle.max.graal.compiler/src/com/oracle/max/graal/compiler/ir/Phi.java Wed Jun 15 11:55:47 2011 +0200 +++ b/graal/com.oracle.max.graal.compiler/src/com/oracle/max/graal/compiler/ir/Phi.java Wed Jun 15 12:04:46 2011 +0200 @@ -129,9 +129,8 @@ return "Phi: (" + str + ")"; } - public Phi addInput(Node y) { + public void addInput(Node y) { inputs().variablePart().add(y); - return this; } public void removeInput(int index) { diff -r 0966a5a904ad -r ef7ceaf48b6f graal/com.oracle.max.graal.compiler/src/com/oracle/max/graal/compiler/value/FrameState.java --- a/graal/com.oracle.max.graal.compiler/src/com/oracle/max/graal/compiler/value/FrameState.java Wed Jun 15 11:55:47 2011 +0200 +++ b/graal/com.oracle.max.graal.compiler/src/com/oracle/max/graal/compiler/value/FrameState.java Wed Jun 15 12:04:46 2011 +0200 @@ -377,22 +377,14 @@ phi = setupPhiForStack(block, i - localsSize); } - Phi originalPhi = phi; if (phi.valueCount() == 0) { int size = block.predecessors().size(); for (int j = 0; j < size; ++j) { - phi = phi.addInput(x); + phi.addInput(x); } - phi = phi.addInput((x == y) ? phi : y); + phi.addInput((x == y) ? phi : y); } else { - phi = phi.addInput((x == y) ? phi : y); - } - if (originalPhi != phi) { - for (int j = 0; j < other.localsSize() + other.stackSize(); ++j) { - if (other.valueAt(j) == originalPhi) { - other.setValueAt(j, phi); - } - } + phi.addInput((x == y) ? phi : y); } if (block instanceof LoopBegin) {