# HG changeset patch # User Jaroslav Tulach # Date 1450265477 -3600 # Node ID fbe1eb7b4172d4ac7fb1f315b78e34ffab458da1 # Parent 9bba3a7b34beb2eb1c39f1b53ca4c072ee5b94ea Providing compatible implementation of List.toString diff -r 9bba3a7b34be -r fbe1eb7b4172 truffle/com.oracle.truffle.api.interop/src/com/oracle/truffle/api/interop/impl/ReadOnlyArrayList.java --- a/truffle/com.oracle.truffle.api.interop/src/com/oracle/truffle/api/interop/impl/ReadOnlyArrayList.java Mon Dec 14 15:07:19 2015 +0100 +++ b/truffle/com.oracle.truffle.api.interop/src/com/oracle/truffle/api/interop/impl/ReadOnlyArrayList.java Wed Dec 16 12:31:17 2015 +0100 @@ -211,6 +211,25 @@ return new ReadOnlyArrayList<>(arr, first + fromIndex, first + toIndex); } + @Override + public String toString() { + Iterator it = iterator(); + if (!it.hasNext()) { + return "[]"; + } + + StringBuilder sb = new StringBuilder(); + sb.append('['); + for (;;) { + T e = it.next(); + sb.append(e == this ? "(this Collection)" : e); + if (!it.hasNext()) { + return sb.append(']').toString(); + } + sb.append(',').append(' '); + } + } + private final class LI implements ListIterator, Iterator { private int index; diff -r 9bba3a7b34be -r fbe1eb7b4172 truffle/com.oracle.truffle.api.test/src/com/oracle/truffle/api/interop/impl/ReadOnlyArrayListTest.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/truffle/com.oracle.truffle.api.test/src/com/oracle/truffle/api/interop/impl/ReadOnlyArrayListTest.java Wed Dec 16 12:31:17 2015 +0100 @@ -0,0 +1,38 @@ +/* + * Copyright (c) 2012, 2015, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ +package com.oracle.truffle.api.interop.impl; + +import java.util.ArrayList; +import java.util.List; +import static org.junit.Assert.assertEquals; +import org.junit.Test; + +public class ReadOnlyArrayListTest { + @Test + public void testToString() { + List readOnly = ReadOnlyArrayList.asList(new String[]{"Hello", "from", "Truffle!"}, 0, 3); + List copy = new ArrayList<>(readOnly); + + assertEquals("Same toString result", readOnly.toString(), copy.toString()); + } +}