annotate test/gc/g1/TestHumongousCodeCacheRoots.java @ 13062:28674af341ac

8027756: assert(!hr->isHumongous()) failed: code root in humongous region? Summary: Change checks for isHumongous() to continuesHumongous() as installing a code root for a humongous object is valid, but not for continuations of humongous objects. Cleaned up asserts. Reviewed-by: jmasa, tamao
author tschatzl
date Thu, 07 Nov 2013 15:17:10 +0100
parents
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
13062
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
1 /*
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
2 * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved.
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
4 *
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
5 * This code is free software; you can redistribute it and/or modify it
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
6 * under the terms of the GNU General Public License version 2 only, as
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
7 * published by the Free Software Foundation.
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
8 *
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
9 * This code is distributed in the hope that it will be useful, but WITHOUT
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
12 * version 2 for more details (a copy is included in the LICENSE file that
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
13 * accompanied this code).
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
14 *
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
15 * You should have received a copy of the GNU General Public License version
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
16 * 2 along with this work; if not, write to the Free Software Foundation,
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
18 *
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
20 * or visit www.oracle.com if you need additional information or have any
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
21 * questions.
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
22 */
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
23
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
24 /*
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
25 * @test
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
26 * @key regression
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
27 * @key gc
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
28 * @bug 8027756
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
29 * @library /testlibrary /testlibrary/whitebox
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
30 * @build TestHumongousCodeCacheRoots
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
31 * @run main ClassFileInstaller sun.hotspot.WhiteBox
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
32 * @summary Humongous objects may have references from the code cache
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
33 * @run main TestHumongousCodeCacheRoots
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
34 */
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
35
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
36 import com.oracle.java.testlibrary.*;
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
37 import sun.hotspot.WhiteBox;
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
38
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
39 import java.util.ArrayList;
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
40 import java.util.Arrays;
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
41
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
42 class TestHumongousCodeCacheRootsHelper {
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
43
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
44 static final int n = 1000000;
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
45 static final int[] AA = new int[n];
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
46 static final int[] BB = new int[n];
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
47
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
48 public static void main(String args[]) throws Exception {
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
49 // do some work so that the compiler compiles this method, inlining the
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
50 // reference to the integer array (which is a humonguous object) into
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
51 // the code cache.
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
52 for(int i = 0; i < n; i++) {
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
53 AA[i] = 0;
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
54 BB[i] = 0;
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
55 }
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
56 // trigger a GC that checks that the verification code allows humongous
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
57 // objects with code cache roots; objects should be all live here.
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
58 System.gc();
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
59
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
60 // deoptimize everyhing: this should make all compiled code zombies.
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
61 WhiteBox wb = WhiteBox.getWhiteBox();
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
62 wb.deoptimizeAll();
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
63
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
64 // trigger a GC that checks that the verification code allows humongous
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
65 // objects with code cache roots; objects should be all live here.
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
66 System.gc();
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
67
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
68 // wait a little for the code cache sweeper to try to clean up zombie nmethods
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
69 // and unregister the code roots.
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
70 try { Thread.sleep(5000); } catch (InterruptedException ex) { }
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
71
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
72 // do some work on the arrays to make sure that they need to be live after the GCs
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
73 for(int i = 0; i < n; i++) {
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
74 AA[i] = 1;
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
75 BB[i] = 10;
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
76 }
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
77
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
78 System.out.println();
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
79 }
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
80 }
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
81
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
82 public class TestHumongousCodeCacheRoots {
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
83
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
84 /**
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
85 * Executes a class in a new VM process with the given parameters.
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
86 * @param vmargs Arguments to the VM to run
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
87 * @param classname Name of the class to run
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
88 * @param arguments Arguments to the class
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
89 * @param useTestDotJavaDotOpts Use test.java.opts as part of the VM argument string
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
90 * @return The OutputAnalyzer with the results for the invocation.
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
91 */
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
92 public static OutputAnalyzer runWhiteBoxTest(String[] vmargs, String classname, String[] arguments, boolean useTestDotJavaDotOpts) throws Exception {
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
93 ArrayList<String> finalargs = new ArrayList<String>();
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
94
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
95 String[] whiteboxOpts = new String[] {
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
96 "-Xbootclasspath/a:.",
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
97 "-XX:+UnlockDiagnosticVMOptions", "-XX:+WhiteBoxAPI",
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
98 "-cp", System.getProperty("java.class.path"),
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
99 };
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
100
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
101 if (useTestDotJavaDotOpts) {
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
102 // System.getProperty("test.java.opts") is '' if no options is set,
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
103 // we need to skip such a result
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
104 String[] externalVMOpts = new String[0];
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
105 if (System.getProperty("test.java.opts") != null && System.getProperty("test.java.opts").length() != 0) {
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
106 externalVMOpts = System.getProperty("test.java.opts").split(" ");
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
107 }
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
108 finalargs.addAll(Arrays.asList(externalVMOpts));
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
109 }
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
110
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
111 finalargs.addAll(Arrays.asList(vmargs));
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
112 finalargs.addAll(Arrays.asList(whiteboxOpts));
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
113 finalargs.add(classname);
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
114 finalargs.addAll(Arrays.asList(arguments));
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
115
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
116 ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(finalargs.toArray(new String[0]));
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
117 OutputAnalyzer output = new OutputAnalyzer(pb.start());
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
118 output.shouldHaveExitValue(0);
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
119
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
120 return output;
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
121 }
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
122
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
123 public static void runTest(String compiler, String[] other) throws Exception {
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
124 ArrayList<String> joined = new ArrayList<String>();
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
125 joined.add(compiler);
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
126 joined.addAll(Arrays.asList(other));
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
127 runWhiteBoxTest(joined.toArray(new String[0]), TestHumongousCodeCacheRootsHelper.class.getName(),
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
128 new String[] {}, false);
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
129 }
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
130
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
131 public static void main(String[] args) throws Exception {
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
132 final String[] baseArguments = new String[] {
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
133 "-XX:+UseG1GC", "-XX:G1HeapRegionSize=1M", "-Xmx100M", // make sure we get a humongous region
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
134 "-XX:+UnlockDiagnosticVMOptions",
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
135 "-XX:InitiatingHeapOccupancyPercent=1", // strong code root marking
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
136 "-XX:+G1VerifyHeapRegionCodeRoots", "-XX:+VerifyAfterGC", // make sure that verification is run
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
137 "-XX:NmethodSweepFraction=1", "-XX:NmethodSweepCheckInterval=1", // make the code cache sweep more predictable
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
138 };
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
139 runTest("-client", baseArguments);
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
140 runTest("-server", baseArguments);
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
141 }
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
142 }
28674af341ac 8027756: assert(!hr->isHumongous()) failed: code root in humongous region?
tschatzl
parents:
diff changeset
143