Mercurial > hg > graal-compiler
annotate src/share/vm/gc_implementation/g1/concurrentMarkThread.hpp @ 1840:4e0094bc41fa
6983311: G1: LoopTest hangs when run with -XX:+ExplicitInvokesConcurrent
Summary: Clear the concurrent marking "in progress" flag while the FullGCCount_lock is held. This avoids a race that can cause back to back System.gc() calls, when ExplicitGCInvokesConcurrent is enabled, to fail to initiate a marking cycle causing the requesting thread to hang.
Reviewed-by: tonyp, ysr
| author | johnc |
|---|---|
| date | Fri, 01 Oct 2010 18:23:16 -0700 |
| parents | c18cbe5936b8 |
| children | f95d63e2154a |
| rev | line source |
|---|---|
| 342 | 1 /* |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1359
diff
changeset
|
2 * Copyright (c) 2001, 2009, Oracle and/or its affiliates. All rights reserved. |
| 342 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1359
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1359
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1359
diff
changeset
|
21 * questions. |
| 342 | 22 * |
| 23 */ | |
| 24 | |
| 25 // The Concurrent Mark GC Thread (could be several in the future). | |
| 26 // This is copied from the Concurrent Mark Sweep GC Thread | |
| 27 // Still under construction. | |
| 28 | |
| 29 class ConcurrentMark; | |
| 30 | |
| 31 class ConcurrentMarkThread: public ConcurrentGCThread { | |
| 32 friend class VMStructs; | |
| 33 | |
| 34 double _vtime_start; // Initial virtual time. | |
| 35 double _vtime_accum; // Accumulated virtual time. | |
| 36 | |
| 37 double _vtime_mark_accum; | |
| 38 double _vtime_count_accum; | |
| 39 | |
| 40 public: | |
| 41 virtual void run(); | |
| 42 | |
| 43 private: | |
| 44 ConcurrentMark* _cm; | |
|
1359
23b1b27ac76c
6909756: G1: guarantee(G1CollectedHeap::heap()->mark_in_progress(),"Precondition.")
tonyp
parents:
1019
diff
changeset
|
45 volatile bool _started; |
|
23b1b27ac76c
6909756: G1: guarantee(G1CollectedHeap::heap()->mark_in_progress(),"Precondition.")
tonyp
parents:
1019
diff
changeset
|
46 volatile bool _in_progress; |
| 342 | 47 |
| 48 void sleepBeforeNextCycle(); | |
| 49 | |
| 50 static SurrogateLockerThread* _slt; | |
| 51 | |
| 52 public: | |
| 53 // Constructor | |
| 54 ConcurrentMarkThread(ConcurrentMark* cm); | |
| 55 | |
| 56 static void makeSurrogateLockerThread(TRAPS); | |
| 57 static SurrogateLockerThread* slt() { return _slt; } | |
| 58 | |
| 59 // Printing | |
| 1019 | 60 void print_on(outputStream* st) const; |
| 61 void print() const; | |
| 342 | 62 |
| 63 // Total virtual time so far. | |
| 64 double vtime_accum(); | |
| 65 // Marking virtual time so far | |
| 66 double vtime_mark_accum(); | |
| 67 // Counting virtual time so far. | |
| 68 double vtime_count_accum() { return _vtime_count_accum; } | |
| 69 | |
|
1359
23b1b27ac76c
6909756: G1: guarantee(G1CollectedHeap::heap()->mark_in_progress(),"Precondition.")
tonyp
parents:
1019
diff
changeset
|
70 ConcurrentMark* cm() { return _cm; } |
|
23b1b27ac76c
6909756: G1: guarantee(G1CollectedHeap::heap()->mark_in_progress(),"Precondition.")
tonyp
parents:
1019
diff
changeset
|
71 |
|
1840
4e0094bc41fa
6983311: G1: LoopTest hangs when run with -XX:+ExplicitInvokesConcurrent
johnc
parents:
1552
diff
changeset
|
72 void set_started() { assert(!_in_progress, "cycle in progress"); _started = true; } |
|
4e0094bc41fa
6983311: G1: LoopTest hangs when run with -XX:+ExplicitInvokesConcurrent
johnc
parents:
1552
diff
changeset
|
73 void clear_started() { assert(_in_progress, "must be starting a cycle"); _started = false; } |
|
1359
23b1b27ac76c
6909756: G1: guarantee(G1CollectedHeap::heap()->mark_in_progress(),"Precondition.")
tonyp
parents:
1019
diff
changeset
|
74 bool started() { return _started; } |
|
23b1b27ac76c
6909756: G1: guarantee(G1CollectedHeap::heap()->mark_in_progress(),"Precondition.")
tonyp
parents:
1019
diff
changeset
|
75 |
|
1840
4e0094bc41fa
6983311: G1: LoopTest hangs when run with -XX:+ExplicitInvokesConcurrent
johnc
parents:
1552
diff
changeset
|
76 void set_in_progress() { assert(_started, "must be starting a cycle"); _in_progress = true; } |
|
4e0094bc41fa
6983311: G1: LoopTest hangs when run with -XX:+ExplicitInvokesConcurrent
johnc
parents:
1552
diff
changeset
|
77 void clear_in_progress() { assert(!_started, "must not be starting a new cycle"); _in_progress = false; } |
|
1359
23b1b27ac76c
6909756: G1: guarantee(G1CollectedHeap::heap()->mark_in_progress(),"Precondition.")
tonyp
parents:
1019
diff
changeset
|
78 bool in_progress() { return _in_progress; } |
| 342 | 79 |
|
1359
23b1b27ac76c
6909756: G1: guarantee(G1CollectedHeap::heap()->mark_in_progress(),"Precondition.")
tonyp
parents:
1019
diff
changeset
|
80 // This flag returns true from the moment a marking cycle is |
|
23b1b27ac76c
6909756: G1: guarantee(G1CollectedHeap::heap()->mark_in_progress(),"Precondition.")
tonyp
parents:
1019
diff
changeset
|
81 // initiated (during the initial-mark pause when started() is set) |
|
23b1b27ac76c
6909756: G1: guarantee(G1CollectedHeap::heap()->mark_in_progress(),"Precondition.")
tonyp
parents:
1019
diff
changeset
|
82 // to the moment when the cycle completes (just after the next |
|
23b1b27ac76c
6909756: G1: guarantee(G1CollectedHeap::heap()->mark_in_progress(),"Precondition.")
tonyp
parents:
1019
diff
changeset
|
83 // marking bitmap has been cleared and in_progress() is |
|
23b1b27ac76c
6909756: G1: guarantee(G1CollectedHeap::heap()->mark_in_progress(),"Precondition.")
tonyp
parents:
1019
diff
changeset
|
84 // cleared). While this flag is true we will not start another cycle |
|
23b1b27ac76c
6909756: G1: guarantee(G1CollectedHeap::heap()->mark_in_progress(),"Precondition.")
tonyp
parents:
1019
diff
changeset
|
85 // so that cycles do not overlap. We cannot use just in_progress() |
|
23b1b27ac76c
6909756: G1: guarantee(G1CollectedHeap::heap()->mark_in_progress(),"Precondition.")
tonyp
parents:
1019
diff
changeset
|
86 // as the CM thread might take some time to wake up before noticing |
|
23b1b27ac76c
6909756: G1: guarantee(G1CollectedHeap::heap()->mark_in_progress(),"Precondition.")
tonyp
parents:
1019
diff
changeset
|
87 // that started() is set and set in_progress(). |
|
23b1b27ac76c
6909756: G1: guarantee(G1CollectedHeap::heap()->mark_in_progress(),"Precondition.")
tonyp
parents:
1019
diff
changeset
|
88 bool during_cycle() { return started() || in_progress(); } |
| 342 | 89 |
| 90 // Yield for GC | |
| 91 void yield(); | |
| 92 | |
| 93 // shutdown | |
| 794 | 94 void stop(); |
| 342 | 95 }; |