Mercurial > hg > graal-compiler
annotate src/share/vm/gc_implementation/g1/satbQueue.hpp @ 1842:6e0aac35bfa9
6980838: G1: guarantee(false) failed: thread has an unexpected active value in its SATB queue
Summary: Under certain circumstances a safepoint could happen between a JavaThread object being created and that object being added to the Java threads list. This could cause the active field of that thread's SATB queue to get out-of-sync with respect to the other Java threads. The solution is to activate the SATB queue, when necessary, before adding the thread to the Java threads list, not when the JavaThread object is created. The changeset also includes a small fix to rename the surrogate locker thread from "Surrogate Locker Thread (CMS)" to "Surrogate Locker Thread (Concurrent GC)" since it's also used in G1.
Reviewed-by: iveresov, ysr, johnc, jcoomes
| author | tonyp |
|---|---|
| date | Fri, 01 Oct 2010 16:43:05 -0400 |
| parents | c18cbe5936b8 |
| children | f95d63e2154a |
| rev | line source |
|---|---|
| 342 | 1 /* |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1317
diff
changeset
|
2 * Copyright (c) 2001, 2007, Oracle and/or its affiliates. All rights reserved. |
| 342 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1317
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1317
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1317
diff
changeset
|
21 * questions. |
| 342 | 22 * |
| 23 */ | |
| 24 | |
| 25 class ObjectClosure; | |
| 26 class JavaThread; | |
| 27 | |
| 28 // A ptrQueue whose elements are "oops", pointers to object heads. | |
| 29 class ObjPtrQueue: public PtrQueue { | |
| 30 public: | |
| 31 ObjPtrQueue(PtrQueueSet* qset_, bool perm = false) : | |
|
1842
6e0aac35bfa9
6980838: G1: guarantee(false) failed: thread has an unexpected active value in its SATB queue
tonyp
parents:
1552
diff
changeset
|
32 // SATB queues are only active during marking cycles. We create |
|
6e0aac35bfa9
6980838: G1: guarantee(false) failed: thread has an unexpected active value in its SATB queue
tonyp
parents:
1552
diff
changeset
|
33 // them with their active field set to false. If a thread is |
|
6e0aac35bfa9
6980838: G1: guarantee(false) failed: thread has an unexpected active value in its SATB queue
tonyp
parents:
1552
diff
changeset
|
34 // created during a cycle and its SATB queue needs to be activated |
|
6e0aac35bfa9
6980838: G1: guarantee(false) failed: thread has an unexpected active value in its SATB queue
tonyp
parents:
1552
diff
changeset
|
35 // before the thread starts running, we'll need to set its active |
|
6e0aac35bfa9
6980838: G1: guarantee(false) failed: thread has an unexpected active value in its SATB queue
tonyp
parents:
1552
diff
changeset
|
36 // field to true. This is done in JavaThread::initialize_queues(). |
|
6e0aac35bfa9
6980838: G1: guarantee(false) failed: thread has an unexpected active value in its SATB queue
tonyp
parents:
1552
diff
changeset
|
37 PtrQueue(qset_, perm, false /* active */) { } |
| 342 | 38 // Apply the closure to all elements, and reset the index to make the |
| 39 // buffer empty. | |
| 40 void apply_closure(ObjectClosure* cl); | |
| 41 | |
| 42 // Apply the closure to all elements of "buf", down to "index" (inclusive.) | |
| 43 static void apply_closure_to_buffer(ObjectClosure* cl, | |
| 44 void** buf, size_t index, size_t sz); | |
| 45 | |
|
845
df6caf649ff7
6700789: G1: Enable use of compressed oops with G1 heaps
ysr
parents:
342
diff
changeset
|
46 void verify_oops_in_buffer() NOT_DEBUG_RETURN; |
| 342 | 47 }; |
| 48 | |
| 49 | |
| 50 | |
| 51 class SATBMarkQueueSet: public PtrQueueSet { | |
| 52 ObjectClosure* _closure; | |
| 53 ObjectClosure** _par_closures; // One per ParGCThread. | |
| 54 | |
| 55 ObjPtrQueue _shared_satb_queue; | |
| 56 | |
| 57 // Utility function to support sequential and parallel versions. If | |
| 58 // "par" is true, then "worker" is the par thread id; if "false", worker | |
| 59 // is ignored. | |
| 60 bool apply_closure_to_completed_buffer_work(bool par, int worker); | |
| 61 | |
|
1317
d4197f8d516a
6935821: G1: threads created during marking do not active their SATB queues
tonyp
parents:
1111
diff
changeset
|
62 #ifdef ASSERT |
|
d4197f8d516a
6935821: G1: threads created during marking do not active their SATB queues
tonyp
parents:
1111
diff
changeset
|
63 void dump_active_values(JavaThread* first, bool expected_active); |
|
d4197f8d516a
6935821: G1: threads created during marking do not active their SATB queues
tonyp
parents:
1111
diff
changeset
|
64 #endif // ASSERT |
| 342 | 65 |
| 66 public: | |
| 67 SATBMarkQueueSet(); | |
| 68 | |
| 69 void initialize(Monitor* cbl_mon, Mutex* fl_lock, | |
| 1111 | 70 int process_completed_threshold, |
| 71 Mutex* lock); | |
| 342 | 72 |
| 73 static void handle_zero_index_for_thread(JavaThread* t); | |
| 74 | |
|
1317
d4197f8d516a
6935821: G1: threads created during marking do not active their SATB queues
tonyp
parents:
1111
diff
changeset
|
75 // Apply "set_active(b)" to all Java threads' SATB queues. It should be |
|
d4197f8d516a
6935821: G1: threads created during marking do not active their SATB queues
tonyp
parents:
1111
diff
changeset
|
76 // called only with the world stopped. The method will assert that the |
|
d4197f8d516a
6935821: G1: threads created during marking do not active their SATB queues
tonyp
parents:
1111
diff
changeset
|
77 // SATB queues of all threads it visits, as well as the SATB queue |
|
d4197f8d516a
6935821: G1: threads created during marking do not active their SATB queues
tonyp
parents:
1111
diff
changeset
|
78 // set itself, has an active value same as expected_active. |
|
d4197f8d516a
6935821: G1: threads created during marking do not active their SATB queues
tonyp
parents:
1111
diff
changeset
|
79 void set_active_all_threads(bool b, bool expected_active); |
| 342 | 80 |
| 81 // Register "blk" as "the closure" for all queues. Only one such closure | |
| 82 // is allowed. The "apply_closure_to_completed_buffer" method will apply | |
| 83 // this closure to a completed buffer, and "iterate_closure_all_threads" | |
| 84 // applies it to partially-filled buffers (the latter should only be done | |
| 85 // with the world stopped). | |
| 86 void set_closure(ObjectClosure* closure); | |
| 87 // Set the parallel closures: pointer is an array of pointers to | |
| 88 // closures, one for each parallel GC thread. | |
| 89 void set_par_closure(int i, ObjectClosure* closure); | |
| 90 | |
| 91 // If there is a registered closure for buffers, apply it to all entries | |
| 92 // in all currently-active buffers. This should only be applied at a | |
| 93 // safepoint. (Currently must not be called in parallel; this should | |
| 94 // change in the future.) | |
| 95 void iterate_closure_all_threads(); | |
| 96 // Parallel version of the above. | |
| 97 void par_iterate_closure_all_threads(int worker); | |
| 98 | |
| 99 // If there exists some completed buffer, pop it, then apply the | |
| 100 // registered closure to all its elements, and return true. If no | |
| 101 // completed buffers exist, return false. | |
| 102 bool apply_closure_to_completed_buffer() { | |
| 103 return apply_closure_to_completed_buffer_work(false, 0); | |
| 104 } | |
| 105 // Parallel version of the above. | |
| 106 bool par_apply_closure_to_completed_buffer(int worker) { | |
| 107 return apply_closure_to_completed_buffer_work(true, worker); | |
| 108 } | |
| 109 | |
| 110 ObjPtrQueue* shared_satb_queue() { return &_shared_satb_queue; } | |
| 111 | |
| 112 // If a marking is being abandoned, reset any unprocessed log buffers. | |
| 113 void abandon_partial_marking(); | |
| 114 | |
| 115 }; |