Mercurial > hg > graal-compiler
annotate src/share/vm/gc_implementation/g1/g1RemSet.cpp @ 10372:e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
Summary: Fixed the output of G1SummarizeRSetStats: too small datatype for the number of concurrently processed cards, added concurrent remembered set thread time retrieval for Linux and Windows (BSD uses os::elapsedTime() now), and other cleanup. The information presented during VM operation is now relative to the previous output, not always cumulative if G1SummarizeRSetStatsPeriod > 0. At VM exit, the code prints a cumulative summary.
Reviewed-by: johnc, jwilhelm
| author | tschatzl |
|---|---|
| date | Tue, 28 May 2013 09:32:06 +0200 |
| parents | 194f52aa2f23 |
| children | 3a4805ad0005 |
| rev | line source |
|---|---|
| 342 | 1 /* |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
2 * Copyright (c) 2001, 2013, Oracle and/or its affiliates. All rights reserved. |
| 342 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1282
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1282
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1282
diff
changeset
|
21 * questions. |
| 342 | 22 * |
| 23 */ | |
| 24 | |
| 1972 | 25 #include "precompiled.hpp" |
| 26 #include "gc_implementation/g1/bufferingOopClosure.hpp" | |
| 27 #include "gc_implementation/g1/concurrentG1Refine.hpp" | |
| 28 #include "gc_implementation/g1/concurrentG1RefineThread.hpp" | |
| 29 #include "gc_implementation/g1/g1BlockOffsetTable.inline.hpp" | |
| 30 #include "gc_implementation/g1/g1CollectedHeap.inline.hpp" | |
| 31 #include "gc_implementation/g1/g1CollectorPolicy.hpp" | |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
32 #include "gc_implementation/g1/g1HotCardCache.hpp" |
|
6219
922993931b3d
7178361: G1: Make sure that PrintGC and PrintGCDetails use the same timing for the GC pause
brutisso
parents:
4839
diff
changeset
|
33 #include "gc_implementation/g1/g1GCPhaseTimes.hpp" |
| 1972 | 34 #include "gc_implementation/g1/g1OopClosures.inline.hpp" |
| 35 #include "gc_implementation/g1/g1RemSet.inline.hpp" | |
| 36 #include "gc_implementation/g1/heapRegionSeq.inline.hpp" | |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
37 #include "gc_implementation/g1/heapRegionRemSet.hpp" |
| 1972 | 38 #include "memory/iterator.hpp" |
| 39 #include "oops/oop.inline.hpp" | |
| 40 #include "utilities/intHisto.hpp" | |
| 342 | 41 |
| 42 #define CARD_REPEAT_HISTO 0 | |
| 43 | |
| 44 #if CARD_REPEAT_HISTO | |
| 45 static size_t ct_freq_sz; | |
| 46 static jbyte* ct_freq = NULL; | |
| 47 | |
| 48 void init_ct_freq_table(size_t heap_sz_bytes) { | |
| 49 if (ct_freq == NULL) { | |
| 50 ct_freq_sz = heap_sz_bytes/CardTableModRefBS::card_size; | |
| 51 ct_freq = new jbyte[ct_freq_sz]; | |
| 52 for (size_t j = 0; j < ct_freq_sz; j++) ct_freq[j] = 0; | |
| 53 } | |
| 54 } | |
| 55 | |
| 56 void ct_freq_note_card(size_t index) { | |
| 57 assert(0 <= index && index < ct_freq_sz, "Bounds error."); | |
| 58 if (ct_freq[index] < 100) { ct_freq[index]++; } | |
| 59 } | |
| 60 | |
| 61 static IntHistogram card_repeat_count(10, 10); | |
| 62 | |
| 63 void ct_freq_update_histo_and_reset() { | |
| 64 for (size_t j = 0; j < ct_freq_sz; j++) { | |
| 65 card_repeat_count.add_entry(ct_freq[j]); | |
| 66 ct_freq[j] = 0; | |
| 67 } | |
| 68 | |
| 69 } | |
| 70 #endif | |
| 71 | |
| 1861 | 72 G1RemSet::G1RemSet(G1CollectedHeap* g1, CardTableModRefBS* ct_bs) |
| 73 : _g1(g1), _conc_refine_cards(0), | |
| 74 _ct_bs(ct_bs), _g1p(_g1->g1_policy()), | |
| 342 | 75 _cg1r(g1->concurrent_g1_refine()), |
| 1705 | 76 _cset_rs_update_cl(NULL), |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
77 _cards_scanned(NULL), _total_cards_scanned(0), |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
78 _prev_period_summary() |
| 342 | 79 { |
| 80 _seq_task = new SubTasksDone(NumSeqTasks); | |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
81 guarantee(n_workers() > 0, "There should be some workers"); |
| 6197 | 82 _cset_rs_update_cl = NEW_C_HEAP_ARRAY(OopsInHeapRegionClosure*, n_workers(), mtGC); |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
83 for (uint i = 0; i < n_workers(); i++) { |
| 1705 | 84 _cset_rs_update_cl[i] = NULL; |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
85 } |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
86 _prev_period_summary.initialize(this, n_workers()); |
| 342 | 87 } |
| 88 | |
| 1861 | 89 G1RemSet::~G1RemSet() { |
| 342 | 90 delete _seq_task; |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
91 for (uint i = 0; i < n_workers(); i++) { |
| 1705 | 92 assert(_cset_rs_update_cl[i] == NULL, "it should be"); |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
93 } |
| 6197 | 94 FREE_C_HEAP_ARRAY(OopsInHeapRegionClosure*, _cset_rs_update_cl, mtGC); |
| 342 | 95 } |
| 96 | |
| 97 void CountNonCleanMemRegionClosure::do_MemRegion(MemRegion mr) { | |
| 98 if (_g1->is_in_g1_reserved(mr.start())) { | |
| 99 _n += (int) ((mr.byte_size() / CardTableModRefBS::card_size)); | |
| 100 if (_start_first == NULL) _start_first = mr.start(); | |
| 101 } | |
| 102 } | |
| 103 | |
| 104 class ScanRSClosure : public HeapRegionClosure { | |
| 105 size_t _cards_done, _cards; | |
| 106 G1CollectedHeap* _g1h; | |
| 107 OopsInHeapRegionClosure* _oc; | |
| 108 G1BlockOffsetSharedArray* _bot_shared; | |
| 109 CardTableModRefBS *_ct_bs; | |
| 110 int _worker_i; | |
| 1261 | 111 int _block_size; |
| 342 | 112 bool _try_claimed; |
| 113 public: | |
| 114 ScanRSClosure(OopsInHeapRegionClosure* oc, int worker_i) : | |
| 115 _oc(oc), | |
| 116 _cards(0), | |
| 117 _cards_done(0), | |
| 118 _worker_i(worker_i), | |
| 119 _try_claimed(false) | |
| 120 { | |
| 121 _g1h = G1CollectedHeap::heap(); | |
| 122 _bot_shared = _g1h->bot_shared(); | |
| 123 _ct_bs = (CardTableModRefBS*) (_g1h->barrier_set()); | |
| 1261 | 124 _block_size = MAX2<int>(G1RSetScanBlockSize, 1); |
| 342 | 125 } |
| 126 | |
| 127 void set_try_claimed() { _try_claimed = true; } | |
| 128 | |
| 129 void scanCard(size_t index, HeapRegion *r) { | |
| 4023 | 130 // Stack allocate the DirtyCardToOopClosure instance |
| 131 HeapRegionDCTOC cl(_g1h, r, _oc, | |
| 132 CardTableModRefBS::Precise, | |
| 133 HeapRegionDCTOC::IntoCSFilterKind); | |
| 342 | 134 |
| 135 // Set the "from" region in the closure. | |
| 136 _oc->set_region(r); | |
| 137 HeapWord* card_start = _bot_shared->address_for_index(index); | |
| 138 HeapWord* card_end = card_start + G1BlockOffsetSharedArray::N_words; | |
| 139 Space *sp = SharedHeap::heap()->space_containing(card_start); | |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
140 MemRegion sm_region = sp->used_region_at_save_marks(); |
| 342 | 141 MemRegion mr = sm_region.intersection(MemRegion(card_start,card_end)); |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
142 if (!mr.is_empty() && !_ct_bs->is_card_claimed(index)) { |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
143 // We make the card as "claimed" lazily (so races are possible |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
144 // but they're benign), which reduces the number of duplicate |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
145 // scans (the rsets of the regions in the cset can intersect). |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
146 _ct_bs->set_card_claimed(index); |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
147 _cards_done++; |
| 4023 | 148 cl.do_MemRegion(mr); |
| 342 | 149 } |
| 150 } | |
| 151 | |
| 152 void printCard(HeapRegion* card_region, size_t card_index, | |
| 153 HeapWord* card_start) { | |
| 154 gclog_or_tty->print_cr("T %d Region [" PTR_FORMAT ", " PTR_FORMAT ") " | |
| 155 "RS names card %p: " | |
| 156 "[" PTR_FORMAT ", " PTR_FORMAT ")", | |
| 157 _worker_i, | |
| 158 card_region->bottom(), card_region->end(), | |
| 159 card_index, | |
| 160 card_start, card_start + G1BlockOffsetSharedArray::N_words); | |
| 161 } | |
| 162 | |
| 163 bool doHeapRegion(HeapRegion* r) { | |
| 164 assert(r->in_collection_set(), "should only be called on elements of CS."); | |
| 165 HeapRegionRemSet* hrrs = r->rem_set(); | |
| 166 if (hrrs->iter_is_complete()) return false; // All done. | |
| 167 if (!_try_claimed && !hrrs->claim_iter()) return false; | |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
168 // If we ever free the collection set concurrently, we should also |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
169 // clear the card table concurrently therefore we won't need to |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
170 // add regions of the collection set to the dirty cards region. |
|
796
29e7d79232b9
6819065: G1: eliminate high serial card table clearing time
apetrusenko
parents:
794
diff
changeset
|
171 _g1h->push_dirty_cards_region(r); |
| 342 | 172 // If we didn't return above, then |
| 173 // _try_claimed || r->claim_iter() | |
| 174 // is true: either we're supposed to work on claimed-but-not-complete | |
| 175 // regions, or we successfully claimed the region. | |
|
10182
5c93c1f61226
8011724: G1: Stack allocate instances of HeapRegionRemSetIterator
johnc
parents:
6725
diff
changeset
|
176 HeapRegionRemSetIterator iter(hrrs); |
| 342 | 177 size_t card_index; |
| 1261 | 178 |
| 179 // We claim cards in block so as to recude the contention. The block size is determined by | |
| 180 // the G1RSetScanBlockSize parameter. | |
| 181 size_t jump_to_card = hrrs->iter_claimed_next(_block_size); | |
|
10182
5c93c1f61226
8011724: G1: Stack allocate instances of HeapRegionRemSetIterator
johnc
parents:
6725
diff
changeset
|
182 for (size_t current_card = 0; iter.has_next(card_index); current_card++) { |
| 1261 | 183 if (current_card >= jump_to_card + _block_size) { |
| 184 jump_to_card = hrrs->iter_claimed_next(_block_size); | |
| 747 | 185 } |
| 1261 | 186 if (current_card < jump_to_card) continue; |
| 342 | 187 HeapWord* card_start = _g1h->bot_shared()->address_for_index(card_index); |
| 188 #if 0 | |
| 189 gclog_or_tty->print("Rem set iteration yielded card [" PTR_FORMAT ", " PTR_FORMAT ").\n", | |
| 190 card_start, card_start + CardTableModRefBS::card_size_in_words); | |
| 191 #endif | |
| 192 | |
| 193 HeapRegion* card_region = _g1h->heap_region_containing(card_start); | |
| 194 assert(card_region != NULL, "Yielding cards not in the heap?"); | |
| 195 _cards++; | |
| 196 | |
|
796
29e7d79232b9
6819065: G1: eliminate high serial card table clearing time
apetrusenko
parents:
794
diff
changeset
|
197 if (!card_region->is_on_dirty_cards_region_list()) { |
|
29e7d79232b9
6819065: G1: eliminate high serial card table clearing time
apetrusenko
parents:
794
diff
changeset
|
198 _g1h->push_dirty_cards_region(card_region); |
|
29e7d79232b9
6819065: G1: eliminate high serial card table clearing time
apetrusenko
parents:
794
diff
changeset
|
199 } |
|
29e7d79232b9
6819065: G1: eliminate high serial card table clearing time
apetrusenko
parents:
794
diff
changeset
|
200 |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
201 // If the card is dirty, then we will scan it during updateRS. |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
202 if (!card_region->in_collection_set() && |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
203 !_ct_bs->is_card_dirty(card_index)) { |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
204 scanCard(card_index, card_region); |
| 342 | 205 } |
| 206 } | |
| 747 | 207 if (!_try_claimed) { |
| 208 hrrs->set_iter_complete(); | |
| 209 } | |
| 342 | 210 return false; |
| 211 } | |
| 212 size_t cards_done() { return _cards_done;} | |
| 213 size_t cards_looked_up() { return _cards;} | |
| 214 }; | |
| 215 | |
| 1861 | 216 void G1RemSet::scanRS(OopsInHeapRegionClosure* oc, int worker_i) { |
| 342 | 217 double rs_time_start = os::elapsedTime(); |
|
4097
dc467e8b2c5e
7112743: G1: Reduce overhead of marking closure during evacuation pauses
johnc
parents:
4095
diff
changeset
|
218 HeapRegion *startRegion = _g1->start_cset_region_for_worker(worker_i); |
| 342 | 219 |
| 1261 | 220 ScanRSClosure scanRScl(oc, worker_i); |
|
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3777
diff
changeset
|
221 |
| 342 | 222 _g1->collection_set_iterate_from(startRegion, &scanRScl); |
| 223 scanRScl.set_try_claimed(); | |
| 224 _g1->collection_set_iterate_from(startRegion, &scanRScl); | |
| 225 | |
| 1261 | 226 double scan_rs_time_sec = os::elapsedTime() - rs_time_start; |
| 342 | 227 |
| 228 assert( _cards_scanned != NULL, "invariant" ); | |
| 229 _cards_scanned[worker_i] = scanRScl.cards_done(); | |
| 230 | |
|
6219
922993931b3d
7178361: G1: Make sure that PrintGC and PrintGCDetails use the same timing for the GC pause
brutisso
parents:
4839
diff
changeset
|
231 _g1p->phase_times()->record_scan_rs_time(worker_i, scan_rs_time_sec * 1000.0); |
| 342 | 232 } |
| 233 | |
| 1705 | 234 // Closure used for updating RSets and recording references that |
| 235 // point into the collection set. Only called during an | |
| 236 // evacuation pause. | |
| 237 | |
| 238 class RefineRecordRefsIntoCSCardTableEntryClosure: public CardTableEntryClosure { | |
| 239 G1RemSet* _g1rs; | |
| 240 DirtyCardQueue* _into_cset_dcq; | |
| 241 public: | |
| 242 RefineRecordRefsIntoCSCardTableEntryClosure(G1CollectedHeap* g1h, | |
| 243 DirtyCardQueue* into_cset_dcq) : | |
| 244 _g1rs(g1h->g1_rem_set()), _into_cset_dcq(into_cset_dcq) | |
| 245 {} | |
| 246 bool do_card_ptr(jbyte* card_ptr, int worker_i) { | |
| 247 // The only time we care about recording cards that | |
| 248 // contain references that point into the collection set | |
| 249 // is during RSet updating within an evacuation pause. | |
| 250 // In this case worker_i should be the id of a GC worker thread. | |
| 251 assert(SafepointSynchronize::is_at_safepoint(), "not during an evacuation pause"); | |
|
2364
04d1138b4cce
7023747: G1: too strict assert in RefineRecordRefsIntoCSCardTableEntryClosure::do_card_ptr in g1RemSet.cpp
brutisso
parents:
2361
diff
changeset
|
252 assert(worker_i < (int) (ParallelGCThreads == 0 ? 1 : ParallelGCThreads), "should be a GC worker"); |
| 342 | 253 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
254 if (_g1rs->refine_card(card_ptr, worker_i, true)) { |
| 1705 | 255 // 'card_ptr' contains references that point into the collection |
| 256 // set. We need to record the card in the DCQS | |
| 257 // (G1CollectedHeap::into_cset_dirty_card_queue_set()) | |
| 258 // that's used for that purpose. | |
| 259 // | |
| 260 // Enqueue the card | |
| 261 _into_cset_dcq->enqueue(card_ptr); | |
| 262 } | |
| 263 return true; | |
| 264 } | |
| 265 }; | |
| 266 | |
| 1861 | 267 void G1RemSet::updateRS(DirtyCardQueue* into_cset_dcq, int worker_i) { |
| 342 | 268 double start = os::elapsedTime(); |
| 1705 | 269 // Apply the given closure to all remaining log entries. |
| 270 RefineRecordRefsIntoCSCardTableEntryClosure into_cset_update_rs_cl(_g1, into_cset_dcq); | |
|
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3777
diff
changeset
|
271 |
| 1705 | 272 _g1->iterate_dirty_card_closure(&into_cset_update_rs_cl, into_cset_dcq, false, worker_i); |
| 273 | |
| 794 | 274 // Now there should be no dirty cards. |
| 275 if (G1RSLogCheckCardTable) { | |
| 276 CountNonCleanMemRegionClosure cl(_g1); | |
| 277 _ct_bs->mod_card_iterate(&cl); | |
| 278 // XXX This isn't true any more: keeping cards of young regions | |
| 279 // marked dirty broke it. Need some reasonable fix. | |
| 280 guarantee(cl.n() == 0, "Card table should be clean."); | |
| 342 | 281 } |
| 794 | 282 |
|
6219
922993931b3d
7178361: G1: Make sure that PrintGC and PrintGCDetails use the same timing for the GC pause
brutisso
parents:
4839
diff
changeset
|
283 _g1p->phase_times()->record_update_rs_time(worker_i, (os::elapsedTime() - start) * 1000.0); |
| 342 | 284 } |
| 285 | |
| 1861 | 286 void G1RemSet::cleanupHRRS() { |
| 342 | 287 HeapRegionRemSet::cleanup(); |
| 288 } | |
| 289 | |
| 1861 | 290 void G1RemSet::oops_into_collection_set_do(OopsInHeapRegionClosure* oc, |
| 342 | 291 int worker_i) { |
| 292 #if CARD_REPEAT_HISTO | |
| 293 ct_freq_update_histo_and_reset(); | |
| 294 #endif | |
| 295 | |
| 1705 | 296 // We cache the value of 'oc' closure into the appropriate slot in the |
| 297 // _cset_rs_update_cl for this worker | |
| 298 assert(worker_i < (int)n_workers(), "sanity"); | |
| 299 _cset_rs_update_cl[worker_i] = oc; | |
| 300 | |
| 301 // A DirtyCardQueue that is used to hold cards containing references | |
| 302 // that point into the collection set. This DCQ is associated with a | |
| 303 // special DirtyCardQueueSet (see g1CollectedHeap.hpp). Under normal | |
| 304 // circumstances (i.e. the pause successfully completes), these cards | |
| 305 // are just discarded (there's no need to update the RSets of regions | |
| 306 // that were in the collection set - after the pause these regions | |
| 307 // are wholly 'free' of live objects. In the event of an evacuation | |
| 308 // failure the cards/buffers in this queue set are: | |
| 309 // * passed to the DirtyCardQueueSet that is used to manage deferred | |
| 310 // RSet updates, or | |
| 311 // * scanned for references that point into the collection set | |
| 312 // and the RSet of the corresponding region in the collection set | |
| 313 // is updated immediately. | |
| 314 DirtyCardQueue into_cset_dcq(&_g1->into_cset_dirty_card_queue_set()); | |
| 315 | |
|
1708
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
316 assert((ParallelGCThreads > 0) || worker_i == 0, "invariant"); |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
317 |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
318 // The two flags below were introduced temporarily to serialize |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
319 // the updating and scanning of remembered sets. There are some |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
320 // race conditions when these two operations are done in parallel |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
321 // and they are causing failures. When we resolve said race |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
322 // conditions, we'll revert back to parallel remembered set |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
323 // updating and scanning. See CRs 6677707 and 6677708. |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
324 if (G1UseParallelRSetUpdating || (worker_i == 0)) { |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
325 updateRS(&into_cset_dcq, worker_i); |
| 342 | 326 } else { |
|
6628
bb3f6194fedb
7178363: G1: Remove the serial code for PrintGCDetails and make it a special case of the parallel code
brutisso
parents:
6254
diff
changeset
|
327 _g1p->phase_times()->record_update_rs_processed_buffers(worker_i, 0); |
|
6219
922993931b3d
7178361: G1: Make sure that PrintGC and PrintGCDetails use the same timing for the GC pause
brutisso
parents:
4839
diff
changeset
|
328 _g1p->phase_times()->record_update_rs_time(worker_i, 0.0); |
|
1708
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
329 } |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
330 if (G1UseParallelRSetScanning || (worker_i == 0)) { |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
331 scanRS(oc, worker_i); |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
332 } else { |
|
6219
922993931b3d
7178361: G1: Make sure that PrintGC and PrintGCDetails use the same timing for the GC pause
brutisso
parents:
4839
diff
changeset
|
333 _g1p->phase_times()->record_scan_rs_time(worker_i, 0.0); |
| 342 | 334 } |
| 1705 | 335 |
| 336 // We now clear the cached values of _cset_rs_update_cl for this worker | |
| 337 _cset_rs_update_cl[worker_i] = NULL; | |
| 342 | 338 } |
| 339 | |
| 1861 | 340 void G1RemSet::prepare_for_oops_into_collection_set_do() { |
| 342 | 341 cleanupHRRS(); |
| 342 ConcurrentG1Refine* cg1r = _g1->concurrent_g1_refine(); | |
| 343 _g1->set_refine_cte_cl_concurrency(false); | |
| 344 DirtyCardQueueSet& dcqs = JavaThread::dirty_card_queue_set(); | |
| 345 dcqs.concatenate_logs(); | |
| 346 | |
|
4095
bca17e38de00
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
4090
diff
changeset
|
347 if (G1CollectedHeap::use_parallel_gc_threads()) { |
|
bca17e38de00
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
4090
diff
changeset
|
348 // Don't set the number of workers here. It will be set |
|
bca17e38de00
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
4090
diff
changeset
|
349 // when the task is run |
|
bca17e38de00
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
4090
diff
changeset
|
350 // _seq_task->set_n_termination((int)n_workers()); |
| 342 | 351 } |
| 352 guarantee( _cards_scanned == NULL, "invariant" ); | |
| 6197 | 353 _cards_scanned = NEW_C_HEAP_ARRAY(size_t, n_workers(), mtGC); |
| 545 | 354 for (uint i = 0; i < n_workers(); ++i) { |
| 355 _cards_scanned[i] = 0; | |
| 356 } | |
| 342 | 357 _total_cards_scanned = 0; |
| 358 } | |
| 359 | |
| 360 | |
| 1705 | 361 // This closure, applied to a DirtyCardQueueSet, is used to immediately |
| 362 // update the RSets for the regions in the CSet. For each card it iterates | |
| 363 // through the oops which coincide with that card. It scans the reference | |
| 364 // fields in each oop; when it finds an oop that points into the collection | |
| 365 // set, the RSet for the region containing the referenced object is updated. | |
| 366 class UpdateRSetCardTableEntryIntoCSetClosure: public CardTableEntryClosure { | |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
367 G1CollectedHeap* _g1; |
|
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
368 CardTableModRefBS* _ct_bs; |
|
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
369 public: |
| 1705 | 370 UpdateRSetCardTableEntryIntoCSetClosure(G1CollectedHeap* g1, |
| 371 CardTableModRefBS* bs): | |
| 372 _g1(g1), _ct_bs(bs) | |
| 373 { } | |
| 374 | |
| 375 bool do_card_ptr(jbyte* card_ptr, int worker_i) { | |
| 376 // Construct the region representing the card. | |
| 377 HeapWord* start = _ct_bs->addr_for(card_ptr); | |
| 378 // And find the region containing it. | |
| 379 HeapRegion* r = _g1->heap_region_containing(start); | |
| 380 assert(r != NULL, "unexpected null"); | |
| 381 | |
| 382 // Scan oops in the card looking for references into the collection set | |
|
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
383 // Don't use addr_for(card_ptr + 1) which can ask for |
|
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
384 // a card beyond the heap. This is not safe without a perm |
|
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
385 // gen. |
|
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
386 HeapWord* end = start + CardTableModRefBS::card_size_in_words; |
| 1705 | 387 MemRegion scanRegion(start, end); |
| 388 | |
| 389 UpdateRSetImmediate update_rs_cl(_g1->g1_rem_set()); | |
|
3983
811ec3d0833b
7097053: G1: assert(da ? referent->is_oop() : referent->is_oop_or_null()) failed: referenceProcessor.cpp:1054
johnc
parents:
3979
diff
changeset
|
390 FilterIntoCSClosure update_rs_cset_oop_cl(NULL, _g1, &update_rs_cl); |
| 1705 | 391 FilterOutOfRegionClosure filter_then_update_rs_cset_oop_cl(r, &update_rs_cset_oop_cl); |
| 392 | |
| 393 // We can pass false as the "filter_young" parameter here as: | |
| 394 // * we should be in a STW pause, | |
| 395 // * the DCQS to which this closure is applied is used to hold | |
| 396 // references that point into the collection set from the prior | |
| 397 // RSet updating, | |
| 398 // * the post-write barrier shouldn't be logging updates to young | |
| 399 // regions (but there is a situation where this can happen - see | |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
400 // the comment in G1RemSet::refine_card() below - |
| 1705 | 401 // that should not be applicable here), and |
| 402 // * during actual RSet updating, the filtering of cards in young | |
| 403 // regions in HeapRegion::oops_on_card_seq_iterate_careful is | |
| 404 // employed. | |
| 405 // As a result, when this closure is applied to "refs into cset" | |
| 406 // DCQS, we shouldn't see any cards in young regions. | |
| 407 update_rs_cl.set_region(r); | |
| 408 HeapWord* stop_point = | |
| 409 r->oops_on_card_seq_iterate_careful(scanRegion, | |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
410 &filter_then_update_rs_cset_oop_cl, |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
411 false /* filter_young */, |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
412 NULL /* card_ptr */); |
| 1705 | 413 |
| 414 // Since this is performed in the event of an evacuation failure, we | |
| 415 // we shouldn't see a non-null stop point | |
| 416 assert(stop_point == NULL, "saw an unallocated region"); | |
| 417 return true; | |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
418 } |
|
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
419 }; |
|
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
420 |
| 1861 | 421 void G1RemSet::cleanup_after_oops_into_collection_set_do() { |
| 342 | 422 guarantee( _cards_scanned != NULL, "invariant" ); |
| 423 _total_cards_scanned = 0; | |
|
3777
e8b0b0392037
7046182: G1: remove unnecessary iterations over the collection set
tonyp
parents:
3765
diff
changeset
|
424 for (uint i = 0; i < n_workers(); ++i) { |
| 342 | 425 _total_cards_scanned += _cards_scanned[i]; |
|
3777
e8b0b0392037
7046182: G1: remove unnecessary iterations over the collection set
tonyp
parents:
3765
diff
changeset
|
426 } |
| 6197 | 427 FREE_C_HEAP_ARRAY(size_t, _cards_scanned, mtGC); |
| 342 | 428 _cards_scanned = NULL; |
| 429 // Cleanup after copy | |
| 430 _g1->set_refine_cte_cl_concurrency(true); | |
| 431 // Set all cards back to clean. | |
| 432 _g1->cleanUpCardTable(); | |
| 794 | 433 |
| 1705 | 434 DirtyCardQueueSet& into_cset_dcqs = _g1->into_cset_dirty_card_queue_set(); |
| 435 int into_cset_n_buffers = into_cset_dcqs.completed_buffers_num(); | |
| 436 | |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
437 if (_g1->evacuation_failed()) { |
| 1705 | 438 // Restore remembered sets for the regions pointing into the collection set. |
| 439 | |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
440 if (G1DeferredRSUpdate) { |
| 1705 | 441 // If deferred RS updates are enabled then we just need to transfer |
| 442 // the completed buffers from (a) the DirtyCardQueueSet used to hold | |
| 443 // cards that contain references that point into the collection set | |
| 444 // to (b) the DCQS used to hold the deferred RS updates | |
| 445 _g1->dirty_card_queue_set().merge_bufferlists(&into_cset_dcqs); | |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
446 } else { |
| 1705 | 447 |
| 448 CardTableModRefBS* bs = (CardTableModRefBS*)_g1->barrier_set(); | |
| 449 UpdateRSetCardTableEntryIntoCSetClosure update_rs_cset_immediate(_g1, bs); | |
| 450 | |
| 451 int n_completed_buffers = 0; | |
| 452 while (into_cset_dcqs.apply_closure_to_completed_buffer(&update_rs_cset_immediate, | |
| 453 0, 0, true)) { | |
| 454 n_completed_buffers++; | |
| 455 } | |
| 456 assert(n_completed_buffers == into_cset_n_buffers, "missed some buffers"); | |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
457 } |
|
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
458 } |
| 1705 | 459 |
| 460 // Free any completed buffers in the DirtyCardQueueSet used to hold cards | |
| 461 // which contain references that point into the collection. | |
| 462 _g1->into_cset_dirty_card_queue_set().clear(); | |
| 463 assert(_g1->into_cset_dirty_card_queue_set().completed_buffers_num() == 0, | |
| 464 "all buffers should be freed"); | |
| 465 _g1->into_cset_dirty_card_queue_set().clear_n_completed_buffers(); | |
| 342 | 466 } |
| 467 | |
| 468 class ScrubRSClosure: public HeapRegionClosure { | |
| 469 G1CollectedHeap* _g1h; | |
| 470 BitMap* _region_bm; | |
| 471 BitMap* _card_bm; | |
| 472 CardTableModRefBS* _ctbs; | |
| 473 public: | |
| 474 ScrubRSClosure(BitMap* region_bm, BitMap* card_bm) : | |
| 475 _g1h(G1CollectedHeap::heap()), | |
| 476 _region_bm(region_bm), _card_bm(card_bm), | |
| 477 _ctbs(NULL) | |
| 478 { | |
| 479 ModRefBarrierSet* bs = _g1h->mr_bs(); | |
| 480 guarantee(bs->is_a(BarrierSet::CardTableModRef), "Precondition"); | |
| 481 _ctbs = (CardTableModRefBS*)bs; | |
| 482 } | |
| 483 | |
| 484 bool doHeapRegion(HeapRegion* r) { | |
| 485 if (!r->continuesHumongous()) { | |
| 486 r->rem_set()->scrub(_ctbs, _region_bm, _card_bm); | |
| 487 } | |
| 488 return false; | |
| 489 } | |
| 490 }; | |
| 491 | |
| 1861 | 492 void G1RemSet::scrub(BitMap* region_bm, BitMap* card_bm) { |
| 342 | 493 ScrubRSClosure scrub_cl(region_bm, card_bm); |
| 494 _g1->heap_region_iterate(&scrub_cl); | |
| 495 } | |
| 496 | |
| 1861 | 497 void G1RemSet::scrub_par(BitMap* region_bm, BitMap* card_bm, |
|
4728
441e946dc1af
7121618: Change type of number of GC workers to unsigned int.
jmasa
parents:
4097
diff
changeset
|
498 uint worker_num, int claim_val) { |
| 342 | 499 ScrubRSClosure scrub_cl(region_bm, card_bm); |
|
4095
bca17e38de00
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
4090
diff
changeset
|
500 _g1->heap_region_par_iterate_chunked(&scrub_cl, |
|
bca17e38de00
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
4090
diff
changeset
|
501 worker_num, |
|
4728
441e946dc1af
7121618: Change type of number of GC workers to unsigned int.
jmasa
parents:
4097
diff
changeset
|
502 n_workers(), |
|
4095
bca17e38de00
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
4090
diff
changeset
|
503 claim_val); |
| 342 | 504 } |
| 505 | |
| 4839 | 506 G1TriggerClosure::G1TriggerClosure() : |
| 507 _triggered(false) { } | |
| 508 | |
| 509 G1InvokeIfNotTriggeredClosure::G1InvokeIfNotTriggeredClosure(G1TriggerClosure* t_cl, | |
| 510 OopClosure* oop_cl) : | |
| 511 _trigger_cl(t_cl), _oop_cl(oop_cl) { } | |
| 1705 | 512 |
| 4839 | 513 G1Mux2Closure::G1Mux2Closure(OopClosure *c1, OopClosure *c2) : |
| 514 _c1(c1), _c2(c2) { } | |
| 1705 | 515 |
| 4839 | 516 G1UpdateRSOrPushRefOopClosure:: |
| 517 G1UpdateRSOrPushRefOopClosure(G1CollectedHeap* g1h, | |
| 518 G1RemSet* rs, | |
| 519 OopsInHeapRegionClosure* push_ref_cl, | |
| 520 bool record_refs_into_cset, | |
| 521 int worker_i) : | |
| 522 _g1(g1h), _g1_rem_set(rs), _from(NULL), | |
| 523 _record_refs_into_cset(record_refs_into_cset), | |
| 524 _push_ref_cl(push_ref_cl), _worker_i(worker_i) { } | |
| 1705 | 525 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
526 // Returns true if the given card contains references that point |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
527 // into the collection set, if we're checking for such references; |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
528 // false otherwise. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
529 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
530 bool G1RemSet::refine_card(jbyte* card_ptr, int worker_i, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
531 bool check_for_refs_into_cset) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
532 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
533 // If the card is no longer dirty, nothing to do. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
534 if (*card_ptr != CardTableModRefBS::dirty_card_val()) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
535 // No need to return that this card contains refs that point |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
536 // into the collection set. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
537 return false; |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
538 } |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
539 |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
540 // Construct the region representing the card. |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
541 HeapWord* start = _ct_bs->addr_for(card_ptr); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
542 // And find the region containing it. |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
543 HeapRegion* r = _g1->heap_region_containing(start); |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
544 if (r == NULL) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
545 // Again no need to return that this card contains refs that |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
546 // point into the collection set. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
547 return false; // Not in the G1 heap (might be in perm, for example.) |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
548 } |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
549 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
550 // Why do we have to check here whether a card is on a young region, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
551 // given that we dirty young regions and, as a result, the |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
552 // post-barrier is supposed to filter them out and never to enqueue |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
553 // them? When we allocate a new region as the "allocation region" we |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
554 // actually dirty its cards after we release the lock, since card |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
555 // dirtying while holding the lock was a performance bottleneck. So, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
556 // as a result, it is possible for other threads to actually |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
557 // allocate objects in the region (after the acquire the lock) |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
558 // before all the cards on the region are dirtied. This is unlikely, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
559 // and it doesn't happen often, but it can happen. So, the extra |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
560 // check below filters out those cards. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
561 if (r->is_young()) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
562 return false; |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
563 } |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
564 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
565 // While we are processing RSet buffers during the collection, we |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
566 // actually don't want to scan any cards on the collection set, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
567 // since we don't want to update remebered sets with entries that |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
568 // point into the collection set, given that live objects from the |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
569 // collection set are about to move and such entries will be stale |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
570 // very soon. This change also deals with a reliability issue which |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
571 // involves scanning a card in the collection set and coming across |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
572 // an array that was being chunked and looking malformed. Note, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
573 // however, that if evacuation fails, we have to scan any objects |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
574 // that were not moved and create any missing entries. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
575 if (r->in_collection_set()) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
576 return false; |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
577 } |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
578 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
579 // The result from the hot card cache insert call is either: |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
580 // * pointer to the current card |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
581 // (implying that the current card is not 'hot'), |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
582 // * null |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
583 // (meaning we had inserted the card ptr into the "hot" card cache, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
584 // which had some headroom), |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
585 // * a pointer to a "hot" card that was evicted from the "hot" cache. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
586 // |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
587 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
588 G1HotCardCache* hot_card_cache = _cg1r->hot_card_cache(); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
589 if (hot_card_cache->use_cache()) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
590 assert(!check_for_refs_into_cset, "sanity"); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
591 assert(!SafepointSynchronize::is_at_safepoint(), "sanity"); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
592 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
593 card_ptr = hot_card_cache->insert(card_ptr); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
594 if (card_ptr == NULL) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
595 // There was no eviction. Nothing to do. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
596 return false; |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
597 } |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
598 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
599 start = _ct_bs->addr_for(card_ptr); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
600 r = _g1->heap_region_containing(start); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
601 if (r == NULL) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
602 // Not in the G1 heap |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
603 return false; |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
604 } |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
605 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
606 // Checking whether the region we got back from the cache |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
607 // is young here is inappropriate. The region could have been |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
608 // freed, reallocated and tagged as young while in the cache. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
609 // Hence we could see its young type change at any time. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
610 } |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
611 |
|
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
612 // Don't use addr_for(card_ptr + 1) which can ask for |
|
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
613 // a card beyond the heap. This is not safe without a perm |
|
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
614 // gen at the upper end of the heap. |
|
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
615 HeapWord* end = start + CardTableModRefBS::card_size_in_words; |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
616 MemRegion dirtyRegion(start, end); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
617 |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
618 #if CARD_REPEAT_HISTO |
|
2188
c33825b68624
6923430: G1: assert(res != 0,"This should have worked.")
johnc
parents:
1972
diff
changeset
|
619 init_ct_freq_table(_g1->max_capacity()); |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
620 ct_freq_note_card(_ct_bs->index_for(start)); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
621 #endif |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
622 |
|
4071
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
623 OopsInHeapRegionClosure* oops_in_heap_closure = NULL; |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
624 if (check_for_refs_into_cset) { |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
625 // ConcurrentG1RefineThreads have worker numbers larger than what |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
626 // _cset_rs_update_cl[] is set up to handle. But those threads should |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
627 // only be active outside of a collection which means that when they |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
628 // reach here they should have check_for_refs_into_cset == false. |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
629 assert((size_t)worker_i < n_workers(), "index of worker larger than _cset_rs_update_cl[].length"); |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
630 oops_in_heap_closure = _cset_rs_update_cl[worker_i]; |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
631 } |
| 4839 | 632 G1UpdateRSOrPushRefOopClosure update_rs_oop_cl(_g1, |
| 633 _g1->g1_rem_set(), | |
| 634 oops_in_heap_closure, | |
| 635 check_for_refs_into_cset, | |
| 636 worker_i); | |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
637 update_rs_oop_cl.set_from(r); |
| 1705 | 638 |
| 4839 | 639 G1TriggerClosure trigger_cl; |
|
3983
811ec3d0833b
7097053: G1: assert(da ? referent->is_oop() : referent->is_oop_or_null()) failed: referenceProcessor.cpp:1054
johnc
parents:
3979
diff
changeset
|
640 FilterIntoCSClosure into_cs_cl(NULL, _g1, &trigger_cl); |
| 4839 | 641 G1InvokeIfNotTriggeredClosure invoke_cl(&trigger_cl, &into_cs_cl); |
| 642 G1Mux2Closure mux(&invoke_cl, &update_rs_oop_cl); | |
| 1705 | 643 |
| 644 FilterOutOfRegionClosure filter_then_update_rs_oop_cl(r, | |
| 645 (check_for_refs_into_cset ? | |
| 646 (OopClosure*)&mux : | |
| 647 (OopClosure*)&update_rs_oop_cl)); | |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
648 |
|
1666
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
649 // The region for the current card may be a young region. The |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
650 // current card may have been a card that was evicted from the |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
651 // card cache. When the card was inserted into the cache, we had |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
652 // determined that its region was non-young. While in the cache, |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
653 // the region may have been freed during a cleanup pause, reallocated |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
654 // and tagged as young. |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
655 // |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
656 // We wish to filter out cards for such a region but the current |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
657 // thread, if we're running concurrently, may "see" the young type |
|
1666
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
658 // change at any time (so an earlier "is_young" check may pass or |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
659 // fail arbitrarily). We tell the iteration code to perform this |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
660 // filtering when it has been determined that there has been an actual |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
661 // allocation in this region and making it safe to check the young type. |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
662 bool filter_young = true; |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
663 |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
664 HeapWord* stop_point = |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
665 r->oops_on_card_seq_iterate_careful(dirtyRegion, |
|
1666
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
666 &filter_then_update_rs_oop_cl, |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
667 filter_young, |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
668 card_ptr); |
|
1666
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
669 |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
670 // If stop_point is non-null, then we encountered an unallocated region |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
671 // (perhaps the unfilled portion of a TLAB.) For now, we'll dirty the |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
672 // card and re-enqueue: if we put off the card until a GC pause, then the |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
673 // unallocated portion will be filled in. Alternatively, we might try |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
674 // the full complexity of the technique used in "regular" precleaning. |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
675 if (stop_point != NULL) { |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
676 // The card might have gotten re-dirtied and re-enqueued while we |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
677 // worked. (In fact, it's pretty likely.) |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
678 if (*card_ptr != CardTableModRefBS::dirty_card_val()) { |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
679 *card_ptr = CardTableModRefBS::dirty_card_val(); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
680 MutexLockerEx x(Shared_DirtyCardQ_lock, |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
681 Mutex::_no_safepoint_check_flag); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
682 DirtyCardQueue* sdcq = |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
683 JavaThread::dirty_card_queue_set().shared_dirty_card_queue(); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
684 sdcq->enqueue(card_ptr); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
685 } |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
686 } else { |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
687 _conc_refine_cards++; |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
688 } |
| 1705 | 689 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
690 // This gets set to true if the card being refined has |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
691 // references that point into the collection set. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
692 bool has_refs_into_cset = trigger_cl.triggered(); |
| 342 | 693 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
694 // We should only be detecting that the card contains references |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
695 // that point into the collection set if the current thread is |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
696 // a GC worker thread. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
697 assert(!has_refs_into_cset || SafepointSynchronize::is_at_safepoint(), |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
698 "invalid result at non safepoint"); |
| 1705 | 699 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
700 return has_refs_into_cset; |
| 342 | 701 } |
| 702 | |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
703 void G1RemSet::print_periodic_summary_info() { |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
704 G1RemSetSummary current; |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
705 current.initialize(this, n_workers()); |
| 342 | 706 |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
707 _prev_period_summary.subtract_from(¤t); |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
708 print_summary_info(&_prev_period_summary); |
| 342 | 709 |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
710 _prev_period_summary.set(¤t); |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
711 } |
| 794 | 712 |
| 1861 | 713 void G1RemSet::print_summary_info() { |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
714 G1RemSetSummary current; |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
715 current.initialize(this, n_workers()); |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
716 |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
717 print_summary_info(¤t, " Cumulative RS summary"); |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
718 } |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
719 |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
720 void G1RemSet::print_summary_info(G1RemSetSummary * summary, const char * header) { |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
721 assert(summary != NULL, "just checking"); |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
722 |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
723 if (header != NULL) { |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
724 gclog_or_tty->print_cr("%s", header); |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
725 } |
| 342 | 726 |
| 727 #if CARD_REPEAT_HISTO | |
| 728 gclog_or_tty->print_cr("\nG1 card_repeat count histogram: "); | |
| 729 gclog_or_tty->print_cr(" # of repeats --> # of cards with that number."); | |
| 730 card_repeat_count.print_on(gclog_or_tty); | |
| 731 #endif | |
| 732 | |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
733 summary->print_on(gclog_or_tty); |
| 342 | 734 } |
| 1705 | 735 |
| 1861 | 736 void G1RemSet::prepare_for_verify() { |
|
637
25e146966e7c
6817419: G1: Enable extensive verification for humongous regions
iveresov
parents:
626
diff
changeset
|
737 if (G1HRRSFlushLogBuffersOnVerify && |
|
25e146966e7c
6817419: G1: Enable extensive verification for humongous regions
iveresov
parents:
626
diff
changeset
|
738 (VerifyBeforeGC || VerifyAfterGC) |
|
25e146966e7c
6817419: G1: Enable extensive verification for humongous regions
iveresov
parents:
626
diff
changeset
|
739 && !_g1->full_collection()) { |
| 342 | 740 cleanupHRRS(); |
| 741 _g1->set_refine_cte_cl_concurrency(false); | |
| 742 if (SafepointSynchronize::is_at_safepoint()) { | |
| 743 DirtyCardQueueSet& dcqs = JavaThread::dirty_card_queue_set(); | |
| 744 dcqs.concatenate_logs(); | |
| 745 } | |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
746 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
747 G1HotCardCache* hot_card_cache = _cg1r->hot_card_cache(); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
748 bool use_hot_card_cache = hot_card_cache->use_cache(); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
749 hot_card_cache->set_use_cache(false); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
750 |
| 1705 | 751 DirtyCardQueue into_cset_dcq(&_g1->into_cset_dirty_card_queue_set()); |
| 752 updateRS(&into_cset_dcq, 0); | |
| 753 _g1->into_cset_dirty_card_queue_set().clear(); | |
|
637
25e146966e7c
6817419: G1: Enable extensive verification for humongous regions
iveresov
parents:
626
diff
changeset
|
754 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
755 hot_card_cache->set_use_cache(use_hot_card_cache); |
|
637
25e146966e7c
6817419: G1: Enable extensive verification for humongous regions
iveresov
parents:
626
diff
changeset
|
756 assert(JavaThread::dirty_card_queue_set().completed_buffers_num() == 0, "All should be consumed"); |
| 342 | 757 } |
| 758 } |