changeset 17088:6e27f9d92dc5

[SPARC] Findbugs/checkstyle
author Stefan Anzinger <stefan.anzinger@oracle.com>
date Tue, 09 Sep 2014 15:41:27 -0700
parents 4faf9bdb9973
children 245c1ceb8221
files graal/com.oracle.graal.api.meta/src/com/oracle/graal/api/meta/RawConstant.java graal/com.oracle.graal.compiler.sparc.test/src/com/oracle/graal/compiler/sparc/test/SPARCAllocatorTest.java graal/com.oracle.graal.compiler.sparc/src/com/oracle/graal/compiler/sparc/SPARCLIRGenerator.java graal/com.oracle.graal.lir.sparc/src/com/oracle/graal/lir/sparc/SPARCArithmetic.java graal/com.oracle.graal.lir.sparc/src/com/oracle/graal/lir/sparc/SPARCMove.java graal/com.oracle.graal.lir.sparc/src/com/oracle/graal/lir/sparc/SPARCSaveRegistersOp.java
diffstat 6 files changed, 25 insertions(+), 24 deletions(-) [+]
line wrap: on
line diff
--- a/graal/com.oracle.graal.api.meta/src/com/oracle/graal/api/meta/RawConstant.java	Tue Sep 09 14:31:36 2014 -0700
+++ b/graal/com.oracle.graal.api.meta/src/com/oracle/graal/api/meta/RawConstant.java	Tue Sep 09 15:41:27 2014 -0700
@@ -1,3 +1,25 @@
+/*
+ * Copyright (c) 2009, 2014, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
 package com.oracle.graal.api.meta;
 
 public class RawConstant extends PrimitiveConstant {
--- a/graal/com.oracle.graal.compiler.sparc.test/src/com/oracle/graal/compiler/sparc/test/SPARCAllocatorTest.java	Tue Sep 09 14:31:36 2014 -0700
+++ b/graal/com.oracle.graal.compiler.sparc.test/src/com/oracle/graal/compiler/sparc/test/SPARCAllocatorTest.java	Tue Sep 09 15:41:27 2014 -0700
@@ -55,7 +55,7 @@
 
     @Test
     public void test3() {
-        test("test3snippet", 3, 1, 0);
+        test("test3snippet", 3, 0, 0);
     }
 
     public static long test3snippet(long x) {
--- a/graal/com.oracle.graal.compiler.sparc/src/com/oracle/graal/compiler/sparc/SPARCLIRGenerator.java	Tue Sep 09 14:31:36 2014 -0700
+++ b/graal/com.oracle.graal.compiler.sparc/src/com/oracle/graal/compiler/sparc/SPARCLIRGenerator.java	Tue Sep 09 15:41:27 2014 -0700
@@ -62,7 +62,6 @@
 import com.oracle.graal.lir.sparc.SPARCMove.StackLoadAddressOp;
 import com.oracle.graal.phases.util.*;
 import com.oracle.graal.sparc.*;
-import com.oracle.graal.sparc.SPARC.*;
 
 /**
  * This class implements the SPARC specific portion of the LIR generator.
@@ -866,13 +865,8 @@
     }
 
     private void moveBetweenFpGp(AllocatableValue dst, AllocatableValue src) {
-// boolean isVis3 = getArchitecture().features.contains(CPUFeature.VIS3);
-// if (isVis3) {
-//
-// } else {
         StackSlot tempSlot = getTempSlot(LIRKind.derive(dst));
         append(new MoveFpGp(dst, src, tempSlot));
-// }
     }
 
     private StackSlot getTempSlot(LIRKind kind) {
--- a/graal/com.oracle.graal.lir.sparc/src/com/oracle/graal/lir/sparc/SPARCArithmetic.java	Tue Sep 09 14:31:36 2014 -0700
+++ b/graal/com.oracle.graal.lir.sparc/src/com/oracle/graal/lir/sparc/SPARCArithmetic.java	Tue Sep 09 15:41:27 2014 -0700
@@ -684,18 +684,6 @@
                     new Fsubs(asFloatReg(dst), asFloatReg(dst), asFloatReg(dst)).emit(masm);
                     masm.bind(notOrdered);
                     break;
-// case MOV_D2L:
-// new Movdtox(asDoubleReg(src), asLongReg(dst)).emit(masm);
-// break;
-// case MOV_L2D:
-// new Movxtod(asLongReg(src), asDoubleReg(dst)).emit(masm);
-// break;
-// case MOV_F2I:
-// new Movstosw(asFloatReg(src), asIntReg(dst)).emit(masm);
-// break;
-// case MOV_I2F:
-// new Movwtos(asIntReg(src), asFloatReg(dst)).emit(masm);
-// break;
                 case D2L:
                     new Fcmp(CC.Fcc0, Opfs.Fcmpd, asDoubleReg(src), asDoubleReg(src)).emit(masm);
                     new Fbo(false, notOrdered).emit(masm);
--- a/graal/com.oracle.graal.lir.sparc/src/com/oracle/graal/lir/sparc/SPARCMove.java	Tue Sep 09 14:31:36 2014 -0700
+++ b/graal/com.oracle.graal.lir.sparc/src/com/oracle/graal/lir/sparc/SPARCMove.java	Tue Sep 09 15:41:27 2014 -0700
@@ -643,7 +643,7 @@
                     if (input.isDefaultForKind()) {
                         new Clr(asLongReg(result)).emit(masm);
                     } else if (isSimm13(input.asLong())) {
-                        new Or(g0, input.asInt(), asLongReg(result)).emit(masm);
+                        new Or(g0, (int) input.asLong(), asLongReg(result)).emit(masm);
                     } else {
                         new Setx(input.asLong(), asLongReg(result)).emit(masm);
                     }
--- a/graal/com.oracle.graal.lir.sparc/src/com/oracle/graal/lir/sparc/SPARCSaveRegistersOp.java	Tue Sep 09 14:31:36 2014 -0700
+++ b/graal/com.oracle.graal.lir.sparc/src/com/oracle/graal/lir/sparc/SPARCSaveRegistersOp.java	Tue Sep 09 15:41:27 2014 -0700
@@ -27,11 +27,8 @@
 import java.util.*;
 
 import com.oracle.graal.api.code.*;
-import com.oracle.graal.api.meta.*;
-import com.oracle.graal.asm.sparc.SPARCAssembler.Lddf;
-import com.oracle.graal.asm.sparc.SPARCAssembler.Movxtod;
+import com.oracle.graal.asm.sparc.SPARCAssembler.*;
 import com.oracle.graal.asm.sparc.*;
-import com.oracle.graal.asm.sparc.SPARCAssembler.Stx;
 import com.oracle.graal.lir.*;
 import com.oracle.graal.lir.StandardOp.SaveRegistersOp;
 import com.oracle.graal.lir.asm.*;