Mercurial > hg > graal-compiler
changeset 391:ab4a7734b9c4
6753547: NUMA allocator: Invalid chunk size computation during adaptive resizing
Summary: The per-lgrp chuck size can be incorrectly computed (causing an assertion failure) because of the non-associativity of the floating point operations. The fix is to rearrange the operations.
Reviewed-by: ysr
| author | iveresov |
|---|---|
| date | Mon, 06 Oct 2008 20:59:16 -0700 |
| parents | cc68c8e9b309 |
| children | 05366dad12cf |
| files | src/share/vm/gc_implementation/shared/mutableNUMASpace.cpp |
| diffstat | 1 files changed, 3 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/src/share/vm/gc_implementation/shared/mutableNUMASpace.cpp Mon Oct 06 13:16:35 2008 -0400 +++ b/src/share/vm/gc_implementation/shared/mutableNUMASpace.cpp Mon Oct 06 20:59:16 2008 -0700 @@ -391,6 +391,8 @@ } // Produce a new chunk size. page_size() aligned. +// This function is expected to be called on sequence of i's from 0 to +// lgrp_spaces()->length(). size_t MutableNUMASpace::adaptive_chunk_size(int i, size_t limit) { size_t pages_available = base_space_size(); for (int j = 0; j < i; j++) { @@ -405,7 +407,7 @@ size_t chunk_size = 0; if (alloc_rate > 0) { LGRPSpace *ls = lgrp_spaces()->at(i); - chunk_size = (size_t)(ls->alloc_rate()->average() * pages_available / alloc_rate) * page_size(); + chunk_size = (size_t)(ls->alloc_rate()->average() / alloc_rate * pages_available) * page_size(); } chunk_size = MAX2(chunk_size, page_size());