Mercurial > hg > graal-jvmci-8
annotate src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp @ 4827:2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
Summary: There is a high number of mispredicted branches associated with calling BitMap::iteratate() from within CMBitMapRO::iterate(). Implement a version of CMBitMapRO::iterate() directly using inline-able routines.
Reviewed-by: tonyp, iveresov
| author | johnc |
|---|---|
| date | Fri, 13 Jan 2012 13:27:48 -0800 |
| parents | 2ace1c4ee8da |
| children | d30fa85f9994 |
| rev | line source |
|---|---|
| 3771 | 1 /* |
|
4787
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
2 * Copyright (c) 2001, 2012, Oracle and/or its affiliates. All rights reserved. |
| 3771 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
| 19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | |
| 20 * or visit www.oracle.com if you need additional information or have any | |
| 21 * questions. | |
| 22 * | |
| 23 */ | |
| 24 | |
| 25 #ifndef SHARE_VM_GC_IMPLEMENTATION_G1_CONCURRENTMARK_INLINE_HPP | |
| 26 #define SHARE_VM_GC_IMPLEMENTATION_G1_CONCURRENTMARK_INLINE_HPP | |
| 27 | |
| 28 #include "gc_implementation/g1/concurrentMark.hpp" | |
| 29 #include "gc_implementation/g1/g1CollectedHeap.inline.hpp" | |
| 30 | |
|
4827
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
31 inline bool CMBitMapRO::iterate(BitMapClosure* cl, MemRegion mr) { |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
32 HeapWord* start_addr = MAX2(startWord(), mr.start()); |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
33 HeapWord* end_addr = MIN2(endWord(), mr.end()); |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
34 |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
35 if (end_addr > start_addr) { |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
36 // Right-open interval [start-offset, end-offset). |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
37 BitMap::idx_t start_offset = heapWordToOffset(start_addr); |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
38 BitMap::idx_t end_offset = heapWordToOffset(end_addr); |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
39 |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
40 start_offset = _bm.get_next_one_offset(start_offset, end_offset); |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
41 while (start_offset < end_offset) { |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
42 HeapWord* obj_addr = offsetToHeapWord(start_offset); |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
43 oop obj = (oop) obj_addr; |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
44 if (!cl->do_bit(start_offset)) { |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
45 return false; |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
46 } |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
47 HeapWord* next_addr = MIN2(obj_addr + obj->size(), end_addr); |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
48 BitMap::idx_t next_offset = heapWordToOffset(next_addr); |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
49 start_offset = _bm.get_next_one_offset(next_offset, end_offset); |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
50 } |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
51 } |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
52 return true; |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
53 } |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
54 |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
55 inline bool CMBitMapRO::iterate(BitMapClosure* cl) { |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
56 MemRegion mr(startWord(), sizeInWords()); |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
57 return iterate(cl, mr); |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
58 } |
|
2e966d967c5c
7121547: G1: High number mispredicted branches while iterating over the marking bitmap
johnc
parents:
4787
diff
changeset
|
59 |
| 3771 | 60 inline void CMTask::push(oop obj) { |
| 61 HeapWord* objAddr = (HeapWord*) obj; | |
| 62 assert(_g1h->is_in_g1_reserved(objAddr), "invariant"); | |
| 63 assert(!_g1h->is_on_master_free_list( | |
| 64 _g1h->heap_region_containing((HeapWord*) objAddr)), "invariant"); | |
| 65 assert(!_g1h->is_obj_ill(obj), "invariant"); | |
| 66 assert(_nextMarkBitMap->isMarked(objAddr), "invariant"); | |
| 67 | |
| 68 if (_cm->verbose_high()) { | |
| 69 gclog_or_tty->print_cr("[%d] pushing "PTR_FORMAT, _task_id, (void*) obj); | |
| 70 } | |
| 71 | |
| 72 if (!_task_queue->push(obj)) { | |
| 73 // The local task queue looks full. We need to push some entries | |
| 74 // to the global stack. | |
| 75 | |
| 76 if (_cm->verbose_medium()) { | |
| 77 gclog_or_tty->print_cr("[%d] task queue overflow, " | |
| 78 "moving entries to the global stack", | |
| 79 _task_id); | |
| 80 } | |
| 81 move_entries_to_global_stack(); | |
| 82 | |
| 83 // this should succeed since, even if we overflow the global | |
| 84 // stack, we should have definitely removed some entries from the | |
| 85 // local queue. So, there must be space on it. | |
| 86 bool success = _task_queue->push(obj); | |
| 87 assert(success, "invariant"); | |
| 88 } | |
| 89 | |
| 90 statsOnly( int tmp_size = _task_queue->size(); | |
|
3776
23d434c6290d
7055073: G1: code cleanup in the concurrentMark.* files
tonyp
parents:
3771
diff
changeset
|
91 if (tmp_size > _local_max_size) { |
| 3771 | 92 _local_max_size = tmp_size; |
|
3776
23d434c6290d
7055073: G1: code cleanup in the concurrentMark.* files
tonyp
parents:
3771
diff
changeset
|
93 } |
| 3771 | 94 ++_local_pushes ); |
| 95 } | |
| 96 | |
| 97 // This determines whether the method below will check both the local | |
| 98 // and global fingers when determining whether to push on the stack a | |
| 99 // gray object (value 1) or whether it will only check the global one | |
| 100 // (value 0). The tradeoffs are that the former will be a bit more | |
| 101 // accurate and possibly push less on the stack, but it might also be | |
| 102 // a little bit slower. | |
| 103 | |
| 104 #define _CHECK_BOTH_FINGERS_ 1 | |
| 105 | |
| 106 inline void CMTask::deal_with_reference(oop obj) { | |
| 107 if (_cm->verbose_high()) { | |
| 108 gclog_or_tty->print_cr("[%d] we're dealing with reference = "PTR_FORMAT, | |
| 109 _task_id, (void*) obj); | |
| 110 } | |
| 111 | |
| 112 ++_refs_reached; | |
| 113 | |
| 114 HeapWord* objAddr = (HeapWord*) obj; | |
| 115 assert(obj->is_oop_or_null(true /* ignore mark word */), "Error"); | |
| 116 if (_g1h->is_in_g1_reserved(objAddr)) { | |
| 117 assert(obj != NULL, "null check is implicit"); | |
| 118 if (!_nextMarkBitMap->isMarked(objAddr)) { | |
| 119 // Only get the containing region if the object is not marked on the | |
| 120 // bitmap (otherwise, it's a waste of time since we won't do | |
| 121 // anything with it). | |
| 122 HeapRegion* hr = _g1h->heap_region_containing_raw(obj); | |
| 123 if (!hr->obj_allocated_since_next_marking(obj)) { | |
| 124 if (_cm->verbose_high()) { | |
| 125 gclog_or_tty->print_cr("[%d] "PTR_FORMAT" is not considered marked", | |
| 126 _task_id, (void*) obj); | |
| 127 } | |
| 128 | |
| 129 // we need to mark it first | |
| 130 if (_nextMarkBitMap->parMark(objAddr)) { | |
| 131 // No OrderAccess:store_load() is needed. It is implicit in the | |
| 132 // CAS done in parMark(objAddr) above | |
| 133 HeapWord* global_finger = _cm->finger(); | |
| 134 | |
| 135 #if _CHECK_BOTH_FINGERS_ | |
| 136 // we will check both the local and global fingers | |
| 137 | |
| 138 if (_finger != NULL && objAddr < _finger) { | |
| 139 if (_cm->verbose_high()) { | |
| 140 gclog_or_tty->print_cr("[%d] below the local finger ("PTR_FORMAT"), " | |
| 141 "pushing it", _task_id, _finger); | |
| 142 } | |
| 143 push(obj); | |
| 144 } else if (_curr_region != NULL && objAddr < _region_limit) { | |
| 145 // do nothing | |
| 146 } else if (objAddr < global_finger) { | |
| 147 // Notice that the global finger might be moving forward | |
| 148 // concurrently. This is not a problem. In the worst case, we | |
| 149 // mark the object while it is above the global finger and, by | |
| 150 // the time we read the global finger, it has moved forward | |
| 151 // passed this object. In this case, the object will probably | |
| 152 // be visited when a task is scanning the region and will also | |
| 153 // be pushed on the stack. So, some duplicate work, but no | |
| 154 // correctness problems. | |
| 155 | |
| 156 if (_cm->verbose_high()) { | |
| 157 gclog_or_tty->print_cr("[%d] below the global finger " | |
| 158 "("PTR_FORMAT"), pushing it", | |
| 159 _task_id, global_finger); | |
| 160 } | |
| 161 push(obj); | |
| 162 } else { | |
| 163 // do nothing | |
| 164 } | |
| 165 #else // _CHECK_BOTH_FINGERS_ | |
| 166 // we will only check the global finger | |
| 167 | |
| 168 if (objAddr < global_finger) { | |
| 169 // see long comment above | |
| 170 | |
| 171 if (_cm->verbose_high()) { | |
| 172 gclog_or_tty->print_cr("[%d] below the global finger " | |
| 173 "("PTR_FORMAT"), pushing it", | |
| 174 _task_id, global_finger); | |
| 175 } | |
| 176 push(obj); | |
| 177 } | |
| 178 #endif // _CHECK_BOTH_FINGERS_ | |
| 179 } | |
| 180 } | |
| 181 } | |
| 182 } | |
| 183 } | |
| 184 | |
|
4787
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
185 inline void ConcurrentMark::markPrev(oop p) { |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
186 assert(!_prevMarkBitMap->isMarked((HeapWord*) p), "sanity"); |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
187 // Note we are overriding the read-only view of the prev map here, via |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
188 // the cast. |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
189 ((CMBitMap*)_prevMarkBitMap)->mark((HeapWord*) p); |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
190 } |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
191 |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
192 inline void ConcurrentMark::markNext(oop p) { |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
193 assert(!_nextMarkBitMap->isMarked((HeapWord*) p), "sanity"); |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
194 _nextMarkBitMap->mark((HeapWord*) p); |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
195 } |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
196 |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
197 inline void ConcurrentMark::grayRoot(oop obj, size_t word_size) { |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
198 HeapWord* addr = (HeapWord*) obj; |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
199 |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
200 // Currently we don't do anything with word_size but we will use it |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
201 // in the very near future in the liveness calculation piggy-backing |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
202 // changes. |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
203 |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
204 #ifdef ASSERT |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
205 HeapRegion* hr = _g1h->heap_region_containing(addr); |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
206 assert(hr != NULL, "sanity"); |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
207 assert(!hr->is_survivor(), "should not allocate survivors during IM"); |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
208 assert(addr < hr->next_top_at_mark_start(), |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
209 err_msg("addr: "PTR_FORMAT" hr: "HR_FORMAT" NTAMS: "PTR_FORMAT, |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
210 addr, HR_FORMAT_PARAMS(hr), hr->next_top_at_mark_start())); |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
211 // We cannot assert that word_size == obj->size() given that obj |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
212 // might not be in a consistent state (another thread might be in |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
213 // the process of copying it). So the best thing we can do is to |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
214 // assert that word_size is under an upper bound which is its |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
215 // containing region's capacity. |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
216 assert(word_size * HeapWordSize <= hr->capacity(), |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
217 err_msg("size: "SIZE_FORMAT" capacity: "SIZE_FORMAT" "HR_FORMAT, |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
218 word_size * HeapWordSize, hr->capacity(), |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
219 HR_FORMAT_PARAMS(hr))); |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
220 #endif // ASSERT |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
221 |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
222 if (!_nextMarkBitMap->isMarked(addr)) { |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
223 _nextMarkBitMap->parMark(addr); |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
224 } |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
225 } |
|
2ace1c4ee8da
6888336: G1: avoid explicitly marking and pushing objects in survivor spaces
tonyp
parents:
3776
diff
changeset
|
226 |
| 3771 | 227 #endif // SHARE_VM_GC_IMPLEMENTATION_G1_CONCURRENTMARK_INLINE_HPP |