Mercurial > hg > graal-jvmci-8
annotate src/share/vm/oops/oop.pcgc.inline.hpp @ 1992:3cd116fd11be
6994628: G1: Test gc/gctests/FinalizeTest05 fails (one live object is finalized)
Summary: The Solaris Studio 12 update 1 C++ compiler was incorrectly re-ordering the reads of an object's mark word in oopDesc::forward_to_atomic(). This opened a small window where one thread could execute the successful CAS path even though another thread had already successfully forwarded the object. This could result in an object being copied twice. The code in oopDesc::forward_to_atomic() was changed to read the mark word once.
Reviewed-by: ysr, tonyp
| author | johnc |
|---|---|
| date | Tue, 07 Dec 2010 16:18:45 -0800 |
| parents | f95d63e2154a |
| children | e5383553fd4e |
| rev | line source |
|---|---|
| 0 | 1 /* |
| 1972 | 2 * Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved. |
| 0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
196
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
196
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
196
diff
changeset
|
21 * questions. |
| 0 | 22 * |
| 23 */ | |
| 24 | |
| 1972 | 25 #ifndef SHARE_VM_OOPS_OOP_PCGC_INLINE_HPP |
| 26 #define SHARE_VM_OOPS_OOP_PCGC_INLINE_HPP | |
| 27 | |
| 28 #ifndef SERIALGC | |
| 29 #include "gc_implementation/parNew/parNewGeneration.hpp" | |
| 30 #include "gc_implementation/parallelScavenge/parallelScavengeHeap.hpp" | |
| 31 #include "gc_implementation/parallelScavenge/psCompactionManager.hpp" | |
| 32 #include "gc_implementation/parallelScavenge/psParallelCompact.hpp" | |
| 33 #include "gc_implementation/parallelScavenge/psScavenge.hpp" | |
| 34 #include "gc_implementation/parallelScavenge/psScavenge.inline.hpp" | |
| 35 #endif | |
| 36 | |
| 0 | 37 inline void oopDesc::update_contents(ParCompactionManager* cm) { |
| 38 // The klass field must be updated before anything else | |
| 39 // can be done. | |
| 40 DEBUG_ONLY(klassOopDesc* original_klass = klass()); | |
| 41 | |
| 42 // Can the option to update and/or copy be moved up in the | |
| 43 // call chain to avoid calling into here? | |
| 44 | |
| 45 if (PSParallelCompact::should_update_klass(klass())) { | |
| 46 update_header(); | |
| 47 assert(klass()->is_klass(), "Not updated correctly"); | |
| 48 } else { | |
| 49 assert(klass()->is_klass(), "Not updated"); | |
| 50 } | |
| 51 | |
| 52 Klass* new_klass = blueprint(); | |
| 53 if (!new_klass->oop_is_typeArray()) { | |
| 54 // It might contain oops beyond the header, so take the virtual call. | |
| 55 new_klass->oop_update_pointers(cm, this); | |
| 56 } | |
| 57 // Else skip it. The typeArrayKlass in the header never needs scavenging. | |
| 58 } | |
| 59 | |
| 60 inline void oopDesc::update_contents(ParCompactionManager* cm, | |
| 61 HeapWord* begin_limit, | |
| 62 HeapWord* end_limit) { | |
| 63 // The klass field must be updated before anything else | |
| 64 // can be done. | |
| 65 debug_only(klassOopDesc* original_klass = klass()); | |
| 66 | |
| 67 update_contents(cm, klass(), begin_limit, end_limit); | |
| 68 } | |
| 69 | |
| 70 inline void oopDesc::update_contents(ParCompactionManager* cm, | |
| 71 klassOop old_klass, | |
| 72 HeapWord* begin_limit, | |
| 73 HeapWord* end_limit) { | |
| 74 | |
| 75 klassOop updated_klass = | |
| 76 PSParallelCompact::summary_data().calc_new_klass(old_klass); | |
| 77 | |
| 78 // Needs to be boundary aware for the 64 bit case | |
| 79 // update_header(); | |
| 80 // The klass has moved. Is the location of the klass | |
| 81 // within the limits? | |
|
113
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
0
diff
changeset
|
82 if ((((HeapWord*)&_metadata._klass) >= begin_limit) && |
|
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
0
diff
changeset
|
83 (((HeapWord*)&_metadata._klass) < end_limit)) { |
| 0 | 84 set_klass(updated_klass); |
| 85 } | |
| 86 | |
| 87 Klass* klass = updated_klass->klass_part(); | |
| 88 if (!klass->oop_is_typeArray()) { | |
| 89 // It might contain oops beyond the header, so take the virtual call. | |
| 90 klass->oop_update_pointers(cm, this, begin_limit, end_limit); | |
| 91 } | |
| 92 // Else skip it. The typeArrayKlass in the header never needs scavenging. | |
| 93 } | |
| 94 | |
| 95 inline void oopDesc::follow_contents(ParCompactionManager* cm) { | |
| 96 assert (PSParallelCompact::mark_bitmap()->is_marked(this), | |
| 97 "should be marked"); | |
| 98 blueprint()->oop_follow_contents(cm, this); | |
| 99 } | |
| 100 | |
| 101 // Used by parallel old GC. | |
| 102 | |
| 103 inline void oopDesc::follow_header(ParCompactionManager* cm) { | |
|
113
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
0
diff
changeset
|
104 if (UseCompressedOops) { |
|
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
0
diff
changeset
|
105 PSParallelCompact::mark_and_push(cm, compressed_klass_addr()); |
|
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
0
diff
changeset
|
106 } else { |
|
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
0
diff
changeset
|
107 PSParallelCompact::mark_and_push(cm, klass_addr()); |
|
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
0
diff
changeset
|
108 } |
| 0 | 109 } |
| 110 | |
| 111 inline oop oopDesc::forward_to_atomic(oop p) { | |
| 112 assert(ParNewGeneration::is_legal_forward_ptr(p), | |
| 113 "illegal forwarding pointer value."); | |
| 114 markOop oldMark = mark(); | |
| 115 markOop forwardPtrMark = markOopDesc::encode_pointer_as_mark(p); | |
| 116 markOop curMark; | |
| 117 | |
| 118 assert(forwardPtrMark->decode_pointer() == p, "encoding must be reversable"); | |
| 119 assert(sizeof(markOop) == sizeof(intptr_t), "CAS below requires this."); | |
| 120 | |
|
1992
3cd116fd11be
6994628: G1: Test gc/gctests/FinalizeTest05 fails (one live object is finalized)
johnc
parents:
1972
diff
changeset
|
121 while (!oldMark->is_marked()) { |
| 0 | 122 curMark = (markOop)Atomic::cmpxchg_ptr(forwardPtrMark, &_mark, oldMark); |
|
1992
3cd116fd11be
6994628: G1: Test gc/gctests/FinalizeTest05 fails (one live object is finalized)
johnc
parents:
1972
diff
changeset
|
123 assert(is_forwarded(), "object should have been forwarded"); |
| 0 | 124 if (curMark == oldMark) { |
| 125 return NULL; | |
| 126 } | |
|
1992
3cd116fd11be
6994628: G1: Test gc/gctests/FinalizeTest05 fails (one live object is finalized)
johnc
parents:
1972
diff
changeset
|
127 // If the CAS was unsuccessful then curMark->is_marked() |
|
3cd116fd11be
6994628: G1: Test gc/gctests/FinalizeTest05 fails (one live object is finalized)
johnc
parents:
1972
diff
changeset
|
128 // should return true as another thread has CAS'd in another |
|
3cd116fd11be
6994628: G1: Test gc/gctests/FinalizeTest05 fails (one live object is finalized)
johnc
parents:
1972
diff
changeset
|
129 // forwarding pointer. |
| 0 | 130 oldMark = curMark; |
| 131 } | |
| 132 return forwardee(); | |
| 133 } | |
| 134 | |
| 135 inline void oopDesc::update_header() { | |
|
113
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
0
diff
changeset
|
136 if (UseCompressedOops) { |
|
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
0
diff
changeset
|
137 PSParallelCompact::adjust_pointer(compressed_klass_addr()); |
|
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
0
diff
changeset
|
138 } else { |
|
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
0
diff
changeset
|
139 PSParallelCompact::adjust_pointer(klass_addr()); |
|
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
0
diff
changeset
|
140 } |
| 0 | 141 } |
| 142 | |
| 143 inline void oopDesc::update_header(HeapWord* beg_addr, HeapWord* end_addr) { | |
|
113
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
0
diff
changeset
|
144 if (UseCompressedOops) { |
|
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
0
diff
changeset
|
145 PSParallelCompact::adjust_pointer(compressed_klass_addr(), |
|
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
0
diff
changeset
|
146 beg_addr, end_addr); |
|
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
0
diff
changeset
|
147 } else { |
|
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
0
diff
changeset
|
148 PSParallelCompact::adjust_pointer(klass_addr(), beg_addr, end_addr); |
|
ba764ed4b6f2
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
0
diff
changeset
|
149 } |
| 0 | 150 } |
| 1972 | 151 |
| 152 #endif // SHARE_VM_OOPS_OOP_PCGC_INLINE_HPP |