Mercurial > hg > graal-jvmci-8
annotate src/share/vm/opto/loopopts.cpp @ 23799:535618ab1c04
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
Summary: Emit CastII to make narrow ConvI2L dependent on the corresponding range check.
Reviewed-by: kvn, roland
author | thartmann |
---|---|
date | Wed, 27 Jan 2016 09:02:51 +0100 |
parents | b6585ac86988 |
children | 5c3f2bcc3b94 |
rev | line source |
---|---|
0 | 1 /* |
17467
55fb97c4c58d
8029233: Update copyright year to match last edit in jdk8 hotspot repository for 2013
mikael
parents:
13076
diff
changeset
|
2 * Copyright (c) 1999, 2013, Oracle and/or its affiliates. All rights reserved. |
0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 * | |
5 * This code is free software; you can redistribute it and/or modify it | |
6 * under the terms of the GNU General Public License version 2 only, as | |
7 * published by the Free Software Foundation. | |
8 * | |
9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
12 * version 2 for more details (a copy is included in the LICENSE file that | |
13 * accompanied this code). | |
14 * | |
15 * You should have received a copy of the GNU General Public License version | |
16 * 2 along with this work; if not, write to the Free Software Foundation, | |
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
18 * | |
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1254
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1254
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1254
diff
changeset
|
21 * questions. |
0 | 22 * |
23 */ | |
24 | |
1972 | 25 #include "precompiled.hpp" |
26 #include "memory/allocation.inline.hpp" | |
27 #include "opto/addnode.hpp" | |
28 #include "opto/connode.hpp" | |
29 #include "opto/divnode.hpp" | |
30 #include "opto/loopnode.hpp" | |
4047 | 31 #include "opto/matcher.hpp" |
1972 | 32 #include "opto/mulnode.hpp" |
33 #include "opto/rootnode.hpp" | |
34 #include "opto/subnode.hpp" | |
0 | 35 |
36 //============================================================================= | |
37 //------------------------------split_thru_phi--------------------------------- | |
38 // Split Node 'n' through merge point if there is enough win. | |
39 Node *PhaseIdealLoop::split_thru_phi( Node *n, Node *region, int policy ) { | |
69 | 40 if (n->Opcode() == Op_ConvI2L && n->bottom_type() != TypeLong::LONG) { |
41 // ConvI2L may have type information on it which is unsafe to push up | |
42 // so disable this for now | |
43 return NULL; | |
44 } | |
13076
f675976a61e7
8028198: SIGSEGV in PhaseIdealLoop::build_loop_late_post
rbackman
parents:
12956
diff
changeset
|
45 |
0 | 46 int wins = 0; |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
47 assert(!n->is_CFG(), ""); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
48 assert(region->is_Region(), ""); |
64
b8f5ba577b02
6673473: (Escape Analysis) Add the instance's field information to PhiNode
kvn
parents:
35
diff
changeset
|
49 |
b8f5ba577b02
6673473: (Escape Analysis) Add the instance's field information to PhiNode
kvn
parents:
35
diff
changeset
|
50 const Type* type = n->bottom_type(); |
b8f5ba577b02
6673473: (Escape Analysis) Add the instance's field information to PhiNode
kvn
parents:
35
diff
changeset
|
51 const TypeOopPtr *t_oop = _igvn.type(n)->isa_oopptr(); |
b8f5ba577b02
6673473: (Escape Analysis) Add the instance's field information to PhiNode
kvn
parents:
35
diff
changeset
|
52 Node *phi; |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
53 if (t_oop != NULL && t_oop->is_known_instance_field()) { |
64
b8f5ba577b02
6673473: (Escape Analysis) Add the instance's field information to PhiNode
kvn
parents:
35
diff
changeset
|
54 int iid = t_oop->instance_id(); |
b8f5ba577b02
6673473: (Escape Analysis) Add the instance's field information to PhiNode
kvn
parents:
35
diff
changeset
|
55 int index = C->get_alias_index(t_oop); |
b8f5ba577b02
6673473: (Escape Analysis) Add the instance's field information to PhiNode
kvn
parents:
35
diff
changeset
|
56 int offset = t_oop->offset(); |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
57 phi = new (C) PhiNode(region, type, NULL, iid, index, offset); |
64
b8f5ba577b02
6673473: (Escape Analysis) Add the instance's field information to PhiNode
kvn
parents:
35
diff
changeset
|
58 } else { |
1254
4ee1c645110e
6924097: assert((_type == Type::MEMORY) == (_adr_type != 0),"adr_type for memory phis only")
kvn
parents:
866
diff
changeset
|
59 phi = PhiNode::make_blank(region, n); |
64
b8f5ba577b02
6673473: (Escape Analysis) Add the instance's field information to PhiNode
kvn
parents:
35
diff
changeset
|
60 } |
0 | 61 uint old_unique = C->unique(); |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
62 for (uint i = 1; i < region->req(); i++) { |
0 | 63 Node *x; |
64 Node* the_clone = NULL; | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
65 if (region->in(i) == C->top()) { |
0 | 66 x = C->top(); // Dead path? Use a dead data op |
67 } else { | |
68 x = n->clone(); // Else clone up the data op | |
69 the_clone = x; // Remember for possible deletion. | |
70 // Alter data node to use pre-phi inputs | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
71 if (n->in(0) == region) |
0 | 72 x->set_req( 0, region->in(i) ); |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
73 for (uint j = 1; j < n->req(); j++) { |
0 | 74 Node *in = n->in(j); |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
75 if (in->is_Phi() && in->in(0) == region) |
0 | 76 x->set_req( j, in->in(i) ); // Use pre-Phi input for the clone |
77 } | |
78 } | |
79 // Check for a 'win' on some paths | |
80 const Type *t = x->Value(&_igvn); | |
81 | |
82 bool singleton = t->singleton(); | |
83 | |
84 // A TOP singleton indicates that there are no possible values incoming | |
85 // along a particular edge. In most cases, this is OK, and the Phi will | |
86 // be eliminated later in an Ideal call. However, we can't allow this to | |
87 // happen if the singleton occurs on loop entry, as the elimination of | |
88 // the PhiNode may cause the resulting node to migrate back to a previous | |
89 // loop iteration. | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
90 if (singleton && t == Type::TOP) { |
0 | 91 // Is_Loop() == false does not confirm the absence of a loop (e.g., an |
92 // irreducible loop may not be indicated by an affirmative is_Loop()); | |
93 // therefore, the only top we can split thru a phi is on a backedge of | |
94 // a loop. | |
95 singleton &= region->is_Loop() && (i != LoopNode::EntryControl); | |
96 } | |
97 | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
98 if (singleton) { |
0 | 99 wins++; |
100 x = ((PhaseGVN&)_igvn).makecon(t); | |
101 } else { | |
102 // We now call Identity to try to simplify the cloned node. | |
103 // Note that some Identity methods call phase->type(this). | |
104 // Make sure that the type array is big enough for | |
105 // our new node, even though we may throw the node away. | |
106 // (Note: This tweaking with igvn only works because x is a new node.) | |
107 _igvn.set_type(x, t); | |
293
c3e045194476
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
253
diff
changeset
|
108 // If x is a TypeNode, capture any more-precise type permanently into Node |
605 | 109 // otherwise it will be not updated during igvn->transform since |
293
c3e045194476
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
253
diff
changeset
|
110 // igvn->type(x) is set to x->Value() already. |
c3e045194476
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
253
diff
changeset
|
111 x->raise_bottom_type(t); |
0 | 112 Node *y = x->Identity(&_igvn); |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
113 if (y != x) { |
0 | 114 wins++; |
115 x = y; | |
116 } else { | |
117 y = _igvn.hash_find(x); | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
118 if (y) { |
0 | 119 wins++; |
120 x = y; | |
121 } else { | |
122 // Else x is a new node we are keeping | |
123 // We do not need register_new_node_with_optimizer | |
124 // because set_type has already been called. | |
125 _igvn._worklist.push(x); | |
126 } | |
127 } | |
128 } | |
129 if (x != the_clone && the_clone != NULL) | |
130 _igvn.remove_dead_node(the_clone); | |
131 phi->set_req( i, x ); | |
132 } | |
133 // Too few wins? | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
134 if (wins <= policy) { |
0 | 135 _igvn.remove_dead_node(phi); |
136 return NULL; | |
137 } | |
138 | |
139 // Record Phi | |
140 register_new_node( phi, region ); | |
141 | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
142 for (uint i2 = 1; i2 < phi->req(); i2++) { |
0 | 143 Node *x = phi->in(i2); |
144 // If we commoned up the cloned 'x' with another existing Node, | |
145 // the existing Node picks up a new use. We need to make the | |
146 // existing Node occur higher up so it dominates its uses. | |
147 Node *old_ctrl; | |
148 IdealLoopTree *old_loop; | |
149 | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
150 if (x->is_Con()) { |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
151 // Constant's control is always root. |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
152 set_ctrl(x, C->root()); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
153 continue; |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
154 } |
0 | 155 // The occasional new node |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
156 if (x->_idx >= old_unique) { // Found a new, unplaced node? |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
157 old_ctrl = NULL; |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
158 old_loop = NULL; // Not in any prior loop |
0 | 159 } else { |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
160 old_ctrl = get_ctrl(x); |
0 | 161 old_loop = get_loop(old_ctrl); // Get prior loop |
162 } | |
163 // New late point must dominate new use | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
164 Node *new_ctrl = dom_lca(old_ctrl, region->in(i2)); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
165 if (new_ctrl == old_ctrl) // Nothing is changed |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
166 continue; |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
167 |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
168 IdealLoopTree *new_loop = get_loop(new_ctrl); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
169 |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
170 // Don't move x into a loop if its uses are |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
171 // outside of loop. Otherwise x will be cloned |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
172 // for each use outside of this loop. |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
173 IdealLoopTree *use_loop = get_loop(region); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
174 if (!new_loop->is_member(use_loop) && |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
175 (old_loop == NULL || !new_loop->is_member(old_loop))) { |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
176 // Take early control, later control will be recalculated |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
177 // during next iteration of loop optimizations. |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
178 new_ctrl = get_early_ctrl(x); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
179 new_loop = get_loop(new_ctrl); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
180 } |
0 | 181 // Set new location |
182 set_ctrl(x, new_ctrl); | |
183 // If changing loop bodies, see if we need to collect into new body | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
184 if (old_loop != new_loop) { |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
185 if (old_loop && !old_loop->_child) |
0 | 186 old_loop->_body.yank(x); |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
187 if (!new_loop->_child) |
0 | 188 new_loop->_body.push(x); // Collect body info |
189 } | |
190 } | |
191 | |
192 return phi; | |
193 } | |
194 | |
195 //------------------------------dominated_by------------------------------------ | |
196 // Replace the dominated test with an obvious true or false. Place it on the | |
197 // IGVN worklist for later cleanup. Move control-dependent data Nodes on the | |
198 // live path up to the dominating control. | |
3840
4e761e7e6e12
7070134: Hotspot crashes with sigsegv from PorterStemmer
kvn
parents:
3281
diff
changeset
|
199 void PhaseIdealLoop::dominated_by( Node *prevdom, Node *iff, bool flip, bool exclude_loop_predicate ) { |
0 | 200 #ifndef PRODUCT |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
201 if (VerifyLoopOptimizations && PrintOpto) tty->print_cr("dominating test"); |
0 | 202 #endif |
203 | |
204 | |
205 // prevdom is the dominating projection of the dominating test. | |
206 assert( iff->is_If(), "" ); | |
207 assert( iff->Opcode() == Op_If || iff->Opcode() == Op_CountedLoopEnd, "Check this code when new subtype is added"); | |
208 int pop = prevdom->Opcode(); | |
209 assert( pop == Op_IfFalse || pop == Op_IfTrue, "" ); | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
210 if (flip) { |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
211 if (pop == Op_IfTrue) |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
212 pop = Op_IfFalse; |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
213 else |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
214 pop = Op_IfTrue; |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
215 } |
0 | 216 // 'con' is set to true or false to kill the dominated test. |
217 Node *con = _igvn.makecon(pop == Op_IfTrue ? TypeInt::ONE : TypeInt::ZERO); | |
218 set_ctrl(con, C->root()); // Constant gets a new use | |
219 // Hack the dominated test | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
220 _igvn.replace_input_of(iff, 1, con); |
0 | 221 |
222 // If I dont have a reachable TRUE and FALSE path following the IfNode then | |
223 // I can assume this path reaches an infinite loop. In this case it's not | |
224 // important to optimize the data Nodes - either the whole compilation will | |
225 // be tossed or this path (and all data Nodes) will go dead. | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
226 if (iff->outcnt() != 2) return; |
0 | 227 |
228 // Make control-dependent data Nodes on the live path (path that will remain | |
229 // once the dominated IF is removed) become control-dependent on the | |
230 // dominating projection. | |
3840
4e761e7e6e12
7070134: Hotspot crashes with sigsegv from PorterStemmer
kvn
parents:
3281
diff
changeset
|
231 Node* dp = iff->as_If()->proj_out(pop == Op_IfTrue); |
4e761e7e6e12
7070134: Hotspot crashes with sigsegv from PorterStemmer
kvn
parents:
3281
diff
changeset
|
232 |
4e761e7e6e12
7070134: Hotspot crashes with sigsegv from PorterStemmer
kvn
parents:
3281
diff
changeset
|
233 // Loop predicates may have depending checks which should not |
4e761e7e6e12
7070134: Hotspot crashes with sigsegv from PorterStemmer
kvn
parents:
3281
diff
changeset
|
234 // be skipped. For example, range check predicate has two checks |
4e761e7e6e12
7070134: Hotspot crashes with sigsegv from PorterStemmer
kvn
parents:
3281
diff
changeset
|
235 // for lower and upper bounds. |
8774
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
236 if (dp == NULL) |
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
237 return; |
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
238 |
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
239 ProjNode* dp_proj = dp->as_Proj(); |
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
240 ProjNode* unc_proj = iff->as_If()->proj_out(1 - dp_proj->_con)->as_Proj(); |
3840
4e761e7e6e12
7070134: Hotspot crashes with sigsegv from PorterStemmer
kvn
parents:
3281
diff
changeset
|
241 if (exclude_loop_predicate && |
20701
b6585ac86988
8048170: Test closed/java/text/Normalizer/ConformanceTest.java failed
roland
parents:
20671
diff
changeset
|
242 (unc_proj->is_uncommon_trap_proj(Deoptimization::Reason_predicate) || |
b6585ac86988
8048170: Test closed/java/text/Normalizer/ConformanceTest.java failed
roland
parents:
20671
diff
changeset
|
243 unc_proj->is_uncommon_trap_proj(Deoptimization::Reason_range_check))) { |
b6585ac86988
8048170: Test closed/java/text/Normalizer/ConformanceTest.java failed
roland
parents:
20671
diff
changeset
|
244 // If this is a range check (IfNode::is_range_check), do not |
b6585ac86988
8048170: Test closed/java/text/Normalizer/ConformanceTest.java failed
roland
parents:
20671
diff
changeset
|
245 // reorder because Compile::allow_range_check_smearing might have |
b6585ac86988
8048170: Test closed/java/text/Normalizer/ConformanceTest.java failed
roland
parents:
20671
diff
changeset
|
246 // changed the check. |
3840
4e761e7e6e12
7070134: Hotspot crashes with sigsegv from PorterStemmer
kvn
parents:
3281
diff
changeset
|
247 return; // Let IGVN transformation change control dependence. |
20701
b6585ac86988
8048170: Test closed/java/text/Normalizer/ConformanceTest.java failed
roland
parents:
20671
diff
changeset
|
248 } |
3840
4e761e7e6e12
7070134: Hotspot crashes with sigsegv from PorterStemmer
kvn
parents:
3281
diff
changeset
|
249 |
0 | 250 IdealLoopTree *old_loop = get_loop(dp); |
251 | |
252 for (DUIterator_Fast imax, i = dp->fast_outs(imax); i < imax; i++) { | |
253 Node* cd = dp->fast_out(i); // Control-dependent node | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
254 if (cd->depends_only_on_test()) { |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
255 assert(cd->in(0) == dp, ""); |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
256 _igvn.replace_input_of(cd, 0, prevdom); |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
257 set_early_ctrl(cd); |
0 | 258 IdealLoopTree *new_loop = get_loop(get_ctrl(cd)); |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
259 if (old_loop != new_loop) { |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
260 if (!old_loop->_child) old_loop->_body.yank(cd); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
261 if (!new_loop->_child) new_loop->_body.push(cd); |
0 | 262 } |
263 --i; | |
264 --imax; | |
265 } | |
266 } | |
267 } | |
268 | |
269 //------------------------------has_local_phi_input---------------------------- | |
270 // Return TRUE if 'n' has Phi inputs from its local block and no other | |
271 // block-local inputs (all non-local-phi inputs come from earlier blocks) | |
272 Node *PhaseIdealLoop::has_local_phi_input( Node *n ) { | |
273 Node *n_ctrl = get_ctrl(n); | |
274 // See if some inputs come from a Phi in this block, or from before | |
275 // this block. | |
276 uint i; | |
277 for( i = 1; i < n->req(); i++ ) { | |
278 Node *phi = n->in(i); | |
279 if( phi->is_Phi() && phi->in(0) == n_ctrl ) | |
280 break; | |
281 } | |
282 if( i >= n->req() ) | |
283 return NULL; // No Phi inputs; nowhere to clone thru | |
284 | |
285 // Check for inputs created between 'n' and the Phi input. These | |
286 // must split as well; they have already been given the chance | |
287 // (courtesy of a post-order visit) and since they did not we must | |
288 // recover the 'cost' of splitting them by being very profitable | |
289 // when splitting 'n'. Since this is unlikely we simply give up. | |
290 for( i = 1; i < n->req(); i++ ) { | |
291 Node *m = n->in(i); | |
292 if( get_ctrl(m) == n_ctrl && !m->is_Phi() ) { | |
293 // We allow the special case of AddP's with no local inputs. | |
294 // This allows us to split-up address expressions. | |
295 if (m->is_AddP() && | |
296 get_ctrl(m->in(2)) != n_ctrl && | |
297 get_ctrl(m->in(3)) != n_ctrl) { | |
298 // Move the AddP up to dominating point | |
299 set_ctrl_and_loop(m, find_non_split_ctrl(idom(n_ctrl))); | |
300 continue; | |
301 } | |
302 return NULL; | |
303 } | |
304 } | |
305 | |
306 return n_ctrl; | |
307 } | |
308 | |
309 //------------------------------remix_address_expressions---------------------- | |
310 // Rework addressing expressions to get the most loop-invariant stuff | |
311 // moved out. We'd like to do all associative operators, but it's especially | |
312 // important (common) to do address expressions. | |
313 Node *PhaseIdealLoop::remix_address_expressions( Node *n ) { | |
314 if (!has_ctrl(n)) return NULL; | |
315 Node *n_ctrl = get_ctrl(n); | |
316 IdealLoopTree *n_loop = get_loop(n_ctrl); | |
317 | |
318 // See if 'n' mixes loop-varying and loop-invariant inputs and | |
319 // itself is loop-varying. | |
320 | |
321 // Only interested in binary ops (and AddP) | |
322 if( n->req() < 3 || n->req() > 4 ) return NULL; | |
323 | |
324 Node *n1_ctrl = get_ctrl(n->in( 1)); | |
325 Node *n2_ctrl = get_ctrl(n->in( 2)); | |
326 Node *n3_ctrl = get_ctrl(n->in(n->req() == 3 ? 2 : 3)); | |
327 IdealLoopTree *n1_loop = get_loop( n1_ctrl ); | |
328 IdealLoopTree *n2_loop = get_loop( n2_ctrl ); | |
329 IdealLoopTree *n3_loop = get_loop( n3_ctrl ); | |
330 | |
331 // Does one of my inputs spin in a tighter loop than self? | |
332 if( (n_loop->is_member( n1_loop ) && n_loop != n1_loop) || | |
333 (n_loop->is_member( n2_loop ) && n_loop != n2_loop) || | |
334 (n_loop->is_member( n3_loop ) && n_loop != n3_loop) ) | |
335 return NULL; // Leave well enough alone | |
336 | |
337 // Is at least one of my inputs loop-invariant? | |
338 if( n1_loop == n_loop && | |
339 n2_loop == n_loop && | |
340 n3_loop == n_loop ) | |
341 return NULL; // No loop-invariant inputs | |
342 | |
343 | |
344 int n_op = n->Opcode(); | |
345 | |
346 // Replace expressions like ((V+I) << 2) with (V<<2 + I<<2). | |
347 if( n_op == Op_LShiftI ) { | |
348 // Scale is loop invariant | |
349 Node *scale = n->in(2); | |
350 Node *scale_ctrl = get_ctrl(scale); | |
351 IdealLoopTree *scale_loop = get_loop(scale_ctrl ); | |
352 if( n_loop == scale_loop || !scale_loop->is_member( n_loop ) ) | |
353 return NULL; | |
354 const TypeInt *scale_t = scale->bottom_type()->isa_int(); | |
355 if( scale_t && scale_t->is_con() && scale_t->get_con() >= 16 ) | |
356 return NULL; // Dont bother with byte/short masking | |
357 // Add must vary with loop (else shift would be loop-invariant) | |
358 Node *add = n->in(1); | |
359 Node *add_ctrl = get_ctrl(add); | |
360 IdealLoopTree *add_loop = get_loop(add_ctrl); | |
361 //assert( n_loop == add_loop, "" ); | |
362 if( n_loop != add_loop ) return NULL; // happens w/ evil ZKM loops | |
363 | |
364 // Convert I-V into I+ (0-V); same for V-I | |
365 if( add->Opcode() == Op_SubI && | |
366 _igvn.type( add->in(1) ) != TypeInt::ZERO ) { | |
367 Node *zero = _igvn.intcon(0); | |
368 set_ctrl(zero, C->root()); | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
369 Node *neg = new (C) SubINode( _igvn.intcon(0), add->in(2) ); |
0 | 370 register_new_node( neg, get_ctrl(add->in(2) ) ); |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
371 add = new (C) AddINode( add->in(1), neg ); |
0 | 372 register_new_node( add, add_ctrl ); |
373 } | |
374 if( add->Opcode() != Op_AddI ) return NULL; | |
375 // See if one add input is loop invariant | |
376 Node *add_var = add->in(1); | |
377 Node *add_var_ctrl = get_ctrl(add_var); | |
378 IdealLoopTree *add_var_loop = get_loop(add_var_ctrl ); | |
379 Node *add_invar = add->in(2); | |
380 Node *add_invar_ctrl = get_ctrl(add_invar); | |
381 IdealLoopTree *add_invar_loop = get_loop(add_invar_ctrl ); | |
382 if( add_var_loop == n_loop ) { | |
383 } else if( add_invar_loop == n_loop ) { | |
384 // Swap to find the invariant part | |
385 add_invar = add_var; | |
386 add_invar_ctrl = add_var_ctrl; | |
387 add_invar_loop = add_var_loop; | |
388 add_var = add->in(2); | |
389 Node *add_var_ctrl = get_ctrl(add_var); | |
390 IdealLoopTree *add_var_loop = get_loop(add_var_ctrl ); | |
391 } else // Else neither input is loop invariant | |
392 return NULL; | |
393 if( n_loop == add_invar_loop || !add_invar_loop->is_member( n_loop ) ) | |
394 return NULL; // No invariant part of the add? | |
395 | |
396 // Yes! Reshape address expression! | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
397 Node *inv_scale = new (C) LShiftINode( add_invar, scale ); |
850
fd50a67f97d1
6860469: remix_address_expressions sets incorrect control causing crash in split_if_with_block_post
never
parents:
834
diff
changeset
|
398 Node *inv_scale_ctrl = |
fd50a67f97d1
6860469: remix_address_expressions sets incorrect control causing crash in split_if_with_block_post
never
parents:
834
diff
changeset
|
399 dom_depth(add_invar_ctrl) > dom_depth(scale_ctrl) ? |
fd50a67f97d1
6860469: remix_address_expressions sets incorrect control causing crash in split_if_with_block_post
never
parents:
834
diff
changeset
|
400 add_invar_ctrl : scale_ctrl; |
fd50a67f97d1
6860469: remix_address_expressions sets incorrect control causing crash in split_if_with_block_post
never
parents:
834
diff
changeset
|
401 register_new_node( inv_scale, inv_scale_ctrl ); |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
402 Node *var_scale = new (C) LShiftINode( add_var, scale ); |
0 | 403 register_new_node( var_scale, n_ctrl ); |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
404 Node *var_add = new (C) AddINode( var_scale, inv_scale ); |
0 | 405 register_new_node( var_add, n_ctrl ); |
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
406 _igvn.replace_node( n, var_add ); |
0 | 407 return var_add; |
408 } | |
409 | |
410 // Replace (I+V) with (V+I) | |
411 if( n_op == Op_AddI || | |
412 n_op == Op_AddL || | |
413 n_op == Op_AddF || | |
414 n_op == Op_AddD || | |
415 n_op == Op_MulI || | |
416 n_op == Op_MulL || | |
417 n_op == Op_MulF || | |
418 n_op == Op_MulD ) { | |
419 if( n2_loop == n_loop ) { | |
420 assert( n1_loop != n_loop, "" ); | |
421 n->swap_edges(1, 2); | |
422 } | |
423 } | |
424 | |
425 // Replace ((I1 +p V) +p I2) with ((I1 +p I2) +p V), | |
426 // but not if I2 is a constant. | |
427 if( n_op == Op_AddP ) { | |
428 if( n2_loop == n_loop && n3_loop != n_loop ) { | |
429 if( n->in(2)->Opcode() == Op_AddP && !n->in(3)->is_Con() ) { | |
430 Node *n22_ctrl = get_ctrl(n->in(2)->in(2)); | |
431 Node *n23_ctrl = get_ctrl(n->in(2)->in(3)); | |
432 IdealLoopTree *n22loop = get_loop( n22_ctrl ); | |
433 IdealLoopTree *n23_loop = get_loop( n23_ctrl ); | |
434 if( n22loop != n_loop && n22loop->is_member(n_loop) && | |
435 n23_loop == n_loop ) { | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
436 Node *add1 = new (C) AddPNode( n->in(1), n->in(2)->in(2), n->in(3) ); |
0 | 437 // Stuff new AddP in the loop preheader |
438 register_new_node( add1, n_loop->_head->in(LoopNode::EntryControl) ); | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
439 Node *add2 = new (C) AddPNode( n->in(1), add1, n->in(2)->in(3) ); |
0 | 440 register_new_node( add2, n_ctrl ); |
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
441 _igvn.replace_node( n, add2 ); |
0 | 442 return add2; |
443 } | |
444 } | |
445 } | |
446 | |
447 // Replace (I1 +p (I2 + V)) with ((I1 +p I2) +p V) | |
448 if( n2_loop != n_loop && n3_loop == n_loop ) { | |
449 if( n->in(3)->Opcode() == Op_AddI ) { | |
450 Node *V = n->in(3)->in(1); | |
451 Node *I = n->in(3)->in(2); | |
452 if( is_member(n_loop,get_ctrl(V)) ) { | |
453 } else { | |
454 Node *tmp = V; V = I; I = tmp; | |
455 } | |
456 if( !is_member(n_loop,get_ctrl(I)) ) { | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
457 Node *add1 = new (C) AddPNode( n->in(1), n->in(2), I ); |
0 | 458 // Stuff new AddP in the loop preheader |
459 register_new_node( add1, n_loop->_head->in(LoopNode::EntryControl) ); | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
460 Node *add2 = new (C) AddPNode( n->in(1), add1, V ); |
0 | 461 register_new_node( add2, n_ctrl ); |
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
462 _igvn.replace_node( n, add2 ); |
0 | 463 return add2; |
464 } | |
465 } | |
466 } | |
467 } | |
468 | |
469 return NULL; | |
470 } | |
471 | |
472 //------------------------------conditional_move------------------------------- | |
473 // Attempt to replace a Phi with a conditional move. We have some pretty | |
474 // strict profitability requirements. All Phis at the merge point must | |
475 // be converted, so we can remove the control flow. We need to limit the | |
476 // number of c-moves to a small handful. All code that was in the side-arms | |
477 // of the CFG diamond is now speculatively executed. This code has to be | |
478 // "cheap enough". We are pretty much limited to CFG diamonds that merge | |
479 // 1 or 2 items with a total of 1 or 2 ops executed speculatively. | |
480 Node *PhaseIdealLoop::conditional_move( Node *region ) { | |
481 | |
4047 | 482 assert(region->is_Region(), "sanity check"); |
483 if (region->req() != 3) return NULL; | |
0 | 484 |
485 // Check for CFG diamond | |
486 Node *lp = region->in(1); | |
487 Node *rp = region->in(2); | |
4047 | 488 if (!lp || !rp) return NULL; |
0 | 489 Node *lp_c = lp->in(0); |
4047 | 490 if (lp_c == NULL || lp_c != rp->in(0) || !lp_c->is_If()) return NULL; |
0 | 491 IfNode *iff = lp_c->as_If(); |
492 | |
493 // Check for ops pinned in an arm of the diamond. | |
494 // Can't remove the control flow in this case | |
4047 | 495 if (lp->outcnt() > 1) return NULL; |
496 if (rp->outcnt() > 1) return NULL; | |
497 | |
498 IdealLoopTree* r_loop = get_loop(region); | |
499 assert(r_loop == get_loop(iff), "sanity"); | |
500 // Always convert to CMOVE if all results are used only outside this loop. | |
501 bool used_inside_loop = (r_loop == _ltree_root); | |
0 | 502 |
503 // Check profitability | |
504 int cost = 0; | |
35
e2ae28d2ce91
6667588: Don't generate duplicated CMP for float/double values
kvn
parents:
0
diff
changeset
|
505 int phis = 0; |
0 | 506 for (DUIterator_Fast imax, i = region->fast_outs(imax); i < imax; i++) { |
507 Node *out = region->fast_out(i); | |
4047 | 508 if (!out->is_Phi()) continue; // Ignore other control edges, etc |
35
e2ae28d2ce91
6667588: Don't generate duplicated CMP for float/double values
kvn
parents:
0
diff
changeset
|
509 phis++; |
0 | 510 PhiNode* phi = out->as_Phi(); |
4047 | 511 BasicType bt = phi->type()->basic_type(); |
512 switch (bt) { | |
513 case T_FLOAT: | |
514 case T_DOUBLE: { | |
515 cost += Matcher::float_cmove_cost(); // Could be very expensive | |
516 break; | |
517 } | |
518 case T_LONG: { | |
519 cost += Matcher::long_cmove_cost(); // May encodes as 2 CMOV's | |
520 } | |
0 | 521 case T_INT: // These all CMOV fine |
4047 | 522 case T_ADDRESS: { // (RawPtr) |
0 | 523 cost++; |
524 break; | |
4047 | 525 } |
293
c3e045194476
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
253
diff
changeset
|
526 case T_NARROWOOP: // Fall through |
0 | 527 case T_OBJECT: { // Base oops are OK, but not derived oops |
293
c3e045194476
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
253
diff
changeset
|
528 const TypeOopPtr *tp = phi->type()->make_ptr()->isa_oopptr(); |
0 | 529 // Derived pointers are Bad (tm): what's the Base (for GC purposes) of a |
530 // CMOVE'd derived pointer? It's a CMOVE'd derived base. Thus | |
531 // CMOVE'ing a derived pointer requires we also CMOVE the base. If we | |
532 // have a Phi for the base here that we convert to a CMOVE all is well | |
533 // and good. But if the base is dead, we'll not make a CMOVE. Later | |
534 // the allocator will have to produce a base by creating a CMOVE of the | |
535 // relevant bases. This puts the allocator in the business of | |
536 // manufacturing expensive instructions, generally a bad plan. | |
537 // Just Say No to Conditionally-Moved Derived Pointers. | |
4047 | 538 if (tp && tp->offset() != 0) |
0 | 539 return NULL; |
540 cost++; | |
541 break; | |
542 } | |
543 default: | |
544 return NULL; // In particular, can't do memory or I/O | |
545 } | |
546 // Add in cost any speculative ops | |
4047 | 547 for (uint j = 1; j < region->req(); j++) { |
0 | 548 Node *proj = region->in(j); |
549 Node *inp = phi->in(j); | |
550 if (get_ctrl(inp) == proj) { // Found local op | |
551 cost++; | |
552 // Check for a chain of dependent ops; these will all become | |
553 // speculative in a CMOV. | |
4047 | 554 for (uint k = 1; k < inp->req(); k++) |
0 | 555 if (get_ctrl(inp->in(k)) == proj) |
4047 | 556 cost += ConditionalMoveLimit; // Too much speculative goo |
0 | 557 } |
558 } | |
293
c3e045194476
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
253
diff
changeset
|
559 // See if the Phi is used by a Cmp or Narrow oop Decode/Encode. |
c3e045194476
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
253
diff
changeset
|
560 // This will likely Split-If, a higher-payoff operation. |
0 | 561 for (DUIterator_Fast kmax, k = phi->fast_outs(kmax); k < kmax; k++) { |
562 Node* use = phi->fast_out(k); | |
6848
8e47bac5643a
7054512: Compress class pointers after perm gen removal
roland
parents:
6804
diff
changeset
|
563 if (use->is_Cmp() || use->is_DecodeNarrowPtr() || use->is_EncodeNarrowPtr()) |
4047 | 564 cost += ConditionalMoveLimit; |
565 // Is there a use inside the loop? | |
566 // Note: check only basic types since CMoveP is pinned. | |
567 if (!used_inside_loop && is_java_primitive(bt)) { | |
568 IdealLoopTree* u_loop = get_loop(has_ctrl(use) ? get_ctrl(use) : use); | |
569 if (r_loop == u_loop || r_loop->is_member(u_loop)) { | |
570 used_inside_loop = true; | |
571 } | |
572 } | |
0 | 573 } |
574 } | |
35
e2ae28d2ce91
6667588: Don't generate duplicated CMP for float/double values
kvn
parents:
0
diff
changeset
|
575 Node* bol = iff->in(1); |
4047 | 576 assert(bol->Opcode() == Op_Bool, ""); |
35
e2ae28d2ce91
6667588: Don't generate duplicated CMP for float/double values
kvn
parents:
0
diff
changeset
|
577 int cmp_op = bol->in(1)->Opcode(); |
e2ae28d2ce91
6667588: Don't generate duplicated CMP for float/double values
kvn
parents:
0
diff
changeset
|
578 // It is expensive to generate flags from a float compare. |
e2ae28d2ce91
6667588: Don't generate duplicated CMP for float/double values
kvn
parents:
0
diff
changeset
|
579 // Avoid duplicated float compare. |
4047 | 580 if (phis > 1 && (cmp_op == Op_CmpF || cmp_op == Op_CmpD)) return NULL; |
581 | |
582 float infrequent_prob = PROB_UNLIKELY_MAG(3); | |
583 // Ignore cost and blocks frequency if CMOVE can be moved outside the loop. | |
584 if (used_inside_loop) { | |
585 if (cost >= ConditionalMoveLimit) return NULL; // Too much goo | |
586 | |
587 // BlockLayoutByFrequency optimization moves infrequent branch | |
588 // from hot path. No point in CMOV'ing in such case (110 is used | |
589 // instead of 100 to take into account not exactness of float value). | |
590 if (BlockLayoutByFrequency) { | |
591 infrequent_prob = MAX2(infrequent_prob, (float)BlockLayoutMinDiamondPercentage/110.0f); | |
592 } | |
593 } | |
594 // Check for highly predictable branch. No point in CMOV'ing if | |
595 // we are going to predict accurately all the time. | |
596 if (iff->_prob < infrequent_prob || | |
597 iff->_prob > (1.0f - infrequent_prob)) | |
598 return NULL; | |
0 | 599 |
600 // -------------- | |
601 // Now replace all Phis with CMOV's | |
602 Node *cmov_ctrl = iff->in(0); | |
603 uint flip = (lp->Opcode() == Op_IfTrue); | |
4047 | 604 while (1) { |
0 | 605 PhiNode* phi = NULL; |
606 for (DUIterator_Fast imax, i = region->fast_outs(imax); i < imax; i++) { | |
607 Node *out = region->fast_out(i); | |
608 if (out->is_Phi()) { | |
609 phi = out->as_Phi(); | |
610 break; | |
611 } | |
612 } | |
613 if (phi == NULL) break; | |
614 #ifndef PRODUCT | |
4047 | 615 if (PrintOpto && VerifyLoopOptimizations) tty->print_cr("CMOV"); |
0 | 616 #endif |
617 // Move speculative ops | |
4047 | 618 for (uint j = 1; j < region->req(); j++) { |
0 | 619 Node *proj = region->in(j); |
620 Node *inp = phi->in(j); | |
621 if (get_ctrl(inp) == proj) { // Found local op | |
622 #ifndef PRODUCT | |
4047 | 623 if (PrintOpto && VerifyLoopOptimizations) { |
0 | 624 tty->print(" speculate: "); |
625 inp->dump(); | |
626 } | |
627 #endif | |
628 set_ctrl(inp, cmov_ctrl); | |
629 } | |
630 } | |
631 Node *cmov = CMoveNode::make( C, cmov_ctrl, iff->in(1), phi->in(1+flip), phi->in(2-flip), _igvn.type(phi) ); | |
632 register_new_node( cmov, cmov_ctrl ); | |
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
633 _igvn.replace_node( phi, cmov ); |
0 | 634 #ifndef PRODUCT |
4047 | 635 if (TraceLoopOpts) { |
636 tty->print("CMOV "); | |
637 r_loop->dump_head(); | |
4064
670a74b863fc
7107042: assert(no_dead_loop) failed: dead loop detected
kvn
parents:
4047
diff
changeset
|
638 if (Verbose) { |
4047 | 639 bol->in(1)->dump(1); |
640 cmov->dump(1); | |
4064
670a74b863fc
7107042: assert(no_dead_loop) failed: dead loop detected
kvn
parents:
4047
diff
changeset
|
641 } |
4047 | 642 } |
643 if (VerifyLoopOptimizations) verify(); | |
0 | 644 #endif |
645 } | |
646 | |
647 // The useless CFG diamond will fold up later; see the optimization in | |
648 // RegionNode::Ideal. | |
649 _igvn._worklist.push(region); | |
650 | |
651 return iff->in(1); | |
652 } | |
653 | |
654 //------------------------------split_if_with_blocks_pre----------------------- | |
655 // Do the real work in a non-recursive function. Data nodes want to be | |
656 // cloned in the pre-order so they can feed each other nicely. | |
657 Node *PhaseIdealLoop::split_if_with_blocks_pre( Node *n ) { | |
658 // Cloning these guys is unlikely to win | |
659 int n_op = n->Opcode(); | |
660 if( n_op == Op_MergeMem ) return n; | |
661 if( n->is_Proj() ) return n; | |
662 // Do not clone-up CmpFXXX variations, as these are always | |
663 // followed by a CmpI | |
664 if( n->is_Cmp() ) return n; | |
665 // Attempt to use a conditional move instead of a phi/branch | |
666 if( ConditionalMoveLimit > 0 && n_op == Op_Region ) { | |
667 Node *cmov = conditional_move( n ); | |
668 if( cmov ) return cmov; | |
669 } | |
253
b0fe4deeb9fb
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
251
diff
changeset
|
670 if( n->is_CFG() || n->is_LoadStore() ) |
b0fe4deeb9fb
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
251
diff
changeset
|
671 return n; |
0 | 672 if( n_op == Op_Opaque1 || // Opaque nodes cannot be mod'd |
673 n_op == Op_Opaque2 ) { | |
674 if( !C->major_progress() ) // If chance of no more loop opts... | |
675 _igvn._worklist.push(n); // maybe we'll remove them | |
676 return n; | |
677 } | |
678 | |
679 if( n->is_Con() ) return n; // No cloning for Con nodes | |
680 | |
681 Node *n_ctrl = get_ctrl(n); | |
682 if( !n_ctrl ) return n; // Dead node | |
683 | |
684 // Attempt to remix address expressions for loop invariants | |
685 Node *m = remix_address_expressions( n ); | |
686 if( m ) return m; | |
687 | |
688 // Determine if the Node has inputs from some local Phi. | |
689 // Returns the block to clone thru. | |
690 Node *n_blk = has_local_phi_input( n ); | |
691 if( !n_blk ) return n; | |
692 // Do not clone the trip counter through on a CountedLoop | |
693 // (messes up the canonical shape). | |
694 if( n_blk->is_CountedLoop() && n->Opcode() == Op_AddI ) return n; | |
695 | |
696 // Check for having no control input; not pinned. Allow | |
697 // dominating control. | |
698 if( n->in(0) ) { | |
699 Node *dom = idom(n_blk); | |
700 if( dom_lca( n->in(0), dom ) != n->in(0) ) | |
701 return n; | |
702 } | |
703 // Policy: when is it profitable. You must get more wins than | |
704 // policy before it is considered profitable. Policy is usually 0, | |
705 // so 1 win is considered profitable. Big merges will require big | |
706 // cloning, so get a larger policy. | |
707 int policy = n_blk->req() >> 2; | |
708 | |
709 // If the loop is a candidate for range check elimination, | |
710 // delay splitting through it's phi until a later loop optimization | |
711 if (n_blk->is_CountedLoop()) { | |
712 IdealLoopTree *lp = get_loop(n_blk); | |
713 if (lp && lp->_rce_candidate) { | |
714 return n; | |
715 } | |
716 } | |
717 | |
718 // Use same limit as split_if_with_blocks_post | |
719 if( C->unique() > 35000 ) return n; // Method too big | |
720 | |
721 // Split 'n' through the merge point if it is profitable | |
722 Node *phi = split_thru_phi( n, n_blk, policy ); | |
4047 | 723 if (!phi) return n; |
0 | 724 |
725 // Found a Phi to split thru! | |
726 // Replace 'n' with the new phi | |
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
727 _igvn.replace_node( n, phi ); |
0 | 728 // Moved a load around the loop, 'en-registering' something. |
4047 | 729 if (n_blk->is_Loop() && n->is_Load() && |
730 !phi->in(LoopNode::LoopBackControl)->is_Load()) | |
0 | 731 C->set_major_progress(); |
732 | |
733 return phi; | |
734 } | |
735 | |
736 static bool merge_point_too_heavy(Compile* C, Node* region) { | |
737 // Bail out if the region and its phis have too many users. | |
738 int weight = 0; | |
739 for (DUIterator_Fast imax, i = region->fast_outs(imax); i < imax; i++) { | |
740 weight += region->fast_out(i)->outcnt(); | |
741 } | |
20671
9e69e8d1c900
8058148: MaxNodeLimit and LiveNodeCountInliningCutoff
vlivanov
parents:
17985
diff
changeset
|
742 int nodes_left = C->max_node_limit() - C->live_nodes(); |
0 | 743 if (weight * 8 > nodes_left) { |
744 #ifndef PRODUCT | |
745 if (PrintOpto) | |
746 tty->print_cr("*** Split-if bails out: %d nodes, region weight %d", C->unique(), weight); | |
747 #endif | |
748 return true; | |
749 } else { | |
750 return false; | |
751 } | |
752 } | |
753 | |
754 static bool merge_point_safe(Node* region) { | |
755 // 4799512: Stop split_if_with_blocks from splitting a block with a ConvI2LNode | |
756 // having a PhiNode input. This sidesteps the dangerous case where the split | |
757 // ConvI2LNode may become TOP if the input Value() does not | |
758 // overlap the ConvI2L range, leaving a node which may not dominate its | |
759 // uses. | |
760 // A better fix for this problem can be found in the BugTraq entry, but | |
761 // expediency for Mantis demands this hack. | |
834
0f2d888530e7
6855164: SIGSEGV during compilation of method involving loop over CharSequence.
cfang
parents:
605
diff
changeset
|
762 // 6855164: If the merge point has a FastLockNode with a PhiNode input, we stop |
0f2d888530e7
6855164: SIGSEGV during compilation of method involving loop over CharSequence.
cfang
parents:
605
diff
changeset
|
763 // split_if_with_blocks from splitting a block because we could not move around |
0f2d888530e7
6855164: SIGSEGV during compilation of method involving loop over CharSequence.
cfang
parents:
605
diff
changeset
|
764 // the FastLockNode. |
0 | 765 for (DUIterator_Fast imax, i = region->fast_outs(imax); i < imax; i++) { |
766 Node* n = region->fast_out(i); | |
767 if (n->is_Phi()) { | |
768 for (DUIterator_Fast jmax, j = n->fast_outs(jmax); j < jmax; j++) { | |
769 Node* m = n->fast_out(j); | |
834
0f2d888530e7
6855164: SIGSEGV during compilation of method involving loop over CharSequence.
cfang
parents:
605
diff
changeset
|
770 if (m->is_FastLock()) |
0 | 771 return false; |
834
0f2d888530e7
6855164: SIGSEGV during compilation of method involving loop over CharSequence.
cfang
parents:
605
diff
changeset
|
772 #ifdef _LP64 |
0f2d888530e7
6855164: SIGSEGV during compilation of method involving loop over CharSequence.
cfang
parents:
605
diff
changeset
|
773 if (m->Opcode() == Op_ConvI2L) |
0f2d888530e7
6855164: SIGSEGV during compilation of method involving loop over CharSequence.
cfang
parents:
605
diff
changeset
|
774 return false; |
23799
535618ab1c04
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
20701
diff
changeset
|
775 if (m->is_CastII() && m->isa_CastII()->has_range_check()) { |
535618ab1c04
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
20701
diff
changeset
|
776 return false; |
535618ab1c04
6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents:
20701
diff
changeset
|
777 } |
834
0f2d888530e7
6855164: SIGSEGV during compilation of method involving loop over CharSequence.
cfang
parents:
605
diff
changeset
|
778 #endif |
0 | 779 } |
780 } | |
781 } | |
782 return true; | |
783 } | |
784 | |
785 | |
786 //------------------------------place_near_use--------------------------------- | |
787 // Place some computation next to use but not inside inner loops. | |
788 // For inner loop uses move it to the preheader area. | |
789 Node *PhaseIdealLoop::place_near_use( Node *useblock ) const { | |
790 IdealLoopTree *u_loop = get_loop( useblock ); | |
791 return (u_loop->_irreducible || u_loop->_child) | |
792 ? useblock | |
793 : u_loop->_head->in(LoopNode::EntryControl); | |
794 } | |
795 | |
796 | |
797 //------------------------------split_if_with_blocks_post---------------------- | |
798 // Do the real work in a non-recursive function. CFG hackery wants to be | |
799 // in the post-order, so it can dirty the I-DOM info and not use the dirtied | |
800 // info. | |
801 void PhaseIdealLoop::split_if_with_blocks_post( Node *n ) { | |
802 | |
803 // Cloning Cmp through Phi's involves the split-if transform. | |
804 // FastLock is not used by an If | |
805 if( n->is_Cmp() && !n->is_FastLock() ) { | |
806 if( C->unique() > 35000 ) return; // Method too big | |
807 | |
808 // Do not do 'split-if' if irreducible loops are present. | |
809 if( _has_irreducible_loops ) | |
810 return; | |
811 | |
812 Node *n_ctrl = get_ctrl(n); | |
813 // Determine if the Node has inputs from some local Phi. | |
814 // Returns the block to clone thru. | |
815 Node *n_blk = has_local_phi_input( n ); | |
816 if( n_blk != n_ctrl ) return; | |
817 | |
818 if( merge_point_too_heavy(C, n_ctrl) ) | |
819 return; | |
820 | |
821 if( n->outcnt() != 1 ) return; // Multiple bool's from 1 compare? | |
822 Node *bol = n->unique_out(); | |
823 assert( bol->is_Bool(), "expect a bool here" ); | |
824 if( bol->outcnt() != 1 ) return;// Multiple branches from 1 compare? | |
825 Node *iff = bol->unique_out(); | |
826 | |
827 // Check some safety conditions | |
828 if( iff->is_If() ) { // Classic split-if? | |
829 if( iff->in(0) != n_ctrl ) return; // Compare must be in same blk as if | |
830 } else if (iff->is_CMove()) { // Trying to split-up a CMOVE | |
4779
c8d8e124380c
7064302: JDK7 build 147 crashed after testing my java 6-compiled web app
kvn
parents:
4064
diff
changeset
|
831 // Can't split CMove with different control edge. |
c8d8e124380c
7064302: JDK7 build 147 crashed after testing my java 6-compiled web app
kvn
parents:
4064
diff
changeset
|
832 if (iff->in(0) != NULL && iff->in(0) != n_ctrl ) return; |
0 | 833 if( get_ctrl(iff->in(2)) == n_ctrl || |
834 get_ctrl(iff->in(3)) == n_ctrl ) | |
835 return; // Inputs not yet split-up | |
836 if ( get_loop(n_ctrl) != get_loop(get_ctrl(iff)) ) { | |
837 return; // Loop-invar test gates loop-varying CMOVE | |
838 } | |
839 } else { | |
840 return; // some other kind of node, such as an Allocate | |
841 } | |
842 | |
843 // Do not do 'split-if' if some paths are dead. First do dead code | |
844 // elimination and then see if its still profitable. | |
845 for( uint i = 1; i < n_ctrl->req(); i++ ) | |
846 if( n_ctrl->in(i) == C->top() ) | |
847 return; | |
848 | |
849 // When is split-if profitable? Every 'win' on means some control flow | |
850 // goes dead, so it's almost always a win. | |
851 int policy = 0; | |
852 // If trying to do a 'Split-If' at the loop head, it is only | |
853 // profitable if the cmp folds up on BOTH paths. Otherwise we | |
854 // risk peeling a loop forever. | |
855 | |
856 // CNC - Disabled for now. Requires careful handling of loop | |
857 // body selection for the cloned code. Also, make sure we check | |
858 // for any input path not being in the same loop as n_ctrl. For | |
859 // irreducible loops we cannot check for 'n_ctrl->is_Loop()' | |
860 // because the alternative loop entry points won't be converted | |
861 // into LoopNodes. | |
862 IdealLoopTree *n_loop = get_loop(n_ctrl); | |
863 for( uint j = 1; j < n_ctrl->req(); j++ ) | |
864 if( get_loop(n_ctrl->in(j)) != n_loop ) | |
865 return; | |
866 | |
867 // Check for safety of the merge point. | |
868 if( !merge_point_safe(n_ctrl) ) { | |
869 return; | |
870 } | |
871 | |
872 // Split compare 'n' through the merge point if it is profitable | |
873 Node *phi = split_thru_phi( n, n_ctrl, policy ); | |
874 if( !phi ) return; | |
875 | |
876 // Found a Phi to split thru! | |
877 // Replace 'n' with the new phi | |
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
878 _igvn.replace_node( n, phi ); |
0 | 879 |
880 // Now split the bool up thru the phi | |
881 Node *bolphi = split_thru_phi( bol, n_ctrl, -1 ); | |
8774
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
882 guarantee(bolphi != NULL, "null boolean phi node"); |
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
883 |
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
884 _igvn.replace_node( bol, bolphi ); |
0 | 885 assert( iff->in(1) == bolphi, "" ); |
8774
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
886 |
0 | 887 if( bolphi->Value(&_igvn)->singleton() ) |
888 return; | |
889 | |
890 // Conditional-move? Must split up now | |
891 if( !iff->is_If() ) { | |
892 Node *cmovphi = split_thru_phi( iff, n_ctrl, -1 ); | |
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
893 _igvn.replace_node( iff, cmovphi ); |
0 | 894 return; |
895 } | |
896 | |
897 // Now split the IF | |
898 do_split_if( iff ); | |
899 return; | |
900 } | |
901 | |
902 // Check for an IF ready to split; one that has its | |
903 // condition codes input coming from a Phi at the block start. | |
904 int n_op = n->Opcode(); | |
905 | |
906 // Check for an IF being dominated by another IF same test | |
20701
b6585ac86988
8048170: Test closed/java/text/Normalizer/ConformanceTest.java failed
roland
parents:
20671
diff
changeset
|
907 if (n_op == Op_If) { |
0 | 908 Node *bol = n->in(1); |
909 uint max = bol->outcnt(); | |
910 // Check for same test used more than once? | |
20701
b6585ac86988
8048170: Test closed/java/text/Normalizer/ConformanceTest.java failed
roland
parents:
20671
diff
changeset
|
911 if (max > 1 && bol->is_Bool()) { |
0 | 912 // Search up IDOMs to see if this IF is dominated. |
913 Node *cutoff = get_ctrl(bol); | |
914 | |
915 // Now search up IDOMs till cutoff, looking for a dominating test | |
916 Node *prevdom = n; | |
917 Node *dom = idom(prevdom); | |
20701
b6585ac86988
8048170: Test closed/java/text/Normalizer/ConformanceTest.java failed
roland
parents:
20671
diff
changeset
|
918 while (dom != cutoff) { |
b6585ac86988
8048170: Test closed/java/text/Normalizer/ConformanceTest.java failed
roland
parents:
20671
diff
changeset
|
919 if (dom->req() > 1 && dom->in(1) == bol && prevdom->in(0) == dom) { |
0 | 920 // Replace the dominated test with an obvious true or false. |
921 // Place it on the IGVN worklist for later cleanup. | |
922 C->set_major_progress(); | |
20701
b6585ac86988
8048170: Test closed/java/text/Normalizer/ConformanceTest.java failed
roland
parents:
20671
diff
changeset
|
923 dominated_by(prevdom, n, false, true); |
0 | 924 #ifndef PRODUCT |
925 if( VerifyLoopOptimizations ) verify(); | |
926 #endif | |
927 return; | |
928 } | |
929 prevdom = dom; | |
930 dom = idom(prevdom); | |
931 } | |
932 } | |
933 } | |
934 | |
935 // See if a shared loop-varying computation has no loop-varying uses. | |
936 // Happens if something is only used for JVM state in uncommon trap exits, | |
937 // like various versions of induction variable+offset. Clone the | |
938 // computation per usage to allow it to sink out of the loop. | |
939 if (has_ctrl(n) && !n->in(0)) {// n not dead and has no control edge (can float about) | |
940 Node *n_ctrl = get_ctrl(n); | |
941 IdealLoopTree *n_loop = get_loop(n_ctrl); | |
942 if( n_loop != _ltree_root ) { | |
943 DUIterator_Fast imax, i = n->fast_outs(imax); | |
944 for (; i < imax; i++) { | |
945 Node* u = n->fast_out(i); | |
946 if( !has_ctrl(u) ) break; // Found control user | |
947 IdealLoopTree *u_loop = get_loop(get_ctrl(u)); | |
948 if( u_loop == n_loop ) break; // Found loop-varying use | |
949 if( n_loop->is_member( u_loop ) ) break; // Found use in inner loop | |
950 if( u->Opcode() == Op_Opaque1 ) break; // Found loop limit, bugfix for 4677003 | |
951 } | |
952 bool did_break = (i < imax); // Did we break out of the previous loop? | |
953 if (!did_break && n->outcnt() > 1) { // All uses in outer loops! | |
4779
c8d8e124380c
7064302: JDK7 build 147 crashed after testing my java 6-compiled web app
kvn
parents:
4064
diff
changeset
|
954 Node *late_load_ctrl = NULL; |
0 | 955 if (n->is_Load()) { |
956 // If n is a load, get and save the result from get_late_ctrl(), | |
957 // to be later used in calculating the control for n's clones. | |
958 clear_dom_lca_tags(); | |
959 late_load_ctrl = get_late_ctrl(n, n_ctrl); | |
960 } | |
961 // If n is a load, and the late control is the same as the current | |
962 // control, then the cloning of n is a pointless exercise, because | |
963 // GVN will ensure that we end up where we started. | |
964 if (!n->is_Load() || late_load_ctrl != n_ctrl) { | |
965 for (DUIterator_Last jmin, j = n->last_outs(jmin); j >= jmin; ) { | |
966 Node *u = n->last_out(j); // Clone private computation per use | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
967 _igvn.rehash_node_delayed(u); |
0 | 968 Node *x = n->clone(); // Clone computation |
969 Node *x_ctrl = NULL; | |
970 if( u->is_Phi() ) { | |
971 // Replace all uses of normal nodes. Replace Phi uses | |
605 | 972 // individually, so the separate Nodes can sink down |
0 | 973 // different paths. |
974 uint k = 1; | |
975 while( u->in(k) != n ) k++; | |
976 u->set_req( k, x ); | |
977 // x goes next to Phi input path | |
978 x_ctrl = u->in(0)->in(k); | |
979 --j; | |
980 } else { // Normal use | |
981 // Replace all uses | |
982 for( uint k = 0; k < u->req(); k++ ) { | |
983 if( u->in(k) == n ) { | |
984 u->set_req( k, x ); | |
985 --j; | |
986 } | |
987 } | |
988 x_ctrl = get_ctrl(u); | |
989 } | |
990 | |
991 // Find control for 'x' next to use but not inside inner loops. | |
992 // For inner loop uses get the preheader area. | |
993 x_ctrl = place_near_use(x_ctrl); | |
994 | |
995 if (n->is_Load()) { | |
996 // For loads, add a control edge to a CFG node outside of the loop | |
997 // to force them to not combine and return back inside the loop | |
998 // during GVN optimization (4641526). | |
999 // | |
1000 // Because we are setting the actual control input, factor in | |
1001 // the result from get_late_ctrl() so we respect any | |
1002 // anti-dependences. (6233005). | |
1003 x_ctrl = dom_lca(late_load_ctrl, x_ctrl); | |
1004 | |
1005 // Don't allow the control input to be a CFG splitting node. | |
1006 // Such nodes should only have ProjNodes as outs, e.g. IfNode | |
1007 // should only have IfTrueNode and IfFalseNode (4985384). | |
1008 x_ctrl = find_non_split_ctrl(x_ctrl); | |
1009 assert(dom_depth(n_ctrl) <= dom_depth(x_ctrl), "n is later than its clone"); | |
1010 | |
1011 x->set_req(0, x_ctrl); | |
1012 } | |
1013 register_new_node(x, x_ctrl); | |
1014 | |
1015 // Some institutional knowledge is needed here: 'x' is | |
1016 // yanked because if the optimizer runs GVN on it all the | |
1017 // cloned x's will common up and undo this optimization and | |
1018 // be forced back in the loop. This is annoying because it | |
1019 // makes +VerifyOpto report false-positives on progress. I | |
1020 // tried setting control edges on the x's to force them to | |
1021 // not combine, but the matching gets worried when it tries | |
1022 // to fold a StoreP and an AddP together (as part of an | |
1023 // address expression) and the AddP and StoreP have | |
1024 // different controls. | |
6848
8e47bac5643a
7054512: Compress class pointers after perm gen removal
roland
parents:
6804
diff
changeset
|
1025 if (!x->is_Load() && !x->is_DecodeNarrowPtr()) _igvn._worklist.yank(x); |
0 | 1026 } |
1027 _igvn.remove_dead_node(n); | |
1028 } | |
1029 } | |
1030 } | |
1031 } | |
1032 | |
1033 // Check for Opaque2's who's loop has disappeared - who's input is in the | |
1034 // same loop nest as their output. Remove 'em, they are no longer useful. | |
1035 if( n_op == Op_Opaque2 && | |
1036 n->in(1) != NULL && | |
1037 get_loop(get_ctrl(n)) == get_loop(get_ctrl(n->in(1))) ) { | |
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
1038 _igvn.replace_node( n, n->in(1) ); |
0 | 1039 } |
1040 } | |
1041 | |
1042 //------------------------------split_if_with_blocks--------------------------- | |
1043 // Check for aggressive application of 'split-if' optimization, | |
1044 // using basic block level info. | |
1045 void PhaseIdealLoop::split_if_with_blocks( VectorSet &visited, Node_Stack &nstack ) { | |
1046 Node *n = C->root(); | |
1047 visited.set(n->_idx); // first, mark node as visited | |
1048 // Do pre-visit work for root | |
1049 n = split_if_with_blocks_pre( n ); | |
1050 uint cnt = n->outcnt(); | |
1051 uint i = 0; | |
1052 while (true) { | |
1053 // Visit all children | |
1054 if (i < cnt) { | |
1055 Node* use = n->raw_out(i); | |
1056 ++i; | |
1057 if (use->outcnt() != 0 && !visited.test_set(use->_idx)) { | |
1058 // Now do pre-visit work for this use | |
1059 use = split_if_with_blocks_pre( use ); | |
1060 nstack.push(n, i); // Save parent and next use's index. | |
1061 n = use; // Process all children of current use. | |
1062 cnt = use->outcnt(); | |
1063 i = 0; | |
1064 } | |
1065 } | |
1066 else { | |
1067 // All of n's children have been processed, complete post-processing. | |
1068 if (cnt != 0 && !n->is_Con()) { | |
1069 assert(has_node(n), "no dead nodes"); | |
1070 split_if_with_blocks_post( n ); | |
1071 } | |
1072 if (nstack.is_empty()) { | |
1073 // Finished all nodes on stack. | |
1074 break; | |
1075 } | |
1076 // Get saved parent node and next use's index. Visit the rest of uses. | |
1077 n = nstack.node(); | |
1078 cnt = n->outcnt(); | |
1079 i = nstack.index(); | |
1080 nstack.pop(); | |
1081 } | |
1082 } | |
1083 } | |
1084 | |
1085 | |
1086 //============================================================================= | |
1087 // | |
1088 // C L O N E A L O O P B O D Y | |
1089 // | |
1090 | |
1091 //------------------------------clone_iff-------------------------------------- | |
1092 // Passed in a Phi merging (recursively) some nearly equivalent Bool/Cmps. | |
1093 // "Nearly" because all Nodes have been cloned from the original in the loop, | |
1094 // but the fall-in edges to the Cmp are different. Clone bool/Cmp pairs | |
1095 // through the Phi recursively, and return a Bool. | |
1096 BoolNode *PhaseIdealLoop::clone_iff( PhiNode *phi, IdealLoopTree *loop ) { | |
1097 | |
1098 // Convert this Phi into a Phi merging Bools | |
1099 uint i; | |
1100 for( i = 1; i < phi->req(); i++ ) { | |
1101 Node *b = phi->in(i); | |
1102 if( b->is_Phi() ) { | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1103 _igvn.replace_input_of(phi, i, clone_iff( b->as_Phi(), loop )); |
0 | 1104 } else { |
1105 assert( b->is_Bool(), "" ); | |
1106 } | |
1107 } | |
1108 | |
1109 Node *sample_bool = phi->in(1); | |
1110 Node *sample_cmp = sample_bool->in(1); | |
1111 | |
1112 // Make Phis to merge the Cmp's inputs. | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
1113 PhiNode *phi1 = new (C) PhiNode( phi->in(0), Type::TOP ); |
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
1114 PhiNode *phi2 = new (C) PhiNode( phi->in(0), Type::TOP ); |
0 | 1115 for( i = 1; i < phi->req(); i++ ) { |
1116 Node *n1 = phi->in(i)->in(1)->in(1); | |
1117 Node *n2 = phi->in(i)->in(1)->in(2); | |
1118 phi1->set_req( i, n1 ); | |
1119 phi2->set_req( i, n2 ); | |
17671
de95063c0e34
8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed
roland
parents:
17467
diff
changeset
|
1120 phi1->set_type( phi1->type()->meet_speculative(n1->bottom_type())); |
de95063c0e34
8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed
roland
parents:
17467
diff
changeset
|
1121 phi2->set_type( phi2->type()->meet_speculative(n2->bottom_type())); |
0 | 1122 } |
1123 // See if these Phis have been made before. | |
1124 // Register with optimizer | |
1125 Node *hit1 = _igvn.hash_find_insert(phi1); | |
1126 if( hit1 ) { // Hit, toss just made Phi | |
1127 _igvn.remove_dead_node(phi1); // Remove new phi | |
1128 assert( hit1->is_Phi(), "" ); | |
1129 phi1 = (PhiNode*)hit1; // Use existing phi | |
1130 } else { // Miss | |
1131 _igvn.register_new_node_with_optimizer(phi1); | |
1132 } | |
1133 Node *hit2 = _igvn.hash_find_insert(phi2); | |
1134 if( hit2 ) { // Hit, toss just made Phi | |
1135 _igvn.remove_dead_node(phi2); // Remove new phi | |
1136 assert( hit2->is_Phi(), "" ); | |
1137 phi2 = (PhiNode*)hit2; // Use existing phi | |
1138 } else { // Miss | |
1139 _igvn.register_new_node_with_optimizer(phi2); | |
1140 } | |
1141 // Register Phis with loop/block info | |
1142 set_ctrl(phi1, phi->in(0)); | |
1143 set_ctrl(phi2, phi->in(0)); | |
1144 // Make a new Cmp | |
1145 Node *cmp = sample_cmp->clone(); | |
1146 cmp->set_req( 1, phi1 ); | |
1147 cmp->set_req( 2, phi2 ); | |
1148 _igvn.register_new_node_with_optimizer(cmp); | |
1149 set_ctrl(cmp, phi->in(0)); | |
1150 | |
1151 // Make a new Bool | |
1152 Node *b = sample_bool->clone(); | |
1153 b->set_req(1,cmp); | |
1154 _igvn.register_new_node_with_optimizer(b); | |
1155 set_ctrl(b, phi->in(0)); | |
1156 | |
1157 assert( b->is_Bool(), "" ); | |
1158 return (BoolNode*)b; | |
1159 } | |
1160 | |
1161 //------------------------------clone_bool------------------------------------- | |
1162 // Passed in a Phi merging (recursively) some nearly equivalent Bool/Cmps. | |
1163 // "Nearly" because all Nodes have been cloned from the original in the loop, | |
1164 // but the fall-in edges to the Cmp are different. Clone bool/Cmp pairs | |
1165 // through the Phi recursively, and return a Bool. | |
1166 CmpNode *PhaseIdealLoop::clone_bool( PhiNode *phi, IdealLoopTree *loop ) { | |
1167 uint i; | |
1168 // Convert this Phi into a Phi merging Bools | |
1169 for( i = 1; i < phi->req(); i++ ) { | |
1170 Node *b = phi->in(i); | |
1171 if( b->is_Phi() ) { | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1172 _igvn.replace_input_of(phi, i, clone_bool( b->as_Phi(), loop )); |
0 | 1173 } else { |
1174 assert( b->is_Cmp() || b->is_top(), "inputs are all Cmp or TOP" ); | |
1175 } | |
1176 } | |
1177 | |
1178 Node *sample_cmp = phi->in(1); | |
1179 | |
1180 // Make Phis to merge the Cmp's inputs. | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
1181 PhiNode *phi1 = new (C) PhiNode( phi->in(0), Type::TOP ); |
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
1182 PhiNode *phi2 = new (C) PhiNode( phi->in(0), Type::TOP ); |
0 | 1183 for( uint j = 1; j < phi->req(); j++ ) { |
1184 Node *cmp_top = phi->in(j); // Inputs are all Cmp or TOP | |
1185 Node *n1, *n2; | |
1186 if( cmp_top->is_Cmp() ) { | |
1187 n1 = cmp_top->in(1); | |
1188 n2 = cmp_top->in(2); | |
1189 } else { | |
1190 n1 = n2 = cmp_top; | |
1191 } | |
1192 phi1->set_req( j, n1 ); | |
1193 phi2->set_req( j, n2 ); | |
17671
de95063c0e34
8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed
roland
parents:
17467
diff
changeset
|
1194 phi1->set_type(phi1->type()->meet_speculative(n1->bottom_type())); |
de95063c0e34
8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed
roland
parents:
17467
diff
changeset
|
1195 phi2->set_type(phi2->type()->meet_speculative(n2->bottom_type())); |
0 | 1196 } |
1197 | |
1198 // See if these Phis have been made before. | |
1199 // Register with optimizer | |
1200 Node *hit1 = _igvn.hash_find_insert(phi1); | |
1201 if( hit1 ) { // Hit, toss just made Phi | |
1202 _igvn.remove_dead_node(phi1); // Remove new phi | |
1203 assert( hit1->is_Phi(), "" ); | |
1204 phi1 = (PhiNode*)hit1; // Use existing phi | |
1205 } else { // Miss | |
1206 _igvn.register_new_node_with_optimizer(phi1); | |
1207 } | |
1208 Node *hit2 = _igvn.hash_find_insert(phi2); | |
1209 if( hit2 ) { // Hit, toss just made Phi | |
1210 _igvn.remove_dead_node(phi2); // Remove new phi | |
1211 assert( hit2->is_Phi(), "" ); | |
1212 phi2 = (PhiNode*)hit2; // Use existing phi | |
1213 } else { // Miss | |
1214 _igvn.register_new_node_with_optimizer(phi2); | |
1215 } | |
1216 // Register Phis with loop/block info | |
1217 set_ctrl(phi1, phi->in(0)); | |
1218 set_ctrl(phi2, phi->in(0)); | |
1219 // Make a new Cmp | |
1220 Node *cmp = sample_cmp->clone(); | |
1221 cmp->set_req( 1, phi1 ); | |
1222 cmp->set_req( 2, phi2 ); | |
1223 _igvn.register_new_node_with_optimizer(cmp); | |
1224 set_ctrl(cmp, phi->in(0)); | |
1225 | |
1226 assert( cmp->is_Cmp(), "" ); | |
1227 return (CmpNode*)cmp; | |
1228 } | |
1229 | |
1230 //------------------------------sink_use--------------------------------------- | |
1231 // If 'use' was in the loop-exit block, it now needs to be sunk | |
1232 // below the post-loop merge point. | |
1233 void PhaseIdealLoop::sink_use( Node *use, Node *post_loop ) { | |
1234 if (!use->is_CFG() && get_ctrl(use) == post_loop->in(2)) { | |
1235 set_ctrl(use, post_loop); | |
1236 for (DUIterator j = use->outs(); use->has_out(j); j++) | |
1237 sink_use(use->out(j), post_loop); | |
1238 } | |
1239 } | |
1240 | |
1241 //------------------------------clone_loop------------------------------------- | |
1242 // | |
1243 // C L O N E A L O O P B O D Y | |
1244 // | |
1245 // This is the basic building block of the loop optimizations. It clones an | |
1246 // entire loop body. It makes an old_new loop body mapping; with this mapping | |
1247 // you can find the new-loop equivalent to an old-loop node. All new-loop | |
1248 // nodes are exactly equal to their old-loop counterparts, all edges are the | |
1249 // same. All exits from the old-loop now have a RegionNode that merges the | |
1250 // equivalent new-loop path. This is true even for the normal "loop-exit" | |
1251 // condition. All uses of loop-invariant old-loop values now come from (one | |
1252 // or more) Phis that merge their new-loop equivalents. | |
1253 // | |
1254 // This operation leaves the graph in an illegal state: there are two valid | |
1255 // control edges coming from the loop pre-header to both loop bodies. I'll | |
1256 // definitely have to hack the graph after running this transform. | |
1257 // | |
1258 // From this building block I will further edit edges to perform loop peeling | |
1259 // or loop unrolling or iteration splitting (Range-Check-Elimination), etc. | |
1260 // | |
1261 // Parameter side_by_size_idom: | |
1262 // When side_by_size_idom is NULL, the dominator tree is constructed for | |
1263 // the clone loop to dominate the original. Used in construction of | |
1264 // pre-main-post loop sequence. | |
1265 // When nonnull, the clone and original are side-by-side, both are | |
1266 // dominated by the side_by_side_idom node. Used in construction of | |
1267 // unswitched loops. | |
1268 void PhaseIdealLoop::clone_loop( IdealLoopTree *loop, Node_List &old_new, int dd, | |
1269 Node* side_by_side_idom) { | |
1270 | |
1271 // Step 1: Clone the loop body. Make the old->new mapping. | |
1272 uint i; | |
1273 for( i = 0; i < loop->_body.size(); i++ ) { | |
1274 Node *old = loop->_body.at(i); | |
1275 Node *nnn = old->clone(); | |
1276 old_new.map( old->_idx, nnn ); | |
1277 _igvn.register_new_node_with_optimizer(nnn); | |
1278 } | |
1279 | |
1280 | |
1281 // Step 2: Fix the edges in the new body. If the old input is outside the | |
1282 // loop use it. If the old input is INside the loop, use the corresponding | |
1283 // new node instead. | |
1284 for( i = 0; i < loop->_body.size(); i++ ) { | |
1285 Node *old = loop->_body.at(i); | |
1286 Node *nnn = old_new[old->_idx]; | |
1287 // Fix CFG/Loop controlling the new node | |
1288 if (has_ctrl(old)) { | |
1289 set_ctrl(nnn, old_new[get_ctrl(old)->_idx]); | |
1290 } else { | |
1291 set_loop(nnn, loop->_parent); | |
1292 if (old->outcnt() > 0) { | |
1293 set_idom( nnn, old_new[idom(old)->_idx], dd ); | |
1294 } | |
1295 } | |
1296 // Correct edges to the new node | |
1297 for( uint j = 0; j < nnn->req(); j++ ) { | |
1298 Node *n = nnn->in(j); | |
1299 if( n ) { | |
1300 IdealLoopTree *old_in_loop = get_loop( has_ctrl(n) ? get_ctrl(n) : n ); | |
1301 if( loop->is_member( old_in_loop ) ) | |
1302 nnn->set_req(j, old_new[n->_idx]); | |
1303 } | |
1304 } | |
1305 _igvn.hash_find_insert(nnn); | |
1306 } | |
1307 Node *newhead = old_new[loop->_head->_idx]; | |
1308 set_idom(newhead, newhead->in(LoopNode::EntryControl), dd); | |
1309 | |
1310 | |
1311 // Step 3: Now fix control uses. Loop varying control uses have already | |
1312 // been fixed up (as part of all input edges in Step 2). Loop invariant | |
1313 // control uses must be either an IfFalse or an IfTrue. Make a merge | |
1314 // point to merge the old and new IfFalse/IfTrue nodes; make the use | |
1315 // refer to this. | |
1316 ResourceArea *area = Thread::current()->resource_area(); | |
1317 Node_List worklist(area); | |
1318 uint new_counter = C->unique(); | |
1319 for( i = 0; i < loop->_body.size(); i++ ) { | |
1320 Node* old = loop->_body.at(i); | |
1321 if( !old->is_CFG() ) continue; | |
1322 Node* nnn = old_new[old->_idx]; | |
1323 | |
1324 // Copy uses to a worklist, so I can munge the def-use info | |
1325 // with impunity. | |
1326 for (DUIterator_Fast jmax, j = old->fast_outs(jmax); j < jmax; j++) | |
1327 worklist.push(old->fast_out(j)); | |
1328 | |
1329 while( worklist.size() ) { // Visit all uses | |
1330 Node *use = worklist.pop(); | |
1331 if (!has_node(use)) continue; // Ignore dead nodes | |
1332 IdealLoopTree *use_loop = get_loop( has_ctrl(use) ? get_ctrl(use) : use ); | |
1333 if( !loop->is_member( use_loop ) && use->is_CFG() ) { | |
1334 // Both OLD and USE are CFG nodes here. | |
1335 assert( use->is_Proj(), "" ); | |
1336 | |
1337 // Clone the loop exit control projection | |
1338 Node *newuse = use->clone(); | |
1339 newuse->set_req(0,nnn); | |
1340 _igvn.register_new_node_with_optimizer(newuse); | |
1341 set_loop(newuse, use_loop); | |
1342 set_idom(newuse, nnn, dom_depth(nnn) + 1 ); | |
1343 | |
1344 // We need a Region to merge the exit from the peeled body and the | |
1345 // exit from the old loop body. | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
1346 RegionNode *r = new (C) RegionNode(3); |
0 | 1347 // Map the old use to the new merge point |
1348 old_new.map( use->_idx, r ); | |
1349 uint dd_r = MIN2(dom_depth(newuse),dom_depth(use)); | |
1350 assert( dd_r >= dom_depth(dom_lca(newuse,use)), "" ); | |
1351 | |
1352 // The original user of 'use' uses 'r' instead. | |
1353 for (DUIterator_Last lmin, l = use->last_outs(lmin); l >= lmin;) { | |
1354 Node* useuse = use->last_out(l); | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1355 _igvn.rehash_node_delayed(useuse); |
0 | 1356 uint uses_found = 0; |
1357 if( useuse->in(0) == use ) { | |
1358 useuse->set_req(0, r); | |
1359 uses_found++; | |
1360 if( useuse->is_CFG() ) { | |
1361 assert( dom_depth(useuse) > dd_r, "" ); | |
1362 set_idom(useuse, r, dom_depth(useuse)); | |
1363 } | |
1364 } | |
1365 for( uint k = 1; k < useuse->req(); k++ ) { | |
1366 if( useuse->in(k) == use ) { | |
1367 useuse->set_req(k, r); | |
1368 uses_found++; | |
1369 } | |
1370 } | |
1371 l -= uses_found; // we deleted 1 or more copies of this edge | |
1372 } | |
1373 | |
1374 // Now finish up 'r' | |
1375 r->set_req( 1, newuse ); | |
1376 r->set_req( 2, use ); | |
1377 _igvn.register_new_node_with_optimizer(r); | |
1378 set_loop(r, use_loop); | |
1379 set_idom(r, !side_by_side_idom ? newuse->in(0) : side_by_side_idom, dd_r); | |
1380 } // End of if a loop-exit test | |
1381 } | |
1382 } | |
1383 | |
1384 // Step 4: If loop-invariant use is not control, it must be dominated by a | |
1385 // loop exit IfFalse/IfTrue. Find "proper" loop exit. Make a Region | |
1386 // there if needed. Make a Phi there merging old and new used values. | |
1387 Node_List *split_if_set = NULL; | |
1388 Node_List *split_bool_set = NULL; | |
1389 Node_List *split_cex_set = NULL; | |
1390 for( i = 0; i < loop->_body.size(); i++ ) { | |
1391 Node* old = loop->_body.at(i); | |
1392 Node* nnn = old_new[old->_idx]; | |
1393 // Copy uses to a worklist, so I can munge the def-use info | |
1394 // with impunity. | |
1395 for (DUIterator_Fast jmax, j = old->fast_outs(jmax); j < jmax; j++) | |
1396 worklist.push(old->fast_out(j)); | |
1397 | |
1398 while( worklist.size() ) { | |
1399 Node *use = worklist.pop(); | |
1400 if (!has_node(use)) continue; // Ignore dead nodes | |
1401 if (use->in(0) == C->top()) continue; | |
1402 IdealLoopTree *use_loop = get_loop( has_ctrl(use) ? get_ctrl(use) : use ); | |
1403 // Check for data-use outside of loop - at least one of OLD or USE | |
1404 // must not be a CFG node. | |
1405 if( !loop->is_member( use_loop ) && (!old->is_CFG() || !use->is_CFG())) { | |
1406 | |
1407 // If the Data use is an IF, that means we have an IF outside of the | |
1408 // loop that is switching on a condition that is set inside of the | |
1409 // loop. Happens if people set a loop-exit flag; then test the flag | |
1410 // in the loop to break the loop, then test is again outside of the | |
1411 // loop to determine which way the loop exited. | |
17978
ad51f24671c2
8046275: Fastdebug build failing on jdk9/hs/ control jobs after pulling some hs-comp changes
kvn
parents:
17887
diff
changeset
|
1412 // Loop predicate If node connects to Bool node through Opaque1 node. |
ad51f24671c2
8046275: Fastdebug build failing on jdk9/hs/ control jobs after pulling some hs-comp changes
kvn
parents:
17887
diff
changeset
|
1413 if (use->is_If() || use->is_CMove() || C->is_predicate_opaq(use)) { |
0 | 1414 // Since this code is highly unlikely, we lazily build the worklist |
1415 // of such Nodes to go split. | |
1416 if( !split_if_set ) | |
1417 split_if_set = new Node_List(area); | |
1418 split_if_set->push(use); | |
1419 } | |
1420 if( use->is_Bool() ) { | |
1421 if( !split_bool_set ) | |
1422 split_bool_set = new Node_List(area); | |
1423 split_bool_set->push(use); | |
1424 } | |
1425 if( use->Opcode() == Op_CreateEx ) { | |
1426 if( !split_cex_set ) | |
1427 split_cex_set = new Node_List(area); | |
1428 split_cex_set->push(use); | |
1429 } | |
1430 | |
1431 | |
1432 // Get "block" use is in | |
1433 uint idx = 0; | |
1434 while( use->in(idx) != old ) idx++; | |
1435 Node *prev = use->is_CFG() ? use : get_ctrl(use); | |
1436 assert( !loop->is_member( get_loop( prev ) ), "" ); | |
1437 Node *cfg = prev->_idx >= new_counter | |
1438 ? prev->in(2) | |
1439 : idom(prev); | |
1440 if( use->is_Phi() ) // Phi use is in prior block | |
1441 cfg = prev->in(idx); // NOT in block of Phi itself | |
1442 if (cfg->is_top()) { // Use is dead? | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1443 _igvn.replace_input_of(use, idx, C->top()); |
0 | 1444 continue; |
1445 } | |
1446 | |
1447 while( !loop->is_member( get_loop( cfg ) ) ) { | |
1448 prev = cfg; | |
1449 cfg = cfg->_idx >= new_counter ? cfg->in(2) : idom(cfg); | |
1450 } | |
1451 // If the use occurs after merging several exits from the loop, then | |
1452 // old value must have dominated all those exits. Since the same old | |
1453 // value was used on all those exits we did not need a Phi at this | |
1454 // merge point. NOW we do need a Phi here. Each loop exit value | |
1455 // is now merged with the peeled body exit; each exit gets its own | |
1456 // private Phi and those Phis need to be merged here. | |
1457 Node *phi; | |
1458 if( prev->is_Region() ) { | |
1459 if( idx == 0 ) { // Updating control edge? | |
1460 phi = prev; // Just use existing control | |
1461 } else { // Else need a new Phi | |
1462 phi = PhiNode::make( prev, old ); | |
1463 // Now recursively fix up the new uses of old! | |
1464 for( uint i = 1; i < prev->req(); i++ ) { | |
1465 worklist.push(phi); // Onto worklist once for each 'old' input | |
1466 } | |
1467 } | |
1468 } else { | |
1469 // Get new RegionNode merging old and new loop exits | |
1470 prev = old_new[prev->_idx]; | |
1471 assert( prev, "just made this in step 7" ); | |
1472 if( idx == 0 ) { // Updating control edge? | |
1473 phi = prev; // Just use existing control | |
1474 } else { // Else need a new Phi | |
1475 // Make a new Phi merging data values properly | |
1476 phi = PhiNode::make( prev, old ); | |
1477 phi->set_req( 1, nnn ); | |
1478 } | |
1479 } | |
1480 // If inserting a new Phi, check for prior hits | |
1481 if( idx != 0 ) { | |
1482 Node *hit = _igvn.hash_find_insert(phi); | |
1483 if( hit == NULL ) { | |
1484 _igvn.register_new_node_with_optimizer(phi); // Register new phi | |
1485 } else { // or | |
1486 // Remove the new phi from the graph and use the hit | |
1487 _igvn.remove_dead_node(phi); | |
1488 phi = hit; // Use existing phi | |
1489 } | |
1490 set_ctrl(phi, prev); | |
1491 } | |
1492 // Make 'use' use the Phi instead of the old loop body exit value | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1493 _igvn.replace_input_of(use, idx, phi); |
0 | 1494 if( use->_idx >= new_counter ) { // If updating new phis |
1495 // Not needed for correctness, but prevents a weak assert | |
1496 // in AddPNode from tripping (when we end up with different | |
1497 // base & derived Phis that will become the same after | |
1498 // IGVN does CSE). | |
1499 Node *hit = _igvn.hash_find_insert(use); | |
1500 if( hit ) // Go ahead and re-hash for hits. | |
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
1501 _igvn.replace_node( use, hit ); |
0 | 1502 } |
1503 | |
1504 // If 'use' was in the loop-exit block, it now needs to be sunk | |
1505 // below the post-loop merge point. | |
1506 sink_use( use, prev ); | |
1507 } | |
1508 } | |
1509 } | |
1510 | |
1511 // Check for IFs that need splitting/cloning. Happens if an IF outside of | |
1512 // the loop uses a condition set in the loop. The original IF probably | |
1513 // takes control from one or more OLD Regions (which in turn get from NEW | |
1514 // Regions). In any case, there will be a set of Phis for each merge point | |
1515 // from the IF up to where the original BOOL def exists the loop. | |
1516 if( split_if_set ) { | |
1517 while( split_if_set->size() ) { | |
1518 Node *iff = split_if_set->pop(); | |
1519 if( iff->in(1)->is_Phi() ) { | |
1520 BoolNode *b = clone_iff( iff->in(1)->as_Phi(), loop ); | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1521 _igvn.replace_input_of(iff, 1, b); |
0 | 1522 } |
1523 } | |
1524 } | |
1525 if( split_bool_set ) { | |
1526 while( split_bool_set->size() ) { | |
1527 Node *b = split_bool_set->pop(); | |
1528 Node *phi = b->in(1); | |
1529 assert( phi->is_Phi(), "" ); | |
1530 CmpNode *cmp = clone_bool( (PhiNode*)phi, loop ); | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1531 _igvn.replace_input_of(b, 1, cmp); |
0 | 1532 } |
1533 } | |
1534 if( split_cex_set ) { | |
1535 while( split_cex_set->size() ) { | |
1536 Node *b = split_cex_set->pop(); | |
1537 assert( b->in(0)->is_Region(), "" ); | |
1538 assert( b->in(1)->is_Phi(), "" ); | |
1539 assert( b->in(0)->in(0) == b->in(1)->in(0), "" ); | |
1540 split_up( b, b->in(0), NULL ); | |
1541 } | |
1542 } | |
1543 | |
1544 } | |
1545 | |
1546 | |
1547 //---------------------- stride_of_possible_iv ------------------------------------- | |
1548 // Looks for an iff/bool/comp with one operand of the compare | |
1549 // being a cycle involving an add and a phi, | |
1550 // with an optional truncation (left-shift followed by a right-shift) | |
1551 // of the add. Returns zero if not an iv. | |
1552 int PhaseIdealLoop::stride_of_possible_iv(Node* iff) { | |
1553 Node* trunc1 = NULL; | |
1554 Node* trunc2 = NULL; | |
1555 const TypeInt* ttype = NULL; | |
1556 if (!iff->is_If() || iff->in(1) == NULL || !iff->in(1)->is_Bool()) { | |
1557 return 0; | |
1558 } | |
1559 BoolNode* bl = iff->in(1)->as_Bool(); | |
1560 Node* cmp = bl->in(1); | |
1561 if (!cmp || cmp->Opcode() != Op_CmpI && cmp->Opcode() != Op_CmpU) { | |
1562 return 0; | |
1563 } | |
1564 // Must have an invariant operand | |
1565 if (is_member(get_loop(iff), get_ctrl(cmp->in(2)))) { | |
1566 return 0; | |
1567 } | |
1568 Node* add2 = NULL; | |
1569 Node* cmp1 = cmp->in(1); | |
1570 if (cmp1->is_Phi()) { | |
1571 // (If (Bool (CmpX phi:(Phi ...(Optional-trunc(AddI phi add2))) ))) | |
1572 Node* phi = cmp1; | |
1573 for (uint i = 1; i < phi->req(); i++) { | |
1574 Node* in = phi->in(i); | |
1575 Node* add = CountedLoopNode::match_incr_with_optional_truncation(in, | |
1576 &trunc1, &trunc2, &ttype); | |
1577 if (add && add->in(1) == phi) { | |
1578 add2 = add->in(2); | |
1579 break; | |
1580 } | |
1581 } | |
1582 } else { | |
1583 // (If (Bool (CmpX addtrunc:(Optional-trunc((AddI (Phi ...addtrunc...) add2)) ))) | |
1584 Node* addtrunc = cmp1; | |
1585 Node* add = CountedLoopNode::match_incr_with_optional_truncation(addtrunc, | |
1586 &trunc1, &trunc2, &ttype); | |
1587 if (add && add->in(1)->is_Phi()) { | |
1588 Node* phi = add->in(1); | |
1589 for (uint i = 1; i < phi->req(); i++) { | |
1590 if (phi->in(i) == addtrunc) { | |
1591 add2 = add->in(2); | |
1592 break; | |
1593 } | |
1594 } | |
1595 } | |
1596 } | |
1597 if (add2 != NULL) { | |
1598 const TypeInt* add2t = _igvn.type(add2)->is_int(); | |
1599 if (add2t->is_con()) { | |
1600 return add2t->get_con(); | |
1601 } | |
1602 } | |
1603 return 0; | |
1604 } | |
1605 | |
1606 | |
1607 //---------------------- stay_in_loop ------------------------------------- | |
1608 // Return the (unique) control output node that's in the loop (if it exists.) | |
1609 Node* PhaseIdealLoop::stay_in_loop( Node* n, IdealLoopTree *loop) { | |
1610 Node* unique = NULL; | |
1611 if (!n) return NULL; | |
1612 for (DUIterator_Fast imax, i = n->fast_outs(imax); i < imax; i++) { | |
1613 Node* use = n->fast_out(i); | |
1614 if (!has_ctrl(use) && loop->is_member(get_loop(use))) { | |
1615 if (unique != NULL) { | |
1616 return NULL; | |
1617 } | |
1618 unique = use; | |
1619 } | |
1620 } | |
1621 return unique; | |
1622 } | |
1623 | |
1624 //------------------------------ register_node ------------------------------------- | |
1625 // Utility to register node "n" with PhaseIdealLoop | |
1626 void PhaseIdealLoop::register_node(Node* n, IdealLoopTree *loop, Node* pred, int ddepth) { | |
1627 _igvn.register_new_node_with_optimizer(n); | |
1628 loop->_body.push(n); | |
1629 if (n->is_CFG()) { | |
1630 set_loop(n, loop); | |
1631 set_idom(n, pred, ddepth); | |
1632 } else { | |
1633 set_ctrl(n, pred); | |
1634 } | |
1635 } | |
1636 | |
1637 //------------------------------ proj_clone ------------------------------------- | |
1638 // Utility to create an if-projection | |
1639 ProjNode* PhaseIdealLoop::proj_clone(ProjNode* p, IfNode* iff) { | |
1640 ProjNode* c = p->clone()->as_Proj(); | |
1641 c->set_req(0, iff); | |
1642 return c; | |
1643 } | |
1644 | |
1645 //------------------------------ short_circuit_if ------------------------------------- | |
1646 // Force the iff control output to be the live_proj | |
1647 Node* PhaseIdealLoop::short_circuit_if(IfNode* iff, ProjNode* live_proj) { | |
8774
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
1648 guarantee(live_proj != NULL, "null projection"); |
0 | 1649 int proj_con = live_proj->_con; |
1650 assert(proj_con == 0 || proj_con == 1, "false or true projection"); | |
1651 Node *con = _igvn.intcon(proj_con); | |
1652 set_ctrl(con, C->root()); | |
1653 if (iff) { | |
1654 iff->set_req(1, con); | |
1655 } | |
1656 return con; | |
1657 } | |
1658 | |
1659 //------------------------------ insert_if_before_proj ------------------------------------- | |
1660 // Insert a new if before an if projection (* - new node) | |
1661 // | |
1662 // before | |
1663 // if(test) | |
1664 // / \ | |
1665 // v v | |
1666 // other-proj proj (arg) | |
1667 // | |
1668 // after | |
1669 // if(test) | |
1670 // / \ | |
1671 // / v | |
1672 // | * proj-clone | |
1673 // v | | |
1674 // other-proj v | |
1675 // * new_if(relop(cmp[IU](left,right))) | |
1676 // / \ | |
1677 // v v | |
1678 // * new-proj proj | |
1679 // (returned) | |
1680 // | |
1681 ProjNode* PhaseIdealLoop::insert_if_before_proj(Node* left, bool Signed, BoolTest::mask relop, Node* right, ProjNode* proj) { | |
1682 IfNode* iff = proj->in(0)->as_If(); | |
1683 IdealLoopTree *loop = get_loop(proj); | |
1684 ProjNode *other_proj = iff->proj_out(!proj->is_IfTrue())->as_Proj(); | |
1685 int ddepth = dom_depth(proj); | |
1686 | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1687 _igvn.rehash_node_delayed(iff); |
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1688 _igvn.rehash_node_delayed(proj); |
0 | 1689 |
1690 proj->set_req(0, NULL); // temporary disconnect | |
1691 ProjNode* proj2 = proj_clone(proj, iff); | |
1692 register_node(proj2, loop, iff, ddepth); | |
1693 | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
1694 Node* cmp = Signed ? (Node*) new (C)CmpINode(left, right) : (Node*) new (C)CmpUNode(left, right); |
0 | 1695 register_node(cmp, loop, proj2, ddepth); |
1696 | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
1697 BoolNode* bol = new (C)BoolNode(cmp, relop); |
0 | 1698 register_node(bol, loop, proj2, ddepth); |
1699 | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
1700 IfNode* new_if = new (C)IfNode(proj2, bol, iff->_prob, iff->_fcnt); |
0 | 1701 register_node(new_if, loop, proj2, ddepth); |
1702 | |
1703 proj->set_req(0, new_if); // reattach | |
1704 set_idom(proj, new_if, ddepth); | |
1705 | |
1706 ProjNode* new_exit = proj_clone(other_proj, new_if)->as_Proj(); | |
8774
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
1707 guarantee(new_exit != NULL, "null exit node"); |
0 | 1708 register_node(new_exit, get_loop(other_proj), new_if, ddepth); |
1709 | |
1710 return new_exit; | |
1711 } | |
1712 | |
1713 //------------------------------ insert_region_before_proj ------------------------------------- | |
1714 // Insert a region before an if projection (* - new node) | |
1715 // | |
1716 // before | |
1717 // if(test) | |
1718 // / | | |
1719 // v | | |
1720 // proj v | |
1721 // other-proj | |
1722 // | |
1723 // after | |
1724 // if(test) | |
1725 // / | | |
1726 // v | | |
1727 // * proj-clone v | |
1728 // | other-proj | |
1729 // v | |
1730 // * new-region | |
1731 // | | |
1732 // v | |
1733 // * dum_if | |
1734 // / \ | |
1735 // v \ | |
1736 // * dum-proj v | |
1737 // proj | |
1738 // | |
1739 RegionNode* PhaseIdealLoop::insert_region_before_proj(ProjNode* proj) { | |
1740 IfNode* iff = proj->in(0)->as_If(); | |
1741 IdealLoopTree *loop = get_loop(proj); | |
1742 ProjNode *other_proj = iff->proj_out(!proj->is_IfTrue())->as_Proj(); | |
1743 int ddepth = dom_depth(proj); | |
1744 | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1745 _igvn.rehash_node_delayed(iff); |
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1746 _igvn.rehash_node_delayed(proj); |
0 | 1747 |
1748 proj->set_req(0, NULL); // temporary disconnect | |
1749 ProjNode* proj2 = proj_clone(proj, iff); | |
1750 register_node(proj2, loop, iff, ddepth); | |
1751 | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
1752 RegionNode* reg = new (C)RegionNode(2); |
0 | 1753 reg->set_req(1, proj2); |
1754 register_node(reg, loop, iff, ddepth); | |
1755 | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
1756 IfNode* dum_if = new (C)IfNode(reg, short_circuit_if(NULL, proj), iff->_prob, iff->_fcnt); |
0 | 1757 register_node(dum_if, loop, reg, ddepth); |
1758 | |
1759 proj->set_req(0, dum_if); // reattach | |
1760 set_idom(proj, dum_if, ddepth); | |
1761 | |
1762 ProjNode* dum_proj = proj_clone(other_proj, dum_if); | |
1763 register_node(dum_proj, loop, dum_if, ddepth); | |
1764 | |
1765 return reg; | |
1766 } | |
1767 | |
1768 //------------------------------ insert_cmpi_loop_exit ------------------------------------- | |
1769 // Clone a signed compare loop exit from an unsigned compare and | |
1770 // insert it before the unsigned cmp on the stay-in-loop path. | |
1771 // All new nodes inserted in the dominator tree between the original | |
1772 // if and it's projections. The original if test is replaced with | |
1773 // a constant to force the stay-in-loop path. | |
1774 // | |
1775 // This is done to make sure that the original if and it's projections | |
1776 // still dominate the same set of control nodes, that the ctrl() relation | |
1777 // from data nodes to them is preserved, and that their loop nesting is | |
1778 // preserved. | |
1779 // | |
1780 // before | |
1781 // if(i <u limit) unsigned compare loop exit | |
1782 // / | | |
1783 // v v | |
1784 // exit-proj stay-in-loop-proj | |
1785 // | |
1786 // after | |
1787 // if(stay-in-loop-const) original if | |
1788 // / | | |
1789 // / v | |
1790 // / if(i < limit) new signed test | |
1791 // / / | | |
1792 // / / v | |
1793 // / / if(i <u limit) new cloned unsigned test | |
1794 // / / / | | |
1795 // v v v | | |
1796 // region | | |
1797 // | | | |
1798 // dum-if | | |
1799 // / | | | |
1800 // ether | | | |
1801 // v v | |
1802 // exit-proj stay-in-loop-proj | |
1803 // | |
1804 IfNode* PhaseIdealLoop::insert_cmpi_loop_exit(IfNode* if_cmpu, IdealLoopTree *loop) { | |
1805 const bool Signed = true; | |
1806 const bool Unsigned = false; | |
1807 | |
1808 BoolNode* bol = if_cmpu->in(1)->as_Bool(); | |
1809 if (bol->_test._test != BoolTest::lt) return NULL; | |
1810 CmpNode* cmpu = bol->in(1)->as_Cmp(); | |
1811 if (cmpu->Opcode() != Op_CmpU) return NULL; | |
1812 int stride = stride_of_possible_iv(if_cmpu); | |
1813 if (stride == 0) return NULL; | |
1814 | |
8774
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
1815 Node* lp_proj = stay_in_loop(if_cmpu, loop); |
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
1816 guarantee(lp_proj != NULL, "null loop node"); |
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
1817 |
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
1818 ProjNode* lp_continue = lp_proj->as_Proj(); |
0 | 1819 ProjNode* lp_exit = if_cmpu->proj_out(!lp_continue->is_IfTrue())->as_Proj(); |
1820 | |
1821 Node* limit = NULL; | |
1822 if (stride > 0) { | |
1823 limit = cmpu->in(2); | |
1824 } else { | |
1825 limit = _igvn.makecon(TypeInt::ZERO); | |
1826 set_ctrl(limit, C->root()); | |
1827 } | |
1828 // Create a new region on the exit path | |
1829 RegionNode* reg = insert_region_before_proj(lp_exit); | |
8774
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
1830 guarantee(reg != NULL, "null region node"); |
0 | 1831 |
1832 // Clone the if-cmpu-true-false using a signed compare | |
1833 BoolTest::mask rel_i = stride > 0 ? bol->_test._test : BoolTest::ge; | |
1834 ProjNode* cmpi_exit = insert_if_before_proj(cmpu->in(1), Signed, rel_i, limit, lp_continue); | |
1835 reg->add_req(cmpi_exit); | |
1836 | |
1837 // Clone the if-cmpu-true-false | |
1838 BoolTest::mask rel_u = bol->_test._test; | |
1839 ProjNode* cmpu_exit = insert_if_before_proj(cmpu->in(1), Unsigned, rel_u, cmpu->in(2), lp_continue); | |
1840 reg->add_req(cmpu_exit); | |
1841 | |
1842 // Force original if to stay in loop. | |
1843 short_circuit_if(if_cmpu, lp_continue); | |
1844 | |
1845 return cmpi_exit->in(0)->as_If(); | |
1846 } | |
1847 | |
1848 //------------------------------ remove_cmpi_loop_exit ------------------------------------- | |
1849 // Remove a previously inserted signed compare loop exit. | |
1850 void PhaseIdealLoop::remove_cmpi_loop_exit(IfNode* if_cmp, IdealLoopTree *loop) { | |
1851 Node* lp_proj = stay_in_loop(if_cmp, loop); | |
1852 assert(if_cmp->in(1)->in(1)->Opcode() == Op_CmpI && | |
1853 stay_in_loop(lp_proj, loop)->is_If() && | |
1854 stay_in_loop(lp_proj, loop)->in(1)->in(1)->Opcode() == Op_CmpU, "inserted cmpi before cmpu"); | |
1855 Node *con = _igvn.makecon(lp_proj->is_IfTrue() ? TypeInt::ONE : TypeInt::ZERO); | |
1856 set_ctrl(con, C->root()); | |
1857 if_cmp->set_req(1, con); | |
1858 } | |
1859 | |
1860 //------------------------------ scheduled_nodelist ------------------------------------- | |
1861 // Create a post order schedule of nodes that are in the | |
1862 // "member" set. The list is returned in "sched". | |
1863 // The first node in "sched" is the loop head, followed by | |
1864 // nodes which have no inputs in the "member" set, and then | |
1865 // followed by the nodes that have an immediate input dependence | |
1866 // on a node in "sched". | |
1867 void PhaseIdealLoop::scheduled_nodelist( IdealLoopTree *loop, VectorSet& member, Node_List &sched ) { | |
1868 | |
1869 assert(member.test(loop->_head->_idx), "loop head must be in member set"); | |
1870 Arena *a = Thread::current()->resource_area(); | |
1871 VectorSet visited(a); | |
1872 Node_Stack nstack(a, loop->_body.size()); | |
1873 | |
1874 Node* n = loop->_head; // top of stack is cached in "n" | |
1875 uint idx = 0; | |
1876 visited.set(n->_idx); | |
1877 | |
1878 // Initially push all with no inputs from within member set | |
1879 for(uint i = 0; i < loop->_body.size(); i++ ) { | |
1880 Node *elt = loop->_body.at(i); | |
1881 if (member.test(elt->_idx)) { | |
1882 bool found = false; | |
1883 for (uint j = 0; j < elt->req(); j++) { | |
1884 Node* def = elt->in(j); | |
1885 if (def && member.test(def->_idx) && def != elt) { | |
1886 found = true; | |
1887 break; | |
1888 } | |
1889 } | |
1890 if (!found && elt != loop->_head) { | |
1891 nstack.push(n, idx); | |
1892 n = elt; | |
1893 assert(!visited.test(n->_idx), "not seen yet"); | |
1894 visited.set(n->_idx); | |
1895 } | |
1896 } | |
1897 } | |
1898 | |
1899 // traverse out's that are in the member set | |
1900 while (true) { | |
1901 if (idx < n->outcnt()) { | |
1902 Node* use = n->raw_out(idx); | |
1903 idx++; | |
1904 if (!visited.test_set(use->_idx)) { | |
1905 if (member.test(use->_idx)) { | |
1906 nstack.push(n, idx); | |
1907 n = use; | |
1908 idx = 0; | |
1909 } | |
1910 } | |
1911 } else { | |
1912 // All outputs processed | |
1913 sched.push(n); | |
1914 if (nstack.is_empty()) break; | |
1915 n = nstack.node(); | |
1916 idx = nstack.index(); | |
1917 nstack.pop(); | |
1918 } | |
1919 } | |
1920 } | |
1921 | |
1922 | |
1923 //------------------------------ has_use_in_set ------------------------------------- | |
1924 // Has a use in the vector set | |
1925 bool PhaseIdealLoop::has_use_in_set( Node* n, VectorSet& vset ) { | |
1926 for (DUIterator_Fast jmax, j = n->fast_outs(jmax); j < jmax; j++) { | |
1927 Node* use = n->fast_out(j); | |
1928 if (vset.test(use->_idx)) { | |
1929 return true; | |
1930 } | |
1931 } | |
1932 return false; | |
1933 } | |
1934 | |
1935 | |
1936 //------------------------------ has_use_internal_to_set ------------------------------------- | |
1937 // Has use internal to the vector set (ie. not in a phi at the loop head) | |
1938 bool PhaseIdealLoop::has_use_internal_to_set( Node* n, VectorSet& vset, IdealLoopTree *loop ) { | |
1939 Node* head = loop->_head; | |
1940 for (DUIterator_Fast jmax, j = n->fast_outs(jmax); j < jmax; j++) { | |
1941 Node* use = n->fast_out(j); | |
1942 if (vset.test(use->_idx) && !(use->is_Phi() && use->in(0) == head)) { | |
1943 return true; | |
1944 } | |
1945 } | |
1946 return false; | |
1947 } | |
1948 | |
1949 | |
1950 //------------------------------ clone_for_use_outside_loop ------------------------------------- | |
1951 // clone "n" for uses that are outside of loop | |
10322
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
1952 int PhaseIdealLoop::clone_for_use_outside_loop( IdealLoopTree *loop, Node* n, Node_List& worklist ) { |
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
1953 int cloned = 0; |
0 | 1954 assert(worklist.size() == 0, "should be empty"); |
1955 for (DUIterator_Fast jmax, j = n->fast_outs(jmax); j < jmax; j++) { | |
1956 Node* use = n->fast_out(j); | |
1957 if( !loop->is_member(get_loop(has_ctrl(use) ? get_ctrl(use) : use)) ) { | |
1958 worklist.push(use); | |
1959 } | |
1960 } | |
1961 while( worklist.size() ) { | |
1962 Node *use = worklist.pop(); | |
1963 if (!has_node(use) || use->in(0) == C->top()) continue; | |
1964 uint j; | |
1965 for (j = 0; j < use->req(); j++) { | |
1966 if (use->in(j) == n) break; | |
1967 } | |
1968 assert(j < use->req(), "must be there"); | |
1969 | |
1970 // clone "n" and insert it between the inputs of "n" and the use outside the loop | |
1971 Node* n_clone = n->clone(); | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1972 _igvn.replace_input_of(use, j, n_clone); |
10322
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
1973 cloned++; |
251 | 1974 Node* use_c; |
0 | 1975 if (!use->is_Phi()) { |
251 | 1976 use_c = has_ctrl(use) ? get_ctrl(use) : use->in(0); |
0 | 1977 } else { |
1978 // Use in a phi is considered a use in the associated predecessor block | |
251 | 1979 use_c = use->in(0)->in(j); |
0 | 1980 } |
251 | 1981 set_ctrl(n_clone, use_c); |
1982 assert(!loop->is_member(get_loop(use_c)), "should be outside loop"); | |
1983 get_loop(use_c)->_body.push(n_clone); | |
0 | 1984 _igvn.register_new_node_with_optimizer(n_clone); |
1985 #if !defined(PRODUCT) | |
1986 if (TracePartialPeeling) { | |
1987 tty->print_cr("loop exit cloning old: %d new: %d newbb: %d", n->_idx, n_clone->_idx, get_ctrl(n_clone)->_idx); | |
1988 } | |
1989 #endif | |
1990 } | |
10322
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
1991 return cloned; |
0 | 1992 } |
1993 | |
1994 | |
1995 //------------------------------ clone_for_special_use_inside_loop ------------------------------------- | |
1996 // clone "n" for special uses that are in the not_peeled region. | |
1997 // If these def-uses occur in separate blocks, the code generator | |
1998 // marks the method as not compilable. For example, if a "BoolNode" | |
1999 // is in a different basic block than the "IfNode" that uses it, then | |
2000 // the compilation is aborted in the code generator. | |
2001 void PhaseIdealLoop::clone_for_special_use_inside_loop( IdealLoopTree *loop, Node* n, | |
2002 VectorSet& not_peel, Node_List& sink_list, Node_List& worklist ) { | |
2003 if (n->is_Phi() || n->is_Load()) { | |
2004 return; | |
2005 } | |
2006 assert(worklist.size() == 0, "should be empty"); | |
2007 for (DUIterator_Fast jmax, j = n->fast_outs(jmax); j < jmax; j++) { | |
2008 Node* use = n->fast_out(j); | |
2009 if ( not_peel.test(use->_idx) && | |
2010 (use->is_If() || use->is_CMove() || use->is_Bool()) && | |
2011 use->in(1) == n) { | |
2012 worklist.push(use); | |
2013 } | |
2014 } | |
2015 if (worklist.size() > 0) { | |
2016 // clone "n" and insert it between inputs of "n" and the use | |
2017 Node* n_clone = n->clone(); | |
2018 loop->_body.push(n_clone); | |
2019 _igvn.register_new_node_with_optimizer(n_clone); | |
2020 set_ctrl(n_clone, get_ctrl(n)); | |
2021 sink_list.push(n_clone); | |
2022 not_peel <<= n_clone->_idx; // add n_clone to not_peel set. | |
2023 #if !defined(PRODUCT) | |
2024 if (TracePartialPeeling) { | |
2025 tty->print_cr("special not_peeled cloning old: %d new: %d", n->_idx, n_clone->_idx); | |
2026 } | |
2027 #endif | |
2028 while( worklist.size() ) { | |
2029 Node *use = worklist.pop(); | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2030 _igvn.rehash_node_delayed(use); |
0 | 2031 for (uint j = 1; j < use->req(); j++) { |
2032 if (use->in(j) == n) { | |
2033 use->set_req(j, n_clone); | |
2034 } | |
2035 } | |
2036 } | |
2037 } | |
2038 } | |
2039 | |
2040 | |
2041 //------------------------------ insert_phi_for_loop ------------------------------------- | |
2042 // Insert phi(lp_entry_val, back_edge_val) at use->in(idx) for loop lp if phi does not already exist | |
2043 void PhaseIdealLoop::insert_phi_for_loop( Node* use, uint idx, Node* lp_entry_val, Node* back_edge_val, LoopNode* lp ) { | |
2044 Node *phi = PhiNode::make(lp, back_edge_val); | |
2045 phi->set_req(LoopNode::EntryControl, lp_entry_val); | |
2046 // Use existing phi if it already exists | |
2047 Node *hit = _igvn.hash_find_insert(phi); | |
2048 if( hit == NULL ) { | |
2049 _igvn.register_new_node_with_optimizer(phi); | |
2050 set_ctrl(phi, lp); | |
2051 } else { | |
2052 // Remove the new phi from the graph and use the hit | |
2053 _igvn.remove_dead_node(phi); | |
2054 phi = hit; | |
2055 } | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2056 _igvn.replace_input_of(use, idx, phi); |
0 | 2057 } |
2058 | |
2059 #ifdef ASSERT | |
2060 //------------------------------ is_valid_loop_partition ------------------------------------- | |
2061 // Validate the loop partition sets: peel and not_peel | |
2062 bool PhaseIdealLoop::is_valid_loop_partition( IdealLoopTree *loop, VectorSet& peel, Node_List& peel_list, | |
2063 VectorSet& not_peel ) { | |
2064 uint i; | |
2065 // Check that peel_list entries are in the peel set | |
2066 for (i = 0; i < peel_list.size(); i++) { | |
2067 if (!peel.test(peel_list.at(i)->_idx)) { | |
2068 return false; | |
2069 } | |
2070 } | |
2071 // Check at loop members are in one of peel set or not_peel set | |
2072 for (i = 0; i < loop->_body.size(); i++ ) { | |
2073 Node *def = loop->_body.at(i); | |
2074 uint di = def->_idx; | |
2075 // Check that peel set elements are in peel_list | |
2076 if (peel.test(di)) { | |
2077 if (not_peel.test(di)) { | |
2078 return false; | |
2079 } | |
2080 // Must be in peel_list also | |
2081 bool found = false; | |
2082 for (uint j = 0; j < peel_list.size(); j++) { | |
2083 if (peel_list.at(j)->_idx == di) { | |
2084 found = true; | |
2085 break; | |
2086 } | |
2087 } | |
2088 if (!found) { | |
2089 return false; | |
2090 } | |
2091 } else if (not_peel.test(di)) { | |
2092 if (peel.test(di)) { | |
2093 return false; | |
2094 } | |
2095 } else { | |
2096 return false; | |
2097 } | |
2098 } | |
2099 return true; | |
2100 } | |
2101 | |
2102 //------------------------------ is_valid_clone_loop_exit_use ------------------------------------- | |
2103 // Ensure a use outside of loop is of the right form | |
2104 bool PhaseIdealLoop::is_valid_clone_loop_exit_use( IdealLoopTree *loop, Node* use, uint exit_idx) { | |
2105 Node *use_c = has_ctrl(use) ? get_ctrl(use) : use; | |
2106 return (use->is_Phi() && | |
2107 use_c->is_Region() && use_c->req() == 3 && | |
2108 (use_c->in(exit_idx)->Opcode() == Op_IfTrue || | |
2109 use_c->in(exit_idx)->Opcode() == Op_IfFalse || | |
2110 use_c->in(exit_idx)->Opcode() == Op_JumpProj) && | |
2111 loop->is_member( get_loop( use_c->in(exit_idx)->in(0) ) ) ); | |
2112 } | |
2113 | |
2114 //------------------------------ is_valid_clone_loop_form ------------------------------------- | |
2115 // Ensure that all uses outside of loop are of the right form | |
2116 bool PhaseIdealLoop::is_valid_clone_loop_form( IdealLoopTree *loop, Node_List& peel_list, | |
2117 uint orig_exit_idx, uint clone_exit_idx) { | |
2118 uint len = peel_list.size(); | |
2119 for (uint i = 0; i < len; i++) { | |
2120 Node *def = peel_list.at(i); | |
2121 | |
2122 for (DUIterator_Fast jmax, j = def->fast_outs(jmax); j < jmax; j++) { | |
2123 Node *use = def->fast_out(j); | |
2124 Node *use_c = has_ctrl(use) ? get_ctrl(use) : use; | |
2125 if (!loop->is_member(get_loop(use_c))) { | |
2126 // use is not in the loop, check for correct structure | |
2127 if (use->in(0) == def) { | |
2128 // Okay | |
2129 } else if (!is_valid_clone_loop_exit_use(loop, use, orig_exit_idx)) { | |
2130 return false; | |
2131 } | |
2132 } | |
2133 } | |
2134 } | |
2135 return true; | |
2136 } | |
2137 #endif | |
2138 | |
2139 //------------------------------ partial_peel ------------------------------------- | |
2140 // Partially peel (aka loop rotation) the top portion of a loop (called | |
2141 // the peel section below) by cloning it and placing one copy just before | |
2142 // the new loop head and the other copy at the bottom of the new loop. | |
2143 // | |
2144 // before after where it came from | |
2145 // | |
2146 // stmt1 stmt1 | |
2147 // loop: stmt2 clone | |
2148 // stmt2 if condA goto exitA clone | |
2149 // if condA goto exitA new_loop: new | |
2150 // stmt3 stmt3 clone | |
2151 // if !condB goto loop if condB goto exitB clone | |
2152 // exitB: stmt2 orig | |
2153 // stmt4 if !condA goto new_loop orig | |
2154 // exitA: goto exitA | |
2155 // exitB: | |
2156 // stmt4 | |
2157 // exitA: | |
2158 // | |
2159 // Step 1: find the cut point: an exit test on probable | |
2160 // induction variable. | |
2161 // Step 2: schedule (with cloning) operations in the peel | |
2162 // section that can be executed after the cut into | |
2163 // the section that is not peeled. This may need | |
2164 // to clone operations into exit blocks. For | |
2165 // instance, a reference to A[i] in the not-peel | |
2166 // section and a reference to B[i] in an exit block | |
2167 // may cause a left-shift of i by 2 to be placed | |
2168 // in the peel block. This step will clone the left | |
2169 // shift into the exit block and sink the left shift | |
2170 // from the peel to the not-peel section. | |
2171 // Step 3: clone the loop, retarget the control, and insert | |
2172 // phis for values that are live across the new loop | |
2173 // head. This is very dependent on the graph structure | |
2174 // from clone_loop. It creates region nodes for | |
2175 // exit control and associated phi nodes for values | |
2176 // flow out of the loop through that exit. The region | |
2177 // node is dominated by the clone's control projection. | |
2178 // So the clone's peel section is placed before the | |
2179 // new loop head, and the clone's not-peel section is | |
2180 // forms the top part of the new loop. The original | |
2181 // peel section forms the tail of the new loop. | |
2182 // Step 4: update the dominator tree and recompute the | |
2183 // dominator depth. | |
2184 // | |
2185 // orig | |
2186 // | |
2445 | 2187 // stmt1 |
2188 // | | |
2189 // v | |
2190 // loop predicate | |
2191 // | | |
2192 // v | |
0 | 2193 // loop<----+ |
2194 // | | | |
2195 // stmt2 | | |
2196 // | | | |
2197 // v | | |
2198 // ifA | | |
2199 // / | | | |
2200 // v v | | |
2201 // false true ^ <-- last_peel | |
2202 // / | | | |
2203 // / ===|==cut | | |
2204 // / stmt3 | <-- first_not_peel | |
2205 // / | | | |
2206 // | v | | |
2207 // v ifB | | |
2208 // exitA: / \ | | |
2209 // / \ | | |
2210 // v v | | |
2211 // false true | | |
2212 // / \ | | |
2213 // / ----+ | |
2214 // | | |
2215 // v | |
2216 // exitB: | |
2217 // stmt4 | |
2218 // | |
2219 // | |
2220 // after clone loop | |
2221 // | |
2222 // stmt1 | |
2445 | 2223 // | |
2224 // v | |
2225 // loop predicate | |
0 | 2226 // / \ |
2227 // clone / \ orig | |
2228 // / \ | |
2229 // / \ | |
2230 // v v | |
2231 // +---->loop loop<----+ | |
2232 // | | | | | |
2233 // | stmt2 stmt2 | | |
2234 // | | | | | |
2235 // | v v | | |
2236 // | ifA ifA | | |
2237 // | | \ / | | | |
2238 // | v v v v | | |
2239 // ^ true false false true ^ <-- last_peel | |
2240 // | | ^ \ / | | | |
2241 // | cut==|== \ \ / ===|==cut | | |
2242 // | stmt3 \ \ / stmt3 | <-- first_not_peel | |
2243 // | | dom | | | | | |
2244 // | v \ 1v v2 v | | |
2245 // | ifB regionA ifB | | |
2246 // | / \ | / \ | | |
2247 // | / \ v / \ | | |
2248 // | v v exitA: v v | | |
2249 // | true false false true | | |
2250 // | / ^ \ / \ | | |
2251 // +---- \ \ / ----+ | |
2252 // dom \ / | |
2253 // \ 1v v2 | |
2254 // regionB | |
2255 // | | |
2256 // v | |
2257 // exitB: | |
2258 // stmt4 | |
2259 // | |
2260 // | |
2261 // after partial peel | |
2262 // | |
2263 // stmt1 | |
2445 | 2264 // | |
2265 // v | |
2266 // loop predicate | |
0 | 2267 // / |
2268 // clone / orig | |
2269 // / TOP | |
2270 // / \ | |
2271 // v v | |
2445 | 2272 // TOP->loop loop----+ |
0 | 2273 // | | | |
2274 // stmt2 stmt2 | | |
2275 // | | | | |
2276 // v v | | |
2277 // ifA ifA | | |
2278 // | \ / | | | |
2279 // v v v v | | |
2280 // true false false true | <-- last_peel | |
2281 // | ^ \ / +------|---+ | |
2282 // +->newloop \ \ / === ==cut | | | |
2283 // | stmt3 \ \ / TOP | | | |
2284 // | | dom | | stmt3 | | <-- first_not_peel | |
2285 // | v \ 1v v2 v | | | |
2286 // | ifB regionA ifB ^ v | |
2287 // | / \ | / \ | | | |
2288 // | / \ v / \ | | | |
2289 // | v v exitA: v v | | | |
2290 // | true false false true | | | |
2291 // | / ^ \ / \ | | | |
2292 // | | \ \ / v | | | |
2293 // | | dom \ / TOP | | | |
2294 // | | \ 1v v2 | | | |
2295 // ^ v regionB | | | |
2296 // | | | | | | |
2297 // | | v ^ v | |
2298 // | | exitB: | | | |
2299 // | | stmt4 | | | |
2300 // | +------------>-----------------+ | | |
2301 // | | | |
2302 // +-----------------<---------------------+ | |
2303 // | |
2304 // | |
2305 // final graph | |
2306 // | |
2307 // stmt1 | |
2308 // | | |
2309 // v | |
3281
273b56978029
7039586: test/java/util/Collections/Rotate.java failing with hs21-b09
kvn
parents:
2468
diff
changeset
|
2310 // loop predicate |
273b56978029
7039586: test/java/util/Collections/Rotate.java failing with hs21-b09
kvn
parents:
2468
diff
changeset
|
2311 // | |
273b56978029
7039586: test/java/util/Collections/Rotate.java failing with hs21-b09
kvn
parents:
2468
diff
changeset
|
2312 // v |
2445 | 2313 // stmt2 clone |
2314 // | | |
2315 // v | |
0 | 2316 // ........> ifA clone |
2317 // : / | | |
2318 // dom / | | |
2319 // : v v | |
2320 // : false true | |
2321 // : | | | |
2445 | 2322 // : | v |
0 | 2323 // : | newloop<-----+ |
2324 // : | | | | |
2325 // : | stmt3 clone | | |
2326 // : | | | | |
2327 // : | v | | |
2328 // : | ifB | | |
2329 // : | / \ | | |
2330 // : | v v | | |
2331 // : | false true | | |
2332 // : | | | | | |
2333 // : | v stmt2 | | |
2334 // : | exitB: | | | |
2335 // : | stmt4 v | | |
2336 // : | ifA orig | | |
2337 // : | / \ | | |
2338 // : | / \ | | |
2339 // : | v v | | |
2340 // : | false true | | |
2341 // : | / \ | | |
2342 // : v v -----+ | |
2343 // RegionA | |
2344 // | | |
2345 // v | |
2346 // exitA | |
2347 // | |
2348 bool PhaseIdealLoop::partial_peel( IdealLoopTree *loop, Node_List &old_new ) { | |
2349 | |
2445 | 2350 assert(!loop->_head->is_CountedLoop(), "Non-counted loop only"); |
108 | 2351 if (!loop->_head->is_Loop()) { |
2352 return false; } | |
2353 | |
0 | 2354 LoopNode *head = loop->_head->as_Loop(); |
2355 | |
2356 if (head->is_partial_peel_loop() || head->partial_peel_has_failed()) { | |
2357 return false; | |
2358 } | |
2359 | |
2360 // Check for complex exit control | |
2361 for(uint ii = 0; ii < loop->_body.size(); ii++ ) { | |
2362 Node *n = loop->_body.at(ii); | |
2363 int opc = n->Opcode(); | |
2364 if (n->is_Call() || | |
2365 opc == Op_Catch || | |
2366 opc == Op_CatchProj || | |
2367 opc == Op_Jump || | |
17726
085b304a1cc5
8027754: Enable loop optimizations for loops with MathExact inside
rbackman
parents:
17671
diff
changeset
|
2368 opc == Op_JumpProj) { |
0 | 2369 #if !defined(PRODUCT) |
2370 if (TracePartialPeeling) { | |
2371 tty->print_cr("\nExit control too complex: lp: %d", head->_idx); | |
2372 } | |
2373 #endif | |
2374 return false; | |
2375 } | |
2376 } | |
2377 | |
2378 int dd = dom_depth(head); | |
2379 | |
2380 // Step 1: find cut point | |
2381 | |
2382 // Walk up dominators to loop head looking for first loop exit | |
2383 // which is executed on every path thru loop. | |
2384 IfNode *peel_if = NULL; | |
2385 IfNode *peel_if_cmpu = NULL; | |
2386 | |
2387 Node *iff = loop->tail(); | |
2388 while( iff != head ) { | |
2389 if( iff->is_If() ) { | |
2390 Node *ctrl = get_ctrl(iff->in(1)); | |
2391 if (ctrl->is_top()) return false; // Dead test on live IF. | |
2392 // If loop-varying exit-test, check for induction variable | |
2393 if( loop->is_member(get_loop(ctrl)) && | |
2394 loop->is_loop_exit(iff) && | |
2395 is_possible_iv_test(iff)) { | |
2396 Node* cmp = iff->in(1)->in(1); | |
2397 if (cmp->Opcode() == Op_CmpI) { | |
2398 peel_if = iff->as_If(); | |
2399 } else { | |
2400 assert(cmp->Opcode() == Op_CmpU, "must be CmpI or CmpU"); | |
2401 peel_if_cmpu = iff->as_If(); | |
2402 } | |
2403 } | |
2404 } | |
2405 iff = idom(iff); | |
2406 } | |
2407 // Prefer signed compare over unsigned compare. | |
2408 IfNode* new_peel_if = NULL; | |
2409 if (peel_if == NULL) { | |
2410 if (!PartialPeelAtUnsignedTests || peel_if_cmpu == NULL) { | |
2411 return false; // No peel point found | |
2412 } | |
2413 new_peel_if = insert_cmpi_loop_exit(peel_if_cmpu, loop); | |
2414 if (new_peel_if == NULL) { | |
2415 return false; // No peel point found | |
2416 } | |
2417 peel_if = new_peel_if; | |
2418 } | |
2419 Node* last_peel = stay_in_loop(peel_if, loop); | |
2420 Node* first_not_peeled = stay_in_loop(last_peel, loop); | |
2421 if (first_not_peeled == NULL || first_not_peeled == head) { | |
2422 return false; | |
2423 } | |
2424 | |
2425 #if !defined(PRODUCT) | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2426 if (TraceLoopOpts) { |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2427 tty->print("PartialPeel "); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2428 loop->dump_head(); |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2429 } |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2430 |
0 | 2431 if (TracePartialPeeling) { |
2432 tty->print_cr("before partial peel one iteration"); | |
2433 Node_List wl; | |
2434 Node* t = head->in(2); | |
2435 while (true) { | |
2436 wl.push(t); | |
2437 if (t == head) break; | |
2438 t = idom(t); | |
2439 } | |
2440 while (wl.size() > 0) { | |
2441 Node* tt = wl.pop(); | |
2442 tt->dump(); | |
2443 if (tt == last_peel) tty->print_cr("-- cut --"); | |
2444 } | |
2445 } | |
2446 #endif | |
2447 ResourceArea *area = Thread::current()->resource_area(); | |
2448 VectorSet peel(area); | |
2449 VectorSet not_peel(area); | |
2450 Node_List peel_list(area); | |
2451 Node_List worklist(area); | |
2452 Node_List sink_list(area); | |
2453 | |
2454 // Set of cfg nodes to peel are those that are executable from | |
2455 // the head through last_peel. | |
2456 assert(worklist.size() == 0, "should be empty"); | |
2457 worklist.push(head); | |
2458 peel.set(head->_idx); | |
2459 while (worklist.size() > 0) { | |
2460 Node *n = worklist.pop(); | |
2461 if (n != last_peel) { | |
2462 for (DUIterator_Fast jmax, j = n->fast_outs(jmax); j < jmax; j++) { | |
2463 Node* use = n->fast_out(j); | |
2464 if (use->is_CFG() && | |
2465 loop->is_member(get_loop(use)) && | |
2466 !peel.test_set(use->_idx)) { | |
2467 worklist.push(use); | |
2468 } | |
2469 } | |
2470 } | |
2471 } | |
2472 | |
2473 // Set of non-cfg nodes to peel are those that are control | |
2474 // dependent on the cfg nodes. | |
2475 uint i; | |
2476 for(i = 0; i < loop->_body.size(); i++ ) { | |
2477 Node *n = loop->_body.at(i); | |
2478 Node *n_c = has_ctrl(n) ? get_ctrl(n) : n; | |
2479 if (peel.test(n_c->_idx)) { | |
2480 peel.set(n->_idx); | |
2481 } else { | |
2482 not_peel.set(n->_idx); | |
2483 } | |
2484 } | |
2485 | |
2486 // Step 2: move operations from the peeled section down into the | |
2487 // not-peeled section | |
2488 | |
2489 // Get a post order schedule of nodes in the peel region | |
2490 // Result in right-most operand. | |
2491 scheduled_nodelist(loop, peel, peel_list ); | |
2492 | |
2493 assert(is_valid_loop_partition(loop, peel, peel_list, not_peel), "bad partition"); | |
2494 | |
2495 // For future check for too many new phis | |
2496 uint old_phi_cnt = 0; | |
2497 for (DUIterator_Fast jmax, j = head->fast_outs(jmax); j < jmax; j++) { | |
2498 Node* use = head->fast_out(j); | |
2499 if (use->is_Phi()) old_phi_cnt++; | |
2500 } | |
2501 | |
2502 #if !defined(PRODUCT) | |
2503 if (TracePartialPeeling) { | |
2504 tty->print_cr("\npeeled list"); | |
2505 } | |
2506 #endif | |
2507 | |
2508 // Evacuate nodes in peel region into the not_peeled region if possible | |
2509 uint new_phi_cnt = 0; | |
10322
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
2510 uint cloned_for_outside_use = 0; |
0 | 2511 for (i = 0; i < peel_list.size();) { |
2512 Node* n = peel_list.at(i); | |
2513 #if !defined(PRODUCT) | |
2514 if (TracePartialPeeling) n->dump(); | |
2515 #endif | |
2516 bool incr = true; | |
2517 if ( !n->is_CFG() ) { | |
2518 | |
2519 if ( has_use_in_set(n, not_peel) ) { | |
2520 | |
2521 // If not used internal to the peeled region, | |
2522 // move "n" from peeled to not_peeled region. | |
2523 | |
2524 if ( !has_use_internal_to_set(n, peel, loop) ) { | |
2525 | |
2526 // if not pinned and not a load (which maybe anti-dependent on a store) | |
2527 // and not a CMove (Matcher expects only bool->cmove). | |
2528 if ( n->in(0) == NULL && !n->is_Load() && !n->is_CMove() ) { | |
10322
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
2529 cloned_for_outside_use += clone_for_use_outside_loop( loop, n, worklist ); |
0 | 2530 sink_list.push(n); |
2531 peel >>= n->_idx; // delete n from peel set. | |
2532 not_peel <<= n->_idx; // add n to not_peel set. | |
2533 peel_list.remove(i); | |
2534 incr = false; | |
2535 #if !defined(PRODUCT) | |
2536 if (TracePartialPeeling) { | |
2537 tty->print_cr("sink to not_peeled region: %d newbb: %d", | |
2538 n->_idx, get_ctrl(n)->_idx); | |
2539 } | |
2540 #endif | |
2541 } | |
2542 } else { | |
2543 // Otherwise check for special def-use cases that span | |
2544 // the peel/not_peel boundary such as bool->if | |
2545 clone_for_special_use_inside_loop( loop, n, not_peel, sink_list, worklist ); | |
2546 new_phi_cnt++; | |
2547 } | |
2548 } | |
2549 } | |
2550 if (incr) i++; | |
2551 } | |
2552 | |
2553 if (new_phi_cnt > old_phi_cnt + PartialPeelNewPhiDelta) { | |
2554 #if !defined(PRODUCT) | |
2555 if (TracePartialPeeling) { | |
2556 tty->print_cr("\nToo many new phis: %d old %d new cmpi: %c", | |
2557 new_phi_cnt, old_phi_cnt, new_peel_if != NULL?'T':'F'); | |
2558 } | |
2559 #endif | |
2560 if (new_peel_if != NULL) { | |
2561 remove_cmpi_loop_exit(new_peel_if, loop); | |
2562 } | |
2563 // Inhibit more partial peeling on this loop | |
2564 assert(!head->is_partial_peel_loop(), "not partial peeled"); | |
2565 head->mark_partial_peel_failed(); | |
10322
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
2566 if (cloned_for_outside_use > 0) { |
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
2567 // Terminate this round of loop opts because |
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
2568 // the graph outside this loop was changed. |
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
2569 C->set_major_progress(); |
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
2570 return true; |
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
2571 } |
0 | 2572 return false; |
2573 } | |
2574 | |
2575 // Step 3: clone loop, retarget control, and insert new phis | |
2576 | |
2577 // Create new loop head for new phis and to hang | |
2578 // the nodes being moved (sinked) from the peel region. | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
2579 LoopNode* new_head = new (C) LoopNode(last_peel, last_peel); |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2580 new_head->set_unswitch_count(head->unswitch_count()); // Preserve |
0 | 2581 _igvn.register_new_node_with_optimizer(new_head); |
2582 assert(first_not_peeled->in(0) == last_peel, "last_peel <- first_not_peeled"); | |
2583 first_not_peeled->set_req(0, new_head); | |
2584 set_loop(new_head, loop); | |
2585 loop->_body.push(new_head); | |
2586 not_peel.set(new_head->_idx); | |
2587 set_idom(new_head, last_peel, dom_depth(first_not_peeled)); | |
2588 set_idom(first_not_peeled, new_head, dom_depth(first_not_peeled)); | |
2589 | |
2590 while (sink_list.size() > 0) { | |
2591 Node* n = sink_list.pop(); | |
2592 set_ctrl(n, new_head); | |
2593 } | |
2594 | |
2595 assert(is_valid_loop_partition(loop, peel, peel_list, not_peel), "bad partition"); | |
2596 | |
2597 clone_loop( loop, old_new, dd ); | |
2598 | |
2599 const uint clone_exit_idx = 1; | |
2600 const uint orig_exit_idx = 2; | |
2601 assert(is_valid_clone_loop_form( loop, peel_list, orig_exit_idx, clone_exit_idx ), "bad clone loop"); | |
2602 | |
2603 Node* head_clone = old_new[head->_idx]; | |
2604 LoopNode* new_head_clone = old_new[new_head->_idx]->as_Loop(); | |
2605 Node* orig_tail_clone = head_clone->in(2); | |
2606 | |
2607 // Add phi if "def" node is in peel set and "use" is not | |
2608 | |
2609 for(i = 0; i < peel_list.size(); i++ ) { | |
2610 Node *def = peel_list.at(i); | |
2611 if (!def->is_CFG()) { | |
2612 for (DUIterator_Fast jmax, j = def->fast_outs(jmax); j < jmax; j++) { | |
2613 Node *use = def->fast_out(j); | |
2614 if (has_node(use) && use->in(0) != C->top() && | |
2615 (!peel.test(use->_idx) || | |
2616 (use->is_Phi() && use->in(0) == head)) ) { | |
2617 worklist.push(use); | |
2618 } | |
2619 } | |
2620 while( worklist.size() ) { | |
2621 Node *use = worklist.pop(); | |
2622 for (uint j = 1; j < use->req(); j++) { | |
2623 Node* n = use->in(j); | |
2624 if (n == def) { | |
2625 | |
2626 // "def" is in peel set, "use" is not in peel set | |
2627 // or "use" is in the entry boundary (a phi) of the peel set | |
2628 | |
2629 Node* use_c = has_ctrl(use) ? get_ctrl(use) : use; | |
2630 | |
2631 if ( loop->is_member(get_loop( use_c )) ) { | |
2632 // use is in loop | |
2633 if (old_new[use->_idx] != NULL) { // null for dead code | |
2634 Node* use_clone = old_new[use->_idx]; | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2635 _igvn.replace_input_of(use, j, C->top()); |
0 | 2636 insert_phi_for_loop( use_clone, j, old_new[def->_idx], def, new_head_clone ); |
2637 } | |
2638 } else { | |
2639 assert(is_valid_clone_loop_exit_use(loop, use, orig_exit_idx), "clone loop format"); | |
2640 // use is not in the loop, check if the live range includes the cut | |
2641 Node* lp_if = use_c->in(orig_exit_idx)->in(0); | |
2642 if (not_peel.test(lp_if->_idx)) { | |
2643 assert(j == orig_exit_idx, "use from original loop"); | |
2644 insert_phi_for_loop( use, clone_exit_idx, old_new[def->_idx], def, new_head_clone ); | |
2645 } | |
2646 } | |
2647 } | |
2648 } | |
2649 } | |
2650 } | |
2651 } | |
2652 | |
2653 // Step 3b: retarget control | |
2654 | |
2655 // Redirect control to the new loop head if a cloned node in | |
2656 // the not_peeled region has control that points into the peeled region. | |
2657 // This necessary because the cloned peeled region will be outside | |
2658 // the loop. | |
2659 // from to | |
2660 // cloned-peeled <---+ | |
2661 // new_head_clone: | <--+ | |
2662 // cloned-not_peeled in(0) in(0) | |
2663 // orig-peeled | |
2664 | |
2665 for(i = 0; i < loop->_body.size(); i++ ) { | |
2666 Node *n = loop->_body.at(i); | |
2667 if (!n->is_CFG() && n->in(0) != NULL && | |
2668 not_peel.test(n->_idx) && peel.test(n->in(0)->_idx)) { | |
2669 Node* n_clone = old_new[n->_idx]; | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2670 _igvn.replace_input_of(n_clone, 0, new_head_clone); |
0 | 2671 } |
2672 } | |
2673 | |
2674 // Backedge of the surviving new_head (the clone) is original last_peel | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2675 _igvn.replace_input_of(new_head_clone, LoopNode::LoopBackControl, last_peel); |
0 | 2676 |
2677 // Cut first node in original not_peel set | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2678 _igvn.rehash_node_delayed(new_head); // Multiple edge updates: |
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2679 new_head->set_req(LoopNode::EntryControl, C->top()); // use rehash_node_delayed / set_req instead of |
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2680 new_head->set_req(LoopNode::LoopBackControl, C->top()); // multiple replace_input_of calls |
0 | 2681 |
2682 // Copy head_clone back-branch info to original head | |
2683 // and remove original head's loop entry and | |
2684 // clone head's back-branch | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2685 _igvn.rehash_node_delayed(head); // Multiple edge updates |
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2686 head->set_req(LoopNode::EntryControl, head_clone->in(LoopNode::LoopBackControl)); |
0 | 2687 head->set_req(LoopNode::LoopBackControl, C->top()); |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2688 _igvn.replace_input_of(head_clone, LoopNode::LoopBackControl, C->top()); |
0 | 2689 |
2690 // Similarly modify the phis | |
2691 for (DUIterator_Fast kmax, k = head->fast_outs(kmax); k < kmax; k++) { | |
2692 Node* use = head->fast_out(k); | |
2693 if (use->is_Phi() && use->outcnt() > 0) { | |
2694 Node* use_clone = old_new[use->_idx]; | |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2695 _igvn.rehash_node_delayed(use); // Multiple edge updates |
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2696 use->set_req(LoopNode::EntryControl, use_clone->in(LoopNode::LoopBackControl)); |
0 | 2697 use->set_req(LoopNode::LoopBackControl, C->top()); |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2698 _igvn.replace_input_of(use_clone, LoopNode::LoopBackControl, C->top()); |
0 | 2699 } |
2700 } | |
2701 | |
2702 // Step 4: update dominator tree and dominator depth | |
2703 | |
2704 set_idom(head, orig_tail_clone, dd); | |
2705 recompute_dom_depth(); | |
2706 | |
2707 // Inhibit more partial peeling on this loop | |
2708 new_head_clone->set_partial_peel_loop(); | |
2709 C->set_major_progress(); | |
17887 | 2710 loop->record_for_igvn(); |
0 | 2711 |
2712 #if !defined(PRODUCT) | |
2713 if (TracePartialPeeling) { | |
2714 tty->print_cr("\nafter partial peel one iteration"); | |
2715 Node_List wl(area); | |
2716 Node* t = last_peel; | |
2717 while (true) { | |
2718 wl.push(t); | |
2719 if (t == head_clone) break; | |
2720 t = idom(t); | |
2721 } | |
2722 while (wl.size() > 0) { | |
2723 Node* tt = wl.pop(); | |
2724 if (tt == head) tty->print_cr("orig head"); | |
2725 else if (tt == new_head_clone) tty->print_cr("new head"); | |
2726 else if (tt == head_clone) tty->print_cr("clone head"); | |
2727 tt->dump(); | |
2728 } | |
2729 } | |
2730 #endif | |
2731 return true; | |
2732 } | |
2733 | |
2734 //------------------------------reorg_offsets---------------------------------- | |
2735 // Reorganize offset computations to lower register pressure. Mostly | |
2736 // prevent loop-fallout uses of the pre-incremented trip counter (which are | |
2737 // then alive with the post-incremented trip counter forcing an extra | |
2738 // register move) | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2739 void PhaseIdealLoop::reorg_offsets(IdealLoopTree *loop) { |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2740 // Perform it only for canonical counted loops. |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2741 // Loop's shape could be messed up by iteration_split_impl. |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2742 if (!loop->_head->is_CountedLoop()) |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2743 return; |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2744 if (!loop->_head->as_Loop()->is_valid_counted_loop()) |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2745 return; |
0 | 2746 |
2747 CountedLoopNode *cl = loop->_head->as_CountedLoop(); | |
2748 CountedLoopEndNode *cle = cl->loopexit(); | |
2749 Node *exit = cle->proj_out(false); | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2750 Node *phi = cl->phi(); |
0 | 2751 |
2752 // Check for the special case of folks using the pre-incremented | |
2753 // trip-counter on the fall-out path (forces the pre-incremented | |
2754 // and post-incremented trip counter to be live at the same time). | |
2755 // Fix this by adjusting to use the post-increment trip counter. | |
367
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
318
diff
changeset
|
2756 |
0 | 2757 bool progress = true; |
2758 while (progress) { | |
2759 progress = false; | |
2760 for (DUIterator_Fast imax, i = phi->fast_outs(imax); i < imax; i++) { | |
2761 Node* use = phi->fast_out(i); // User of trip-counter | |
2762 if (!has_ctrl(use)) continue; | |
2763 Node *u_ctrl = get_ctrl(use); | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2764 if (use->is_Phi()) { |
0 | 2765 u_ctrl = NULL; |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2766 for (uint j = 1; j < use->req(); j++) |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2767 if (use->in(j) == phi) |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2768 u_ctrl = dom_lca(u_ctrl, use->in(0)->in(j)); |
0 | 2769 } |
2770 IdealLoopTree *u_loop = get_loop(u_ctrl); | |
2771 // Look for loop-invariant use | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2772 if (u_loop == loop) continue; |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2773 if (loop->is_member(u_loop)) continue; |
0 | 2774 // Check that use is live out the bottom. Assuming the trip-counter |
2775 // update is right at the bottom, uses of of the loop middle are ok. | |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2776 if (dom_lca(exit, u_ctrl) != exit) continue; |
0 | 2777 // Hit! Refactor use to use the post-incremented tripcounter. |
2778 // Compute a post-increment tripcounter. | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
2779 Node *opaq = new (C) Opaque2Node( C, cle->incr() ); |
17985
4077c61b03a0
8046516: Segmentation fault in JVM (easily reproducible)
kvn
parents:
17978
diff
changeset
|
2780 register_new_node(opaq, exit); |
0 | 2781 Node *neg_stride = _igvn.intcon(-cle->stride_con()); |
2782 set_ctrl(neg_stride, C->root()); | |
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
2783 Node *post = new (C) AddINode( opaq, neg_stride); |
17985
4077c61b03a0
8046516: Segmentation fault in JVM (easily reproducible)
kvn
parents:
17978
diff
changeset
|
2784 register_new_node(post, exit); |
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2785 _igvn.rehash_node_delayed(use); |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2786 for (uint j = 1; j < use->req(); j++) { |
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2787 if (use->in(j) == phi) |
0 | 2788 use->set_req(j, post); |
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2789 } |
0 | 2790 // Since DU info changed, rerun loop |
2791 progress = true; | |
2792 break; | |
2793 } | |
2794 } | |
2795 | |
2796 } |