Mercurial > hg > graal-jvmci-8
annotate src/share/vm/gc_implementation/g1/g1RemSet.cpp @ 17937:78bbf4d43a14
8037816: Fix for 8036122 breaks build with Xcode5/clang
8043029: Change 8037816 breaks HS build with older GCC versions which don't support diagnostic pragmas
8043164: Format warning in traceStream.hpp
Summary: Backport of main fix + two corrections, enables clang compilation, turns on format attributes, corrects/mutes warnings
Reviewed-by: kvn, coleenp, iveresov, twisti
| author | drchase |
|---|---|
| date | Thu, 22 May 2014 15:52:41 -0400 |
| parents | 8847586c9037 |
| children | 52b4284cb496 02e61cf08ab3 |
| rev | line source |
|---|---|
| 342 | 1 /* |
|
17937
78bbf4d43a14
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
17844
diff
changeset
|
2 * Copyright (c) 2001, 2014, Oracle and/or its affiliates. All rights reserved. |
| 342 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1282
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1282
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1282
diff
changeset
|
21 * questions. |
| 342 | 22 * |
| 23 */ | |
| 24 | |
| 1972 | 25 #include "precompiled.hpp" |
| 26 #include "gc_implementation/g1/bufferingOopClosure.hpp" | |
| 27 #include "gc_implementation/g1/concurrentG1Refine.hpp" | |
| 28 #include "gc_implementation/g1/concurrentG1RefineThread.hpp" | |
| 29 #include "gc_implementation/g1/g1BlockOffsetTable.inline.hpp" | |
| 30 #include "gc_implementation/g1/g1CollectedHeap.inline.hpp" | |
| 31 #include "gc_implementation/g1/g1CollectorPolicy.hpp" | |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
32 #include "gc_implementation/g1/g1HotCardCache.hpp" |
|
6219
922993931b3d
7178361: G1: Make sure that PrintGC and PrintGCDetails use the same timing for the GC pause
brutisso
parents:
4839
diff
changeset
|
33 #include "gc_implementation/g1/g1GCPhaseTimes.hpp" |
| 1972 | 34 #include "gc_implementation/g1/g1OopClosures.inline.hpp" |
| 35 #include "gc_implementation/g1/g1RemSet.inline.hpp" | |
| 36 #include "gc_implementation/g1/heapRegionSeq.inline.hpp" | |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
37 #include "gc_implementation/g1/heapRegionRemSet.hpp" |
| 1972 | 38 #include "memory/iterator.hpp" |
| 39 #include "oops/oop.inline.hpp" | |
| 40 #include "utilities/intHisto.hpp" | |
| 342 | 41 |
|
17937
78bbf4d43a14
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
17844
diff
changeset
|
42 PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC |
|
78bbf4d43a14
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
17844
diff
changeset
|
43 |
| 342 | 44 #define CARD_REPEAT_HISTO 0 |
| 45 | |
| 46 #if CARD_REPEAT_HISTO | |
| 47 static size_t ct_freq_sz; | |
| 48 static jbyte* ct_freq = NULL; | |
| 49 | |
| 50 void init_ct_freq_table(size_t heap_sz_bytes) { | |
| 51 if (ct_freq == NULL) { | |
| 52 ct_freq_sz = heap_sz_bytes/CardTableModRefBS::card_size; | |
| 53 ct_freq = new jbyte[ct_freq_sz]; | |
| 54 for (size_t j = 0; j < ct_freq_sz; j++) ct_freq[j] = 0; | |
| 55 } | |
| 56 } | |
| 57 | |
| 58 void ct_freq_note_card(size_t index) { | |
| 59 assert(0 <= index && index < ct_freq_sz, "Bounds error."); | |
| 60 if (ct_freq[index] < 100) { ct_freq[index]++; } | |
| 61 } | |
| 62 | |
| 63 static IntHistogram card_repeat_count(10, 10); | |
| 64 | |
| 65 void ct_freq_update_histo_and_reset() { | |
| 66 for (size_t j = 0; j < ct_freq_sz; j++) { | |
| 67 card_repeat_count.add_entry(ct_freq[j]); | |
| 68 ct_freq[j] = 0; | |
| 69 } | |
| 70 | |
| 71 } | |
| 72 #endif | |
| 73 | |
| 1861 | 74 G1RemSet::G1RemSet(G1CollectedHeap* g1, CardTableModRefBS* ct_bs) |
| 75 : _g1(g1), _conc_refine_cards(0), | |
| 76 _ct_bs(ct_bs), _g1p(_g1->g1_policy()), | |
| 342 | 77 _cg1r(g1->concurrent_g1_refine()), |
| 1705 | 78 _cset_rs_update_cl(NULL), |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
79 _cards_scanned(NULL), _total_cards_scanned(0), |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
80 _prev_period_summary() |
| 342 | 81 { |
| 82 _seq_task = new SubTasksDone(NumSeqTasks); | |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
83 guarantee(n_workers() > 0, "There should be some workers"); |
| 6197 | 84 _cset_rs_update_cl = NEW_C_HEAP_ARRAY(OopsInHeapRegionClosure*, n_workers(), mtGC); |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
85 for (uint i = 0; i < n_workers(); i++) { |
| 1705 | 86 _cset_rs_update_cl[i] = NULL; |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
87 } |
|
12344
7ec10139bf37
8025441: G1: assert "assert(thread < _num_vtimes) failed: just checking" fails when G1ConcRefinementThreads > ParallelGCThreads
tschatzl
parents:
12343
diff
changeset
|
88 if (G1SummarizeRSetStats) { |
|
7ec10139bf37
8025441: G1: assert "assert(thread < _num_vtimes) failed: just checking" fails when G1ConcRefinementThreads > ParallelGCThreads
tschatzl
parents:
12343
diff
changeset
|
89 _prev_period_summary.initialize(this); |
|
7ec10139bf37
8025441: G1: assert "assert(thread < _num_vtimes) failed: just checking" fails when G1ConcRefinementThreads > ParallelGCThreads
tschatzl
parents:
12343
diff
changeset
|
90 } |
| 342 | 91 } |
| 92 | |
| 1861 | 93 G1RemSet::~G1RemSet() { |
| 342 | 94 delete _seq_task; |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
95 for (uint i = 0; i < n_workers(); i++) { |
| 1705 | 96 assert(_cset_rs_update_cl[i] == NULL, "it should be"); |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
97 } |
| 6197 | 98 FREE_C_HEAP_ARRAY(OopsInHeapRegionClosure*, _cset_rs_update_cl, mtGC); |
| 342 | 99 } |
| 100 | |
| 101 void CountNonCleanMemRegionClosure::do_MemRegion(MemRegion mr) { | |
| 102 if (_g1->is_in_g1_reserved(mr.start())) { | |
| 103 _n += (int) ((mr.byte_size() / CardTableModRefBS::card_size)); | |
| 104 if (_start_first == NULL) _start_first = mr.start(); | |
| 105 } | |
| 106 } | |
| 107 | |
| 108 class ScanRSClosure : public HeapRegionClosure { | |
| 109 size_t _cards_done, _cards; | |
| 110 G1CollectedHeap* _g1h; | |
| 12080 | 111 |
| 342 | 112 OopsInHeapRegionClosure* _oc; |
| 12080 | 113 CodeBlobToOopClosure* _code_root_cl; |
| 114 | |
| 342 | 115 G1BlockOffsetSharedArray* _bot_shared; |
| 12343 | 116 G1SATBCardTableModRefBS *_ct_bs; |
| 12080 | 117 |
| 118 double _strong_code_root_scan_time_sec; | |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17757
diff
changeset
|
119 uint _worker_i; |
| 12080 | 120 int _block_size; |
| 121 bool _try_claimed; | |
| 122 | |
| 342 | 123 public: |
| 12080 | 124 ScanRSClosure(OopsInHeapRegionClosure* oc, |
| 125 CodeBlobToOopClosure* code_root_cl, | |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17757
diff
changeset
|
126 uint worker_i) : |
| 342 | 127 _oc(oc), |
| 12080 | 128 _code_root_cl(code_root_cl), |
| 129 _strong_code_root_scan_time_sec(0.0), | |
| 342 | 130 _cards(0), |
| 131 _cards_done(0), | |
| 132 _worker_i(worker_i), | |
| 133 _try_claimed(false) | |
| 134 { | |
| 135 _g1h = G1CollectedHeap::heap(); | |
| 136 _bot_shared = _g1h->bot_shared(); | |
| 12343 | 137 _ct_bs = _g1h->g1_barrier_set(); |
| 1261 | 138 _block_size = MAX2<int>(G1RSetScanBlockSize, 1); |
| 342 | 139 } |
| 140 | |
| 141 void set_try_claimed() { _try_claimed = true; } | |
| 142 | |
| 143 void scanCard(size_t index, HeapRegion *r) { | |
| 4023 | 144 // Stack allocate the DirtyCardToOopClosure instance |
| 145 HeapRegionDCTOC cl(_g1h, r, _oc, | |
| 146 CardTableModRefBS::Precise, | |
| 147 HeapRegionDCTOC::IntoCSFilterKind); | |
| 342 | 148 |
| 149 // Set the "from" region in the closure. | |
| 150 _oc->set_region(r); | |
| 151 HeapWord* card_start = _bot_shared->address_for_index(index); | |
| 152 HeapWord* card_end = card_start + G1BlockOffsetSharedArray::N_words; | |
| 153 Space *sp = SharedHeap::heap()->space_containing(card_start); | |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
154 MemRegion sm_region = sp->used_region_at_save_marks(); |
| 342 | 155 MemRegion mr = sm_region.intersection(MemRegion(card_start,card_end)); |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
156 if (!mr.is_empty() && !_ct_bs->is_card_claimed(index)) { |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
157 // We make the card as "claimed" lazily (so races are possible |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
158 // but they're benign), which reduces the number of duplicate |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
159 // scans (the rsets of the regions in the cset can intersect). |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
160 _ct_bs->set_card_claimed(index); |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
161 _cards_done++; |
| 4023 | 162 cl.do_MemRegion(mr); |
| 342 | 163 } |
| 164 } | |
| 165 | |
| 166 void printCard(HeapRegion* card_region, size_t card_index, | |
| 167 HeapWord* card_start) { | |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17757
diff
changeset
|
168 gclog_or_tty->print_cr("T " UINT32_FORMAT " Region [" PTR_FORMAT ", " PTR_FORMAT ") " |
| 342 | 169 "RS names card %p: " |
| 170 "[" PTR_FORMAT ", " PTR_FORMAT ")", | |
| 171 _worker_i, | |
| 172 card_region->bottom(), card_region->end(), | |
| 173 card_index, | |
| 174 card_start, card_start + G1BlockOffsetSharedArray::N_words); | |
| 175 } | |
| 176 | |
| 12080 | 177 void scan_strong_code_roots(HeapRegion* r) { |
| 178 double scan_start = os::elapsedTime(); | |
| 179 r->strong_code_roots_do(_code_root_cl); | |
| 180 _strong_code_root_scan_time_sec += (os::elapsedTime() - scan_start); | |
| 181 } | |
| 182 | |
| 342 | 183 bool doHeapRegion(HeapRegion* r) { |
| 184 assert(r->in_collection_set(), "should only be called on elements of CS."); | |
| 185 HeapRegionRemSet* hrrs = r->rem_set(); | |
| 186 if (hrrs->iter_is_complete()) return false; // All done. | |
| 187 if (!_try_claimed && !hrrs->claim_iter()) return false; | |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
188 // If we ever free the collection set concurrently, we should also |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
189 // clear the card table concurrently therefore we won't need to |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
190 // add regions of the collection set to the dirty cards region. |
|
796
29e7d79232b9
6819065: G1: eliminate high serial card table clearing time
apetrusenko
parents:
794
diff
changeset
|
191 _g1h->push_dirty_cards_region(r); |
| 342 | 192 // If we didn't return above, then |
| 193 // _try_claimed || r->claim_iter() | |
| 194 // is true: either we're supposed to work on claimed-but-not-complete | |
| 195 // regions, or we successfully claimed the region. | |
| 12080 | 196 |
|
10182
5c93c1f61226
8011724: G1: Stack allocate instances of HeapRegionRemSetIterator
johnc
parents:
6725
diff
changeset
|
197 HeapRegionRemSetIterator iter(hrrs); |
| 342 | 198 size_t card_index; |
| 1261 | 199 |
| 200 // We claim cards in block so as to recude the contention. The block size is determined by | |
| 201 // the G1RSetScanBlockSize parameter. | |
| 202 size_t jump_to_card = hrrs->iter_claimed_next(_block_size); | |
|
10182
5c93c1f61226
8011724: G1: Stack allocate instances of HeapRegionRemSetIterator
johnc
parents:
6725
diff
changeset
|
203 for (size_t current_card = 0; iter.has_next(card_index); current_card++) { |
| 1261 | 204 if (current_card >= jump_to_card + _block_size) { |
| 205 jump_to_card = hrrs->iter_claimed_next(_block_size); | |
| 747 | 206 } |
| 1261 | 207 if (current_card < jump_to_card) continue; |
| 342 | 208 HeapWord* card_start = _g1h->bot_shared()->address_for_index(card_index); |
| 209 #if 0 | |
| 210 gclog_or_tty->print("Rem set iteration yielded card [" PTR_FORMAT ", " PTR_FORMAT ").\n", | |
| 211 card_start, card_start + CardTableModRefBS::card_size_in_words); | |
| 212 #endif | |
| 213 | |
| 214 HeapRegion* card_region = _g1h->heap_region_containing(card_start); | |
| 215 assert(card_region != NULL, "Yielding cards not in the heap?"); | |
| 216 _cards++; | |
| 217 | |
|
796
29e7d79232b9
6819065: G1: eliminate high serial card table clearing time
apetrusenko
parents:
794
diff
changeset
|
218 if (!card_region->is_on_dirty_cards_region_list()) { |
|
29e7d79232b9
6819065: G1: eliminate high serial card table clearing time
apetrusenko
parents:
794
diff
changeset
|
219 _g1h->push_dirty_cards_region(card_region); |
|
29e7d79232b9
6819065: G1: eliminate high serial card table clearing time
apetrusenko
parents:
794
diff
changeset
|
220 } |
|
29e7d79232b9
6819065: G1: eliminate high serial card table clearing time
apetrusenko
parents:
794
diff
changeset
|
221 |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
222 // If the card is dirty, then we will scan it during updateRS. |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
223 if (!card_region->in_collection_set() && |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
224 !_ct_bs->is_card_dirty(card_index)) { |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
225 scanCard(card_index, card_region); |
| 342 | 226 } |
| 227 } | |
| 747 | 228 if (!_try_claimed) { |
| 12080 | 229 // Scan the strong code root list attached to the current region |
| 230 scan_strong_code_roots(r); | |
| 231 | |
| 747 | 232 hrrs->set_iter_complete(); |
| 233 } | |
| 342 | 234 return false; |
| 235 } | |
| 12080 | 236 |
| 237 double strong_code_root_scan_time_sec() { | |
| 238 return _strong_code_root_scan_time_sec; | |
| 239 } | |
| 240 | |
| 342 | 241 size_t cards_done() { return _cards_done;} |
| 242 size_t cards_looked_up() { return _cards;} | |
| 243 }; | |
| 244 | |
| 12080 | 245 void G1RemSet::scanRS(OopsInHeapRegionClosure* oc, |
| 246 CodeBlobToOopClosure* code_root_cl, | |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17757
diff
changeset
|
247 uint worker_i) { |
| 342 | 248 double rs_time_start = os::elapsedTime(); |
|
4097
dc467e8b2c5e
7112743: G1: Reduce overhead of marking closure during evacuation pauses
johnc
parents:
4095
diff
changeset
|
249 HeapRegion *startRegion = _g1->start_cset_region_for_worker(worker_i); |
| 342 | 250 |
| 12080 | 251 ScanRSClosure scanRScl(oc, code_root_cl, worker_i); |
|
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3777
diff
changeset
|
252 |
| 342 | 253 _g1->collection_set_iterate_from(startRegion, &scanRScl); |
| 254 scanRScl.set_try_claimed(); | |
| 255 _g1->collection_set_iterate_from(startRegion, &scanRScl); | |
| 256 | |
| 12080 | 257 double scan_rs_time_sec = (os::elapsedTime() - rs_time_start) |
| 258 - scanRScl.strong_code_root_scan_time_sec(); | |
| 342 | 259 |
| 12080 | 260 assert(_cards_scanned != NULL, "invariant"); |
| 342 | 261 _cards_scanned[worker_i] = scanRScl.cards_done(); |
| 262 | |
|
6219
922993931b3d
7178361: G1: Make sure that PrintGC and PrintGCDetails use the same timing for the GC pause
brutisso
parents:
4839
diff
changeset
|
263 _g1p->phase_times()->record_scan_rs_time(worker_i, scan_rs_time_sec * 1000.0); |
| 12080 | 264 _g1p->phase_times()->record_strong_code_root_scan_time(worker_i, |
| 265 scanRScl.strong_code_root_scan_time_sec() * 1000.0); | |
| 342 | 266 } |
| 267 | |
| 1705 | 268 // Closure used for updating RSets and recording references that |
| 269 // point into the collection set. Only called during an | |
| 270 // evacuation pause. | |
| 271 | |
| 272 class RefineRecordRefsIntoCSCardTableEntryClosure: public CardTableEntryClosure { | |
| 273 G1RemSet* _g1rs; | |
| 274 DirtyCardQueue* _into_cset_dcq; | |
| 275 public: | |
| 276 RefineRecordRefsIntoCSCardTableEntryClosure(G1CollectedHeap* g1h, | |
| 277 DirtyCardQueue* into_cset_dcq) : | |
| 278 _g1rs(g1h->g1_rem_set()), _into_cset_dcq(into_cset_dcq) | |
| 279 {} | |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17757
diff
changeset
|
280 bool do_card_ptr(jbyte* card_ptr, uint worker_i) { |
| 1705 | 281 // The only time we care about recording cards that |
| 282 // contain references that point into the collection set | |
| 283 // is during RSet updating within an evacuation pause. | |
| 284 // In this case worker_i should be the id of a GC worker thread. | |
| 285 assert(SafepointSynchronize::is_at_safepoint(), "not during an evacuation pause"); | |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17757
diff
changeset
|
286 assert(worker_i < (ParallelGCThreads == 0 ? 1 : ParallelGCThreads), "should be a GC worker"); |
| 342 | 287 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
288 if (_g1rs->refine_card(card_ptr, worker_i, true)) { |
| 1705 | 289 // 'card_ptr' contains references that point into the collection |
| 290 // set. We need to record the card in the DCQS | |
| 291 // (G1CollectedHeap::into_cset_dirty_card_queue_set()) | |
| 292 // that's used for that purpose. | |
| 293 // | |
| 294 // Enqueue the card | |
| 295 _into_cset_dcq->enqueue(card_ptr); | |
| 296 } | |
| 297 return true; | |
| 298 } | |
| 299 }; | |
| 300 | |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17757
diff
changeset
|
301 void G1RemSet::updateRS(DirtyCardQueue* into_cset_dcq, uint worker_i) { |
| 342 | 302 double start = os::elapsedTime(); |
| 1705 | 303 // Apply the given closure to all remaining log entries. |
| 304 RefineRecordRefsIntoCSCardTableEntryClosure into_cset_update_rs_cl(_g1, into_cset_dcq); | |
|
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3777
diff
changeset
|
305 |
| 1705 | 306 _g1->iterate_dirty_card_closure(&into_cset_update_rs_cl, into_cset_dcq, false, worker_i); |
| 307 | |
| 794 | 308 // Now there should be no dirty cards. |
| 309 if (G1RSLogCheckCardTable) { | |
| 310 CountNonCleanMemRegionClosure cl(_g1); | |
| 311 _ct_bs->mod_card_iterate(&cl); | |
| 312 // XXX This isn't true any more: keeping cards of young regions | |
| 313 // marked dirty broke it. Need some reasonable fix. | |
| 314 guarantee(cl.n() == 0, "Card table should be clean."); | |
| 342 | 315 } |
| 794 | 316 |
|
6219
922993931b3d
7178361: G1: Make sure that PrintGC and PrintGCDetails use the same timing for the GC pause
brutisso
parents:
4839
diff
changeset
|
317 _g1p->phase_times()->record_update_rs_time(worker_i, (os::elapsedTime() - start) * 1000.0); |
| 342 | 318 } |
| 319 | |
| 1861 | 320 void G1RemSet::cleanupHRRS() { |
| 342 | 321 HeapRegionRemSet::cleanup(); |
| 322 } | |
| 323 | |
| 1861 | 324 void G1RemSet::oops_into_collection_set_do(OopsInHeapRegionClosure* oc, |
| 12080 | 325 CodeBlobToOopClosure* code_root_cl, |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17757
diff
changeset
|
326 uint worker_i) { |
| 342 | 327 #if CARD_REPEAT_HISTO |
| 328 ct_freq_update_histo_and_reset(); | |
| 329 #endif | |
| 330 | |
| 1705 | 331 // We cache the value of 'oc' closure into the appropriate slot in the |
| 332 // _cset_rs_update_cl for this worker | |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17757
diff
changeset
|
333 assert(worker_i < n_workers(), "sanity"); |
| 1705 | 334 _cset_rs_update_cl[worker_i] = oc; |
| 335 | |
| 336 // A DirtyCardQueue that is used to hold cards containing references | |
| 337 // that point into the collection set. This DCQ is associated with a | |
| 338 // special DirtyCardQueueSet (see g1CollectedHeap.hpp). Under normal | |
| 339 // circumstances (i.e. the pause successfully completes), these cards | |
| 340 // are just discarded (there's no need to update the RSets of regions | |
| 341 // that were in the collection set - after the pause these regions | |
| 342 // are wholly 'free' of live objects. In the event of an evacuation | |
| 343 // failure the cards/buffers in this queue set are: | |
| 344 // * passed to the DirtyCardQueueSet that is used to manage deferred | |
| 345 // RSet updates, or | |
| 346 // * scanned for references that point into the collection set | |
| 347 // and the RSet of the corresponding region in the collection set | |
| 348 // is updated immediately. | |
| 349 DirtyCardQueue into_cset_dcq(&_g1->into_cset_dirty_card_queue_set()); | |
| 350 | |
|
1708
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
351 assert((ParallelGCThreads > 0) || worker_i == 0, "invariant"); |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
352 |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
353 // The two flags below were introduced temporarily to serialize |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
354 // the updating and scanning of remembered sets. There are some |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
355 // race conditions when these two operations are done in parallel |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
356 // and they are causing failures. When we resolve said race |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
357 // conditions, we'll revert back to parallel remembered set |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
358 // updating and scanning. See CRs 6677707 and 6677708. |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
359 if (G1UseParallelRSetUpdating || (worker_i == 0)) { |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
360 updateRS(&into_cset_dcq, worker_i); |
| 342 | 361 } else { |
|
6628
bb3f6194fedb
7178363: G1: Remove the serial code for PrintGCDetails and make it a special case of the parallel code
brutisso
parents:
6254
diff
changeset
|
362 _g1p->phase_times()->record_update_rs_processed_buffers(worker_i, 0); |
|
6219
922993931b3d
7178361: G1: Make sure that PrintGC and PrintGCDetails use the same timing for the GC pause
brutisso
parents:
4839
diff
changeset
|
363 _g1p->phase_times()->record_update_rs_time(worker_i, 0.0); |
|
1708
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
364 } |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
365 if (G1UseParallelRSetScanning || (worker_i == 0)) { |
| 12080 | 366 scanRS(oc, code_root_cl, worker_i); |
|
1708
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
367 } else { |
|
6219
922993931b3d
7178361: G1: Make sure that PrintGC and PrintGCDetails use the same timing for the GC pause
brutisso
parents:
4839
diff
changeset
|
368 _g1p->phase_times()->record_scan_rs_time(worker_i, 0.0); |
| 342 | 369 } |
| 1705 | 370 |
| 371 // We now clear the cached values of _cset_rs_update_cl for this worker | |
| 372 _cset_rs_update_cl[worker_i] = NULL; | |
| 342 | 373 } |
| 374 | |
| 1861 | 375 void G1RemSet::prepare_for_oops_into_collection_set_do() { |
| 342 | 376 cleanupHRRS(); |
| 377 ConcurrentG1Refine* cg1r = _g1->concurrent_g1_refine(); | |
| 378 _g1->set_refine_cte_cl_concurrency(false); | |
| 379 DirtyCardQueueSet& dcqs = JavaThread::dirty_card_queue_set(); | |
| 380 dcqs.concatenate_logs(); | |
| 381 | |
| 382 guarantee( _cards_scanned == NULL, "invariant" ); | |
| 6197 | 383 _cards_scanned = NEW_C_HEAP_ARRAY(size_t, n_workers(), mtGC); |
| 545 | 384 for (uint i = 0; i < n_workers(); ++i) { |
| 385 _cards_scanned[i] = 0; | |
| 386 } | |
| 342 | 387 _total_cards_scanned = 0; |
| 388 } | |
| 389 | |
| 390 | |
| 1705 | 391 // This closure, applied to a DirtyCardQueueSet, is used to immediately |
| 392 // update the RSets for the regions in the CSet. For each card it iterates | |
| 393 // through the oops which coincide with that card. It scans the reference | |
| 394 // fields in each oop; when it finds an oop that points into the collection | |
| 395 // set, the RSet for the region containing the referenced object is updated. | |
| 396 class UpdateRSetCardTableEntryIntoCSetClosure: public CardTableEntryClosure { | |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
397 G1CollectedHeap* _g1; |
|
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
398 CardTableModRefBS* _ct_bs; |
|
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
399 public: |
| 1705 | 400 UpdateRSetCardTableEntryIntoCSetClosure(G1CollectedHeap* g1, |
| 401 CardTableModRefBS* bs): | |
| 402 _g1(g1), _ct_bs(bs) | |
| 403 { } | |
| 404 | |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17757
diff
changeset
|
405 bool do_card_ptr(jbyte* card_ptr, uint worker_i) { |
| 1705 | 406 // Construct the region representing the card. |
| 407 HeapWord* start = _ct_bs->addr_for(card_ptr); | |
| 408 // And find the region containing it. | |
| 409 HeapRegion* r = _g1->heap_region_containing(start); | |
| 410 assert(r != NULL, "unexpected null"); | |
| 411 | |
| 412 // Scan oops in the card looking for references into the collection set | |
|
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
413 // Don't use addr_for(card_ptr + 1) which can ask for |
|
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
414 // a card beyond the heap. This is not safe without a perm |
|
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
415 // gen. |
|
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
416 HeapWord* end = start + CardTableModRefBS::card_size_in_words; |
| 1705 | 417 MemRegion scanRegion(start, end); |
| 418 | |
| 419 UpdateRSetImmediate update_rs_cl(_g1->g1_rem_set()); | |
|
3983
811ec3d0833b
7097053: G1: assert(da ? referent->is_oop() : referent->is_oop_or_null()) failed: referenceProcessor.cpp:1054
johnc
parents:
3979
diff
changeset
|
420 FilterIntoCSClosure update_rs_cset_oop_cl(NULL, _g1, &update_rs_cl); |
| 1705 | 421 FilterOutOfRegionClosure filter_then_update_rs_cset_oop_cl(r, &update_rs_cset_oop_cl); |
| 422 | |
| 423 // We can pass false as the "filter_young" parameter here as: | |
| 424 // * we should be in a STW pause, | |
| 425 // * the DCQS to which this closure is applied is used to hold | |
| 426 // references that point into the collection set from the prior | |
| 427 // RSet updating, | |
| 428 // * the post-write barrier shouldn't be logging updates to young | |
| 429 // regions (but there is a situation where this can happen - see | |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
430 // the comment in G1RemSet::refine_card() below - |
| 1705 | 431 // that should not be applicable here), and |
| 432 // * during actual RSet updating, the filtering of cards in young | |
| 433 // regions in HeapRegion::oops_on_card_seq_iterate_careful is | |
| 434 // employed. | |
| 435 // As a result, when this closure is applied to "refs into cset" | |
| 436 // DCQS, we shouldn't see any cards in young regions. | |
| 437 update_rs_cl.set_region(r); | |
| 438 HeapWord* stop_point = | |
| 439 r->oops_on_card_seq_iterate_careful(scanRegion, | |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
440 &filter_then_update_rs_cset_oop_cl, |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
441 false /* filter_young */, |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
442 NULL /* card_ptr */); |
| 1705 | 443 |
| 444 // Since this is performed in the event of an evacuation failure, we | |
| 445 // we shouldn't see a non-null stop point | |
| 446 assert(stop_point == NULL, "saw an unallocated region"); | |
| 447 return true; | |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
448 } |
|
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
449 }; |
|
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
450 |
| 1861 | 451 void G1RemSet::cleanup_after_oops_into_collection_set_do() { |
| 342 | 452 guarantee( _cards_scanned != NULL, "invariant" ); |
| 453 _total_cards_scanned = 0; | |
|
3777
e8b0b0392037
7046182: G1: remove unnecessary iterations over the collection set
tonyp
parents:
3765
diff
changeset
|
454 for (uint i = 0; i < n_workers(); ++i) { |
| 342 | 455 _total_cards_scanned += _cards_scanned[i]; |
|
3777
e8b0b0392037
7046182: G1: remove unnecessary iterations over the collection set
tonyp
parents:
3765
diff
changeset
|
456 } |
| 6197 | 457 FREE_C_HEAP_ARRAY(size_t, _cards_scanned, mtGC); |
| 342 | 458 _cards_scanned = NULL; |
| 459 // Cleanup after copy | |
| 460 _g1->set_refine_cte_cl_concurrency(true); | |
| 461 // Set all cards back to clean. | |
| 462 _g1->cleanUpCardTable(); | |
| 794 | 463 |
| 1705 | 464 DirtyCardQueueSet& into_cset_dcqs = _g1->into_cset_dirty_card_queue_set(); |
| 465 int into_cset_n_buffers = into_cset_dcqs.completed_buffers_num(); | |
| 466 | |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
467 if (_g1->evacuation_failed()) { |
|
17757
eff02b5bd56c
8035654: Add times for evacuation failure handling in "Other" time
tschatzl
parents:
13059
diff
changeset
|
468 double restore_remembered_set_start = os::elapsedTime(); |
|
eff02b5bd56c
8035654: Add times for evacuation failure handling in "Other" time
tschatzl
parents:
13059
diff
changeset
|
469 |
| 1705 | 470 // Restore remembered sets for the regions pointing into the collection set. |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
471 if (G1DeferredRSUpdate) { |
| 1705 | 472 // If deferred RS updates are enabled then we just need to transfer |
| 473 // the completed buffers from (a) the DirtyCardQueueSet used to hold | |
| 474 // cards that contain references that point into the collection set | |
| 475 // to (b) the DCQS used to hold the deferred RS updates | |
| 476 _g1->dirty_card_queue_set().merge_bufferlists(&into_cset_dcqs); | |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
477 } else { |
| 1705 | 478 |
| 479 CardTableModRefBS* bs = (CardTableModRefBS*)_g1->barrier_set(); | |
| 480 UpdateRSetCardTableEntryIntoCSetClosure update_rs_cset_immediate(_g1, bs); | |
| 481 | |
| 482 int n_completed_buffers = 0; | |
| 483 while (into_cset_dcqs.apply_closure_to_completed_buffer(&update_rs_cset_immediate, | |
| 484 0, 0, true)) { | |
| 485 n_completed_buffers++; | |
| 486 } | |
| 487 assert(n_completed_buffers == into_cset_n_buffers, "missed some buffers"); | |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
488 } |
|
17757
eff02b5bd56c
8035654: Add times for evacuation failure handling in "Other" time
tschatzl
parents:
13059
diff
changeset
|
489 |
|
eff02b5bd56c
8035654: Add times for evacuation failure handling in "Other" time
tschatzl
parents:
13059
diff
changeset
|
490 _g1->g1_policy()->phase_times()->record_evac_fail_restore_remsets((os::elapsedTime() - restore_remembered_set_start) * 1000.0); |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
491 } |
| 1705 | 492 |
| 493 // Free any completed buffers in the DirtyCardQueueSet used to hold cards | |
| 494 // which contain references that point into the collection. | |
| 495 _g1->into_cset_dirty_card_queue_set().clear(); | |
| 496 assert(_g1->into_cset_dirty_card_queue_set().completed_buffers_num() == 0, | |
| 497 "all buffers should be freed"); | |
| 498 _g1->into_cset_dirty_card_queue_set().clear_n_completed_buffers(); | |
| 342 | 499 } |
| 500 | |
| 501 class ScrubRSClosure: public HeapRegionClosure { | |
| 502 G1CollectedHeap* _g1h; | |
| 503 BitMap* _region_bm; | |
| 504 BitMap* _card_bm; | |
| 505 CardTableModRefBS* _ctbs; | |
| 506 public: | |
| 507 ScrubRSClosure(BitMap* region_bm, BitMap* card_bm) : | |
| 508 _g1h(G1CollectedHeap::heap()), | |
| 509 _region_bm(region_bm), _card_bm(card_bm), | |
| 12343 | 510 _ctbs(_g1h->g1_barrier_set()) {} |
| 342 | 511 |
| 512 bool doHeapRegion(HeapRegion* r) { | |
| 513 if (!r->continuesHumongous()) { | |
| 514 r->rem_set()->scrub(_ctbs, _region_bm, _card_bm); | |
| 515 } | |
| 516 return false; | |
| 517 } | |
| 518 }; | |
| 519 | |
| 1861 | 520 void G1RemSet::scrub(BitMap* region_bm, BitMap* card_bm) { |
| 342 | 521 ScrubRSClosure scrub_cl(region_bm, card_bm); |
| 522 _g1->heap_region_iterate(&scrub_cl); | |
| 523 } | |
| 524 | |
| 1861 | 525 void G1RemSet::scrub_par(BitMap* region_bm, BitMap* card_bm, |
|
4728
441e946dc1af
7121618: Change type of number of GC workers to unsigned int.
jmasa
parents:
4097
diff
changeset
|
526 uint worker_num, int claim_val) { |
| 342 | 527 ScrubRSClosure scrub_cl(region_bm, card_bm); |
|
4095
bca17e38de00
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
4090
diff
changeset
|
528 _g1->heap_region_par_iterate_chunked(&scrub_cl, |
|
bca17e38de00
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
4090
diff
changeset
|
529 worker_num, |
|
4728
441e946dc1af
7121618: Change type of number of GC workers to unsigned int.
jmasa
parents:
4097
diff
changeset
|
530 n_workers(), |
|
4095
bca17e38de00
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
4090
diff
changeset
|
531 claim_val); |
| 342 | 532 } |
| 533 | |
| 4839 | 534 G1TriggerClosure::G1TriggerClosure() : |
| 535 _triggered(false) { } | |
| 536 | |
| 537 G1InvokeIfNotTriggeredClosure::G1InvokeIfNotTriggeredClosure(G1TriggerClosure* t_cl, | |
| 538 OopClosure* oop_cl) : | |
| 539 _trigger_cl(t_cl), _oop_cl(oop_cl) { } | |
| 1705 | 540 |
| 4839 | 541 G1Mux2Closure::G1Mux2Closure(OopClosure *c1, OopClosure *c2) : |
| 542 _c1(c1), _c2(c2) { } | |
| 1705 | 543 |
| 4839 | 544 G1UpdateRSOrPushRefOopClosure:: |
| 545 G1UpdateRSOrPushRefOopClosure(G1CollectedHeap* g1h, | |
| 546 G1RemSet* rs, | |
| 547 OopsInHeapRegionClosure* push_ref_cl, | |
| 548 bool record_refs_into_cset, | |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17757
diff
changeset
|
549 uint worker_i) : |
| 4839 | 550 _g1(g1h), _g1_rem_set(rs), _from(NULL), |
| 551 _record_refs_into_cset(record_refs_into_cset), | |
| 552 _push_ref_cl(push_ref_cl), _worker_i(worker_i) { } | |
| 1705 | 553 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
554 // Returns true if the given card contains references that point |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
555 // into the collection set, if we're checking for such references; |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
556 // false otherwise. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
557 |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17757
diff
changeset
|
558 bool G1RemSet::refine_card(jbyte* card_ptr, uint worker_i, |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
559 bool check_for_refs_into_cset) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
560 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
561 // If the card is no longer dirty, nothing to do. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
562 if (*card_ptr != CardTableModRefBS::dirty_card_val()) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
563 // No need to return that this card contains refs that point |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
564 // into the collection set. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
565 return false; |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
566 } |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
567 |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
568 // Construct the region representing the card. |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
569 HeapWord* start = _ct_bs->addr_for(card_ptr); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
570 // And find the region containing it. |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
571 HeapRegion* r = _g1->heap_region_containing(start); |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
572 if (r == NULL) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
573 // Again no need to return that this card contains refs that |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
574 // point into the collection set. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
575 return false; // Not in the G1 heap (might be in perm, for example.) |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
576 } |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
577 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
578 // Why do we have to check here whether a card is on a young region, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
579 // given that we dirty young regions and, as a result, the |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
580 // post-barrier is supposed to filter them out and never to enqueue |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
581 // them? When we allocate a new region as the "allocation region" we |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
582 // actually dirty its cards after we release the lock, since card |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
583 // dirtying while holding the lock was a performance bottleneck. So, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
584 // as a result, it is possible for other threads to actually |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
585 // allocate objects in the region (after the acquire the lock) |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
586 // before all the cards on the region are dirtied. This is unlikely, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
587 // and it doesn't happen often, but it can happen. So, the extra |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
588 // check below filters out those cards. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
589 if (r->is_young()) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
590 return false; |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
591 } |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
592 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
593 // While we are processing RSet buffers during the collection, we |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
594 // actually don't want to scan any cards on the collection set, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
595 // since we don't want to update remebered sets with entries that |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
596 // point into the collection set, given that live objects from the |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
597 // collection set are about to move and such entries will be stale |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
598 // very soon. This change also deals with a reliability issue which |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
599 // involves scanning a card in the collection set and coming across |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
600 // an array that was being chunked and looking malformed. Note, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
601 // however, that if evacuation fails, we have to scan any objects |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
602 // that were not moved and create any missing entries. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
603 if (r->in_collection_set()) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
604 return false; |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
605 } |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
606 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
607 // The result from the hot card cache insert call is either: |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
608 // * pointer to the current card |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
609 // (implying that the current card is not 'hot'), |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
610 // * null |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
611 // (meaning we had inserted the card ptr into the "hot" card cache, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
612 // which had some headroom), |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
613 // * a pointer to a "hot" card that was evicted from the "hot" cache. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
614 // |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
615 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
616 G1HotCardCache* hot_card_cache = _cg1r->hot_card_cache(); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
617 if (hot_card_cache->use_cache()) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
618 assert(!check_for_refs_into_cset, "sanity"); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
619 assert(!SafepointSynchronize::is_at_safepoint(), "sanity"); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
620 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
621 card_ptr = hot_card_cache->insert(card_ptr); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
622 if (card_ptr == NULL) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
623 // There was no eviction. Nothing to do. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
624 return false; |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
625 } |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
626 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
627 start = _ct_bs->addr_for(card_ptr); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
628 r = _g1->heap_region_containing(start); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
629 if (r == NULL) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
630 // Not in the G1 heap |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
631 return false; |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
632 } |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
633 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
634 // Checking whether the region we got back from the cache |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
635 // is young here is inappropriate. The region could have been |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
636 // freed, reallocated and tagged as young while in the cache. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
637 // Hence we could see its young type change at any time. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
638 } |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
639 |
|
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
640 // Don't use addr_for(card_ptr + 1) which can ask for |
|
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
641 // a card beyond the heap. This is not safe without a perm |
|
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
642 // gen at the upper end of the heap. |
|
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
643 HeapWord* end = start + CardTableModRefBS::card_size_in_words; |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
644 MemRegion dirtyRegion(start, end); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
645 |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
646 #if CARD_REPEAT_HISTO |
|
2188
c33825b68624
6923430: G1: assert(res != 0,"This should have worked.")
johnc
parents:
1972
diff
changeset
|
647 init_ct_freq_table(_g1->max_capacity()); |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
648 ct_freq_note_card(_ct_bs->index_for(start)); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
649 #endif |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
650 |
|
4071
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
651 OopsInHeapRegionClosure* oops_in_heap_closure = NULL; |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
652 if (check_for_refs_into_cset) { |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
653 // ConcurrentG1RefineThreads have worker numbers larger than what |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
654 // _cset_rs_update_cl[] is set up to handle. But those threads should |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
655 // only be active outside of a collection which means that when they |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
656 // reach here they should have check_for_refs_into_cset == false. |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
657 assert((size_t)worker_i < n_workers(), "index of worker larger than _cset_rs_update_cl[].length"); |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
658 oops_in_heap_closure = _cset_rs_update_cl[worker_i]; |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
659 } |
| 4839 | 660 G1UpdateRSOrPushRefOopClosure update_rs_oop_cl(_g1, |
| 661 _g1->g1_rem_set(), | |
| 662 oops_in_heap_closure, | |
| 663 check_for_refs_into_cset, | |
| 664 worker_i); | |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
665 update_rs_oop_cl.set_from(r); |
| 1705 | 666 |
| 4839 | 667 G1TriggerClosure trigger_cl; |
|
3983
811ec3d0833b
7097053: G1: assert(da ? referent->is_oop() : referent->is_oop_or_null()) failed: referenceProcessor.cpp:1054
johnc
parents:
3979
diff
changeset
|
668 FilterIntoCSClosure into_cs_cl(NULL, _g1, &trigger_cl); |
| 4839 | 669 G1InvokeIfNotTriggeredClosure invoke_cl(&trigger_cl, &into_cs_cl); |
| 670 G1Mux2Closure mux(&invoke_cl, &update_rs_oop_cl); | |
| 1705 | 671 |
| 672 FilterOutOfRegionClosure filter_then_update_rs_oop_cl(r, | |
| 673 (check_for_refs_into_cset ? | |
| 674 (OopClosure*)&mux : | |
| 675 (OopClosure*)&update_rs_oop_cl)); | |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
676 |
|
1666
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
677 // The region for the current card may be a young region. The |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
678 // current card may have been a card that was evicted from the |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
679 // card cache. When the card was inserted into the cache, we had |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
680 // determined that its region was non-young. While in the cache, |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
681 // the region may have been freed during a cleanup pause, reallocated |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
682 // and tagged as young. |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
683 // |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
684 // We wish to filter out cards for such a region but the current |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
685 // thread, if we're running concurrently, may "see" the young type |
|
1666
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
686 // change at any time (so an earlier "is_young" check may pass or |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
687 // fail arbitrarily). We tell the iteration code to perform this |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
688 // filtering when it has been determined that there has been an actual |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
689 // allocation in this region and making it safe to check the young type. |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
690 bool filter_young = true; |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
691 |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
692 HeapWord* stop_point = |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
693 r->oops_on_card_seq_iterate_careful(dirtyRegion, |
|
1666
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
694 &filter_then_update_rs_oop_cl, |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
695 filter_young, |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
696 card_ptr); |
|
1666
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
697 |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
698 // If stop_point is non-null, then we encountered an unallocated region |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
699 // (perhaps the unfilled portion of a TLAB.) For now, we'll dirty the |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
700 // card and re-enqueue: if we put off the card until a GC pause, then the |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
701 // unallocated portion will be filled in. Alternatively, we might try |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
702 // the full complexity of the technique used in "regular" precleaning. |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
703 if (stop_point != NULL) { |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
704 // The card might have gotten re-dirtied and re-enqueued while we |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
705 // worked. (In fact, it's pretty likely.) |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
706 if (*card_ptr != CardTableModRefBS::dirty_card_val()) { |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
707 *card_ptr = CardTableModRefBS::dirty_card_val(); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
708 MutexLockerEx x(Shared_DirtyCardQ_lock, |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
709 Mutex::_no_safepoint_check_flag); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
710 DirtyCardQueue* sdcq = |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
711 JavaThread::dirty_card_queue_set().shared_dirty_card_queue(); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
712 sdcq->enqueue(card_ptr); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
713 } |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
714 } else { |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
715 _conc_refine_cards++; |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
716 } |
| 1705 | 717 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
718 // This gets set to true if the card being refined has |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
719 // references that point into the collection set. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
720 bool has_refs_into_cset = trigger_cl.triggered(); |
| 342 | 721 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
722 // We should only be detecting that the card contains references |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
723 // that point into the collection set if the current thread is |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
724 // a GC worker thread. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
725 assert(!has_refs_into_cset || SafepointSynchronize::is_at_safepoint(), |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
726 "invalid result at non safepoint"); |
| 1705 | 727 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
728 return has_refs_into_cset; |
| 342 | 729 } |
| 730 | |
|
12339
c319b188c7b2
8014078: G1: improve remembered set summary information by providing per region type information
tschatzl
parents:
12080
diff
changeset
|
731 void G1RemSet::print_periodic_summary_info(const char* header) { |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
732 G1RemSetSummary current; |
|
12344
7ec10139bf37
8025441: G1: assert "assert(thread < _num_vtimes) failed: just checking" fails when G1ConcRefinementThreads > ParallelGCThreads
tschatzl
parents:
12343
diff
changeset
|
733 current.initialize(this); |
| 342 | 734 |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
735 _prev_period_summary.subtract_from(¤t); |
|
12339
c319b188c7b2
8014078: G1: improve remembered set summary information by providing per region type information
tschatzl
parents:
12080
diff
changeset
|
736 print_summary_info(&_prev_period_summary, header); |
| 342 | 737 |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
738 _prev_period_summary.set(¤t); |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
739 } |
| 794 | 740 |
| 1861 | 741 void G1RemSet::print_summary_info() { |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
742 G1RemSetSummary current; |
|
12344
7ec10139bf37
8025441: G1: assert "assert(thread < _num_vtimes) failed: just checking" fails when G1ConcRefinementThreads > ParallelGCThreads
tschatzl
parents:
12343
diff
changeset
|
743 current.initialize(this); |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
744 |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
745 print_summary_info(¤t, " Cumulative RS summary"); |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
746 } |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
747 |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
748 void G1RemSet::print_summary_info(G1RemSetSummary * summary, const char * header) { |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
749 assert(summary != NULL, "just checking"); |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
750 |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
751 if (header != NULL) { |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
752 gclog_or_tty->print_cr("%s", header); |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
753 } |
| 342 | 754 |
| 755 #if CARD_REPEAT_HISTO | |
| 756 gclog_or_tty->print_cr("\nG1 card_repeat count histogram: "); | |
| 757 gclog_or_tty->print_cr(" # of repeats --> # of cards with that number."); | |
| 758 card_repeat_count.print_on(gclog_or_tty); | |
| 759 #endif | |
| 760 | |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
761 summary->print_on(gclog_or_tty); |
| 342 | 762 } |
| 1705 | 763 |
| 1861 | 764 void G1RemSet::prepare_for_verify() { |
|
637
25e146966e7c
6817419: G1: Enable extensive verification for humongous regions
iveresov
parents:
626
diff
changeset
|
765 if (G1HRRSFlushLogBuffersOnVerify && |
|
25e146966e7c
6817419: G1: Enable extensive verification for humongous regions
iveresov
parents:
626
diff
changeset
|
766 (VerifyBeforeGC || VerifyAfterGC) |
|
10373
3a4805ad0005
8015244: G1: Verification after a full GC is incorrectly placed.
johnc
parents:
10372
diff
changeset
|
767 && (!_g1->full_collection() || G1VerifyRSetsDuringFullGC)) { |
| 342 | 768 cleanupHRRS(); |
| 769 _g1->set_refine_cte_cl_concurrency(false); | |
| 770 if (SafepointSynchronize::is_at_safepoint()) { | |
| 771 DirtyCardQueueSet& dcqs = JavaThread::dirty_card_queue_set(); | |
| 772 dcqs.concatenate_logs(); | |
| 773 } | |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
774 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
775 G1HotCardCache* hot_card_cache = _cg1r->hot_card_cache(); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
776 bool use_hot_card_cache = hot_card_cache->use_cache(); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
777 hot_card_cache->set_use_cache(false); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
778 |
| 1705 | 779 DirtyCardQueue into_cset_dcq(&_g1->into_cset_dirty_card_queue_set()); |
| 780 updateRS(&into_cset_dcq, 0); | |
| 781 _g1->into_cset_dirty_card_queue_set().clear(); | |
|
637
25e146966e7c
6817419: G1: Enable extensive verification for humongous regions
iveresov
parents:
626
diff
changeset
|
782 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
783 hot_card_cache->set_use_cache(use_hot_card_cache); |
|
637
25e146966e7c
6817419: G1: Enable extensive verification for humongous regions
iveresov
parents:
626
diff
changeset
|
784 assert(JavaThread::dirty_card_queue_set().completed_buffers_num() == 0, "All should be consumed"); |
| 342 | 785 } |
| 786 } |