Mercurial > hg > graal-jvmci-8
annotate src/share/vm/gc_implementation/g1/g1RemSet.cpp @ 23569:f3f2f71d2dc8
8139424: SIGSEGV, Problematic frame: # V [libjvm.so+0xd0c0cc] void InstanceKlass::oop_oop_iterate_oop_maps_specialized<true,oopDesc*,MarkAndPushClosure>
Summary: The crash was caused by a faulty eager humongous reclaim. The reason for reclaiming a live object was that the call to cleanupHRRS was done after dirtying cards and clearing the remembered sets for the humongous object. This could lead to one or many cards being missed.
Reviewed-by: tbenson, kbarrett, tschatzl
| author | dbuck |
|---|---|
| date | Tue, 19 Jan 2016 18:16:40 +0000 |
| parents | ea47136e6ea4 |
| children | b5f3a471e646 |
| rev | line source |
|---|---|
| 342 | 1 /* |
|
17937
78bbf4d43a14
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
17844
diff
changeset
|
2 * Copyright (c) 2001, 2014, Oracle and/or its affiliates. All rights reserved. |
| 342 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1282
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1282
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1282
diff
changeset
|
21 * questions. |
| 342 | 22 * |
| 23 */ | |
| 24 | |
| 1972 | 25 #include "precompiled.hpp" |
| 26 #include "gc_implementation/g1/concurrentG1Refine.hpp" | |
| 27 #include "gc_implementation/g1/concurrentG1RefineThread.hpp" | |
| 28 #include "gc_implementation/g1/g1BlockOffsetTable.inline.hpp" | |
| 29 #include "gc_implementation/g1/g1CollectedHeap.inline.hpp" | |
| 30 #include "gc_implementation/g1/g1CollectorPolicy.hpp" | |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
31 #include "gc_implementation/g1/g1HotCardCache.hpp" |
|
6219
922993931b3d
7178361: G1: Make sure that PrintGC and PrintGCDetails use the same timing for the GC pause
brutisso
parents:
4839
diff
changeset
|
32 #include "gc_implementation/g1/g1GCPhaseTimes.hpp" |
| 1972 | 33 #include "gc_implementation/g1/g1OopClosures.inline.hpp" |
| 34 #include "gc_implementation/g1/g1RemSet.inline.hpp" | |
|
20377
a8ea2f110d87
8054819: Rename HeapRegionSeq to HeapRegionManager
tschatzl
parents:
20337
diff
changeset
|
35 #include "gc_implementation/g1/heapRegionManager.inline.hpp" |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
36 #include "gc_implementation/g1/heapRegionRemSet.hpp" |
| 1972 | 37 #include "memory/iterator.hpp" |
| 38 #include "oops/oop.inline.hpp" | |
| 39 #include "utilities/intHisto.hpp" | |
| 342 | 40 |
|
17937
78bbf4d43a14
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
17844
diff
changeset
|
41 PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC |
|
78bbf4d43a14
8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents:
17844
diff
changeset
|
42 |
| 342 | 43 #define CARD_REPEAT_HISTO 0 |
| 44 | |
| 45 #if CARD_REPEAT_HISTO | |
| 46 static size_t ct_freq_sz; | |
| 47 static jbyte* ct_freq = NULL; | |
| 48 | |
| 49 void init_ct_freq_table(size_t heap_sz_bytes) { | |
| 50 if (ct_freq == NULL) { | |
| 51 ct_freq_sz = heap_sz_bytes/CardTableModRefBS::card_size; | |
| 52 ct_freq = new jbyte[ct_freq_sz]; | |
| 53 for (size_t j = 0; j < ct_freq_sz; j++) ct_freq[j] = 0; | |
| 54 } | |
| 55 } | |
| 56 | |
| 57 void ct_freq_note_card(size_t index) { | |
| 58 assert(0 <= index && index < ct_freq_sz, "Bounds error."); | |
| 59 if (ct_freq[index] < 100) { ct_freq[index]++; } | |
| 60 } | |
| 61 | |
| 62 static IntHistogram card_repeat_count(10, 10); | |
| 63 | |
| 64 void ct_freq_update_histo_and_reset() { | |
| 65 for (size_t j = 0; j < ct_freq_sz; j++) { | |
| 66 card_repeat_count.add_entry(ct_freq[j]); | |
| 67 ct_freq[j] = 0; | |
| 68 } | |
| 69 | |
| 70 } | |
| 71 #endif | |
| 72 | |
| 1861 | 73 G1RemSet::G1RemSet(G1CollectedHeap* g1, CardTableModRefBS* ct_bs) |
| 74 : _g1(g1), _conc_refine_cards(0), | |
| 75 _ct_bs(ct_bs), _g1p(_g1->g1_policy()), | |
| 342 | 76 _cg1r(g1->concurrent_g1_refine()), |
| 1705 | 77 _cset_rs_update_cl(NULL), |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
78 _cards_scanned(NULL), _total_cards_scanned(0), |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
79 _prev_period_summary() |
| 342 | 80 { |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
81 guarantee(n_workers() > 0, "There should be some workers"); |
|
23220
b554c7fa9478
8067655: Clean up G1 remembered set oop iteration
mgerdin
parents:
20504
diff
changeset
|
82 _cset_rs_update_cl = NEW_C_HEAP_ARRAY(G1ParPushHeapRSClosure*, n_workers(), mtGC); |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
83 for (uint i = 0; i < n_workers(); i++) { |
| 1705 | 84 _cset_rs_update_cl[i] = NULL; |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
85 } |
|
12344
7ec10139bf37
8025441: G1: assert "assert(thread < _num_vtimes) failed: just checking" fails when G1ConcRefinementThreads > ParallelGCThreads
tschatzl
parents:
12343
diff
changeset
|
86 if (G1SummarizeRSetStats) { |
|
7ec10139bf37
8025441: G1: assert "assert(thread < _num_vtimes) failed: just checking" fails when G1ConcRefinementThreads > ParallelGCThreads
tschatzl
parents:
12343
diff
changeset
|
87 _prev_period_summary.initialize(this); |
|
7ec10139bf37
8025441: G1: assert "assert(thread < _num_vtimes) failed: just checking" fails when G1ConcRefinementThreads > ParallelGCThreads
tschatzl
parents:
12343
diff
changeset
|
88 } |
| 342 | 89 } |
| 90 | |
| 1861 | 91 G1RemSet::~G1RemSet() { |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
92 for (uint i = 0; i < n_workers(); i++) { |
| 1705 | 93 assert(_cset_rs_update_cl[i] == NULL, "it should be"); |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
94 } |
|
23220
b554c7fa9478
8067655: Clean up G1 remembered set oop iteration
mgerdin
parents:
20504
diff
changeset
|
95 FREE_C_HEAP_ARRAY(G1ParPushHeapRSClosure*, _cset_rs_update_cl, mtGC); |
| 342 | 96 } |
| 97 | |
| 98 void CountNonCleanMemRegionClosure::do_MemRegion(MemRegion mr) { | |
| 99 if (_g1->is_in_g1_reserved(mr.start())) { | |
| 100 _n += (int) ((mr.byte_size() / CardTableModRefBS::card_size)); | |
| 101 if (_start_first == NULL) _start_first = mr.start(); | |
| 102 } | |
| 103 } | |
| 104 | |
| 105 class ScanRSClosure : public HeapRegionClosure { | |
| 106 size_t _cards_done, _cards; | |
| 107 G1CollectedHeap* _g1h; | |
| 12080 | 108 |
|
23220
b554c7fa9478
8067655: Clean up G1 remembered set oop iteration
mgerdin
parents:
20504
diff
changeset
|
109 G1ParPushHeapRSClosure* _oc; |
| 20494 | 110 CodeBlobClosure* _code_root_cl; |
| 12080 | 111 |
| 342 | 112 G1BlockOffsetSharedArray* _bot_shared; |
| 12343 | 113 G1SATBCardTableModRefBS *_ct_bs; |
| 12080 | 114 |
| 115 double _strong_code_root_scan_time_sec; | |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17757
diff
changeset
|
116 uint _worker_i; |
| 12080 | 117 int _block_size; |
| 118 bool _try_claimed; | |
| 119 | |
| 342 | 120 public: |
|
23220
b554c7fa9478
8067655: Clean up G1 remembered set oop iteration
mgerdin
parents:
20504
diff
changeset
|
121 ScanRSClosure(G1ParPushHeapRSClosure* oc, |
| 20494 | 122 CodeBlobClosure* code_root_cl, |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17757
diff
changeset
|
123 uint worker_i) : |
| 342 | 124 _oc(oc), |
| 12080 | 125 _code_root_cl(code_root_cl), |
| 126 _strong_code_root_scan_time_sec(0.0), | |
| 342 | 127 _cards(0), |
| 128 _cards_done(0), | |
| 129 _worker_i(worker_i), | |
| 130 _try_claimed(false) | |
| 131 { | |
| 132 _g1h = G1CollectedHeap::heap(); | |
| 133 _bot_shared = _g1h->bot_shared(); | |
| 12343 | 134 _ct_bs = _g1h->g1_barrier_set(); |
| 1261 | 135 _block_size = MAX2<int>(G1RSetScanBlockSize, 1); |
| 342 | 136 } |
| 137 | |
| 138 void set_try_claimed() { _try_claimed = true; } | |
| 139 | |
| 140 void scanCard(size_t index, HeapRegion *r) { | |
| 4023 | 141 // Stack allocate the DirtyCardToOopClosure instance |
| 142 HeapRegionDCTOC cl(_g1h, r, _oc, | |
|
23220
b554c7fa9478
8067655: Clean up G1 remembered set oop iteration
mgerdin
parents:
20504
diff
changeset
|
143 CardTableModRefBS::Precise); |
| 342 | 144 |
| 145 // Set the "from" region in the closure. | |
| 146 _oc->set_region(r); | |
|
22897
80ac3ee51955
8065358: Refactor G1s usage of save_marks and reduce related races
mgerdin
parents:
20504
diff
changeset
|
147 MemRegion card_region(_bot_shared->address_for_index(index), G1BlockOffsetSharedArray::N_words); |
|
80ac3ee51955
8065358: Refactor G1s usage of save_marks and reduce related races
mgerdin
parents:
20504
diff
changeset
|
148 MemRegion pre_gc_allocated(r->bottom(), r->scan_top()); |
|
80ac3ee51955
8065358: Refactor G1s usage of save_marks and reduce related races
mgerdin
parents:
20504
diff
changeset
|
149 MemRegion mr = pre_gc_allocated.intersection(card_region); |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
150 if (!mr.is_empty() && !_ct_bs->is_card_claimed(index)) { |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
151 // We make the card as "claimed" lazily (so races are possible |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
152 // but they're benign), which reduces the number of duplicate |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
153 // scans (the rsets of the regions in the cset can intersect). |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
154 _ct_bs->set_card_claimed(index); |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
155 _cards_done++; |
| 4023 | 156 cl.do_MemRegion(mr); |
| 342 | 157 } |
| 158 } | |
| 159 | |
| 160 void printCard(HeapRegion* card_region, size_t card_index, | |
| 161 HeapWord* card_start) { | |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17757
diff
changeset
|
162 gclog_or_tty->print_cr("T " UINT32_FORMAT " Region [" PTR_FORMAT ", " PTR_FORMAT ") " |
| 342 | 163 "RS names card %p: " |
| 164 "[" PTR_FORMAT ", " PTR_FORMAT ")", | |
| 165 _worker_i, | |
| 166 card_region->bottom(), card_region->end(), | |
| 167 card_index, | |
| 168 card_start, card_start + G1BlockOffsetSharedArray::N_words); | |
| 169 } | |
| 170 | |
| 12080 | 171 void scan_strong_code_roots(HeapRegion* r) { |
| 172 double scan_start = os::elapsedTime(); | |
| 173 r->strong_code_roots_do(_code_root_cl); | |
| 174 _strong_code_root_scan_time_sec += (os::elapsedTime() - scan_start); | |
| 175 } | |
| 176 | |
| 342 | 177 bool doHeapRegion(HeapRegion* r) { |
| 178 assert(r->in_collection_set(), "should only be called on elements of CS."); | |
| 179 HeapRegionRemSet* hrrs = r->rem_set(); | |
| 180 if (hrrs->iter_is_complete()) return false; // All done. | |
| 181 if (!_try_claimed && !hrrs->claim_iter()) return false; | |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
182 // If we ever free the collection set concurrently, we should also |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
183 // clear the card table concurrently therefore we won't need to |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
184 // add regions of the collection set to the dirty cards region. |
|
796
29e7d79232b9
6819065: G1: eliminate high serial card table clearing time
apetrusenko
parents:
794
diff
changeset
|
185 _g1h->push_dirty_cards_region(r); |
| 342 | 186 // If we didn't return above, then |
| 187 // _try_claimed || r->claim_iter() | |
| 188 // is true: either we're supposed to work on claimed-but-not-complete | |
| 189 // regions, or we successfully claimed the region. | |
| 12080 | 190 |
|
10182
5c93c1f61226
8011724: G1: Stack allocate instances of HeapRegionRemSetIterator
johnc
parents:
6725
diff
changeset
|
191 HeapRegionRemSetIterator iter(hrrs); |
| 342 | 192 size_t card_index; |
| 1261 | 193 |
| 194 // We claim cards in block so as to recude the contention. The block size is determined by | |
| 195 // the G1RSetScanBlockSize parameter. | |
| 196 size_t jump_to_card = hrrs->iter_claimed_next(_block_size); | |
|
10182
5c93c1f61226
8011724: G1: Stack allocate instances of HeapRegionRemSetIterator
johnc
parents:
6725
diff
changeset
|
197 for (size_t current_card = 0; iter.has_next(card_index); current_card++) { |
| 1261 | 198 if (current_card >= jump_to_card + _block_size) { |
| 199 jump_to_card = hrrs->iter_claimed_next(_block_size); | |
| 747 | 200 } |
| 1261 | 201 if (current_card < jump_to_card) continue; |
| 342 | 202 HeapWord* card_start = _g1h->bot_shared()->address_for_index(card_index); |
| 203 #if 0 | |
| 204 gclog_or_tty->print("Rem set iteration yielded card [" PTR_FORMAT ", " PTR_FORMAT ").\n", | |
| 205 card_start, card_start + CardTableModRefBS::card_size_in_words); | |
| 206 #endif | |
| 207 | |
| 208 HeapRegion* card_region = _g1h->heap_region_containing(card_start); | |
| 209 _cards++; | |
| 210 | |
|
796
29e7d79232b9
6819065: G1: eliminate high serial card table clearing time
apetrusenko
parents:
794
diff
changeset
|
211 if (!card_region->is_on_dirty_cards_region_list()) { |
|
29e7d79232b9
6819065: G1: eliminate high serial card table clearing time
apetrusenko
parents:
794
diff
changeset
|
212 _g1h->push_dirty_cards_region(card_region); |
|
29e7d79232b9
6819065: G1: eliminate high serial card table clearing time
apetrusenko
parents:
794
diff
changeset
|
213 } |
|
29e7d79232b9
6819065: G1: eliminate high serial card table clearing time
apetrusenko
parents:
794
diff
changeset
|
214 |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
215 // If the card is dirty, then we will scan it during updateRS. |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
216 if (!card_region->in_collection_set() && |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
217 !_ct_bs->is_card_dirty(card_index)) { |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
218 scanCard(card_index, card_region); |
| 342 | 219 } |
| 220 } | |
| 747 | 221 if (!_try_claimed) { |
| 12080 | 222 // Scan the strong code root list attached to the current region |
| 223 scan_strong_code_roots(r); | |
| 224 | |
| 747 | 225 hrrs->set_iter_complete(); |
| 226 } | |
| 342 | 227 return false; |
| 228 } | |
| 12080 | 229 |
| 230 double strong_code_root_scan_time_sec() { | |
| 231 return _strong_code_root_scan_time_sec; | |
| 232 } | |
| 233 | |
| 342 | 234 size_t cards_done() { return _cards_done;} |
| 235 size_t cards_looked_up() { return _cards;} | |
| 236 }; | |
| 237 | |
|
23220
b554c7fa9478
8067655: Clean up G1 remembered set oop iteration
mgerdin
parents:
20504
diff
changeset
|
238 void G1RemSet::scanRS(G1ParPushHeapRSClosure* oc, |
| 20494 | 239 CodeBlobClosure* code_root_cl, |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17757
diff
changeset
|
240 uint worker_i) { |
| 342 | 241 double rs_time_start = os::elapsedTime(); |
|
4097
dc467e8b2c5e
7112743: G1: Reduce overhead of marking closure during evacuation pauses
johnc
parents:
4095
diff
changeset
|
242 HeapRegion *startRegion = _g1->start_cset_region_for_worker(worker_i); |
| 342 | 243 |
| 12080 | 244 ScanRSClosure scanRScl(oc, code_root_cl, worker_i); |
|
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3777
diff
changeset
|
245 |
| 342 | 246 _g1->collection_set_iterate_from(startRegion, &scanRScl); |
| 247 scanRScl.set_try_claimed(); | |
| 248 _g1->collection_set_iterate_from(startRegion, &scanRScl); | |
| 249 | |
| 12080 | 250 double scan_rs_time_sec = (os::elapsedTime() - rs_time_start) |
| 251 - scanRScl.strong_code_root_scan_time_sec(); | |
| 342 | 252 |
| 12080 | 253 assert(_cards_scanned != NULL, "invariant"); |
| 342 | 254 _cards_scanned[worker_i] = scanRScl.cards_done(); |
| 255 | |
|
23223
8f8f1d578796
8074037: Refactor the G1GCPhaseTime logging to make it easier to add new phases
brutisso
parents:
23221
diff
changeset
|
256 _g1p->phase_times()->record_time_secs(G1GCPhaseTimes::ScanRS, worker_i, scan_rs_time_sec); |
|
8f8f1d578796
8074037: Refactor the G1GCPhaseTime logging to make it easier to add new phases
brutisso
parents:
23221
diff
changeset
|
257 _g1p->phase_times()->record_time_secs(G1GCPhaseTimes::CodeRoots, worker_i, scanRScl.strong_code_root_scan_time_sec()); |
| 342 | 258 } |
| 259 | |
| 1705 | 260 // Closure used for updating RSets and recording references that |
| 261 // point into the collection set. Only called during an | |
| 262 // evacuation pause. | |
| 263 | |
| 264 class RefineRecordRefsIntoCSCardTableEntryClosure: public CardTableEntryClosure { | |
| 265 G1RemSet* _g1rs; | |
| 266 DirtyCardQueue* _into_cset_dcq; | |
| 267 public: | |
| 268 RefineRecordRefsIntoCSCardTableEntryClosure(G1CollectedHeap* g1h, | |
| 269 DirtyCardQueue* into_cset_dcq) : | |
| 270 _g1rs(g1h->g1_rem_set()), _into_cset_dcq(into_cset_dcq) | |
| 271 {} | |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17757
diff
changeset
|
272 bool do_card_ptr(jbyte* card_ptr, uint worker_i) { |
| 1705 | 273 // The only time we care about recording cards that |
| 274 // contain references that point into the collection set | |
| 275 // is during RSet updating within an evacuation pause. | |
| 276 // In this case worker_i should be the id of a GC worker thread. | |
| 277 assert(SafepointSynchronize::is_at_safepoint(), "not during an evacuation pause"); | |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17757
diff
changeset
|
278 assert(worker_i < (ParallelGCThreads == 0 ? 1 : ParallelGCThreads), "should be a GC worker"); |
| 342 | 279 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
280 if (_g1rs->refine_card(card_ptr, worker_i, true)) { |
| 1705 | 281 // 'card_ptr' contains references that point into the collection |
| 282 // set. We need to record the card in the DCQS | |
| 283 // (G1CollectedHeap::into_cset_dirty_card_queue_set()) | |
| 284 // that's used for that purpose. | |
| 285 // | |
| 286 // Enqueue the card | |
| 287 _into_cset_dcq->enqueue(card_ptr); | |
| 288 } | |
| 289 return true; | |
| 290 } | |
| 291 }; | |
| 292 | |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17757
diff
changeset
|
293 void G1RemSet::updateRS(DirtyCardQueue* into_cset_dcq, uint worker_i) { |
|
23223
8f8f1d578796
8074037: Refactor the G1GCPhaseTime logging to make it easier to add new phases
brutisso
parents:
23221
diff
changeset
|
294 G1GCParPhaseTimesTracker x(_g1p->phase_times(), G1GCPhaseTimes::UpdateRS, worker_i); |
| 1705 | 295 // Apply the given closure to all remaining log entries. |
| 296 RefineRecordRefsIntoCSCardTableEntryClosure into_cset_update_rs_cl(_g1, into_cset_dcq); | |
|
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3777
diff
changeset
|
297 |
| 1705 | 298 _g1->iterate_dirty_card_closure(&into_cset_update_rs_cl, into_cset_dcq, false, worker_i); |
| 342 | 299 } |
| 300 | |
| 1861 | 301 void G1RemSet::cleanupHRRS() { |
| 342 | 302 HeapRegionRemSet::cleanup(); |
| 303 } | |
| 304 | |
|
23220
b554c7fa9478
8067655: Clean up G1 remembered set oop iteration
mgerdin
parents:
20504
diff
changeset
|
305 void G1RemSet::oops_into_collection_set_do(G1ParPushHeapRSClosure* oc, |
| 20494 | 306 CodeBlobClosure* code_root_cl, |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17757
diff
changeset
|
307 uint worker_i) { |
| 342 | 308 #if CARD_REPEAT_HISTO |
| 309 ct_freq_update_histo_and_reset(); | |
| 310 #endif | |
| 311 | |
| 1705 | 312 // We cache the value of 'oc' closure into the appropriate slot in the |
| 313 // _cset_rs_update_cl for this worker | |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17757
diff
changeset
|
314 assert(worker_i < n_workers(), "sanity"); |
| 1705 | 315 _cset_rs_update_cl[worker_i] = oc; |
| 316 | |
| 317 // A DirtyCardQueue that is used to hold cards containing references | |
| 318 // that point into the collection set. This DCQ is associated with a | |
| 319 // special DirtyCardQueueSet (see g1CollectedHeap.hpp). Under normal | |
| 320 // circumstances (i.e. the pause successfully completes), these cards | |
| 321 // are just discarded (there's no need to update the RSets of regions | |
| 322 // that were in the collection set - after the pause these regions | |
| 323 // are wholly 'free' of live objects. In the event of an evacuation | |
|
20504
6948da6d7c13
8052172: Evacuation failure handling in G1 does not evacuate all objects if -XX:-G1DeferredRSUpdate is set
tschatzl
parents:
20494
diff
changeset
|
324 // failure the cards/buffers in this queue set are passed to the |
|
6948da6d7c13
8052172: Evacuation failure handling in G1 does not evacuate all objects if -XX:-G1DeferredRSUpdate is set
tschatzl
parents:
20494
diff
changeset
|
325 // DirtyCardQueueSet that is used to manage RSet updates |
| 1705 | 326 DirtyCardQueue into_cset_dcq(&_g1->into_cset_dirty_card_queue_set()); |
| 327 | |
|
1708
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
328 assert((ParallelGCThreads > 0) || worker_i == 0, "invariant"); |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
329 |
|
23221
a9b72f566e9f
8051837: Remove temporary G1UseParallelRSetUpdating and G1UseParallelRSetScanning flags
brutisso
parents:
23220
diff
changeset
|
330 updateRS(&into_cset_dcq, worker_i); |
|
a9b72f566e9f
8051837: Remove temporary G1UseParallelRSetUpdating and G1UseParallelRSetScanning flags
brutisso
parents:
23220
diff
changeset
|
331 scanRS(oc, code_root_cl, worker_i); |
| 1705 | 332 |
| 333 // We now clear the cached values of _cset_rs_update_cl for this worker | |
| 334 _cset_rs_update_cl[worker_i] = NULL; | |
| 342 | 335 } |
| 336 | |
| 1861 | 337 void G1RemSet::prepare_for_oops_into_collection_set_do() { |
| 342 | 338 _g1->set_refine_cte_cl_concurrency(false); |
| 339 DirtyCardQueueSet& dcqs = JavaThread::dirty_card_queue_set(); | |
| 340 dcqs.concatenate_logs(); | |
| 341 | |
| 342 guarantee( _cards_scanned == NULL, "invariant" ); | |
| 6197 | 343 _cards_scanned = NEW_C_HEAP_ARRAY(size_t, n_workers(), mtGC); |
| 545 | 344 for (uint i = 0; i < n_workers(); ++i) { |
| 345 _cards_scanned[i] = 0; | |
| 346 } | |
| 342 | 347 _total_cards_scanned = 0; |
| 348 } | |
| 349 | |
| 1861 | 350 void G1RemSet::cleanup_after_oops_into_collection_set_do() { |
| 342 | 351 guarantee( _cards_scanned != NULL, "invariant" ); |
| 352 _total_cards_scanned = 0; | |
|
3777
e8b0b0392037
7046182: G1: remove unnecessary iterations over the collection set
tonyp
parents:
3765
diff
changeset
|
353 for (uint i = 0; i < n_workers(); ++i) { |
| 342 | 354 _total_cards_scanned += _cards_scanned[i]; |
|
3777
e8b0b0392037
7046182: G1: remove unnecessary iterations over the collection set
tonyp
parents:
3765
diff
changeset
|
355 } |
| 6197 | 356 FREE_C_HEAP_ARRAY(size_t, _cards_scanned, mtGC); |
| 342 | 357 _cards_scanned = NULL; |
| 358 // Cleanup after copy | |
| 359 _g1->set_refine_cte_cl_concurrency(true); | |
| 360 // Set all cards back to clean. | |
| 361 _g1->cleanUpCardTable(); | |
| 794 | 362 |
| 1705 | 363 DirtyCardQueueSet& into_cset_dcqs = _g1->into_cset_dirty_card_queue_set(); |
| 364 int into_cset_n_buffers = into_cset_dcqs.completed_buffers_num(); | |
| 365 | |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
366 if (_g1->evacuation_failed()) { |
|
17757
eff02b5bd56c
8035654: Add times for evacuation failure handling in "Other" time
tschatzl
parents:
13059
diff
changeset
|
367 double restore_remembered_set_start = os::elapsedTime(); |
|
eff02b5bd56c
8035654: Add times for evacuation failure handling in "Other" time
tschatzl
parents:
13059
diff
changeset
|
368 |
| 1705 | 369 // Restore remembered sets for the regions pointing into the collection set. |
|
20504
6948da6d7c13
8052172: Evacuation failure handling in G1 does not evacuate all objects if -XX:-G1DeferredRSUpdate is set
tschatzl
parents:
20494
diff
changeset
|
370 // We just need to transfer the completed buffers from the DirtyCardQueueSet |
|
6948da6d7c13
8052172: Evacuation failure handling in G1 does not evacuate all objects if -XX:-G1DeferredRSUpdate is set
tschatzl
parents:
20494
diff
changeset
|
371 // used to hold cards that contain references that point into the collection set |
|
6948da6d7c13
8052172: Evacuation failure handling in G1 does not evacuate all objects if -XX:-G1DeferredRSUpdate is set
tschatzl
parents:
20494
diff
changeset
|
372 // to the DCQS used to hold the deferred RS updates. |
|
6948da6d7c13
8052172: Evacuation failure handling in G1 does not evacuate all objects if -XX:-G1DeferredRSUpdate is set
tschatzl
parents:
20494
diff
changeset
|
373 _g1->dirty_card_queue_set().merge_bufferlists(&into_cset_dcqs); |
|
17757
eff02b5bd56c
8035654: Add times for evacuation failure handling in "Other" time
tschatzl
parents:
13059
diff
changeset
|
374 _g1->g1_policy()->phase_times()->record_evac_fail_restore_remsets((os::elapsedTime() - restore_remembered_set_start) * 1000.0); |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
375 } |
| 1705 | 376 |
| 377 // Free any completed buffers in the DirtyCardQueueSet used to hold cards | |
| 378 // which contain references that point into the collection. | |
| 379 _g1->into_cset_dirty_card_queue_set().clear(); | |
| 380 assert(_g1->into_cset_dirty_card_queue_set().completed_buffers_num() == 0, | |
| 381 "all buffers should be freed"); | |
| 382 _g1->into_cset_dirty_card_queue_set().clear_n_completed_buffers(); | |
| 342 | 383 } |
| 384 | |
| 385 class ScrubRSClosure: public HeapRegionClosure { | |
| 386 G1CollectedHeap* _g1h; | |
| 387 BitMap* _region_bm; | |
| 388 BitMap* _card_bm; | |
| 389 CardTableModRefBS* _ctbs; | |
| 390 public: | |
| 391 ScrubRSClosure(BitMap* region_bm, BitMap* card_bm) : | |
| 392 _g1h(G1CollectedHeap::heap()), | |
| 393 _region_bm(region_bm), _card_bm(card_bm), | |
| 12343 | 394 _ctbs(_g1h->g1_barrier_set()) {} |
| 342 | 395 |
| 396 bool doHeapRegion(HeapRegion* r) { | |
| 397 if (!r->continuesHumongous()) { | |
| 398 r->rem_set()->scrub(_ctbs, _region_bm, _card_bm); | |
| 399 } | |
| 400 return false; | |
| 401 } | |
| 402 }; | |
| 403 | |
| 1861 | 404 void G1RemSet::scrub(BitMap* region_bm, BitMap* card_bm) { |
| 342 | 405 ScrubRSClosure scrub_cl(region_bm, card_bm); |
| 406 _g1->heap_region_iterate(&scrub_cl); | |
| 407 } | |
| 408 | |
| 1861 | 409 void G1RemSet::scrub_par(BitMap* region_bm, BitMap* card_bm, |
|
4728
441e946dc1af
7121618: Change type of number of GC workers to unsigned int.
jmasa
parents:
4097
diff
changeset
|
410 uint worker_num, int claim_val) { |
| 342 | 411 ScrubRSClosure scrub_cl(region_bm, card_bm); |
|
4095
bca17e38de00
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
4090
diff
changeset
|
412 _g1->heap_region_par_iterate_chunked(&scrub_cl, |
|
bca17e38de00
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
4090
diff
changeset
|
413 worker_num, |
|
4728
441e946dc1af
7121618: Change type of number of GC workers to unsigned int.
jmasa
parents:
4097
diff
changeset
|
414 n_workers(), |
|
4095
bca17e38de00
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
4090
diff
changeset
|
415 claim_val); |
| 342 | 416 } |
| 417 | |
| 4839 | 418 G1TriggerClosure::G1TriggerClosure() : |
| 419 _triggered(false) { } | |
| 420 | |
| 421 G1InvokeIfNotTriggeredClosure::G1InvokeIfNotTriggeredClosure(G1TriggerClosure* t_cl, | |
| 422 OopClosure* oop_cl) : | |
| 423 _trigger_cl(t_cl), _oop_cl(oop_cl) { } | |
| 1705 | 424 |
| 4839 | 425 G1Mux2Closure::G1Mux2Closure(OopClosure *c1, OopClosure *c2) : |
| 426 _c1(c1), _c2(c2) { } | |
| 1705 | 427 |
| 4839 | 428 G1UpdateRSOrPushRefOopClosure:: |
| 429 G1UpdateRSOrPushRefOopClosure(G1CollectedHeap* g1h, | |
| 430 G1RemSet* rs, | |
|
23220
b554c7fa9478
8067655: Clean up G1 remembered set oop iteration
mgerdin
parents:
20504
diff
changeset
|
431 G1ParPushHeapRSClosure* push_ref_cl, |
| 4839 | 432 bool record_refs_into_cset, |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17757
diff
changeset
|
433 uint worker_i) : |
| 4839 | 434 _g1(g1h), _g1_rem_set(rs), _from(NULL), |
| 435 _record_refs_into_cset(record_refs_into_cset), | |
| 436 _push_ref_cl(push_ref_cl), _worker_i(worker_i) { } | |
| 1705 | 437 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
438 // Returns true if the given card contains references that point |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
439 // into the collection set, if we're checking for such references; |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
440 // false otherwise. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
441 |
|
17844
8847586c9037
8016302: Change type of the number of GC workers to unsigned int (2)
vkempik
parents:
17757
diff
changeset
|
442 bool G1RemSet::refine_card(jbyte* card_ptr, uint worker_i, |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
443 bool check_for_refs_into_cset) { |
| 20337 | 444 assert(_g1->is_in_exact(_ct_bs->addr_for(card_ptr)), |
| 445 err_msg("Card at "PTR_FORMAT" index "SIZE_FORMAT" representing heap at "PTR_FORMAT" (%u) must be in committed heap", | |
| 446 p2i(card_ptr), | |
| 447 _ct_bs->index_for(_ct_bs->addr_for(card_ptr)), | |
| 448 _ct_bs->addr_for(card_ptr), | |
| 449 _g1->addr_to_region(_ct_bs->addr_for(card_ptr)))); | |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
450 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
451 // If the card is no longer dirty, nothing to do. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
452 if (*card_ptr != CardTableModRefBS::dirty_card_val()) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
453 // No need to return that this card contains refs that point |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
454 // into the collection set. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
455 return false; |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
456 } |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
457 |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
458 // Construct the region representing the card. |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
459 HeapWord* start = _ct_bs->addr_for(card_ptr); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
460 // And find the region containing it. |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
461 HeapRegion* r = _g1->heap_region_containing(start); |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
462 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
463 // Why do we have to check here whether a card is on a young region, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
464 // given that we dirty young regions and, as a result, the |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
465 // post-barrier is supposed to filter them out and never to enqueue |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
466 // them? When we allocate a new region as the "allocation region" we |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
467 // actually dirty its cards after we release the lock, since card |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
468 // dirtying while holding the lock was a performance bottleneck. So, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
469 // as a result, it is possible for other threads to actually |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
470 // allocate objects in the region (after the acquire the lock) |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
471 // before all the cards on the region are dirtied. This is unlikely, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
472 // and it doesn't happen often, but it can happen. So, the extra |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
473 // check below filters out those cards. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
474 if (r->is_young()) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
475 return false; |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
476 } |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
477 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
478 // While we are processing RSet buffers during the collection, we |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
479 // actually don't want to scan any cards on the collection set, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
480 // since we don't want to update remebered sets with entries that |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
481 // point into the collection set, given that live objects from the |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
482 // collection set are about to move and such entries will be stale |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
483 // very soon. This change also deals with a reliability issue which |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
484 // involves scanning a card in the collection set and coming across |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
485 // an array that was being chunked and looking malformed. Note, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
486 // however, that if evacuation fails, we have to scan any objects |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
487 // that were not moved and create any missing entries. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
488 if (r->in_collection_set()) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
489 return false; |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
490 } |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
491 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
492 // The result from the hot card cache insert call is either: |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
493 // * pointer to the current card |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
494 // (implying that the current card is not 'hot'), |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
495 // * null |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
496 // (meaning we had inserted the card ptr into the "hot" card cache, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
497 // which had some headroom), |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
498 // * a pointer to a "hot" card that was evicted from the "hot" cache. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
499 // |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
500 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
501 G1HotCardCache* hot_card_cache = _cg1r->hot_card_cache(); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
502 if (hot_card_cache->use_cache()) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
503 assert(!check_for_refs_into_cset, "sanity"); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
504 assert(!SafepointSynchronize::is_at_safepoint(), "sanity"); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
505 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
506 card_ptr = hot_card_cache->insert(card_ptr); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
507 if (card_ptr == NULL) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
508 // There was no eviction. Nothing to do. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
509 return false; |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
510 } |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
511 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
512 start = _ct_bs->addr_for(card_ptr); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
513 r = _g1->heap_region_containing(start); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
514 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
515 // Checking whether the region we got back from the cache |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
516 // is young here is inappropriate. The region could have been |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
517 // freed, reallocated and tagged as young while in the cache. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
518 // Hence we could see its young type change at any time. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
519 } |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
520 |
|
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
521 // Don't use addr_for(card_ptr + 1) which can ask for |
|
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
522 // a card beyond the heap. This is not safe without a perm |
|
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
523 // gen at the upper end of the heap. |
|
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
524 HeapWord* end = start + CardTableModRefBS::card_size_in_words; |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
525 MemRegion dirtyRegion(start, end); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
526 |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
527 #if CARD_REPEAT_HISTO |
|
2188
c33825b68624
6923430: G1: assert(res != 0,"This should have worked.")
johnc
parents:
1972
diff
changeset
|
528 init_ct_freq_table(_g1->max_capacity()); |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
529 ct_freq_note_card(_ct_bs->index_for(start)); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
530 #endif |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
531 |
|
23220
b554c7fa9478
8067655: Clean up G1 remembered set oop iteration
mgerdin
parents:
20504
diff
changeset
|
532 G1ParPushHeapRSClosure* oops_in_heap_closure = NULL; |
|
4071
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
533 if (check_for_refs_into_cset) { |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
534 // ConcurrentG1RefineThreads have worker numbers larger than what |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
535 // _cset_rs_update_cl[] is set up to handle. But those threads should |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
536 // only be active outside of a collection which means that when they |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
537 // reach here they should have check_for_refs_into_cset == false. |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
538 assert((size_t)worker_i < n_workers(), "index of worker larger than _cset_rs_update_cl[].length"); |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
539 oops_in_heap_closure = _cset_rs_update_cl[worker_i]; |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
540 } |
| 4839 | 541 G1UpdateRSOrPushRefOopClosure update_rs_oop_cl(_g1, |
| 542 _g1->g1_rem_set(), | |
| 543 oops_in_heap_closure, | |
| 544 check_for_refs_into_cset, | |
| 545 worker_i); | |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
546 update_rs_oop_cl.set_from(r); |
| 1705 | 547 |
| 4839 | 548 G1TriggerClosure trigger_cl; |
|
3983
811ec3d0833b
7097053: G1: assert(da ? referent->is_oop() : referent->is_oop_or_null()) failed: referenceProcessor.cpp:1054
johnc
parents:
3979
diff
changeset
|
549 FilterIntoCSClosure into_cs_cl(NULL, _g1, &trigger_cl); |
| 4839 | 550 G1InvokeIfNotTriggeredClosure invoke_cl(&trigger_cl, &into_cs_cl); |
| 551 G1Mux2Closure mux(&invoke_cl, &update_rs_oop_cl); | |
| 1705 | 552 |
| 553 FilterOutOfRegionClosure filter_then_update_rs_oop_cl(r, | |
| 554 (check_for_refs_into_cset ? | |
| 555 (OopClosure*)&mux : | |
| 556 (OopClosure*)&update_rs_oop_cl)); | |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
557 |
|
1666
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
558 // The region for the current card may be a young region. The |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
559 // current card may have been a card that was evicted from the |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
560 // card cache. When the card was inserted into the cache, we had |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
561 // determined that its region was non-young. While in the cache, |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
562 // the region may have been freed during a cleanup pause, reallocated |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
563 // and tagged as young. |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
564 // |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
565 // We wish to filter out cards for such a region but the current |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
566 // thread, if we're running concurrently, may "see" the young type |
|
1666
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
567 // change at any time (so an earlier "is_young" check may pass or |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
568 // fail arbitrarily). We tell the iteration code to perform this |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
569 // filtering when it has been determined that there has been an actual |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
570 // allocation in this region and making it safe to check the young type. |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
571 bool filter_young = true; |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
572 |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
573 HeapWord* stop_point = |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
574 r->oops_on_card_seq_iterate_careful(dirtyRegion, |
|
1666
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
575 &filter_then_update_rs_oop_cl, |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
576 filter_young, |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
577 card_ptr); |
|
1666
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
578 |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
579 // If stop_point is non-null, then we encountered an unallocated region |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
580 // (perhaps the unfilled portion of a TLAB.) For now, we'll dirty the |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
581 // card and re-enqueue: if we put off the card until a GC pause, then the |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
582 // unallocated portion will be filled in. Alternatively, we might try |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
583 // the full complexity of the technique used in "regular" precleaning. |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
584 if (stop_point != NULL) { |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
585 // The card might have gotten re-dirtied and re-enqueued while we |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
586 // worked. (In fact, it's pretty likely.) |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
587 if (*card_ptr != CardTableModRefBS::dirty_card_val()) { |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
588 *card_ptr = CardTableModRefBS::dirty_card_val(); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
589 MutexLockerEx x(Shared_DirtyCardQ_lock, |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
590 Mutex::_no_safepoint_check_flag); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
591 DirtyCardQueue* sdcq = |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
592 JavaThread::dirty_card_queue_set().shared_dirty_card_queue(); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
593 sdcq->enqueue(card_ptr); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
594 } |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
595 } else { |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
596 _conc_refine_cards++; |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
597 } |
| 1705 | 598 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
599 // This gets set to true if the card being refined has |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
600 // references that point into the collection set. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
601 bool has_refs_into_cset = trigger_cl.triggered(); |
| 342 | 602 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
603 // We should only be detecting that the card contains references |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
604 // that point into the collection set if the current thread is |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
605 // a GC worker thread. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
606 assert(!has_refs_into_cset || SafepointSynchronize::is_at_safepoint(), |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
607 "invalid result at non safepoint"); |
| 1705 | 608 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
609 return has_refs_into_cset; |
| 342 | 610 } |
| 611 | |
|
12339
c319b188c7b2
8014078: G1: improve remembered set summary information by providing per region type information
tschatzl
parents:
12080
diff
changeset
|
612 void G1RemSet::print_periodic_summary_info(const char* header) { |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
613 G1RemSetSummary current; |
|
12344
7ec10139bf37
8025441: G1: assert "assert(thread < _num_vtimes) failed: just checking" fails when G1ConcRefinementThreads > ParallelGCThreads
tschatzl
parents:
12343
diff
changeset
|
614 current.initialize(this); |
| 342 | 615 |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
616 _prev_period_summary.subtract_from(¤t); |
|
12339
c319b188c7b2
8014078: G1: improve remembered set summary information by providing per region type information
tschatzl
parents:
12080
diff
changeset
|
617 print_summary_info(&_prev_period_summary, header); |
| 342 | 618 |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
619 _prev_period_summary.set(¤t); |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
620 } |
| 794 | 621 |
| 1861 | 622 void G1RemSet::print_summary_info() { |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
623 G1RemSetSummary current; |
|
12344
7ec10139bf37
8025441: G1: assert "assert(thread < _num_vtimes) failed: just checking" fails when G1ConcRefinementThreads > ParallelGCThreads
tschatzl
parents:
12343
diff
changeset
|
624 current.initialize(this); |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
625 |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
626 print_summary_info(¤t, " Cumulative RS summary"); |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
627 } |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
628 |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
629 void G1RemSet::print_summary_info(G1RemSetSummary * summary, const char * header) { |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
630 assert(summary != NULL, "just checking"); |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
631 |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
632 if (header != NULL) { |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
633 gclog_or_tty->print_cr("%s", header); |
|
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
634 } |
| 342 | 635 |
| 636 #if CARD_REPEAT_HISTO | |
| 637 gclog_or_tty->print_cr("\nG1 card_repeat count histogram: "); | |
| 638 gclog_or_tty->print_cr(" # of repeats --> # of cards with that number."); | |
| 639 card_repeat_count.print_on(gclog_or_tty); | |
| 640 #endif | |
| 641 | |
|
10372
e72f7eecc96d
8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen
tschatzl
parents:
10246
diff
changeset
|
642 summary->print_on(gclog_or_tty); |
| 342 | 643 } |
| 1705 | 644 |
| 1861 | 645 void G1RemSet::prepare_for_verify() { |
|
637
25e146966e7c
6817419: G1: Enable extensive verification for humongous regions
iveresov
parents:
626
diff
changeset
|
646 if (G1HRRSFlushLogBuffersOnVerify && |
|
25e146966e7c
6817419: G1: Enable extensive verification for humongous regions
iveresov
parents:
626
diff
changeset
|
647 (VerifyBeforeGC || VerifyAfterGC) |
|
10373
3a4805ad0005
8015244: G1: Verification after a full GC is incorrectly placed.
johnc
parents:
10372
diff
changeset
|
648 && (!_g1->full_collection() || G1VerifyRSetsDuringFullGC)) { |
| 342 | 649 cleanupHRRS(); |
| 650 _g1->set_refine_cte_cl_concurrency(false); | |
| 651 if (SafepointSynchronize::is_at_safepoint()) { | |
| 652 DirtyCardQueueSet& dcqs = JavaThread::dirty_card_queue_set(); | |
| 653 dcqs.concatenate_logs(); | |
| 654 } | |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
655 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
656 G1HotCardCache* hot_card_cache = _cg1r->hot_card_cache(); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
657 bool use_hot_card_cache = hot_card_cache->use_cache(); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
658 hot_card_cache->set_use_cache(false); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
659 |
| 1705 | 660 DirtyCardQueue into_cset_dcq(&_g1->into_cset_dirty_card_queue_set()); |
| 661 updateRS(&into_cset_dcq, 0); | |
| 662 _g1->into_cset_dirty_card_queue_set().clear(); | |
|
637
25e146966e7c
6817419: G1: Enable extensive verification for humongous regions
iveresov
parents:
626
diff
changeset
|
663 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
664 hot_card_cache->set_use_cache(use_hot_card_cache); |
|
637
25e146966e7c
6817419: G1: Enable extensive verification for humongous regions
iveresov
parents:
626
diff
changeset
|
665 assert(JavaThread::dirty_card_queue_set().completed_buffers_num() == 0, "All should be consumed"); |
| 342 | 666 } |
| 667 } |