Mercurial > hg > graal-jvmci-8

annotate jvmci/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotConstantReflectionProvider.java @ 23325:f895a46e0a45

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
8150850: [JVMCI] NPE when executing HotSpotConstantReflectionProvider.readStableFieldValue Contributed-by: kshefov Reviewed-by: twisti, dnsimon
author Roland Schatz <roland.schatz@oracle.com>
date Tue, 15 Mar 2016 13:00:43 +0300
parents 7b09dede4552
children f102ee538647
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
12429
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
1 /*
21552
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
2 * Copyright (c) 2011, 2015, Oracle and/or its affiliates. All rights reserved.
12429
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
4 *
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
5 * This code is free software; you can redistribute it and/or modify it
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
6 * under the terms of the GNU General Public License version 2 only, as
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
7 * published by the Free Software Foundation.
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
8 *
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
9 * This code is distributed in the hope that it will be useful, but WITHOUT
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
12 * version 2 for more details (a copy is included in the LICENSE file that
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
13 * accompanied this code).
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
14 *
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
15 * You should have received a copy of the GNU General Public License version
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
16 * 2 along with this work; if not, write to the Free Software Foundation,
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
18 *
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
20 * or visit www.oracle.com if you need additional information or have any
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
21 * questions.
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
22 */
22672
1bbd4a7c274b Rename jdk.internal.jvmci to jdk.vm.ci
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 22664
diff changeset
23 package jdk.vm.ci.hotspot;
12429
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
24
22672
1bbd4a7c274b Rename jdk.internal.jvmci to jdk.vm.ci
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 22664
diff changeset
25 import static jdk.vm.ci.hotspot.HotSpotJVMCIRuntimeProvider.getArrayBaseOffset;
1bbd4a7c274b Rename jdk.internal.jvmci to jdk.vm.ci
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 22664
diff changeset
26 import static jdk.vm.ci.hotspot.HotSpotJVMCIRuntimeProvider.getArrayIndexScale;
22555
2fe06375f2d3 made HotSpotJVMCIRuntimeProvider.getArrayBaseOffset and HotSpotJVMCIRuntimeProvider.getArrayIndexScale static
Doug Simon <doug.simon@oracle.com>
parents: 22536
diff changeset
27
2fe06375f2d3 made HotSpotJVMCIRuntimeProvider.getArrayBaseOffset and HotSpotJVMCIRuntimeProvider.getArrayIndexScale static
Doug Simon <doug.simon@oracle.com>
parents: 22536
diff changeset
28 import java.lang.reflect.Array;
12429
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
29
23290
87394b31a42e Move lookup of Java class and hub from ResolvedJavaType to ConstantReflectionProvider
Christian Wimmer <christian.wimmer@oracle.com>
parents: 22760
diff changeset
30 import jdk.vm.ci.common.JVMCIError;
23306
7b09dede4552 JVMCI options should not use System.getProperty() directly (JDK-8146820)
Doug Simon <doug.simon@oracle.com>
parents: 23290
diff changeset
31 import jdk.vm.ci.hotspot.HotSpotJVMCIRuntime.Option;
22672
1bbd4a7c274b Rename jdk.internal.jvmci to jdk.vm.ci
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 22664
diff changeset
32 import jdk.vm.ci.meta.Constant;
1bbd4a7c274b Rename jdk.internal.jvmci to jdk.vm.ci
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 22664
diff changeset
33 import jdk.vm.ci.meta.ConstantReflectionProvider;
1bbd4a7c274b Rename jdk.internal.jvmci to jdk.vm.ci
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 22664
diff changeset
34 import jdk.vm.ci.meta.JavaConstant;
1bbd4a7c274b Rename jdk.internal.jvmci to jdk.vm.ci
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 22664
diff changeset
35 import jdk.vm.ci.meta.JavaKind;
1bbd4a7c274b Rename jdk.internal.jvmci to jdk.vm.ci
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 22664
diff changeset
36 import jdk.vm.ci.meta.JavaType;
1bbd4a7c274b Rename jdk.internal.jvmci to jdk.vm.ci
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 22664
diff changeset
37 import jdk.vm.ci.meta.MemoryAccessProvider;
1bbd4a7c274b Rename jdk.internal.jvmci to jdk.vm.ci
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 22664
diff changeset
38 import jdk.vm.ci.meta.MethodHandleAccessProvider;
22757
f4c4cc22a31c tightened signature of ConstantReflectionProvider methods for reading fields
Doug Simon <doug.simon@oracle.com>
parents: 22672
diff changeset
39 import jdk.vm.ci.meta.ResolvedJavaField;
22672
1bbd4a7c274b Rename jdk.internal.jvmci to jdk.vm.ci
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 22664
diff changeset
40 import jdk.vm.ci.meta.ResolvedJavaType;
12429
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
41
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
42 /**
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
43 * HotSpot implementation of {@link ConstantReflectionProvider}.
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
44 */
18867
7f4cb7587f4c localized replay compilation marker interface to HotSpot specific code
Doug Simon <doug.simon@oracle.com>
parents: 18801
diff changeset
45 public class HotSpotConstantReflectionProvider implements ConstantReflectionProvider, HotSpotProxified {
12429
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
46
21552
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
47 protected final HotSpotJVMCIRuntimeProvider runtime;
18465
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
48 protected final HotSpotMethodHandleAccessProvider methodHandleAccess;
18482
b8a622c3e99f Move raw memory access operations to a separate interface.
Roland Schatz <roland.schatz@oracle.com>
parents: 18472
diff changeset
49 protected final HotSpotMemoryAccessProviderImpl memoryAccess;
12429
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
50
21552
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
51 public HotSpotConstantReflectionProvider(HotSpotJVMCIRuntimeProvider runtime) {
12431
7080a96be216 rename: graalRuntime -> runtime, getGraalRuntime -> getRuntime
Doug Simon <doug.simon@oracle.com>
parents: 12429
diff changeset
52 this.runtime = runtime;
18465
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
53 this.methodHandleAccess = new HotSpotMethodHandleAccessProvider(this);
18482
b8a622c3e99f Move raw memory access operations to a separate interface.
Roland Schatz <roland.schatz@oracle.com>
parents: 18472
diff changeset
54 this.memoryAccess = new HotSpotMemoryAccessProviderImpl(runtime);
18465
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
55 }
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
56
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
57 public MethodHandleAccessProvider getMethodHandleAccess() {
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
58 return methodHandleAccess;
12429
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
59 }
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
60
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
61 @Override
18482
b8a622c3e99f Move raw memory access operations to a separate interface.
Roland Schatz <roland.schatz@oracle.com>
parents: 18472
diff changeset
62 public MemoryAccessProvider getMemoryAccessProvider() {
b8a622c3e99f Move raw memory access operations to a separate interface.
Roland Schatz <roland.schatz@oracle.com>
parents: 18472
diff changeset
63 return memoryAccess;
b8a622c3e99f Move raw memory access operations to a separate interface.
Roland Schatz <roland.schatz@oracle.com>
parents: 18472
diff changeset
64 }
b8a622c3e99f Move raw memory access operations to a separate interface.
Roland Schatz <roland.schatz@oracle.com>
parents: 18472
diff changeset
65
b8a622c3e99f Move raw memory access operations to a separate interface.
Roland Schatz <roland.schatz@oracle.com>
parents: 18472
diff changeset
66 @Override
18188
8652481a1110 Introduce new Constant interface for use in high-level graph.
Roland Schatz <roland.schatz@oracle.com>
parents: 18187
diff changeset
67 public Boolean constantEquals(Constant x, Constant y) {
18471
7b60f8334af0 Compare compressed flag in HotSpotObjectConstantImpl#equals and reference equality in HotSpotConstantReflectionProvider#constantEquals
Andreas Woess <andreas.woess@jku.at>
parents: 18465
diff changeset
68 if (x == y) {
7b60f8334af0 Compare compressed flag in HotSpotObjectConstantImpl#equals and reference equality in HotSpotConstantReflectionProvider#constantEquals
Andreas Woess <andreas.woess@jku.at>
parents: 18465
diff changeset
69 return true;
7b60f8334af0 Compare compressed flag in HotSpotObjectConstantImpl#equals and reference equality in HotSpotConstantReflectionProvider#constantEquals
Andreas Woess <andreas.woess@jku.at>
parents: 18465
diff changeset
70 } else if (x instanceof HotSpotObjectConstantImpl) {
7b60f8334af0 Compare compressed flag in HotSpotObjectConstantImpl#equals and reference equality in HotSpotConstantReflectionProvider#constantEquals
Andreas Woess <andreas.woess@jku.at>
parents: 18465
diff changeset
71 return y instanceof HotSpotObjectConstantImpl && ((HotSpotObjectConstantImpl) x).object() == ((HotSpotObjectConstantImpl) y).object();
7b60f8334af0 Compare compressed flag in HotSpotObjectConstantImpl#equals and reference equality in HotSpotConstantReflectionProvider#constantEquals
Andreas Woess <andreas.woess@jku.at>
parents: 18465
diff changeset
72 } else {
7b60f8334af0 Compare compressed flag in HotSpotObjectConstantImpl#equals and reference equality in HotSpotConstantReflectionProvider#constantEquals
Andreas Woess <andreas.woess@jku.at>
parents: 18465
diff changeset
73 return x.equals(y);
7b60f8334af0 Compare compressed flag in HotSpotObjectConstantImpl#equals and reference equality in HotSpotConstantReflectionProvider#constantEquals
Andreas Woess <andreas.woess@jku.at>
parents: 18465
diff changeset
74 }
12429
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
75 }
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
76
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
77 @Override
18187
9619ba4daf4c Rename Constant to JavaConstant.
Roland Schatz <roland.schatz@oracle.com>
parents: 18176
diff changeset
78 public Integer readArrayLength(JavaConstant array) {
22536
dc1aeef79e7e Refactoring: Rename Kind to JavaKind.
Roland Schatz <roland.schatz@oracle.com>
parents: 22054
diff changeset
79 if (array.getJavaKind() != JavaKind.Object || array.isNull()) {
12429
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
80 return null;
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
81 }
18262
f7d45e2426d4 converted HotSpotObjectConstant to an interface
Doug Simon <doug.simon@oracle.com>
parents: 18223
diff changeset
82
18290
e7d219e9d01f removed HotSpotObjectConstantImpl.asObject()
Doug Simon <doug.simon@oracle.com>
parents: 18266
diff changeset
83 Object arrayObject = ((HotSpotObjectConstantImpl) array).object();
18262
f7d45e2426d4 converted HotSpotObjectConstant to an interface
Doug Simon <doug.simon@oracle.com>
parents: 18223
diff changeset
84 if (!arrayObject.getClass().isArray()) {
f7d45e2426d4 converted HotSpotObjectConstant to an interface
Doug Simon <doug.simon@oracle.com>
parents: 18223
diff changeset
85 return null;
f7d45e2426d4 converted HotSpotObjectConstant to an interface
Doug Simon <doug.simon@oracle.com>
parents: 18223
diff changeset
86 }
f7d45e2426d4 converted HotSpotObjectConstant to an interface
Doug Simon <doug.simon@oracle.com>
parents: 18223
diff changeset
87 return Array.getLength(arrayObject);
12429
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
88 }
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
89
18472
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
90 public JavaConstant readConstantArrayElement(JavaConstant array, int index) {
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
91 if (array instanceof HotSpotObjectConstantImpl && ((HotSpotObjectConstantImpl) array).getStableDimension() > 0) {
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
92 JavaConstant element = readArrayElement(array, index);
18505
3356ea593672 Add missing null check in readConstantArrayElement
Andreas Woess <andreas.woess@jku.at>
parents: 18487
diff changeset
93 if (element != null && (((HotSpotObjectConstantImpl) array).isDefaultStable() || !element.isDefaultForKind())) {
18472
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
94 return element;
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
95 }
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
96 }
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
97 return null;
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
98 }
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
99
21459
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
100 /**
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
101 * Try to convert {@code offset} into an an index into {@code array}.
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
102 *
21643
2081f8f294fe Fixed some javadoc
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21556
diff changeset
103 * @return the computed index or -1 if the offset isn't within the array
21459
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
104 */
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
105 private int indexForOffset(JavaConstant array, long offset) {
22536
dc1aeef79e7e Refactoring: Rename Kind to JavaKind.
Roland Schatz <roland.schatz@oracle.com>
parents: 22054
diff changeset
106 if (array.getJavaKind() != JavaKind.Object || array.isNull()) {
21459
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
107 return -1;
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
108 }
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
109 Class<?> componentType = ((HotSpotObjectConstantImpl) array).object().getClass().getComponentType();
22536
dc1aeef79e7e Refactoring: Rename Kind to JavaKind.
Roland Schatz <roland.schatz@oracle.com>
parents: 22054
diff changeset
110 JavaKind kind = runtime.getHostJVMCIBackend().getMetaAccess().lookupJavaType(componentType).getJavaKind();
22555
2fe06375f2d3 made HotSpotJVMCIRuntimeProvider.getArrayBaseOffset and HotSpotJVMCIRuntimeProvider.getArrayIndexScale static
Doug Simon <doug.simon@oracle.com>
parents: 22536
diff changeset
111 int arraybase = getArrayBaseOffset(kind);
2fe06375f2d3 made HotSpotJVMCIRuntimeProvider.getArrayBaseOffset and HotSpotJVMCIRuntimeProvider.getArrayIndexScale static
Doug Simon <doug.simon@oracle.com>
parents: 22536
diff changeset
112 int scale = getArrayIndexScale(kind);
21459
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
113 if (offset < arraybase) {
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
114 return -1;
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
115 }
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
116 long index = offset - arraybase;
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
117 if (index % scale != 0) {
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
118 return -1;
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
119 }
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
120 long result = index / scale;
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
121 if (result >= Integer.MAX_VALUE) {
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
122 return -1;
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
123 }
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
124 return (int) result;
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
125 }
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
126
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
127 public JavaConstant readConstantArrayElementForOffset(JavaConstant array, long offset) {
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
128 if (array instanceof HotSpotObjectConstantImpl && ((HotSpotObjectConstantImpl) array).getStableDimension() > 0) {
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
129 return readConstantArrayElement(array, indexForOffset(array, offset));
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
130 }
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
131 return null;
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
132 }
f5c2bc68205e support later folding of constant array reads
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 21377
diff changeset
133
15023
652564fe42d5 Use CompressionNode for accessing compressed Klass pointers.
Roland Schatz <roland.schatz@oracle.com>
parents: 15018
diff changeset
134 @Override
18187
9619ba4daf4c Rename Constant to JavaConstant.
Roland Schatz <roland.schatz@oracle.com>
parents: 18176
diff changeset
135 public JavaConstant readArrayElement(JavaConstant array, int index) {
22536
dc1aeef79e7e Refactoring: Rename Kind to JavaKind.
Roland Schatz <roland.schatz@oracle.com>
parents: 22054
diff changeset
136 if (array.getJavaKind() != JavaKind.Object || array.isNull()) {
15018
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
137 return null;
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
138 }
18290
e7d219e9d01f removed HotSpotObjectConstantImpl.asObject()
Doug Simon <doug.simon@oracle.com>
parents: 18266
diff changeset
139 Object a = ((HotSpotObjectConstantImpl) array).object();
15018
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
140
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
141 if (index < 0 || index >= Array.getLength(a)) {
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
142 return null;
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
143 }
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
144
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
145 if (a instanceof Object[]) {
18472
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
146 Object element = ((Object[]) a)[index];
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
147 if (((HotSpotObjectConstantImpl) array).getStableDimension() > 1) {
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
148 return HotSpotObjectConstantImpl.forStableArray(element, ((HotSpotObjectConstantImpl) array).getStableDimension() - 1, ((HotSpotObjectConstantImpl) array).isDefaultStable());
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
149 } else {
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
150 return HotSpotObjectConstantImpl.forObject(element);
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
151 }
15018
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
152 } else {
18187
9619ba4daf4c Rename Constant to JavaConstant.
Roland Schatz <roland.schatz@oracle.com>
parents: 18176
diff changeset
153 return JavaConstant.forBoxedPrimitive(Array.get(a, index));
15018
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
154 }
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
155 }
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
156
18801
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
157 /**
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
158 * Check if the constant is a boxed value that is guaranteed to be cached by the platform.
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
159 * Otherwise the generated code might be the only reference to the boxed value and since object
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
160 * references from nmethods are weak this can cause GC problems.
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
161 *
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
162 * @param source
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
163 * @return true if the box is cached
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
164 */
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
165 private static boolean isBoxCached(JavaConstant source) {
22536
dc1aeef79e7e Refactoring: Rename Kind to JavaKind.
Roland Schatz <roland.schatz@oracle.com>
parents: 22054
diff changeset
166 switch (source.getJavaKind()) {
18801
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
167 case Boolean:
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
168 return true;
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
169 case Char:
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
170 return source.asInt() <= 127;
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
171 case Byte:
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
172 case Short:
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
173 case Int:
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
174 return source.asInt() >= -128 && source.asInt() <= 127;
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
175 case Long:
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
176 return source.asLong() >= -128 && source.asLong() <= 127;
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
177 case Float:
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
178 case Double:
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
179 return false;
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
180 default:
22536
dc1aeef79e7e Refactoring: Rename Kind to JavaKind.
Roland Schatz <roland.schatz@oracle.com>
parents: 22054
diff changeset
181 throw new IllegalArgumentException("unexpected kind " + source.getJavaKind());
18801
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
182 }
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
183 }
95249d5e794f Only embed boxed primitives when the box is cached by the JDK
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 18686
diff changeset
184
15018
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
185 @Override
18187
9619ba4daf4c Rename Constant to JavaConstant.
Roland Schatz <roland.schatz@oracle.com>
parents: 18176
diff changeset
186 public JavaConstant boxPrimitive(JavaConstant source) {
22536
dc1aeef79e7e Refactoring: Rename Kind to JavaKind.
Roland Schatz <roland.schatz@oracle.com>
parents: 22054
diff changeset
187 if (!source.getJavaKind().isPrimitive() || !isBoxCached(source)) {
15018
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
188 return null;
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
189 }
18262
f7d45e2426d4 converted HotSpotObjectConstant to an interface
Doug Simon <doug.simon@oracle.com>
parents: 18223
diff changeset
190 return HotSpotObjectConstantImpl.forObject(source.asBoxedPrimitive());
15018
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
191 }
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
192
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
193 @Override
18187
9619ba4daf4c Rename Constant to JavaConstant.
Roland Schatz <roland.schatz@oracle.com>
parents: 18176
diff changeset
194 public JavaConstant unboxPrimitive(JavaConstant source) {
22536
dc1aeef79e7e Refactoring: Rename Kind to JavaKind.
Roland Schatz <roland.schatz@oracle.com>
parents: 22054
diff changeset
195 if (!source.getJavaKind().isObject()) {
15018
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
196 return null;
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
197 }
18293
ab8fbaa5e72f fixed minor regressions after removing HotSpotObjectConstantImpl.asObject()
Doug Simon <doug.simon@oracle.com>
parents: 18290
diff changeset
198 if (source.isNull()) {
ab8fbaa5e72f fixed minor regressions after removing HotSpotObjectConstantImpl.asObject()
Doug Simon <doug.simon@oracle.com>
parents: 18290
diff changeset
199 return null;
ab8fbaa5e72f fixed minor regressions after removing HotSpotObjectConstantImpl.asObject()
Doug Simon <doug.simon@oracle.com>
parents: 18290
diff changeset
200 }
18290
e7d219e9d01f removed HotSpotObjectConstantImpl.asObject()
Doug Simon <doug.simon@oracle.com>
parents: 18266
diff changeset
201 return JavaConstant.forBoxedPrimitive(((HotSpotObjectConstantImpl) source).object());
15018
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
202 }
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
203
18295
17bf458cf86e reduced use of HotSpotObjectConstantImpl.forObject
Doug Simon <doug.simon@oracle.com>
parents: 18293
diff changeset
204 public JavaConstant forString(String value) {
17bf458cf86e reduced use of HotSpotObjectConstantImpl.forObject
Doug Simon <doug.simon@oracle.com>
parents: 18293
diff changeset
205 return HotSpotObjectConstantImpl.forObject(value);
17bf458cf86e reduced use of HotSpotObjectConstantImpl.forObject
Doug Simon <doug.simon@oracle.com>
parents: 18293
diff changeset
206 }
17bf458cf86e reduced use of HotSpotObjectConstantImpl.forObject
Doug Simon <doug.simon@oracle.com>
parents: 18293
diff changeset
207
22645
c33f0cb02b34 Add ConstantReflectionProvider.forObject method and make HotSpotObjectConstantImpl package-private.
Roland Schatz <roland.schatz@oracle.com>
parents: 22590
diff changeset
208 public JavaConstant forObject(Object value) {
c33f0cb02b34 Add ConstantReflectionProvider.forObject method and make HotSpotObjectConstantImpl package-private.
Roland Schatz <roland.schatz@oracle.com>
parents: 22590
diff changeset
209 return HotSpotObjectConstantImpl.forObject(value);
c33f0cb02b34 Add ConstantReflectionProvider.forObject method and make HotSpotObjectConstantImpl package-private.
Roland Schatz <roland.schatz@oracle.com>
parents: 22590
diff changeset
210 }
c33f0cb02b34 Add ConstantReflectionProvider.forObject method and make HotSpotObjectConstantImpl package-private.
Roland Schatz <roland.schatz@oracle.com>
parents: 22590
diff changeset
211
15018
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
212 @Override
18487
0f4813e0b4a9 Use asConstant() instead of asJavaConstant() where possible.
Roland Schatz <roland.schatz@oracle.com>
parents: 18482
diff changeset
213 public ResolvedJavaType asJavaType(Constant constant) {
15909
e43591136d9f Support for compressed constants.
Roland Schatz <roland.schatz@oracle.com>
parents: 15291
diff changeset
214 if (constant instanceof HotSpotObjectConstant) {
18290
e7d219e9d01f removed HotSpotObjectConstantImpl.asObject()
Doug Simon <doug.simon@oracle.com>
parents: 18266
diff changeset
215 Object obj = ((HotSpotObjectConstantImpl) constant).object();
15018
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
216 if (obj instanceof Class) {
21552
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
217 return runtime.getHostJVMCIBackend().getMetaAccess().lookupJavaType((Class<?>) obj);
15018
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
218 }
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
219 }
16183
b1be2a46cc5c canonicalize LoadMethodNodes
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 15909
diff changeset
220 if (constant instanceof HotSpotMetaspaceConstant) {
22590
3f6488b29c1a Remove rawValue from HotSpotMetaspaceConstantImpl, patch raw pointer at code installation time.
Roland Schatz <roland.schatz@oracle.com>
parents: 22555
diff changeset
221 MetaspaceWrapperObject obj = HotSpotMetaspaceConstantImpl.getMetaspaceObject(constant);
18223
17c98fad6980 converted HotSpotResolvedObjectType to an interface
Doug Simon <doug.simon@oracle.com>
parents: 18188
diff changeset
222 if (obj instanceof HotSpotResolvedObjectTypeImpl) {
16183
b1be2a46cc5c canonicalize LoadMethodNodes
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 15909
diff changeset
223 return (ResolvedJavaType) obj;
b1be2a46cc5c canonicalize LoadMethodNodes
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 15909
diff changeset
224 }
b1be2a46cc5c canonicalize LoadMethodNodes
Tom Rodriguez <tom.rodriguez@oracle.com>
parents: 15909
diff changeset
225 }
15018
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
226 return null;
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 13488
diff changeset
227 }
18465
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
228
21552
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
229 private static final String SystemClassName = "Ljava/lang/System;";
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
230
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
231 /**
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
232 * Determines if a static field is constant for the purpose of
22757
f4c4cc22a31c tightened signature of ConstantReflectionProvider methods for reading fields
Doug Simon <doug.simon@oracle.com>
parents: 22672
diff changeset
233 * {@link #readConstantFieldValue(ResolvedJavaField, JavaConstant)}.
21552
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
234 */
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
235 protected boolean isStaticFieldConstant(HotSpotResolvedJavaField staticField) {
22760
4cf1946f59fc must not fold accesses to @Stable fields if -XX:-FoldStableValues (GRAAL-58)
Doug Simon <doug.simon@oracle.com>
parents: 22758
diff changeset
236 if (staticField.isFinal() || (staticField.isStable() && runtime.getConfig().foldStableValues)) {
21552
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
237 ResolvedJavaType holder = staticField.getDeclaringClass();
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
238 if (holder.isInitialized() && !holder.getName().equals(SystemClassName)) {
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
239 return true;
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
240 }
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
241 }
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
242 return false;
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
243 }
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
244
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
245 /**
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
246 * Determines if a value read from a {@code final} instance field is considered constant. The
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
247 * implementation in {@link HotSpotConstantReflectionProvider} returns true if {@code value} is
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
248 * not the {@link JavaConstant#isDefaultForKind default value} for its kind or if
23306
7b09dede4552 JVMCI options should not use System.getProperty() directly (JDK-8146820)
Doug Simon <doug.simon@oracle.com>
parents: 23290
diff changeset
249 * {@link Option#TrustFinalDefaultFields} is true.
21552
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
250 *
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
251 * @param value a value read from a {@code final} instance field
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
252 * @param receiverClass the {@link Object#getClass() class} of object from which the
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
253 * {@code value} was read
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
254 */
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
255 protected boolean isFinalInstanceFieldValueConstant(JavaConstant value, Class<?> receiverClass) {
23306
7b09dede4552 JVMCI options should not use System.getProperty() directly (JDK-8146820)
Doug Simon <doug.simon@oracle.com>
parents: 23290
diff changeset
256 return !value.isDefaultForKind() || Option.TrustFinalDefaultFields.getBoolean();
21552
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
257 }
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
258
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
259 /**
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
260 * Determines if a value read from a {@link Stable} instance field is considered constant. The
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
261 * implementation in {@link HotSpotConstantReflectionProvider} returns true if {@code value} is
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
262 * not the {@link JavaConstant#isDefaultForKind default value} for its kind.
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
263 *
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
264 * @param value a value read from a {@link Stable} field
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
265 * @param receiverClass the {@link Object#getClass() class} of object from which the
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
266 * {@code value} was read
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
267 */
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
268 protected boolean isStableInstanceFieldValueConstant(JavaConstant value, Class<?> receiverClass) {
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
269 return !value.isDefaultForKind();
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
270 }
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
271
22757
f4c4cc22a31c tightened signature of ConstantReflectionProvider methods for reading fields
Doug Simon <doug.simon@oracle.com>
parents: 22672
diff changeset
272 public JavaConstant readConstantFieldValue(ResolvedJavaField field, JavaConstant receiver) {
18465
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
273 HotSpotResolvedJavaField hotspotField = (HotSpotResolvedJavaField) field;
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
274
21377
6f2ff1bccbf1 Adhere to specification described in JavaDoc of interface
Christian Wimmer <christian.wimmer@oracle.com>
parents: 21290
diff changeset
275 if (hotspotField.isStatic()) {
21552
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
276 if (isStaticFieldConstant(hotspotField)) {
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
277 JavaConstant value = readFieldValue(field, receiver);
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
278 if (hotspotField.isFinal() || !value.isDefaultForKind()) {
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
279 return value;
18465
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
280 }
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
281 }
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
282 } else {
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
283 /*
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
284 * for non-static final fields, we must assume that they are only initialized if they
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
285 * have a non-default value.
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
286 */
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
287 Object object = receiver.isNull() ? null : ((HotSpotObjectConstantImpl) receiver).object();
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
288
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
289 // Canonicalization may attempt to process an unsafe read before
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
290 // processing a guard (e.g. a null check or a type check) for this read
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
291 // so we need to check the object being read
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
292 if (object != null) {
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
293 if (hotspotField.isFinal()) {
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
294 if (hotspotField.isInObject(object)) {
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
295 JavaConstant value = readFieldValue(field, receiver);
21552
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
296 if (isFinalInstanceFieldValueConstant(value, object.getClass())) {
18465
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
297 return value;
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
298 }
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
299 }
22760
4cf1946f59fc must not fold accesses to @Stable fields if -XX:-FoldStableValues (GRAAL-58)
Doug Simon <doug.simon@oracle.com>
parents: 22758
diff changeset
300 } else if (hotspotField.isStable() && runtime.getConfig().foldStableValues) {
18465
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
301 if (hotspotField.isInObject(object)) {
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
302 JavaConstant value = readFieldValue(field, receiver);
21552
9579a3c62a9e use skeleton findbugs jar containing only SuppresFBWarnings to avoid external dependency for JVMCI classes (JBS:GRAAL-53)
Doug Simon <doug.simon@oracle.com>
parents: 21459
diff changeset
303 if (isStableInstanceFieldValueConstant(value, object.getClass())) {
18465
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
304 return value;
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
305 }
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
306 }
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
307 }
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
308 }
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
309 }
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
310 return null;
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
311 }
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
312
22757
f4c4cc22a31c tightened signature of ConstantReflectionProvider methods for reading fields
Doug Simon <doug.simon@oracle.com>
parents: 22672
diff changeset
313 public JavaConstant readFieldValue(ResolvedJavaField field, JavaConstant receiver) {
18465
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
314 HotSpotResolvedJavaField hotspotField = (HotSpotResolvedJavaField) field;
18472
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
315 if (!hotspotField.isStable()) {
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
316 return readNonStableFieldValue(field, receiver);
22760
4cf1946f59fc must not fold accesses to @Stable fields if -XX:-FoldStableValues (GRAAL-58)
Doug Simon <doug.simon@oracle.com>
parents: 22758
diff changeset
317 } else if (runtime.getConfig().foldStableValues) {
4cf1946f59fc must not fold accesses to @Stable fields if -XX:-FoldStableValues (GRAAL-58)
Doug Simon <doug.simon@oracle.com>
parents: 22758
diff changeset
318 return readStableFieldValue(field, receiver, hotspotField.isDefaultStable());
18472
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
319 } else {
22760
4cf1946f59fc must not fold accesses to @Stable fields if -XX:-FoldStableValues (GRAAL-58)
Doug Simon <doug.simon@oracle.com>
parents: 22758
diff changeset
320 return null;
18472
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
321 }
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
322 }
18465
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
323
22758
a130b51efb07 removed @Option mechanism from JVMCI (GRAAL-1371)
Doug Simon <doug.simon@oracle.com>
parents: 22757
diff changeset
324 private JavaConstant readNonStableFieldValue(ResolvedJavaField field, JavaConstant receiver) {
18472
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
325 HotSpotResolvedJavaField hotspotField = (HotSpotResolvedJavaField) field;
21377
6f2ff1bccbf1 Adhere to specification described in JavaDoc of interface
Christian Wimmer <christian.wimmer@oracle.com>
parents: 21290
diff changeset
326 if (hotspotField.isStatic()) {
18465
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
327 HotSpotResolvedJavaType holder = (HotSpotResolvedJavaType) hotspotField.getDeclaringClass();
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
328 if (holder.isInitialized()) {
22536
dc1aeef79e7e Refactoring: Rename Kind to JavaKind.
Roland Schatz <roland.schatz@oracle.com>
parents: 22054
diff changeset
329 return memoryAccess.readUnsafeConstant(hotspotField.getJavaKind(), HotSpotObjectConstantImpl.forObject(holder.mirror()), hotspotField.offset());
18465
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
330 }
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
331 } else {
21377
6f2ff1bccbf1 Adhere to specification described in JavaDoc of interface
Christian Wimmer <christian.wimmer@oracle.com>
parents: 21290
diff changeset
332 if (receiver.isNonNull() && hotspotField.isInObject(((HotSpotObjectConstantImpl) receiver).object())) {
22536
dc1aeef79e7e Refactoring: Rename Kind to JavaKind.
Roland Schatz <roland.schatz@oracle.com>
parents: 22054
diff changeset
333 return memoryAccess.readUnsafeConstant(hotspotField.getJavaKind(), receiver, hotspotField.offset());
21377
6f2ff1bccbf1 Adhere to specification described in JavaDoc of interface
Christian Wimmer <christian.wimmer@oracle.com>
parents: 21290
diff changeset
334 }
18465
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
335 }
21377
6f2ff1bccbf1 Adhere to specification described in JavaDoc of interface
Christian Wimmer <christian.wimmer@oracle.com>
parents: 21290
diff changeset
336 return null;
18465
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
337 }
f0a8b72315c1 Move ResolvedJavaField#read[Constant]Value and getMethodHandleAccess() to ConstantReflectionProvider
Andreas Woess <andreas.woess@jku.at>
parents: 18362
diff changeset
338
22757
f4c4cc22a31c tightened signature of ConstantReflectionProvider methods for reading fields
Doug Simon <doug.simon@oracle.com>
parents: 22672
diff changeset
339 public JavaConstant readStableFieldValue(ResolvedJavaField field, JavaConstant receiver, boolean isDefaultStable) {
18472
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
340 JavaConstant fieldValue = readNonStableFieldValue(field, receiver);
23325
f895a46e0a45 8150850: [JVMCI] NPE when executing HotSpotConstantReflectionProvider.readStableFieldValue
Roland Schatz <roland.schatz@oracle.com>
parents: 23306
diff changeset
341 if (fieldValue != null && fieldValue.isNonNull()) {
18564
966081b8e830 guard against null element in HotSpotConstantReflectionProvider.readStableFieldValue
Doug Simon <doug.simon@oracle.com>
parents: 18530
diff changeset
342 JavaType declaredType = field.getType();
966081b8e830 guard against null element in HotSpotConstantReflectionProvider.readStableFieldValue
Doug Simon <doug.simon@oracle.com>
parents: 18530
diff changeset
343 if (declaredType.getComponentType() != null) {
966081b8e830 guard against null element in HotSpotConstantReflectionProvider.readStableFieldValue
Doug Simon <doug.simon@oracle.com>
parents: 18530
diff changeset
344 int stableDimension = getArrayDimension(declaredType);
966081b8e830 guard against null element in HotSpotConstantReflectionProvider.readStableFieldValue
Doug Simon <doug.simon@oracle.com>
parents: 18530
diff changeset
345 return HotSpotObjectConstantImpl.forStableArray(((HotSpotObjectConstantImpl) fieldValue).object(), stableDimension, isDefaultStable);
966081b8e830 guard against null element in HotSpotConstantReflectionProvider.readStableFieldValue
Doug Simon <doug.simon@oracle.com>
parents: 18530
diff changeset
346 }
18472
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
347 }
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
348 return fieldValue;
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
349 }
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
350
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
351 private static int getArrayDimension(JavaType type) {
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
352 int dimensions = 0;
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
353 JavaType componentType = type;
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
354 while ((componentType = componentType.getComponentType()) != null) {
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
355 dimensions++;
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
356 }
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
357 return dimensions;
de179c27cad3 Add support for stable array constants
Andreas Woess <andreas.woess@jku.at>
parents: 18471
diff changeset
358 }
23290
87394b31a42e Move lookup of Java class and hub from ResolvedJavaType to ConstantReflectionProvider
Christian Wimmer <christian.wimmer@oracle.com>
parents: 22760
diff changeset
359
87394b31a42e Move lookup of Java class and hub from ResolvedJavaType to ConstantReflectionProvider
Christian Wimmer <christian.wimmer@oracle.com>
parents: 22760
diff changeset
360 @Override
87394b31a42e Move lookup of Java class and hub from ResolvedJavaType to ConstantReflectionProvider
Christian Wimmer <christian.wimmer@oracle.com>
parents: 22760
diff changeset
361 public JavaConstant asJavaClass(ResolvedJavaType type) {
87394b31a42e Move lookup of Java class and hub from ResolvedJavaType to ConstantReflectionProvider
Christian Wimmer <christian.wimmer@oracle.com>
parents: 22760
diff changeset
362 return HotSpotObjectConstantImpl.forObject(((HotSpotResolvedJavaType) type).mirror());
87394b31a42e Move lookup of Java class and hub from ResolvedJavaType to ConstantReflectionProvider
Christian Wimmer <christian.wimmer@oracle.com>
parents: 22760
diff changeset
363 }
87394b31a42e Move lookup of Java class and hub from ResolvedJavaType to ConstantReflectionProvider
Christian Wimmer <christian.wimmer@oracle.com>
parents: 22760
diff changeset
364
87394b31a42e Move lookup of Java class and hub from ResolvedJavaType to ConstantReflectionProvider
Christian Wimmer <christian.wimmer@oracle.com>
parents: 22760
diff changeset
365 @Override
87394b31a42e Move lookup of Java class and hub from ResolvedJavaType to ConstantReflectionProvider
Christian Wimmer <christian.wimmer@oracle.com>
parents: 22760
diff changeset
366 public Constant asObjectHub(ResolvedJavaType type) {
87394b31a42e Move lookup of Java class and hub from ResolvedJavaType to ConstantReflectionProvider
Christian Wimmer <christian.wimmer@oracle.com>
parents: 22760
diff changeset
367 if (type instanceof HotSpotResolvedObjectType) {
87394b31a42e Move lookup of Java class and hub from ResolvedJavaType to ConstantReflectionProvider
Christian Wimmer <christian.wimmer@oracle.com>
parents: 22760
diff changeset
368 return ((HotSpotResolvedObjectType) type).klass();
87394b31a42e Move lookup of Java class and hub from ResolvedJavaType to ConstantReflectionProvider
Christian Wimmer <christian.wimmer@oracle.com>
parents: 22760
diff changeset
369 } else {
87394b31a42e Move lookup of Java class and hub from ResolvedJavaType to ConstantReflectionProvider
Christian Wimmer <christian.wimmer@oracle.com>
parents: 22760
diff changeset
370 throw JVMCIError.unimplemented();
87394b31a42e Move lookup of Java class and hub from ResolvedJavaType to ConstantReflectionProvider
Christian Wimmer <christian.wimmer@oracle.com>
parents: 22760
diff changeset
371 }
87394b31a42e Move lookup of Java class and hub from ResolvedJavaType to ConstantReflectionProvider
Christian Wimmer <christian.wimmer@oracle.com>
parents: 22760
diff changeset
372 }
12429
5124eeec1a7b split HotSpotRuntime into separate provider implementations
Doug Simon <doug.simon@oracle.com>
parents:
diff changeset
373 }