Mercurial > hg > truffle
annotate src/share/vm/opto/loopopts.cpp @ 17726:085b304a1cc5
8027754: Enable loop optimizations for loops with MathExact inside
Reviewed-by: kvn, iveresov
| author | rbackman |
|---|---|
| date | Thu, 23 Jan 2014 12:08:28 +0100 |
| parents | de95063c0e34 |
| children | 4ca6dc0799b6 cd3c534f8f4a |
| rev | line source |
|---|---|
| 0 | 1 /* |
|
17467
55fb97c4c58d
8029233: Update copyright year to match last edit in jdk8 hotspot repository for 2013
mikael
parents:
13076
diff
changeset
|
2 * Copyright (c) 1999, 2013, Oracle and/or its affiliates. All rights reserved. |
| 0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1254
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1254
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1254
diff
changeset
|
21 * questions. |
| 0 | 22 * |
| 23 */ | |
| 24 | |
| 1972 | 25 #include "precompiled.hpp" |
| 26 #include "memory/allocation.inline.hpp" | |
| 27 #include "opto/addnode.hpp" | |
| 28 #include "opto/connode.hpp" | |
| 29 #include "opto/divnode.hpp" | |
| 30 #include "opto/loopnode.hpp" | |
| 4047 | 31 #include "opto/matcher.hpp" |
| 1972 | 32 #include "opto/mulnode.hpp" |
| 33 #include "opto/rootnode.hpp" | |
| 34 #include "opto/subnode.hpp" | |
| 0 | 35 |
| 36 //============================================================================= | |
| 37 //------------------------------split_thru_phi--------------------------------- | |
| 38 // Split Node 'n' through merge point if there is enough win. | |
| 39 Node *PhaseIdealLoop::split_thru_phi( Node *n, Node *region, int policy ) { | |
| 69 | 40 if (n->Opcode() == Op_ConvI2L && n->bottom_type() != TypeLong::LONG) { |
| 41 // ConvI2L may have type information on it which is unsafe to push up | |
| 42 // so disable this for now | |
| 43 return NULL; | |
| 44 } | |
|
13076
f675976a61e7
8028198: SIGSEGV in PhaseIdealLoop::build_loop_late_post
rbackman
parents:
12956
diff
changeset
|
45 |
| 0 | 46 int wins = 0; |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
47 assert(!n->is_CFG(), ""); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
48 assert(region->is_Region(), ""); |
|
64
b8f5ba577b02
6673473: (Escape Analysis) Add the instance's field information to PhiNode
kvn
parents:
35
diff
changeset
|
49 |
|
b8f5ba577b02
6673473: (Escape Analysis) Add the instance's field information to PhiNode
kvn
parents:
35
diff
changeset
|
50 const Type* type = n->bottom_type(); |
|
b8f5ba577b02
6673473: (Escape Analysis) Add the instance's field information to PhiNode
kvn
parents:
35
diff
changeset
|
51 const TypeOopPtr *t_oop = _igvn.type(n)->isa_oopptr(); |
|
b8f5ba577b02
6673473: (Escape Analysis) Add the instance's field information to PhiNode
kvn
parents:
35
diff
changeset
|
52 Node *phi; |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
53 if (t_oop != NULL && t_oop->is_known_instance_field()) { |
|
64
b8f5ba577b02
6673473: (Escape Analysis) Add the instance's field information to PhiNode
kvn
parents:
35
diff
changeset
|
54 int iid = t_oop->instance_id(); |
|
b8f5ba577b02
6673473: (Escape Analysis) Add the instance's field information to PhiNode
kvn
parents:
35
diff
changeset
|
55 int index = C->get_alias_index(t_oop); |
|
b8f5ba577b02
6673473: (Escape Analysis) Add the instance's field information to PhiNode
kvn
parents:
35
diff
changeset
|
56 int offset = t_oop->offset(); |
|
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
57 phi = new (C) PhiNode(region, type, NULL, iid, index, offset); |
|
64
b8f5ba577b02
6673473: (Escape Analysis) Add the instance's field information to PhiNode
kvn
parents:
35
diff
changeset
|
58 } else { |
|
1254
4ee1c645110e
6924097: assert((_type == Type::MEMORY) == (_adr_type != 0),"adr_type for memory phis only")
kvn
parents:
866
diff
changeset
|
59 phi = PhiNode::make_blank(region, n); |
|
64
b8f5ba577b02
6673473: (Escape Analysis) Add the instance's field information to PhiNode
kvn
parents:
35
diff
changeset
|
60 } |
| 0 | 61 uint old_unique = C->unique(); |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
62 for (uint i = 1; i < region->req(); i++) { |
| 0 | 63 Node *x; |
| 64 Node* the_clone = NULL; | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
65 if (region->in(i) == C->top()) { |
| 0 | 66 x = C->top(); // Dead path? Use a dead data op |
| 67 } else { | |
| 68 x = n->clone(); // Else clone up the data op | |
| 69 the_clone = x; // Remember for possible deletion. | |
| 70 // Alter data node to use pre-phi inputs | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
71 if (n->in(0) == region) |
| 0 | 72 x->set_req( 0, region->in(i) ); |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
73 for (uint j = 1; j < n->req(); j++) { |
| 0 | 74 Node *in = n->in(j); |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
75 if (in->is_Phi() && in->in(0) == region) |
| 0 | 76 x->set_req( j, in->in(i) ); // Use pre-Phi input for the clone |
| 77 } | |
| 78 } | |
| 79 // Check for a 'win' on some paths | |
| 80 const Type *t = x->Value(&_igvn); | |
| 81 | |
| 82 bool singleton = t->singleton(); | |
| 83 | |
| 84 // A TOP singleton indicates that there are no possible values incoming | |
| 85 // along a particular edge. In most cases, this is OK, and the Phi will | |
| 86 // be eliminated later in an Ideal call. However, we can't allow this to | |
| 87 // happen if the singleton occurs on loop entry, as the elimination of | |
| 88 // the PhiNode may cause the resulting node to migrate back to a previous | |
| 89 // loop iteration. | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
90 if (singleton && t == Type::TOP) { |
| 0 | 91 // Is_Loop() == false does not confirm the absence of a loop (e.g., an |
| 92 // irreducible loop may not be indicated by an affirmative is_Loop()); | |
| 93 // therefore, the only top we can split thru a phi is on a backedge of | |
| 94 // a loop. | |
| 95 singleton &= region->is_Loop() && (i != LoopNode::EntryControl); | |
| 96 } | |
| 97 | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
98 if (singleton) { |
| 0 | 99 wins++; |
| 100 x = ((PhaseGVN&)_igvn).makecon(t); | |
| 101 } else { | |
| 102 // We now call Identity to try to simplify the cloned node. | |
| 103 // Note that some Identity methods call phase->type(this). | |
| 104 // Make sure that the type array is big enough for | |
| 105 // our new node, even though we may throw the node away. | |
| 106 // (Note: This tweaking with igvn only works because x is a new node.) | |
| 107 _igvn.set_type(x, t); | |
|
293
c3e045194476
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
253
diff
changeset
|
108 // If x is a TypeNode, capture any more-precise type permanently into Node |
| 605 | 109 // otherwise it will be not updated during igvn->transform since |
|
293
c3e045194476
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
253
diff
changeset
|
110 // igvn->type(x) is set to x->Value() already. |
|
c3e045194476
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
253
diff
changeset
|
111 x->raise_bottom_type(t); |
| 0 | 112 Node *y = x->Identity(&_igvn); |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
113 if (y != x) { |
| 0 | 114 wins++; |
| 115 x = y; | |
| 116 } else { | |
| 117 y = _igvn.hash_find(x); | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
118 if (y) { |
| 0 | 119 wins++; |
| 120 x = y; | |
| 121 } else { | |
| 122 // Else x is a new node we are keeping | |
| 123 // We do not need register_new_node_with_optimizer | |
| 124 // because set_type has already been called. | |
| 125 _igvn._worklist.push(x); | |
| 126 } | |
| 127 } | |
| 128 } | |
| 129 if (x != the_clone && the_clone != NULL) | |
| 130 _igvn.remove_dead_node(the_clone); | |
| 131 phi->set_req( i, x ); | |
| 132 } | |
| 133 // Too few wins? | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
134 if (wins <= policy) { |
| 0 | 135 _igvn.remove_dead_node(phi); |
| 136 return NULL; | |
| 137 } | |
| 138 | |
| 139 // Record Phi | |
| 140 register_new_node( phi, region ); | |
| 141 | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
142 for (uint i2 = 1; i2 < phi->req(); i2++) { |
| 0 | 143 Node *x = phi->in(i2); |
| 144 // If we commoned up the cloned 'x' with another existing Node, | |
| 145 // the existing Node picks up a new use. We need to make the | |
| 146 // existing Node occur higher up so it dominates its uses. | |
| 147 Node *old_ctrl; | |
| 148 IdealLoopTree *old_loop; | |
| 149 | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
150 if (x->is_Con()) { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
151 // Constant's control is always root. |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
152 set_ctrl(x, C->root()); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
153 continue; |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
154 } |
| 0 | 155 // The occasional new node |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
156 if (x->_idx >= old_unique) { // Found a new, unplaced node? |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
157 old_ctrl = NULL; |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
158 old_loop = NULL; // Not in any prior loop |
| 0 | 159 } else { |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
160 old_ctrl = get_ctrl(x); |
| 0 | 161 old_loop = get_loop(old_ctrl); // Get prior loop |
| 162 } | |
| 163 // New late point must dominate new use | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
164 Node *new_ctrl = dom_lca(old_ctrl, region->in(i2)); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
165 if (new_ctrl == old_ctrl) // Nothing is changed |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
166 continue; |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
167 |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
168 IdealLoopTree *new_loop = get_loop(new_ctrl); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
169 |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
170 // Don't move x into a loop if its uses are |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
171 // outside of loop. Otherwise x will be cloned |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
172 // for each use outside of this loop. |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
173 IdealLoopTree *use_loop = get_loop(region); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
174 if (!new_loop->is_member(use_loop) && |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
175 (old_loop == NULL || !new_loop->is_member(old_loop))) { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
176 // Take early control, later control will be recalculated |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
177 // during next iteration of loop optimizations. |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
178 new_ctrl = get_early_ctrl(x); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
179 new_loop = get_loop(new_ctrl); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
180 } |
| 0 | 181 // Set new location |
| 182 set_ctrl(x, new_ctrl); | |
| 183 // If changing loop bodies, see if we need to collect into new body | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
184 if (old_loop != new_loop) { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
185 if (old_loop && !old_loop->_child) |
| 0 | 186 old_loop->_body.yank(x); |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
187 if (!new_loop->_child) |
| 0 | 188 new_loop->_body.push(x); // Collect body info |
| 189 } | |
| 190 } | |
| 191 | |
| 192 return phi; | |
| 193 } | |
| 194 | |
| 195 //------------------------------dominated_by------------------------------------ | |
| 196 // Replace the dominated test with an obvious true or false. Place it on the | |
| 197 // IGVN worklist for later cleanup. Move control-dependent data Nodes on the | |
| 198 // live path up to the dominating control. | |
|
3840
4e761e7e6e12
7070134: Hotspot crashes with sigsegv from PorterStemmer
kvn
parents:
3281
diff
changeset
|
199 void PhaseIdealLoop::dominated_by( Node *prevdom, Node *iff, bool flip, bool exclude_loop_predicate ) { |
| 0 | 200 #ifndef PRODUCT |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
201 if (VerifyLoopOptimizations && PrintOpto) tty->print_cr("dominating test"); |
| 0 | 202 #endif |
| 203 | |
| 204 | |
| 205 // prevdom is the dominating projection of the dominating test. | |
| 206 assert( iff->is_If(), "" ); | |
| 207 assert( iff->Opcode() == Op_If || iff->Opcode() == Op_CountedLoopEnd, "Check this code when new subtype is added"); | |
| 208 int pop = prevdom->Opcode(); | |
| 209 assert( pop == Op_IfFalse || pop == Op_IfTrue, "" ); | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
210 if (flip) { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
211 if (pop == Op_IfTrue) |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
212 pop = Op_IfFalse; |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
213 else |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
214 pop = Op_IfTrue; |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
215 } |
| 0 | 216 // 'con' is set to true or false to kill the dominated test. |
| 217 Node *con = _igvn.makecon(pop == Op_IfTrue ? TypeInt::ONE : TypeInt::ZERO); | |
| 218 set_ctrl(con, C->root()); // Constant gets a new use | |
| 219 // Hack the dominated test | |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
220 _igvn.replace_input_of(iff, 1, con); |
| 0 | 221 |
| 222 // If I dont have a reachable TRUE and FALSE path following the IfNode then | |
| 223 // I can assume this path reaches an infinite loop. In this case it's not | |
| 224 // important to optimize the data Nodes - either the whole compilation will | |
| 225 // be tossed or this path (and all data Nodes) will go dead. | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
226 if (iff->outcnt() != 2) return; |
| 0 | 227 |
| 228 // Make control-dependent data Nodes on the live path (path that will remain | |
| 229 // once the dominated IF is removed) become control-dependent on the | |
| 230 // dominating projection. | |
|
3840
4e761e7e6e12
7070134: Hotspot crashes with sigsegv from PorterStemmer
kvn
parents:
3281
diff
changeset
|
231 Node* dp = iff->as_If()->proj_out(pop == Op_IfTrue); |
|
4e761e7e6e12
7070134: Hotspot crashes with sigsegv from PorterStemmer
kvn
parents:
3281
diff
changeset
|
232 |
|
4e761e7e6e12
7070134: Hotspot crashes with sigsegv from PorterStemmer
kvn
parents:
3281
diff
changeset
|
233 // Loop predicates may have depending checks which should not |
|
4e761e7e6e12
7070134: Hotspot crashes with sigsegv from PorterStemmer
kvn
parents:
3281
diff
changeset
|
234 // be skipped. For example, range check predicate has two checks |
|
4e761e7e6e12
7070134: Hotspot crashes with sigsegv from PorterStemmer
kvn
parents:
3281
diff
changeset
|
235 // for lower and upper bounds. |
|
8774
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
236 if (dp == NULL) |
|
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
237 return; |
|
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
238 |
|
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
239 ProjNode* dp_proj = dp->as_Proj(); |
|
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
240 ProjNode* unc_proj = iff->as_If()->proj_out(1 - dp_proj->_con)->as_Proj(); |
|
3840
4e761e7e6e12
7070134: Hotspot crashes with sigsegv from PorterStemmer
kvn
parents:
3281
diff
changeset
|
241 if (exclude_loop_predicate && |
|
12956
3213ba4d3dff
8024069: replace_in_map() should operate on parent maps
roland
parents:
12323
diff
changeset
|
242 unc_proj->is_uncommon_trap_proj(Deoptimization::Reason_predicate)) |
|
3840
4e761e7e6e12
7070134: Hotspot crashes with sigsegv from PorterStemmer
kvn
parents:
3281
diff
changeset
|
243 return; // Let IGVN transformation change control dependence. |
|
4e761e7e6e12
7070134: Hotspot crashes with sigsegv from PorterStemmer
kvn
parents:
3281
diff
changeset
|
244 |
| 0 | 245 IdealLoopTree *old_loop = get_loop(dp); |
| 246 | |
| 247 for (DUIterator_Fast imax, i = dp->fast_outs(imax); i < imax; i++) { | |
| 248 Node* cd = dp->fast_out(i); // Control-dependent node | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
249 if (cd->depends_only_on_test()) { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
250 assert(cd->in(0) == dp, ""); |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
251 _igvn.replace_input_of(cd, 0, prevdom); |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
252 set_early_ctrl(cd); |
| 0 | 253 IdealLoopTree *new_loop = get_loop(get_ctrl(cd)); |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
254 if (old_loop != new_loop) { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
255 if (!old_loop->_child) old_loop->_body.yank(cd); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
256 if (!new_loop->_child) new_loop->_body.push(cd); |
| 0 | 257 } |
| 258 --i; | |
| 259 --imax; | |
| 260 } | |
| 261 } | |
| 262 } | |
| 263 | |
| 264 //------------------------------has_local_phi_input---------------------------- | |
| 265 // Return TRUE if 'n' has Phi inputs from its local block and no other | |
| 266 // block-local inputs (all non-local-phi inputs come from earlier blocks) | |
| 267 Node *PhaseIdealLoop::has_local_phi_input( Node *n ) { | |
| 268 Node *n_ctrl = get_ctrl(n); | |
| 269 // See if some inputs come from a Phi in this block, or from before | |
| 270 // this block. | |
| 271 uint i; | |
| 272 for( i = 1; i < n->req(); i++ ) { | |
| 273 Node *phi = n->in(i); | |
| 274 if( phi->is_Phi() && phi->in(0) == n_ctrl ) | |
| 275 break; | |
| 276 } | |
| 277 if( i >= n->req() ) | |
| 278 return NULL; // No Phi inputs; nowhere to clone thru | |
| 279 | |
| 280 // Check for inputs created between 'n' and the Phi input. These | |
| 281 // must split as well; they have already been given the chance | |
| 282 // (courtesy of a post-order visit) and since they did not we must | |
| 283 // recover the 'cost' of splitting them by being very profitable | |
| 284 // when splitting 'n'. Since this is unlikely we simply give up. | |
| 285 for( i = 1; i < n->req(); i++ ) { | |
| 286 Node *m = n->in(i); | |
| 287 if( get_ctrl(m) == n_ctrl && !m->is_Phi() ) { | |
| 288 // We allow the special case of AddP's with no local inputs. | |
| 289 // This allows us to split-up address expressions. | |
| 290 if (m->is_AddP() && | |
| 291 get_ctrl(m->in(2)) != n_ctrl && | |
| 292 get_ctrl(m->in(3)) != n_ctrl) { | |
| 293 // Move the AddP up to dominating point | |
| 294 set_ctrl_and_loop(m, find_non_split_ctrl(idom(n_ctrl))); | |
| 295 continue; | |
| 296 } | |
| 297 return NULL; | |
| 298 } | |
| 299 } | |
| 300 | |
| 301 return n_ctrl; | |
| 302 } | |
| 303 | |
| 304 //------------------------------remix_address_expressions---------------------- | |
| 305 // Rework addressing expressions to get the most loop-invariant stuff | |
| 306 // moved out. We'd like to do all associative operators, but it's especially | |
| 307 // important (common) to do address expressions. | |
| 308 Node *PhaseIdealLoop::remix_address_expressions( Node *n ) { | |
| 309 if (!has_ctrl(n)) return NULL; | |
| 310 Node *n_ctrl = get_ctrl(n); | |
| 311 IdealLoopTree *n_loop = get_loop(n_ctrl); | |
| 312 | |
| 313 // See if 'n' mixes loop-varying and loop-invariant inputs and | |
| 314 // itself is loop-varying. | |
| 315 | |
| 316 // Only interested in binary ops (and AddP) | |
| 317 if( n->req() < 3 || n->req() > 4 ) return NULL; | |
| 318 | |
| 319 Node *n1_ctrl = get_ctrl(n->in( 1)); | |
| 320 Node *n2_ctrl = get_ctrl(n->in( 2)); | |
| 321 Node *n3_ctrl = get_ctrl(n->in(n->req() == 3 ? 2 : 3)); | |
| 322 IdealLoopTree *n1_loop = get_loop( n1_ctrl ); | |
| 323 IdealLoopTree *n2_loop = get_loop( n2_ctrl ); | |
| 324 IdealLoopTree *n3_loop = get_loop( n3_ctrl ); | |
| 325 | |
| 326 // Does one of my inputs spin in a tighter loop than self? | |
| 327 if( (n_loop->is_member( n1_loop ) && n_loop != n1_loop) || | |
| 328 (n_loop->is_member( n2_loop ) && n_loop != n2_loop) || | |
| 329 (n_loop->is_member( n3_loop ) && n_loop != n3_loop) ) | |
| 330 return NULL; // Leave well enough alone | |
| 331 | |
| 332 // Is at least one of my inputs loop-invariant? | |
| 333 if( n1_loop == n_loop && | |
| 334 n2_loop == n_loop && | |
| 335 n3_loop == n_loop ) | |
| 336 return NULL; // No loop-invariant inputs | |
| 337 | |
| 338 | |
| 339 int n_op = n->Opcode(); | |
| 340 | |
| 341 // Replace expressions like ((V+I) << 2) with (V<<2 + I<<2). | |
| 342 if( n_op == Op_LShiftI ) { | |
| 343 // Scale is loop invariant | |
| 344 Node *scale = n->in(2); | |
| 345 Node *scale_ctrl = get_ctrl(scale); | |
| 346 IdealLoopTree *scale_loop = get_loop(scale_ctrl ); | |
| 347 if( n_loop == scale_loop || !scale_loop->is_member( n_loop ) ) | |
| 348 return NULL; | |
| 349 const TypeInt *scale_t = scale->bottom_type()->isa_int(); | |
| 350 if( scale_t && scale_t->is_con() && scale_t->get_con() >= 16 ) | |
| 351 return NULL; // Dont bother with byte/short masking | |
| 352 // Add must vary with loop (else shift would be loop-invariant) | |
| 353 Node *add = n->in(1); | |
| 354 Node *add_ctrl = get_ctrl(add); | |
| 355 IdealLoopTree *add_loop = get_loop(add_ctrl); | |
| 356 //assert( n_loop == add_loop, "" ); | |
| 357 if( n_loop != add_loop ) return NULL; // happens w/ evil ZKM loops | |
| 358 | |
| 359 // Convert I-V into I+ (0-V); same for V-I | |
| 360 if( add->Opcode() == Op_SubI && | |
| 361 _igvn.type( add->in(1) ) != TypeInt::ZERO ) { | |
| 362 Node *zero = _igvn.intcon(0); | |
| 363 set_ctrl(zero, C->root()); | |
|
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
364 Node *neg = new (C) SubINode( _igvn.intcon(0), add->in(2) ); |
| 0 | 365 register_new_node( neg, get_ctrl(add->in(2) ) ); |
|
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
366 add = new (C) AddINode( add->in(1), neg ); |
| 0 | 367 register_new_node( add, add_ctrl ); |
| 368 } | |
| 369 if( add->Opcode() != Op_AddI ) return NULL; | |
| 370 // See if one add input is loop invariant | |
| 371 Node *add_var = add->in(1); | |
| 372 Node *add_var_ctrl = get_ctrl(add_var); | |
| 373 IdealLoopTree *add_var_loop = get_loop(add_var_ctrl ); | |
| 374 Node *add_invar = add->in(2); | |
| 375 Node *add_invar_ctrl = get_ctrl(add_invar); | |
| 376 IdealLoopTree *add_invar_loop = get_loop(add_invar_ctrl ); | |
| 377 if( add_var_loop == n_loop ) { | |
| 378 } else if( add_invar_loop == n_loop ) { | |
| 379 // Swap to find the invariant part | |
| 380 add_invar = add_var; | |
| 381 add_invar_ctrl = add_var_ctrl; | |
| 382 add_invar_loop = add_var_loop; | |
| 383 add_var = add->in(2); | |
| 384 Node *add_var_ctrl = get_ctrl(add_var); | |
| 385 IdealLoopTree *add_var_loop = get_loop(add_var_ctrl ); | |
| 386 } else // Else neither input is loop invariant | |
| 387 return NULL; | |
| 388 if( n_loop == add_invar_loop || !add_invar_loop->is_member( n_loop ) ) | |
| 389 return NULL; // No invariant part of the add? | |
| 390 | |
| 391 // Yes! Reshape address expression! | |
|
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
392 Node *inv_scale = new (C) LShiftINode( add_invar, scale ); |
|
850
fd50a67f97d1
6860469: remix_address_expressions sets incorrect control causing crash in split_if_with_block_post
never
parents:
834
diff
changeset
|
393 Node *inv_scale_ctrl = |
|
fd50a67f97d1
6860469: remix_address_expressions sets incorrect control causing crash in split_if_with_block_post
never
parents:
834
diff
changeset
|
394 dom_depth(add_invar_ctrl) > dom_depth(scale_ctrl) ? |
|
fd50a67f97d1
6860469: remix_address_expressions sets incorrect control causing crash in split_if_with_block_post
never
parents:
834
diff
changeset
|
395 add_invar_ctrl : scale_ctrl; |
|
fd50a67f97d1
6860469: remix_address_expressions sets incorrect control causing crash in split_if_with_block_post
never
parents:
834
diff
changeset
|
396 register_new_node( inv_scale, inv_scale_ctrl ); |
|
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
397 Node *var_scale = new (C) LShiftINode( add_var, scale ); |
| 0 | 398 register_new_node( var_scale, n_ctrl ); |
|
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
399 Node *var_add = new (C) AddINode( var_scale, inv_scale ); |
| 0 | 400 register_new_node( var_add, n_ctrl ); |
|
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
401 _igvn.replace_node( n, var_add ); |
| 0 | 402 return var_add; |
| 403 } | |
| 404 | |
| 405 // Replace (I+V) with (V+I) | |
| 406 if( n_op == Op_AddI || | |
| 407 n_op == Op_AddL || | |
| 408 n_op == Op_AddF || | |
| 409 n_op == Op_AddD || | |
| 410 n_op == Op_MulI || | |
| 411 n_op == Op_MulL || | |
| 412 n_op == Op_MulF || | |
| 413 n_op == Op_MulD ) { | |
| 414 if( n2_loop == n_loop ) { | |
| 415 assert( n1_loop != n_loop, "" ); | |
| 416 n->swap_edges(1, 2); | |
| 417 } | |
| 418 } | |
| 419 | |
| 420 // Replace ((I1 +p V) +p I2) with ((I1 +p I2) +p V), | |
| 421 // but not if I2 is a constant. | |
| 422 if( n_op == Op_AddP ) { | |
| 423 if( n2_loop == n_loop && n3_loop != n_loop ) { | |
| 424 if( n->in(2)->Opcode() == Op_AddP && !n->in(3)->is_Con() ) { | |
| 425 Node *n22_ctrl = get_ctrl(n->in(2)->in(2)); | |
| 426 Node *n23_ctrl = get_ctrl(n->in(2)->in(3)); | |
| 427 IdealLoopTree *n22loop = get_loop( n22_ctrl ); | |
| 428 IdealLoopTree *n23_loop = get_loop( n23_ctrl ); | |
| 429 if( n22loop != n_loop && n22loop->is_member(n_loop) && | |
| 430 n23_loop == n_loop ) { | |
|
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
431 Node *add1 = new (C) AddPNode( n->in(1), n->in(2)->in(2), n->in(3) ); |
| 0 | 432 // Stuff new AddP in the loop preheader |
| 433 register_new_node( add1, n_loop->_head->in(LoopNode::EntryControl) ); | |
|
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
434 Node *add2 = new (C) AddPNode( n->in(1), add1, n->in(2)->in(3) ); |
| 0 | 435 register_new_node( add2, n_ctrl ); |
|
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
436 _igvn.replace_node( n, add2 ); |
| 0 | 437 return add2; |
| 438 } | |
| 439 } | |
| 440 } | |
| 441 | |
| 442 // Replace (I1 +p (I2 + V)) with ((I1 +p I2) +p V) | |
| 443 if( n2_loop != n_loop && n3_loop == n_loop ) { | |
| 444 if( n->in(3)->Opcode() == Op_AddI ) { | |
| 445 Node *V = n->in(3)->in(1); | |
| 446 Node *I = n->in(3)->in(2); | |
| 447 if( is_member(n_loop,get_ctrl(V)) ) { | |
| 448 } else { | |
| 449 Node *tmp = V; V = I; I = tmp; | |
| 450 } | |
| 451 if( !is_member(n_loop,get_ctrl(I)) ) { | |
|
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
452 Node *add1 = new (C) AddPNode( n->in(1), n->in(2), I ); |
| 0 | 453 // Stuff new AddP in the loop preheader |
| 454 register_new_node( add1, n_loop->_head->in(LoopNode::EntryControl) ); | |
|
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
455 Node *add2 = new (C) AddPNode( n->in(1), add1, V ); |
| 0 | 456 register_new_node( add2, n_ctrl ); |
|
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
457 _igvn.replace_node( n, add2 ); |
| 0 | 458 return add2; |
| 459 } | |
| 460 } | |
| 461 } | |
| 462 } | |
| 463 | |
| 464 return NULL; | |
| 465 } | |
| 466 | |
| 467 //------------------------------conditional_move------------------------------- | |
| 468 // Attempt to replace a Phi with a conditional move. We have some pretty | |
| 469 // strict profitability requirements. All Phis at the merge point must | |
| 470 // be converted, so we can remove the control flow. We need to limit the | |
| 471 // number of c-moves to a small handful. All code that was in the side-arms | |
| 472 // of the CFG diamond is now speculatively executed. This code has to be | |
| 473 // "cheap enough". We are pretty much limited to CFG diamonds that merge | |
| 474 // 1 or 2 items with a total of 1 or 2 ops executed speculatively. | |
| 475 Node *PhaseIdealLoop::conditional_move( Node *region ) { | |
| 476 | |
| 4047 | 477 assert(region->is_Region(), "sanity check"); |
| 478 if (region->req() != 3) return NULL; | |
| 0 | 479 |
| 480 // Check for CFG diamond | |
| 481 Node *lp = region->in(1); | |
| 482 Node *rp = region->in(2); | |
| 4047 | 483 if (!lp || !rp) return NULL; |
| 0 | 484 Node *lp_c = lp->in(0); |
| 4047 | 485 if (lp_c == NULL || lp_c != rp->in(0) || !lp_c->is_If()) return NULL; |
| 0 | 486 IfNode *iff = lp_c->as_If(); |
| 487 | |
| 488 // Check for ops pinned in an arm of the diamond. | |
| 489 // Can't remove the control flow in this case | |
| 4047 | 490 if (lp->outcnt() > 1) return NULL; |
| 491 if (rp->outcnt() > 1) return NULL; | |
| 492 | |
| 493 IdealLoopTree* r_loop = get_loop(region); | |
| 494 assert(r_loop == get_loop(iff), "sanity"); | |
| 495 // Always convert to CMOVE if all results are used only outside this loop. | |
| 496 bool used_inside_loop = (r_loop == _ltree_root); | |
| 0 | 497 |
| 498 // Check profitability | |
| 499 int cost = 0; | |
|
35
e2ae28d2ce91
6667588: Don't generate duplicated CMP for float/double values
kvn
parents:
0
diff
changeset
|
500 int phis = 0; |
| 0 | 501 for (DUIterator_Fast imax, i = region->fast_outs(imax); i < imax; i++) { |
| 502 Node *out = region->fast_out(i); | |
| 4047 | 503 if (!out->is_Phi()) continue; // Ignore other control edges, etc |
|
35
e2ae28d2ce91
6667588: Don't generate duplicated CMP for float/double values
kvn
parents:
0
diff
changeset
|
504 phis++; |
| 0 | 505 PhiNode* phi = out->as_Phi(); |
| 4047 | 506 BasicType bt = phi->type()->basic_type(); |
| 507 switch (bt) { | |
| 508 case T_FLOAT: | |
| 509 case T_DOUBLE: { | |
| 510 cost += Matcher::float_cmove_cost(); // Could be very expensive | |
| 511 break; | |
| 512 } | |
| 513 case T_LONG: { | |
| 514 cost += Matcher::long_cmove_cost(); // May encodes as 2 CMOV's | |
| 515 } | |
| 0 | 516 case T_INT: // These all CMOV fine |
| 4047 | 517 case T_ADDRESS: { // (RawPtr) |
| 0 | 518 cost++; |
| 519 break; | |
| 4047 | 520 } |
|
293
c3e045194476
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
253
diff
changeset
|
521 case T_NARROWOOP: // Fall through |
| 0 | 522 case T_OBJECT: { // Base oops are OK, but not derived oops |
|
293
c3e045194476
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
253
diff
changeset
|
523 const TypeOopPtr *tp = phi->type()->make_ptr()->isa_oopptr(); |
| 0 | 524 // Derived pointers are Bad (tm): what's the Base (for GC purposes) of a |
| 525 // CMOVE'd derived pointer? It's a CMOVE'd derived base. Thus | |
| 526 // CMOVE'ing a derived pointer requires we also CMOVE the base. If we | |
| 527 // have a Phi for the base here that we convert to a CMOVE all is well | |
| 528 // and good. But if the base is dead, we'll not make a CMOVE. Later | |
| 529 // the allocator will have to produce a base by creating a CMOVE of the | |
| 530 // relevant bases. This puts the allocator in the business of | |
| 531 // manufacturing expensive instructions, generally a bad plan. | |
| 532 // Just Say No to Conditionally-Moved Derived Pointers. | |
| 4047 | 533 if (tp && tp->offset() != 0) |
| 0 | 534 return NULL; |
| 535 cost++; | |
| 536 break; | |
| 537 } | |
| 538 default: | |
| 539 return NULL; // In particular, can't do memory or I/O | |
| 540 } | |
| 541 // Add in cost any speculative ops | |
| 4047 | 542 for (uint j = 1; j < region->req(); j++) { |
| 0 | 543 Node *proj = region->in(j); |
| 544 Node *inp = phi->in(j); | |
| 545 if (get_ctrl(inp) == proj) { // Found local op | |
| 546 cost++; | |
| 547 // Check for a chain of dependent ops; these will all become | |
| 548 // speculative in a CMOV. | |
| 4047 | 549 for (uint k = 1; k < inp->req(); k++) |
| 0 | 550 if (get_ctrl(inp->in(k)) == proj) |
| 4047 | 551 cost += ConditionalMoveLimit; // Too much speculative goo |
| 0 | 552 } |
| 553 } | |
|
293
c3e045194476
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
253
diff
changeset
|
554 // See if the Phi is used by a Cmp or Narrow oop Decode/Encode. |
|
c3e045194476
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
253
diff
changeset
|
555 // This will likely Split-If, a higher-payoff operation. |
| 0 | 556 for (DUIterator_Fast kmax, k = phi->fast_outs(kmax); k < kmax; k++) { |
| 557 Node* use = phi->fast_out(k); | |
|
6848
8e47bac5643a
7054512: Compress class pointers after perm gen removal
roland
parents:
6804
diff
changeset
|
558 if (use->is_Cmp() || use->is_DecodeNarrowPtr() || use->is_EncodeNarrowPtr()) |
| 4047 | 559 cost += ConditionalMoveLimit; |
| 560 // Is there a use inside the loop? | |
| 561 // Note: check only basic types since CMoveP is pinned. | |
| 562 if (!used_inside_loop && is_java_primitive(bt)) { | |
| 563 IdealLoopTree* u_loop = get_loop(has_ctrl(use) ? get_ctrl(use) : use); | |
| 564 if (r_loop == u_loop || r_loop->is_member(u_loop)) { | |
| 565 used_inside_loop = true; | |
| 566 } | |
| 567 } | |
| 0 | 568 } |
| 569 } | |
|
35
e2ae28d2ce91
6667588: Don't generate duplicated CMP for float/double values
kvn
parents:
0
diff
changeset
|
570 Node* bol = iff->in(1); |
| 4047 | 571 assert(bol->Opcode() == Op_Bool, ""); |
|
35
e2ae28d2ce91
6667588: Don't generate duplicated CMP for float/double values
kvn
parents:
0
diff
changeset
|
572 int cmp_op = bol->in(1)->Opcode(); |
|
e2ae28d2ce91
6667588: Don't generate duplicated CMP for float/double values
kvn
parents:
0
diff
changeset
|
573 // It is expensive to generate flags from a float compare. |
|
e2ae28d2ce91
6667588: Don't generate duplicated CMP for float/double values
kvn
parents:
0
diff
changeset
|
574 // Avoid duplicated float compare. |
| 4047 | 575 if (phis > 1 && (cmp_op == Op_CmpF || cmp_op == Op_CmpD)) return NULL; |
| 576 | |
| 577 float infrequent_prob = PROB_UNLIKELY_MAG(3); | |
| 578 // Ignore cost and blocks frequency if CMOVE can be moved outside the loop. | |
| 579 if (used_inside_loop) { | |
| 580 if (cost >= ConditionalMoveLimit) return NULL; // Too much goo | |
| 581 | |
| 582 // BlockLayoutByFrequency optimization moves infrequent branch | |
| 583 // from hot path. No point in CMOV'ing in such case (110 is used | |
| 584 // instead of 100 to take into account not exactness of float value). | |
| 585 if (BlockLayoutByFrequency) { | |
| 586 infrequent_prob = MAX2(infrequent_prob, (float)BlockLayoutMinDiamondPercentage/110.0f); | |
| 587 } | |
| 588 } | |
| 589 // Check for highly predictable branch. No point in CMOV'ing if | |
| 590 // we are going to predict accurately all the time. | |
| 591 if (iff->_prob < infrequent_prob || | |
| 592 iff->_prob > (1.0f - infrequent_prob)) | |
| 593 return NULL; | |
| 0 | 594 |
| 595 // -------------- | |
| 596 // Now replace all Phis with CMOV's | |
| 597 Node *cmov_ctrl = iff->in(0); | |
| 598 uint flip = (lp->Opcode() == Op_IfTrue); | |
| 4047 | 599 while (1) { |
| 0 | 600 PhiNode* phi = NULL; |
| 601 for (DUIterator_Fast imax, i = region->fast_outs(imax); i < imax; i++) { | |
| 602 Node *out = region->fast_out(i); | |
| 603 if (out->is_Phi()) { | |
| 604 phi = out->as_Phi(); | |
| 605 break; | |
| 606 } | |
| 607 } | |
| 608 if (phi == NULL) break; | |
| 609 #ifndef PRODUCT | |
| 4047 | 610 if (PrintOpto && VerifyLoopOptimizations) tty->print_cr("CMOV"); |
| 0 | 611 #endif |
| 612 // Move speculative ops | |
| 4047 | 613 for (uint j = 1; j < region->req(); j++) { |
| 0 | 614 Node *proj = region->in(j); |
| 615 Node *inp = phi->in(j); | |
| 616 if (get_ctrl(inp) == proj) { // Found local op | |
| 617 #ifndef PRODUCT | |
| 4047 | 618 if (PrintOpto && VerifyLoopOptimizations) { |
| 0 | 619 tty->print(" speculate: "); |
| 620 inp->dump(); | |
| 621 } | |
| 622 #endif | |
| 623 set_ctrl(inp, cmov_ctrl); | |
| 624 } | |
| 625 } | |
| 626 Node *cmov = CMoveNode::make( C, cmov_ctrl, iff->in(1), phi->in(1+flip), phi->in(2-flip), _igvn.type(phi) ); | |
| 627 register_new_node( cmov, cmov_ctrl ); | |
|
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
628 _igvn.replace_node( phi, cmov ); |
| 0 | 629 #ifndef PRODUCT |
| 4047 | 630 if (TraceLoopOpts) { |
| 631 tty->print("CMOV "); | |
| 632 r_loop->dump_head(); | |
|
4064
670a74b863fc
7107042: assert(no_dead_loop) failed: dead loop detected
kvn
parents:
4047
diff
changeset
|
633 if (Verbose) { |
| 4047 | 634 bol->in(1)->dump(1); |
| 635 cmov->dump(1); | |
|
4064
670a74b863fc
7107042: assert(no_dead_loop) failed: dead loop detected
kvn
parents:
4047
diff
changeset
|
636 } |
| 4047 | 637 } |
| 638 if (VerifyLoopOptimizations) verify(); | |
| 0 | 639 #endif |
| 640 } | |
| 641 | |
| 642 // The useless CFG diamond will fold up later; see the optimization in | |
| 643 // RegionNode::Ideal. | |
| 644 _igvn._worklist.push(region); | |
| 645 | |
| 646 return iff->in(1); | |
| 647 } | |
| 648 | |
| 649 //------------------------------split_if_with_blocks_pre----------------------- | |
| 650 // Do the real work in a non-recursive function. Data nodes want to be | |
| 651 // cloned in the pre-order so they can feed each other nicely. | |
| 652 Node *PhaseIdealLoop::split_if_with_blocks_pre( Node *n ) { | |
| 653 // Cloning these guys is unlikely to win | |
| 654 int n_op = n->Opcode(); | |
| 655 if( n_op == Op_MergeMem ) return n; | |
| 656 if( n->is_Proj() ) return n; | |
| 657 // Do not clone-up CmpFXXX variations, as these are always | |
| 658 // followed by a CmpI | |
| 659 if( n->is_Cmp() ) return n; | |
| 660 // Attempt to use a conditional move instead of a phi/branch | |
| 661 if( ConditionalMoveLimit > 0 && n_op == Op_Region ) { | |
| 662 Node *cmov = conditional_move( n ); | |
| 663 if( cmov ) return cmov; | |
| 664 } | |
|
253
b0fe4deeb9fb
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
251
diff
changeset
|
665 if( n->is_CFG() || n->is_LoadStore() ) |
|
b0fe4deeb9fb
6726999: nsk/stress/jck12a/jck12a010 assert(n != null,"Bad immediate dominator info.")
kvn
parents:
251
diff
changeset
|
666 return n; |
| 0 | 667 if( n_op == Op_Opaque1 || // Opaque nodes cannot be mod'd |
| 668 n_op == Op_Opaque2 ) { | |
| 669 if( !C->major_progress() ) // If chance of no more loop opts... | |
| 670 _igvn._worklist.push(n); // maybe we'll remove them | |
| 671 return n; | |
| 672 } | |
| 673 | |
| 674 if( n->is_Con() ) return n; // No cloning for Con nodes | |
| 675 | |
| 676 Node *n_ctrl = get_ctrl(n); | |
| 677 if( !n_ctrl ) return n; // Dead node | |
| 678 | |
| 679 // Attempt to remix address expressions for loop invariants | |
| 680 Node *m = remix_address_expressions( n ); | |
| 681 if( m ) return m; | |
| 682 | |
| 683 // Determine if the Node has inputs from some local Phi. | |
| 684 // Returns the block to clone thru. | |
| 685 Node *n_blk = has_local_phi_input( n ); | |
| 686 if( !n_blk ) return n; | |
| 687 // Do not clone the trip counter through on a CountedLoop | |
| 688 // (messes up the canonical shape). | |
| 689 if( n_blk->is_CountedLoop() && n->Opcode() == Op_AddI ) return n; | |
| 690 | |
| 691 // Check for having no control input; not pinned. Allow | |
| 692 // dominating control. | |
| 693 if( n->in(0) ) { | |
| 694 Node *dom = idom(n_blk); | |
| 695 if( dom_lca( n->in(0), dom ) != n->in(0) ) | |
| 696 return n; | |
| 697 } | |
| 698 // Policy: when is it profitable. You must get more wins than | |
| 699 // policy before it is considered profitable. Policy is usually 0, | |
| 700 // so 1 win is considered profitable. Big merges will require big | |
| 701 // cloning, so get a larger policy. | |
| 702 int policy = n_blk->req() >> 2; | |
| 703 | |
| 704 // If the loop is a candidate for range check elimination, | |
| 705 // delay splitting through it's phi until a later loop optimization | |
| 706 if (n_blk->is_CountedLoop()) { | |
| 707 IdealLoopTree *lp = get_loop(n_blk); | |
| 708 if (lp && lp->_rce_candidate) { | |
| 709 return n; | |
| 710 } | |
| 711 } | |
| 712 | |
| 713 // Use same limit as split_if_with_blocks_post | |
| 714 if( C->unique() > 35000 ) return n; // Method too big | |
| 715 | |
| 716 // Split 'n' through the merge point if it is profitable | |
| 717 Node *phi = split_thru_phi( n, n_blk, policy ); | |
| 4047 | 718 if (!phi) return n; |
| 0 | 719 |
| 720 // Found a Phi to split thru! | |
| 721 // Replace 'n' with the new phi | |
|
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
722 _igvn.replace_node( n, phi ); |
| 0 | 723 // Moved a load around the loop, 'en-registering' something. |
| 4047 | 724 if (n_blk->is_Loop() && n->is_Load() && |
| 725 !phi->in(LoopNode::LoopBackControl)->is_Load()) | |
| 0 | 726 C->set_major_progress(); |
| 727 | |
| 728 return phi; | |
| 729 } | |
| 730 | |
| 731 static bool merge_point_too_heavy(Compile* C, Node* region) { | |
| 732 // Bail out if the region and its phis have too many users. | |
| 733 int weight = 0; | |
| 734 for (DUIterator_Fast imax, i = region->fast_outs(imax); i < imax; i++) { | |
| 735 weight += region->fast_out(i)->outcnt(); | |
| 736 } | |
|
7196
2aff40cb4703
7092905: C2: Keep track of the number of dead nodes
bharadwaj
parents:
6853
diff
changeset
|
737 int nodes_left = MaxNodeLimit - C->live_nodes(); |
| 0 | 738 if (weight * 8 > nodes_left) { |
| 739 #ifndef PRODUCT | |
| 740 if (PrintOpto) | |
| 741 tty->print_cr("*** Split-if bails out: %d nodes, region weight %d", C->unique(), weight); | |
| 742 #endif | |
| 743 return true; | |
| 744 } else { | |
| 745 return false; | |
| 746 } | |
| 747 } | |
| 748 | |
| 749 static bool merge_point_safe(Node* region) { | |
| 750 // 4799512: Stop split_if_with_blocks from splitting a block with a ConvI2LNode | |
| 751 // having a PhiNode input. This sidesteps the dangerous case where the split | |
| 752 // ConvI2LNode may become TOP if the input Value() does not | |
| 753 // overlap the ConvI2L range, leaving a node which may not dominate its | |
| 754 // uses. | |
| 755 // A better fix for this problem can be found in the BugTraq entry, but | |
| 756 // expediency for Mantis demands this hack. | |
|
834
0f2d888530e7
6855164: SIGSEGV during compilation of method involving loop over CharSequence.
cfang
parents:
605
diff
changeset
|
757 // 6855164: If the merge point has a FastLockNode with a PhiNode input, we stop |
|
0f2d888530e7
6855164: SIGSEGV during compilation of method involving loop over CharSequence.
cfang
parents:
605
diff
changeset
|
758 // split_if_with_blocks from splitting a block because we could not move around |
|
0f2d888530e7
6855164: SIGSEGV during compilation of method involving loop over CharSequence.
cfang
parents:
605
diff
changeset
|
759 // the FastLockNode. |
| 0 | 760 for (DUIterator_Fast imax, i = region->fast_outs(imax); i < imax; i++) { |
| 761 Node* n = region->fast_out(i); | |
| 762 if (n->is_Phi()) { | |
| 763 for (DUIterator_Fast jmax, j = n->fast_outs(jmax); j < jmax; j++) { | |
| 764 Node* m = n->fast_out(j); | |
|
834
0f2d888530e7
6855164: SIGSEGV during compilation of method involving loop over CharSequence.
cfang
parents:
605
diff
changeset
|
765 if (m->is_FastLock()) |
| 0 | 766 return false; |
|
834
0f2d888530e7
6855164: SIGSEGV during compilation of method involving loop over CharSequence.
cfang
parents:
605
diff
changeset
|
767 #ifdef _LP64 |
|
0f2d888530e7
6855164: SIGSEGV during compilation of method involving loop over CharSequence.
cfang
parents:
605
diff
changeset
|
768 if (m->Opcode() == Op_ConvI2L) |
|
0f2d888530e7
6855164: SIGSEGV during compilation of method involving loop over CharSequence.
cfang
parents:
605
diff
changeset
|
769 return false; |
|
0f2d888530e7
6855164: SIGSEGV during compilation of method involving loop over CharSequence.
cfang
parents:
605
diff
changeset
|
770 #endif |
| 0 | 771 } |
| 772 } | |
| 773 } | |
| 774 return true; | |
| 775 } | |
| 776 | |
| 777 | |
| 778 //------------------------------place_near_use--------------------------------- | |
| 779 // Place some computation next to use but not inside inner loops. | |
| 780 // For inner loop uses move it to the preheader area. | |
| 781 Node *PhaseIdealLoop::place_near_use( Node *useblock ) const { | |
| 782 IdealLoopTree *u_loop = get_loop( useblock ); | |
| 783 return (u_loop->_irreducible || u_loop->_child) | |
| 784 ? useblock | |
| 785 : u_loop->_head->in(LoopNode::EntryControl); | |
| 786 } | |
| 787 | |
| 788 | |
| 789 //------------------------------split_if_with_blocks_post---------------------- | |
| 790 // Do the real work in a non-recursive function. CFG hackery wants to be | |
| 791 // in the post-order, so it can dirty the I-DOM info and not use the dirtied | |
| 792 // info. | |
| 793 void PhaseIdealLoop::split_if_with_blocks_post( Node *n ) { | |
| 794 | |
| 795 // Cloning Cmp through Phi's involves the split-if transform. | |
| 796 // FastLock is not used by an If | |
| 797 if( n->is_Cmp() && !n->is_FastLock() ) { | |
| 798 if( C->unique() > 35000 ) return; // Method too big | |
| 799 | |
| 800 // Do not do 'split-if' if irreducible loops are present. | |
| 801 if( _has_irreducible_loops ) | |
| 802 return; | |
| 803 | |
| 804 Node *n_ctrl = get_ctrl(n); | |
| 805 // Determine if the Node has inputs from some local Phi. | |
| 806 // Returns the block to clone thru. | |
| 807 Node *n_blk = has_local_phi_input( n ); | |
| 808 if( n_blk != n_ctrl ) return; | |
| 809 | |
| 810 if( merge_point_too_heavy(C, n_ctrl) ) | |
| 811 return; | |
| 812 | |
| 813 if( n->outcnt() != 1 ) return; // Multiple bool's from 1 compare? | |
| 814 Node *bol = n->unique_out(); | |
| 815 assert( bol->is_Bool(), "expect a bool here" ); | |
| 816 if( bol->outcnt() != 1 ) return;// Multiple branches from 1 compare? | |
| 817 Node *iff = bol->unique_out(); | |
| 818 | |
| 819 // Check some safety conditions | |
| 820 if( iff->is_If() ) { // Classic split-if? | |
| 821 if( iff->in(0) != n_ctrl ) return; // Compare must be in same blk as if | |
| 822 } else if (iff->is_CMove()) { // Trying to split-up a CMOVE | |
|
4779
c8d8e124380c
7064302: JDK7 build 147 crashed after testing my java 6-compiled web app
kvn
parents:
4064
diff
changeset
|
823 // Can't split CMove with different control edge. |
|
c8d8e124380c
7064302: JDK7 build 147 crashed after testing my java 6-compiled web app
kvn
parents:
4064
diff
changeset
|
824 if (iff->in(0) != NULL && iff->in(0) != n_ctrl ) return; |
| 0 | 825 if( get_ctrl(iff->in(2)) == n_ctrl || |
| 826 get_ctrl(iff->in(3)) == n_ctrl ) | |
| 827 return; // Inputs not yet split-up | |
| 828 if ( get_loop(n_ctrl) != get_loop(get_ctrl(iff)) ) { | |
| 829 return; // Loop-invar test gates loop-varying CMOVE | |
| 830 } | |
| 831 } else { | |
| 832 return; // some other kind of node, such as an Allocate | |
| 833 } | |
| 834 | |
| 835 // Do not do 'split-if' if some paths are dead. First do dead code | |
| 836 // elimination and then see if its still profitable. | |
| 837 for( uint i = 1; i < n_ctrl->req(); i++ ) | |
| 838 if( n_ctrl->in(i) == C->top() ) | |
| 839 return; | |
| 840 | |
| 841 // When is split-if profitable? Every 'win' on means some control flow | |
| 842 // goes dead, so it's almost always a win. | |
| 843 int policy = 0; | |
| 844 // If trying to do a 'Split-If' at the loop head, it is only | |
| 845 // profitable if the cmp folds up on BOTH paths. Otherwise we | |
| 846 // risk peeling a loop forever. | |
| 847 | |
| 848 // CNC - Disabled for now. Requires careful handling of loop | |
| 849 // body selection for the cloned code. Also, make sure we check | |
| 850 // for any input path not being in the same loop as n_ctrl. For | |
| 851 // irreducible loops we cannot check for 'n_ctrl->is_Loop()' | |
| 852 // because the alternative loop entry points won't be converted | |
| 853 // into LoopNodes. | |
| 854 IdealLoopTree *n_loop = get_loop(n_ctrl); | |
| 855 for( uint j = 1; j < n_ctrl->req(); j++ ) | |
| 856 if( get_loop(n_ctrl->in(j)) != n_loop ) | |
| 857 return; | |
| 858 | |
| 859 // Check for safety of the merge point. | |
| 860 if( !merge_point_safe(n_ctrl) ) { | |
| 861 return; | |
| 862 } | |
| 863 | |
| 864 // Split compare 'n' through the merge point if it is profitable | |
| 865 Node *phi = split_thru_phi( n, n_ctrl, policy ); | |
| 866 if( !phi ) return; | |
| 867 | |
| 868 // Found a Phi to split thru! | |
| 869 // Replace 'n' with the new phi | |
|
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
870 _igvn.replace_node( n, phi ); |
| 0 | 871 |
| 872 // Now split the bool up thru the phi | |
| 873 Node *bolphi = split_thru_phi( bol, n_ctrl, -1 ); | |
|
8774
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
874 guarantee(bolphi != NULL, "null boolean phi node"); |
|
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
875 |
|
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
876 _igvn.replace_node( bol, bolphi ); |
| 0 | 877 assert( iff->in(1) == bolphi, "" ); |
|
8774
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
878 |
| 0 | 879 if( bolphi->Value(&_igvn)->singleton() ) |
| 880 return; | |
| 881 | |
| 882 // Conditional-move? Must split up now | |
| 883 if( !iff->is_If() ) { | |
| 884 Node *cmovphi = split_thru_phi( iff, n_ctrl, -1 ); | |
|
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
885 _igvn.replace_node( iff, cmovphi ); |
| 0 | 886 return; |
| 887 } | |
| 888 | |
| 889 // Now split the IF | |
| 890 do_split_if( iff ); | |
| 891 return; | |
| 892 } | |
| 893 | |
| 894 // Check for an IF ready to split; one that has its | |
| 895 // condition codes input coming from a Phi at the block start. | |
| 896 int n_op = n->Opcode(); | |
| 897 | |
| 898 // Check for an IF being dominated by another IF same test | |
| 899 if( n_op == Op_If ) { | |
| 900 Node *bol = n->in(1); | |
| 901 uint max = bol->outcnt(); | |
| 902 // Check for same test used more than once? | |
| 903 if( n_op == Op_If && max > 1 && bol->is_Bool() ) { | |
| 904 // Search up IDOMs to see if this IF is dominated. | |
| 905 Node *cutoff = get_ctrl(bol); | |
| 906 | |
| 907 // Now search up IDOMs till cutoff, looking for a dominating test | |
| 908 Node *prevdom = n; | |
| 909 Node *dom = idom(prevdom); | |
| 910 while( dom != cutoff ) { | |
| 911 if( dom->req() > 1 && dom->in(1) == bol && prevdom->in(0) == dom ) { | |
| 912 // Replace the dominated test with an obvious true or false. | |
| 913 // Place it on the IGVN worklist for later cleanup. | |
| 914 C->set_major_progress(); | |
|
3840
4e761e7e6e12
7070134: Hotspot crashes with sigsegv from PorterStemmer
kvn
parents:
3281
diff
changeset
|
915 dominated_by( prevdom, n, false, true ); |
| 0 | 916 #ifndef PRODUCT |
| 917 if( VerifyLoopOptimizations ) verify(); | |
| 918 #endif | |
| 919 return; | |
| 920 } | |
| 921 prevdom = dom; | |
| 922 dom = idom(prevdom); | |
| 923 } | |
| 924 } | |
| 925 } | |
| 926 | |
| 927 // See if a shared loop-varying computation has no loop-varying uses. | |
| 928 // Happens if something is only used for JVM state in uncommon trap exits, | |
| 929 // like various versions of induction variable+offset. Clone the | |
| 930 // computation per usage to allow it to sink out of the loop. | |
| 931 if (has_ctrl(n) && !n->in(0)) {// n not dead and has no control edge (can float about) | |
| 932 Node *n_ctrl = get_ctrl(n); | |
| 933 IdealLoopTree *n_loop = get_loop(n_ctrl); | |
| 934 if( n_loop != _ltree_root ) { | |
| 935 DUIterator_Fast imax, i = n->fast_outs(imax); | |
| 936 for (; i < imax; i++) { | |
| 937 Node* u = n->fast_out(i); | |
| 938 if( !has_ctrl(u) ) break; // Found control user | |
| 939 IdealLoopTree *u_loop = get_loop(get_ctrl(u)); | |
| 940 if( u_loop == n_loop ) break; // Found loop-varying use | |
| 941 if( n_loop->is_member( u_loop ) ) break; // Found use in inner loop | |
| 942 if( u->Opcode() == Op_Opaque1 ) break; // Found loop limit, bugfix for 4677003 | |
| 943 } | |
| 944 bool did_break = (i < imax); // Did we break out of the previous loop? | |
| 945 if (!did_break && n->outcnt() > 1) { // All uses in outer loops! | |
|
4779
c8d8e124380c
7064302: JDK7 build 147 crashed after testing my java 6-compiled web app
kvn
parents:
4064
diff
changeset
|
946 Node *late_load_ctrl = NULL; |
| 0 | 947 if (n->is_Load()) { |
| 948 // If n is a load, get and save the result from get_late_ctrl(), | |
| 949 // to be later used in calculating the control for n's clones. | |
| 950 clear_dom_lca_tags(); | |
| 951 late_load_ctrl = get_late_ctrl(n, n_ctrl); | |
| 952 } | |
| 953 // If n is a load, and the late control is the same as the current | |
| 954 // control, then the cloning of n is a pointless exercise, because | |
| 955 // GVN will ensure that we end up where we started. | |
| 956 if (!n->is_Load() || late_load_ctrl != n_ctrl) { | |
| 957 for (DUIterator_Last jmin, j = n->last_outs(jmin); j >= jmin; ) { | |
| 958 Node *u = n->last_out(j); // Clone private computation per use | |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
959 _igvn.rehash_node_delayed(u); |
| 0 | 960 Node *x = n->clone(); // Clone computation |
| 961 Node *x_ctrl = NULL; | |
| 962 if( u->is_Phi() ) { | |
| 963 // Replace all uses of normal nodes. Replace Phi uses | |
| 605 | 964 // individually, so the separate Nodes can sink down |
| 0 | 965 // different paths. |
| 966 uint k = 1; | |
| 967 while( u->in(k) != n ) k++; | |
| 968 u->set_req( k, x ); | |
| 969 // x goes next to Phi input path | |
| 970 x_ctrl = u->in(0)->in(k); | |
| 971 --j; | |
| 972 } else { // Normal use | |
| 973 // Replace all uses | |
| 974 for( uint k = 0; k < u->req(); k++ ) { | |
| 975 if( u->in(k) == n ) { | |
| 976 u->set_req( k, x ); | |
| 977 --j; | |
| 978 } | |
| 979 } | |
| 980 x_ctrl = get_ctrl(u); | |
| 981 } | |
| 982 | |
| 983 // Find control for 'x' next to use but not inside inner loops. | |
| 984 // For inner loop uses get the preheader area. | |
| 985 x_ctrl = place_near_use(x_ctrl); | |
| 986 | |
| 987 if (n->is_Load()) { | |
| 988 // For loads, add a control edge to a CFG node outside of the loop | |
| 989 // to force them to not combine and return back inside the loop | |
| 990 // during GVN optimization (4641526). | |
| 991 // | |
| 992 // Because we are setting the actual control input, factor in | |
| 993 // the result from get_late_ctrl() so we respect any | |
| 994 // anti-dependences. (6233005). | |
| 995 x_ctrl = dom_lca(late_load_ctrl, x_ctrl); | |
| 996 | |
| 997 // Don't allow the control input to be a CFG splitting node. | |
| 998 // Such nodes should only have ProjNodes as outs, e.g. IfNode | |
| 999 // should only have IfTrueNode and IfFalseNode (4985384). | |
| 1000 x_ctrl = find_non_split_ctrl(x_ctrl); | |
| 1001 assert(dom_depth(n_ctrl) <= dom_depth(x_ctrl), "n is later than its clone"); | |
| 1002 | |
| 1003 x->set_req(0, x_ctrl); | |
| 1004 } | |
| 1005 register_new_node(x, x_ctrl); | |
| 1006 | |
| 1007 // Some institutional knowledge is needed here: 'x' is | |
| 1008 // yanked because if the optimizer runs GVN on it all the | |
| 1009 // cloned x's will common up and undo this optimization and | |
| 1010 // be forced back in the loop. This is annoying because it | |
| 1011 // makes +VerifyOpto report false-positives on progress. I | |
| 1012 // tried setting control edges on the x's to force them to | |
| 1013 // not combine, but the matching gets worried when it tries | |
| 1014 // to fold a StoreP and an AddP together (as part of an | |
| 1015 // address expression) and the AddP and StoreP have | |
| 1016 // different controls. | |
|
6848
8e47bac5643a
7054512: Compress class pointers after perm gen removal
roland
parents:
6804
diff
changeset
|
1017 if (!x->is_Load() && !x->is_DecodeNarrowPtr()) _igvn._worklist.yank(x); |
| 0 | 1018 } |
| 1019 _igvn.remove_dead_node(n); | |
| 1020 } | |
| 1021 } | |
| 1022 } | |
| 1023 } | |
| 1024 | |
| 1025 // Check for Opaque2's who's loop has disappeared - who's input is in the | |
| 1026 // same loop nest as their output. Remove 'em, they are no longer useful. | |
| 1027 if( n_op == Op_Opaque2 && | |
| 1028 n->in(1) != NULL && | |
| 1029 get_loop(get_ctrl(n)) == get_loop(get_ctrl(n->in(1))) ) { | |
|
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
1030 _igvn.replace_node( n, n->in(1) ); |
| 0 | 1031 } |
| 1032 } | |
| 1033 | |
| 1034 //------------------------------split_if_with_blocks--------------------------- | |
| 1035 // Check for aggressive application of 'split-if' optimization, | |
| 1036 // using basic block level info. | |
| 1037 void PhaseIdealLoop::split_if_with_blocks( VectorSet &visited, Node_Stack &nstack ) { | |
| 1038 Node *n = C->root(); | |
| 1039 visited.set(n->_idx); // first, mark node as visited | |
| 1040 // Do pre-visit work for root | |
| 1041 n = split_if_with_blocks_pre( n ); | |
| 1042 uint cnt = n->outcnt(); | |
| 1043 uint i = 0; | |
| 1044 while (true) { | |
| 1045 // Visit all children | |
| 1046 if (i < cnt) { | |
| 1047 Node* use = n->raw_out(i); | |
| 1048 ++i; | |
| 1049 if (use->outcnt() != 0 && !visited.test_set(use->_idx)) { | |
| 1050 // Now do pre-visit work for this use | |
| 1051 use = split_if_with_blocks_pre( use ); | |
| 1052 nstack.push(n, i); // Save parent and next use's index. | |
| 1053 n = use; // Process all children of current use. | |
| 1054 cnt = use->outcnt(); | |
| 1055 i = 0; | |
| 1056 } | |
| 1057 } | |
| 1058 else { | |
| 1059 // All of n's children have been processed, complete post-processing. | |
| 1060 if (cnt != 0 && !n->is_Con()) { | |
| 1061 assert(has_node(n), "no dead nodes"); | |
| 1062 split_if_with_blocks_post( n ); | |
| 1063 } | |
| 1064 if (nstack.is_empty()) { | |
| 1065 // Finished all nodes on stack. | |
| 1066 break; | |
| 1067 } | |
| 1068 // Get saved parent node and next use's index. Visit the rest of uses. | |
| 1069 n = nstack.node(); | |
| 1070 cnt = n->outcnt(); | |
| 1071 i = nstack.index(); | |
| 1072 nstack.pop(); | |
| 1073 } | |
| 1074 } | |
| 1075 } | |
| 1076 | |
| 1077 | |
| 1078 //============================================================================= | |
| 1079 // | |
| 1080 // C L O N E A L O O P B O D Y | |
| 1081 // | |
| 1082 | |
| 1083 //------------------------------clone_iff-------------------------------------- | |
| 1084 // Passed in a Phi merging (recursively) some nearly equivalent Bool/Cmps. | |
| 1085 // "Nearly" because all Nodes have been cloned from the original in the loop, | |
| 1086 // but the fall-in edges to the Cmp are different. Clone bool/Cmp pairs | |
| 1087 // through the Phi recursively, and return a Bool. | |
| 1088 BoolNode *PhaseIdealLoop::clone_iff( PhiNode *phi, IdealLoopTree *loop ) { | |
| 1089 | |
| 1090 // Convert this Phi into a Phi merging Bools | |
| 1091 uint i; | |
| 1092 for( i = 1; i < phi->req(); i++ ) { | |
| 1093 Node *b = phi->in(i); | |
| 1094 if( b->is_Phi() ) { | |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1095 _igvn.replace_input_of(phi, i, clone_iff( b->as_Phi(), loop )); |
| 0 | 1096 } else { |
| 1097 assert( b->is_Bool(), "" ); | |
| 1098 } | |
| 1099 } | |
| 1100 | |
| 1101 Node *sample_bool = phi->in(1); | |
| 1102 Node *sample_cmp = sample_bool->in(1); | |
| 1103 | |
| 1104 // Make Phis to merge the Cmp's inputs. | |
|
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
1105 PhiNode *phi1 = new (C) PhiNode( phi->in(0), Type::TOP ); |
|
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
1106 PhiNode *phi2 = new (C) PhiNode( phi->in(0), Type::TOP ); |
| 0 | 1107 for( i = 1; i < phi->req(); i++ ) { |
| 1108 Node *n1 = phi->in(i)->in(1)->in(1); | |
| 1109 Node *n2 = phi->in(i)->in(1)->in(2); | |
| 1110 phi1->set_req( i, n1 ); | |
| 1111 phi2->set_req( i, n2 ); | |
|
17671
de95063c0e34
8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed
roland
parents:
17467
diff
changeset
|
1112 phi1->set_type( phi1->type()->meet_speculative(n1->bottom_type())); |
|
de95063c0e34
8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed
roland
parents:
17467
diff
changeset
|
1113 phi2->set_type( phi2->type()->meet_speculative(n2->bottom_type())); |
| 0 | 1114 } |
| 1115 // See if these Phis have been made before. | |
| 1116 // Register with optimizer | |
| 1117 Node *hit1 = _igvn.hash_find_insert(phi1); | |
| 1118 if( hit1 ) { // Hit, toss just made Phi | |
| 1119 _igvn.remove_dead_node(phi1); // Remove new phi | |
| 1120 assert( hit1->is_Phi(), "" ); | |
| 1121 phi1 = (PhiNode*)hit1; // Use existing phi | |
| 1122 } else { // Miss | |
| 1123 _igvn.register_new_node_with_optimizer(phi1); | |
| 1124 } | |
| 1125 Node *hit2 = _igvn.hash_find_insert(phi2); | |
| 1126 if( hit2 ) { // Hit, toss just made Phi | |
| 1127 _igvn.remove_dead_node(phi2); // Remove new phi | |
| 1128 assert( hit2->is_Phi(), "" ); | |
| 1129 phi2 = (PhiNode*)hit2; // Use existing phi | |
| 1130 } else { // Miss | |
| 1131 _igvn.register_new_node_with_optimizer(phi2); | |
| 1132 } | |
| 1133 // Register Phis with loop/block info | |
| 1134 set_ctrl(phi1, phi->in(0)); | |
| 1135 set_ctrl(phi2, phi->in(0)); | |
| 1136 // Make a new Cmp | |
| 1137 Node *cmp = sample_cmp->clone(); | |
| 1138 cmp->set_req( 1, phi1 ); | |
| 1139 cmp->set_req( 2, phi2 ); | |
| 1140 _igvn.register_new_node_with_optimizer(cmp); | |
| 1141 set_ctrl(cmp, phi->in(0)); | |
| 1142 | |
| 1143 // Make a new Bool | |
| 1144 Node *b = sample_bool->clone(); | |
| 1145 b->set_req(1,cmp); | |
| 1146 _igvn.register_new_node_with_optimizer(b); | |
| 1147 set_ctrl(b, phi->in(0)); | |
| 1148 | |
| 1149 assert( b->is_Bool(), "" ); | |
| 1150 return (BoolNode*)b; | |
| 1151 } | |
| 1152 | |
| 1153 //------------------------------clone_bool------------------------------------- | |
| 1154 // Passed in a Phi merging (recursively) some nearly equivalent Bool/Cmps. | |
| 1155 // "Nearly" because all Nodes have been cloned from the original in the loop, | |
| 1156 // but the fall-in edges to the Cmp are different. Clone bool/Cmp pairs | |
| 1157 // through the Phi recursively, and return a Bool. | |
| 1158 CmpNode *PhaseIdealLoop::clone_bool( PhiNode *phi, IdealLoopTree *loop ) { | |
| 1159 uint i; | |
| 1160 // Convert this Phi into a Phi merging Bools | |
| 1161 for( i = 1; i < phi->req(); i++ ) { | |
| 1162 Node *b = phi->in(i); | |
| 1163 if( b->is_Phi() ) { | |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1164 _igvn.replace_input_of(phi, i, clone_bool( b->as_Phi(), loop )); |
| 0 | 1165 } else { |
| 1166 assert( b->is_Cmp() || b->is_top(), "inputs are all Cmp or TOP" ); | |
| 1167 } | |
| 1168 } | |
| 1169 | |
| 1170 Node *sample_cmp = phi->in(1); | |
| 1171 | |
| 1172 // Make Phis to merge the Cmp's inputs. | |
|
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
1173 PhiNode *phi1 = new (C) PhiNode( phi->in(0), Type::TOP ); |
|
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
1174 PhiNode *phi2 = new (C) PhiNode( phi->in(0), Type::TOP ); |
| 0 | 1175 for( uint j = 1; j < phi->req(); j++ ) { |
| 1176 Node *cmp_top = phi->in(j); // Inputs are all Cmp or TOP | |
| 1177 Node *n1, *n2; | |
| 1178 if( cmp_top->is_Cmp() ) { | |
| 1179 n1 = cmp_top->in(1); | |
| 1180 n2 = cmp_top->in(2); | |
| 1181 } else { | |
| 1182 n1 = n2 = cmp_top; | |
| 1183 } | |
| 1184 phi1->set_req( j, n1 ); | |
| 1185 phi2->set_req( j, n2 ); | |
|
17671
de95063c0e34
8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed
roland
parents:
17467
diff
changeset
|
1186 phi1->set_type(phi1->type()->meet_speculative(n1->bottom_type())); |
|
de95063c0e34
8027422: assert(_gvn.type(obj)->higher_equal(tjp)) failed: cast_up is no longer needed
roland
parents:
17467
diff
changeset
|
1187 phi2->set_type(phi2->type()->meet_speculative(n2->bottom_type())); |
| 0 | 1188 } |
| 1189 | |
| 1190 // See if these Phis have been made before. | |
| 1191 // Register with optimizer | |
| 1192 Node *hit1 = _igvn.hash_find_insert(phi1); | |
| 1193 if( hit1 ) { // Hit, toss just made Phi | |
| 1194 _igvn.remove_dead_node(phi1); // Remove new phi | |
| 1195 assert( hit1->is_Phi(), "" ); | |
| 1196 phi1 = (PhiNode*)hit1; // Use existing phi | |
| 1197 } else { // Miss | |
| 1198 _igvn.register_new_node_with_optimizer(phi1); | |
| 1199 } | |
| 1200 Node *hit2 = _igvn.hash_find_insert(phi2); | |
| 1201 if( hit2 ) { // Hit, toss just made Phi | |
| 1202 _igvn.remove_dead_node(phi2); // Remove new phi | |
| 1203 assert( hit2->is_Phi(), "" ); | |
| 1204 phi2 = (PhiNode*)hit2; // Use existing phi | |
| 1205 } else { // Miss | |
| 1206 _igvn.register_new_node_with_optimizer(phi2); | |
| 1207 } | |
| 1208 // Register Phis with loop/block info | |
| 1209 set_ctrl(phi1, phi->in(0)); | |
| 1210 set_ctrl(phi2, phi->in(0)); | |
| 1211 // Make a new Cmp | |
| 1212 Node *cmp = sample_cmp->clone(); | |
| 1213 cmp->set_req( 1, phi1 ); | |
| 1214 cmp->set_req( 2, phi2 ); | |
| 1215 _igvn.register_new_node_with_optimizer(cmp); | |
| 1216 set_ctrl(cmp, phi->in(0)); | |
| 1217 | |
| 1218 assert( cmp->is_Cmp(), "" ); | |
| 1219 return (CmpNode*)cmp; | |
| 1220 } | |
| 1221 | |
| 1222 //------------------------------sink_use--------------------------------------- | |
| 1223 // If 'use' was in the loop-exit block, it now needs to be sunk | |
| 1224 // below the post-loop merge point. | |
| 1225 void PhaseIdealLoop::sink_use( Node *use, Node *post_loop ) { | |
| 1226 if (!use->is_CFG() && get_ctrl(use) == post_loop->in(2)) { | |
| 1227 set_ctrl(use, post_loop); | |
| 1228 for (DUIterator j = use->outs(); use->has_out(j); j++) | |
| 1229 sink_use(use->out(j), post_loop); | |
| 1230 } | |
| 1231 } | |
| 1232 | |
| 1233 //------------------------------clone_loop------------------------------------- | |
| 1234 // | |
| 1235 // C L O N E A L O O P B O D Y | |
| 1236 // | |
| 1237 // This is the basic building block of the loop optimizations. It clones an | |
| 1238 // entire loop body. It makes an old_new loop body mapping; with this mapping | |
| 1239 // you can find the new-loop equivalent to an old-loop node. All new-loop | |
| 1240 // nodes are exactly equal to their old-loop counterparts, all edges are the | |
| 1241 // same. All exits from the old-loop now have a RegionNode that merges the | |
| 1242 // equivalent new-loop path. This is true even for the normal "loop-exit" | |
| 1243 // condition. All uses of loop-invariant old-loop values now come from (one | |
| 1244 // or more) Phis that merge their new-loop equivalents. | |
| 1245 // | |
| 1246 // This operation leaves the graph in an illegal state: there are two valid | |
| 1247 // control edges coming from the loop pre-header to both loop bodies. I'll | |
| 1248 // definitely have to hack the graph after running this transform. | |
| 1249 // | |
| 1250 // From this building block I will further edit edges to perform loop peeling | |
| 1251 // or loop unrolling or iteration splitting (Range-Check-Elimination), etc. | |
| 1252 // | |
| 1253 // Parameter side_by_size_idom: | |
| 1254 // When side_by_size_idom is NULL, the dominator tree is constructed for | |
| 1255 // the clone loop to dominate the original. Used in construction of | |
| 1256 // pre-main-post loop sequence. | |
| 1257 // When nonnull, the clone and original are side-by-side, both are | |
| 1258 // dominated by the side_by_side_idom node. Used in construction of | |
| 1259 // unswitched loops. | |
| 1260 void PhaseIdealLoop::clone_loop( IdealLoopTree *loop, Node_List &old_new, int dd, | |
| 1261 Node* side_by_side_idom) { | |
| 1262 | |
| 1263 // Step 1: Clone the loop body. Make the old->new mapping. | |
| 1264 uint i; | |
| 1265 for( i = 0; i < loop->_body.size(); i++ ) { | |
| 1266 Node *old = loop->_body.at(i); | |
| 1267 Node *nnn = old->clone(); | |
| 1268 old_new.map( old->_idx, nnn ); | |
| 1269 _igvn.register_new_node_with_optimizer(nnn); | |
| 1270 } | |
| 1271 | |
| 1272 | |
| 1273 // Step 2: Fix the edges in the new body. If the old input is outside the | |
| 1274 // loop use it. If the old input is INside the loop, use the corresponding | |
| 1275 // new node instead. | |
| 1276 for( i = 0; i < loop->_body.size(); i++ ) { | |
| 1277 Node *old = loop->_body.at(i); | |
| 1278 Node *nnn = old_new[old->_idx]; | |
| 1279 // Fix CFG/Loop controlling the new node | |
| 1280 if (has_ctrl(old)) { | |
| 1281 set_ctrl(nnn, old_new[get_ctrl(old)->_idx]); | |
| 1282 } else { | |
| 1283 set_loop(nnn, loop->_parent); | |
| 1284 if (old->outcnt() > 0) { | |
| 1285 set_idom( nnn, old_new[idom(old)->_idx], dd ); | |
| 1286 } | |
| 1287 } | |
| 1288 // Correct edges to the new node | |
| 1289 for( uint j = 0; j < nnn->req(); j++ ) { | |
| 1290 Node *n = nnn->in(j); | |
| 1291 if( n ) { | |
| 1292 IdealLoopTree *old_in_loop = get_loop( has_ctrl(n) ? get_ctrl(n) : n ); | |
| 1293 if( loop->is_member( old_in_loop ) ) | |
| 1294 nnn->set_req(j, old_new[n->_idx]); | |
| 1295 } | |
| 1296 } | |
| 1297 _igvn.hash_find_insert(nnn); | |
| 1298 } | |
| 1299 Node *newhead = old_new[loop->_head->_idx]; | |
| 1300 set_idom(newhead, newhead->in(LoopNode::EntryControl), dd); | |
| 1301 | |
| 1302 | |
| 1303 // Step 3: Now fix control uses. Loop varying control uses have already | |
| 1304 // been fixed up (as part of all input edges in Step 2). Loop invariant | |
| 1305 // control uses must be either an IfFalse or an IfTrue. Make a merge | |
| 1306 // point to merge the old and new IfFalse/IfTrue nodes; make the use | |
| 1307 // refer to this. | |
| 1308 ResourceArea *area = Thread::current()->resource_area(); | |
| 1309 Node_List worklist(area); | |
| 1310 uint new_counter = C->unique(); | |
| 1311 for( i = 0; i < loop->_body.size(); i++ ) { | |
| 1312 Node* old = loop->_body.at(i); | |
| 1313 if( !old->is_CFG() ) continue; | |
| 1314 Node* nnn = old_new[old->_idx]; | |
| 1315 | |
| 1316 // Copy uses to a worklist, so I can munge the def-use info | |
| 1317 // with impunity. | |
| 1318 for (DUIterator_Fast jmax, j = old->fast_outs(jmax); j < jmax; j++) | |
| 1319 worklist.push(old->fast_out(j)); | |
| 1320 | |
| 1321 while( worklist.size() ) { // Visit all uses | |
| 1322 Node *use = worklist.pop(); | |
| 1323 if (!has_node(use)) continue; // Ignore dead nodes | |
| 1324 IdealLoopTree *use_loop = get_loop( has_ctrl(use) ? get_ctrl(use) : use ); | |
| 1325 if( !loop->is_member( use_loop ) && use->is_CFG() ) { | |
| 1326 // Both OLD and USE are CFG nodes here. | |
| 1327 assert( use->is_Proj(), "" ); | |
| 1328 | |
| 1329 // Clone the loop exit control projection | |
| 1330 Node *newuse = use->clone(); | |
| 1331 newuse->set_req(0,nnn); | |
| 1332 _igvn.register_new_node_with_optimizer(newuse); | |
| 1333 set_loop(newuse, use_loop); | |
| 1334 set_idom(newuse, nnn, dom_depth(nnn) + 1 ); | |
| 1335 | |
| 1336 // We need a Region to merge the exit from the peeled body and the | |
| 1337 // exit from the old loop body. | |
|
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
1338 RegionNode *r = new (C) RegionNode(3); |
| 0 | 1339 // Map the old use to the new merge point |
| 1340 old_new.map( use->_idx, r ); | |
| 1341 uint dd_r = MIN2(dom_depth(newuse),dom_depth(use)); | |
| 1342 assert( dd_r >= dom_depth(dom_lca(newuse,use)), "" ); | |
| 1343 | |
| 1344 // The original user of 'use' uses 'r' instead. | |
| 1345 for (DUIterator_Last lmin, l = use->last_outs(lmin); l >= lmin;) { | |
| 1346 Node* useuse = use->last_out(l); | |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1347 _igvn.rehash_node_delayed(useuse); |
| 0 | 1348 uint uses_found = 0; |
| 1349 if( useuse->in(0) == use ) { | |
| 1350 useuse->set_req(0, r); | |
| 1351 uses_found++; | |
| 1352 if( useuse->is_CFG() ) { | |
| 1353 assert( dom_depth(useuse) > dd_r, "" ); | |
| 1354 set_idom(useuse, r, dom_depth(useuse)); | |
| 1355 } | |
| 1356 } | |
| 1357 for( uint k = 1; k < useuse->req(); k++ ) { | |
| 1358 if( useuse->in(k) == use ) { | |
| 1359 useuse->set_req(k, r); | |
| 1360 uses_found++; | |
| 1361 } | |
| 1362 } | |
| 1363 l -= uses_found; // we deleted 1 or more copies of this edge | |
| 1364 } | |
| 1365 | |
| 1366 // Now finish up 'r' | |
| 1367 r->set_req( 1, newuse ); | |
| 1368 r->set_req( 2, use ); | |
| 1369 _igvn.register_new_node_with_optimizer(r); | |
| 1370 set_loop(r, use_loop); | |
| 1371 set_idom(r, !side_by_side_idom ? newuse->in(0) : side_by_side_idom, dd_r); | |
| 1372 } // End of if a loop-exit test | |
| 1373 } | |
| 1374 } | |
| 1375 | |
| 1376 // Step 4: If loop-invariant use is not control, it must be dominated by a | |
| 1377 // loop exit IfFalse/IfTrue. Find "proper" loop exit. Make a Region | |
| 1378 // there if needed. Make a Phi there merging old and new used values. | |
| 1379 Node_List *split_if_set = NULL; | |
| 1380 Node_List *split_bool_set = NULL; | |
| 1381 Node_List *split_cex_set = NULL; | |
| 1382 for( i = 0; i < loop->_body.size(); i++ ) { | |
| 1383 Node* old = loop->_body.at(i); | |
| 1384 Node* nnn = old_new[old->_idx]; | |
| 1385 // Copy uses to a worklist, so I can munge the def-use info | |
| 1386 // with impunity. | |
| 1387 for (DUIterator_Fast jmax, j = old->fast_outs(jmax); j < jmax; j++) | |
| 1388 worklist.push(old->fast_out(j)); | |
| 1389 | |
| 1390 while( worklist.size() ) { | |
| 1391 Node *use = worklist.pop(); | |
| 1392 if (!has_node(use)) continue; // Ignore dead nodes | |
| 1393 if (use->in(0) == C->top()) continue; | |
| 1394 IdealLoopTree *use_loop = get_loop( has_ctrl(use) ? get_ctrl(use) : use ); | |
| 1395 // Check for data-use outside of loop - at least one of OLD or USE | |
| 1396 // must not be a CFG node. | |
| 1397 if( !loop->is_member( use_loop ) && (!old->is_CFG() || !use->is_CFG())) { | |
| 1398 | |
| 1399 // If the Data use is an IF, that means we have an IF outside of the | |
| 1400 // loop that is switching on a condition that is set inside of the | |
| 1401 // loop. Happens if people set a loop-exit flag; then test the flag | |
| 1402 // in the loop to break the loop, then test is again outside of the | |
| 1403 // loop to determine which way the loop exited. | |
| 1404 if( use->is_If() || use->is_CMove() ) { | |
| 1405 // Since this code is highly unlikely, we lazily build the worklist | |
| 1406 // of such Nodes to go split. | |
| 1407 if( !split_if_set ) | |
| 1408 split_if_set = new Node_List(area); | |
| 1409 split_if_set->push(use); | |
| 1410 } | |
| 1411 if( use->is_Bool() ) { | |
| 1412 if( !split_bool_set ) | |
| 1413 split_bool_set = new Node_List(area); | |
| 1414 split_bool_set->push(use); | |
| 1415 } | |
| 1416 if( use->Opcode() == Op_CreateEx ) { | |
| 1417 if( !split_cex_set ) | |
| 1418 split_cex_set = new Node_List(area); | |
| 1419 split_cex_set->push(use); | |
| 1420 } | |
| 1421 | |
| 1422 | |
| 1423 // Get "block" use is in | |
| 1424 uint idx = 0; | |
| 1425 while( use->in(idx) != old ) idx++; | |
| 1426 Node *prev = use->is_CFG() ? use : get_ctrl(use); | |
| 1427 assert( !loop->is_member( get_loop( prev ) ), "" ); | |
| 1428 Node *cfg = prev->_idx >= new_counter | |
| 1429 ? prev->in(2) | |
| 1430 : idom(prev); | |
| 1431 if( use->is_Phi() ) // Phi use is in prior block | |
| 1432 cfg = prev->in(idx); // NOT in block of Phi itself | |
| 1433 if (cfg->is_top()) { // Use is dead? | |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1434 _igvn.replace_input_of(use, idx, C->top()); |
| 0 | 1435 continue; |
| 1436 } | |
| 1437 | |
| 1438 while( !loop->is_member( get_loop( cfg ) ) ) { | |
| 1439 prev = cfg; | |
| 1440 cfg = cfg->_idx >= new_counter ? cfg->in(2) : idom(cfg); | |
| 1441 } | |
| 1442 // If the use occurs after merging several exits from the loop, then | |
| 1443 // old value must have dominated all those exits. Since the same old | |
| 1444 // value was used on all those exits we did not need a Phi at this | |
| 1445 // merge point. NOW we do need a Phi here. Each loop exit value | |
| 1446 // is now merged with the peeled body exit; each exit gets its own | |
| 1447 // private Phi and those Phis need to be merged here. | |
| 1448 Node *phi; | |
| 1449 if( prev->is_Region() ) { | |
| 1450 if( idx == 0 ) { // Updating control edge? | |
| 1451 phi = prev; // Just use existing control | |
| 1452 } else { // Else need a new Phi | |
| 1453 phi = PhiNode::make( prev, old ); | |
| 1454 // Now recursively fix up the new uses of old! | |
| 1455 for( uint i = 1; i < prev->req(); i++ ) { | |
| 1456 worklist.push(phi); // Onto worklist once for each 'old' input | |
| 1457 } | |
| 1458 } | |
| 1459 } else { | |
| 1460 // Get new RegionNode merging old and new loop exits | |
| 1461 prev = old_new[prev->_idx]; | |
| 1462 assert( prev, "just made this in step 7" ); | |
| 1463 if( idx == 0 ) { // Updating control edge? | |
| 1464 phi = prev; // Just use existing control | |
| 1465 } else { // Else need a new Phi | |
| 1466 // Make a new Phi merging data values properly | |
| 1467 phi = PhiNode::make( prev, old ); | |
| 1468 phi->set_req( 1, nnn ); | |
| 1469 } | |
| 1470 } | |
| 1471 // If inserting a new Phi, check for prior hits | |
| 1472 if( idx != 0 ) { | |
| 1473 Node *hit = _igvn.hash_find_insert(phi); | |
| 1474 if( hit == NULL ) { | |
| 1475 _igvn.register_new_node_with_optimizer(phi); // Register new phi | |
| 1476 } else { // or | |
| 1477 // Remove the new phi from the graph and use the hit | |
| 1478 _igvn.remove_dead_node(phi); | |
| 1479 phi = hit; // Use existing phi | |
| 1480 } | |
| 1481 set_ctrl(phi, prev); | |
| 1482 } | |
| 1483 // Make 'use' use the Phi instead of the old loop body exit value | |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1484 _igvn.replace_input_of(use, idx, phi); |
| 0 | 1485 if( use->_idx >= new_counter ) { // If updating new phis |
| 1486 // Not needed for correctness, but prevents a weak assert | |
| 1487 // in AddPNode from tripping (when we end up with different | |
| 1488 // base & derived Phis that will become the same after | |
| 1489 // IGVN does CSE). | |
| 1490 Node *hit = _igvn.hash_find_insert(use); | |
| 1491 if( hit ) // Go ahead and re-hash for hits. | |
|
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
1492 _igvn.replace_node( use, hit ); |
| 0 | 1493 } |
| 1494 | |
| 1495 // If 'use' was in the loop-exit block, it now needs to be sunk | |
| 1496 // below the post-loop merge point. | |
| 1497 sink_use( use, prev ); | |
| 1498 } | |
| 1499 } | |
| 1500 } | |
| 1501 | |
| 1502 // Check for IFs that need splitting/cloning. Happens if an IF outside of | |
| 1503 // the loop uses a condition set in the loop. The original IF probably | |
| 1504 // takes control from one or more OLD Regions (which in turn get from NEW | |
| 1505 // Regions). In any case, there will be a set of Phis for each merge point | |
| 1506 // from the IF up to where the original BOOL def exists the loop. | |
| 1507 if( split_if_set ) { | |
| 1508 while( split_if_set->size() ) { | |
| 1509 Node *iff = split_if_set->pop(); | |
| 1510 if( iff->in(1)->is_Phi() ) { | |
| 1511 BoolNode *b = clone_iff( iff->in(1)->as_Phi(), loop ); | |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1512 _igvn.replace_input_of(iff, 1, b); |
| 0 | 1513 } |
| 1514 } | |
| 1515 } | |
| 1516 if( split_bool_set ) { | |
| 1517 while( split_bool_set->size() ) { | |
| 1518 Node *b = split_bool_set->pop(); | |
| 1519 Node *phi = b->in(1); | |
| 1520 assert( phi->is_Phi(), "" ); | |
| 1521 CmpNode *cmp = clone_bool( (PhiNode*)phi, loop ); | |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1522 _igvn.replace_input_of(b, 1, cmp); |
| 0 | 1523 } |
| 1524 } | |
| 1525 if( split_cex_set ) { | |
| 1526 while( split_cex_set->size() ) { | |
| 1527 Node *b = split_cex_set->pop(); | |
| 1528 assert( b->in(0)->is_Region(), "" ); | |
| 1529 assert( b->in(1)->is_Phi(), "" ); | |
| 1530 assert( b->in(0)->in(0) == b->in(1)->in(0), "" ); | |
| 1531 split_up( b, b->in(0), NULL ); | |
| 1532 } | |
| 1533 } | |
| 1534 | |
| 1535 } | |
| 1536 | |
| 1537 | |
| 1538 //---------------------- stride_of_possible_iv ------------------------------------- | |
| 1539 // Looks for an iff/bool/comp with one operand of the compare | |
| 1540 // being a cycle involving an add and a phi, | |
| 1541 // with an optional truncation (left-shift followed by a right-shift) | |
| 1542 // of the add. Returns zero if not an iv. | |
| 1543 int PhaseIdealLoop::stride_of_possible_iv(Node* iff) { | |
| 1544 Node* trunc1 = NULL; | |
| 1545 Node* trunc2 = NULL; | |
| 1546 const TypeInt* ttype = NULL; | |
| 1547 if (!iff->is_If() || iff->in(1) == NULL || !iff->in(1)->is_Bool()) { | |
| 1548 return 0; | |
| 1549 } | |
| 1550 BoolNode* bl = iff->in(1)->as_Bool(); | |
| 1551 Node* cmp = bl->in(1); | |
| 1552 if (!cmp || cmp->Opcode() != Op_CmpI && cmp->Opcode() != Op_CmpU) { | |
| 1553 return 0; | |
| 1554 } | |
| 1555 // Must have an invariant operand | |
| 1556 if (is_member(get_loop(iff), get_ctrl(cmp->in(2)))) { | |
| 1557 return 0; | |
| 1558 } | |
| 1559 Node* add2 = NULL; | |
| 1560 Node* cmp1 = cmp->in(1); | |
| 1561 if (cmp1->is_Phi()) { | |
| 1562 // (If (Bool (CmpX phi:(Phi ...(Optional-trunc(AddI phi add2))) ))) | |
| 1563 Node* phi = cmp1; | |
| 1564 for (uint i = 1; i < phi->req(); i++) { | |
| 1565 Node* in = phi->in(i); | |
| 1566 Node* add = CountedLoopNode::match_incr_with_optional_truncation(in, | |
| 1567 &trunc1, &trunc2, &ttype); | |
| 1568 if (add && add->in(1) == phi) { | |
| 1569 add2 = add->in(2); | |
| 1570 break; | |
| 1571 } | |
| 1572 } | |
| 1573 } else { | |
| 1574 // (If (Bool (CmpX addtrunc:(Optional-trunc((AddI (Phi ...addtrunc...) add2)) ))) | |
| 1575 Node* addtrunc = cmp1; | |
| 1576 Node* add = CountedLoopNode::match_incr_with_optional_truncation(addtrunc, | |
| 1577 &trunc1, &trunc2, &ttype); | |
| 1578 if (add && add->in(1)->is_Phi()) { | |
| 1579 Node* phi = add->in(1); | |
| 1580 for (uint i = 1; i < phi->req(); i++) { | |
| 1581 if (phi->in(i) == addtrunc) { | |
| 1582 add2 = add->in(2); | |
| 1583 break; | |
| 1584 } | |
| 1585 } | |
| 1586 } | |
| 1587 } | |
| 1588 if (add2 != NULL) { | |
| 1589 const TypeInt* add2t = _igvn.type(add2)->is_int(); | |
| 1590 if (add2t->is_con()) { | |
| 1591 return add2t->get_con(); | |
| 1592 } | |
| 1593 } | |
| 1594 return 0; | |
| 1595 } | |
| 1596 | |
| 1597 | |
| 1598 //---------------------- stay_in_loop ------------------------------------- | |
| 1599 // Return the (unique) control output node that's in the loop (if it exists.) | |
| 1600 Node* PhaseIdealLoop::stay_in_loop( Node* n, IdealLoopTree *loop) { | |
| 1601 Node* unique = NULL; | |
| 1602 if (!n) return NULL; | |
| 1603 for (DUIterator_Fast imax, i = n->fast_outs(imax); i < imax; i++) { | |
| 1604 Node* use = n->fast_out(i); | |
| 1605 if (!has_ctrl(use) && loop->is_member(get_loop(use))) { | |
| 1606 if (unique != NULL) { | |
| 1607 return NULL; | |
| 1608 } | |
| 1609 unique = use; | |
| 1610 } | |
| 1611 } | |
| 1612 return unique; | |
| 1613 } | |
| 1614 | |
| 1615 //------------------------------ register_node ------------------------------------- | |
| 1616 // Utility to register node "n" with PhaseIdealLoop | |
| 1617 void PhaseIdealLoop::register_node(Node* n, IdealLoopTree *loop, Node* pred, int ddepth) { | |
| 1618 _igvn.register_new_node_with_optimizer(n); | |
| 1619 loop->_body.push(n); | |
| 1620 if (n->is_CFG()) { | |
| 1621 set_loop(n, loop); | |
| 1622 set_idom(n, pred, ddepth); | |
| 1623 } else { | |
| 1624 set_ctrl(n, pred); | |
| 1625 } | |
| 1626 } | |
| 1627 | |
| 1628 //------------------------------ proj_clone ------------------------------------- | |
| 1629 // Utility to create an if-projection | |
| 1630 ProjNode* PhaseIdealLoop::proj_clone(ProjNode* p, IfNode* iff) { | |
| 1631 ProjNode* c = p->clone()->as_Proj(); | |
| 1632 c->set_req(0, iff); | |
| 1633 return c; | |
| 1634 } | |
| 1635 | |
| 1636 //------------------------------ short_circuit_if ------------------------------------- | |
| 1637 // Force the iff control output to be the live_proj | |
| 1638 Node* PhaseIdealLoop::short_circuit_if(IfNode* iff, ProjNode* live_proj) { | |
|
8774
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
1639 guarantee(live_proj != NULL, "null projection"); |
| 0 | 1640 int proj_con = live_proj->_con; |
| 1641 assert(proj_con == 0 || proj_con == 1, "false or true projection"); | |
| 1642 Node *con = _igvn.intcon(proj_con); | |
| 1643 set_ctrl(con, C->root()); | |
| 1644 if (iff) { | |
| 1645 iff->set_req(1, con); | |
| 1646 } | |
| 1647 return con; | |
| 1648 } | |
| 1649 | |
| 1650 //------------------------------ insert_if_before_proj ------------------------------------- | |
| 1651 // Insert a new if before an if projection (* - new node) | |
| 1652 // | |
| 1653 // before | |
| 1654 // if(test) | |
| 1655 // / \ | |
| 1656 // v v | |
| 1657 // other-proj proj (arg) | |
| 1658 // | |
| 1659 // after | |
| 1660 // if(test) | |
| 1661 // / \ | |
| 1662 // / v | |
| 1663 // | * proj-clone | |
| 1664 // v | | |
| 1665 // other-proj v | |
| 1666 // * new_if(relop(cmp[IU](left,right))) | |
| 1667 // / \ | |
| 1668 // v v | |
| 1669 // * new-proj proj | |
| 1670 // (returned) | |
| 1671 // | |
| 1672 ProjNode* PhaseIdealLoop::insert_if_before_proj(Node* left, bool Signed, BoolTest::mask relop, Node* right, ProjNode* proj) { | |
| 1673 IfNode* iff = proj->in(0)->as_If(); | |
| 1674 IdealLoopTree *loop = get_loop(proj); | |
| 1675 ProjNode *other_proj = iff->proj_out(!proj->is_IfTrue())->as_Proj(); | |
| 1676 int ddepth = dom_depth(proj); | |
| 1677 | |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1678 _igvn.rehash_node_delayed(iff); |
|
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1679 _igvn.rehash_node_delayed(proj); |
| 0 | 1680 |
| 1681 proj->set_req(0, NULL); // temporary disconnect | |
| 1682 ProjNode* proj2 = proj_clone(proj, iff); | |
| 1683 register_node(proj2, loop, iff, ddepth); | |
| 1684 | |
|
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
1685 Node* cmp = Signed ? (Node*) new (C)CmpINode(left, right) : (Node*) new (C)CmpUNode(left, right); |
| 0 | 1686 register_node(cmp, loop, proj2, ddepth); |
| 1687 | |
|
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
1688 BoolNode* bol = new (C)BoolNode(cmp, relop); |
| 0 | 1689 register_node(bol, loop, proj2, ddepth); |
| 1690 | |
|
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
1691 IfNode* new_if = new (C)IfNode(proj2, bol, iff->_prob, iff->_fcnt); |
| 0 | 1692 register_node(new_if, loop, proj2, ddepth); |
| 1693 | |
| 1694 proj->set_req(0, new_if); // reattach | |
| 1695 set_idom(proj, new_if, ddepth); | |
| 1696 | |
| 1697 ProjNode* new_exit = proj_clone(other_proj, new_if)->as_Proj(); | |
|
8774
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
1698 guarantee(new_exit != NULL, "null exit node"); |
| 0 | 1699 register_node(new_exit, get_loop(other_proj), new_if, ddepth); |
| 1700 | |
| 1701 return new_exit; | |
| 1702 } | |
| 1703 | |
| 1704 //------------------------------ insert_region_before_proj ------------------------------------- | |
| 1705 // Insert a region before an if projection (* - new node) | |
| 1706 // | |
| 1707 // before | |
| 1708 // if(test) | |
| 1709 // / | | |
| 1710 // v | | |
| 1711 // proj v | |
| 1712 // other-proj | |
| 1713 // | |
| 1714 // after | |
| 1715 // if(test) | |
| 1716 // / | | |
| 1717 // v | | |
| 1718 // * proj-clone v | |
| 1719 // | other-proj | |
| 1720 // v | |
| 1721 // * new-region | |
| 1722 // | | |
| 1723 // v | |
| 1724 // * dum_if | |
| 1725 // / \ | |
| 1726 // v \ | |
| 1727 // * dum-proj v | |
| 1728 // proj | |
| 1729 // | |
| 1730 RegionNode* PhaseIdealLoop::insert_region_before_proj(ProjNode* proj) { | |
| 1731 IfNode* iff = proj->in(0)->as_If(); | |
| 1732 IdealLoopTree *loop = get_loop(proj); | |
| 1733 ProjNode *other_proj = iff->proj_out(!proj->is_IfTrue())->as_Proj(); | |
| 1734 int ddepth = dom_depth(proj); | |
| 1735 | |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1736 _igvn.rehash_node_delayed(iff); |
|
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1737 _igvn.rehash_node_delayed(proj); |
| 0 | 1738 |
| 1739 proj->set_req(0, NULL); // temporary disconnect | |
| 1740 ProjNode* proj2 = proj_clone(proj, iff); | |
| 1741 register_node(proj2, loop, iff, ddepth); | |
| 1742 | |
|
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
1743 RegionNode* reg = new (C)RegionNode(2); |
| 0 | 1744 reg->set_req(1, proj2); |
| 1745 register_node(reg, loop, iff, ddepth); | |
| 1746 | |
|
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
1747 IfNode* dum_if = new (C)IfNode(reg, short_circuit_if(NULL, proj), iff->_prob, iff->_fcnt); |
| 0 | 1748 register_node(dum_if, loop, reg, ddepth); |
| 1749 | |
| 1750 proj->set_req(0, dum_if); // reattach | |
| 1751 set_idom(proj, dum_if, ddepth); | |
| 1752 | |
| 1753 ProjNode* dum_proj = proj_clone(other_proj, dum_if); | |
| 1754 register_node(dum_proj, loop, dum_if, ddepth); | |
| 1755 | |
| 1756 return reg; | |
| 1757 } | |
| 1758 | |
| 1759 //------------------------------ insert_cmpi_loop_exit ------------------------------------- | |
| 1760 // Clone a signed compare loop exit from an unsigned compare and | |
| 1761 // insert it before the unsigned cmp on the stay-in-loop path. | |
| 1762 // All new nodes inserted in the dominator tree between the original | |
| 1763 // if and it's projections. The original if test is replaced with | |
| 1764 // a constant to force the stay-in-loop path. | |
| 1765 // | |
| 1766 // This is done to make sure that the original if and it's projections | |
| 1767 // still dominate the same set of control nodes, that the ctrl() relation | |
| 1768 // from data nodes to them is preserved, and that their loop nesting is | |
| 1769 // preserved. | |
| 1770 // | |
| 1771 // before | |
| 1772 // if(i <u limit) unsigned compare loop exit | |
| 1773 // / | | |
| 1774 // v v | |
| 1775 // exit-proj stay-in-loop-proj | |
| 1776 // | |
| 1777 // after | |
| 1778 // if(stay-in-loop-const) original if | |
| 1779 // / | | |
| 1780 // / v | |
| 1781 // / if(i < limit) new signed test | |
| 1782 // / / | | |
| 1783 // / / v | |
| 1784 // / / if(i <u limit) new cloned unsigned test | |
| 1785 // / / / | | |
| 1786 // v v v | | |
| 1787 // region | | |
| 1788 // | | | |
| 1789 // dum-if | | |
| 1790 // / | | | |
| 1791 // ether | | | |
| 1792 // v v | |
| 1793 // exit-proj stay-in-loop-proj | |
| 1794 // | |
| 1795 IfNode* PhaseIdealLoop::insert_cmpi_loop_exit(IfNode* if_cmpu, IdealLoopTree *loop) { | |
| 1796 const bool Signed = true; | |
| 1797 const bool Unsigned = false; | |
| 1798 | |
| 1799 BoolNode* bol = if_cmpu->in(1)->as_Bool(); | |
| 1800 if (bol->_test._test != BoolTest::lt) return NULL; | |
| 1801 CmpNode* cmpu = bol->in(1)->as_Cmp(); | |
| 1802 if (cmpu->Opcode() != Op_CmpU) return NULL; | |
| 1803 int stride = stride_of_possible_iv(if_cmpu); | |
| 1804 if (stride == 0) return NULL; | |
| 1805 | |
|
8774
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
1806 Node* lp_proj = stay_in_loop(if_cmpu, loop); |
|
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
1807 guarantee(lp_proj != NULL, "null loop node"); |
|
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
1808 |
|
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
1809 ProjNode* lp_continue = lp_proj->as_Proj(); |
| 0 | 1810 ProjNode* lp_exit = if_cmpu->proj_out(!lp_continue->is_IfTrue())->as_Proj(); |
| 1811 | |
| 1812 Node* limit = NULL; | |
| 1813 if (stride > 0) { | |
| 1814 limit = cmpu->in(2); | |
| 1815 } else { | |
| 1816 limit = _igvn.makecon(TypeInt::ZERO); | |
| 1817 set_ctrl(limit, C->root()); | |
| 1818 } | |
| 1819 // Create a new region on the exit path | |
| 1820 RegionNode* reg = insert_region_before_proj(lp_exit); | |
|
8774
3b9368710f08
8008811: [parfait] Null pointer deference in hotspot/src/share/vm/opto/loopopts.cpp
morris
parents:
7196
diff
changeset
|
1821 guarantee(reg != NULL, "null region node"); |
| 0 | 1822 |
| 1823 // Clone the if-cmpu-true-false using a signed compare | |
| 1824 BoolTest::mask rel_i = stride > 0 ? bol->_test._test : BoolTest::ge; | |
| 1825 ProjNode* cmpi_exit = insert_if_before_proj(cmpu->in(1), Signed, rel_i, limit, lp_continue); | |
| 1826 reg->add_req(cmpi_exit); | |
| 1827 | |
| 1828 // Clone the if-cmpu-true-false | |
| 1829 BoolTest::mask rel_u = bol->_test._test; | |
| 1830 ProjNode* cmpu_exit = insert_if_before_proj(cmpu->in(1), Unsigned, rel_u, cmpu->in(2), lp_continue); | |
| 1831 reg->add_req(cmpu_exit); | |
| 1832 | |
| 1833 // Force original if to stay in loop. | |
| 1834 short_circuit_if(if_cmpu, lp_continue); | |
| 1835 | |
| 1836 return cmpi_exit->in(0)->as_If(); | |
| 1837 } | |
| 1838 | |
| 1839 //------------------------------ remove_cmpi_loop_exit ------------------------------------- | |
| 1840 // Remove a previously inserted signed compare loop exit. | |
| 1841 void PhaseIdealLoop::remove_cmpi_loop_exit(IfNode* if_cmp, IdealLoopTree *loop) { | |
| 1842 Node* lp_proj = stay_in_loop(if_cmp, loop); | |
| 1843 assert(if_cmp->in(1)->in(1)->Opcode() == Op_CmpI && | |
| 1844 stay_in_loop(lp_proj, loop)->is_If() && | |
| 1845 stay_in_loop(lp_proj, loop)->in(1)->in(1)->Opcode() == Op_CmpU, "inserted cmpi before cmpu"); | |
| 1846 Node *con = _igvn.makecon(lp_proj->is_IfTrue() ? TypeInt::ONE : TypeInt::ZERO); | |
| 1847 set_ctrl(con, C->root()); | |
| 1848 if_cmp->set_req(1, con); | |
| 1849 } | |
| 1850 | |
| 1851 //------------------------------ scheduled_nodelist ------------------------------------- | |
| 1852 // Create a post order schedule of nodes that are in the | |
| 1853 // "member" set. The list is returned in "sched". | |
| 1854 // The first node in "sched" is the loop head, followed by | |
| 1855 // nodes which have no inputs in the "member" set, and then | |
| 1856 // followed by the nodes that have an immediate input dependence | |
| 1857 // on a node in "sched". | |
| 1858 void PhaseIdealLoop::scheduled_nodelist( IdealLoopTree *loop, VectorSet& member, Node_List &sched ) { | |
| 1859 | |
| 1860 assert(member.test(loop->_head->_idx), "loop head must be in member set"); | |
| 1861 Arena *a = Thread::current()->resource_area(); | |
| 1862 VectorSet visited(a); | |
| 1863 Node_Stack nstack(a, loop->_body.size()); | |
| 1864 | |
| 1865 Node* n = loop->_head; // top of stack is cached in "n" | |
| 1866 uint idx = 0; | |
| 1867 visited.set(n->_idx); | |
| 1868 | |
| 1869 // Initially push all with no inputs from within member set | |
| 1870 for(uint i = 0; i < loop->_body.size(); i++ ) { | |
| 1871 Node *elt = loop->_body.at(i); | |
| 1872 if (member.test(elt->_idx)) { | |
| 1873 bool found = false; | |
| 1874 for (uint j = 0; j < elt->req(); j++) { | |
| 1875 Node* def = elt->in(j); | |
| 1876 if (def && member.test(def->_idx) && def != elt) { | |
| 1877 found = true; | |
| 1878 break; | |
| 1879 } | |
| 1880 } | |
| 1881 if (!found && elt != loop->_head) { | |
| 1882 nstack.push(n, idx); | |
| 1883 n = elt; | |
| 1884 assert(!visited.test(n->_idx), "not seen yet"); | |
| 1885 visited.set(n->_idx); | |
| 1886 } | |
| 1887 } | |
| 1888 } | |
| 1889 | |
| 1890 // traverse out's that are in the member set | |
| 1891 while (true) { | |
| 1892 if (idx < n->outcnt()) { | |
| 1893 Node* use = n->raw_out(idx); | |
| 1894 idx++; | |
| 1895 if (!visited.test_set(use->_idx)) { | |
| 1896 if (member.test(use->_idx)) { | |
| 1897 nstack.push(n, idx); | |
| 1898 n = use; | |
| 1899 idx = 0; | |
| 1900 } | |
| 1901 } | |
| 1902 } else { | |
| 1903 // All outputs processed | |
| 1904 sched.push(n); | |
| 1905 if (nstack.is_empty()) break; | |
| 1906 n = nstack.node(); | |
| 1907 idx = nstack.index(); | |
| 1908 nstack.pop(); | |
| 1909 } | |
| 1910 } | |
| 1911 } | |
| 1912 | |
| 1913 | |
| 1914 //------------------------------ has_use_in_set ------------------------------------- | |
| 1915 // Has a use in the vector set | |
| 1916 bool PhaseIdealLoop::has_use_in_set( Node* n, VectorSet& vset ) { | |
| 1917 for (DUIterator_Fast jmax, j = n->fast_outs(jmax); j < jmax; j++) { | |
| 1918 Node* use = n->fast_out(j); | |
| 1919 if (vset.test(use->_idx)) { | |
| 1920 return true; | |
| 1921 } | |
| 1922 } | |
| 1923 return false; | |
| 1924 } | |
| 1925 | |
| 1926 | |
| 1927 //------------------------------ has_use_internal_to_set ------------------------------------- | |
| 1928 // Has use internal to the vector set (ie. not in a phi at the loop head) | |
| 1929 bool PhaseIdealLoop::has_use_internal_to_set( Node* n, VectorSet& vset, IdealLoopTree *loop ) { | |
| 1930 Node* head = loop->_head; | |
| 1931 for (DUIterator_Fast jmax, j = n->fast_outs(jmax); j < jmax; j++) { | |
| 1932 Node* use = n->fast_out(j); | |
| 1933 if (vset.test(use->_idx) && !(use->is_Phi() && use->in(0) == head)) { | |
| 1934 return true; | |
| 1935 } | |
| 1936 } | |
| 1937 return false; | |
| 1938 } | |
| 1939 | |
| 1940 | |
| 1941 //------------------------------ clone_for_use_outside_loop ------------------------------------- | |
| 1942 // clone "n" for uses that are outside of loop | |
|
10322
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
1943 int PhaseIdealLoop::clone_for_use_outside_loop( IdealLoopTree *loop, Node* n, Node_List& worklist ) { |
|
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
1944 int cloned = 0; |
| 0 | 1945 assert(worklist.size() == 0, "should be empty"); |
| 1946 for (DUIterator_Fast jmax, j = n->fast_outs(jmax); j < jmax; j++) { | |
| 1947 Node* use = n->fast_out(j); | |
| 1948 if( !loop->is_member(get_loop(has_ctrl(use) ? get_ctrl(use) : use)) ) { | |
| 1949 worklist.push(use); | |
| 1950 } | |
| 1951 } | |
| 1952 while( worklist.size() ) { | |
| 1953 Node *use = worklist.pop(); | |
| 1954 if (!has_node(use) || use->in(0) == C->top()) continue; | |
| 1955 uint j; | |
| 1956 for (j = 0; j < use->req(); j++) { | |
| 1957 if (use->in(j) == n) break; | |
| 1958 } | |
| 1959 assert(j < use->req(), "must be there"); | |
| 1960 | |
| 1961 // clone "n" and insert it between the inputs of "n" and the use outside the loop | |
| 1962 Node* n_clone = n->clone(); | |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
1963 _igvn.replace_input_of(use, j, n_clone); |
|
10322
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
1964 cloned++; |
| 251 | 1965 Node* use_c; |
| 0 | 1966 if (!use->is_Phi()) { |
| 251 | 1967 use_c = has_ctrl(use) ? get_ctrl(use) : use->in(0); |
| 0 | 1968 } else { |
| 1969 // Use in a phi is considered a use in the associated predecessor block | |
| 251 | 1970 use_c = use->in(0)->in(j); |
| 0 | 1971 } |
| 251 | 1972 set_ctrl(n_clone, use_c); |
| 1973 assert(!loop->is_member(get_loop(use_c)), "should be outside loop"); | |
| 1974 get_loop(use_c)->_body.push(n_clone); | |
| 0 | 1975 _igvn.register_new_node_with_optimizer(n_clone); |
| 1976 #if !defined(PRODUCT) | |
| 1977 if (TracePartialPeeling) { | |
| 1978 tty->print_cr("loop exit cloning old: %d new: %d newbb: %d", n->_idx, n_clone->_idx, get_ctrl(n_clone)->_idx); | |
| 1979 } | |
| 1980 #endif | |
| 1981 } | |
|
10322
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
1982 return cloned; |
| 0 | 1983 } |
| 1984 | |
| 1985 | |
| 1986 //------------------------------ clone_for_special_use_inside_loop ------------------------------------- | |
| 1987 // clone "n" for special uses that are in the not_peeled region. | |
| 1988 // If these def-uses occur in separate blocks, the code generator | |
| 1989 // marks the method as not compilable. For example, if a "BoolNode" | |
| 1990 // is in a different basic block than the "IfNode" that uses it, then | |
| 1991 // the compilation is aborted in the code generator. | |
| 1992 void PhaseIdealLoop::clone_for_special_use_inside_loop( IdealLoopTree *loop, Node* n, | |
| 1993 VectorSet& not_peel, Node_List& sink_list, Node_List& worklist ) { | |
| 1994 if (n->is_Phi() || n->is_Load()) { | |
| 1995 return; | |
| 1996 } | |
| 1997 assert(worklist.size() == 0, "should be empty"); | |
| 1998 for (DUIterator_Fast jmax, j = n->fast_outs(jmax); j < jmax; j++) { | |
| 1999 Node* use = n->fast_out(j); | |
| 2000 if ( not_peel.test(use->_idx) && | |
| 2001 (use->is_If() || use->is_CMove() || use->is_Bool()) && | |
| 2002 use->in(1) == n) { | |
| 2003 worklist.push(use); | |
| 2004 } | |
| 2005 } | |
| 2006 if (worklist.size() > 0) { | |
| 2007 // clone "n" and insert it between inputs of "n" and the use | |
| 2008 Node* n_clone = n->clone(); | |
| 2009 loop->_body.push(n_clone); | |
| 2010 _igvn.register_new_node_with_optimizer(n_clone); | |
| 2011 set_ctrl(n_clone, get_ctrl(n)); | |
| 2012 sink_list.push(n_clone); | |
| 2013 not_peel <<= n_clone->_idx; // add n_clone to not_peel set. | |
| 2014 #if !defined(PRODUCT) | |
| 2015 if (TracePartialPeeling) { | |
| 2016 tty->print_cr("special not_peeled cloning old: %d new: %d", n->_idx, n_clone->_idx); | |
| 2017 } | |
| 2018 #endif | |
| 2019 while( worklist.size() ) { | |
| 2020 Node *use = worklist.pop(); | |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2021 _igvn.rehash_node_delayed(use); |
| 0 | 2022 for (uint j = 1; j < use->req(); j++) { |
| 2023 if (use->in(j) == n) { | |
| 2024 use->set_req(j, n_clone); | |
| 2025 } | |
| 2026 } | |
| 2027 } | |
| 2028 } | |
| 2029 } | |
| 2030 | |
| 2031 | |
| 2032 //------------------------------ insert_phi_for_loop ------------------------------------- | |
| 2033 // Insert phi(lp_entry_val, back_edge_val) at use->in(idx) for loop lp if phi does not already exist | |
| 2034 void PhaseIdealLoop::insert_phi_for_loop( Node* use, uint idx, Node* lp_entry_val, Node* back_edge_val, LoopNode* lp ) { | |
| 2035 Node *phi = PhiNode::make(lp, back_edge_val); | |
| 2036 phi->set_req(LoopNode::EntryControl, lp_entry_val); | |
| 2037 // Use existing phi if it already exists | |
| 2038 Node *hit = _igvn.hash_find_insert(phi); | |
| 2039 if( hit == NULL ) { | |
| 2040 _igvn.register_new_node_with_optimizer(phi); | |
| 2041 set_ctrl(phi, lp); | |
| 2042 } else { | |
| 2043 // Remove the new phi from the graph and use the hit | |
| 2044 _igvn.remove_dead_node(phi); | |
| 2045 phi = hit; | |
| 2046 } | |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2047 _igvn.replace_input_of(use, idx, phi); |
| 0 | 2048 } |
| 2049 | |
| 2050 #ifdef ASSERT | |
| 2051 //------------------------------ is_valid_loop_partition ------------------------------------- | |
| 2052 // Validate the loop partition sets: peel and not_peel | |
| 2053 bool PhaseIdealLoop::is_valid_loop_partition( IdealLoopTree *loop, VectorSet& peel, Node_List& peel_list, | |
| 2054 VectorSet& not_peel ) { | |
| 2055 uint i; | |
| 2056 // Check that peel_list entries are in the peel set | |
| 2057 for (i = 0; i < peel_list.size(); i++) { | |
| 2058 if (!peel.test(peel_list.at(i)->_idx)) { | |
| 2059 return false; | |
| 2060 } | |
| 2061 } | |
| 2062 // Check at loop members are in one of peel set or not_peel set | |
| 2063 for (i = 0; i < loop->_body.size(); i++ ) { | |
| 2064 Node *def = loop->_body.at(i); | |
| 2065 uint di = def->_idx; | |
| 2066 // Check that peel set elements are in peel_list | |
| 2067 if (peel.test(di)) { | |
| 2068 if (not_peel.test(di)) { | |
| 2069 return false; | |
| 2070 } | |
| 2071 // Must be in peel_list also | |
| 2072 bool found = false; | |
| 2073 for (uint j = 0; j < peel_list.size(); j++) { | |
| 2074 if (peel_list.at(j)->_idx == di) { | |
| 2075 found = true; | |
| 2076 break; | |
| 2077 } | |
| 2078 } | |
| 2079 if (!found) { | |
| 2080 return false; | |
| 2081 } | |
| 2082 } else if (not_peel.test(di)) { | |
| 2083 if (peel.test(di)) { | |
| 2084 return false; | |
| 2085 } | |
| 2086 } else { | |
| 2087 return false; | |
| 2088 } | |
| 2089 } | |
| 2090 return true; | |
| 2091 } | |
| 2092 | |
| 2093 //------------------------------ is_valid_clone_loop_exit_use ------------------------------------- | |
| 2094 // Ensure a use outside of loop is of the right form | |
| 2095 bool PhaseIdealLoop::is_valid_clone_loop_exit_use( IdealLoopTree *loop, Node* use, uint exit_idx) { | |
| 2096 Node *use_c = has_ctrl(use) ? get_ctrl(use) : use; | |
| 2097 return (use->is_Phi() && | |
| 2098 use_c->is_Region() && use_c->req() == 3 && | |
| 2099 (use_c->in(exit_idx)->Opcode() == Op_IfTrue || | |
| 2100 use_c->in(exit_idx)->Opcode() == Op_IfFalse || | |
| 2101 use_c->in(exit_idx)->Opcode() == Op_JumpProj) && | |
| 2102 loop->is_member( get_loop( use_c->in(exit_idx)->in(0) ) ) ); | |
| 2103 } | |
| 2104 | |
| 2105 //------------------------------ is_valid_clone_loop_form ------------------------------------- | |
| 2106 // Ensure that all uses outside of loop are of the right form | |
| 2107 bool PhaseIdealLoop::is_valid_clone_loop_form( IdealLoopTree *loop, Node_List& peel_list, | |
| 2108 uint orig_exit_idx, uint clone_exit_idx) { | |
| 2109 uint len = peel_list.size(); | |
| 2110 for (uint i = 0; i < len; i++) { | |
| 2111 Node *def = peel_list.at(i); | |
| 2112 | |
| 2113 for (DUIterator_Fast jmax, j = def->fast_outs(jmax); j < jmax; j++) { | |
| 2114 Node *use = def->fast_out(j); | |
| 2115 Node *use_c = has_ctrl(use) ? get_ctrl(use) : use; | |
| 2116 if (!loop->is_member(get_loop(use_c))) { | |
| 2117 // use is not in the loop, check for correct structure | |
| 2118 if (use->in(0) == def) { | |
| 2119 // Okay | |
| 2120 } else if (!is_valid_clone_loop_exit_use(loop, use, orig_exit_idx)) { | |
| 2121 return false; | |
| 2122 } | |
| 2123 } | |
| 2124 } | |
| 2125 } | |
| 2126 return true; | |
| 2127 } | |
| 2128 #endif | |
| 2129 | |
| 2130 //------------------------------ partial_peel ------------------------------------- | |
| 2131 // Partially peel (aka loop rotation) the top portion of a loop (called | |
| 2132 // the peel section below) by cloning it and placing one copy just before | |
| 2133 // the new loop head and the other copy at the bottom of the new loop. | |
| 2134 // | |
| 2135 // before after where it came from | |
| 2136 // | |
| 2137 // stmt1 stmt1 | |
| 2138 // loop: stmt2 clone | |
| 2139 // stmt2 if condA goto exitA clone | |
| 2140 // if condA goto exitA new_loop: new | |
| 2141 // stmt3 stmt3 clone | |
| 2142 // if !condB goto loop if condB goto exitB clone | |
| 2143 // exitB: stmt2 orig | |
| 2144 // stmt4 if !condA goto new_loop orig | |
| 2145 // exitA: goto exitA | |
| 2146 // exitB: | |
| 2147 // stmt4 | |
| 2148 // exitA: | |
| 2149 // | |
| 2150 // Step 1: find the cut point: an exit test on probable | |
| 2151 // induction variable. | |
| 2152 // Step 2: schedule (with cloning) operations in the peel | |
| 2153 // section that can be executed after the cut into | |
| 2154 // the section that is not peeled. This may need | |
| 2155 // to clone operations into exit blocks. For | |
| 2156 // instance, a reference to A[i] in the not-peel | |
| 2157 // section and a reference to B[i] in an exit block | |
| 2158 // may cause a left-shift of i by 2 to be placed | |
| 2159 // in the peel block. This step will clone the left | |
| 2160 // shift into the exit block and sink the left shift | |
| 2161 // from the peel to the not-peel section. | |
| 2162 // Step 3: clone the loop, retarget the control, and insert | |
| 2163 // phis for values that are live across the new loop | |
| 2164 // head. This is very dependent on the graph structure | |
| 2165 // from clone_loop. It creates region nodes for | |
| 2166 // exit control and associated phi nodes for values | |
| 2167 // flow out of the loop through that exit. The region | |
| 2168 // node is dominated by the clone's control projection. | |
| 2169 // So the clone's peel section is placed before the | |
| 2170 // new loop head, and the clone's not-peel section is | |
| 2171 // forms the top part of the new loop. The original | |
| 2172 // peel section forms the tail of the new loop. | |
| 2173 // Step 4: update the dominator tree and recompute the | |
| 2174 // dominator depth. | |
| 2175 // | |
| 2176 // orig | |
| 2177 // | |
| 2445 | 2178 // stmt1 |
| 2179 // | | |
| 2180 // v | |
| 2181 // loop predicate | |
| 2182 // | | |
| 2183 // v | |
| 0 | 2184 // loop<----+ |
| 2185 // | | | |
| 2186 // stmt2 | | |
| 2187 // | | | |
| 2188 // v | | |
| 2189 // ifA | | |
| 2190 // / | | | |
| 2191 // v v | | |
| 2192 // false true ^ <-- last_peel | |
| 2193 // / | | | |
| 2194 // / ===|==cut | | |
| 2195 // / stmt3 | <-- first_not_peel | |
| 2196 // / | | | |
| 2197 // | v | | |
| 2198 // v ifB | | |
| 2199 // exitA: / \ | | |
| 2200 // / \ | | |
| 2201 // v v | | |
| 2202 // false true | | |
| 2203 // / \ | | |
| 2204 // / ----+ | |
| 2205 // | | |
| 2206 // v | |
| 2207 // exitB: | |
| 2208 // stmt4 | |
| 2209 // | |
| 2210 // | |
| 2211 // after clone loop | |
| 2212 // | |
| 2213 // stmt1 | |
| 2445 | 2214 // | |
| 2215 // v | |
| 2216 // loop predicate | |
| 0 | 2217 // / \ |
| 2218 // clone / \ orig | |
| 2219 // / \ | |
| 2220 // / \ | |
| 2221 // v v | |
| 2222 // +---->loop loop<----+ | |
| 2223 // | | | | | |
| 2224 // | stmt2 stmt2 | | |
| 2225 // | | | | | |
| 2226 // | v v | | |
| 2227 // | ifA ifA | | |
| 2228 // | | \ / | | | |
| 2229 // | v v v v | | |
| 2230 // ^ true false false true ^ <-- last_peel | |
| 2231 // | | ^ \ / | | | |
| 2232 // | cut==|== \ \ / ===|==cut | | |
| 2233 // | stmt3 \ \ / stmt3 | <-- first_not_peel | |
| 2234 // | | dom | | | | | |
| 2235 // | v \ 1v v2 v | | |
| 2236 // | ifB regionA ifB | | |
| 2237 // | / \ | / \ | | |
| 2238 // | / \ v / \ | | |
| 2239 // | v v exitA: v v | | |
| 2240 // | true false false true | | |
| 2241 // | / ^ \ / \ | | |
| 2242 // +---- \ \ / ----+ | |
| 2243 // dom \ / | |
| 2244 // \ 1v v2 | |
| 2245 // regionB | |
| 2246 // | | |
| 2247 // v | |
| 2248 // exitB: | |
| 2249 // stmt4 | |
| 2250 // | |
| 2251 // | |
| 2252 // after partial peel | |
| 2253 // | |
| 2254 // stmt1 | |
| 2445 | 2255 // | |
| 2256 // v | |
| 2257 // loop predicate | |
| 0 | 2258 // / |
| 2259 // clone / orig | |
| 2260 // / TOP | |
| 2261 // / \ | |
| 2262 // v v | |
| 2445 | 2263 // TOP->loop loop----+ |
| 0 | 2264 // | | | |
| 2265 // stmt2 stmt2 | | |
| 2266 // | | | | |
| 2267 // v v | | |
| 2268 // ifA ifA | | |
| 2269 // | \ / | | | |
| 2270 // v v v v | | |
| 2271 // true false false true | <-- last_peel | |
| 2272 // | ^ \ / +------|---+ | |
| 2273 // +->newloop \ \ / === ==cut | | | |
| 2274 // | stmt3 \ \ / TOP | | | |
| 2275 // | | dom | | stmt3 | | <-- first_not_peel | |
| 2276 // | v \ 1v v2 v | | | |
| 2277 // | ifB regionA ifB ^ v | |
| 2278 // | / \ | / \ | | | |
| 2279 // | / \ v / \ | | | |
| 2280 // | v v exitA: v v | | | |
| 2281 // | true false false true | | | |
| 2282 // | / ^ \ / \ | | | |
| 2283 // | | \ \ / v | | | |
| 2284 // | | dom \ / TOP | | | |
| 2285 // | | \ 1v v2 | | | |
| 2286 // ^ v regionB | | | |
| 2287 // | | | | | | |
| 2288 // | | v ^ v | |
| 2289 // | | exitB: | | | |
| 2290 // | | stmt4 | | | |
| 2291 // | +------------>-----------------+ | | |
| 2292 // | | | |
| 2293 // +-----------------<---------------------+ | |
| 2294 // | |
| 2295 // | |
| 2296 // final graph | |
| 2297 // | |
| 2298 // stmt1 | |
| 2299 // | | |
| 2300 // v | |
|
3281
273b56978029
7039586: test/java/util/Collections/Rotate.java failing with hs21-b09
kvn
parents:
2468
diff
changeset
|
2301 // loop predicate |
|
273b56978029
7039586: test/java/util/Collections/Rotate.java failing with hs21-b09
kvn
parents:
2468
diff
changeset
|
2302 // | |
|
273b56978029
7039586: test/java/util/Collections/Rotate.java failing with hs21-b09
kvn
parents:
2468
diff
changeset
|
2303 // v |
| 2445 | 2304 // stmt2 clone |
| 2305 // | | |
| 2306 // v | |
| 0 | 2307 // ........> ifA clone |
| 2308 // : / | | |
| 2309 // dom / | | |
| 2310 // : v v | |
| 2311 // : false true | |
| 2312 // : | | | |
| 2445 | 2313 // : | v |
| 0 | 2314 // : | newloop<-----+ |
| 2315 // : | | | | |
| 2316 // : | stmt3 clone | | |
| 2317 // : | | | | |
| 2318 // : | v | | |
| 2319 // : | ifB | | |
| 2320 // : | / \ | | |
| 2321 // : | v v | | |
| 2322 // : | false true | | |
| 2323 // : | | | | | |
| 2324 // : | v stmt2 | | |
| 2325 // : | exitB: | | | |
| 2326 // : | stmt4 v | | |
| 2327 // : | ifA orig | | |
| 2328 // : | / \ | | |
| 2329 // : | / \ | | |
| 2330 // : | v v | | |
| 2331 // : | false true | | |
| 2332 // : | / \ | | |
| 2333 // : v v -----+ | |
| 2334 // RegionA | |
| 2335 // | | |
| 2336 // v | |
| 2337 // exitA | |
| 2338 // | |
| 2339 bool PhaseIdealLoop::partial_peel( IdealLoopTree *loop, Node_List &old_new ) { | |
| 2340 | |
| 2445 | 2341 assert(!loop->_head->is_CountedLoop(), "Non-counted loop only"); |
| 108 | 2342 if (!loop->_head->is_Loop()) { |
| 2343 return false; } | |
| 2344 | |
| 0 | 2345 LoopNode *head = loop->_head->as_Loop(); |
| 2346 | |
| 2347 if (head->is_partial_peel_loop() || head->partial_peel_has_failed()) { | |
| 2348 return false; | |
| 2349 } | |
| 2350 | |
| 2351 // Check for complex exit control | |
| 2352 for(uint ii = 0; ii < loop->_body.size(); ii++ ) { | |
| 2353 Node *n = loop->_body.at(ii); | |
| 2354 int opc = n->Opcode(); | |
| 2355 if (n->is_Call() || | |
| 2356 opc == Op_Catch || | |
| 2357 opc == Op_CatchProj || | |
| 2358 opc == Op_Jump || | |
|
17726
085b304a1cc5
8027754: Enable loop optimizations for loops with MathExact inside
rbackman
parents:
17671
diff
changeset
|
2359 opc == Op_JumpProj) { |
| 0 | 2360 #if !defined(PRODUCT) |
| 2361 if (TracePartialPeeling) { | |
| 2362 tty->print_cr("\nExit control too complex: lp: %d", head->_idx); | |
| 2363 } | |
| 2364 #endif | |
| 2365 return false; | |
| 2366 } | |
| 2367 } | |
| 2368 | |
| 2369 int dd = dom_depth(head); | |
| 2370 | |
| 2371 // Step 1: find cut point | |
| 2372 | |
| 2373 // Walk up dominators to loop head looking for first loop exit | |
| 2374 // which is executed on every path thru loop. | |
| 2375 IfNode *peel_if = NULL; | |
| 2376 IfNode *peel_if_cmpu = NULL; | |
| 2377 | |
| 2378 Node *iff = loop->tail(); | |
| 2379 while( iff != head ) { | |
| 2380 if( iff->is_If() ) { | |
| 2381 Node *ctrl = get_ctrl(iff->in(1)); | |
| 2382 if (ctrl->is_top()) return false; // Dead test on live IF. | |
| 2383 // If loop-varying exit-test, check for induction variable | |
| 2384 if( loop->is_member(get_loop(ctrl)) && | |
| 2385 loop->is_loop_exit(iff) && | |
| 2386 is_possible_iv_test(iff)) { | |
| 2387 Node* cmp = iff->in(1)->in(1); | |
| 2388 if (cmp->Opcode() == Op_CmpI) { | |
| 2389 peel_if = iff->as_If(); | |
| 2390 } else { | |
| 2391 assert(cmp->Opcode() == Op_CmpU, "must be CmpI or CmpU"); | |
| 2392 peel_if_cmpu = iff->as_If(); | |
| 2393 } | |
| 2394 } | |
| 2395 } | |
| 2396 iff = idom(iff); | |
| 2397 } | |
| 2398 // Prefer signed compare over unsigned compare. | |
| 2399 IfNode* new_peel_if = NULL; | |
| 2400 if (peel_if == NULL) { | |
| 2401 if (!PartialPeelAtUnsignedTests || peel_if_cmpu == NULL) { | |
| 2402 return false; // No peel point found | |
| 2403 } | |
| 2404 new_peel_if = insert_cmpi_loop_exit(peel_if_cmpu, loop); | |
| 2405 if (new_peel_if == NULL) { | |
| 2406 return false; // No peel point found | |
| 2407 } | |
| 2408 peel_if = new_peel_if; | |
| 2409 } | |
| 2410 Node* last_peel = stay_in_loop(peel_if, loop); | |
| 2411 Node* first_not_peeled = stay_in_loop(last_peel, loop); | |
| 2412 if (first_not_peeled == NULL || first_not_peeled == head) { | |
| 2413 return false; | |
| 2414 } | |
| 2415 | |
| 2416 #if !defined(PRODUCT) | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2417 if (TraceLoopOpts) { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2418 tty->print("PartialPeel "); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2419 loop->dump_head(); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2420 } |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2421 |
| 0 | 2422 if (TracePartialPeeling) { |
| 2423 tty->print_cr("before partial peel one iteration"); | |
| 2424 Node_List wl; | |
| 2425 Node* t = head->in(2); | |
| 2426 while (true) { | |
| 2427 wl.push(t); | |
| 2428 if (t == head) break; | |
| 2429 t = idom(t); | |
| 2430 } | |
| 2431 while (wl.size() > 0) { | |
| 2432 Node* tt = wl.pop(); | |
| 2433 tt->dump(); | |
| 2434 if (tt == last_peel) tty->print_cr("-- cut --"); | |
| 2435 } | |
| 2436 } | |
| 2437 #endif | |
| 2438 ResourceArea *area = Thread::current()->resource_area(); | |
| 2439 VectorSet peel(area); | |
| 2440 VectorSet not_peel(area); | |
| 2441 Node_List peel_list(area); | |
| 2442 Node_List worklist(area); | |
| 2443 Node_List sink_list(area); | |
| 2444 | |
| 2445 // Set of cfg nodes to peel are those that are executable from | |
| 2446 // the head through last_peel. | |
| 2447 assert(worklist.size() == 0, "should be empty"); | |
| 2448 worklist.push(head); | |
| 2449 peel.set(head->_idx); | |
| 2450 while (worklist.size() > 0) { | |
| 2451 Node *n = worklist.pop(); | |
| 2452 if (n != last_peel) { | |
| 2453 for (DUIterator_Fast jmax, j = n->fast_outs(jmax); j < jmax; j++) { | |
| 2454 Node* use = n->fast_out(j); | |
| 2455 if (use->is_CFG() && | |
| 2456 loop->is_member(get_loop(use)) && | |
| 2457 !peel.test_set(use->_idx)) { | |
| 2458 worklist.push(use); | |
| 2459 } | |
| 2460 } | |
| 2461 } | |
| 2462 } | |
| 2463 | |
| 2464 // Set of non-cfg nodes to peel are those that are control | |
| 2465 // dependent on the cfg nodes. | |
| 2466 uint i; | |
| 2467 for(i = 0; i < loop->_body.size(); i++ ) { | |
| 2468 Node *n = loop->_body.at(i); | |
| 2469 Node *n_c = has_ctrl(n) ? get_ctrl(n) : n; | |
| 2470 if (peel.test(n_c->_idx)) { | |
| 2471 peel.set(n->_idx); | |
| 2472 } else { | |
| 2473 not_peel.set(n->_idx); | |
| 2474 } | |
| 2475 } | |
| 2476 | |
| 2477 // Step 2: move operations from the peeled section down into the | |
| 2478 // not-peeled section | |
| 2479 | |
| 2480 // Get a post order schedule of nodes in the peel region | |
| 2481 // Result in right-most operand. | |
| 2482 scheduled_nodelist(loop, peel, peel_list ); | |
| 2483 | |
| 2484 assert(is_valid_loop_partition(loop, peel, peel_list, not_peel), "bad partition"); | |
| 2485 | |
| 2486 // For future check for too many new phis | |
| 2487 uint old_phi_cnt = 0; | |
| 2488 for (DUIterator_Fast jmax, j = head->fast_outs(jmax); j < jmax; j++) { | |
| 2489 Node* use = head->fast_out(j); | |
| 2490 if (use->is_Phi()) old_phi_cnt++; | |
| 2491 } | |
| 2492 | |
| 2493 #if !defined(PRODUCT) | |
| 2494 if (TracePartialPeeling) { | |
| 2495 tty->print_cr("\npeeled list"); | |
| 2496 } | |
| 2497 #endif | |
| 2498 | |
| 2499 // Evacuate nodes in peel region into the not_peeled region if possible | |
| 2500 uint new_phi_cnt = 0; | |
|
10322
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
2501 uint cloned_for_outside_use = 0; |
| 0 | 2502 for (i = 0; i < peel_list.size();) { |
| 2503 Node* n = peel_list.at(i); | |
| 2504 #if !defined(PRODUCT) | |
| 2505 if (TracePartialPeeling) n->dump(); | |
| 2506 #endif | |
| 2507 bool incr = true; | |
| 2508 if ( !n->is_CFG() ) { | |
| 2509 | |
| 2510 if ( has_use_in_set(n, not_peel) ) { | |
| 2511 | |
| 2512 // If not used internal to the peeled region, | |
| 2513 // move "n" from peeled to not_peeled region. | |
| 2514 | |
| 2515 if ( !has_use_internal_to_set(n, peel, loop) ) { | |
| 2516 | |
| 2517 // if not pinned and not a load (which maybe anti-dependent on a store) | |
| 2518 // and not a CMove (Matcher expects only bool->cmove). | |
| 2519 if ( n->in(0) == NULL && !n->is_Load() && !n->is_CMove() ) { | |
|
10322
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
2520 cloned_for_outside_use += clone_for_use_outside_loop( loop, n, worklist ); |
| 0 | 2521 sink_list.push(n); |
| 2522 peel >>= n->_idx; // delete n from peel set. | |
| 2523 not_peel <<= n->_idx; // add n to not_peel set. | |
| 2524 peel_list.remove(i); | |
| 2525 incr = false; | |
| 2526 #if !defined(PRODUCT) | |
| 2527 if (TracePartialPeeling) { | |
| 2528 tty->print_cr("sink to not_peeled region: %d newbb: %d", | |
| 2529 n->_idx, get_ctrl(n)->_idx); | |
| 2530 } | |
| 2531 #endif | |
| 2532 } | |
| 2533 } else { | |
| 2534 // Otherwise check for special def-use cases that span | |
| 2535 // the peel/not_peel boundary such as bool->if | |
| 2536 clone_for_special_use_inside_loop( loop, n, not_peel, sink_list, worklist ); | |
| 2537 new_phi_cnt++; | |
| 2538 } | |
| 2539 } | |
| 2540 } | |
| 2541 if (incr) i++; | |
| 2542 } | |
| 2543 | |
| 2544 if (new_phi_cnt > old_phi_cnt + PartialPeelNewPhiDelta) { | |
| 2545 #if !defined(PRODUCT) | |
| 2546 if (TracePartialPeeling) { | |
| 2547 tty->print_cr("\nToo many new phis: %d old %d new cmpi: %c", | |
| 2548 new_phi_cnt, old_phi_cnt, new_peel_if != NULL?'T':'F'); | |
| 2549 } | |
| 2550 #endif | |
| 2551 if (new_peel_if != NULL) { | |
| 2552 remove_cmpi_loop_exit(new_peel_if, loop); | |
| 2553 } | |
| 2554 // Inhibit more partial peeling on this loop | |
| 2555 assert(!head->is_partial_peel_loop(), "not partial peeled"); | |
| 2556 head->mark_partial_peel_failed(); | |
|
10322
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
2557 if (cloned_for_outside_use > 0) { |
|
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
2558 // Terminate this round of loop opts because |
|
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
2559 // the graph outside this loop was changed. |
|
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
2560 C->set_major_progress(); |
|
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
2561 return true; |
|
1682bec79205
8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed
kvn
parents:
8774
diff
changeset
|
2562 } |
| 0 | 2563 return false; |
| 2564 } | |
| 2565 | |
| 2566 // Step 3: clone loop, retarget control, and insert new phis | |
| 2567 | |
| 2568 // Create new loop head for new phis and to hang | |
| 2569 // the nodes being moved (sinked) from the peel region. | |
|
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
2570 LoopNode* new_head = new (C) LoopNode(last_peel, last_peel); |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2571 new_head->set_unswitch_count(head->unswitch_count()); // Preserve |
| 0 | 2572 _igvn.register_new_node_with_optimizer(new_head); |
| 2573 assert(first_not_peeled->in(0) == last_peel, "last_peel <- first_not_peeled"); | |
| 2574 first_not_peeled->set_req(0, new_head); | |
| 2575 set_loop(new_head, loop); | |
| 2576 loop->_body.push(new_head); | |
| 2577 not_peel.set(new_head->_idx); | |
| 2578 set_idom(new_head, last_peel, dom_depth(first_not_peeled)); | |
| 2579 set_idom(first_not_peeled, new_head, dom_depth(first_not_peeled)); | |
| 2580 | |
| 2581 while (sink_list.size() > 0) { | |
| 2582 Node* n = sink_list.pop(); | |
| 2583 set_ctrl(n, new_head); | |
| 2584 } | |
| 2585 | |
| 2586 assert(is_valid_loop_partition(loop, peel, peel_list, not_peel), "bad partition"); | |
| 2587 | |
| 2588 clone_loop( loop, old_new, dd ); | |
| 2589 | |
| 2590 const uint clone_exit_idx = 1; | |
| 2591 const uint orig_exit_idx = 2; | |
| 2592 assert(is_valid_clone_loop_form( loop, peel_list, orig_exit_idx, clone_exit_idx ), "bad clone loop"); | |
| 2593 | |
| 2594 Node* head_clone = old_new[head->_idx]; | |
| 2595 LoopNode* new_head_clone = old_new[new_head->_idx]->as_Loop(); | |
| 2596 Node* orig_tail_clone = head_clone->in(2); | |
| 2597 | |
| 2598 // Add phi if "def" node is in peel set and "use" is not | |
| 2599 | |
| 2600 for(i = 0; i < peel_list.size(); i++ ) { | |
| 2601 Node *def = peel_list.at(i); | |
| 2602 if (!def->is_CFG()) { | |
| 2603 for (DUIterator_Fast jmax, j = def->fast_outs(jmax); j < jmax; j++) { | |
| 2604 Node *use = def->fast_out(j); | |
| 2605 if (has_node(use) && use->in(0) != C->top() && | |
| 2606 (!peel.test(use->_idx) || | |
| 2607 (use->is_Phi() && use->in(0) == head)) ) { | |
| 2608 worklist.push(use); | |
| 2609 } | |
| 2610 } | |
| 2611 while( worklist.size() ) { | |
| 2612 Node *use = worklist.pop(); | |
| 2613 for (uint j = 1; j < use->req(); j++) { | |
| 2614 Node* n = use->in(j); | |
| 2615 if (n == def) { | |
| 2616 | |
| 2617 // "def" is in peel set, "use" is not in peel set | |
| 2618 // or "use" is in the entry boundary (a phi) of the peel set | |
| 2619 | |
| 2620 Node* use_c = has_ctrl(use) ? get_ctrl(use) : use; | |
| 2621 | |
| 2622 if ( loop->is_member(get_loop( use_c )) ) { | |
| 2623 // use is in loop | |
| 2624 if (old_new[use->_idx] != NULL) { // null for dead code | |
| 2625 Node* use_clone = old_new[use->_idx]; | |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2626 _igvn.replace_input_of(use, j, C->top()); |
| 0 | 2627 insert_phi_for_loop( use_clone, j, old_new[def->_idx], def, new_head_clone ); |
| 2628 } | |
| 2629 } else { | |
| 2630 assert(is_valid_clone_loop_exit_use(loop, use, orig_exit_idx), "clone loop format"); | |
| 2631 // use is not in the loop, check if the live range includes the cut | |
| 2632 Node* lp_if = use_c->in(orig_exit_idx)->in(0); | |
| 2633 if (not_peel.test(lp_if->_idx)) { | |
| 2634 assert(j == orig_exit_idx, "use from original loop"); | |
| 2635 insert_phi_for_loop( use, clone_exit_idx, old_new[def->_idx], def, new_head_clone ); | |
| 2636 } | |
| 2637 } | |
| 2638 } | |
| 2639 } | |
| 2640 } | |
| 2641 } | |
| 2642 } | |
| 2643 | |
| 2644 // Step 3b: retarget control | |
| 2645 | |
| 2646 // Redirect control to the new loop head if a cloned node in | |
| 2647 // the not_peeled region has control that points into the peeled region. | |
| 2648 // This necessary because the cloned peeled region will be outside | |
| 2649 // the loop. | |
| 2650 // from to | |
| 2651 // cloned-peeled <---+ | |
| 2652 // new_head_clone: | <--+ | |
| 2653 // cloned-not_peeled in(0) in(0) | |
| 2654 // orig-peeled | |
| 2655 | |
| 2656 for(i = 0; i < loop->_body.size(); i++ ) { | |
| 2657 Node *n = loop->_body.at(i); | |
| 2658 if (!n->is_CFG() && n->in(0) != NULL && | |
| 2659 not_peel.test(n->_idx) && peel.test(n->in(0)->_idx)) { | |
| 2660 Node* n_clone = old_new[n->_idx]; | |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2661 _igvn.replace_input_of(n_clone, 0, new_head_clone); |
| 0 | 2662 } |
| 2663 } | |
| 2664 | |
| 2665 // Backedge of the surviving new_head (the clone) is original last_peel | |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2666 _igvn.replace_input_of(new_head_clone, LoopNode::LoopBackControl, last_peel); |
| 0 | 2667 |
| 2668 // Cut first node in original not_peel set | |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2669 _igvn.rehash_node_delayed(new_head); // Multiple edge updates: |
|
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2670 new_head->set_req(LoopNode::EntryControl, C->top()); // use rehash_node_delayed / set_req instead of |
|
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2671 new_head->set_req(LoopNode::LoopBackControl, C->top()); // multiple replace_input_of calls |
| 0 | 2672 |
| 2673 // Copy head_clone back-branch info to original head | |
| 2674 // and remove original head's loop entry and | |
| 2675 // clone head's back-branch | |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2676 _igvn.rehash_node_delayed(head); // Multiple edge updates |
|
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2677 head->set_req(LoopNode::EntryControl, head_clone->in(LoopNode::LoopBackControl)); |
| 0 | 2678 head->set_req(LoopNode::LoopBackControl, C->top()); |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2679 _igvn.replace_input_of(head_clone, LoopNode::LoopBackControl, C->top()); |
| 0 | 2680 |
| 2681 // Similarly modify the phis | |
| 2682 for (DUIterator_Fast kmax, k = head->fast_outs(kmax); k < kmax; k++) { | |
| 2683 Node* use = head->fast_out(k); | |
| 2684 if (use->is_Phi() && use->outcnt() > 0) { | |
| 2685 Node* use_clone = old_new[use->_idx]; | |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2686 _igvn.rehash_node_delayed(use); // Multiple edge updates |
|
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2687 use->set_req(LoopNode::EntryControl, use_clone->in(LoopNode::LoopBackControl)); |
| 0 | 2688 use->set_req(LoopNode::LoopBackControl, C->top()); |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2689 _igvn.replace_input_of(use_clone, LoopNode::LoopBackControl, C->top()); |
| 0 | 2690 } |
| 2691 } | |
| 2692 | |
| 2693 // Step 4: update dominator tree and dominator depth | |
| 2694 | |
| 2695 set_idom(head, orig_tail_clone, dd); | |
| 2696 recompute_dom_depth(); | |
| 2697 | |
| 2698 // Inhibit more partial peeling on this loop | |
| 2699 new_head_clone->set_partial_peel_loop(); | |
| 2700 C->set_major_progress(); | |
| 2701 | |
| 2702 #if !defined(PRODUCT) | |
| 2703 if (TracePartialPeeling) { | |
| 2704 tty->print_cr("\nafter partial peel one iteration"); | |
| 2705 Node_List wl(area); | |
| 2706 Node* t = last_peel; | |
| 2707 while (true) { | |
| 2708 wl.push(t); | |
| 2709 if (t == head_clone) break; | |
| 2710 t = idom(t); | |
| 2711 } | |
| 2712 while (wl.size() > 0) { | |
| 2713 Node* tt = wl.pop(); | |
| 2714 if (tt == head) tty->print_cr("orig head"); | |
| 2715 else if (tt == new_head_clone) tty->print_cr("new head"); | |
| 2716 else if (tt == head_clone) tty->print_cr("clone head"); | |
| 2717 tt->dump(); | |
| 2718 } | |
| 2719 } | |
| 2720 #endif | |
| 2721 return true; | |
| 2722 } | |
| 2723 | |
| 2724 //------------------------------reorg_offsets---------------------------------- | |
| 2725 // Reorganize offset computations to lower register pressure. Mostly | |
| 2726 // prevent loop-fallout uses of the pre-incremented trip counter (which are | |
| 2727 // then alive with the post-incremented trip counter forcing an extra | |
| 2728 // register move) | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2729 void PhaseIdealLoop::reorg_offsets(IdealLoopTree *loop) { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2730 // Perform it only for canonical counted loops. |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2731 // Loop's shape could be messed up by iteration_split_impl. |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2732 if (!loop->_head->is_CountedLoop()) |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2733 return; |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2734 if (!loop->_head->as_Loop()->is_valid_counted_loop()) |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2735 return; |
| 0 | 2736 |
| 2737 CountedLoopNode *cl = loop->_head->as_CountedLoop(); | |
| 2738 CountedLoopEndNode *cle = cl->loopexit(); | |
| 2739 Node *exit = cle->proj_out(false); | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2740 Node *phi = cl->phi(); |
| 0 | 2741 |
| 2742 // Check for the special case of folks using the pre-incremented | |
| 2743 // trip-counter on the fall-out path (forces the pre-incremented | |
| 2744 // and post-incremented trip counter to be live at the same time). | |
| 2745 // Fix this by adjusting to use the post-increment trip counter. | |
|
367
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
318
diff
changeset
|
2746 |
| 0 | 2747 bool progress = true; |
| 2748 while (progress) { | |
| 2749 progress = false; | |
| 2750 for (DUIterator_Fast imax, i = phi->fast_outs(imax); i < imax; i++) { | |
| 2751 Node* use = phi->fast_out(i); // User of trip-counter | |
| 2752 if (!has_ctrl(use)) continue; | |
| 2753 Node *u_ctrl = get_ctrl(use); | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2754 if (use->is_Phi()) { |
| 0 | 2755 u_ctrl = NULL; |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2756 for (uint j = 1; j < use->req(); j++) |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2757 if (use->in(j) == phi) |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2758 u_ctrl = dom_lca(u_ctrl, use->in(0)->in(j)); |
| 0 | 2759 } |
| 2760 IdealLoopTree *u_loop = get_loop(u_ctrl); | |
| 2761 // Look for loop-invariant use | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2762 if (u_loop == loop) continue; |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2763 if (loop->is_member(u_loop)) continue; |
| 0 | 2764 // Check that use is live out the bottom. Assuming the trip-counter |
| 2765 // update is right at the bottom, uses of of the loop middle are ok. | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2766 if (dom_lca(exit, u_ctrl) != exit) continue; |
| 0 | 2767 // Hit! Refactor use to use the post-incremented tripcounter. |
| 2768 // Compute a post-increment tripcounter. | |
|
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
2769 Node *opaq = new (C) Opaque2Node( C, cle->incr() ); |
| 0 | 2770 register_new_node( opaq, u_ctrl ); |
| 2771 Node *neg_stride = _igvn.intcon(-cle->stride_con()); | |
| 2772 set_ctrl(neg_stride, C->root()); | |
|
6804
e626685e9f6c
7193318: C2: remove number of inputs requirement from Node's new operator
kvn
parents:
6144
diff
changeset
|
2773 Node *post = new (C) AddINode( opaq, neg_stride); |
| 0 | 2774 register_new_node( post, u_ctrl ); |
|
6144
5e990493719e
7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents:
4779
diff
changeset
|
2775 _igvn.rehash_node_delayed(use); |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2776 for (uint j = 1; j < use->req(); j++) { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2777 if (use->in(j) == phi) |
| 0 | 2778 use->set_req(j, post); |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
1972
diff
changeset
|
2779 } |
| 0 | 2780 // Since DU info changed, rerun loop |
| 2781 progress = true; | |
| 2782 break; | |
| 2783 } | |
| 2784 } | |
| 2785 | |
| 2786 } |