Mercurial > hg > truffle
annotate src/share/vm/gc_implementation/g1/g1RemSet.cpp @ 10246:194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
Summary: Refactor G1's hot card cache and card counts table into their own files. Simplify the card counts table, including removing the encoding of the card index in each entry. The card counts table now has a 1:1 correspondence with the cards spanned by heap. Space for the card counts table is reserved from virtual memory (rather than C heap) during JVM startup and is committed/expanded when the heap is expanded. Changes were also reviewed-by Vitaly Davidovich.
Reviewed-by: tschatzl, jmasa
| author | johnc |
|---|---|
| date | Thu, 09 May 2013 11:16:39 -0700 |
| parents | 5c93c1f61226 |
| children | e72f7eecc96d |
| rev | line source |
|---|---|
| 342 | 1 /* |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
2 * Copyright (c) 2001, 2013, Oracle and/or its affiliates. All rights reserved. |
| 342 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1282
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1282
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1282
diff
changeset
|
21 * questions. |
| 342 | 22 * |
| 23 */ | |
| 24 | |
| 1972 | 25 #include "precompiled.hpp" |
| 26 #include "gc_implementation/g1/bufferingOopClosure.hpp" | |
| 27 #include "gc_implementation/g1/concurrentG1Refine.hpp" | |
| 28 #include "gc_implementation/g1/concurrentG1RefineThread.hpp" | |
| 29 #include "gc_implementation/g1/g1BlockOffsetTable.inline.hpp" | |
| 30 #include "gc_implementation/g1/g1CollectedHeap.inline.hpp" | |
| 31 #include "gc_implementation/g1/g1CollectorPolicy.hpp" | |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
32 #include "gc_implementation/g1/g1HotCardCache.hpp" |
|
6219
922993931b3d
7178361: G1: Make sure that PrintGC and PrintGCDetails use the same timing for the GC pause
brutisso
parents:
4839
diff
changeset
|
33 #include "gc_implementation/g1/g1GCPhaseTimes.hpp" |
| 1972 | 34 #include "gc_implementation/g1/g1OopClosures.inline.hpp" |
| 35 #include "gc_implementation/g1/g1RemSet.inline.hpp" | |
| 36 #include "gc_implementation/g1/heapRegionSeq.inline.hpp" | |
| 37 #include "memory/iterator.hpp" | |
| 38 #include "oops/oop.inline.hpp" | |
| 39 #include "utilities/intHisto.hpp" | |
| 342 | 40 |
| 41 #define CARD_REPEAT_HISTO 0 | |
| 42 | |
| 43 #if CARD_REPEAT_HISTO | |
| 44 static size_t ct_freq_sz; | |
| 45 static jbyte* ct_freq = NULL; | |
| 46 | |
| 47 void init_ct_freq_table(size_t heap_sz_bytes) { | |
| 48 if (ct_freq == NULL) { | |
| 49 ct_freq_sz = heap_sz_bytes/CardTableModRefBS::card_size; | |
| 50 ct_freq = new jbyte[ct_freq_sz]; | |
| 51 for (size_t j = 0; j < ct_freq_sz; j++) ct_freq[j] = 0; | |
| 52 } | |
| 53 } | |
| 54 | |
| 55 void ct_freq_note_card(size_t index) { | |
| 56 assert(0 <= index && index < ct_freq_sz, "Bounds error."); | |
| 57 if (ct_freq[index] < 100) { ct_freq[index]++; } | |
| 58 } | |
| 59 | |
| 60 static IntHistogram card_repeat_count(10, 10); | |
| 61 | |
| 62 void ct_freq_update_histo_and_reset() { | |
| 63 for (size_t j = 0; j < ct_freq_sz; j++) { | |
| 64 card_repeat_count.add_entry(ct_freq[j]); | |
| 65 ct_freq[j] = 0; | |
| 66 } | |
| 67 | |
| 68 } | |
| 69 #endif | |
| 70 | |
| 1861 | 71 G1RemSet::G1RemSet(G1CollectedHeap* g1, CardTableModRefBS* ct_bs) |
| 72 : _g1(g1), _conc_refine_cards(0), | |
| 73 _ct_bs(ct_bs), _g1p(_g1->g1_policy()), | |
| 342 | 74 _cg1r(g1->concurrent_g1_refine()), |
| 1705 | 75 _cset_rs_update_cl(NULL), |
| 342 | 76 _cards_scanned(NULL), _total_cards_scanned(0) |
| 77 { | |
| 78 _seq_task = new SubTasksDone(NumSeqTasks); | |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
79 guarantee(n_workers() > 0, "There should be some workers"); |
| 6197 | 80 _cset_rs_update_cl = NEW_C_HEAP_ARRAY(OopsInHeapRegionClosure*, n_workers(), mtGC); |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
81 for (uint i = 0; i < n_workers(); i++) { |
| 1705 | 82 _cset_rs_update_cl[i] = NULL; |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
83 } |
| 342 | 84 } |
| 85 | |
| 1861 | 86 G1RemSet::~G1RemSet() { |
| 342 | 87 delete _seq_task; |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
88 for (uint i = 0; i < n_workers(); i++) { |
| 1705 | 89 assert(_cset_rs_update_cl[i] == NULL, "it should be"); |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
90 } |
| 6197 | 91 FREE_C_HEAP_ARRAY(OopsInHeapRegionClosure*, _cset_rs_update_cl, mtGC); |
| 342 | 92 } |
| 93 | |
| 94 void CountNonCleanMemRegionClosure::do_MemRegion(MemRegion mr) { | |
| 95 if (_g1->is_in_g1_reserved(mr.start())) { | |
| 96 _n += (int) ((mr.byte_size() / CardTableModRefBS::card_size)); | |
| 97 if (_start_first == NULL) _start_first = mr.start(); | |
| 98 } | |
| 99 } | |
| 100 | |
| 101 class ScanRSClosure : public HeapRegionClosure { | |
| 102 size_t _cards_done, _cards; | |
| 103 G1CollectedHeap* _g1h; | |
| 104 OopsInHeapRegionClosure* _oc; | |
| 105 G1BlockOffsetSharedArray* _bot_shared; | |
| 106 CardTableModRefBS *_ct_bs; | |
| 107 int _worker_i; | |
| 1261 | 108 int _block_size; |
| 342 | 109 bool _try_claimed; |
| 110 public: | |
| 111 ScanRSClosure(OopsInHeapRegionClosure* oc, int worker_i) : | |
| 112 _oc(oc), | |
| 113 _cards(0), | |
| 114 _cards_done(0), | |
| 115 _worker_i(worker_i), | |
| 116 _try_claimed(false) | |
| 117 { | |
| 118 _g1h = G1CollectedHeap::heap(); | |
| 119 _bot_shared = _g1h->bot_shared(); | |
| 120 _ct_bs = (CardTableModRefBS*) (_g1h->barrier_set()); | |
| 1261 | 121 _block_size = MAX2<int>(G1RSetScanBlockSize, 1); |
| 342 | 122 } |
| 123 | |
| 124 void set_try_claimed() { _try_claimed = true; } | |
| 125 | |
| 126 void scanCard(size_t index, HeapRegion *r) { | |
| 4023 | 127 // Stack allocate the DirtyCardToOopClosure instance |
| 128 HeapRegionDCTOC cl(_g1h, r, _oc, | |
| 129 CardTableModRefBS::Precise, | |
| 130 HeapRegionDCTOC::IntoCSFilterKind); | |
| 342 | 131 |
| 132 // Set the "from" region in the closure. | |
| 133 _oc->set_region(r); | |
| 134 HeapWord* card_start = _bot_shared->address_for_index(index); | |
| 135 HeapWord* card_end = card_start + G1BlockOffsetSharedArray::N_words; | |
| 136 Space *sp = SharedHeap::heap()->space_containing(card_start); | |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
137 MemRegion sm_region = sp->used_region_at_save_marks(); |
| 342 | 138 MemRegion mr = sm_region.intersection(MemRegion(card_start,card_end)); |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
139 if (!mr.is_empty() && !_ct_bs->is_card_claimed(index)) { |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
140 // We make the card as "claimed" lazily (so races are possible |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
141 // but they're benign), which reduces the number of duplicate |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
142 // scans (the rsets of the regions in the cset can intersect). |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
143 _ct_bs->set_card_claimed(index); |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
144 _cards_done++; |
| 4023 | 145 cl.do_MemRegion(mr); |
| 342 | 146 } |
| 147 } | |
| 148 | |
| 149 void printCard(HeapRegion* card_region, size_t card_index, | |
| 150 HeapWord* card_start) { | |
| 151 gclog_or_tty->print_cr("T %d Region [" PTR_FORMAT ", " PTR_FORMAT ") " | |
| 152 "RS names card %p: " | |
| 153 "[" PTR_FORMAT ", " PTR_FORMAT ")", | |
| 154 _worker_i, | |
| 155 card_region->bottom(), card_region->end(), | |
| 156 card_index, | |
| 157 card_start, card_start + G1BlockOffsetSharedArray::N_words); | |
| 158 } | |
| 159 | |
| 160 bool doHeapRegion(HeapRegion* r) { | |
| 161 assert(r->in_collection_set(), "should only be called on elements of CS."); | |
| 162 HeapRegionRemSet* hrrs = r->rem_set(); | |
| 163 if (hrrs->iter_is_complete()) return false; // All done. | |
| 164 if (!_try_claimed && !hrrs->claim_iter()) return false; | |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
165 // If we ever free the collection set concurrently, we should also |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
166 // clear the card table concurrently therefore we won't need to |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
167 // add regions of the collection set to the dirty cards region. |
|
796
29e7d79232b9
6819065: G1: eliminate high serial card table clearing time
apetrusenko
parents:
794
diff
changeset
|
168 _g1h->push_dirty_cards_region(r); |
| 342 | 169 // If we didn't return above, then |
| 170 // _try_claimed || r->claim_iter() | |
| 171 // is true: either we're supposed to work on claimed-but-not-complete | |
| 172 // regions, or we successfully claimed the region. | |
|
10182
5c93c1f61226
8011724: G1: Stack allocate instances of HeapRegionRemSetIterator
johnc
parents:
6725
diff
changeset
|
173 HeapRegionRemSetIterator iter(hrrs); |
| 342 | 174 size_t card_index; |
| 1261 | 175 |
| 176 // We claim cards in block so as to recude the contention. The block size is determined by | |
| 177 // the G1RSetScanBlockSize parameter. | |
| 178 size_t jump_to_card = hrrs->iter_claimed_next(_block_size); | |
|
10182
5c93c1f61226
8011724: G1: Stack allocate instances of HeapRegionRemSetIterator
johnc
parents:
6725
diff
changeset
|
179 for (size_t current_card = 0; iter.has_next(card_index); current_card++) { |
| 1261 | 180 if (current_card >= jump_to_card + _block_size) { |
| 181 jump_to_card = hrrs->iter_claimed_next(_block_size); | |
| 747 | 182 } |
| 1261 | 183 if (current_card < jump_to_card) continue; |
| 342 | 184 HeapWord* card_start = _g1h->bot_shared()->address_for_index(card_index); |
| 185 #if 0 | |
| 186 gclog_or_tty->print("Rem set iteration yielded card [" PTR_FORMAT ", " PTR_FORMAT ").\n", | |
| 187 card_start, card_start + CardTableModRefBS::card_size_in_words); | |
| 188 #endif | |
| 189 | |
| 190 HeapRegion* card_region = _g1h->heap_region_containing(card_start); | |
| 191 assert(card_region != NULL, "Yielding cards not in the heap?"); | |
| 192 _cards++; | |
| 193 | |
|
796
29e7d79232b9
6819065: G1: eliminate high serial card table clearing time
apetrusenko
parents:
794
diff
changeset
|
194 if (!card_region->is_on_dirty_cards_region_list()) { |
|
29e7d79232b9
6819065: G1: eliminate high serial card table clearing time
apetrusenko
parents:
794
diff
changeset
|
195 _g1h->push_dirty_cards_region(card_region); |
|
29e7d79232b9
6819065: G1: eliminate high serial card table clearing time
apetrusenko
parents:
794
diff
changeset
|
196 } |
|
29e7d79232b9
6819065: G1: eliminate high serial card table clearing time
apetrusenko
parents:
794
diff
changeset
|
197 |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
198 // If the card is dirty, then we will scan it during updateRS. |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
199 if (!card_region->in_collection_set() && |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
200 !_ct_bs->is_card_dirty(card_index)) { |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
201 scanCard(card_index, card_region); |
| 342 | 202 } |
| 203 } | |
| 747 | 204 if (!_try_claimed) { |
| 205 hrrs->set_iter_complete(); | |
| 206 } | |
| 342 | 207 return false; |
| 208 } | |
| 209 size_t cards_done() { return _cards_done;} | |
| 210 size_t cards_looked_up() { return _cards;} | |
| 211 }; | |
| 212 | |
| 1861 | 213 void G1RemSet::scanRS(OopsInHeapRegionClosure* oc, int worker_i) { |
| 342 | 214 double rs_time_start = os::elapsedTime(); |
|
4097
dc467e8b2c5e
7112743: G1: Reduce overhead of marking closure during evacuation pauses
johnc
parents:
4095
diff
changeset
|
215 HeapRegion *startRegion = _g1->start_cset_region_for_worker(worker_i); |
| 342 | 216 |
| 1261 | 217 ScanRSClosure scanRScl(oc, worker_i); |
|
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3777
diff
changeset
|
218 |
| 342 | 219 _g1->collection_set_iterate_from(startRegion, &scanRScl); |
| 220 scanRScl.set_try_claimed(); | |
| 221 _g1->collection_set_iterate_from(startRegion, &scanRScl); | |
| 222 | |
| 1261 | 223 double scan_rs_time_sec = os::elapsedTime() - rs_time_start; |
| 342 | 224 |
| 225 assert( _cards_scanned != NULL, "invariant" ); | |
| 226 _cards_scanned[worker_i] = scanRScl.cards_done(); | |
| 227 | |
|
6219
922993931b3d
7178361: G1: Make sure that PrintGC and PrintGCDetails use the same timing for the GC pause
brutisso
parents:
4839
diff
changeset
|
228 _g1p->phase_times()->record_scan_rs_time(worker_i, scan_rs_time_sec * 1000.0); |
| 342 | 229 } |
| 230 | |
| 1705 | 231 // Closure used for updating RSets and recording references that |
| 232 // point into the collection set. Only called during an | |
| 233 // evacuation pause. | |
| 234 | |
| 235 class RefineRecordRefsIntoCSCardTableEntryClosure: public CardTableEntryClosure { | |
| 236 G1RemSet* _g1rs; | |
| 237 DirtyCardQueue* _into_cset_dcq; | |
| 238 public: | |
| 239 RefineRecordRefsIntoCSCardTableEntryClosure(G1CollectedHeap* g1h, | |
| 240 DirtyCardQueue* into_cset_dcq) : | |
| 241 _g1rs(g1h->g1_rem_set()), _into_cset_dcq(into_cset_dcq) | |
| 242 {} | |
| 243 bool do_card_ptr(jbyte* card_ptr, int worker_i) { | |
| 244 // The only time we care about recording cards that | |
| 245 // contain references that point into the collection set | |
| 246 // is during RSet updating within an evacuation pause. | |
| 247 // In this case worker_i should be the id of a GC worker thread. | |
| 248 assert(SafepointSynchronize::is_at_safepoint(), "not during an evacuation pause"); | |
|
2364
04d1138b4cce
7023747: G1: too strict assert in RefineRecordRefsIntoCSCardTableEntryClosure::do_card_ptr in g1RemSet.cpp
brutisso
parents:
2361
diff
changeset
|
249 assert(worker_i < (int) (ParallelGCThreads == 0 ? 1 : ParallelGCThreads), "should be a GC worker"); |
| 342 | 250 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
251 if (_g1rs->refine_card(card_ptr, worker_i, true)) { |
| 1705 | 252 // 'card_ptr' contains references that point into the collection |
| 253 // set. We need to record the card in the DCQS | |
| 254 // (G1CollectedHeap::into_cset_dirty_card_queue_set()) | |
| 255 // that's used for that purpose. | |
| 256 // | |
| 257 // Enqueue the card | |
| 258 _into_cset_dcq->enqueue(card_ptr); | |
| 259 } | |
| 260 return true; | |
| 261 } | |
| 262 }; | |
| 263 | |
| 1861 | 264 void G1RemSet::updateRS(DirtyCardQueue* into_cset_dcq, int worker_i) { |
| 342 | 265 double start = os::elapsedTime(); |
| 1705 | 266 // Apply the given closure to all remaining log entries. |
| 267 RefineRecordRefsIntoCSCardTableEntryClosure into_cset_update_rs_cl(_g1, into_cset_dcq); | |
|
3979
4dfb2df418f2
6484982: G1: process references during evacuation pauses
johnc
parents:
3777
diff
changeset
|
268 |
| 1705 | 269 _g1->iterate_dirty_card_closure(&into_cset_update_rs_cl, into_cset_dcq, false, worker_i); |
| 270 | |
| 794 | 271 // Now there should be no dirty cards. |
| 272 if (G1RSLogCheckCardTable) { | |
| 273 CountNonCleanMemRegionClosure cl(_g1); | |
| 274 _ct_bs->mod_card_iterate(&cl); | |
| 275 // XXX This isn't true any more: keeping cards of young regions | |
| 276 // marked dirty broke it. Need some reasonable fix. | |
| 277 guarantee(cl.n() == 0, "Card table should be clean."); | |
| 342 | 278 } |
| 794 | 279 |
|
6219
922993931b3d
7178361: G1: Make sure that PrintGC and PrintGCDetails use the same timing for the GC pause
brutisso
parents:
4839
diff
changeset
|
280 _g1p->phase_times()->record_update_rs_time(worker_i, (os::elapsedTime() - start) * 1000.0); |
| 342 | 281 } |
| 282 | |
| 1861 | 283 void G1RemSet::cleanupHRRS() { |
| 342 | 284 HeapRegionRemSet::cleanup(); |
| 285 } | |
| 286 | |
| 1861 | 287 void G1RemSet::oops_into_collection_set_do(OopsInHeapRegionClosure* oc, |
| 342 | 288 int worker_i) { |
| 289 #if CARD_REPEAT_HISTO | |
| 290 ct_freq_update_histo_and_reset(); | |
| 291 #endif | |
| 292 | |
| 1705 | 293 // We cache the value of 'oc' closure into the appropriate slot in the |
| 294 // _cset_rs_update_cl for this worker | |
| 295 assert(worker_i < (int)n_workers(), "sanity"); | |
| 296 _cset_rs_update_cl[worker_i] = oc; | |
| 297 | |
| 298 // A DirtyCardQueue that is used to hold cards containing references | |
| 299 // that point into the collection set. This DCQ is associated with a | |
| 300 // special DirtyCardQueueSet (see g1CollectedHeap.hpp). Under normal | |
| 301 // circumstances (i.e. the pause successfully completes), these cards | |
| 302 // are just discarded (there's no need to update the RSets of regions | |
| 303 // that were in the collection set - after the pause these regions | |
| 304 // are wholly 'free' of live objects. In the event of an evacuation | |
| 305 // failure the cards/buffers in this queue set are: | |
| 306 // * passed to the DirtyCardQueueSet that is used to manage deferred | |
| 307 // RSet updates, or | |
| 308 // * scanned for references that point into the collection set | |
| 309 // and the RSet of the corresponding region in the collection set | |
| 310 // is updated immediately. | |
| 311 DirtyCardQueue into_cset_dcq(&_g1->into_cset_dirty_card_queue_set()); | |
| 312 | |
|
1708
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
313 assert((ParallelGCThreads > 0) || worker_i == 0, "invariant"); |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
314 |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
315 // The two flags below were introduced temporarily to serialize |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
316 // the updating and scanning of remembered sets. There are some |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
317 // race conditions when these two operations are done in parallel |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
318 // and they are causing failures. When we resolve said race |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
319 // conditions, we'll revert back to parallel remembered set |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
320 // updating and scanning. See CRs 6677707 and 6677708. |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
321 if (G1UseParallelRSetUpdating || (worker_i == 0)) { |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
322 updateRS(&into_cset_dcq, worker_i); |
| 342 | 323 } else { |
|
6628
bb3f6194fedb
7178363: G1: Remove the serial code for PrintGCDetails and make it a special case of the parallel code
brutisso
parents:
6254
diff
changeset
|
324 _g1p->phase_times()->record_update_rs_processed_buffers(worker_i, 0); |
|
6219
922993931b3d
7178361: G1: Make sure that PrintGC and PrintGCDetails use the same timing for the GC pause
brutisso
parents:
4839
diff
changeset
|
325 _g1p->phase_times()->record_update_rs_time(worker_i, 0.0); |
|
1708
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
326 } |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
327 if (G1UseParallelRSetScanning || (worker_i == 0)) { |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
328 scanRS(oc, worker_i); |
|
a03ae377b2e8
6930581: G1: assert(ParallelGCThreads > 1 || n_yielded() == _hrrs->occupied(),"Should have yielded all the ..
johnc
parents:
1705
diff
changeset
|
329 } else { |
|
6219
922993931b3d
7178361: G1: Make sure that PrintGC and PrintGCDetails use the same timing for the GC pause
brutisso
parents:
4839
diff
changeset
|
330 _g1p->phase_times()->record_scan_rs_time(worker_i, 0.0); |
| 342 | 331 } |
| 1705 | 332 |
| 333 // We now clear the cached values of _cset_rs_update_cl for this worker | |
| 334 _cset_rs_update_cl[worker_i] = NULL; | |
| 342 | 335 } |
| 336 | |
| 1861 | 337 void G1RemSet::prepare_for_oops_into_collection_set_do() { |
| 342 | 338 cleanupHRRS(); |
| 339 ConcurrentG1Refine* cg1r = _g1->concurrent_g1_refine(); | |
| 340 _g1->set_refine_cte_cl_concurrency(false); | |
| 341 DirtyCardQueueSet& dcqs = JavaThread::dirty_card_queue_set(); | |
| 342 dcqs.concatenate_logs(); | |
| 343 | |
|
4095
bca17e38de00
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
4090
diff
changeset
|
344 if (G1CollectedHeap::use_parallel_gc_threads()) { |
|
bca17e38de00
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
4090
diff
changeset
|
345 // Don't set the number of workers here. It will be set |
|
bca17e38de00
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
4090
diff
changeset
|
346 // when the task is run |
|
bca17e38de00
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
4090
diff
changeset
|
347 // _seq_task->set_n_termination((int)n_workers()); |
| 342 | 348 } |
| 349 guarantee( _cards_scanned == NULL, "invariant" ); | |
| 6197 | 350 _cards_scanned = NEW_C_HEAP_ARRAY(size_t, n_workers(), mtGC); |
| 545 | 351 for (uint i = 0; i < n_workers(); ++i) { |
| 352 _cards_scanned[i] = 0; | |
| 353 } | |
| 342 | 354 _total_cards_scanned = 0; |
| 355 } | |
| 356 | |
| 357 | |
| 1705 | 358 // This closure, applied to a DirtyCardQueueSet, is used to immediately |
| 359 // update the RSets for the regions in the CSet. For each card it iterates | |
| 360 // through the oops which coincide with that card. It scans the reference | |
| 361 // fields in each oop; when it finds an oop that points into the collection | |
| 362 // set, the RSet for the region containing the referenced object is updated. | |
| 363 class UpdateRSetCardTableEntryIntoCSetClosure: public CardTableEntryClosure { | |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
364 G1CollectedHeap* _g1; |
|
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
365 CardTableModRefBS* _ct_bs; |
|
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
366 public: |
| 1705 | 367 UpdateRSetCardTableEntryIntoCSetClosure(G1CollectedHeap* g1, |
| 368 CardTableModRefBS* bs): | |
| 369 _g1(g1), _ct_bs(bs) | |
| 370 { } | |
| 371 | |
| 372 bool do_card_ptr(jbyte* card_ptr, int worker_i) { | |
| 373 // Construct the region representing the card. | |
| 374 HeapWord* start = _ct_bs->addr_for(card_ptr); | |
| 375 // And find the region containing it. | |
| 376 HeapRegion* r = _g1->heap_region_containing(start); | |
| 377 assert(r != NULL, "unexpected null"); | |
| 378 | |
| 379 // Scan oops in the card looking for references into the collection set | |
|
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
380 // Don't use addr_for(card_ptr + 1) which can ask for |
|
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
381 // a card beyond the heap. This is not safe without a perm |
|
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
382 // gen. |
|
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
383 HeapWord* end = start + CardTableModRefBS::card_size_in_words; |
| 1705 | 384 MemRegion scanRegion(start, end); |
| 385 | |
| 386 UpdateRSetImmediate update_rs_cl(_g1->g1_rem_set()); | |
|
3983
811ec3d0833b
7097053: G1: assert(da ? referent->is_oop() : referent->is_oop_or_null()) failed: referenceProcessor.cpp:1054
johnc
parents:
3979
diff
changeset
|
387 FilterIntoCSClosure update_rs_cset_oop_cl(NULL, _g1, &update_rs_cl); |
| 1705 | 388 FilterOutOfRegionClosure filter_then_update_rs_cset_oop_cl(r, &update_rs_cset_oop_cl); |
| 389 | |
| 390 // We can pass false as the "filter_young" parameter here as: | |
| 391 // * we should be in a STW pause, | |
| 392 // * the DCQS to which this closure is applied is used to hold | |
| 393 // references that point into the collection set from the prior | |
| 394 // RSet updating, | |
| 395 // * the post-write barrier shouldn't be logging updates to young | |
| 396 // regions (but there is a situation where this can happen - see | |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
397 // the comment in G1RemSet::refine_card() below - |
| 1705 | 398 // that should not be applicable here), and |
| 399 // * during actual RSet updating, the filtering of cards in young | |
| 400 // regions in HeapRegion::oops_on_card_seq_iterate_careful is | |
| 401 // employed. | |
| 402 // As a result, when this closure is applied to "refs into cset" | |
| 403 // DCQS, we shouldn't see any cards in young regions. | |
| 404 update_rs_cl.set_region(r); | |
| 405 HeapWord* stop_point = | |
| 406 r->oops_on_card_seq_iterate_careful(scanRegion, | |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
407 &filter_then_update_rs_cset_oop_cl, |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
408 false /* filter_young */, |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
409 NULL /* card_ptr */); |
| 1705 | 410 |
| 411 // Since this is performed in the event of an evacuation failure, we | |
| 412 // we shouldn't see a non-null stop point | |
| 413 assert(stop_point == NULL, "saw an unallocated region"); | |
| 414 return true; | |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
415 } |
|
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
416 }; |
|
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
417 |
| 1861 | 418 void G1RemSet::cleanup_after_oops_into_collection_set_do() { |
| 342 | 419 guarantee( _cards_scanned != NULL, "invariant" ); |
| 420 _total_cards_scanned = 0; | |
|
3777
e8b0b0392037
7046182: G1: remove unnecessary iterations over the collection set
tonyp
parents:
3765
diff
changeset
|
421 for (uint i = 0; i < n_workers(); ++i) { |
| 342 | 422 _total_cards_scanned += _cards_scanned[i]; |
|
3777
e8b0b0392037
7046182: G1: remove unnecessary iterations over the collection set
tonyp
parents:
3765
diff
changeset
|
423 } |
| 6197 | 424 FREE_C_HEAP_ARRAY(size_t, _cards_scanned, mtGC); |
| 342 | 425 _cards_scanned = NULL; |
| 426 // Cleanup after copy | |
| 427 _g1->set_refine_cte_cl_concurrency(true); | |
| 428 // Set all cards back to clean. | |
| 429 _g1->cleanUpCardTable(); | |
| 794 | 430 |
| 1705 | 431 DirtyCardQueueSet& into_cset_dcqs = _g1->into_cset_dirty_card_queue_set(); |
| 432 int into_cset_n_buffers = into_cset_dcqs.completed_buffers_num(); | |
| 433 | |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
434 if (_g1->evacuation_failed()) { |
| 1705 | 435 // Restore remembered sets for the regions pointing into the collection set. |
| 436 | |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
437 if (G1DeferredRSUpdate) { |
| 1705 | 438 // If deferred RS updates are enabled then we just need to transfer |
| 439 // the completed buffers from (a) the DirtyCardQueueSet used to hold | |
| 440 // cards that contain references that point into the collection set | |
| 441 // to (b) the DCQS used to hold the deferred RS updates | |
| 442 _g1->dirty_card_queue_set().merge_bufferlists(&into_cset_dcqs); | |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
443 } else { |
| 1705 | 444 |
| 445 CardTableModRefBS* bs = (CardTableModRefBS*)_g1->barrier_set(); | |
| 446 UpdateRSetCardTableEntryIntoCSetClosure update_rs_cset_immediate(_g1, bs); | |
| 447 | |
| 448 int n_completed_buffers = 0; | |
| 449 while (into_cset_dcqs.apply_closure_to_completed_buffer(&update_rs_cset_immediate, | |
| 450 0, 0, true)) { | |
| 451 n_completed_buffers++; | |
| 452 } | |
| 453 assert(n_completed_buffers == into_cset_n_buffers, "missed some buffers"); | |
|
616
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
454 } |
|
4f360ec815ba
6720309: G1: don't synchronously update RSet during evacuation pauses
iveresov
parents:
545
diff
changeset
|
455 } |
| 1705 | 456 |
| 457 // Free any completed buffers in the DirtyCardQueueSet used to hold cards | |
| 458 // which contain references that point into the collection. | |
| 459 _g1->into_cset_dirty_card_queue_set().clear(); | |
| 460 assert(_g1->into_cset_dirty_card_queue_set().completed_buffers_num() == 0, | |
| 461 "all buffers should be freed"); | |
| 462 _g1->into_cset_dirty_card_queue_set().clear_n_completed_buffers(); | |
| 342 | 463 } |
| 464 | |
| 465 class ScrubRSClosure: public HeapRegionClosure { | |
| 466 G1CollectedHeap* _g1h; | |
| 467 BitMap* _region_bm; | |
| 468 BitMap* _card_bm; | |
| 469 CardTableModRefBS* _ctbs; | |
| 470 public: | |
| 471 ScrubRSClosure(BitMap* region_bm, BitMap* card_bm) : | |
| 472 _g1h(G1CollectedHeap::heap()), | |
| 473 _region_bm(region_bm), _card_bm(card_bm), | |
| 474 _ctbs(NULL) | |
| 475 { | |
| 476 ModRefBarrierSet* bs = _g1h->mr_bs(); | |
| 477 guarantee(bs->is_a(BarrierSet::CardTableModRef), "Precondition"); | |
| 478 _ctbs = (CardTableModRefBS*)bs; | |
| 479 } | |
| 480 | |
| 481 bool doHeapRegion(HeapRegion* r) { | |
| 482 if (!r->continuesHumongous()) { | |
| 483 r->rem_set()->scrub(_ctbs, _region_bm, _card_bm); | |
| 484 } | |
| 485 return false; | |
| 486 } | |
| 487 }; | |
| 488 | |
| 1861 | 489 void G1RemSet::scrub(BitMap* region_bm, BitMap* card_bm) { |
| 342 | 490 ScrubRSClosure scrub_cl(region_bm, card_bm); |
| 491 _g1->heap_region_iterate(&scrub_cl); | |
| 492 } | |
| 493 | |
| 1861 | 494 void G1RemSet::scrub_par(BitMap* region_bm, BitMap* card_bm, |
|
4728
441e946dc1af
7121618: Change type of number of GC workers to unsigned int.
jmasa
parents:
4097
diff
changeset
|
495 uint worker_num, int claim_val) { |
| 342 | 496 ScrubRSClosure scrub_cl(region_bm, card_bm); |
|
4095
bca17e38de00
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
4090
diff
changeset
|
497 _g1->heap_region_par_iterate_chunked(&scrub_cl, |
|
bca17e38de00
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
4090
diff
changeset
|
498 worker_num, |
|
4728
441e946dc1af
7121618: Change type of number of GC workers to unsigned int.
jmasa
parents:
4097
diff
changeset
|
499 n_workers(), |
|
4095
bca17e38de00
6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
jmasa
parents:
4090
diff
changeset
|
500 claim_val); |
| 342 | 501 } |
| 502 | |
| 4839 | 503 G1TriggerClosure::G1TriggerClosure() : |
| 504 _triggered(false) { } | |
| 505 | |
| 506 G1InvokeIfNotTriggeredClosure::G1InvokeIfNotTriggeredClosure(G1TriggerClosure* t_cl, | |
| 507 OopClosure* oop_cl) : | |
| 508 _trigger_cl(t_cl), _oop_cl(oop_cl) { } | |
| 1705 | 509 |
| 4839 | 510 G1Mux2Closure::G1Mux2Closure(OopClosure *c1, OopClosure *c2) : |
| 511 _c1(c1), _c2(c2) { } | |
| 1705 | 512 |
| 4839 | 513 G1UpdateRSOrPushRefOopClosure:: |
| 514 G1UpdateRSOrPushRefOopClosure(G1CollectedHeap* g1h, | |
| 515 G1RemSet* rs, | |
| 516 OopsInHeapRegionClosure* push_ref_cl, | |
| 517 bool record_refs_into_cset, | |
| 518 int worker_i) : | |
| 519 _g1(g1h), _g1_rem_set(rs), _from(NULL), | |
| 520 _record_refs_into_cset(record_refs_into_cset), | |
| 521 _push_ref_cl(push_ref_cl), _worker_i(worker_i) { } | |
| 1705 | 522 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
523 // Returns true if the given card contains references that point |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
524 // into the collection set, if we're checking for such references; |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
525 // false otherwise. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
526 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
527 bool G1RemSet::refine_card(jbyte* card_ptr, int worker_i, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
528 bool check_for_refs_into_cset) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
529 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
530 // If the card is no longer dirty, nothing to do. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
531 if (*card_ptr != CardTableModRefBS::dirty_card_val()) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
532 // No need to return that this card contains refs that point |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
533 // into the collection set. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
534 return false; |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
535 } |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
536 |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
537 // Construct the region representing the card. |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
538 HeapWord* start = _ct_bs->addr_for(card_ptr); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
539 // And find the region containing it. |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
540 HeapRegion* r = _g1->heap_region_containing(start); |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
541 if (r == NULL) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
542 // Again no need to return that this card contains refs that |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
543 // point into the collection set. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
544 return false; // Not in the G1 heap (might be in perm, for example.) |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
545 } |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
546 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
547 // Why do we have to check here whether a card is on a young region, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
548 // given that we dirty young regions and, as a result, the |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
549 // post-barrier is supposed to filter them out and never to enqueue |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
550 // them? When we allocate a new region as the "allocation region" we |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
551 // actually dirty its cards after we release the lock, since card |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
552 // dirtying while holding the lock was a performance bottleneck. So, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
553 // as a result, it is possible for other threads to actually |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
554 // allocate objects in the region (after the acquire the lock) |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
555 // before all the cards on the region are dirtied. This is unlikely, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
556 // and it doesn't happen often, but it can happen. So, the extra |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
557 // check below filters out those cards. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
558 if (r->is_young()) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
559 return false; |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
560 } |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
561 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
562 // While we are processing RSet buffers during the collection, we |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
563 // actually don't want to scan any cards on the collection set, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
564 // since we don't want to update remebered sets with entries that |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
565 // point into the collection set, given that live objects from the |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
566 // collection set are about to move and such entries will be stale |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
567 // very soon. This change also deals with a reliability issue which |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
568 // involves scanning a card in the collection set and coming across |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
569 // an array that was being chunked and looking malformed. Note, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
570 // however, that if evacuation fails, we have to scan any objects |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
571 // that were not moved and create any missing entries. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
572 if (r->in_collection_set()) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
573 return false; |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
574 } |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
575 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
576 // The result from the hot card cache insert call is either: |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
577 // * pointer to the current card |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
578 // (implying that the current card is not 'hot'), |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
579 // * null |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
580 // (meaning we had inserted the card ptr into the "hot" card cache, |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
581 // which had some headroom), |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
582 // * a pointer to a "hot" card that was evicted from the "hot" cache. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
583 // |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
584 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
585 G1HotCardCache* hot_card_cache = _cg1r->hot_card_cache(); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
586 if (hot_card_cache->use_cache()) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
587 assert(!check_for_refs_into_cset, "sanity"); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
588 assert(!SafepointSynchronize::is_at_safepoint(), "sanity"); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
589 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
590 card_ptr = hot_card_cache->insert(card_ptr); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
591 if (card_ptr == NULL) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
592 // There was no eviction. Nothing to do. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
593 return false; |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
594 } |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
595 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
596 start = _ct_bs->addr_for(card_ptr); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
597 r = _g1->heap_region_containing(start); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
598 if (r == NULL) { |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
599 // Not in the G1 heap |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
600 return false; |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
601 } |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
602 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
603 // Checking whether the region we got back from the cache |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
604 // is young here is inappropriate. The region could have been |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
605 // freed, reallocated and tagged as young while in the cache. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
606 // Hence we could see its young type change at any time. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
607 } |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
608 |
|
6725
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
609 // Don't use addr_for(card_ptr + 1) which can ask for |
|
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
610 // a card beyond the heap. This is not safe without a perm |
|
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
611 // gen at the upper end of the heap. |
|
da91efe96a93
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
6628
diff
changeset
|
612 HeapWord* end = start + CardTableModRefBS::card_size_in_words; |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
613 MemRegion dirtyRegion(start, end); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
614 |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
615 #if CARD_REPEAT_HISTO |
|
2188
c33825b68624
6923430: G1: assert(res != 0,"This should have worked.")
johnc
parents:
1972
diff
changeset
|
616 init_ct_freq_table(_g1->max_capacity()); |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
617 ct_freq_note_card(_ct_bs->index_for(start)); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
618 #endif |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
619 |
|
4071
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
620 OopsInHeapRegionClosure* oops_in_heap_closure = NULL; |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
621 if (check_for_refs_into_cset) { |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
622 // ConcurrentG1RefineThreads have worker numbers larger than what |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
623 // _cset_rs_update_cl[] is set up to handle. But those threads should |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
624 // only be active outside of a collection which means that when they |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
625 // reach here they should have check_for_refs_into_cset == false. |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
626 assert((size_t)worker_i < n_workers(), "index of worker larger than _cset_rs_update_cl[].length"); |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
627 oops_in_heap_closure = _cset_rs_update_cl[worker_i]; |
|
ed80554efa25
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
brutisso
parents:
4023
diff
changeset
|
628 } |
| 4839 | 629 G1UpdateRSOrPushRefOopClosure update_rs_oop_cl(_g1, |
| 630 _g1->g1_rem_set(), | |
| 631 oops_in_heap_closure, | |
| 632 check_for_refs_into_cset, | |
| 633 worker_i); | |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
634 update_rs_oop_cl.set_from(r); |
| 1705 | 635 |
| 4839 | 636 G1TriggerClosure trigger_cl; |
|
3983
811ec3d0833b
7097053: G1: assert(da ? referent->is_oop() : referent->is_oop_or_null()) failed: referenceProcessor.cpp:1054
johnc
parents:
3979
diff
changeset
|
637 FilterIntoCSClosure into_cs_cl(NULL, _g1, &trigger_cl); |
| 4839 | 638 G1InvokeIfNotTriggeredClosure invoke_cl(&trigger_cl, &into_cs_cl); |
| 639 G1Mux2Closure mux(&invoke_cl, &update_rs_oop_cl); | |
| 1705 | 640 |
| 641 FilterOutOfRegionClosure filter_then_update_rs_oop_cl(r, | |
| 642 (check_for_refs_into_cset ? | |
| 643 (OopClosure*)&mux : | |
| 644 (OopClosure*)&update_rs_oop_cl)); | |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
645 |
|
1666
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
646 // The region for the current card may be a young region. The |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
647 // current card may have been a card that was evicted from the |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
648 // card cache. When the card was inserted into the cache, we had |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
649 // determined that its region was non-young. While in the cache, |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
650 // the region may have been freed during a cleanup pause, reallocated |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
651 // and tagged as young. |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
652 // |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
653 // We wish to filter out cards for such a region but the current |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
654 // thread, if we're running concurrently, may "see" the young type |
|
1666
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
655 // change at any time (so an earlier "is_young" check may pass or |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
656 // fail arbitrarily). We tell the iteration code to perform this |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
657 // filtering when it has been determined that there has been an actual |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
658 // allocation in this region and making it safe to check the young type. |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
659 bool filter_young = true; |
|
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
660 |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
661 HeapWord* stop_point = |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
662 r->oops_on_card_seq_iterate_careful(dirtyRegion, |
|
1666
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
663 &filter_then_update_rs_oop_cl, |
|
3317
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
664 filter_young, |
|
063382f9b575
7035144: G1: nightly failure: Non-dirty cards in region that should be dirty (failures still exist...)
tonyp
parents:
2364
diff
changeset
|
665 card_ptr); |
|
1666
5cbac8938c4c
6956639: G1: assert(cached_ptr != card_ptr) failed: shouldn't be, concurrentG1Refine.cpp:307
johnc
parents:
1611
diff
changeset
|
666 |
|
890
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
667 // If stop_point is non-null, then we encountered an unallocated region |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
668 // (perhaps the unfilled portion of a TLAB.) For now, we'll dirty the |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
669 // card and re-enqueue: if we put off the card until a GC pause, then the |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
670 // unallocated portion will be filled in. Alternatively, we might try |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
671 // the full complexity of the technique used in "regular" precleaning. |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
672 if (stop_point != NULL) { |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
673 // The card might have gotten re-dirtied and re-enqueued while we |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
674 // worked. (In fact, it's pretty likely.) |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
675 if (*card_ptr != CardTableModRefBS::dirty_card_val()) { |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
676 *card_ptr = CardTableModRefBS::dirty_card_val(); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
677 MutexLockerEx x(Shared_DirtyCardQ_lock, |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
678 Mutex::_no_safepoint_check_flag); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
679 DirtyCardQueue* sdcq = |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
680 JavaThread::dirty_card_queue_set().shared_dirty_card_queue(); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
681 sdcq->enqueue(card_ptr); |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
682 } |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
683 } else { |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
684 _conc_refine_cards++; |
|
6cb8e9df7174
6819077: G1: first GC thread coming late into the GC.
johnc
parents:
845
diff
changeset
|
685 } |
| 1705 | 686 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
687 // This gets set to true if the card being refined has |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
688 // references that point into the collection set. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
689 bool has_refs_into_cset = trigger_cl.triggered(); |
| 342 | 690 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
691 // We should only be detecting that the card contains references |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
692 // that point into the collection set if the current thread is |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
693 // a GC worker thread. |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
694 assert(!has_refs_into_cset || SafepointSynchronize::is_at_safepoint(), |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
695 "invalid result at non safepoint"); |
| 1705 | 696 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
697 return has_refs_into_cset; |
| 342 | 698 } |
| 699 | |
| 700 class HRRSStatsIter: public HeapRegionClosure { | |
| 701 size_t _occupied; | |
| 702 size_t _total_mem_sz; | |
| 703 size_t _max_mem_sz; | |
| 704 HeapRegion* _max_mem_sz_region; | |
| 705 public: | |
| 706 HRRSStatsIter() : | |
| 707 _occupied(0), | |
| 708 _total_mem_sz(0), | |
| 709 _max_mem_sz(0), | |
| 710 _max_mem_sz_region(NULL) | |
| 711 {} | |
| 712 | |
| 713 bool doHeapRegion(HeapRegion* r) { | |
| 714 if (r->continuesHumongous()) return false; | |
| 715 size_t mem_sz = r->rem_set()->mem_size(); | |
| 716 if (mem_sz > _max_mem_sz) { | |
| 717 _max_mem_sz = mem_sz; | |
| 718 _max_mem_sz_region = r; | |
| 719 } | |
| 720 _total_mem_sz += mem_sz; | |
| 721 size_t occ = r->rem_set()->occupied(); | |
| 722 _occupied += occ; | |
| 723 return false; | |
| 724 } | |
| 725 size_t total_mem_sz() { return _total_mem_sz; } | |
| 726 size_t max_mem_sz() { return _max_mem_sz; } | |
| 727 size_t occupied() { return _occupied; } | |
| 728 HeapRegion* max_mem_sz_region() { return _max_mem_sz_region; } | |
| 729 }; | |
| 730 | |
| 794 | 731 class PrintRSThreadVTimeClosure : public ThreadClosure { |
| 732 public: | |
| 733 virtual void do_thread(Thread *t) { | |
| 734 ConcurrentG1RefineThread* crt = (ConcurrentG1RefineThread*) t; | |
| 735 gclog_or_tty->print(" %5.2f", crt->vtime_accum()); | |
| 736 } | |
| 737 }; | |
| 738 | |
| 1861 | 739 void G1RemSet::print_summary_info() { |
| 342 | 740 G1CollectedHeap* g1 = G1CollectedHeap::heap(); |
| 741 | |
| 742 #if CARD_REPEAT_HISTO | |
| 743 gclog_or_tty->print_cr("\nG1 card_repeat count histogram: "); | |
| 744 gclog_or_tty->print_cr(" # of repeats --> # of cards with that number."); | |
| 745 card_repeat_count.print_on(gclog_or_tty); | |
| 746 #endif | |
| 747 | |
| 794 | 748 gclog_or_tty->print_cr("\n Concurrent RS processed %d cards", |
| 749 _conc_refine_cards); | |
| 342 | 750 DirtyCardQueueSet& dcqs = JavaThread::dirty_card_queue_set(); |
| 751 jint tot_processed_buffers = | |
| 752 dcqs.processed_buffers_mut() + dcqs.processed_buffers_rs_thread(); | |
| 753 gclog_or_tty->print_cr(" Of %d completed buffers:", tot_processed_buffers); | |
| 794 | 754 gclog_or_tty->print_cr(" %8d (%5.1f%%) by conc RS threads.", |
| 342 | 755 dcqs.processed_buffers_rs_thread(), |
| 756 100.0*(float)dcqs.processed_buffers_rs_thread()/ | |
| 757 (float)tot_processed_buffers); | |
| 758 gclog_or_tty->print_cr(" %8d (%5.1f%%) by mutator threads.", | |
| 759 dcqs.processed_buffers_mut(), | |
| 760 100.0*(float)dcqs.processed_buffers_mut()/ | |
| 761 (float)tot_processed_buffers); | |
| 794 | 762 gclog_or_tty->print_cr(" Conc RS threads times(s)"); |
| 763 PrintRSThreadVTimeClosure p; | |
| 764 gclog_or_tty->print(" "); | |
| 765 g1->concurrent_g1_refine()->threads_do(&p); | |
| 342 | 766 gclog_or_tty->print_cr(""); |
| 794 | 767 |
| 1861 | 768 HRRSStatsIter blk; |
| 769 g1->heap_region_iterate(&blk); | |
|
6254
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6220
diff
changeset
|
770 gclog_or_tty->print_cr(" Total heap region rem set sizes = "SIZE_FORMAT"K." |
|
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6220
diff
changeset
|
771 " Max = "SIZE_FORMAT"K.", |
| 1861 | 772 blk.total_mem_sz()/K, blk.max_mem_sz()/K); |
|
6254
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6220
diff
changeset
|
773 gclog_or_tty->print_cr(" Static structures = "SIZE_FORMAT"K," |
|
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6220
diff
changeset
|
774 " free_lists = "SIZE_FORMAT"K.", |
|
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6220
diff
changeset
|
775 HeapRegionRemSet::static_mem_size() / K, |
|
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6220
diff
changeset
|
776 HeapRegionRemSet::fl_mem_size() / K); |
|
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6220
diff
changeset
|
777 gclog_or_tty->print_cr(" "SIZE_FORMAT" occupied cards represented.", |
| 1861 | 778 blk.occupied()); |
|
6254
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6220
diff
changeset
|
779 HeapRegion* max_mem_sz_region = blk.max_mem_sz_region(); |
|
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6220
diff
changeset
|
780 HeapRegionRemSet* rem_set = max_mem_sz_region->rem_set(); |
|
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6220
diff
changeset
|
781 gclog_or_tty->print_cr(" Max size region = "HR_FORMAT", " |
|
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6220
diff
changeset
|
782 "size = "SIZE_FORMAT "K, occupied = "SIZE_FORMAT"K.", |
|
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6220
diff
changeset
|
783 HR_FORMAT_PARAMS(max_mem_sz_region), |
|
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6220
diff
changeset
|
784 (rem_set->mem_size() + K - 1)/K, |
|
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6220
diff
changeset
|
785 (rem_set->occupied() + K - 1)/K); |
|
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6220
diff
changeset
|
786 gclog_or_tty->print_cr(" Did %d coarsenings.", |
|
a2f7274eb6ef
7114678: G1: various small fixes, code cleanup, and refactoring
tonyp
parents:
6220
diff
changeset
|
787 HeapRegionRemSet::n_coarsenings()); |
| 342 | 788 } |
| 1705 | 789 |
| 1861 | 790 void G1RemSet::prepare_for_verify() { |
|
637
25e146966e7c
6817419: G1: Enable extensive verification for humongous regions
iveresov
parents:
626
diff
changeset
|
791 if (G1HRRSFlushLogBuffersOnVerify && |
|
25e146966e7c
6817419: G1: Enable extensive verification for humongous regions
iveresov
parents:
626
diff
changeset
|
792 (VerifyBeforeGC || VerifyAfterGC) |
|
25e146966e7c
6817419: G1: Enable extensive verification for humongous regions
iveresov
parents:
626
diff
changeset
|
793 && !_g1->full_collection()) { |
| 342 | 794 cleanupHRRS(); |
| 795 _g1->set_refine_cte_cl_concurrency(false); | |
| 796 if (SafepointSynchronize::is_at_safepoint()) { | |
| 797 DirtyCardQueueSet& dcqs = JavaThread::dirty_card_queue_set(); | |
| 798 dcqs.concatenate_logs(); | |
| 799 } | |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
800 |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
801 G1HotCardCache* hot_card_cache = _cg1r->hot_card_cache(); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
802 bool use_hot_card_cache = hot_card_cache->use_cache(); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
803 hot_card_cache->set_use_cache(false); |
|
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
804 |
| 1705 | 805 DirtyCardQueue into_cset_dcq(&_g1->into_cset_dirty_card_queue_set()); |
| 806 updateRS(&into_cset_dcq, 0); | |
| 807 _g1->into_cset_dirty_card_queue_set().clear(); | |
|
637
25e146966e7c
6817419: G1: Enable extensive verification for humongous regions
iveresov
parents:
626
diff
changeset
|
808 |
|
10246
194f52aa2f23
7176479: G1: JVM crashes on T5-8 system with 1.5 TB heap
johnc
parents:
10182
diff
changeset
|
809 hot_card_cache->set_use_cache(use_hot_card_cache); |
|
637
25e146966e7c
6817419: G1: Enable extensive verification for humongous regions
iveresov
parents:
626
diff
changeset
|
810 assert(JavaThread::dirty_card_queue_set().completed_buffers_num() == 0, "All should be consumed"); |
| 342 | 811 } |
| 812 } |