Mercurial > hg > truffle
annotate src/share/vm/opto/bytecodeInfo.cpp @ 10259:39ead0411f07
8013875: Incorrect vtable index being set during methodHandle creation for static
Summary: Set vtable index as appropriate for static interface methods and for interface methods invoked via invokespecial. To be improved in a later enhancement to CallInfo.
Reviewed-by: jrose, twisti
author | bharadwaj |
---|---|
date | Wed, 08 May 2013 14:18:03 -0700 |
parents | 80208f353616 |
children | b9a918201d47 6f3fd5150b67 |
rev | line source |
---|---|
0 | 1 /* |
6842
b9a9ed0f8eeb
7197424: update copyright year to match last edit in jdk8 hotspot repository
mikael
parents:
6266
diff
changeset
|
2 * Copyright (c) 1998, 2012, Oracle and/or its affiliates. All rights reserved. |
0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 * | |
5 * This code is free software; you can redistribute it and/or modify it | |
6 * under the terms of the GNU General Public License version 2 only, as | |
7 * published by the Free Software Foundation. | |
8 * | |
9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
12 * version 2 for more details (a copy is included in the LICENSE file that | |
13 * accompanied this code). | |
14 * | |
15 * You should have received a copy of the GNU General Public License version | |
16 * 2 along with this work; if not, write to the Free Software Foundation, | |
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
18 * | |
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1507
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1507
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1507
diff
changeset
|
21 * questions. |
0 | 22 * |
23 */ | |
24 | |
1972 | 25 #include "precompiled.hpp" |
6972
bd7a7ce2e264
6830717: replay of compilations would help with debugging
minqi
parents:
6853
diff
changeset
|
26 #include "ci/ciReplay.hpp" |
1972 | 27 #include "classfile/systemDictionary.hpp" |
28 #include "classfile/vmSymbols.hpp" | |
2405
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
29 #include "compiler/compileBroker.hpp" |
1972 | 30 #include "compiler/compileLog.hpp" |
31 #include "interpreter/linkResolver.hpp" | |
32 #include "oops/objArrayKlass.hpp" | |
33 #include "opto/callGenerator.hpp" | |
34 #include "opto/parse.hpp" | |
35 #include "runtime/handles.inline.hpp" | |
0 | 36 |
37 //============================================================================= | |
38 //------------------------------InlineTree------------------------------------- | |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
39 InlineTree::InlineTree(Compile* c, |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
40 const InlineTree *caller_tree, ciMethod* callee, |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
41 JVMState* caller_jvms, int caller_bci, |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
42 float site_invoke_ratio, int max_inline_level) : |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
43 C(c), |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
44 _caller_jvms(caller_jvms), |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
45 _caller_tree((InlineTree*) caller_tree), |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
46 _method(callee), |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
47 _site_invoke_ratio(site_invoke_ratio), |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
48 _max_inline_level(max_inline_level), |
7473 | 49 _count_inline_bcs(method()->code_size_for_inlining()), |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
50 _subtrees(c->comp_arena(), 2, 0, NULL), |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
51 _msg(NULL) |
1157
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
52 { |
0 | 53 NOT_PRODUCT(_count_inlines = 0;) |
54 if (_caller_jvms != NULL) { | |
55 // Keep a private copy of the caller_jvms: | |
56 _caller_jvms = new (C) JVMState(caller_jvms->method(), caller_tree->caller_jvms()); | |
57 _caller_jvms->set_bci(caller_jvms->bci()); | |
900
9987d9d5eb0e
6833129: specjvm98 fails with NullPointerException in the compiler with -XX:DeoptimizeALot
cfang
parents:
726
diff
changeset
|
58 assert(!caller_jvms->should_reexecute(), "there should be no reexecute bytecode with inlining"); |
0 | 59 } |
60 assert(_caller_jvms->same_calls_as(caller_jvms), "consistent JVMS"); | |
1157
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
61 assert((caller_tree == NULL ? 0 : caller_tree->stack_depth() + 1) == stack_depth(), "correct (redundant) depth parameter"); |
0 | 62 assert(caller_bci == this->caller_bci(), "correct (redundant) bci parameter"); |
63 if (UseOldInlining) { | |
64 // Update hierarchical counts, count_inline_bcs() and count_inlines() | |
65 InlineTree *caller = (InlineTree *)caller_tree; | |
66 for( ; caller != NULL; caller = ((InlineTree *)(caller->caller_tree())) ) { | |
67 caller->_count_inline_bcs += count_inline_bcs(); | |
68 NOT_PRODUCT(caller->_count_inlines++;) | |
69 } | |
70 } | |
71 } | |
72 | |
1157
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
73 InlineTree::InlineTree(Compile* c, ciMethod* callee_method, JVMState* caller_jvms, |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
74 float site_invoke_ratio, int max_inline_level) : |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
75 C(c), |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
76 _caller_jvms(caller_jvms), |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
77 _caller_tree(NULL), |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
78 _method(callee_method), |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
79 _site_invoke_ratio(site_invoke_ratio), |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
80 _max_inline_level(max_inline_level), |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
81 _count_inline_bcs(method()->code_size()), |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
82 _msg(NULL) |
1157
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
83 { |
0 | 84 NOT_PRODUCT(_count_inlines = 0;) |
85 assert(!UseOldInlining, "do not use for old stuff"); | |
86 } | |
87 | |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
88 static bool is_init_with_ea(ciMethod* callee_method, |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
89 ciMethod* caller_method, Compile* C) { |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
90 // True when EA is ON and a java constructor is called or |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
91 // a super constructor is called from an inlined java constructor. |
244 | 92 return C->do_escape_analysis() && EliminateAllocations && |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
93 ( callee_method->is_initializer() || |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
94 (caller_method->is_initializer() && |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
95 caller_method != C->method() && |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
96 caller_method->holder()->is_subclass_of(callee_method->holder())) |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
97 ); |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
98 } |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
99 |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
100 // positive filter: should callee be inlined? |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
101 bool InlineTree::should_inline(ciMethod* callee_method, ciMethod* caller_method, |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
102 int caller_bci, ciCallProfile& profile, |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
103 WarmCallInfo* wci_result) { |
0 | 104 // Allows targeted inlining |
105 if(callee_method->should_inline()) { | |
106 *wci_result = *(WarmCallInfo::always_hot()); | |
107 if (PrintInlining && Verbose) { | |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
108 CompileTask::print_inline_indent(inline_level()); |
0 | 109 tty->print_cr("Inlined method is hot: "); |
110 } | |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
111 set_msg("force inline by CompilerOracle"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
112 return true; |
0 | 113 } |
114 | |
3897
de847cac9235
7078382: JSR 292: don't count method handle adapters against inlining budgets
twisti
parents:
3784
diff
changeset
|
115 int size = callee_method->code_size_for_inlining(); |
0 | 116 |
117 // Check for too many throws (and not too huge) | |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
118 if(callee_method->interpreter_throwout_count() > InlineThrowCount && |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
119 size < InlineThrowMaxSize ) { |
0 | 120 wci_result->set_profit(wci_result->profit() * 100); |
121 if (PrintInlining && Verbose) { | |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
122 CompileTask::print_inline_indent(inline_level()); |
0 | 123 tty->print_cr("Inlined method with many throws (throws=%d):", callee_method->interpreter_throwout_count()); |
124 } | |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
125 set_msg("many throws"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
126 return true; |
0 | 127 } |
128 | |
129 if (!UseOldInlining) { | |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
130 set_msg("!UseOldInlining"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
131 return true; // size and frequency are represented in a new way |
0 | 132 } |
133 | |
3366
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
134 int default_max_inline_size = C->max_inline_size(); |
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
135 int inline_small_code_size = InlineSmallCode / 4; |
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
136 int max_inline_size = default_max_inline_size; |
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
137 |
0 | 138 int call_site_count = method()->scale_count(profile.count()); |
139 int invoke_count = method()->interpreter_invocation_count(); | |
3366
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
140 |
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
141 assert(invoke_count != 0, "require invocation count greater than zero"); |
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
142 int freq = call_site_count / invoke_count; |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
143 |
0 | 144 // bump the max size if the call is frequent |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
145 if ((freq >= InlineFrequencyRatio) || |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
146 (call_site_count >= InlineFrequencyCount) || |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
147 is_init_with_ea(callee_method, caller_method, C)) { |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
148 |
3366
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
149 max_inline_size = C->freq_inline_size(); |
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
150 if (size <= max_inline_size && TraceFrequencyInlining) { |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
151 CompileTask::print_inline_indent(inline_level()); |
0 | 152 tty->print_cr("Inlined frequent method (freq=%d count=%d):", freq, call_site_count); |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
153 CompileTask::print_inline_indent(inline_level()); |
0 | 154 callee_method->print(); |
155 tty->cr(); | |
156 } | |
157 } else { | |
158 // Not hot. Check for medium-sized pre-existing nmethod at cold sites. | |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
159 if (callee_method->has_compiled_code() && |
8772
80208f353616
8010222: 8007439 disabled inlining of cold accessor methods
kvn
parents:
8119
diff
changeset
|
160 callee_method->instructions_size() > inline_small_code_size) { |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
161 set_msg("already compiled into a medium method"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
162 return false; |
8772
80208f353616
8010222: 8007439 disabled inlining of cold accessor methods
kvn
parents:
8119
diff
changeset
|
163 } |
0 | 164 } |
3366
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
165 if (size > max_inline_size) { |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
166 if (max_inline_size > default_max_inline_size) { |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
167 set_msg("hot method too big"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
168 } else { |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
169 set_msg("too big"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
170 } |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
171 return false; |
0 | 172 } |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
173 return true; |
0 | 174 } |
175 | |
176 | |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
177 // negative filter: should callee NOT be inlined? |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
178 bool InlineTree::should_not_inline(ciMethod *callee_method, |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
179 ciMethod* caller_method, |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
180 WarmCallInfo* wci_result) { |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
181 |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
182 const char* fail_msg = NULL; |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
183 |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
184 // First check all inlining restrictions which are required for correctness |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
185 if ( callee_method->is_abstract()) { |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
186 fail_msg = "abstract method"; // // note: we allow ik->is_abstract() |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
187 } else if (!callee_method->holder()->is_initialized()) { |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
188 fail_msg = "method holder not initialized"; |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
189 } else if ( callee_method->is_native()) { |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
190 fail_msg = "native method"; |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
191 } else if ( callee_method->dont_inline()) { |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
192 fail_msg = "don't inline by annotation"; |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
193 } |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
194 |
0 | 195 if (!UseOldInlining) { |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
196 if (fail_msg != NULL) { |
0 | 197 *wci_result = *(WarmCallInfo::always_cold()); |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
198 set_msg(fail_msg); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
199 return true; |
0 | 200 } |
201 | |
202 if (callee_method->has_unloaded_classes_in_signature()) { | |
203 wci_result->set_profit(wci_result->profit() * 0.1); | |
204 } | |
205 | |
206 // don't inline exception code unless the top method belongs to an | |
207 // exception class | |
208 if (callee_method->holder()->is_subclass_of(C->env()->Throwable_klass())) { | |
209 ciMethod* top_method = caller_jvms() ? caller_jvms()->of_depth(1)->method() : method(); | |
210 if (!top_method->holder()->is_subclass_of(C->env()->Throwable_klass())) { | |
211 wci_result->set_profit(wci_result->profit() * 0.1); | |
212 } | |
213 } | |
214 | |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
215 if (callee_method->has_compiled_code() && |
6972
bd7a7ce2e264
6830717: replay of compilations would help with debugging
minqi
parents:
6853
diff
changeset
|
216 callee_method->instructions_size() > InlineSmallCode) { |
0 | 217 wci_result->set_profit(wci_result->profit() * 0.1); |
218 // %%% adjust wci_result->size()? | |
219 } | |
220 | |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
221 return false; |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
222 } |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
223 |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
224 // one more inlining restriction |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
225 if (fail_msg == NULL && callee_method->has_unloaded_classes_in_signature()) { |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
226 fail_msg = "unloaded signature classes"; |
0 | 227 } |
228 | |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
229 if (fail_msg != NULL) { |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
230 set_msg(fail_msg); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
231 return true; |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
232 } |
1138
dd57230ba8fe
6893268: additional dynamic language related optimizations in C2
twisti
parents:
1137
diff
changeset
|
233 |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
234 // ignore heuristic controls on inlining |
7473 | 235 if (callee_method->should_inline()) { |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
236 set_msg("force inline by CompilerOracle"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
237 return false; |
0 | 238 } |
239 | |
240 // Now perform checks which are heuristic | |
241 | |
7473 | 242 if (!callee_method->force_inline()) { |
243 if (callee_method->has_compiled_code() && | |
244 callee_method->instructions_size() > InlineSmallCode) { | |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
245 set_msg("already compiled into a big method"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
246 return true; |
7473 | 247 } |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
248 } |
0 | 249 |
250 // don't inline exception code unless the top method belongs to an | |
251 // exception class | |
252 if (caller_tree() != NULL && | |
253 callee_method->holder()->is_subclass_of(C->env()->Throwable_klass())) { | |
254 const InlineTree *top = this; | |
255 while (top->caller_tree() != NULL) top = top->caller_tree(); | |
256 ciInstanceKlass* k = top->method()->holder(); | |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
257 if (!k->is_subclass_of(C->env()->Throwable_klass())) { |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
258 set_msg("exception method"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
259 return true; |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
260 } |
0 | 261 } |
262 | |
5950
0f4014d7731b
7152961: InlineTree::should_not_inline may exit prematurely
never
parents:
3939
diff
changeset
|
263 if (callee_method->should_not_inline()) { |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
264 set_msg("disallowed by CompilerOracle"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
265 return true; |
5950
0f4014d7731b
7152961: InlineTree::should_not_inline may exit prematurely
never
parents:
3939
diff
changeset
|
266 } |
0f4014d7731b
7152961: InlineTree::should_not_inline may exit prematurely
never
parents:
3939
diff
changeset
|
267 |
6972
bd7a7ce2e264
6830717: replay of compilations would help with debugging
minqi
parents:
6853
diff
changeset
|
268 #ifndef PRODUCT |
bd7a7ce2e264
6830717: replay of compilations would help with debugging
minqi
parents:
6853
diff
changeset
|
269 if (ciReplay::should_not_inline(callee_method)) { |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
270 set_msg("disallowed by ciReplay"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
271 return true; |
6972
bd7a7ce2e264
6830717: replay of compilations would help with debugging
minqi
parents:
6853
diff
changeset
|
272 } |
bd7a7ce2e264
6830717: replay of compilations would help with debugging
minqi
parents:
6853
diff
changeset
|
273 #endif |
bd7a7ce2e264
6830717: replay of compilations would help with debugging
minqi
parents:
6853
diff
changeset
|
274 |
5950
0f4014d7731b
7152961: InlineTree::should_not_inline may exit prematurely
never
parents:
3939
diff
changeset
|
275 if (UseStringCache) { |
0f4014d7731b
7152961: InlineTree::should_not_inline may exit prematurely
never
parents:
3939
diff
changeset
|
276 // Do not inline StringCache::profile() method used only at the beginning. |
0f4014d7731b
7152961: InlineTree::should_not_inline may exit prematurely
never
parents:
3939
diff
changeset
|
277 if (callee_method->name() == ciSymbol::profile_name() && |
0f4014d7731b
7152961: InlineTree::should_not_inline may exit prematurely
never
parents:
3939
diff
changeset
|
278 callee_method->holder()->name() == ciSymbol::java_lang_StringCache()) { |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
279 set_msg("profiling method"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
280 return true; |
5950
0f4014d7731b
7152961: InlineTree::should_not_inline may exit prematurely
never
parents:
3939
diff
changeset
|
281 } |
0f4014d7731b
7152961: InlineTree::should_not_inline may exit prematurely
never
parents:
3939
diff
changeset
|
282 } |
0f4014d7731b
7152961: InlineTree::should_not_inline may exit prematurely
never
parents:
3939
diff
changeset
|
283 |
0 | 284 // use frequency-based objections only for non-trivial methods |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
285 if (callee_method->code_size() <= MaxTrivialSize) { |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
286 return false; |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
287 } |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
288 |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
289 // don't use counts with -Xcomp or CTW |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
290 if (UseInterpreter && !CompileTheWorld) { |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
291 |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
292 if (!callee_method->has_compiled_code() && |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
293 !callee_method->was_executed_more_than(0)) { |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
294 set_msg("never executed"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
295 return true; |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
296 } |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
297 |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
298 if (is_init_with_ea(callee_method, caller_method, C)) { |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
299 |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
300 // Escape Analysis: inline all executed constructors |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
301 |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
302 } else if (!callee_method->was_executed_more_than(MIN2(MinInliningThreshold, |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
303 CompileThreshold >> 1))) { |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
304 set_msg("executed < MinInliningThreshold times"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
305 return true; |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
306 } |
0 | 307 } |
308 | |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
309 return false; |
0 | 310 } |
311 | |
312 //-----------------------------try_to_inline----------------------------------- | |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
313 // return true if ok |
0 | 314 // Relocated from "InliningClosure::try_to_inline" |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
315 bool InlineTree::try_to_inline(ciMethod* callee_method, ciMethod* caller_method, |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
316 int caller_bci, ciCallProfile& profile, |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
317 WarmCallInfo* wci_result, bool& should_delay) { |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
318 |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
319 // Old algorithm had funny accumulating BC-size counters |
0 | 320 if (UseOldInlining && ClipInlining |
321 && (int)count_inline_bcs() >= DesiredMethodLimit) { | |
7473 | 322 if (!callee_method->force_inline() || !IncrementalInline) { |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
323 set_msg("size > DesiredMethodLimit"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
324 return false; |
7473 | 325 } else if (!C->inlining_incrementally()) { |
326 should_delay = true; | |
327 } | |
0 | 328 } |
329 | |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
330 if (!should_inline(callee_method, caller_method, caller_bci, profile, |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
331 wci_result)) { |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
332 return false; |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
333 } |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
334 if (should_not_inline(callee_method, caller_method, wci_result)) { |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
335 return false; |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
336 } |
0 | 337 |
1157
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
338 if (InlineAccessors && callee_method->is_accessor()) { |
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
339 // accessor methods are not subject to any of the following limits. |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
340 set_msg("accessor"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
341 return true; |
1157
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
342 } |
0 | 343 |
344 // suppress a few checks for accessors and trivial methods | |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
345 if (callee_method->code_size() > MaxTrivialSize) { |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
346 |
0 | 347 // don't inline into giant methods |
7473 | 348 if (C->over_inlining_cutoff()) { |
349 if ((!callee_method->force_inline() && !caller_method->is_compiled_lambda_form()) | |
350 || !IncrementalInline) { | |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
351 set_msg("NodeCountInliningCutoff"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
352 return false; |
7473 | 353 } else { |
354 should_delay = true; | |
355 } | |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
356 } |
0 | 357 |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
358 if ((!UseInterpreter || CompileTheWorld) && |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
359 is_init_with_ea(callee_method, caller_method, C)) { |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
360 |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
361 // Escape Analysis stress testing when running Xcomp or CTW: |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
362 // inline constructors even if they are not reached. |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
363 |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
364 } else if (profile.count() == 0) { |
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
365 // don't inline unreached call sites |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
366 set_msg("call site not reached"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
367 return false; |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
368 } |
0 | 369 } |
370 | |
1157
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
371 if (!C->do_inlining() && InlineAccessors) { |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
372 set_msg("not an accessor"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
373 return false; |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
374 } |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
375 if (inline_level() > _max_inline_level) { |
7473 | 376 if (!callee_method->force_inline() || !IncrementalInline) { |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
377 set_msg("inlining too deep"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
378 return false; |
7473 | 379 } else if (!C->inlining_incrementally()) { |
380 should_delay = true; | |
381 } | |
41
874b2c4f43d1
6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents:
0
diff
changeset
|
382 } |
2405
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
383 |
3334
b21ecca7ccc4
6552561: MaxRecursiveInlineLevel flag doesn't operate correctly
twisti
parents:
2405
diff
changeset
|
384 // detect direct and indirect recursive inlining |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
385 if (!callee_method->is_compiled_lambda_form()) { |
3334
b21ecca7ccc4
6552561: MaxRecursiveInlineLevel flag doesn't operate correctly
twisti
parents:
2405
diff
changeset
|
386 // count the current method and the callee |
b21ecca7ccc4
6552561: MaxRecursiveInlineLevel flag doesn't operate correctly
twisti
parents:
2405
diff
changeset
|
387 int inline_level = (method() == callee_method) ? 1 : 0; |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
388 if (inline_level > MaxRecursiveInlineLevel) { |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
389 set_msg("recursively inlining too deep"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
390 return false; |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
391 } |
3334
b21ecca7ccc4
6552561: MaxRecursiveInlineLevel flag doesn't operate correctly
twisti
parents:
2405
diff
changeset
|
392 // count callers of current method and callee |
2405
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
393 JVMState* jvms = caller_jvms(); |
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
394 while (jvms != NULL && jvms->has_method()) { |
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
395 if (jvms->method() == callee_method) { |
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
396 inline_level++; |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
397 if (inline_level > MaxRecursiveInlineLevel) { |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
398 set_msg("recursively inlining too deep"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
399 return false; |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
400 } |
2405
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
401 } |
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
402 jvms = jvms->caller(); |
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
403 } |
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
404 } |
3d58a4983660
7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents:
2357
diff
changeset
|
405 |
3897
de847cac9235
7078382: JSR 292: don't count method handle adapters against inlining budgets
twisti
parents:
3784
diff
changeset
|
406 int size = callee_method->code_size_for_inlining(); |
0 | 407 |
408 if (UseOldInlining && ClipInlining | |
409 && (int)count_inline_bcs() + size >= DesiredMethodLimit) { | |
7473 | 410 if (!callee_method->force_inline() || !IncrementalInline) { |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
411 set_msg("size > DesiredMethodLimit"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
412 return false; |
7473 | 413 } else if (!C->inlining_incrementally()) { |
414 should_delay = true; | |
415 } | |
0 | 416 } |
417 | |
418 // ok, inline this method | |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
419 return true; |
0 | 420 } |
421 | |
422 //------------------------------pass_initial_checks---------------------------- | |
423 bool pass_initial_checks(ciMethod* caller_method, int caller_bci, ciMethod* callee_method) { | |
424 ciInstanceKlass *callee_holder = callee_method ? callee_method->holder() : NULL; | |
425 // Check if a callee_method was suggested | |
426 if( callee_method == NULL ) return false; | |
427 // Check if klass of callee_method is loaded | |
428 if( !callee_holder->is_loaded() ) return false; | |
429 if( !callee_holder->is_initialized() ) return false; | |
430 if( !UseInterpreter || CompileTheWorld /* running Xcomp or CTW */ ) { | |
431 // Checks that constant pool's call site has been visited | |
432 // stricter than callee_holder->is_initialized() | |
433 ciBytecodeStream iter(caller_method); | |
434 iter.force_bci(caller_bci); | |
435 Bytecodes::Code call_bc = iter.cur_bc(); | |
1137
97125851f396
6829187: compiler optimizations required for JSR 292
twisti
parents:
903
diff
changeset
|
436 // An invokedynamic instruction does not have a klass. |
97125851f396
6829187: compiler optimizations required for JSR 292
twisti
parents:
903
diff
changeset
|
437 if (call_bc != Bytecodes::_invokedynamic) { |
1565 | 438 int index = iter.get_index_u2_cpcache(); |
1137
97125851f396
6829187: compiler optimizations required for JSR 292
twisti
parents:
903
diff
changeset
|
439 if (!caller_method->is_klass_loaded(index, true)) { |
97125851f396
6829187: compiler optimizations required for JSR 292
twisti
parents:
903
diff
changeset
|
440 return false; |
97125851f396
6829187: compiler optimizations required for JSR 292
twisti
parents:
903
diff
changeset
|
441 } |
97125851f396
6829187: compiler optimizations required for JSR 292
twisti
parents:
903
diff
changeset
|
442 // Try to do constant pool resolution if running Xcomp |
97125851f396
6829187: compiler optimizations required for JSR 292
twisti
parents:
903
diff
changeset
|
443 if( !caller_method->check_call(index, call_bc == Bytecodes::_invokestatic) ) { |
97125851f396
6829187: compiler optimizations required for JSR 292
twisti
parents:
903
diff
changeset
|
444 return false; |
97125851f396
6829187: compiler optimizations required for JSR 292
twisti
parents:
903
diff
changeset
|
445 } |
0 | 446 } |
447 } | |
448 // We will attempt to see if a class/field/etc got properly loaded. If it | |
449 // did not, it may attempt to throw an exception during our probing. Catch | |
450 // and ignore such exceptions and do not attempt to compile the method. | |
451 if( callee_method->should_exclude() ) return false; | |
452 | |
453 return true; | |
454 } | |
455 | |
3900
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
456 //------------------------------check_can_parse-------------------------------- |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
457 const char* InlineTree::check_can_parse(ciMethod* callee) { |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
458 // Certain methods cannot be parsed at all: |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
459 if ( callee->is_native()) return "native method"; |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
460 if ( callee->is_abstract()) return "abstract method"; |
3900
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
461 if (!callee->can_be_compiled()) return "not compilable (disabled)"; |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
462 if (!callee->has_balanced_monitors()) return "not compilable (unbalanced monitors)"; |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
463 if ( callee->get_flow_analysis()->failing()) return "not compilable (flow analysis failed)"; |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
464 return NULL; |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
465 } |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
466 |
0 | 467 //------------------------------print_inlining--------------------------------- |
7991
60bba1398c51
8005439: no message about inline method if it specifed by CompileCommand
vlivanov
parents:
7473
diff
changeset
|
468 void InlineTree::print_inlining(ciMethod* callee_method, int caller_bci, |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
469 bool success) const { |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
470 const char* inline_msg = msg(); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
471 assert(inline_msg != NULL, "just checking"); |
7991
60bba1398c51
8005439: no message about inline method if it specifed by CompileCommand
vlivanov
parents:
7473
diff
changeset
|
472 if (C->log() != NULL) { |
60bba1398c51
8005439: no message about inline method if it specifed by CompileCommand
vlivanov
parents:
7473
diff
changeset
|
473 if (success) { |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
474 C->log()->inline_success(inline_msg); |
7991
60bba1398c51
8005439: no message about inline method if it specifed by CompileCommand
vlivanov
parents:
7473
diff
changeset
|
475 } else { |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
476 C->log()->inline_fail(inline_msg); |
7991
60bba1398c51
8005439: no message about inline method if it specifed by CompileCommand
vlivanov
parents:
7473
diff
changeset
|
477 } |
60bba1398c51
8005439: no message about inline method if it specifed by CompileCommand
vlivanov
parents:
7473
diff
changeset
|
478 } |
60bba1398c51
8005439: no message about inline method if it specifed by CompileCommand
vlivanov
parents:
7473
diff
changeset
|
479 if (PrintInlining) { |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
480 C->print_inlining(callee_method, inline_level(), caller_bci, inline_msg); |
7991
60bba1398c51
8005439: no message about inline method if it specifed by CompileCommand
vlivanov
parents:
7473
diff
changeset
|
481 if (callee_method == NULL) tty->print(" callee not monotonic or profiled"); |
60bba1398c51
8005439: no message about inline method if it specifed by CompileCommand
vlivanov
parents:
7473
diff
changeset
|
482 if (Verbose && callee_method) { |
60bba1398c51
8005439: no message about inline method if it specifed by CompileCommand
vlivanov
parents:
7473
diff
changeset
|
483 const InlineTree *top = this; |
60bba1398c51
8005439: no message about inline method if it specifed by CompileCommand
vlivanov
parents:
7473
diff
changeset
|
484 while( top->caller_tree() != NULL ) { top = top->caller_tree(); } |
60bba1398c51
8005439: no message about inline method if it specifed by CompileCommand
vlivanov
parents:
7473
diff
changeset
|
485 //tty->print(" bcs: %d+%d invoked: %d", top->count_inline_bcs(), callee_method->code_size(), callee_method->interpreter_invocation_count()); |
60bba1398c51
8005439: no message about inline method if it specifed by CompileCommand
vlivanov
parents:
7473
diff
changeset
|
486 } |
0 | 487 } |
488 } | |
489 | |
490 //------------------------------ok_to_inline----------------------------------- | |
7473 | 491 WarmCallInfo* InlineTree::ok_to_inline(ciMethod* callee_method, JVMState* jvms, ciCallProfile& profile, WarmCallInfo* initial_wci, bool& should_delay) { |
0 | 492 assert(callee_method != NULL, "caller checks for optimized virtual!"); |
7473 | 493 assert(!should_delay, "should be initialized to false"); |
0 | 494 #ifdef ASSERT |
495 // Make sure the incoming jvms has the same information content as me. | |
496 // This means that we can eventually make this whole class AllStatic. | |
497 if (jvms->caller() == NULL) { | |
498 assert(_caller_jvms == NULL, "redundant instance state"); | |
499 } else { | |
500 assert(_caller_jvms->same_calls_as(jvms->caller()), "redundant instance state"); | |
501 } | |
502 assert(_method == jvms->method(), "redundant instance state"); | |
503 #endif | |
504 int caller_bci = jvms->bci(); | |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
505 ciMethod* caller_method = jvms->method(); |
0 | 506 |
3900
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
507 // Do some initial checks. |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
508 if (!pass_initial_checks(caller_method, caller_bci, callee_method)) { |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
509 set_msg("failed initial checks"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
510 print_inlining(callee_method, caller_bci, false /* !success */); |
0 | 511 return NULL; |
512 } | |
513 | |
3900
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
514 // Do some parse checks. |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
515 set_msg(check_can_parse(callee_method)); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
516 if (msg() != NULL) { |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
517 print_inlining(callee_method, caller_bci, false /* !success */); |
3900
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
518 return NULL; |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
519 } |
a32de5085326
7079673: JSR 292: C1 should inline bytecoded method handle adapters
twisti
parents:
3897
diff
changeset
|
520 |
0 | 521 // Check if inlining policy says no. |
522 WarmCallInfo wci = *(initial_wci); | |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
523 bool success = try_to_inline(callee_method, caller_method, caller_bci, |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
524 profile, &wci, should_delay); |
0 | 525 |
526 #ifndef PRODUCT | |
527 if (UseOldInlining && InlineWarmCalls | |
528 && (PrintOpto || PrintOptoInlining || PrintInlining)) { | |
529 bool cold = wci.is_cold(); | |
530 bool hot = !cold && wci.is_hot(); | |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
531 bool old_cold = !success; |
0 | 532 if (old_cold != cold || (Verbose || WizardMode)) { |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
533 if (msg() == NULL) { |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
534 set_msg("OK"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
535 } |
0 | 536 tty->print(" OldInlining= %4s : %s\n WCI=", |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
537 old_cold ? "cold" : "hot", msg()); |
0 | 538 wci.print(); |
539 } | |
540 } | |
541 #endif | |
542 if (UseOldInlining) { | |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
543 if (success) { |
0 | 544 wci = *(WarmCallInfo::always_hot()); |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
545 } else { |
0 | 546 wci = *(WarmCallInfo::always_cold()); |
7991
60bba1398c51
8005439: no message about inline method if it specifed by CompileCommand
vlivanov
parents:
7473
diff
changeset
|
547 } |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
548 } |
0 | 549 if (!InlineWarmCalls) { |
550 if (!wci.is_cold() && !wci.is_hot()) { | |
551 // Do not inline the warm calls. | |
552 wci = *(WarmCallInfo::always_cold()); | |
553 } | |
554 } | |
555 | |
556 if (!wci.is_cold()) { | |
557 // Inline! | |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
558 if (msg() == NULL) { |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
559 set_msg("inline (hot)"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
560 } |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
561 print_inlining(callee_method, caller_bci, true /* success */); |
0 | 562 if (UseOldInlining) |
563 build_inline_tree_for_callee(callee_method, jvms, caller_bci); | |
564 if (InlineWarmCalls && !wci.is_hot()) | |
565 return new (C) WarmCallInfo(wci); // copy to heap | |
566 return WarmCallInfo::always_hot(); | |
567 } | |
568 | |
569 // Do not inline | |
8119
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
570 if (msg() == NULL) { |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
571 set_msg("too cold to inline"); |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
572 } |
133bf557ef77
8007439: C2: adding successful message of inlining
iignatyev
parents:
7991
diff
changeset
|
573 print_inlining(callee_method, caller_bci, false /* !success */ ); |
0 | 574 return NULL; |
575 } | |
576 | |
577 //------------------------------compute_callee_frequency----------------------- | |
578 float InlineTree::compute_callee_frequency( int caller_bci ) const { | |
579 int count = method()->interpreter_call_site_count(caller_bci); | |
580 int invcnt = method()->interpreter_invocation_count(); | |
581 float freq = (float)count/(float)invcnt; | |
582 // Call-site count / interpreter invocation count, scaled recursively. | |
583 // Always between 0.0 and 1.0. Represents the percentage of the method's | |
584 // total execution time used at this call site. | |
585 | |
586 return freq; | |
587 } | |
588 | |
589 //------------------------------build_inline_tree_for_callee------------------- | |
590 InlineTree *InlineTree::build_inline_tree_for_callee( ciMethod* callee_method, JVMState* caller_jvms, int caller_bci) { | |
591 float recur_frequency = _site_invoke_ratio * compute_callee_frequency(caller_bci); | |
592 // Attempt inlining. | |
593 InlineTree* old_ilt = callee_at(caller_bci, callee_method); | |
594 if (old_ilt != NULL) { | |
595 return old_ilt; | |
596 } | |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
597 int max_inline_level_adjust = 0; |
1157
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
598 if (caller_jvms->method() != NULL) { |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
599 if (caller_jvms->method()->is_compiled_lambda_form()) |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
600 max_inline_level_adjust += 1; // don't count actions in MH or indy adapter frames |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
601 else if (callee_method->is_method_handle_intrinsic() || |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
602 callee_method->is_compiled_lambda_form()) { |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
603 max_inline_level_adjust += 1; // don't count method handle calls from java.lang.invoke implem |
1157
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
604 } |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
605 if (max_inline_level_adjust != 0 && PrintInlining && (Verbose || WizardMode)) { |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
606 CompileTask::print_inline_indent(inline_level()); |
3366
e2a92dd0d3d2
7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents:
3345
diff
changeset
|
607 tty->print_cr(" \\-> discounting inline depth"); |
1157
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
608 } |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
609 if (max_inline_level_adjust != 0 && C->log()) { |
1157
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
610 int id1 = C->log()->identify(caller_jvms->method()); |
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
611 int id2 = C->log()->identify(callee_method); |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
612 C->log()->elem("inline_level_discount caller='%d' callee='%d'", id1, id2); |
1157
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
613 } |
c3b315a0d58a
6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents:
1138
diff
changeset
|
614 } |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
615 InlineTree* ilt = new InlineTree(C, this, callee_method, caller_jvms, caller_bci, recur_frequency, _max_inline_level + max_inline_level_adjust); |
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
616 _subtrees.append(ilt); |
0 | 617 |
618 NOT_PRODUCT( _count_inlines += 1; ) | |
619 | |
620 return ilt; | |
621 } | |
622 | |
623 | |
624 //---------------------------------------callee_at----------------------------- | |
625 InlineTree *InlineTree::callee_at(int bci, ciMethod* callee) const { | |
626 for (int i = 0; i < _subtrees.length(); i++) { | |
627 InlineTree* sub = _subtrees.at(i); | |
628 if (sub->caller_bci() == bci && callee == sub->method()) { | |
629 return sub; | |
630 } | |
631 } | |
632 return NULL; | |
633 } | |
634 | |
635 | |
636 //------------------------------build_inline_tree_root------------------------- | |
637 InlineTree *InlineTree::build_inline_tree_root() { | |
638 Compile* C = Compile::current(); | |
639 | |
640 // Root of inline tree | |
3784
aabf25fa3f05
7057587: JSR 292 - crash with jruby in test/test_respond_to.rb
never
parents:
3366
diff
changeset
|
641 InlineTree* ilt = new InlineTree(C, NULL, C->method(), NULL, -1, 1.0F, MaxInlineLevel); |
0 | 642 |
643 return ilt; | |
644 } | |
645 | |
646 | |
647 //-------------------------find_subtree_from_root----------------------------- | |
648 // Given a jvms, which determines a call chain from the root method, | |
649 // find the corresponding inline tree. | |
650 // Note: This method will be removed or replaced as InlineTree goes away. | |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
651 InlineTree* InlineTree::find_subtree_from_root(InlineTree* root, JVMState* jvms, ciMethod* callee) { |
0 | 652 InlineTree* iltp = root; |
653 uint depth = jvms && jvms->has_method() ? jvms->depth() : 0; | |
654 for (uint d = 1; d <= depth; d++) { | |
655 JVMState* jvmsp = jvms->of_depth(d); | |
656 // Select the corresponding subtree for this bci. | |
657 assert(jvmsp->method() == iltp->method(), "tree still in sync"); | |
658 ciMethod* d_callee = (d == depth) ? callee : jvms->of_depth(d+1)->method(); | |
659 InlineTree* sub = iltp->callee_at(jvmsp->bci(), d_callee); | |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
660 if (sub == NULL) { |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
661 if (d == depth) { |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
662 sub = iltp->build_inline_tree_for_callee(d_callee, jvmsp, jvmsp->bci()); |
0 | 663 } |
6266
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
664 guarantee(sub != NULL, "should be a sub-ilt here"); |
1d7922586cf6
7023639: JSR 292 method handle invocation needs a fast path for compiled code
twisti
parents:
5950
diff
changeset
|
665 return sub; |
0 | 666 } |
667 iltp = sub; | |
668 } | |
669 return iltp; | |
670 } | |
3939 | 671 |
672 | |
673 | |
674 #ifndef PRODUCT | |
675 void InlineTree::print_impl(outputStream* st, int indent) const { | |
676 for (int i = 0; i < indent; i++) st->print(" "); | |
677 st->print(" @ %d ", caller_bci()); | |
678 method()->print_short_name(st); | |
679 st->cr(); | |
680 | |
681 for (int i = 0 ; i < _subtrees.length(); i++) { | |
682 _subtrees.at(i)->print_impl(st, indent + 2); | |
683 } | |
684 } | |
685 | |
686 void InlineTree::print_value_on(outputStream* st) const { | |
687 print_impl(st, 2); | |
688 } | |
689 #endif |