annotate src/share/vm/opto/bytecodeInfo.cpp @ 3366:e2a92dd0d3d2

7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters Reviewed-by: jrose, never, kvn
author twisti
date Tue, 10 May 2011 00:45:03 -0700
parents bad7ecd0b6ed
children 393e144bb99b
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1 /*
2357
8033953d67ff 7012648: move JSR 292 to package java.lang.invoke and adjust names
jrose
parents: 1972
diff changeset
2 * Copyright (c) 1998, 2011, Oracle and/or its affiliates. All rights reserved.
0
a61af66fc99e Initial load
duke
parents:
diff changeset
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
a61af66fc99e Initial load
duke
parents:
diff changeset
4 *
a61af66fc99e Initial load
duke
parents:
diff changeset
5 * This code is free software; you can redistribute it and/or modify it
a61af66fc99e Initial load
duke
parents:
diff changeset
6 * under the terms of the GNU General Public License version 2 only, as
a61af66fc99e Initial load
duke
parents:
diff changeset
7 * published by the Free Software Foundation.
a61af66fc99e Initial load
duke
parents:
diff changeset
8 *
a61af66fc99e Initial load
duke
parents:
diff changeset
9 * This code is distributed in the hope that it will be useful, but WITHOUT
a61af66fc99e Initial load
duke
parents:
diff changeset
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
a61af66fc99e Initial load
duke
parents:
diff changeset
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
a61af66fc99e Initial load
duke
parents:
diff changeset
12 * version 2 for more details (a copy is included in the LICENSE file that
a61af66fc99e Initial load
duke
parents:
diff changeset
13 * accompanied this code).
a61af66fc99e Initial load
duke
parents:
diff changeset
14 *
a61af66fc99e Initial load
duke
parents:
diff changeset
15 * You should have received a copy of the GNU General Public License version
a61af66fc99e Initial load
duke
parents:
diff changeset
16 * 2 along with this work; if not, write to the Free Software Foundation,
a61af66fc99e Initial load
duke
parents:
diff changeset
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
a61af66fc99e Initial load
duke
parents:
diff changeset
18 *
1552
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 1507
diff changeset
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 1507
diff changeset
20 * or visit www.oracle.com if you need additional information or have any
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 1507
diff changeset
21 * questions.
0
a61af66fc99e Initial load
duke
parents:
diff changeset
22 *
a61af66fc99e Initial load
duke
parents:
diff changeset
23 */
a61af66fc99e Initial load
duke
parents:
diff changeset
24
1972
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1783
diff changeset
25 #include "precompiled.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1783
diff changeset
26 #include "classfile/systemDictionary.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1783
diff changeset
27 #include "classfile/vmSymbols.hpp"
2405
3d58a4983660 7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents: 2357
diff changeset
28 #include "compiler/compileBroker.hpp"
1972
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1783
diff changeset
29 #include "compiler/compileLog.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1783
diff changeset
30 #include "interpreter/linkResolver.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1783
diff changeset
31 #include "oops/objArrayKlass.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1783
diff changeset
32 #include "opto/callGenerator.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1783
diff changeset
33 #include "opto/parse.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1783
diff changeset
34 #include "runtime/handles.inline.hpp"
0
a61af66fc99e Initial load
duke
parents:
diff changeset
35
a61af66fc99e Initial load
duke
parents:
diff changeset
36 //=============================================================================
a61af66fc99e Initial load
duke
parents:
diff changeset
37 //------------------------------InlineTree-------------------------------------
1157
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
38 InlineTree::InlineTree( Compile* c,
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
39 const InlineTree *caller_tree, ciMethod* callee,
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
40 JVMState* caller_jvms, int caller_bci,
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
41 float site_invoke_ratio, int site_depth_adjust)
0
a61af66fc99e Initial load
duke
parents:
diff changeset
42 : C(c), _caller_jvms(caller_jvms),
a61af66fc99e Initial load
duke
parents:
diff changeset
43 _caller_tree((InlineTree*)caller_tree),
a61af66fc99e Initial load
duke
parents:
diff changeset
44 _method(callee), _site_invoke_ratio(site_invoke_ratio),
1157
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
45 _site_depth_adjust(site_depth_adjust),
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
46 _count_inline_bcs(method()->code_size())
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
47 {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
48 NOT_PRODUCT(_count_inlines = 0;)
a61af66fc99e Initial load
duke
parents:
diff changeset
49 if (_caller_jvms != NULL) {
a61af66fc99e Initial load
duke
parents:
diff changeset
50 // Keep a private copy of the caller_jvms:
a61af66fc99e Initial load
duke
parents:
diff changeset
51 _caller_jvms = new (C) JVMState(caller_jvms->method(), caller_tree->caller_jvms());
a61af66fc99e Initial load
duke
parents:
diff changeset
52 _caller_jvms->set_bci(caller_jvms->bci());
900
9987d9d5eb0e 6833129: specjvm98 fails with NullPointerException in the compiler with -XX:DeoptimizeALot
cfang
parents: 726
diff changeset
53 assert(!caller_jvms->should_reexecute(), "there should be no reexecute bytecode with inlining");
0
a61af66fc99e Initial load
duke
parents:
diff changeset
54 }
a61af66fc99e Initial load
duke
parents:
diff changeset
55 assert(_caller_jvms->same_calls_as(caller_jvms), "consistent JVMS");
1157
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
56 assert((caller_tree == NULL ? 0 : caller_tree->stack_depth() + 1) == stack_depth(), "correct (redundant) depth parameter");
0
a61af66fc99e Initial load
duke
parents:
diff changeset
57 assert(caller_bci == this->caller_bci(), "correct (redundant) bci parameter");
a61af66fc99e Initial load
duke
parents:
diff changeset
58 if (UseOldInlining) {
a61af66fc99e Initial load
duke
parents:
diff changeset
59 // Update hierarchical counts, count_inline_bcs() and count_inlines()
a61af66fc99e Initial load
duke
parents:
diff changeset
60 InlineTree *caller = (InlineTree *)caller_tree;
a61af66fc99e Initial load
duke
parents:
diff changeset
61 for( ; caller != NULL; caller = ((InlineTree *)(caller->caller_tree())) ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
62 caller->_count_inline_bcs += count_inline_bcs();
a61af66fc99e Initial load
duke
parents:
diff changeset
63 NOT_PRODUCT(caller->_count_inlines++;)
a61af66fc99e Initial load
duke
parents:
diff changeset
64 }
a61af66fc99e Initial load
duke
parents:
diff changeset
65 }
a61af66fc99e Initial load
duke
parents:
diff changeset
66 }
a61af66fc99e Initial load
duke
parents:
diff changeset
67
1157
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
68 InlineTree::InlineTree(Compile* c, ciMethod* callee_method, JVMState* caller_jvms,
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
69 float site_invoke_ratio, int site_depth_adjust)
0
a61af66fc99e Initial load
duke
parents:
diff changeset
70 : C(c), _caller_jvms(caller_jvms), _caller_tree(NULL),
a61af66fc99e Initial load
duke
parents:
diff changeset
71 _method(callee_method), _site_invoke_ratio(site_invoke_ratio),
1157
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
72 _site_depth_adjust(site_depth_adjust),
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
73 _count_inline_bcs(method()->code_size())
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
74 {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
75 NOT_PRODUCT(_count_inlines = 0;)
a61af66fc99e Initial load
duke
parents:
diff changeset
76 assert(!UseOldInlining, "do not use for old stuff");
a61af66fc99e Initial load
duke
parents:
diff changeset
77 }
a61af66fc99e Initial load
duke
parents:
diff changeset
78
41
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
79 static bool is_init_with_ea(ciMethod* callee_method,
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
80 ciMethod* caller_method, Compile* C) {
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
81 // True when EA is ON and a java constructor is called or
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
82 // a super constructor is called from an inlined java constructor.
244
524eca34ea76 6684714: Optimize EA Connection Graph build performance
kvn
parents: 41
diff changeset
83 return C->do_escape_analysis() && EliminateAllocations &&
41
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
84 ( callee_method->is_initializer() ||
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
85 (caller_method->is_initializer() &&
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
86 caller_method != C->method() &&
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
87 caller_method->holder()->is_subclass_of(callee_method->holder()))
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
88 );
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
89 }
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
90
0
a61af66fc99e Initial load
duke
parents:
diff changeset
91 // positive filter: should send be inlined? returns NULL, if yes, or rejection msg
3366
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
92 const char* InlineTree::should_inline(ciMethod* callee_method, ciMethod* caller_method, int caller_bci, ciCallProfile& profile, WarmCallInfo* wci_result) const {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
93 // Allows targeted inlining
a61af66fc99e Initial load
duke
parents:
diff changeset
94 if(callee_method->should_inline()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
95 *wci_result = *(WarmCallInfo::always_hot());
a61af66fc99e Initial load
duke
parents:
diff changeset
96 if (PrintInlining && Verbose) {
2405
3d58a4983660 7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents: 2357
diff changeset
97 CompileTask::print_inline_indent(inline_depth());
0
a61af66fc99e Initial load
duke
parents:
diff changeset
98 tty->print_cr("Inlined method is hot: ");
a61af66fc99e Initial load
duke
parents:
diff changeset
99 }
a61af66fc99e Initial load
duke
parents:
diff changeset
100 return NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
101 }
a61af66fc99e Initial load
duke
parents:
diff changeset
102
a61af66fc99e Initial load
duke
parents:
diff changeset
103 // positive filter: should send be inlined? returns NULL (--> yes)
a61af66fc99e Initial load
duke
parents:
diff changeset
104 // or rejection msg
3366
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
105 int size = callee_method->code_size();
0
a61af66fc99e Initial load
duke
parents:
diff changeset
106
a61af66fc99e Initial load
duke
parents:
diff changeset
107 // Check for too many throws (and not too huge)
41
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
108 if(callee_method->interpreter_throwout_count() > InlineThrowCount &&
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
109 size < InlineThrowMaxSize ) {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
110 wci_result->set_profit(wci_result->profit() * 100);
a61af66fc99e Initial load
duke
parents:
diff changeset
111 if (PrintInlining && Verbose) {
2405
3d58a4983660 7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents: 2357
diff changeset
112 CompileTask::print_inline_indent(inline_depth());
0
a61af66fc99e Initial load
duke
parents:
diff changeset
113 tty->print_cr("Inlined method with many throws (throws=%d):", callee_method->interpreter_throwout_count());
a61af66fc99e Initial load
duke
parents:
diff changeset
114 }
a61af66fc99e Initial load
duke
parents:
diff changeset
115 return NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
116 }
a61af66fc99e Initial load
duke
parents:
diff changeset
117
a61af66fc99e Initial load
duke
parents:
diff changeset
118 if (!UseOldInlining) {
a61af66fc99e Initial load
duke
parents:
diff changeset
119 return NULL; // size and frequency are represented in a new way
a61af66fc99e Initial load
duke
parents:
diff changeset
120 }
a61af66fc99e Initial load
duke
parents:
diff changeset
121
3366
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
122 int default_max_inline_size = C->max_inline_size();
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
123 int inline_small_code_size = InlineSmallCode / 4;
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
124 int max_inline_size = default_max_inline_size;
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
125
0
a61af66fc99e Initial load
duke
parents:
diff changeset
126 int call_site_count = method()->scale_count(profile.count());
a61af66fc99e Initial load
duke
parents:
diff changeset
127 int invoke_count = method()->interpreter_invocation_count();
3366
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
128
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
129 // Bytecoded method handle adapters do not have interpreter
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
130 // profiling data but only made up MDO data. Get the counter from
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
131 // there.
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
132 if (caller_method->is_method_handle_adapter()) {
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
133 assert(method()->method_data_or_null(), "must have an MDO");
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
134 ciMethodData* mdo = method()->method_data();
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
135 ciProfileData* mha_profile = mdo->bci_to_data(caller_bci);
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
136 assert(mha_profile, "must exist");
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
137 CounterData* cd = mha_profile->as_CounterData();
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
138 invoke_count = cd->count();
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
139 call_site_count = invoke_count; // use the same value
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
140 }
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
141
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
142 assert(invoke_count != 0, "require invocation count greater than zero");
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
143 int freq = call_site_count / invoke_count;
41
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
144
0
a61af66fc99e Initial load
duke
parents:
diff changeset
145 // bump the max size if the call is frequent
41
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
146 if ((freq >= InlineFrequencyRatio) ||
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
147 (call_site_count >= InlineFrequencyCount) ||
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
148 is_init_with_ea(callee_method, caller_method, C)) {
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
149
3366
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
150 max_inline_size = C->freq_inline_size();
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
151 if (size <= max_inline_size && TraceFrequencyInlining) {
2405
3d58a4983660 7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents: 2357
diff changeset
152 CompileTask::print_inline_indent(inline_depth());
0
a61af66fc99e Initial load
duke
parents:
diff changeset
153 tty->print_cr("Inlined frequent method (freq=%d count=%d):", freq, call_site_count);
2405
3d58a4983660 7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents: 2357
diff changeset
154 CompileTask::print_inline_indent(inline_depth());
0
a61af66fc99e Initial load
duke
parents:
diff changeset
155 callee_method->print();
a61af66fc99e Initial load
duke
parents:
diff changeset
156 tty->cr();
a61af66fc99e Initial load
duke
parents:
diff changeset
157 }
a61af66fc99e Initial load
duke
parents:
diff changeset
158 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
159 // Not hot. Check for medium-sized pre-existing nmethod at cold sites.
41
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
160 if (callee_method->has_compiled_code() &&
3366
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
161 callee_method->instructions_size(CompLevel_full_optimization) > inline_small_code_size)
0
a61af66fc99e Initial load
duke
parents:
diff changeset
162 return "already compiled into a medium method";
a61af66fc99e Initial load
duke
parents:
diff changeset
163 }
3366
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
164 if (size > max_inline_size) {
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
165 if (max_inline_size > default_max_inline_size)
0
a61af66fc99e Initial load
duke
parents:
diff changeset
166 return "hot method too big";
a61af66fc99e Initial load
duke
parents:
diff changeset
167 return "too big";
a61af66fc99e Initial load
duke
parents:
diff changeset
168 }
a61af66fc99e Initial load
duke
parents:
diff changeset
169 return NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
170 }
a61af66fc99e Initial load
duke
parents:
diff changeset
171
a61af66fc99e Initial load
duke
parents:
diff changeset
172
a61af66fc99e Initial load
duke
parents:
diff changeset
173 // negative filter: should send NOT be inlined? returns NULL, ok to inline, or rejection msg
3366
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
174 const char* InlineTree::should_not_inline(ciMethod *callee_method, ciMethod* caller_method, WarmCallInfo* wci_result) const {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
175 // negative filter: should send NOT be inlined? returns NULL (--> inline) or rejection msg
a61af66fc99e Initial load
duke
parents:
diff changeset
176 if (!UseOldInlining) {
a61af66fc99e Initial load
duke
parents:
diff changeset
177 const char* fail = NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
178 if (callee_method->is_abstract()) fail = "abstract method";
a61af66fc99e Initial load
duke
parents:
diff changeset
179 // note: we allow ik->is_abstract()
a61af66fc99e Initial load
duke
parents:
diff changeset
180 if (!callee_method->holder()->is_initialized()) fail = "method holder not initialized";
a61af66fc99e Initial load
duke
parents:
diff changeset
181 if (callee_method->is_native()) fail = "native method";
a61af66fc99e Initial load
duke
parents:
diff changeset
182
a61af66fc99e Initial load
duke
parents:
diff changeset
183 if (fail) {
a61af66fc99e Initial load
duke
parents:
diff changeset
184 *wci_result = *(WarmCallInfo::always_cold());
a61af66fc99e Initial load
duke
parents:
diff changeset
185 return fail;
a61af66fc99e Initial load
duke
parents:
diff changeset
186 }
a61af66fc99e Initial load
duke
parents:
diff changeset
187
a61af66fc99e Initial load
duke
parents:
diff changeset
188 if (callee_method->has_unloaded_classes_in_signature()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
189 wci_result->set_profit(wci_result->profit() * 0.1);
a61af66fc99e Initial load
duke
parents:
diff changeset
190 }
a61af66fc99e Initial load
duke
parents:
diff changeset
191
a61af66fc99e Initial load
duke
parents:
diff changeset
192 // don't inline exception code unless the top method belongs to an
a61af66fc99e Initial load
duke
parents:
diff changeset
193 // exception class
a61af66fc99e Initial load
duke
parents:
diff changeset
194 if (callee_method->holder()->is_subclass_of(C->env()->Throwable_klass())) {
a61af66fc99e Initial load
duke
parents:
diff changeset
195 ciMethod* top_method = caller_jvms() ? caller_jvms()->of_depth(1)->method() : method();
a61af66fc99e Initial load
duke
parents:
diff changeset
196 if (!top_method->holder()->is_subclass_of(C->env()->Throwable_klass())) {
a61af66fc99e Initial load
duke
parents:
diff changeset
197 wci_result->set_profit(wci_result->profit() * 0.1);
a61af66fc99e Initial load
duke
parents:
diff changeset
198 }
a61af66fc99e Initial load
duke
parents:
diff changeset
199 }
a61af66fc99e Initial load
duke
parents:
diff changeset
200
1783
d5d065957597 6953144: Tiered compilation
iveresov
parents: 1579
diff changeset
201 if (callee_method->has_compiled_code() && callee_method->instructions_size(CompLevel_full_optimization) > InlineSmallCode) {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
202 wci_result->set_profit(wci_result->profit() * 0.1);
a61af66fc99e Initial load
duke
parents:
diff changeset
203 // %%% adjust wci_result->size()?
a61af66fc99e Initial load
duke
parents:
diff changeset
204 }
a61af66fc99e Initial load
duke
parents:
diff changeset
205
a61af66fc99e Initial load
duke
parents:
diff changeset
206 return NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
207 }
a61af66fc99e Initial load
duke
parents:
diff changeset
208
1564
61b2245abf36 6930772: JSR 292 needs to support SPARC C1
twisti
parents: 1507
diff changeset
209 // Always inline MethodHandle methods and generated MethodHandle adapters.
61b2245abf36 6930772: JSR 292 needs to support SPARC C1
twisti
parents: 1507
diff changeset
210 if (callee_method->is_method_handle_invoke() || callee_method->is_method_handle_adapter())
1138
dd57230ba8fe 6893268: additional dynamic language related optimizations in C2
twisti
parents: 1137
diff changeset
211 return NULL;
dd57230ba8fe 6893268: additional dynamic language related optimizations in C2
twisti
parents: 1137
diff changeset
212
0
a61af66fc99e Initial load
duke
parents:
diff changeset
213 // First check all inlining restrictions which are required for correctness
a61af66fc99e Initial load
duke
parents:
diff changeset
214 if (callee_method->is_abstract()) return "abstract method";
a61af66fc99e Initial load
duke
parents:
diff changeset
215 // note: we allow ik->is_abstract()
a61af66fc99e Initial load
duke
parents:
diff changeset
216 if (!callee_method->holder()->is_initialized()) return "method holder not initialized";
a61af66fc99e Initial load
duke
parents:
diff changeset
217 if (callee_method->is_native()) return "native method";
a61af66fc99e Initial load
duke
parents:
diff changeset
218 if (callee_method->has_unloaded_classes_in_signature()) return "unloaded signature classes";
a61af66fc99e Initial load
duke
parents:
diff changeset
219
a61af66fc99e Initial load
duke
parents:
diff changeset
220 if (callee_method->should_inline()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
221 // ignore heuristic controls on inlining
a61af66fc99e Initial load
duke
parents:
diff changeset
222 return NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
223 }
a61af66fc99e Initial load
duke
parents:
diff changeset
224
a61af66fc99e Initial load
duke
parents:
diff changeset
225 // Now perform checks which are heuristic
a61af66fc99e Initial load
duke
parents:
diff changeset
226
1783
d5d065957597 6953144: Tiered compilation
iveresov
parents: 1579
diff changeset
227 if( callee_method->has_compiled_code() && callee_method->instructions_size(CompLevel_full_optimization) > InlineSmallCode )
0
a61af66fc99e Initial load
duke
parents:
diff changeset
228 return "already compiled into a big method";
a61af66fc99e Initial load
duke
parents:
diff changeset
229
a61af66fc99e Initial load
duke
parents:
diff changeset
230 // don't inline exception code unless the top method belongs to an
a61af66fc99e Initial load
duke
parents:
diff changeset
231 // exception class
a61af66fc99e Initial load
duke
parents:
diff changeset
232 if (caller_tree() != NULL &&
a61af66fc99e Initial load
duke
parents:
diff changeset
233 callee_method->holder()->is_subclass_of(C->env()->Throwable_klass())) {
a61af66fc99e Initial load
duke
parents:
diff changeset
234 const InlineTree *top = this;
a61af66fc99e Initial load
duke
parents:
diff changeset
235 while (top->caller_tree() != NULL) top = top->caller_tree();
a61af66fc99e Initial load
duke
parents:
diff changeset
236 ciInstanceKlass* k = top->method()->holder();
a61af66fc99e Initial load
duke
parents:
diff changeset
237 if (!k->is_subclass_of(C->env()->Throwable_klass()))
a61af66fc99e Initial load
duke
parents:
diff changeset
238 return "exception method";
a61af66fc99e Initial load
duke
parents:
diff changeset
239 }
a61af66fc99e Initial load
duke
parents:
diff changeset
240
a61af66fc99e Initial load
duke
parents:
diff changeset
241 // use frequency-based objections only for non-trivial methods
a61af66fc99e Initial load
duke
parents:
diff changeset
242 if (callee_method->code_size() <= MaxTrivialSize) return NULL;
41
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
243
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
244 // don't use counts with -Xcomp or CTW
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
245 if (UseInterpreter && !CompileTheWorld) {
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
246
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
247 if (!callee_method->has_compiled_code() &&
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
248 !callee_method->was_executed_more_than(0)) {
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
249 return "never executed";
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
250 }
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
251
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
252 if (is_init_with_ea(callee_method, caller_method, C)) {
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
253
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
254 // Escape Analysis: inline all executed constructors
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
255
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
256 } else if (!callee_method->was_executed_more_than(MIN2(MinInliningThreshold,
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
257 CompileThreshold >> 1))) {
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
258 return "executed < MinInliningThreshold times";
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
259 }
0
a61af66fc99e Initial load
duke
parents:
diff changeset
260 }
a61af66fc99e Initial load
duke
parents:
diff changeset
261
a61af66fc99e Initial load
duke
parents:
diff changeset
262 if (callee_method->should_not_inline()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
263 return "disallowed by CompilerOracle";
a61af66fc99e Initial load
duke
parents:
diff changeset
264 }
a61af66fc99e Initial load
duke
parents:
diff changeset
265
675
f6da6f0174ac 6821700: tune VM flags for peak performance
kvn
parents: 367
diff changeset
266 if (UseStringCache) {
f6da6f0174ac 6821700: tune VM flags for peak performance
kvn
parents: 367
diff changeset
267 // Do not inline StringCache::profile() method used only at the beginning.
f6da6f0174ac 6821700: tune VM flags for peak performance
kvn
parents: 367
diff changeset
268 if (callee_method->name() == ciSymbol::profile_name() &&
f6da6f0174ac 6821700: tune VM flags for peak performance
kvn
parents: 367
diff changeset
269 callee_method->holder()->name() == ciSymbol::java_lang_StringCache()) {
f6da6f0174ac 6821700: tune VM flags for peak performance
kvn
parents: 367
diff changeset
270 return "profiling method";
f6da6f0174ac 6821700: tune VM flags for peak performance
kvn
parents: 367
diff changeset
271 }
f6da6f0174ac 6821700: tune VM flags for peak performance
kvn
parents: 367
diff changeset
272 }
f6da6f0174ac 6821700: tune VM flags for peak performance
kvn
parents: 367
diff changeset
273
0
a61af66fc99e Initial load
duke
parents:
diff changeset
274 return NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
275 }
a61af66fc99e Initial load
duke
parents:
diff changeset
276
a61af66fc99e Initial load
duke
parents:
diff changeset
277 //-----------------------------try_to_inline-----------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
278 // return NULL if ok, reason for not inlining otherwise
a61af66fc99e Initial load
duke
parents:
diff changeset
279 // Relocated from "InliningClosure::try_to_inline"
41
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
280 const char* InlineTree::try_to_inline(ciMethod* callee_method, ciMethod* caller_method, int caller_bci, ciCallProfile& profile, WarmCallInfo* wci_result) {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
281
a61af66fc99e Initial load
duke
parents:
diff changeset
282 // Old algorithm had funny accumulating BC-size counters
a61af66fc99e Initial load
duke
parents:
diff changeset
283 if (UseOldInlining && ClipInlining
a61af66fc99e Initial load
duke
parents:
diff changeset
284 && (int)count_inline_bcs() >= DesiredMethodLimit) {
a61af66fc99e Initial load
duke
parents:
diff changeset
285 return "size > DesiredMethodLimit";
a61af66fc99e Initial load
duke
parents:
diff changeset
286 }
a61af66fc99e Initial load
duke
parents:
diff changeset
287
a61af66fc99e Initial load
duke
parents:
diff changeset
288 const char *msg = NULL;
3366
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
289 msg = should_inline(callee_method, caller_method, caller_bci, profile, wci_result);
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
290 if (msg != NULL)
41
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
291 return msg;
3366
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
292
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
293 msg = should_not_inline(callee_method, caller_method, wci_result);
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
294 if (msg != NULL)
41
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
295 return msg;
0
a61af66fc99e Initial load
duke
parents:
diff changeset
296
1157
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
297 if (InlineAccessors && callee_method->is_accessor()) {
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
298 // accessor methods are not subject to any of the following limits.
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
299 return NULL;
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
300 }
0
a61af66fc99e Initial load
duke
parents:
diff changeset
301
a61af66fc99e Initial load
duke
parents:
diff changeset
302 // suppress a few checks for accessors and trivial methods
1157
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
303 if (callee_method->code_size() > MaxTrivialSize) {
41
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
304
0
a61af66fc99e Initial load
duke
parents:
diff changeset
305 // don't inline into giant methods
41
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
306 if (C->unique() > (uint)NodeCountInliningCutoff) {
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
307 return "NodeCountInliningCutoff";
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
308 }
0
a61af66fc99e Initial load
duke
parents:
diff changeset
309
41
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
310 if ((!UseInterpreter || CompileTheWorld) &&
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
311 is_init_with_ea(callee_method, caller_method, C)) {
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
312
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
313 // Escape Analysis stress testing when running Xcomp or CTW:
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
314 // inline constructors even if they are not reached.
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
315
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
316 } else if (profile.count() == 0) {
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
317 // don't inline unreached call sites
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
318 return "call site not reached";
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
319 }
0
a61af66fc99e Initial load
duke
parents:
diff changeset
320 }
a61af66fc99e Initial load
duke
parents:
diff changeset
321
1157
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
322 if (!C->do_inlining() && InlineAccessors) {
41
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
323 return "not an accessor";
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
324 }
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
325 if( inline_depth() > MaxInlineLevel ) {
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
326 return "inlining too deep";
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
327 }
2405
3d58a4983660 7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents: 2357
diff changeset
328
3334
b21ecca7ccc4 6552561: MaxRecursiveInlineLevel flag doesn't operate correctly
twisti
parents: 2405
diff changeset
329 // detect direct and indirect recursive inlining
b21ecca7ccc4 6552561: MaxRecursiveInlineLevel flag doesn't operate correctly
twisti
parents: 2405
diff changeset
330 {
b21ecca7ccc4 6552561: MaxRecursiveInlineLevel flag doesn't operate correctly
twisti
parents: 2405
diff changeset
331 // count the current method and the callee
b21ecca7ccc4 6552561: MaxRecursiveInlineLevel flag doesn't operate correctly
twisti
parents: 2405
diff changeset
332 int inline_level = (method() == callee_method) ? 1 : 0;
b21ecca7ccc4 6552561: MaxRecursiveInlineLevel flag doesn't operate correctly
twisti
parents: 2405
diff changeset
333 if (inline_level > MaxRecursiveInlineLevel)
b21ecca7ccc4 6552561: MaxRecursiveInlineLevel flag doesn't operate correctly
twisti
parents: 2405
diff changeset
334 return "recursively inlining too deep";
b21ecca7ccc4 6552561: MaxRecursiveInlineLevel flag doesn't operate correctly
twisti
parents: 2405
diff changeset
335 // count callers of current method and callee
2405
3d58a4983660 7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents: 2357
diff changeset
336 JVMState* jvms = caller_jvms();
3d58a4983660 7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents: 2357
diff changeset
337 while (jvms != NULL && jvms->has_method()) {
3d58a4983660 7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents: 2357
diff changeset
338 if (jvms->method() == callee_method) {
3d58a4983660 7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents: 2357
diff changeset
339 inline_level++;
3d58a4983660 7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents: 2357
diff changeset
340 if (inline_level > MaxRecursiveInlineLevel)
3d58a4983660 7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents: 2357
diff changeset
341 return "recursively inlining too deep";
3d58a4983660 7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents: 2357
diff changeset
342 }
3d58a4983660 7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents: 2357
diff changeset
343 jvms = jvms->caller();
3d58a4983660 7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents: 2357
diff changeset
344 }
3d58a4983660 7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents: 2357
diff changeset
345 }
3d58a4983660 7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents: 2357
diff changeset
346
0
a61af66fc99e Initial load
duke
parents:
diff changeset
347 int size = callee_method->code_size();
a61af66fc99e Initial load
duke
parents:
diff changeset
348
a61af66fc99e Initial load
duke
parents:
diff changeset
349 if (UseOldInlining && ClipInlining
a61af66fc99e Initial load
duke
parents:
diff changeset
350 && (int)count_inline_bcs() + size >= DesiredMethodLimit) {
a61af66fc99e Initial load
duke
parents:
diff changeset
351 return "size > DesiredMethodLimit";
a61af66fc99e Initial load
duke
parents:
diff changeset
352 }
a61af66fc99e Initial load
duke
parents:
diff changeset
353
a61af66fc99e Initial load
duke
parents:
diff changeset
354 // ok, inline this method
a61af66fc99e Initial load
duke
parents:
diff changeset
355 return NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
356 }
a61af66fc99e Initial load
duke
parents:
diff changeset
357
a61af66fc99e Initial load
duke
parents:
diff changeset
358 //------------------------------pass_initial_checks----------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
359 bool pass_initial_checks(ciMethod* caller_method, int caller_bci, ciMethod* callee_method) {
a61af66fc99e Initial load
duke
parents:
diff changeset
360 ciInstanceKlass *callee_holder = callee_method ? callee_method->holder() : NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
361 // Check if a callee_method was suggested
a61af66fc99e Initial load
duke
parents:
diff changeset
362 if( callee_method == NULL ) return false;
a61af66fc99e Initial load
duke
parents:
diff changeset
363 // Check if klass of callee_method is loaded
a61af66fc99e Initial load
duke
parents:
diff changeset
364 if( !callee_holder->is_loaded() ) return false;
a61af66fc99e Initial load
duke
parents:
diff changeset
365 if( !callee_holder->is_initialized() ) return false;
a61af66fc99e Initial load
duke
parents:
diff changeset
366 if( !UseInterpreter || CompileTheWorld /* running Xcomp or CTW */ ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
367 // Checks that constant pool's call site has been visited
a61af66fc99e Initial load
duke
parents:
diff changeset
368 // stricter than callee_holder->is_initialized()
a61af66fc99e Initial load
duke
parents:
diff changeset
369 ciBytecodeStream iter(caller_method);
a61af66fc99e Initial load
duke
parents:
diff changeset
370 iter.force_bci(caller_bci);
a61af66fc99e Initial load
duke
parents:
diff changeset
371 Bytecodes::Code call_bc = iter.cur_bc();
1137
97125851f396 6829187: compiler optimizations required for JSR 292
twisti
parents: 903
diff changeset
372 // An invokedynamic instruction does not have a klass.
97125851f396 6829187: compiler optimizations required for JSR 292
twisti
parents: 903
diff changeset
373 if (call_bc != Bytecodes::_invokedynamic) {
1565
ab102d5d923e 6939207: refactor constant pool index processing
jrose
parents: 1564
diff changeset
374 int index = iter.get_index_u2_cpcache();
1137
97125851f396 6829187: compiler optimizations required for JSR 292
twisti
parents: 903
diff changeset
375 if (!caller_method->is_klass_loaded(index, true)) {
97125851f396 6829187: compiler optimizations required for JSR 292
twisti
parents: 903
diff changeset
376 return false;
97125851f396 6829187: compiler optimizations required for JSR 292
twisti
parents: 903
diff changeset
377 }
97125851f396 6829187: compiler optimizations required for JSR 292
twisti
parents: 903
diff changeset
378 // Try to do constant pool resolution if running Xcomp
97125851f396 6829187: compiler optimizations required for JSR 292
twisti
parents: 903
diff changeset
379 if( !caller_method->check_call(index, call_bc == Bytecodes::_invokestatic) ) {
97125851f396 6829187: compiler optimizations required for JSR 292
twisti
parents: 903
diff changeset
380 return false;
97125851f396 6829187: compiler optimizations required for JSR 292
twisti
parents: 903
diff changeset
381 }
0
a61af66fc99e Initial load
duke
parents:
diff changeset
382 }
a61af66fc99e Initial load
duke
parents:
diff changeset
383 }
a61af66fc99e Initial load
duke
parents:
diff changeset
384 // We will attempt to see if a class/field/etc got properly loaded. If it
a61af66fc99e Initial load
duke
parents:
diff changeset
385 // did not, it may attempt to throw an exception during our probing. Catch
a61af66fc99e Initial load
duke
parents:
diff changeset
386 // and ignore such exceptions and do not attempt to compile the method.
a61af66fc99e Initial load
duke
parents:
diff changeset
387 if( callee_method->should_exclude() ) return false;
a61af66fc99e Initial load
duke
parents:
diff changeset
388
a61af66fc99e Initial load
duke
parents:
diff changeset
389 return true;
a61af66fc99e Initial load
duke
parents:
diff changeset
390 }
a61af66fc99e Initial load
duke
parents:
diff changeset
391
a61af66fc99e Initial load
duke
parents:
diff changeset
392 //------------------------------print_inlining---------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
393 // Really, the failure_msg can be a success message also.
2405
3d58a4983660 7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents: 2357
diff changeset
394 void InlineTree::print_inlining(ciMethod* callee_method, int caller_bci, const char* failure_msg) const {
3d58a4983660 7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents: 2357
diff changeset
395 CompileTask::print_inlining(callee_method, inline_depth(), caller_bci, failure_msg ? failure_msg : "inline");
3d58a4983660 7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents: 2357
diff changeset
396 if (callee_method == NULL) tty->print(" callee not monotonic or profiled");
3d58a4983660 7022998: JSR 292 recursive method handle calls inline themselves infinitely
twisti
parents: 2357
diff changeset
397 if (Verbose && callee_method) {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
398 const InlineTree *top = this;
a61af66fc99e Initial load
duke
parents:
diff changeset
399 while( top->caller_tree() != NULL ) { top = top->caller_tree(); }
a61af66fc99e Initial load
duke
parents:
diff changeset
400 tty->print(" bcs: %d+%d invoked: %d", top->count_inline_bcs(), callee_method->code_size(), callee_method->interpreter_invocation_count());
a61af66fc99e Initial load
duke
parents:
diff changeset
401 }
a61af66fc99e Initial load
duke
parents:
diff changeset
402 }
a61af66fc99e Initial load
duke
parents:
diff changeset
403
a61af66fc99e Initial load
duke
parents:
diff changeset
404 //------------------------------ok_to_inline-----------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
405 WarmCallInfo* InlineTree::ok_to_inline(ciMethod* callee_method, JVMState* jvms, ciCallProfile& profile, WarmCallInfo* initial_wci) {
a61af66fc99e Initial load
duke
parents:
diff changeset
406 assert(callee_method != NULL, "caller checks for optimized virtual!");
a61af66fc99e Initial load
duke
parents:
diff changeset
407 #ifdef ASSERT
a61af66fc99e Initial load
duke
parents:
diff changeset
408 // Make sure the incoming jvms has the same information content as me.
a61af66fc99e Initial load
duke
parents:
diff changeset
409 // This means that we can eventually make this whole class AllStatic.
a61af66fc99e Initial load
duke
parents:
diff changeset
410 if (jvms->caller() == NULL) {
a61af66fc99e Initial load
duke
parents:
diff changeset
411 assert(_caller_jvms == NULL, "redundant instance state");
a61af66fc99e Initial load
duke
parents:
diff changeset
412 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
413 assert(_caller_jvms->same_calls_as(jvms->caller()), "redundant instance state");
a61af66fc99e Initial load
duke
parents:
diff changeset
414 }
a61af66fc99e Initial load
duke
parents:
diff changeset
415 assert(_method == jvms->method(), "redundant instance state");
a61af66fc99e Initial load
duke
parents:
diff changeset
416 #endif
a61af66fc99e Initial load
duke
parents:
diff changeset
417 const char *failure_msg = NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
418 int caller_bci = jvms->bci();
a61af66fc99e Initial load
duke
parents:
diff changeset
419 ciMethod *caller_method = jvms->method();
a61af66fc99e Initial load
duke
parents:
diff changeset
420
a61af66fc99e Initial load
duke
parents:
diff changeset
421 if( !pass_initial_checks(caller_method, caller_bci, callee_method)) {
a61af66fc99e Initial load
duke
parents:
diff changeset
422 if( PrintInlining ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
423 failure_msg = "failed_initial_checks";
a61af66fc99e Initial load
duke
parents:
diff changeset
424 print_inlining( callee_method, caller_bci, failure_msg);
a61af66fc99e Initial load
duke
parents:
diff changeset
425 }
a61af66fc99e Initial load
duke
parents:
diff changeset
426 return NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
427 }
a61af66fc99e Initial load
duke
parents:
diff changeset
428
a61af66fc99e Initial load
duke
parents:
diff changeset
429 // Check if inlining policy says no.
a61af66fc99e Initial load
duke
parents:
diff changeset
430 WarmCallInfo wci = *(initial_wci);
41
874b2c4f43d1 6667605: (Escape Analysis) inline java constructors when EA is on
kvn
parents: 0
diff changeset
431 failure_msg = try_to_inline(callee_method, caller_method, caller_bci, profile, &wci);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
432 if (failure_msg != NULL && C->log() != NULL) {
a61af66fc99e Initial load
duke
parents:
diff changeset
433 C->log()->begin_elem("inline_fail reason='");
a61af66fc99e Initial load
duke
parents:
diff changeset
434 C->log()->text("%s", failure_msg);
a61af66fc99e Initial load
duke
parents:
diff changeset
435 C->log()->end_elem("'");
a61af66fc99e Initial load
duke
parents:
diff changeset
436 }
a61af66fc99e Initial load
duke
parents:
diff changeset
437
a61af66fc99e Initial load
duke
parents:
diff changeset
438 #ifndef PRODUCT
a61af66fc99e Initial load
duke
parents:
diff changeset
439 if (UseOldInlining && InlineWarmCalls
a61af66fc99e Initial load
duke
parents:
diff changeset
440 && (PrintOpto || PrintOptoInlining || PrintInlining)) {
a61af66fc99e Initial load
duke
parents:
diff changeset
441 bool cold = wci.is_cold();
a61af66fc99e Initial load
duke
parents:
diff changeset
442 bool hot = !cold && wci.is_hot();
a61af66fc99e Initial load
duke
parents:
diff changeset
443 bool old_cold = (failure_msg != NULL);
a61af66fc99e Initial load
duke
parents:
diff changeset
444 if (old_cold != cold || (Verbose || WizardMode)) {
a61af66fc99e Initial load
duke
parents:
diff changeset
445 tty->print(" OldInlining= %4s : %s\n WCI=",
a61af66fc99e Initial load
duke
parents:
diff changeset
446 old_cold ? "cold" : "hot", failure_msg ? failure_msg : "OK");
a61af66fc99e Initial load
duke
parents:
diff changeset
447 wci.print();
a61af66fc99e Initial load
duke
parents:
diff changeset
448 }
a61af66fc99e Initial load
duke
parents:
diff changeset
449 }
a61af66fc99e Initial load
duke
parents:
diff changeset
450 #endif
a61af66fc99e Initial load
duke
parents:
diff changeset
451 if (UseOldInlining) {
a61af66fc99e Initial load
duke
parents:
diff changeset
452 if (failure_msg == NULL)
a61af66fc99e Initial load
duke
parents:
diff changeset
453 wci = *(WarmCallInfo::always_hot());
a61af66fc99e Initial load
duke
parents:
diff changeset
454 else
a61af66fc99e Initial load
duke
parents:
diff changeset
455 wci = *(WarmCallInfo::always_cold());
a61af66fc99e Initial load
duke
parents:
diff changeset
456 }
a61af66fc99e Initial load
duke
parents:
diff changeset
457 if (!InlineWarmCalls) {
a61af66fc99e Initial load
duke
parents:
diff changeset
458 if (!wci.is_cold() && !wci.is_hot()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
459 // Do not inline the warm calls.
a61af66fc99e Initial load
duke
parents:
diff changeset
460 wci = *(WarmCallInfo::always_cold());
a61af66fc99e Initial load
duke
parents:
diff changeset
461 }
a61af66fc99e Initial load
duke
parents:
diff changeset
462 }
a61af66fc99e Initial load
duke
parents:
diff changeset
463
a61af66fc99e Initial load
duke
parents:
diff changeset
464 if (!wci.is_cold()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
465 // In -UseOldInlining, the failure_msg may also be a success message.
a61af66fc99e Initial load
duke
parents:
diff changeset
466 if (failure_msg == NULL) failure_msg = "inline (hot)";
a61af66fc99e Initial load
duke
parents:
diff changeset
467
a61af66fc99e Initial load
duke
parents:
diff changeset
468 // Inline!
a61af66fc99e Initial load
duke
parents:
diff changeset
469 if( PrintInlining ) print_inlining( callee_method, caller_bci, failure_msg);
a61af66fc99e Initial load
duke
parents:
diff changeset
470 if (UseOldInlining)
a61af66fc99e Initial load
duke
parents:
diff changeset
471 build_inline_tree_for_callee(callee_method, jvms, caller_bci);
a61af66fc99e Initial load
duke
parents:
diff changeset
472 if (InlineWarmCalls && !wci.is_hot())
a61af66fc99e Initial load
duke
parents:
diff changeset
473 return new (C) WarmCallInfo(wci); // copy to heap
a61af66fc99e Initial load
duke
parents:
diff changeset
474 return WarmCallInfo::always_hot();
a61af66fc99e Initial load
duke
parents:
diff changeset
475 }
a61af66fc99e Initial load
duke
parents:
diff changeset
476
a61af66fc99e Initial load
duke
parents:
diff changeset
477 // Do not inline
a61af66fc99e Initial load
duke
parents:
diff changeset
478 if (failure_msg == NULL) failure_msg = "too cold to inline";
a61af66fc99e Initial load
duke
parents:
diff changeset
479 if( PrintInlining ) print_inlining( callee_method, caller_bci, failure_msg);
a61af66fc99e Initial load
duke
parents:
diff changeset
480 return NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
481 }
a61af66fc99e Initial load
duke
parents:
diff changeset
482
a61af66fc99e Initial load
duke
parents:
diff changeset
483 //------------------------------compute_callee_frequency-----------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
484 float InlineTree::compute_callee_frequency( int caller_bci ) const {
a61af66fc99e Initial load
duke
parents:
diff changeset
485 int count = method()->interpreter_call_site_count(caller_bci);
a61af66fc99e Initial load
duke
parents:
diff changeset
486 int invcnt = method()->interpreter_invocation_count();
a61af66fc99e Initial load
duke
parents:
diff changeset
487 float freq = (float)count/(float)invcnt;
a61af66fc99e Initial load
duke
parents:
diff changeset
488 // Call-site count / interpreter invocation count, scaled recursively.
a61af66fc99e Initial load
duke
parents:
diff changeset
489 // Always between 0.0 and 1.0. Represents the percentage of the method's
a61af66fc99e Initial load
duke
parents:
diff changeset
490 // total execution time used at this call site.
a61af66fc99e Initial load
duke
parents:
diff changeset
491
a61af66fc99e Initial load
duke
parents:
diff changeset
492 return freq;
a61af66fc99e Initial load
duke
parents:
diff changeset
493 }
a61af66fc99e Initial load
duke
parents:
diff changeset
494
a61af66fc99e Initial load
duke
parents:
diff changeset
495 //------------------------------build_inline_tree_for_callee-------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
496 InlineTree *InlineTree::build_inline_tree_for_callee( ciMethod* callee_method, JVMState* caller_jvms, int caller_bci) {
a61af66fc99e Initial load
duke
parents:
diff changeset
497 float recur_frequency = _site_invoke_ratio * compute_callee_frequency(caller_bci);
a61af66fc99e Initial load
duke
parents:
diff changeset
498 // Attempt inlining.
a61af66fc99e Initial load
duke
parents:
diff changeset
499 InlineTree* old_ilt = callee_at(caller_bci, callee_method);
a61af66fc99e Initial load
duke
parents:
diff changeset
500 if (old_ilt != NULL) {
a61af66fc99e Initial load
duke
parents:
diff changeset
501 return old_ilt;
a61af66fc99e Initial load
duke
parents:
diff changeset
502 }
1157
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
503 int new_depth_adjust = 0;
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
504 if (caller_jvms->method() != NULL) {
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
505 if (caller_jvms->method()->is_method_handle_adapter())
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
506 new_depth_adjust -= 1; // don't count actions in MH or indy adapter frames
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
507 else if (callee_method->is_method_handle_invoke()) {
2357
8033953d67ff 7012648: move JSR 292 to package java.lang.invoke and adjust names
jrose
parents: 1972
diff changeset
508 new_depth_adjust -= 1; // don't count method handle calls from java.lang.invoke implem
1157
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
509 }
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
510 if (new_depth_adjust != 0 && PrintInlining) {
3366
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
511 CompileTask::print_inline_indent(inline_depth());
e2a92dd0d3d2 7042122: JSR 292: adjust various inline thresholds for JSR 292 API methods and method handle adapters
twisti
parents: 3345
diff changeset
512 tty->print_cr(" \\-> discounting inline depth");
1157
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
513 }
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
514 if (new_depth_adjust != 0 && C->log()) {
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
515 int id1 = C->log()->identify(caller_jvms->method());
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
516 int id2 = C->log()->identify(callee_method);
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
517 C->log()->elem("inline_depth_discount caller='%d' callee='%d'", id1, id2);
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
518 }
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
519 }
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
520 InlineTree *ilt = new InlineTree(C, this, callee_method, caller_jvms, caller_bci, recur_frequency, _site_depth_adjust + new_depth_adjust);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
521 _subtrees.append( ilt );
a61af66fc99e Initial load
duke
parents:
diff changeset
522
a61af66fc99e Initial load
duke
parents:
diff changeset
523 NOT_PRODUCT( _count_inlines += 1; )
a61af66fc99e Initial load
duke
parents:
diff changeset
524
a61af66fc99e Initial load
duke
parents:
diff changeset
525 return ilt;
a61af66fc99e Initial load
duke
parents:
diff changeset
526 }
a61af66fc99e Initial load
duke
parents:
diff changeset
527
a61af66fc99e Initial load
duke
parents:
diff changeset
528
a61af66fc99e Initial load
duke
parents:
diff changeset
529 //---------------------------------------callee_at-----------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
530 InlineTree *InlineTree::callee_at(int bci, ciMethod* callee) const {
a61af66fc99e Initial load
duke
parents:
diff changeset
531 for (int i = 0; i < _subtrees.length(); i++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
532 InlineTree* sub = _subtrees.at(i);
a61af66fc99e Initial load
duke
parents:
diff changeset
533 if (sub->caller_bci() == bci && callee == sub->method()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
534 return sub;
a61af66fc99e Initial load
duke
parents:
diff changeset
535 }
a61af66fc99e Initial load
duke
parents:
diff changeset
536 }
a61af66fc99e Initial load
duke
parents:
diff changeset
537 return NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
538 }
a61af66fc99e Initial load
duke
parents:
diff changeset
539
a61af66fc99e Initial load
duke
parents:
diff changeset
540
a61af66fc99e Initial load
duke
parents:
diff changeset
541 //------------------------------build_inline_tree_root-------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
542 InlineTree *InlineTree::build_inline_tree_root() {
a61af66fc99e Initial load
duke
parents:
diff changeset
543 Compile* C = Compile::current();
a61af66fc99e Initial load
duke
parents:
diff changeset
544
a61af66fc99e Initial load
duke
parents:
diff changeset
545 // Root of inline tree
1157
c3b315a0d58a 6912063: inlining parameters need to be adjusted for some uses of the JVM
jrose
parents: 1138
diff changeset
546 InlineTree *ilt = new InlineTree(C, NULL, C->method(), NULL, -1, 1.0F, 0);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
547
a61af66fc99e Initial load
duke
parents:
diff changeset
548 return ilt;
a61af66fc99e Initial load
duke
parents:
diff changeset
549 }
a61af66fc99e Initial load
duke
parents:
diff changeset
550
a61af66fc99e Initial load
duke
parents:
diff changeset
551
a61af66fc99e Initial load
duke
parents:
diff changeset
552 //-------------------------find_subtree_from_root-----------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
553 // Given a jvms, which determines a call chain from the root method,
a61af66fc99e Initial load
duke
parents:
diff changeset
554 // find the corresponding inline tree.
a61af66fc99e Initial load
duke
parents:
diff changeset
555 // Note: This method will be removed or replaced as InlineTree goes away.
a61af66fc99e Initial load
duke
parents:
diff changeset
556 InlineTree* InlineTree::find_subtree_from_root(InlineTree* root, JVMState* jvms, ciMethod* callee, bool create_if_not_found) {
a61af66fc99e Initial load
duke
parents:
diff changeset
557 InlineTree* iltp = root;
a61af66fc99e Initial load
duke
parents:
diff changeset
558 uint depth = jvms && jvms->has_method() ? jvms->depth() : 0;
a61af66fc99e Initial load
duke
parents:
diff changeset
559 for (uint d = 1; d <= depth; d++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
560 JVMState* jvmsp = jvms->of_depth(d);
a61af66fc99e Initial load
duke
parents:
diff changeset
561 // Select the corresponding subtree for this bci.
a61af66fc99e Initial load
duke
parents:
diff changeset
562 assert(jvmsp->method() == iltp->method(), "tree still in sync");
a61af66fc99e Initial load
duke
parents:
diff changeset
563 ciMethod* d_callee = (d == depth) ? callee : jvms->of_depth(d+1)->method();
a61af66fc99e Initial load
duke
parents:
diff changeset
564 InlineTree* sub = iltp->callee_at(jvmsp->bci(), d_callee);
a61af66fc99e Initial load
duke
parents:
diff changeset
565 if (!sub) {
a61af66fc99e Initial load
duke
parents:
diff changeset
566 if (create_if_not_found && d == depth) {
a61af66fc99e Initial load
duke
parents:
diff changeset
567 return iltp->build_inline_tree_for_callee(d_callee, jvmsp, jvmsp->bci());
a61af66fc99e Initial load
duke
parents:
diff changeset
568 }
a61af66fc99e Initial load
duke
parents:
diff changeset
569 assert(sub != NULL, "should be a sub-ilt here");
a61af66fc99e Initial load
duke
parents:
diff changeset
570 return NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
571 }
a61af66fc99e Initial load
duke
parents:
diff changeset
572 iltp = sub;
a61af66fc99e Initial load
duke
parents:
diff changeset
573 }
a61af66fc99e Initial load
duke
parents:
diff changeset
574 return iltp;
a61af66fc99e Initial load
duke
parents:
diff changeset
575 }