annotate src/share/vm/opto/stringopts.cpp @ 1250:3f5b7efb9642

6920293: OptimizeStringConcat causing core dumps Reviewed-by: kvn, twisti
author never
date Fri, 05 Feb 2010 11:07:40 -0800
parents 7c57aead6d3e
children c18cbe5936b8
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
1080
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1 /*
1250
3f5b7efb9642 6920293: OptimizeStringConcat causing core dumps
never
parents: 1080
diff changeset
2 * Copyright 2009-2010 Sun Microsystems, Inc. All Rights Reserved.
1080
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
4 *
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
5 * This code is free software; you can redistribute it and/or modify it
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
6 * under the terms of the GNU General Public License version 2 only, as
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
7 * published by the Free Software Foundation.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
8 *
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
9 * This code is distributed in the hope that it will be useful, but WITHOUT
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
12 * version 2 for more details (a copy is included in the LICENSE file that
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
13 * accompanied this code).
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
14 *
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
15 * You should have received a copy of the GNU General Public License version
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
16 * 2 along with this work; if not, write to the Free Software Foundation,
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
18 *
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
19 * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
20 * CA 95054 USA or visit www.sun.com if you need additional information or
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
21 * have any questions.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
22 *
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
23 */
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
24
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
25 #include "incls/_precompiled.incl"
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
26 #include "incls/_stringopts.cpp.incl"
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
27
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
28 #define __ kit.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
29
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
30 class StringConcat : public ResourceObj {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
31 private:
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
32 PhaseStringOpts* _stringopts;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
33 Node* _string_alloc;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
34 AllocateNode* _begin; // The allocation the begins the pattern
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
35 CallStaticJavaNode* _end; // The final call of the pattern. Will either be
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
36 // SB.toString or or String.<init>(SB.toString)
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
37 bool _multiple; // indicates this is a fusion of two or more
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
38 // separate StringBuilders
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
39
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
40 Node* _arguments; // The list of arguments to be concatenated
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
41 GrowableArray<int> _mode; // into a String along with a mode flag
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
42 // indicating how to treat the value.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
43
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
44 Node_List _control; // List of control nodes that will be deleted
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
45 Node_List _uncommon_traps; // Uncommon traps that needs to be rewritten
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
46 // to restart at the initial JVMState.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
47 public:
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
48 // Mode for converting arguments to Strings
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
49 enum {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
50 StringMode,
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
51 IntMode,
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
52 CharMode
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
53 };
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
54
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
55 StringConcat(PhaseStringOpts* stringopts, CallStaticJavaNode* end):
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
56 _end(end),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
57 _begin(NULL),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
58 _multiple(false),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
59 _string_alloc(NULL),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
60 _stringopts(stringopts) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
61 _arguments = new (_stringopts->C, 1) Node(1);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
62 _arguments->del_req(0);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
63 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
64
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
65 bool validate_control_flow();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
66
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
67 void merge_add() {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
68 #if 0
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
69 // XXX This is place holder code for reusing an existing String
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
70 // allocation but the logic for checking the state safety is
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
71 // probably inadequate at the moment.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
72 CallProjections endprojs;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
73 sc->end()->extract_projections(&endprojs, false);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
74 if (endprojs.resproj != NULL) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
75 for (SimpleDUIterator i(endprojs.resproj); i.has_next(); i.next()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
76 CallStaticJavaNode *use = i.get()->isa_CallStaticJava();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
77 if (use != NULL && use->method() != NULL &&
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
78 use->method()->holder() == C->env()->String_klass() &&
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
79 use->method()->name() == ciSymbol::object_initializer_name() &&
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
80 use->in(TypeFunc::Parms + 1) == endprojs.resproj) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
81 // Found useless new String(sb.toString()) so reuse the newly allocated String
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
82 // when creating the result instead of allocating a new one.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
83 sc->set_string_alloc(use->in(TypeFunc::Parms));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
84 sc->set_end(use);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
85 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
86 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
87 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
88 #endif
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
89 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
90
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
91 StringConcat* merge(StringConcat* other, Node* arg);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
92
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
93 void set_allocation(AllocateNode* alloc) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
94 _begin = alloc;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
95 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
96
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
97 void append(Node* value, int mode) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
98 _arguments->add_req(value);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
99 _mode.append(mode);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
100 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
101 void push(Node* value, int mode) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
102 _arguments->ins_req(0, value);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
103 _mode.insert_before(0, mode);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
104 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
105 void push_string(Node* value) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
106 push(value, StringMode);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
107 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
108 void push_int(Node* value) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
109 push(value, IntMode);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
110 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
111 void push_char(Node* value) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
112 push(value, CharMode);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
113 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
114
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
115 Node* argument(int i) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
116 return _arguments->in(i);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
117 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
118 void set_argument(int i, Node* value) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
119 _arguments->set_req(i, value);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
120 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
121 int num_arguments() {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
122 return _mode.length();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
123 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
124 int mode(int i) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
125 return _mode.at(i);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
126 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
127 void add_control(Node* ctrl) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
128 assert(!_control.contains(ctrl), "only push once");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
129 _control.push(ctrl);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
130 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
131 CallStaticJavaNode* end() { return _end; }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
132 AllocateNode* begin() { return _begin; }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
133 Node* string_alloc() { return _string_alloc; }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
134
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
135 void eliminate_unneeded_control();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
136 void eliminate_initialize(InitializeNode* init);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
137 void eliminate_call(CallNode* call);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
138
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
139 void maybe_log_transform() {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
140 CompileLog* log = _stringopts->C->log();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
141 if (log != NULL) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
142 log->head("replace_string_concat arguments='%d' string_alloc='%d' multiple='%d'",
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
143 num_arguments(),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
144 _string_alloc != NULL,
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
145 _multiple);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
146 JVMState* p = _begin->jvms();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
147 while (p != NULL) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
148 log->elem("jvms bci='%d' method='%d'", p->bci(), log->identify(p->method()));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
149 p = p->caller();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
150 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
151 log->tail("replace_string_concat");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
152 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
153 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
154
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
155 void convert_uncommon_traps(GraphKit& kit, const JVMState* jvms) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
156 for (uint u = 0; u < _uncommon_traps.size(); u++) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
157 Node* uct = _uncommon_traps.at(u);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
158
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
159 // Build a new call using the jvms state of the allocate
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
160 address call_addr = SharedRuntime::uncommon_trap_blob()->instructions_begin();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
161 const TypeFunc* call_type = OptoRuntime::uncommon_trap_Type();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
162 int size = call_type->domain()->cnt();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
163 const TypePtr* no_memory_effects = NULL;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
164 Compile* C = _stringopts->C;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
165 CallStaticJavaNode* call = new (C, size) CallStaticJavaNode(call_type, call_addr, "uncommon_trap",
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
166 jvms->bci(), no_memory_effects);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
167 for (int e = 0; e < TypeFunc::Parms; e++) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
168 call->init_req(e, uct->in(e));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
169 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
170 // Set the trap request to record intrinsic failure if this trap
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
171 // is taken too many times. Ideally we would handle then traps by
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
172 // doing the original bookkeeping in the MDO so that if it caused
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
173 // the code to be thrown out we could still recompile and use the
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
174 // optimization. Failing the uncommon traps doesn't really mean
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
175 // that the optimization is a bad idea but there's no other way to
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
176 // do the MDO updates currently.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
177 int trap_request = Deoptimization::make_trap_request(Deoptimization::Reason_intrinsic,
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
178 Deoptimization::Action_make_not_entrant);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
179 call->init_req(TypeFunc::Parms, __ intcon(trap_request));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
180 kit.add_safepoint_edges(call);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
181
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
182 _stringopts->gvn()->transform(call);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
183 C->gvn_replace_by(uct, call);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
184 uct->disconnect_inputs(NULL);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
185 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
186 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
187
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
188 void cleanup() {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
189 // disconnect the hook node
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
190 _arguments->disconnect_inputs(NULL);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
191 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
192 };
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
193
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
194
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
195 void StringConcat::eliminate_unneeded_control() {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
196 eliminate_initialize(begin()->initialization());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
197 for (uint i = 0; i < _control.size(); i++) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
198 Node* n = _control.at(i);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
199 if (n->is_Call()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
200 if (n != _end) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
201 eliminate_call(n->as_Call());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
202 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
203 } else if (n->is_IfTrue()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
204 Compile* C = _stringopts->C;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
205 C->gvn_replace_by(n, n->in(0)->in(0));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
206 C->gvn_replace_by(n->in(0), C->top());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
207 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
208 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
209 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
210
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
211
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
212 StringConcat* StringConcat::merge(StringConcat* other, Node* arg) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
213 StringConcat* result = new StringConcat(_stringopts, _end);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
214 for (uint x = 0; x < _control.size(); x++) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
215 Node* n = _control.at(x);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
216 if (n->is_Call()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
217 result->_control.push(n);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
218 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
219 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
220 for (uint x = 0; x < other->_control.size(); x++) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
221 Node* n = other->_control.at(x);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
222 if (n->is_Call()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
223 result->_control.push(n);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
224 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
225 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
226 assert(result->_control.contains(other->_end), "what?");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
227 assert(result->_control.contains(_begin), "what?");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
228 for (int x = 0; x < num_arguments(); x++) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
229 if (argument(x) == arg) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
230 // replace the toString result with the all the arguments that
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
231 // made up the other StringConcat
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
232 for (int y = 0; y < other->num_arguments(); y++) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
233 result->append(other->argument(y), other->mode(y));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
234 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
235 } else {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
236 result->append(argument(x), mode(x));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
237 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
238 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
239 result->set_allocation(other->_begin);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
240 result->_multiple = true;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
241 return result;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
242 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
243
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
244
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
245 void StringConcat::eliminate_call(CallNode* call) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
246 Compile* C = _stringopts->C;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
247 CallProjections projs;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
248 call->extract_projections(&projs, false);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
249 if (projs.fallthrough_catchproj != NULL) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
250 C->gvn_replace_by(projs.fallthrough_catchproj, call->in(TypeFunc::Control));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
251 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
252 if (projs.fallthrough_memproj != NULL) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
253 C->gvn_replace_by(projs.fallthrough_memproj, call->in(TypeFunc::Memory));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
254 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
255 if (projs.catchall_memproj != NULL) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
256 C->gvn_replace_by(projs.catchall_memproj, C->top());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
257 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
258 if (projs.fallthrough_ioproj != NULL) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
259 C->gvn_replace_by(projs.fallthrough_ioproj, call->in(TypeFunc::I_O));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
260 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
261 if (projs.catchall_ioproj != NULL) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
262 C->gvn_replace_by(projs.catchall_ioproj, C->top());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
263 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
264 if (projs.catchall_catchproj != NULL) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
265 // EA can't cope with the partially collapsed graph this
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
266 // creates so put it on the worklist to be collapsed later.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
267 for (SimpleDUIterator i(projs.catchall_catchproj); i.has_next(); i.next()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
268 Node *use = i.get();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
269 int opc = use->Opcode();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
270 if (opc == Op_CreateEx || opc == Op_Region) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
271 _stringopts->record_dead_node(use);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
272 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
273 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
274 C->gvn_replace_by(projs.catchall_catchproj, C->top());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
275 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
276 if (projs.resproj != NULL) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
277 C->gvn_replace_by(projs.resproj, C->top());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
278 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
279 C->gvn_replace_by(call, C->top());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
280 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
281
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
282 void StringConcat::eliminate_initialize(InitializeNode* init) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
283 Compile* C = _stringopts->C;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
284
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
285 // Eliminate Initialize node.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
286 assert(init->outcnt() <= 2, "only a control and memory projection expected");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
287 assert(init->req() <= InitializeNode::RawStores, "no pending inits");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
288 Node *ctrl_proj = init->proj_out(TypeFunc::Control);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
289 if (ctrl_proj != NULL) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
290 C->gvn_replace_by(ctrl_proj, init->in(TypeFunc::Control));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
291 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
292 Node *mem_proj = init->proj_out(TypeFunc::Memory);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
293 if (mem_proj != NULL) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
294 Node *mem = init->in(TypeFunc::Memory);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
295 C->gvn_replace_by(mem_proj, mem);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
296 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
297 C->gvn_replace_by(init, C->top());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
298 init->disconnect_inputs(NULL);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
299 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
300
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
301 Node_List PhaseStringOpts::collect_toString_calls() {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
302 Node_List string_calls;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
303 Node_List worklist;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
304
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
305 _visited.Clear();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
306
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
307 // Prime the worklist
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
308 for (uint i = 1; i < C->root()->len(); i++) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
309 Node* n = C->root()->in(i);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
310 if (n != NULL && !_visited.test_set(n->_idx)) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
311 worklist.push(n);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
312 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
313 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
314
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
315 while (worklist.size() > 0) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
316 Node* ctrl = worklist.pop();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
317 if (ctrl->is_CallStaticJava()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
318 CallStaticJavaNode* csj = ctrl->as_CallStaticJava();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
319 ciMethod* m = csj->method();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
320 if (m != NULL &&
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
321 (m->intrinsic_id() == vmIntrinsics::_StringBuffer_toString ||
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
322 m->intrinsic_id() == vmIntrinsics::_StringBuilder_toString)) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
323 string_calls.push(csj);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
324 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
325 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
326 if (ctrl->in(0) != NULL && !_visited.test_set(ctrl->in(0)->_idx)) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
327 worklist.push(ctrl->in(0));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
328 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
329 if (ctrl->is_Region()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
330 for (uint i = 1; i < ctrl->len(); i++) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
331 if (ctrl->in(i) != NULL && !_visited.test_set(ctrl->in(i)->_idx)) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
332 worklist.push(ctrl->in(i));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
333 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
334 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
335 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
336 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
337 return string_calls;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
338 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
339
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
340
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
341 StringConcat* PhaseStringOpts::build_candidate(CallStaticJavaNode* call) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
342 ciMethod* m = call->method();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
343 ciSymbol* string_sig;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
344 ciSymbol* int_sig;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
345 ciSymbol* char_sig;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
346 if (m->holder() == C->env()->StringBuilder_klass()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
347 string_sig = ciSymbol::String_StringBuilder_signature();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
348 int_sig = ciSymbol::int_StringBuilder_signature();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
349 char_sig = ciSymbol::char_StringBuilder_signature();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
350 } else if (m->holder() == C->env()->StringBuffer_klass()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
351 string_sig = ciSymbol::String_StringBuffer_signature();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
352 int_sig = ciSymbol::int_StringBuffer_signature();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
353 char_sig = ciSymbol::char_StringBuffer_signature();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
354 } else {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
355 return NULL;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
356 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
357 #ifndef PRODUCT
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
358 if (PrintOptimizeStringConcat) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
359 tty->print("considering toString call in ");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
360 call->jvms()->dump_spec(tty); tty->cr();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
361 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
362 #endif
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
363
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
364 StringConcat* sc = new StringConcat(this, call);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
365
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
366 AllocateNode* alloc = NULL;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
367 InitializeNode* init = NULL;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
368
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
369 // possible opportunity for StringBuilder fusion
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
370 CallStaticJavaNode* cnode = call;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
371 while (cnode) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
372 Node* recv = cnode->in(TypeFunc::Parms)->uncast();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
373 if (recv->is_Proj()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
374 recv = recv->in(0);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
375 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
376 cnode = recv->isa_CallStaticJava();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
377 if (cnode == NULL) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
378 alloc = recv->isa_Allocate();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
379 if (alloc == NULL) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
380 break;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
381 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
382 // Find the constructor call
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
383 Node* result = alloc->result_cast();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
384 if (result == NULL || !result->is_CheckCastPP()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
385 // strange looking allocation
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
386 #ifndef PRODUCT
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
387 if (PrintOptimizeStringConcat) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
388 tty->print("giving up because allocation looks strange ");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
389 alloc->jvms()->dump_spec(tty); tty->cr();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
390 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
391 #endif
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
392 break;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
393 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
394 Node* constructor = NULL;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
395 for (SimpleDUIterator i(result); i.has_next(); i.next()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
396 CallStaticJavaNode *use = i.get()->isa_CallStaticJava();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
397 if (use != NULL && use->method() != NULL &&
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
398 use->method()->name() == ciSymbol::object_initializer_name() &&
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
399 use->method()->holder() == m->holder()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
400 // Matched the constructor.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
401 ciSymbol* sig = use->method()->signature()->as_symbol();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
402 if (sig == ciSymbol::void_method_signature() ||
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
403 sig == ciSymbol::int_void_signature() ||
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
404 sig == ciSymbol::string_void_signature()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
405 if (sig == ciSymbol::string_void_signature()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
406 // StringBuilder(String) so pick this up as the first argument
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
407 assert(use->in(TypeFunc::Parms + 1) != NULL, "what?");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
408 sc->push_string(use->in(TypeFunc::Parms + 1));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
409 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
410 // The int variant takes an initial size for the backing
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
411 // array so just treat it like the void version.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
412 constructor = use;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
413 } else {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
414 #ifndef PRODUCT
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
415 if (PrintOptimizeStringConcat) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
416 tty->print("unexpected constructor signature: %s", sig->as_utf8());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
417 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
418 #endif
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
419 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
420 break;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
421 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
422 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
423 if (constructor == NULL) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
424 // couldn't find constructor
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
425 #ifndef PRODUCT
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
426 if (PrintOptimizeStringConcat) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
427 tty->print("giving up because couldn't find constructor ");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
428 alloc->jvms()->dump_spec(tty);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
429 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
430 #endif
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
431 break;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
432 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
433
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
434 // Walked all the way back and found the constructor call so see
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
435 // if this call converted into a direct string concatenation.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
436 sc->add_control(call);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
437 sc->add_control(constructor);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
438 sc->add_control(alloc);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
439 sc->set_allocation(alloc);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
440 if (sc->validate_control_flow()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
441 return sc;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
442 } else {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
443 return NULL;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
444 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
445 } else if (cnode->method() == NULL) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
446 break;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
447 } else if (cnode->method()->holder() == m->holder() &&
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
448 cnode->method()->name() == ciSymbol::append_name() &&
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
449 (cnode->method()->signature()->as_symbol() == string_sig ||
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
450 cnode->method()->signature()->as_symbol() == char_sig ||
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
451 cnode->method()->signature()->as_symbol() == int_sig)) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
452 sc->add_control(cnode);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
453 Node* arg = cnode->in(TypeFunc::Parms + 1);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
454 if (cnode->method()->signature()->as_symbol() == int_sig) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
455 sc->push_int(arg);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
456 } else if (cnode->method()->signature()->as_symbol() == char_sig) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
457 sc->push_char(arg);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
458 } else {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
459 if (arg->is_Proj() && arg->in(0)->is_CallStaticJava()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
460 CallStaticJavaNode* csj = arg->in(0)->as_CallStaticJava();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
461 if (csj->method() != NULL &&
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
462 csj->method()->holder() == C->env()->Integer_klass() &&
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
463 csj->method()->name() == ciSymbol::toString_name()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
464 sc->add_control(csj);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
465 sc->push_int(csj->in(TypeFunc::Parms));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
466 continue;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
467 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
468 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
469 sc->push_string(arg);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
470 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
471 continue;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
472 } else {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
473 // some unhandled signature
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
474 #ifndef PRODUCT
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
475 if (PrintOptimizeStringConcat) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
476 tty->print("giving up because encountered unexpected signature ");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
477 cnode->tf()->dump(); tty->cr();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
478 cnode->in(TypeFunc::Parms + 1)->dump();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
479 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
480 #endif
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
481 break;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
482 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
483 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
484 return NULL;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
485 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
486
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
487
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
488 PhaseStringOpts::PhaseStringOpts(PhaseGVN* gvn, Unique_Node_List*):
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
489 Phase(StringOpts),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
490 _gvn(gvn),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
491 _visited(Thread::current()->resource_area()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
492
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
493 assert(OptimizeStringConcat, "shouldn't be here");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
494
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
495 size_table_field = C->env()->Integer_klass()->get_field_by_name(ciSymbol::make("sizeTable"),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
496 ciSymbol::make("[I"), true);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
497 if (size_table_field == NULL) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
498 // Something wrong so give up.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
499 assert(false, "why can't we find Integer.sizeTable?");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
500 return;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
501 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
502
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
503 // Collect the types needed to talk about the various slices of memory
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
504 const TypeInstPtr* string_type = TypeInstPtr::make(TypePtr::NotNull, C->env()->String_klass(),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
505 false, NULL, 0);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
506
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
507 const TypePtr* value_field_type = string_type->add_offset(java_lang_String::value_offset_in_bytes());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
508 const TypePtr* offset_field_type = string_type->add_offset(java_lang_String::offset_offset_in_bytes());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
509 const TypePtr* count_field_type = string_type->add_offset(java_lang_String::count_offset_in_bytes());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
510
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
511 value_field_idx = C->get_alias_index(value_field_type);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
512 count_field_idx = C->get_alias_index(count_field_type);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
513 offset_field_idx = C->get_alias_index(offset_field_type);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
514 char_adr_idx = C->get_alias_index(TypeAryPtr::CHARS);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
515
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
516 // For each locally allocated StringBuffer see if the usages can be
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
517 // collapsed into a single String construction.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
518
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
519 // Run through the list of allocation looking for SB.toString to see
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
520 // if it's possible to fuse the usage of the SB into a single String
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
521 // construction.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
522 GrowableArray<StringConcat*> concats;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
523 Node_List toStrings = collect_toString_calls();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
524 while (toStrings.size() > 0) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
525 StringConcat* sc = build_candidate(toStrings.pop()->as_CallStaticJava());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
526 if (sc != NULL) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
527 concats.push(sc);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
528 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
529 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
530
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
531 // try to coalesce separate concats
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
532 restart:
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
533 for (int c = 0; c < concats.length(); c++) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
534 StringConcat* sc = concats.at(c);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
535 for (int i = 0; i < sc->num_arguments(); i++) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
536 Node* arg = sc->argument(i);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
537 if (arg->is_Proj() && arg->in(0)->is_CallStaticJava()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
538 CallStaticJavaNode* csj = arg->in(0)->as_CallStaticJava();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
539 if (csj->method() != NULL &&
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
540 (csj->method()->holder() == C->env()->StringBuffer_klass() ||
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
541 csj->method()->holder() == C->env()->StringBuilder_klass()) &&
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
542 csj->method()->name() == ciSymbol::toString_name()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
543 for (int o = 0; o < concats.length(); o++) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
544 if (c == o) continue;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
545 StringConcat* other = concats.at(o);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
546 if (other->end() == csj) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
547 #ifndef PRODUCT
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
548 if (PrintOptimizeStringConcat) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
549 tty->print_cr("considering stacked concats");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
550 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
551 #endif
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
552
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
553 StringConcat* merged = sc->merge(other, arg);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
554 if (merged->validate_control_flow()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
555 #ifndef PRODUCT
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
556 if (PrintOptimizeStringConcat) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
557 tty->print_cr("stacking would succeed");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
558 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
559 #endif
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
560 if (c < o) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
561 concats.remove_at(o);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
562 concats.at_put(c, merged);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
563 } else {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
564 concats.remove_at(c);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
565 concats.at_put(o, merged);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
566 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
567 goto restart;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
568 } else {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
569 #ifndef PRODUCT
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
570 if (PrintOptimizeStringConcat) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
571 tty->print_cr("stacking would fail");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
572 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
573 #endif
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
574 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
575 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
576 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
577 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
578 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
579 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
580 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
581
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
582
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
583 for (int c = 0; c < concats.length(); c++) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
584 StringConcat* sc = concats.at(c);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
585 replace_string_concat(sc);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
586 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
587
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
588 remove_dead_nodes();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
589 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
590
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
591 void PhaseStringOpts::record_dead_node(Node* dead) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
592 dead_worklist.push(dead);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
593 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
594
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
595 void PhaseStringOpts::remove_dead_nodes() {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
596 // Delete any dead nodes to make things clean enough that escape
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
597 // analysis doesn't get unhappy.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
598 while (dead_worklist.size() > 0) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
599 Node* use = dead_worklist.pop();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
600 int opc = use->Opcode();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
601 switch (opc) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
602 case Op_Region: {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
603 uint i = 1;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
604 for (i = 1; i < use->req(); i++) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
605 if (use->in(i) != C->top()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
606 break;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
607 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
608 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
609 if (i >= use->req()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
610 for (SimpleDUIterator i(use); i.has_next(); i.next()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
611 Node* m = i.get();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
612 if (m->is_Phi()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
613 dead_worklist.push(m);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
614 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
615 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
616 C->gvn_replace_by(use, C->top());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
617 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
618 break;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
619 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
620 case Op_AddP:
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
621 case Op_CreateEx: {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
622 // Recurisvely clean up references to CreateEx so EA doesn't
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
623 // get unhappy about the partially collapsed graph.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
624 for (SimpleDUIterator i(use); i.has_next(); i.next()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
625 Node* m = i.get();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
626 if (m->is_AddP()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
627 dead_worklist.push(m);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
628 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
629 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
630 C->gvn_replace_by(use, C->top());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
631 break;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
632 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
633 case Op_Phi:
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
634 if (use->in(0) == C->top()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
635 C->gvn_replace_by(use, C->top());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
636 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
637 break;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
638 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
639 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
640 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
641
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
642
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
643 bool StringConcat::validate_control_flow() {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
644 // We found all the calls and arguments now lets see if it's
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
645 // safe to transform the graph as we would expect.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
646
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
647 // Check to see if this resulted in too many uncommon traps previously
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
648 if (Compile::current()->too_many_traps(_begin->jvms()->method(), _begin->jvms()->bci(),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
649 Deoptimization::Reason_intrinsic)) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
650 return false;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
651 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
652
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
653 // Walk backwards over the control flow from toString to the
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
654 // allocation and make sure all the control flow is ok. This
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
655 // means it's either going to be eliminated once the calls are
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
656 // removed or it can safely be transformed into an uncommon
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
657 // trap.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
658
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
659 int null_check_count = 0;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
660 Unique_Node_List ctrl_path;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
661
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
662 assert(_control.contains(_begin), "missing");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
663 assert(_control.contains(_end), "missing");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
664
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
665 // Collect the nodes that we know about and will eliminate into ctrl_path
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
666 for (uint i = 0; i < _control.size(); i++) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
667 // Push the call and it's control projection
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
668 Node* n = _control.at(i);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
669 if (n->is_Allocate()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
670 AllocateNode* an = n->as_Allocate();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
671 InitializeNode* init = an->initialization();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
672 ctrl_path.push(init);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
673 ctrl_path.push(init->as_Multi()->proj_out(0));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
674 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
675 if (n->is_Call()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
676 CallNode* cn = n->as_Call();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
677 ctrl_path.push(cn);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
678 ctrl_path.push(cn->proj_out(0));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
679 ctrl_path.push(cn->proj_out(0)->unique_out());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
680 ctrl_path.push(cn->proj_out(0)->unique_out()->as_Catch()->proj_out(0));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
681 } else {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
682 ShouldNotReachHere();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
683 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
684 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
685
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
686 // Skip backwards through the control checking for unexpected contro flow
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
687 Node* ptr = _end;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
688 bool fail = false;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
689 while (ptr != _begin) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
690 if (ptr->is_Call() && ctrl_path.member(ptr)) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
691 ptr = ptr->in(0);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
692 } else if (ptr->is_CatchProj() && ctrl_path.member(ptr)) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
693 ptr = ptr->in(0)->in(0)->in(0);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
694 assert(ctrl_path.member(ptr), "should be a known piece of control");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
695 } else if (ptr->is_IfTrue()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
696 IfNode* iff = ptr->in(0)->as_If();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
697 BoolNode* b = iff->in(1)->isa_Bool();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
698 Node* cmp = b->in(1);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
699 Node* v1 = cmp->in(1);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
700 Node* v2 = cmp->in(2);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
701 Node* otherproj = iff->proj_out(1 - ptr->as_Proj()->_con);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
702
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
703 // Null check of the return of append which can simply be eliminated
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
704 if (b->_test._test == BoolTest::ne &&
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
705 v2->bottom_type() == TypePtr::NULL_PTR &&
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
706 v1->is_Proj() && ctrl_path.member(v1->in(0))) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
707 // NULL check of the return value of the append
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
708 null_check_count++;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
709 if (otherproj->outcnt() == 1) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
710 CallStaticJavaNode* call = otherproj->unique_out()->isa_CallStaticJava();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
711 if (call != NULL && call->_name != NULL && strcmp(call->_name, "uncommon_trap") == 0) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
712 ctrl_path.push(call);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
713 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
714 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
715 _control.push(ptr);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
716 ptr = ptr->in(0)->in(0);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
717 continue;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
718 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
719
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
720 // A test which leads to an uncommon trap which should be safe.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
721 // Later this trap will be converted into a trap that restarts
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
722 // at the beginning.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
723 if (otherproj->outcnt() == 1) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
724 CallStaticJavaNode* call = otherproj->unique_out()->isa_CallStaticJava();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
725 if (call != NULL && call->_name != NULL && strcmp(call->_name, "uncommon_trap") == 0) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
726 // control flow leads to uct so should be ok
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
727 _uncommon_traps.push(call);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
728 ctrl_path.push(call);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
729 ptr = ptr->in(0)->in(0);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
730 continue;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
731 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
732 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
733
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
734 #ifndef PRODUCT
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
735 // Some unexpected control flow we don't know how to handle.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
736 if (PrintOptimizeStringConcat) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
737 tty->print_cr("failing with unknown test");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
738 b->dump();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
739 cmp->dump();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
740 v1->dump();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
741 v2->dump();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
742 tty->cr();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
743 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
744 #endif
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
745 break;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
746 } else if (ptr->is_Proj() && ptr->in(0)->is_Initialize()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
747 ptr = ptr->in(0)->in(0);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
748 } else if (ptr->is_Region()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
749 Node* copy = ptr->as_Region()->is_copy();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
750 if (copy != NULL) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
751 ptr = copy;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
752 continue;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
753 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
754 if (ptr->req() == 3 &&
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
755 ptr->in(1) != NULL && ptr->in(1)->is_Proj() &&
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
756 ptr->in(2) != NULL && ptr->in(2)->is_Proj() &&
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
757 ptr->in(1)->in(0) == ptr->in(2)->in(0) &&
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
758 ptr->in(1)->in(0) != NULL && ptr->in(1)->in(0)->is_If()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
759 // Simple diamond.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
760 // XXX should check for possibly merging stores. simple data merges are ok.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
761 ptr = ptr->in(1)->in(0)->in(0);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
762 continue;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
763 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
764 #ifndef PRODUCT
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
765 if (PrintOptimizeStringConcat) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
766 tty->print_cr("fusion would fail for region");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
767 _begin->dump();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
768 ptr->dump(2);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
769 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
770 #endif
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
771 fail = true;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
772 break;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
773 } else {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
774 // other unknown control
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
775 if (!fail) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
776 #ifndef PRODUCT
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
777 if (PrintOptimizeStringConcat) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
778 tty->print_cr("fusion would fail for");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
779 _begin->dump();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
780 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
781 #endif
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
782 fail = true;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
783 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
784 #ifndef PRODUCT
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
785 if (PrintOptimizeStringConcat) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
786 ptr->dump();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
787 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
788 #endif
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
789 ptr = ptr->in(0);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
790 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
791 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
792 #ifndef PRODUCT
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
793 if (PrintOptimizeStringConcat && fail) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
794 tty->cr();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
795 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
796 #endif
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
797 if (fail) return !fail;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
798
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
799 // Validate that all these results produced are contained within
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
800 // this cluster of objects. First collect all the results produced
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
801 // by calls in the region.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
802 _stringopts->_visited.Clear();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
803 Node_List worklist;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
804 Node* final_result = _end->proj_out(TypeFunc::Parms);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
805 for (uint i = 0; i < _control.size(); i++) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
806 CallNode* cnode = _control.at(i)->isa_Call();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
807 if (cnode != NULL) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
808 _stringopts->_visited.test_set(cnode->_idx);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
809 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
810 Node* result = cnode != NULL ? cnode->proj_out(TypeFunc::Parms) : NULL;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
811 if (result != NULL && result != final_result) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
812 worklist.push(result);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
813 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
814 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
815
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
816 Node* last_result = NULL;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
817 while (worklist.size() > 0) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
818 Node* result = worklist.pop();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
819 if (_stringopts->_visited.test_set(result->_idx))
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
820 continue;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
821 for (SimpleDUIterator i(result); i.has_next(); i.next()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
822 Node *use = i.get();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
823 if (ctrl_path.member(use)) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
824 // already checked this
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
825 continue;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
826 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
827 int opc = use->Opcode();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
828 if (opc == Op_CmpP || opc == Op_Node) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
829 ctrl_path.push(use);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
830 continue;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
831 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
832 if (opc == Op_CastPP || opc == Op_CheckCastPP) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
833 for (SimpleDUIterator j(use); j.has_next(); j.next()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
834 worklist.push(j.get());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
835 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
836 worklist.push(use->in(1));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
837 ctrl_path.push(use);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
838 continue;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
839 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
840 #ifndef PRODUCT
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
841 if (PrintOptimizeStringConcat) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
842 if (result != last_result) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
843 last_result = result;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
844 tty->print_cr("extra uses for result:");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
845 last_result->dump();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
846 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
847 use->dump();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
848 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
849 #endif
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
850 fail = true;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
851 break;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
852 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
853 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
854
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
855 #ifndef PRODUCT
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
856 if (PrintOptimizeStringConcat && !fail) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
857 ttyLocker ttyl;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
858 tty->cr();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
859 tty->print("fusion would succeed (%d %d) for ", null_check_count, _uncommon_traps.size());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
860 _begin->jvms()->dump_spec(tty); tty->cr();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
861 for (int i = 0; i < num_arguments(); i++) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
862 argument(i)->dump();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
863 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
864 _control.dump();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
865 tty->cr();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
866 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
867 #endif
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
868
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
869 return !fail;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
870 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
871
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
872 Node* PhaseStringOpts::fetch_static_field(GraphKit& kit, ciField* field) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
873 const TypeKlassPtr* klass_type = TypeKlassPtr::make(field->holder());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
874 Node* klass_node = __ makecon(klass_type);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
875 BasicType bt = field->layout_type();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
876 ciType* field_klass = field->type();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
877
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
878 const Type *type;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
879 if( bt == T_OBJECT ) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
880 if (!field->type()->is_loaded()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
881 type = TypeInstPtr::BOTTOM;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
882 } else if (field->is_constant()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
883 // This can happen if the constant oop is non-perm.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
884 ciObject* con = field->constant_value().as_object();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
885 // Do not "join" in the previous type; it doesn't add value,
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
886 // and may yield a vacuous result if the field is of interface type.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
887 type = TypeOopPtr::make_from_constant(con)->isa_oopptr();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
888 assert(type != NULL, "field singleton type must be consistent");
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
889 } else {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
890 type = TypeOopPtr::make_from_klass(field_klass->as_klass());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
891 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
892 } else {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
893 type = Type::get_const_basic_type(bt);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
894 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
895
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
896 return kit.make_load(NULL, kit.basic_plus_adr(klass_node, field->offset_in_bytes()),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
897 type, T_OBJECT,
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
898 C->get_alias_index(klass_type->add_offset(field->offset_in_bytes())));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
899 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
900
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
901 Node* PhaseStringOpts::int_stringSize(GraphKit& kit, Node* arg) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
902 RegionNode *final_merge = new (C, 3) RegionNode(3);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
903 kit.gvn().set_type(final_merge, Type::CONTROL);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
904 Node* final_size = new (C, 3) PhiNode(final_merge, TypeInt::INT);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
905 kit.gvn().set_type(final_size, TypeInt::INT);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
906
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
907 IfNode* iff = kit.create_and_map_if(kit.control(),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
908 __ Bool(__ CmpI(arg, __ intcon(0x80000000)), BoolTest::ne),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
909 PROB_FAIR, COUNT_UNKNOWN);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
910 Node* is_min = __ IfFalse(iff);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
911 final_merge->init_req(1, is_min);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
912 final_size->init_req(1, __ intcon(11));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
913
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
914 kit.set_control(__ IfTrue(iff));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
915 if (kit.stopped()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
916 final_merge->init_req(2, C->top());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
917 final_size->init_req(2, C->top());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
918 } else {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
919
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
920 // int size = (i < 0) ? stringSize(-i) + 1 : stringSize(i);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
921 RegionNode *r = new (C, 3) RegionNode(3);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
922 kit.gvn().set_type(r, Type::CONTROL);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
923 Node *phi = new (C, 3) PhiNode(r, TypeInt::INT);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
924 kit.gvn().set_type(phi, TypeInt::INT);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
925 Node *size = new (C, 3) PhiNode(r, TypeInt::INT);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
926 kit.gvn().set_type(size, TypeInt::INT);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
927 Node* chk = __ CmpI(arg, __ intcon(0));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
928 Node* p = __ Bool(chk, BoolTest::lt);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
929 IfNode* iff = kit.create_and_map_if(kit.control(), p, PROB_FAIR, COUNT_UNKNOWN);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
930 Node* lessthan = __ IfTrue(iff);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
931 Node* greaterequal = __ IfFalse(iff);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
932 r->init_req(1, lessthan);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
933 phi->init_req(1, __ SubI(__ intcon(0), arg));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
934 size->init_req(1, __ intcon(1));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
935 r->init_req(2, greaterequal);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
936 phi->init_req(2, arg);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
937 size->init_req(2, __ intcon(0));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
938 kit.set_control(r);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
939 C->record_for_igvn(r);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
940 C->record_for_igvn(phi);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
941 C->record_for_igvn(size);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
942
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
943 // for (int i=0; ; i++)
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
944 // if (x <= sizeTable[i])
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
945 // return i+1;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
946 RegionNode *loop = new (C, 3) RegionNode(3);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
947 loop->init_req(1, kit.control());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
948 kit.gvn().set_type(loop, Type::CONTROL);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
949
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
950 Node *index = new (C, 3) PhiNode(loop, TypeInt::INT);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
951 index->init_req(1, __ intcon(0));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
952 kit.gvn().set_type(index, TypeInt::INT);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
953 kit.set_control(loop);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
954 Node* sizeTable = fetch_static_field(kit, size_table_field);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
955
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
956 Node* value = kit.load_array_element(NULL, sizeTable, index, TypeAryPtr::INTS);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
957 C->record_for_igvn(value);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
958 Node* limit = __ CmpI(phi, value);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
959 Node* limitb = __ Bool(limit, BoolTest::le);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
960 IfNode* iff2 = kit.create_and_map_if(kit.control(), limitb, PROB_MIN, COUNT_UNKNOWN);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
961 Node* lessEqual = __ IfTrue(iff2);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
962 Node* greater = __ IfFalse(iff2);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
963
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
964 loop->init_req(2, greater);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
965 index->init_req(2, __ AddI(index, __ intcon(1)));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
966
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
967 kit.set_control(lessEqual);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
968 C->record_for_igvn(loop);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
969 C->record_for_igvn(index);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
970
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
971 final_merge->init_req(2, kit.control());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
972 final_size->init_req(2, __ AddI(__ AddI(index, size), __ intcon(1)));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
973 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
974
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
975 kit.set_control(final_merge);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
976 C->record_for_igvn(final_merge);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
977 C->record_for_igvn(final_size);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
978
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
979 return final_size;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
980 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
981
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
982 void PhaseStringOpts::int_getChars(GraphKit& kit, Node* arg, Node* char_array, Node* start, Node* end) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
983 RegionNode *final_merge = new (C, 4) RegionNode(4);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
984 kit.gvn().set_type(final_merge, Type::CONTROL);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
985 Node *final_mem = PhiNode::make(final_merge, kit.memory(char_adr_idx), Type::MEMORY, TypeAryPtr::CHARS);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
986 kit.gvn().set_type(final_mem, Type::MEMORY);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
987
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
988 // need to handle Integer.MIN_VALUE specially because negating doesn't make it positive
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
989 {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
990 // i == MIN_VALUE
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
991 IfNode* iff = kit.create_and_map_if(kit.control(),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
992 __ Bool(__ CmpI(arg, __ intcon(0x80000000)), BoolTest::ne),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
993 PROB_FAIR, COUNT_UNKNOWN);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
994
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
995 Node* old_mem = kit.memory(char_adr_idx);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
996
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
997 kit.set_control(__ IfFalse(iff));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
998 if (kit.stopped()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
999 // Statically not equal to MIN_VALUE so this path is dead
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1000 final_merge->init_req(3, kit.control());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1001 } else {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1002 copy_string(kit, __ makecon(TypeInstPtr::make(C->env()->the_min_jint_string())),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1003 char_array, start);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1004 final_merge->init_req(3, kit.control());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1005 final_mem->init_req(3, kit.memory(char_adr_idx));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1006 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1007
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1008 kit.set_control(__ IfTrue(iff));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1009 kit.set_memory(old_mem, char_adr_idx);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1010 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1011
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1012
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1013 // Simplified version of Integer.getChars
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1014
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1015 // int q, r;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1016 // int charPos = index;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1017 Node* charPos = end;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1018
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1019 // char sign = 0;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1020
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1021 Node* i = arg;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1022 Node* sign = __ intcon(0);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1023
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1024 // if (i < 0) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1025 // sign = '-';
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1026 // i = -i;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1027 // }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1028 {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1029 IfNode* iff = kit.create_and_map_if(kit.control(),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1030 __ Bool(__ CmpI(arg, __ intcon(0)), BoolTest::lt),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1031 PROB_FAIR, COUNT_UNKNOWN);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1032
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1033 RegionNode *merge = new (C, 3) RegionNode(3);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1034 kit.gvn().set_type(merge, Type::CONTROL);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1035 i = new (C, 3) PhiNode(merge, TypeInt::INT);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1036 kit.gvn().set_type(i, TypeInt::INT);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1037 sign = new (C, 3) PhiNode(merge, TypeInt::INT);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1038 kit.gvn().set_type(sign, TypeInt::INT);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1039
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1040 merge->init_req(1, __ IfTrue(iff));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1041 i->init_req(1, __ SubI(__ intcon(0), arg));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1042 sign->init_req(1, __ intcon('-'));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1043 merge->init_req(2, __ IfFalse(iff));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1044 i->init_req(2, arg);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1045 sign->init_req(2, __ intcon(0));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1046
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1047 kit.set_control(merge);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1048
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1049 C->record_for_igvn(merge);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1050 C->record_for_igvn(i);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1051 C->record_for_igvn(sign);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1052 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1053
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1054 // for (;;) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1055 // q = i / 10;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1056 // r = i - ((q << 3) + (q << 1)); // r = i-(q*10) ...
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1057 // buf [--charPos] = digits [r];
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1058 // i = q;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1059 // if (i == 0) break;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1060 // }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1061
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1062 {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1063 RegionNode *head = new (C, 3) RegionNode(3);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1064 head->init_req(1, kit.control());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1065 kit.gvn().set_type(head, Type::CONTROL);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1066 Node *i_phi = new (C, 3) PhiNode(head, TypeInt::INT);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1067 i_phi->init_req(1, i);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1068 kit.gvn().set_type(i_phi, TypeInt::INT);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1069 charPos = PhiNode::make(head, charPos);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1070 kit.gvn().set_type(charPos, TypeInt::INT);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1071 Node *mem = PhiNode::make(head, kit.memory(char_adr_idx), Type::MEMORY, TypeAryPtr::CHARS);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1072 kit.gvn().set_type(mem, Type::MEMORY);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1073 kit.set_control(head);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1074 kit.set_memory(mem, char_adr_idx);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1075
1250
3f5b7efb9642 6920293: OptimizeStringConcat causing core dumps
never
parents: 1080
diff changeset
1076 Node* q = __ DivI(NULL, i_phi, __ intcon(10));
1080
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1077 Node* r = __ SubI(i_phi, __ AddI(__ LShiftI(q, __ intcon(3)),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1078 __ LShiftI(q, __ intcon(1))));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1079 Node* m1 = __ SubI(charPos, __ intcon(1));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1080 Node* ch = __ AddI(r, __ intcon('0'));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1081
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1082 Node* st = __ store_to_memory(kit.control(), kit.array_element_address(char_array, m1, T_CHAR),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1083 ch, T_CHAR, char_adr_idx);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1084
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1085
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1086 IfNode* iff = kit.create_and_map_if(head, __ Bool(__ CmpI(q, __ intcon(0)), BoolTest::ne),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1087 PROB_FAIR, COUNT_UNKNOWN);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1088 Node* ne = __ IfTrue(iff);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1089 Node* eq = __ IfFalse(iff);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1090
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1091 head->init_req(2, ne);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1092 mem->init_req(2, st);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1093 i_phi->init_req(2, q);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1094 charPos->init_req(2, m1);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1095
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1096 charPos = m1;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1097
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1098 kit.set_control(eq);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1099 kit.set_memory(st, char_adr_idx);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1100
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1101 C->record_for_igvn(head);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1102 C->record_for_igvn(mem);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1103 C->record_for_igvn(i_phi);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1104 C->record_for_igvn(charPos);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1105 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1106
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1107 {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1108 // if (sign != 0) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1109 // buf [--charPos] = sign;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1110 // }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1111 IfNode* iff = kit.create_and_map_if(kit.control(),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1112 __ Bool(__ CmpI(sign, __ intcon(0)), BoolTest::ne),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1113 PROB_FAIR, COUNT_UNKNOWN);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1114
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1115 final_merge->init_req(2, __ IfFalse(iff));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1116 final_mem->init_req(2, kit.memory(char_adr_idx));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1117
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1118 kit.set_control(__ IfTrue(iff));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1119 if (kit.stopped()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1120 final_merge->init_req(1, C->top());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1121 final_mem->init_req(1, C->top());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1122 } else {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1123 Node* m1 = __ SubI(charPos, __ intcon(1));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1124 Node* st = __ store_to_memory(kit.control(), kit.array_element_address(char_array, m1, T_CHAR),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1125 sign, T_CHAR, char_adr_idx);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1126
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1127 final_merge->init_req(1, kit.control());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1128 final_mem->init_req(1, st);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1129 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1130
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1131 kit.set_control(final_merge);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1132 kit.set_memory(final_mem, char_adr_idx);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1133
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1134 C->record_for_igvn(final_merge);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1135 C->record_for_igvn(final_mem);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1136 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1137 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1138
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1139
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1140 Node* PhaseStringOpts::copy_string(GraphKit& kit, Node* str, Node* char_array, Node* start) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1141 Node* string = str;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1142 Node* offset = kit.make_load(NULL,
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1143 kit.basic_plus_adr(string, string, java_lang_String::offset_offset_in_bytes()),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1144 TypeInt::INT, T_INT, offset_field_idx);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1145 Node* count = kit.make_load(NULL,
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1146 kit.basic_plus_adr(string, string, java_lang_String::count_offset_in_bytes()),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1147 TypeInt::INT, T_INT, count_field_idx);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1148 const TypeAryPtr* value_type = TypeAryPtr::make(TypePtr::NotNull,
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1149 TypeAry::make(TypeInt::CHAR,TypeInt::POS),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1150 ciTypeArrayKlass::make(T_CHAR), true, 0);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1151 Node* value = kit.make_load(NULL,
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1152 kit.basic_plus_adr(string, string, java_lang_String::value_offset_in_bytes()),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1153 value_type, T_OBJECT, value_field_idx);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1154
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1155 // copy the contents
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1156 if (offset->is_Con() && count->is_Con() && value->is_Con() && count->get_int() < unroll_string_copy_length) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1157 // For small constant strings just emit individual stores.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1158 // A length of 6 seems like a good space/speed tradeof.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1159 int c = count->get_int();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1160 int o = offset->get_int();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1161 const TypeOopPtr* t = kit.gvn().type(value)->isa_oopptr();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1162 ciTypeArray* value_array = t->const_oop()->as_type_array();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1163 for (int e = 0; e < c; e++) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1164 __ store_to_memory(kit.control(), kit.array_element_address(char_array, start, T_CHAR),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1165 __ intcon(value_array->char_at(o + e)), T_CHAR, char_adr_idx);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1166 start = __ AddI(start, __ intcon(1));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1167 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1168 } else {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1169 Node* src_ptr = kit.array_element_address(value, offset, T_CHAR);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1170 Node* dst_ptr = kit.array_element_address(char_array, start, T_CHAR);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1171 Node* c = count;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1172 Node* extra = NULL;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1173 #ifdef _LP64
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1174 c = __ ConvI2L(c);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1175 extra = C->top();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1176 #endif
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1177 Node* call = kit.make_runtime_call(GraphKit::RC_LEAF|GraphKit::RC_NO_FP,
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1178 OptoRuntime::fast_arraycopy_Type(),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1179 CAST_FROM_FN_PTR(address, StubRoutines::jshort_disjoint_arraycopy()),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1180 "jshort_disjoint_arraycopy", TypeAryPtr::CHARS,
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1181 src_ptr, dst_ptr, c, extra);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1182 start = __ AddI(start, count);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1183 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1184 return start;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1185 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1186
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1187
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1188 void PhaseStringOpts::replace_string_concat(StringConcat* sc) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1189 // Log a little info about the transformation
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1190 sc->maybe_log_transform();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1191
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1192 // pull the JVMState of the allocation into a SafePointNode to serve as
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1193 // as a shim for the insertion of the new code.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1194 JVMState* jvms = sc->begin()->jvms()->clone_shallow(C);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1195 uint size = sc->begin()->req();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1196 SafePointNode* map = new (C, size) SafePointNode(size, jvms);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1197
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1198 // copy the control and memory state from the final call into our
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1199 // new starting state. This allows any preceeding tests to feed
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1200 // into the new section of code.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1201 for (uint i1 = 0; i1 < TypeFunc::Parms; i1++) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1202 map->init_req(i1, sc->end()->in(i1));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1203 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1204 // blow away old allocation arguments
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1205 for (uint i1 = TypeFunc::Parms; i1 < jvms->debug_start(); i1++) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1206 map->init_req(i1, C->top());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1207 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1208 // Copy the rest of the inputs for the JVMState
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1209 for (uint i1 = jvms->debug_start(); i1 < sc->begin()->req(); i1++) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1210 map->init_req(i1, sc->begin()->in(i1));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1211 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1212 // Make sure the memory state is a MergeMem for parsing.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1213 if (!map->in(TypeFunc::Memory)->is_MergeMem()) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1214 map->set_req(TypeFunc::Memory, MergeMemNode::make(C, map->in(TypeFunc::Memory)));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1215 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1216
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1217 jvms->set_map(map);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1218 map->ensure_stack(jvms, jvms->method()->max_stack());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1219
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1220
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1221 // disconnect all the old StringBuilder calls from the graph
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1222 sc->eliminate_unneeded_control();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1223
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1224 // At this point all the old work has been completely removed from
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1225 // the graph and the saved JVMState exists at the point where the
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1226 // final toString call used to be.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1227 GraphKit kit(jvms);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1228
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1229 // There may be uncommon traps which are still using the
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1230 // intermediate states and these need to be rewritten to point at
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1231 // the JVMState at the beginning of the transformation.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1232 sc->convert_uncommon_traps(kit, jvms);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1233
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1234 // Now insert the logic to compute the size of the string followed
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1235 // by all the logic to construct array and resulting string.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1236
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1237 Node* null_string = __ makecon(TypeInstPtr::make(C->env()->the_null_string()));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1238
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1239 // Create a region for the overflow checks to merge into.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1240 int args = MAX2(sc->num_arguments(), 1);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1241 RegionNode* overflow = new (C, args) RegionNode(args);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1242 kit.gvn().set_type(overflow, Type::CONTROL);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1243
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1244 // Create a hook node to hold onto the individual sizes since they
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1245 // are need for the copying phase.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1246 Node* string_sizes = new (C, args) Node(args);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1247
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1248 Node* length = __ intcon(0);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1249 for (int argi = 0; argi < sc->num_arguments(); argi++) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1250 Node* arg = sc->argument(argi);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1251 switch (sc->mode(argi)) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1252 case StringConcat::IntMode: {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1253 Node* string_size = int_stringSize(kit, arg);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1254
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1255 // accumulate total
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1256 length = __ AddI(length, string_size);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1257
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1258 // Cache this value for the use by int_toString
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1259 string_sizes->init_req(argi, string_size);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1260 break;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1261 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1262 case StringConcat::StringMode: {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1263 const Type* type = kit.gvn().type(arg);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1264 if (type == TypePtr::NULL_PTR) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1265 // replace the argument with the null checked version
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1266 arg = null_string;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1267 sc->set_argument(argi, arg);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1268 } else if (!type->higher_equal(TypeInstPtr::NOTNULL)) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1269 // s = s != null ? s : "null";
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1270 // length = length + (s.count - s.offset);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1271 RegionNode *r = new (C, 3) RegionNode(3);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1272 kit.gvn().set_type(r, Type::CONTROL);
1250
3f5b7efb9642 6920293: OptimizeStringConcat causing core dumps
never
parents: 1080
diff changeset
1273 Node *phi = new (C, 3) PhiNode(r, type);
1080
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1274 kit.gvn().set_type(phi, phi->bottom_type());
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1275 Node* p = __ Bool(__ CmpP(arg, kit.null()), BoolTest::ne);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1276 IfNode* iff = kit.create_and_map_if(kit.control(), p, PROB_MIN, COUNT_UNKNOWN);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1277 Node* notnull = __ IfTrue(iff);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1278 Node* isnull = __ IfFalse(iff);
1250
3f5b7efb9642 6920293: OptimizeStringConcat causing core dumps
never
parents: 1080
diff changeset
1279 kit.set_control(notnull); // set control for the cast_not_null
1080
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1280 r->init_req(1, notnull);
1250
3f5b7efb9642 6920293: OptimizeStringConcat causing core dumps
never
parents: 1080
diff changeset
1281 phi->init_req(1, kit.cast_not_null(arg, false));
1080
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1282 r->init_req(2, isnull);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1283 phi->init_req(2, null_string);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1284 kit.set_control(r);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1285 C->record_for_igvn(r);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1286 C->record_for_igvn(phi);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1287 // replace the argument with the null checked version
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1288 arg = phi;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1289 sc->set_argument(argi, arg);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1290 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1291 // Node* offset = kit.make_load(NULL, kit.basic_plus_adr(arg, arg, offset_offset),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1292 // TypeInt::INT, T_INT, offset_field_idx);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1293 Node* count = kit.make_load(NULL, kit.basic_plus_adr(arg, arg, java_lang_String::count_offset_in_bytes()),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1294 TypeInt::INT, T_INT, count_field_idx);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1295 length = __ AddI(length, count);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1296 string_sizes->init_req(argi, NULL);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1297 break;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1298 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1299 case StringConcat::CharMode: {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1300 // one character only
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1301 length = __ AddI(length, __ intcon(1));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1302 break;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1303 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1304 default:
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1305 ShouldNotReachHere();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1306 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1307 if (argi > 0) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1308 // Check that the sum hasn't overflowed
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1309 IfNode* iff = kit.create_and_map_if(kit.control(),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1310 __ Bool(__ CmpI(length, __ intcon(0)), BoolTest::lt),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1311 PROB_MIN, COUNT_UNKNOWN);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1312 kit.set_control(__ IfFalse(iff));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1313 overflow->set_req(argi, __ IfTrue(iff));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1314 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1315 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1316
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1317 {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1318 // Hook
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1319 PreserveJVMState pjvms(&kit);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1320 kit.set_control(overflow);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1321 kit.uncommon_trap(Deoptimization::Reason_intrinsic,
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1322 Deoptimization::Action_make_not_entrant);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1323 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1324
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1325 // length now contains the number of characters needed for the
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1326 // char[] so create a new AllocateArray for the char[]
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1327 Node* char_array = NULL;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1328 {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1329 PreserveReexecuteState preexecs(&kit);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1330 // The original jvms is for an allocation of either a String or
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1331 // StringBuffer so no stack adjustment is necessary for proper
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1332 // reexecution. If we deoptimize in the slow path the bytecode
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1333 // will be reexecuted and the char[] allocation will be thrown away.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1334 kit.jvms()->set_should_reexecute(true);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1335 char_array = kit.new_array(__ makecon(TypeKlassPtr::make(ciTypeArrayKlass::make(T_CHAR))),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1336 length, 1);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1337 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1338
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1339 // Mark the allocation so that zeroing is skipped since the code
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1340 // below will overwrite the entire array
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1341 AllocateArrayNode* char_alloc = AllocateArrayNode::Ideal_array_allocation(char_array, _gvn);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1342 char_alloc->maybe_set_complete(_gvn);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1343
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1344 // Now copy the string representations into the final char[]
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1345 Node* start = __ intcon(0);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1346 for (int argi = 0; argi < sc->num_arguments(); argi++) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1347 Node* arg = sc->argument(argi);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1348 switch (sc->mode(argi)) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1349 case StringConcat::IntMode: {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1350 Node* end = __ AddI(start, string_sizes->in(argi));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1351 // getChars words backwards so pass the ending point as well as the start
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1352 int_getChars(kit, arg, char_array, start, end);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1353 start = end;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1354 break;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1355 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1356 case StringConcat::StringMode: {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1357 start = copy_string(kit, arg, char_array, start);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1358 break;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1359 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1360 case StringConcat::CharMode: {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1361 __ store_to_memory(kit.control(), kit.array_element_address(char_array, start, T_CHAR),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1362 arg, T_CHAR, char_adr_idx);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1363 start = __ AddI(start, __ intcon(1));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1364 break;
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1365 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1366 default:
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1367 ShouldNotReachHere();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1368 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1369 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1370
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1371 // If we're not reusing an existing String allocation then allocate one here.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1372 Node* result = sc->string_alloc();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1373 if (result == NULL) {
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1374 PreserveReexecuteState preexecs(&kit);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1375 // The original jvms is for an allocation of either a String or
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1376 // StringBuffer so no stack adjustment is necessary for proper
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1377 // reexecution.
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1378 kit.jvms()->set_should_reexecute(true);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1379 result = kit.new_instance(__ makecon(TypeKlassPtr::make(C->env()->String_klass())));
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1380 }
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1381
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1382 // Intialize the string
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1383 kit.store_to_memory(kit.control(), kit.basic_plus_adr(result, java_lang_String::offset_offset_in_bytes()),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1384 __ intcon(0), T_INT, offset_field_idx);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1385 kit.store_to_memory(kit.control(), kit.basic_plus_adr(result, java_lang_String::count_offset_in_bytes()),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1386 length, T_INT, count_field_idx);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1387 kit.store_to_memory(kit.control(), kit.basic_plus_adr(result, java_lang_String::value_offset_in_bytes()),
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1388 char_array, T_OBJECT, value_field_idx);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1389
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1390 // hook up the outgoing control and result
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1391 kit.replace_call(sc->end(), result);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1392
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1393 // Unhook any hook nodes
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1394 string_sizes->disconnect_inputs(NULL);
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1395 sc->cleanup();
7c57aead6d3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
1396 }