annotate src/share/vm/gc_implementation/g1/vm_operations_g1.cpp @ 20646:4e4ebe50c8e3

8062036: ConcurrentMarkThread::slt may be invoked before ConcurrentMarkThread::makeSurrogateLockerThread causing intermittent crashes Summary: Suppress gc_alot during VM init, improve error for SLT uninitialized. Reviewed-by: jmasa, brutisso, tschatzl
author kbarrett
date Tue, 11 Nov 2014 13:39:00 -0500
parents d3fd73295885
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
1 /*
10405
f2110083203d 8005849: JEP 167: Event-Based JVM Tracing
sla
parents: 6120
diff changeset
2 * Copyright (c) 2001, 2013, Oracle and/or its affiliates. All rights reserved.
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
4 *
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
5 * This code is free software; you can redistribute it and/or modify it
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
6 * under the terms of the GNU General Public License version 2 only, as
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
7 * published by the Free Software Foundation.
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
8 *
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
9 * This code is distributed in the hope that it will be useful, but WITHOUT
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
12 * version 2 for more details (a copy is included in the LICENSE file that
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
13 * accompanied this code).
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
14 *
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
15 * You should have received a copy of the GNU General Public License version
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
16 * 2 along with this work; if not, write to the Free Software Foundation,
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
18 *
1552
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 1088
diff changeset
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 1088
diff changeset
20 * or visit www.oracle.com if you need additional information or have any
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 1088
diff changeset
21 * questions.
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
22 *
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
23 */
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
24
1972
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1656
diff changeset
25 #include "precompiled.hpp"
4022
db89aa49298f 7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents: 3914
diff changeset
26 #include "gc_implementation/g1/concurrentMarkThread.inline.hpp"
1972
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1656
diff changeset
27 #include "gc_implementation/g1/g1CollectedHeap.inline.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1656
diff changeset
28 #include "gc_implementation/g1/g1CollectorPolicy.hpp"
6007
5c86f8211d1e 7160728: Introduce an extra logging level for G1 logging
brutisso
parents: 5963
diff changeset
29 #include "gc_implementation/g1/g1Log.hpp"
1972
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1656
diff changeset
30 #include "gc_implementation/g1/vm_operations_g1.hpp"
10405
f2110083203d 8005849: JEP 167: Event-Based JVM Tracing
sla
parents: 6120
diff changeset
31 #include "gc_implementation/shared/gcTimer.hpp"
f2110083203d 8005849: JEP 167: Event-Based JVM Tracing
sla
parents: 6120
diff changeset
32 #include "gc_implementation/shared/gcTraceTime.hpp"
1972
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1656
diff changeset
33 #include "gc_implementation/shared/isGCActiveMark.hpp"
1973
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
34 #include "gc_implementation/g1/vm_operations_g1.hpp"
1972
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1656
diff changeset
35 #include "runtime/interfaceSupport.hpp"
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
36
1973
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
37 VM_G1CollectForAllocation::VM_G1CollectForAllocation(
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
38 unsigned int gc_count_before,
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
39 size_t word_size)
5963
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
40 : VM_G1OperationWithAllocRequest(gc_count_before, word_size,
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
41 GCCause::_allocation_failure) {
1973
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
42 guarantee(word_size > 0, "an allocation should always be requested");
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
43 }
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
44
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
45 void VM_G1CollectForAllocation::doit() {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
46 G1CollectedHeap* g1h = G1CollectedHeap::heap();
6062
1096fc5a52eb 7168294: G1: Some Full GCs incorrectly report GC cause as "No GC"
johnc
parents: 6007
diff changeset
47 GCCauseSetter x(g1h, _gc_cause);
20404
227a9e5e4b4a 8057536: Refactor G1 to allow context specific allocations
sjohanss
parents: 20190
diff changeset
48
227a9e5e4b4a 8057536: Refactor G1 to allow context specific allocations
sjohanss
parents: 20190
diff changeset
49 _result = g1h->satisfy_failed_allocation(_word_size, allocation_context(), &_pause_succeeded);
1973
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
50 assert(_result == NULL || _pause_succeeded,
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
51 "if we get back a result, the pause should have succeeded");
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
52 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
53
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
54 void VM_G1CollectFull::doit() {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
55 G1CollectedHeap* g1h = G1CollectedHeap::heap();
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
56 GCCauseSetter x(g1h, _gc_cause);
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
57 g1h->do_full_collection(false /* clear_all_soft_refs */);
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
58 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
59
1973
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
60 VM_G1IncCollectionPause::VM_G1IncCollectionPause(
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
61 unsigned int gc_count_before,
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
62 size_t word_size,
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
63 bool should_initiate_conc_mark,
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
64 double target_pause_time_ms,
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
65 GCCause::Cause gc_cause)
5963
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
66 : VM_G1OperationWithAllocRequest(gc_count_before, word_size, gc_cause),
1973
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
67 _should_initiate_conc_mark(should_initiate_conc_mark),
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
68 _target_pause_time_ms(target_pause_time_ms),
5963
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
69 _should_retry_gc(false),
6120
37552638d24a 7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents: 6062
diff changeset
70 _old_marking_cycles_completed_before(0) {
1973
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
71 guarantee(target_pause_time_ms > 0.0,
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
72 err_msg("target_pause_time_ms = %1.6lf should be positive",
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
73 target_pause_time_ms));
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
74 _gc_cause = gc_cause;
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
75 }
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
76
5963
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
77 bool VM_G1IncCollectionPause::doit_prologue() {
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
78 bool res = VM_GC_Operation::doit_prologue();
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
79 if (!res) {
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
80 if (_should_initiate_conc_mark) {
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
81 // The prologue can fail for a couple of reasons. The first is that another GC
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
82 // got scheduled and prevented the scheduling of the initial mark GC. The
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
83 // second is that the GC locker may be active and the heap can't be expanded.
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
84 // In both cases we want to retry the GC so that the initial mark pause is
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
85 // actually scheduled. In the second case, however, we should stall until
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
86 // until the GC locker is no longer active and then retry the initial mark GC.
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
87 _should_retry_gc = true;
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
88 }
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
89 }
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
90 return res;
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
91 }
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
92
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
93 void VM_G1IncCollectionPause::doit() {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
94 G1CollectedHeap* g1h = G1CollectedHeap::heap();
1656
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
95 assert(!_should_initiate_conc_mark ||
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
96 ((_gc_cause == GCCause::_gc_locker && GCLockerInvokesConcurrent) ||
4829
9509c20bba28 6976060: G1: humongous object allocations should initiate marking cycles when necessary
brutisso
parents: 4022
diff changeset
97 (_gc_cause == GCCause::_java_lang_system_gc && ExplicitGCInvokesConcurrent) ||
20522
d3fd73295885 8059466: Force young GC to initiate marking cycle when stat update is requested
sjohanss
parents: 20404
diff changeset
98 _gc_cause == GCCause::_g1_humongous_allocation ||
d3fd73295885 8059466: Force young GC to initiate marking cycle when stat update is requested
sjohanss
parents: 20404
diff changeset
99 _gc_cause == GCCause::_update_allocation_context_stats_inc),
d3fd73295885 8059466: Force young GC to initiate marking cycle when stat update is requested
sjohanss
parents: 20404
diff changeset
100 "only a GC locker, a System.gc(), stats update or a hum allocation induced GC should start a cycle");
1656
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
101
1973
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
102 if (_word_size > 0) {
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
103 // An allocation has been requested. So, try to do that first.
20404
227a9e5e4b4a 8057536: Refactor G1 to allow context specific allocations
sjohanss
parents: 20190
diff changeset
104 _result = g1h->attempt_allocation_at_safepoint(_word_size, allocation_context(),
1973
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
105 false /* expect_null_cur_alloc_region */);
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
106 if (_result != NULL) {
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
107 // If we can successfully allocate before we actually do the
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
108 // pause then we will consider this pause successful.
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
109 _pause_succeeded = true;
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
110 return;
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
111 }
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
112 }
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
113
1088
3fc996d4edd2 6902303: G1: ScavengeALot should cause an incremental, rather than a full, collection
ysr
parents: 844
diff changeset
114 GCCauseSetter x(g1h, _gc_cause);
1656
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
115 if (_should_initiate_conc_mark) {
6120
37552638d24a 7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents: 6062
diff changeset
116 // It's safer to read old_marking_cycles_completed() here, given
1656
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
117 // that noone else will be updating it concurrently. Since we'll
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
118 // only need it if we're initiating a marking cycle, no point in
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
119 // setting it earlier.
6120
37552638d24a 7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents: 6062
diff changeset
120 _old_marking_cycles_completed_before = g1h->old_marking_cycles_completed();
1656
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
121
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
122 // At this point we are supposed to start a concurrent cycle. We
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
123 // will do so if one is not already in progress.
3914
20213c8a3c40 7050392: G1: Introduce flag to generate a log of the G1 ergonomic decisions
tonyp
parents: 3773
diff changeset
124 bool res = g1h->g1_policy()->force_initial_mark_if_outside_cycle(_gc_cause);
3773
5130fa1b24f1 7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents: 2426
diff changeset
125
5130fa1b24f1 7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents: 2426
diff changeset
126 // The above routine returns true if we were able to force the
5130fa1b24f1 7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents: 2426
diff changeset
127 // next GC pause to be an initial mark; it returns false if a
5130fa1b24f1 7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents: 2426
diff changeset
128 // marking cycle is already in progress.
5130fa1b24f1 7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents: 2426
diff changeset
129 //
5963
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
130 // If a marking cycle is already in progress just return and skip the
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
131 // pause below - if the reason for requesting this initial mark pause
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
132 // was due to a System.gc() then the requesting thread should block in
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
133 // doit_epilogue() until the marking cycle is complete.
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
134 //
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
135 // If this initial mark pause was requested as part of a humongous
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
136 // allocation then we know that the marking cycle must just have
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
137 // been started by another thread (possibly also allocating a humongous
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
138 // object) as there was no active marking cycle when the requesting
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
139 // thread checked before calling collect() in
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
140 // attempt_allocation_humongous(). Retrying the GC, in this case,
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
141 // will cause the requesting thread to spin inside collect() until the
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
142 // just started marking cycle is complete - which may be a while. So
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
143 // we do NOT retry the GC.
3773
5130fa1b24f1 7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents: 2426
diff changeset
144 if (!res) {
5963
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
145 assert(_word_size == 0, "Concurrent Full GC/Humongous Object IM shouldn't be allocating");
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
146 if (_gc_cause != GCCause::_g1_humongous_allocation) {
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
147 _should_retry_gc = true;
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
148 }
3773
5130fa1b24f1 7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents: 2426
diff changeset
149 return;
5130fa1b24f1 7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses
johnc
parents: 2426
diff changeset
150 }
1656
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
151 }
1973
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
152
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
153 _pause_succeeded =
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
154 g1h->do_collection_pause_at_safepoint(_target_pause_time_ms);
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
155 if (_pause_succeeded && _word_size > 0) {
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
156 // An allocation had been requested.
20404
227a9e5e4b4a 8057536: Refactor G1 to allow context specific allocations
sjohanss
parents: 20190
diff changeset
157 _result = g1h->attempt_allocation_at_safepoint(_word_size, allocation_context(),
1973
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
158 true /* expect_null_cur_alloc_region */);
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
159 } else {
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
160 assert(_result == NULL, "invariant");
5963
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
161 if (!_pause_succeeded) {
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
162 // Another possible reason reason for the pause to not be successful
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
163 // is that, again, the GC locker is active (and has become active
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
164 // since the prologue was executed). In this case we should retry
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
165 // the pause after waiting for the GC locker to become inactive.
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
166 _should_retry_gc = true;
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
167 }
1973
631f79e71e90 6974966: G1: unnecessary direct-to-old allocations
tonyp
parents: 1972
diff changeset
168 }
1656
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
169 }
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
170
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
171 void VM_G1IncCollectionPause::doit_epilogue() {
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
172 VM_GC_Operation::doit_epilogue();
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
173
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
174 // If the pause was initiated by a System.gc() and
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
175 // +ExplicitGCInvokesConcurrent, we have to wait here for the cycle
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
176 // that just started (or maybe one that was already in progress) to
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
177 // finish.
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
178 if (_gc_cause == GCCause::_java_lang_system_gc &&
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
179 _should_initiate_conc_mark) {
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
180 assert(ExplicitGCInvokesConcurrent,
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
181 "the only way to be here is if ExplicitGCInvokesConcurrent is set");
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
182
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
183 G1CollectedHeap* g1h = G1CollectedHeap::heap();
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
184
6120
37552638d24a 7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents: 6062
diff changeset
185 // In the doit() method we saved g1h->old_marking_cycles_completed()
37552638d24a 7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents: 6062
diff changeset
186 // in the _old_marking_cycles_completed_before field. We have to
37552638d24a 7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents: 6062
diff changeset
187 // wait until we observe that g1h->old_marking_cycles_completed()
1656
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
188 // has increased by at least one. This can happen if a) we started
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
189 // a cycle and it completes, b) a cycle already in progress
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
190 // completes, or c) a Full GC happens.
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
191
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
192 // If the condition has already been reached, there's no point in
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
193 // actually taking the lock and doing the wait.
6120
37552638d24a 7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents: 6062
diff changeset
194 if (g1h->old_marking_cycles_completed() <=
37552638d24a 7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents: 6062
diff changeset
195 _old_marking_cycles_completed_before) {
1656
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
196 // The following is largely copied from CMS
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
197
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
198 Thread* thr = Thread::current();
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
199 assert(thr->is_Java_thread(), "invariant");
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
200 JavaThread* jt = (JavaThread*)thr;
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
201 ThreadToNativeFromVM native(jt);
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
202
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
203 MutexLockerEx x(FullGCCount_lock, Mutex::_no_safepoint_check_flag);
6120
37552638d24a 7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents: 6062
diff changeset
204 while (g1h->old_marking_cycles_completed() <=
37552638d24a 7172388: G1: _total_full_collections should not be incremented for concurrent cycles
brutisso
parents: 6062
diff changeset
205 _old_marking_cycles_completed_before) {
1656
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
206 FullGCCount_lock->wait(Mutex::_no_safepoint_check_flag);
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
207 }
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
208 }
4e5661ba9d98 6944166: G1: explicit GCs are not always handled correctly
tonyp
parents: 1552
diff changeset
209 }
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
210 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
211
4022
db89aa49298f 7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents: 3914
diff changeset
212 void VM_CGC_Operation::acquire_pending_list_lock() {
5963
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
213 assert(_needs_pll, "don't call this otherwise");
4022
db89aa49298f 7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents: 3914
diff changeset
214 // The caller may block while communicating
db89aa49298f 7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents: 3914
diff changeset
215 // with the SLT thread in order to acquire/release the PLL.
20646
4e4ebe50c8e3 8062036: ConcurrentMarkThread::slt may be invoked before ConcurrentMarkThread::makeSurrogateLockerThread causing intermittent crashes
kbarrett
parents: 20522
diff changeset
216 SurrogateLockerThread* slt = ConcurrentMarkThread::slt();
4e4ebe50c8e3 8062036: ConcurrentMarkThread::slt may be invoked before ConcurrentMarkThread::makeSurrogateLockerThread causing intermittent crashes
kbarrett
parents: 20522
diff changeset
217 if (slt != NULL) {
4e4ebe50c8e3 8062036: ConcurrentMarkThread::slt may be invoked before ConcurrentMarkThread::makeSurrogateLockerThread causing intermittent crashes
kbarrett
parents: 20522
diff changeset
218 slt->manipulatePLL(SurrogateLockerThread::acquirePLL);
4e4ebe50c8e3 8062036: ConcurrentMarkThread::slt may be invoked before ConcurrentMarkThread::makeSurrogateLockerThread causing intermittent crashes
kbarrett
parents: 20522
diff changeset
219 } else {
4e4ebe50c8e3 8062036: ConcurrentMarkThread::slt may be invoked before ConcurrentMarkThread::makeSurrogateLockerThread causing intermittent crashes
kbarrett
parents: 20522
diff changeset
220 SurrogateLockerThread::report_missing_slt();
4e4ebe50c8e3 8062036: ConcurrentMarkThread::slt may be invoked before ConcurrentMarkThread::makeSurrogateLockerThread causing intermittent crashes
kbarrett
parents: 20522
diff changeset
221 }
4022
db89aa49298f 7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents: 3914
diff changeset
222 }
db89aa49298f 7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents: 3914
diff changeset
223
db89aa49298f 7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents: 3914
diff changeset
224 void VM_CGC_Operation::release_and_notify_pending_list_lock() {
5963
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
225 assert(_needs_pll, "don't call this otherwise");
4022
db89aa49298f 7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents: 3914
diff changeset
226 // The caller may block while communicating
db89aa49298f 7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents: 3914
diff changeset
227 // with the SLT thread in order to acquire/release the PLL.
db89aa49298f 7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents: 3914
diff changeset
228 ConcurrentMarkThread::slt()->
db89aa49298f 7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents: 3914
diff changeset
229 manipulatePLL(SurrogateLockerThread::releaseAndNotifyPLL);
db89aa49298f 7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents: 3914
diff changeset
230 }
db89aa49298f 7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents: 3914
diff changeset
231
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
232 void VM_CGC_Operation::doit() {
6007
5c86f8211d1e 7160728: Introduce an extra logging level for G1 logging
brutisso
parents: 5963
diff changeset
233 gclog_or_tty->date_stamp(G1Log::fine() && PrintGCDateStamps);
5c86f8211d1e 7160728: Introduce an extra logging level for G1 logging
brutisso
parents: 5963
diff changeset
234 TraceCPUTime tcpu(G1Log::finer(), true, gclog_or_tty);
20190
0982ec23da03 8043607: Add a GC id as a log decoration similar to PrintGCTimeStamps
brutisso
parents: 12113
diff changeset
235 GCTraceTime t(_printGCMessage, G1Log::fine(), true, G1CollectedHeap::heap()->gc_timer_cm(), G1CollectedHeap::heap()->concurrent_mark()->concurrent_gc_id());
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
236 SharedHeap* sh = SharedHeap::heap();
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
237 // This could go away if CollectedHeap gave access to _gc_is_active...
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
238 if (sh != NULL) {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
239 IsGCActiveMark x;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
240 _cl->do_void();
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
241 } else {
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
242 _cl->do_void();
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
243 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
244 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
245
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
246 bool VM_CGC_Operation::doit_prologue() {
4022
db89aa49298f 7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents: 3914
diff changeset
247 // Note the relative order of the locks must match that in
db89aa49298f 7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents: 3914
diff changeset
248 // VM_GC_Operation::doit_prologue() or deadlocks can occur
5963
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
249 if (_needs_pll) {
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
250 acquire_pending_list_lock();
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
251 }
4022
db89aa49298f 7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents: 3914
diff changeset
252
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
253 Heap_lock->lock();
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
254 SharedHeap::heap()->_thread_holds_heap_lock_for_gc = true;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
255 return true;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
256 }
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
257
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
258 void VM_CGC_Operation::doit_epilogue() {
4022
db89aa49298f 7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents: 3914
diff changeset
259 // Note the relative order of the unlocks must match that in
db89aa49298f 7099824: G1: we should take the pending list lock before doing the remark pause
johnc
parents: 3914
diff changeset
260 // VM_GC_Operation::doit_epilogue()
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
261 SharedHeap::heap()->_thread_holds_heap_lock_for_gc = false;
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
262 Heap_lock->unlock();
5963
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
263 if (_needs_pll) {
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
264 release_and_notify_pending_list_lock();
64bf7c8270cb 7147724: G1: hang in SurrogateLockerThread::manipulatePLL
johnc
parents: 4829
diff changeset
265 }
342
37f87013dfd8 6711316: Open source the Garbage-First garbage collector
ysr
parents:
diff changeset
266 }