Mercurial > hg > truffle
annotate src/share/vm/gc_implementation/g1/g1CollectedHeap.inline.hpp @ 752:a2957df801a1
6833576: G1: assert illegal index, growableArray.hpp:186
Summary: The code that calculates the heap region index for an object address incorrectly used signed arithmetic.
Reviewed-by: jcoomes, ysr
| author | johnc |
|---|---|
| date | Tue, 05 May 2009 22:15:35 -0700 |
| parents | 0fbdb4381b99 |
| children | c18cbe5936b8 |
| rev | line source |
|---|---|
| 342 | 1 /* |
| 579 | 2 * Copyright 2001-2009 Sun Microsystems, Inc. All Rights Reserved. |
| 342 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
| 19 * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, | |
| 20 * CA 95054 USA or visit www.sun.com if you need additional information or | |
| 21 * have any questions. | |
| 22 * | |
| 23 */ | |
| 24 | |
| 25 // Inline functions for G1CollectedHeap | |
| 26 | |
| 27 inline HeapRegion* | |
| 28 G1CollectedHeap::heap_region_containing(const void* addr) const { | |
| 29 HeapRegion* hr = _hrs->addr_to_region(addr); | |
| 30 // hr can be null if addr in perm_gen | |
| 31 if (hr != NULL && hr->continuesHumongous()) { | |
| 32 hr = hr->humongous_start_region(); | |
| 33 } | |
| 34 return hr; | |
| 35 } | |
| 36 | |
| 37 inline HeapRegion* | |
| 38 G1CollectedHeap::heap_region_containing_raw(const void* addr) const { | |
| 526 | 39 assert(_g1_reserved.contains(addr), "invariant"); |
|
752
a2957df801a1
6833576: G1: assert illegal index, growableArray.hpp:186
johnc
parents:
579
diff
changeset
|
40 size_t index = pointer_delta(addr, _g1_reserved.start(), 1) |
|
a2957df801a1
6833576: G1: assert illegal index, growableArray.hpp:186
johnc
parents:
579
diff
changeset
|
41 >> HeapRegion::LogOfHRGrainBytes; |
|
a2957df801a1
6833576: G1: assert illegal index, growableArray.hpp:186
johnc
parents:
579
diff
changeset
|
42 |
| 526 | 43 HeapRegion* res = _hrs->at(index); |
| 44 assert(res == _hrs->addr_to_region(addr), "sanity"); | |
| 342 | 45 return res; |
| 46 } | |
| 47 | |
| 48 inline bool G1CollectedHeap::obj_in_cs(oop obj) { | |
| 49 HeapRegion* r = _hrs->addr_to_region(obj); | |
| 50 return r != NULL && r->in_collection_set(); | |
| 51 } | |
| 52 | |
| 53 inline HeapWord* G1CollectedHeap::attempt_allocation(size_t word_size, | |
| 54 bool permit_collection_pause) { | |
| 55 HeapWord* res = NULL; | |
| 56 | |
| 57 assert( SafepointSynchronize::is_at_safepoint() || | |
| 58 Heap_lock->owned_by_self(), "pre-condition of the call" ); | |
| 59 | |
| 60 if (_cur_alloc_region != NULL) { | |
| 61 | |
| 62 // If this allocation causes a region to become non empty, | |
| 63 // then we need to update our free_regions count. | |
| 64 | |
| 65 if (_cur_alloc_region->is_empty()) { | |
| 66 res = _cur_alloc_region->allocate(word_size); | |
| 67 if (res != NULL) | |
| 68 _free_regions--; | |
| 69 } else { | |
| 70 res = _cur_alloc_region->allocate(word_size); | |
| 71 } | |
| 72 } | |
| 73 if (res != NULL) { | |
| 74 if (!SafepointSynchronize::is_at_safepoint()) { | |
| 75 assert( Heap_lock->owned_by_self(), "invariant" ); | |
| 76 Heap_lock->unlock(); | |
| 77 } | |
| 78 return res; | |
| 79 } | |
| 80 // attempt_allocation_slow will also unlock the heap lock when appropriate. | |
| 81 return attempt_allocation_slow(word_size, permit_collection_pause); | |
| 82 } | |
| 83 | |
| 84 inline RefToScanQueue* G1CollectedHeap::task_queue(int i) { | |
| 85 return _task_queues->queue(i); | |
| 86 } | |
| 87 | |
| 88 | |
| 89 inline bool G1CollectedHeap::isMarkedPrev(oop obj) const { | |
| 90 return _cm->prevMarkBitMap()->isMarked((HeapWord *)obj); | |
| 91 } | |
| 92 | |
| 93 inline bool G1CollectedHeap::isMarkedNext(oop obj) const { | |
| 94 return _cm->nextMarkBitMap()->isMarked((HeapWord *)obj); | |
| 95 } |