Mercurial > hg > truffle
annotate src/share/vm/opto/locknode.cpp @ 4790:b0ff910edfc9
7128355: assert(!nocreate) failed: Cannot build a phi for a block already parsed
Summary: Do not common BoxLock nodes and avoid creating phis of boxes.
Reviewed-by: never
author | kvn |
---|---|
date | Thu, 12 Jan 2012 14:45:04 -0800 |
parents | 35acf8f0a2e4 |
children | 89d0a5d40008 |
rev | line source |
---|---|
0 | 1 /* |
1972 | 2 * Copyright (c) 1999, 2010, Oracle and/or its affiliates. All rights reserved. |
0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 * | |
5 * This code is free software; you can redistribute it and/or modify it | |
6 * under the terms of the GNU General Public License version 2 only, as | |
7 * published by the Free Software Foundation. | |
8 * | |
9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
12 * version 2 for more details (a copy is included in the LICENSE file that | |
13 * accompanied this code). | |
14 * | |
15 * You should have received a copy of the GNU General Public License version | |
16 * 2 along with this work; if not, write to the Free Software Foundation, | |
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
18 * | |
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
605
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
605
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
605
diff
changeset
|
21 * questions. |
0 | 22 * |
23 */ | |
24 | |
1972 | 25 #include "precompiled.hpp" |
26 #include "opto/locknode.hpp" | |
27 #include "opto/parse.hpp" | |
28 #include "opto/rootnode.hpp" | |
29 #include "opto/runtime.hpp" | |
0 | 30 |
31 //============================================================================= | |
32 const RegMask &BoxLockNode::in_RegMask(uint i) const { | |
33 return _inmask; | |
34 } | |
35 | |
36 const RegMask &BoxLockNode::out_RegMask() const { | |
37 return *Matcher::idealreg2regmask[Op_RegP]; | |
38 } | |
39 | |
40 uint BoxLockNode::size_of() const { return sizeof(*this); } | |
41 | |
66
6dbf1a175d6b
6672848: (Escape Analysis) improve lock elimination with EA
kvn
parents:
0
diff
changeset
|
42 BoxLockNode::BoxLockNode( int slot ) : Node( Compile::current()->root() ), |
6dbf1a175d6b
6672848: (Escape Analysis) improve lock elimination with EA
kvn
parents:
0
diff
changeset
|
43 _slot(slot), _is_eliminated(false) { |
0 | 44 init_class_id(Class_BoxLock); |
45 init_flags(Flag_rematerialize); | |
46 OptoReg::Name reg = OptoReg::stack2reg(_slot); | |
47 _inmask.Insert(reg); | |
48 } | |
49 | |
460
424f9bfe6b96
6775880: EA +DeoptimizeALot: assert(mon_info->owner()->is_locked(),"object must be locked now")
kvn
parents:
196
diff
changeset
|
50 //-----------------------------hash-------------------------------------------- |
424f9bfe6b96
6775880: EA +DeoptimizeALot: assert(mon_info->owner()->is_locked(),"object must be locked now")
kvn
parents:
196
diff
changeset
|
51 uint BoxLockNode::hash() const { |
4777 | 52 if (EliminateNestedLocks) |
53 return NO_HASH; // Each locked region has own BoxLock node | |
460
424f9bfe6b96
6775880: EA +DeoptimizeALot: assert(mon_info->owner()->is_locked(),"object must be locked now")
kvn
parents:
196
diff
changeset
|
54 return Node::hash() + _slot + (_is_eliminated ? Compile::current()->fixed_slots() : 0); |
424f9bfe6b96
6775880: EA +DeoptimizeALot: assert(mon_info->owner()->is_locked(),"object must be locked now")
kvn
parents:
196
diff
changeset
|
55 } |
424f9bfe6b96
6775880: EA +DeoptimizeALot: assert(mon_info->owner()->is_locked(),"object must be locked now")
kvn
parents:
196
diff
changeset
|
56 |
0 | 57 //------------------------------cmp-------------------------------------------- |
58 uint BoxLockNode::cmp( const Node &n ) const { | |
4777 | 59 if (EliminateNestedLocks) |
60 return (&n == this); // Always fail except on self | |
0 | 61 const BoxLockNode &bn = (const BoxLockNode &)n; |
460
424f9bfe6b96
6775880: EA +DeoptimizeALot: assert(mon_info->owner()->is_locked(),"object must be locked now")
kvn
parents:
196
diff
changeset
|
62 return bn._slot == _slot && bn._is_eliminated == _is_eliminated; |
0 | 63 } |
64 | |
4777 | 65 BoxLockNode* BoxLockNode::box_node(Node* box) { |
4790
b0ff910edfc9
7128355: assert(!nocreate) failed: Cannot build a phi for a block already parsed
kvn
parents:
4778
diff
changeset
|
66 // Chase down the BoxNode after RA which may spill box nodes. |
4777 | 67 while (!box->is_BoxLock()) { |
0 | 68 // if (box_node->is_SpillCopy()) { |
69 // Node *m = box_node->in(1); | |
70 // if (m->is_Mach() && m->as_Mach()->ideal_Opcode() == Op_StoreP) { | |
71 // box_node = m->in(m->as_Mach()->operand_index(2)); | |
72 // continue; | |
73 // } | |
74 // } | |
4777 | 75 assert(box->is_SpillCopy() || box->is_Phi(), "Bad spill of Lock."); |
76 // Only BoxLock nodes with the same stack slot are merged. | |
77 // So it is enough to trace one path to find the slot value. | |
78 box = box->in(1); | |
0 | 79 } |
4777 | 80 return box->as_BoxLock(); |
81 } | |
82 | |
83 OptoReg::Name BoxLockNode::reg(Node* box) { | |
84 return box_node(box)->in_RegMask(0).find_first_elem(); | |
85 } | |
86 | |
87 // Is BoxLock node used for one simple lock region (same box and obj)? | |
88 bool BoxLockNode::is_simple_lock_region(LockNode** unique_lock, Node* obj) { | |
89 LockNode* lock = NULL; | |
90 bool has_one_lock = false; | |
91 for (uint i = 0; i < this->outcnt(); i++) { | |
92 Node* n = this->raw_out(i); | |
4790
b0ff910edfc9
7128355: assert(!nocreate) failed: Cannot build a phi for a block already parsed
kvn
parents:
4778
diff
changeset
|
93 assert(!n->is_Phi(), "should not merge BoxLock nodes"); |
4777 | 94 if (n->is_AbstractLock()) { |
95 AbstractLockNode* alock = n->as_AbstractLock(); | |
96 // Check lock's box since box could be referenced by Lock's debug info. | |
97 if (alock->box_node() == this) { | |
4778 | 98 if (alock->obj_node()->eqv_uncast(obj)) { |
4777 | 99 if ((unique_lock != NULL) && alock->is_Lock()) { |
100 if (lock == NULL) { | |
101 lock = alock->as_Lock(); | |
102 has_one_lock = true; | |
103 } else if (lock != alock->as_Lock()) { | |
104 has_one_lock = false; | |
105 } | |
106 } | |
107 } else { | |
108 return false; // Different objects | |
109 } | |
110 } | |
111 } | |
112 } | |
113 #ifdef ASSERT | |
114 // Verify that FastLock and Safepoint reference only this lock region. | |
115 for (uint i = 0; i < this->outcnt(); i++) { | |
116 Node* n = this->raw_out(i); | |
117 if (n->is_FastLock()) { | |
118 FastLockNode* flock = n->as_FastLock(); | |
4778 | 119 assert((flock->box_node() == this) && flock->obj_node()->eqv_uncast(obj),""); |
4777 | 120 } |
121 if (n->is_SafePoint() && n->as_SafePoint()->jvms()) { | |
122 SafePointNode* sfn = n->as_SafePoint(); | |
123 JVMState* youngest_jvms = sfn->jvms(); | |
124 int max_depth = youngest_jvms->depth(); | |
125 for (int depth = 1; depth <= max_depth; depth++) { | |
126 JVMState* jvms = youngest_jvms->of_depth(depth); | |
127 int num_mon = jvms->nof_monitors(); | |
128 // Loop over monitors | |
129 for (int idx = 0; idx < num_mon; idx++) { | |
130 Node* obj_node = sfn->monitor_obj(jvms, idx); | |
131 Node* box_node = sfn->monitor_box(jvms, idx); | |
132 if (box_node == this) { | |
4790
b0ff910edfc9
7128355: assert(!nocreate) failed: Cannot build a phi for a block already parsed
kvn
parents:
4778
diff
changeset
|
133 if (!obj_node->eqv_uncast(obj)) { |
b0ff910edfc9
7128355: assert(!nocreate) failed: Cannot build a phi for a block already parsed
kvn
parents:
4778
diff
changeset
|
134 tty->cr(); |
b0ff910edfc9
7128355: assert(!nocreate) failed: Cannot build a phi for a block already parsed
kvn
parents:
4778
diff
changeset
|
135 tty->print_cr("=====monitor info has different obj====="); |
b0ff910edfc9
7128355: assert(!nocreate) failed: Cannot build a phi for a block already parsed
kvn
parents:
4778
diff
changeset
|
136 tty->print_cr("obj:"); |
b0ff910edfc9
7128355: assert(!nocreate) failed: Cannot build a phi for a block already parsed
kvn
parents:
4778
diff
changeset
|
137 obj->dump(1); tty->cr(); |
b0ff910edfc9
7128355: assert(!nocreate) failed: Cannot build a phi for a block already parsed
kvn
parents:
4778
diff
changeset
|
138 tty->print_cr("obj uncast:"); |
b0ff910edfc9
7128355: assert(!nocreate) failed: Cannot build a phi for a block already parsed
kvn
parents:
4778
diff
changeset
|
139 obj->uncast()->dump(); tty->cr(); |
b0ff910edfc9
7128355: assert(!nocreate) failed: Cannot build a phi for a block already parsed
kvn
parents:
4778
diff
changeset
|
140 tty->print_cr("obj_node:"); |
b0ff910edfc9
7128355: assert(!nocreate) failed: Cannot build a phi for a block already parsed
kvn
parents:
4778
diff
changeset
|
141 obj_node->dump(1); tty->cr(); |
b0ff910edfc9
7128355: assert(!nocreate) failed: Cannot build a phi for a block already parsed
kvn
parents:
4778
diff
changeset
|
142 tty->print_cr("obj_node uncast:"); |
b0ff910edfc9
7128355: assert(!nocreate) failed: Cannot build a phi for a block already parsed
kvn
parents:
4778
diff
changeset
|
143 obj_node->uncast()->dump(); |
b0ff910edfc9
7128355: assert(!nocreate) failed: Cannot build a phi for a block already parsed
kvn
parents:
4778
diff
changeset
|
144 } |
b0ff910edfc9
7128355: assert(!nocreate) failed: Cannot build a phi for a block already parsed
kvn
parents:
4778
diff
changeset
|
145 assert(obj_node->eqv_uncast(obj),"monitor info has different obj"); |
4777 | 146 } |
147 } | |
148 } | |
149 } | |
150 } | |
151 #endif | |
152 if (unique_lock != NULL && has_one_lock) { | |
153 *unique_lock = lock; | |
154 } | |
155 return true; | |
0 | 156 } |
157 | |
158 //============================================================================= | |
159 //-----------------------------hash-------------------------------------------- | |
160 uint FastLockNode::hash() const { return NO_HASH; } | |
161 | |
162 //------------------------------cmp-------------------------------------------- | |
163 uint FastLockNode::cmp( const Node &n ) const { | |
164 return (&n == this); // Always fail except on self | |
165 } | |
166 | |
167 //============================================================================= | |
168 //-----------------------------hash-------------------------------------------- | |
169 uint FastUnlockNode::hash() const { return NO_HASH; } | |
170 | |
171 //------------------------------cmp-------------------------------------------- | |
172 uint FastUnlockNode::cmp( const Node &n ) const { | |
173 return (&n == this); // Always fail except on self | |
174 } | |
175 | |
176 // | |
177 // Create a counter which counts the number of times this lock is acquired | |
178 // | |
179 void FastLockNode::create_lock_counter(JVMState* state) { | |
180 BiasedLockingNamedCounter* blnc = (BiasedLockingNamedCounter*) | |
181 OptoRuntime::new_named_counter(state, NamedCounter::BiasedLockingCounter); | |
182 _counters = blnc->counters(); | |
183 } | |
184 | |
185 //============================================================================= | |
186 //------------------------------do_monitor_enter------------------------------- | |
187 void Parse::do_monitor_enter() { | |
188 kill_dead_locals(); | |
189 | |
190 // Null check; get casted pointer. | |
191 Node *obj = do_null_check(peek(), T_OBJECT); | |
192 // Check for locking null object | |
193 if (stopped()) return; | |
194 | |
195 // the monitor object is not part of debug info expression stack | |
196 pop(); | |
197 | |
198 // Insert a FastLockNode which takes as arguments the current thread pointer, | |
199 // the obj pointer & the address of the stack slot pair used for the lock. | |
200 shared_lock(obj); | |
201 } | |
202 | |
203 //------------------------------do_monitor_exit-------------------------------- | |
204 void Parse::do_monitor_exit() { | |
205 kill_dead_locals(); | |
206 | |
207 pop(); // Pop oop to unlock | |
605 | 208 // Because monitors are guaranteed paired (else we bail out), we know |
0 | 209 // the matching Lock for this Unlock. Hence we know there is no need |
210 // for a null check on Unlock. | |
211 shared_unlock(map()->peek_monitor_box(), map()->peek_monitor_obj()); | |
212 } |