Mercurial > hg > truffle

annotate src/share/vm/gc_implementation/g1/g1OopClosures.cpp @ 20225:cd43876f692e

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
8040977: G1 crashes when run with -XX:-G1DeferredRSUpdate Summary: When G1 is run with -XX:-G1DeferredRSUpdate, the VM crashes because of wrong initialization order of member variables. The change makes the initalization explicit, not relying on initialization order any more. Reviewed-by: brutisso, mgerdin
author tschatzl
date Mon, 21 Jul 2014 09:41:06 +0200
parents b0c374311c4e
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
17687
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
1 /*
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
2 * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved.
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
4 *
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
5 * This code is free software; you can redistribute it and/or modify it
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
6 * under the terms of the GNU General Public License version 2 only, as
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
7 * published by the Free Software Foundation.
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
8 *
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
9 * This code is distributed in the hope that it will be useful, but WITHOUT
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
12 * version 2 for more details (a copy is included in the LICENSE file that
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
13 * accompanied this code).
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
14 *
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
15 * You should have received a copy of the GNU General Public License version
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
16 * 2 along with this work; if not, write to the Free Software Foundation,
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
18 *
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
20 * or visit www.oracle.com if you need additional information or have any
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
21 * questions.
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
22 *
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
23 */
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
24
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
25 #include "precompiled.hpp"
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
26 #include "gc_implementation/g1/g1CollectedHeap.inline.hpp"
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
27 #include "gc_implementation/g1/g1OopClosures.inline.hpp"
20225
cd43876f692e 8040977: G1 crashes when run with -XX:-G1DeferredRSUpdate
tschatzl
parents: 20223
diff changeset
28 #include "gc_implementation/g1/g1ParScanThreadState.hpp"
17687
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
29
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
30 G1ParCopyHelper::G1ParCopyHelper(G1CollectedHeap* g1, G1ParScanThreadState* par_scan_state) :
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
31 G1ParClosureSuper(g1, par_scan_state), _scanned_klass(NULL),
86b64209f715 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work
tschatzl
parents:
diff changeset
32 _cm(_g1->concurrent_mark()) {}
20223
b0c374311c4e 8035400: Move G1ParScanThreadState into its own files
tschatzl
parents: 17687
diff changeset
33
20225
cd43876f692e 8040977: G1 crashes when run with -XX:-G1DeferredRSUpdate
tschatzl
parents: 20223
diff changeset
34 G1ParClosureSuper::G1ParClosureSuper(G1CollectedHeap* g1) :
cd43876f692e 8040977: G1 crashes when run with -XX:-G1DeferredRSUpdate
tschatzl
parents: 20223
diff changeset
35 _g1(g1), _par_scan_state(NULL), _worker_id(UINT_MAX) { }
cd43876f692e 8040977: G1 crashes when run with -XX:-G1DeferredRSUpdate
tschatzl
parents: 20223
diff changeset
36
20223
b0c374311c4e 8035400: Move G1ParScanThreadState into its own files
tschatzl
parents: 17687
diff changeset
37 G1ParClosureSuper::G1ParClosureSuper(G1CollectedHeap* g1, G1ParScanThreadState* par_scan_state) :
20225
cd43876f692e 8040977: G1 crashes when run with -XX:-G1DeferredRSUpdate
tschatzl
parents: 20223
diff changeset
38 _g1(g1), _par_scan_state(NULL),
cd43876f692e 8040977: G1 crashes when run with -XX:-G1DeferredRSUpdate
tschatzl
parents: 20223
diff changeset
39 _worker_id(UINT_MAX) {
cd43876f692e 8040977: G1 crashes when run with -XX:-G1DeferredRSUpdate
tschatzl
parents: 20223
diff changeset
40 set_par_scan_thread_state(par_scan_state);
cd43876f692e 8040977: G1 crashes when run with -XX:-G1DeferredRSUpdate
tschatzl
parents: 20223
diff changeset
41 }
cd43876f692e 8040977: G1 crashes when run with -XX:-G1DeferredRSUpdate
tschatzl
parents: 20223
diff changeset
42
cd43876f692e 8040977: G1 crashes when run with -XX:-G1DeferredRSUpdate
tschatzl
parents: 20223
diff changeset
43 void G1ParClosureSuper::set_par_scan_thread_state(G1ParScanThreadState* par_scan_state) {
cd43876f692e 8040977: G1 crashes when run with -XX:-G1DeferredRSUpdate
tschatzl
parents: 20223
diff changeset
44 assert(_par_scan_state == NULL, "_par_scan_state must only be set once");
cd43876f692e 8040977: G1 crashes when run with -XX:-G1DeferredRSUpdate
tschatzl
parents: 20223
diff changeset
45 assert(par_scan_state != NULL, "Must set par_scan_state to non-NULL.");
cd43876f692e 8040977: G1 crashes when run with -XX:-G1DeferredRSUpdate
tschatzl
parents: 20223
diff changeset
46
cd43876f692e 8040977: G1 crashes when run with -XX:-G1DeferredRSUpdate
tschatzl
parents: 20223
diff changeset
47 _par_scan_state = par_scan_state;
cd43876f692e 8040977: G1 crashes when run with -XX:-G1DeferredRSUpdate
tschatzl
parents: 20223
diff changeset
48 _worker_id = par_scan_state->queue_num();
cd43876f692e 8040977: G1 crashes when run with -XX:-G1DeferredRSUpdate
tschatzl
parents: 20223
diff changeset
49
cd43876f692e 8040977: G1 crashes when run with -XX:-G1DeferredRSUpdate
tschatzl
parents: 20223
diff changeset
50 assert(_worker_id < MAX2((uint)ParallelGCThreads, 1u),
cd43876f692e 8040977: G1 crashes when run with -XX:-G1DeferredRSUpdate
tschatzl
parents: 20223
diff changeset
51 err_msg("The given worker id %u must be less than the number of threads %u", _worker_id, MAX2((uint)ParallelGCThreads, 1u)));
cd43876f692e 8040977: G1 crashes when run with -XX:-G1DeferredRSUpdate
tschatzl
parents: 20223
diff changeset
52 }