annotate src/share/vm/classfile/stackMapTable.hpp @ 20242:d14a18794c90

8051012: Regression in verifier for <init> method call from inside of a branch Summary: Fix stackmap matching for branches. Reviewed-by: coleenp, lfoltan, acorn
author hseigel
date Sat, 02 Aug 2014 16:28:59 -0400
parents da91efe96a93
children c77d5db18942
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1 /*
6605
4ee06e614636 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 2426
diff changeset
2 * Copyright (c) 2003, 2012, Oracle and/or its affiliates. All rights reserved.
0
a61af66fc99e Initial load
duke
parents:
diff changeset
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
a61af66fc99e Initial load
duke
parents:
diff changeset
4 *
a61af66fc99e Initial load
duke
parents:
diff changeset
5 * This code is free software; you can redistribute it and/or modify it
a61af66fc99e Initial load
duke
parents:
diff changeset
6 * under the terms of the GNU General Public License version 2 only, as
a61af66fc99e Initial load
duke
parents:
diff changeset
7 * published by the Free Software Foundation.
a61af66fc99e Initial load
duke
parents:
diff changeset
8 *
a61af66fc99e Initial load
duke
parents:
diff changeset
9 * This code is distributed in the hope that it will be useful, but WITHOUT
a61af66fc99e Initial load
duke
parents:
diff changeset
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
a61af66fc99e Initial load
duke
parents:
diff changeset
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
a61af66fc99e Initial load
duke
parents:
diff changeset
12 * version 2 for more details (a copy is included in the LICENSE file that
a61af66fc99e Initial load
duke
parents:
diff changeset
13 * accompanied this code).
a61af66fc99e Initial load
duke
parents:
diff changeset
14 *
a61af66fc99e Initial load
duke
parents:
diff changeset
15 * You should have received a copy of the GNU General Public License version
a61af66fc99e Initial load
duke
parents:
diff changeset
16 * 2 along with this work; if not, write to the Free Software Foundation,
a61af66fc99e Initial load
duke
parents:
diff changeset
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
a61af66fc99e Initial load
duke
parents:
diff changeset
18 *
1552
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 0
diff changeset
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 0
diff changeset
20 * or visit www.oracle.com if you need additional information or have any
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 0
diff changeset
21 * questions.
0
a61af66fc99e Initial load
duke
parents:
diff changeset
22 *
a61af66fc99e Initial load
duke
parents:
diff changeset
23 */
a61af66fc99e Initial load
duke
parents:
diff changeset
24
1972
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
25 #ifndef SHARE_VM_CLASSFILE_STACKMAPTABLE_HPP
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
26 #define SHARE_VM_CLASSFILE_STACKMAPTABLE_HPP
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
27
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
28 #include "classfile/stackMapFrame.hpp"
6605
4ee06e614636 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 2426
diff changeset
29 #include "classfile/verifier.hpp"
1972
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
30 #include "memory/allocation.hpp"
6725
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 6605
diff changeset
31 #include "oops/constantPool.hpp"
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 6605
diff changeset
32 #include "oops/method.hpp"
1972
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
33 #include "utilities/globalDefinitions.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
34 #ifdef TARGET_ARCH_x86
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
35 # include "bytes_x86.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
36 #endif
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
37 #ifdef TARGET_ARCH_sparc
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
38 # include "bytes_sparc.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
39 #endif
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
40 #ifdef TARGET_ARCH_zero
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
41 # include "bytes_zero.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
42 #endif
2192
b92c45f2bc75 7016023: Enable building ARM and PPC from src/closed repository
bobv
parents: 1972
diff changeset
43 #ifdef TARGET_ARCH_arm
b92c45f2bc75 7016023: Enable building ARM and PPC from src/closed repository
bobv
parents: 1972
diff changeset
44 # include "bytes_arm.hpp"
b92c45f2bc75 7016023: Enable building ARM and PPC from src/closed repository
bobv
parents: 1972
diff changeset
45 #endif
b92c45f2bc75 7016023: Enable building ARM and PPC from src/closed repository
bobv
parents: 1972
diff changeset
46 #ifdef TARGET_ARCH_ppc
b92c45f2bc75 7016023: Enable building ARM and PPC from src/closed repository
bobv
parents: 1972
diff changeset
47 # include "bytes_ppc.hpp"
b92c45f2bc75 7016023: Enable building ARM and PPC from src/closed repository
bobv
parents: 1972
diff changeset
48 #endif
1972
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
49
0
a61af66fc99e Initial load
duke
parents:
diff changeset
50 class StackMapReader;
a61af66fc99e Initial load
duke
parents:
diff changeset
51
a61af66fc99e Initial load
duke
parents:
diff changeset
52 // StackMapTable class is the StackMap table used by type checker
a61af66fc99e Initial load
duke
parents:
diff changeset
53 class StackMapTable : public StackObj {
a61af66fc99e Initial load
duke
parents:
diff changeset
54 private:
a61af66fc99e Initial load
duke
parents:
diff changeset
55 // Logically, the _frame_count (as well as many fields in the StackFrame)
a61af66fc99e Initial load
duke
parents:
diff changeset
56 // should be a u2, but if we defined the variable as that type it will
a61af66fc99e Initial load
duke
parents:
diff changeset
57 // be difficult to detect/recover from overflow or underflow conditions.
a61af66fc99e Initial load
duke
parents:
diff changeset
58 // Widening the type and making it signed will help detect these.
a61af66fc99e Initial load
duke
parents:
diff changeset
59 int32_t _code_length;
a61af66fc99e Initial load
duke
parents:
diff changeset
60 int32_t _frame_count; // Stackmap frame count
a61af66fc99e Initial load
duke
parents:
diff changeset
61 StackMapFrame** _frame_array;
a61af66fc99e Initial load
duke
parents:
diff changeset
62
a61af66fc99e Initial load
duke
parents:
diff changeset
63 public:
a61af66fc99e Initial load
duke
parents:
diff changeset
64 StackMapTable(StackMapReader* reader, StackMapFrame* init_frame,
a61af66fc99e Initial load
duke
parents:
diff changeset
65 u2 max_locals, u2 max_stack,
a61af66fc99e Initial load
duke
parents:
diff changeset
66 char* code_data, int code_len, TRAPS);
a61af66fc99e Initial load
duke
parents:
diff changeset
67
a61af66fc99e Initial load
duke
parents:
diff changeset
68 inline int32_t get_frame_count() const { return _frame_count; }
a61af66fc99e Initial load
duke
parents:
diff changeset
69 inline int get_offset(int index) const {
a61af66fc99e Initial load
duke
parents:
diff changeset
70 return _frame_array[index]->offset();
a61af66fc99e Initial load
duke
parents:
diff changeset
71 }
a61af66fc99e Initial load
duke
parents:
diff changeset
72
a61af66fc99e Initial load
duke
parents:
diff changeset
73 // Match and/or update current_frame to the frame in stackmap table with
a61af66fc99e Initial load
duke
parents:
diff changeset
74 // specified offset. Return true if the two frames match.
a61af66fc99e Initial load
duke
parents:
diff changeset
75 bool match_stackmap(
a61af66fc99e Initial load
duke
parents:
diff changeset
76 StackMapFrame* current_frame, int32_t offset,
20242
d14a18794c90 8051012: Regression in verifier for <init> method call from inside of a branch
hseigel
parents: 6725
diff changeset
77 bool match, bool update, bool handler, ErrorContext* ctx, TRAPS) const;
0
a61af66fc99e Initial load
duke
parents:
diff changeset
78 // Match and/or update current_frame to the frame in stackmap table with
a61af66fc99e Initial load
duke
parents:
diff changeset
79 // specified offset and frame index. Return true if the two frames match.
a61af66fc99e Initial load
duke
parents:
diff changeset
80 bool match_stackmap(
a61af66fc99e Initial load
duke
parents:
diff changeset
81 StackMapFrame* current_frame, int32_t offset, int32_t frame_index,
20242
d14a18794c90 8051012: Regression in verifier for <init> method call from inside of a branch
hseigel
parents: 6725
diff changeset
82 bool match, bool update, bool handler, ErrorContext* ctx, TRAPS) const;
0
a61af66fc99e Initial load
duke
parents:
diff changeset
83
a61af66fc99e Initial load
duke
parents:
diff changeset
84 // Check jump instructions. Make sure there are no uninitialized
a61af66fc99e Initial load
duke
parents:
diff changeset
85 // instances on backward branch.
a61af66fc99e Initial load
duke
parents:
diff changeset
86 void check_jump_target(StackMapFrame* frame, int32_t target, TRAPS) const;
a61af66fc99e Initial load
duke
parents:
diff changeset
87
a61af66fc99e Initial load
duke
parents:
diff changeset
88 // The following methods are only used inside this class.
a61af66fc99e Initial load
duke
parents:
diff changeset
89
a61af66fc99e Initial load
duke
parents:
diff changeset
90 // Returns the frame array index where the frame with offset is stored.
a61af66fc99e Initial load
duke
parents:
diff changeset
91 int get_index_from_offset(int32_t offset) const;
a61af66fc99e Initial load
duke
parents:
diff changeset
92
a61af66fc99e Initial load
duke
parents:
diff changeset
93 // Make sure that there's no uninitialized object exist on backward branch.
a61af66fc99e Initial load
duke
parents:
diff changeset
94 void check_new_object(
a61af66fc99e Initial load
duke
parents:
diff changeset
95 const StackMapFrame* frame, int32_t target, TRAPS) const;
a61af66fc99e Initial load
duke
parents:
diff changeset
96
6605
4ee06e614636 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 2426
diff changeset
97 void print_on(outputStream* str) const;
0
a61af66fc99e Initial load
duke
parents:
diff changeset
98 };
a61af66fc99e Initial load
duke
parents:
diff changeset
99
a61af66fc99e Initial load
duke
parents:
diff changeset
100 class StackMapStream : StackObj {
a61af66fc99e Initial load
duke
parents:
diff changeset
101 private:
6725
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 6605
diff changeset
102 Array<u1>* _data;
0
a61af66fc99e Initial load
duke
parents:
diff changeset
103 int _index;
a61af66fc99e Initial load
duke
parents:
diff changeset
104 public:
6725
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 6605
diff changeset
105 StackMapStream(Array<u1>* ah)
0
a61af66fc99e Initial load
duke
parents:
diff changeset
106 : _data(ah), _index(0) {
a61af66fc99e Initial load
duke
parents:
diff changeset
107 }
a61af66fc99e Initial load
duke
parents:
diff changeset
108 u1 get_u1(TRAPS) {
a61af66fc99e Initial load
duke
parents:
diff changeset
109 if (_data == NULL || _index >= _data->length()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
110 stackmap_format_error("access beyond the end of attribute", CHECK_0);
a61af66fc99e Initial load
duke
parents:
diff changeset
111 }
6725
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 6605
diff changeset
112 return _data->at(_index++);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
113 }
a61af66fc99e Initial load
duke
parents:
diff changeset
114 u2 get_u2(TRAPS) {
a61af66fc99e Initial load
duke
parents:
diff changeset
115 if (_data == NULL || _index >= _data->length() - 1) {
a61af66fc99e Initial load
duke
parents:
diff changeset
116 stackmap_format_error("access beyond the end of attribute", CHECK_0);
a61af66fc99e Initial load
duke
parents:
diff changeset
117 }
6725
da91efe96a93 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 6605
diff changeset
118 u2 res = Bytes::get_Java_u2(_data->adr_at(_index));
0
a61af66fc99e Initial load
duke
parents:
diff changeset
119 _index += 2;
a61af66fc99e Initial load
duke
parents:
diff changeset
120 return res;
a61af66fc99e Initial load
duke
parents:
diff changeset
121 }
a61af66fc99e Initial load
duke
parents:
diff changeset
122 bool at_end() {
a61af66fc99e Initial load
duke
parents:
diff changeset
123 return (_data == NULL) || (_index == _data->length());
a61af66fc99e Initial load
duke
parents:
diff changeset
124 }
a61af66fc99e Initial load
duke
parents:
diff changeset
125 static void stackmap_format_error(const char* msg, TRAPS);
a61af66fc99e Initial load
duke
parents:
diff changeset
126 };
a61af66fc99e Initial load
duke
parents:
diff changeset
127
a61af66fc99e Initial load
duke
parents:
diff changeset
128 class StackMapReader : StackObj {
a61af66fc99e Initial load
duke
parents:
diff changeset
129 private:
a61af66fc99e Initial load
duke
parents:
diff changeset
130 // information about the class and method
a61af66fc99e Initial load
duke
parents:
diff changeset
131 constantPoolHandle _cp;
a61af66fc99e Initial load
duke
parents:
diff changeset
132 ClassVerifier* _verifier;
a61af66fc99e Initial load
duke
parents:
diff changeset
133 StackMapStream* _stream;
a61af66fc99e Initial load
duke
parents:
diff changeset
134 char* _code_data;
a61af66fc99e Initial load
duke
parents:
diff changeset
135 int32_t _code_length;
a61af66fc99e Initial load
duke
parents:
diff changeset
136
a61af66fc99e Initial load
duke
parents:
diff changeset
137 // information get from the attribute
a61af66fc99e Initial load
duke
parents:
diff changeset
138 int32_t _frame_count; // frame count
a61af66fc99e Initial load
duke
parents:
diff changeset
139
a61af66fc99e Initial load
duke
parents:
diff changeset
140 int32_t chop(VerificationType* locals, int32_t length, int32_t chops);
a61af66fc99e Initial load
duke
parents:
diff changeset
141 VerificationType parse_verification_type(u1* flags, TRAPS);
a61af66fc99e Initial load
duke
parents:
diff changeset
142 void check_verification_type_array_size(
a61af66fc99e Initial load
duke
parents:
diff changeset
143 int32_t size, int32_t max_size, TRAPS) {
a61af66fc99e Initial load
duke
parents:
diff changeset
144 if (size < 0 || size > max_size) {
a61af66fc99e Initial load
duke
parents:
diff changeset
145 // Since this error could be caused someone rewriting the method
a61af66fc99e Initial load
duke
parents:
diff changeset
146 // but not knowing to update the stackmap data, we call the the
a61af66fc99e Initial load
duke
parents:
diff changeset
147 // verifier's error method, which may not throw an exception and
a61af66fc99e Initial load
duke
parents:
diff changeset
148 // failover to the old verifier instead.
a61af66fc99e Initial load
duke
parents:
diff changeset
149 _verifier->class_format_error(
a61af66fc99e Initial load
duke
parents:
diff changeset
150 "StackMapTable format error: bad type array size");
a61af66fc99e Initial load
duke
parents:
diff changeset
151 }
a61af66fc99e Initial load
duke
parents:
diff changeset
152 }
a61af66fc99e Initial load
duke
parents:
diff changeset
153
a61af66fc99e Initial load
duke
parents:
diff changeset
154 enum {
a61af66fc99e Initial load
duke
parents:
diff changeset
155 SAME_LOCALS_1_STACK_ITEM_EXTENDED = 247,
a61af66fc99e Initial load
duke
parents:
diff changeset
156 SAME_EXTENDED = 251,
a61af66fc99e Initial load
duke
parents:
diff changeset
157 FULL = 255
a61af66fc99e Initial load
duke
parents:
diff changeset
158 };
a61af66fc99e Initial load
duke
parents:
diff changeset
159
a61af66fc99e Initial load
duke
parents:
diff changeset
160 public:
a61af66fc99e Initial load
duke
parents:
diff changeset
161 // Constructor
a61af66fc99e Initial load
duke
parents:
diff changeset
162 StackMapReader(ClassVerifier* v, StackMapStream* stream, char* code_data,
a61af66fc99e Initial load
duke
parents:
diff changeset
163 int32_t code_len, TRAPS) :
a61af66fc99e Initial load
duke
parents:
diff changeset
164 _verifier(v), _stream(stream),
a61af66fc99e Initial load
duke
parents:
diff changeset
165 _code_data(code_data), _code_length(code_len) {
a61af66fc99e Initial load
duke
parents:
diff changeset
166 methodHandle m = v->method();
a61af66fc99e Initial load
duke
parents:
diff changeset
167 if (m->has_stackmap_table()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
168 _cp = constantPoolHandle(THREAD, m->constants());
a61af66fc99e Initial load
duke
parents:
diff changeset
169 _frame_count = _stream->get_u2(CHECK);
a61af66fc99e Initial load
duke
parents:
diff changeset
170 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
171 // There's no stackmap table present. Frame count and size are 0.
a61af66fc99e Initial load
duke
parents:
diff changeset
172 _frame_count = 0;
a61af66fc99e Initial load
duke
parents:
diff changeset
173 }
a61af66fc99e Initial load
duke
parents:
diff changeset
174 }
a61af66fc99e Initial load
duke
parents:
diff changeset
175
a61af66fc99e Initial load
duke
parents:
diff changeset
176 inline int32_t get_frame_count() const { return _frame_count; }
a61af66fc99e Initial load
duke
parents:
diff changeset
177 StackMapFrame* next(StackMapFrame* pre_frame, bool first,
a61af66fc99e Initial load
duke
parents:
diff changeset
178 u2 max_locals, u2 max_stack, TRAPS);
a61af66fc99e Initial load
duke
parents:
diff changeset
179
a61af66fc99e Initial load
duke
parents:
diff changeset
180 void check_end(TRAPS) {
a61af66fc99e Initial load
duke
parents:
diff changeset
181 if (!_stream->at_end()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
182 StackMapStream::stackmap_format_error("wrong attribute size", CHECK);
a61af66fc99e Initial load
duke
parents:
diff changeset
183 }
a61af66fc99e Initial load
duke
parents:
diff changeset
184 }
a61af66fc99e Initial load
duke
parents:
diff changeset
185 };
1972
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
186
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
187 #endif // SHARE_VM_CLASSFILE_STACKMAPTABLE_HPP