annotate src/share/vm/memory/referencePolicy.cpp @ 3992:d1bdeef3e3e2

7098282: G1: assert(interval >= 0) failed: Sanity check, referencePolicy.cpp: 76 Summary: There is a race between one thread successfully forwarding and copying the klass mirror for the SoftReference class (including the static master clock) and another thread attempting to use the master clock while attempting to discover a soft reference object. Maintain a shadow copy of the soft reference master clock and use the shadow during reference discovery and reference processing. Reviewed-by: tonyp, brutisso, ysr
author johnc
date Wed, 12 Oct 2011 10:25:51 -0700
parents f95d63e2154a
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1 /*
3992
d1bdeef3e3e2 7098282: G1: assert(interval >= 0) failed: Sanity check, referencePolicy.cpp: 76
johnc
parents: 1972
diff changeset
2 * Copyright (c) 2000, 2011, Oracle and/or its affiliates. All rights reserved.
0
a61af66fc99e Initial load
duke
parents:
diff changeset
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
a61af66fc99e Initial load
duke
parents:
diff changeset
4 *
a61af66fc99e Initial load
duke
parents:
diff changeset
5 * This code is free software; you can redistribute it and/or modify it
a61af66fc99e Initial load
duke
parents:
diff changeset
6 * under the terms of the GNU General Public License version 2 only, as
a61af66fc99e Initial load
duke
parents:
diff changeset
7 * published by the Free Software Foundation.
a61af66fc99e Initial load
duke
parents:
diff changeset
8 *
a61af66fc99e Initial load
duke
parents:
diff changeset
9 * This code is distributed in the hope that it will be useful, but WITHOUT
a61af66fc99e Initial load
duke
parents:
diff changeset
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
a61af66fc99e Initial load
duke
parents:
diff changeset
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
a61af66fc99e Initial load
duke
parents:
diff changeset
12 * version 2 for more details (a copy is included in the LICENSE file that
a61af66fc99e Initial load
duke
parents:
diff changeset
13 * accompanied this code).
a61af66fc99e Initial load
duke
parents:
diff changeset
14 *
a61af66fc99e Initial load
duke
parents:
diff changeset
15 * You should have received a copy of the GNU General Public License version
a61af66fc99e Initial load
duke
parents:
diff changeset
16 * 2 along with this work; if not, write to the Free Software Foundation,
a61af66fc99e Initial load
duke
parents:
diff changeset
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
a61af66fc99e Initial load
duke
parents:
diff changeset
18 *
1552
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 470
diff changeset
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 470
diff changeset
20 * or visit www.oracle.com if you need additional information or have any
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 470
diff changeset
21 * questions.
0
a61af66fc99e Initial load
duke
parents:
diff changeset
22 *
a61af66fc99e Initial load
duke
parents:
diff changeset
23 */
a61af66fc99e Initial load
duke
parents:
diff changeset
24
1972
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
25 #include "precompiled.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
26 #include "classfile/javaClasses.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
27 #include "memory/referencePolicy.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
28 #include "memory/universe.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
29 #include "runtime/arguments.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1552
diff changeset
30 #include "runtime/globals.hpp"
0
a61af66fc99e Initial load
duke
parents:
diff changeset
31
a61af66fc99e Initial load
duke
parents:
diff changeset
32 LRUCurrentHeapPolicy::LRUCurrentHeapPolicy() {
457
27a80744a83b 6778647: snap(), snap_policy() should be renamed setup(), setup_policy()
ysr
parents: 453
diff changeset
33 setup();
453
c96030fff130 6684579: SoftReference processing can be made more efficient
ysr
parents: 0
diff changeset
34 }
c96030fff130 6684579: SoftReference processing can be made more efficient
ysr
parents: 0
diff changeset
35
c96030fff130 6684579: SoftReference processing can be made more efficient
ysr
parents: 0
diff changeset
36 // Capture state (of-the-VM) information needed to evaluate the policy
457
27a80744a83b 6778647: snap(), snap_policy() should be renamed setup(), setup_policy()
ysr
parents: 453
diff changeset
37 void LRUCurrentHeapPolicy::setup() {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
38 _max_interval = (Universe::get_heap_free_at_last_gc() / M) * SoftRefLRUPolicyMSPerMB;
a61af66fc99e Initial load
duke
parents:
diff changeset
39 assert(_max_interval >= 0,"Sanity check");
a61af66fc99e Initial load
duke
parents:
diff changeset
40 }
a61af66fc99e Initial load
duke
parents:
diff changeset
41
a61af66fc99e Initial load
duke
parents:
diff changeset
42 // The oop passed in is the SoftReference object, and not
a61af66fc99e Initial load
duke
parents:
diff changeset
43 // the object the SoftReference points to.
3992
d1bdeef3e3e2 7098282: G1: assert(interval >= 0) failed: Sanity check, referencePolicy.cpp: 76
johnc
parents: 1972
diff changeset
44 bool LRUCurrentHeapPolicy::should_clear_reference(oop p,
d1bdeef3e3e2 7098282: G1: assert(interval >= 0) failed: Sanity check, referencePolicy.cpp: 76
johnc
parents: 1972
diff changeset
45 jlong timestamp_clock) {
d1bdeef3e3e2 7098282: G1: assert(interval >= 0) failed: Sanity check, referencePolicy.cpp: 76
johnc
parents: 1972
diff changeset
46 jlong interval = timestamp_clock - java_lang_ref_SoftReference::timestamp(p);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
47 assert(interval >= 0, "Sanity check");
a61af66fc99e Initial load
duke
parents:
diff changeset
48
a61af66fc99e Initial load
duke
parents:
diff changeset
49 // The interval will be zero if the ref was accessed since the last scavenge/gc.
a61af66fc99e Initial load
duke
parents:
diff changeset
50 if(interval <= _max_interval) {
a61af66fc99e Initial load
duke
parents:
diff changeset
51 return false;
a61af66fc99e Initial load
duke
parents:
diff changeset
52 }
a61af66fc99e Initial load
duke
parents:
diff changeset
53
a61af66fc99e Initial load
duke
parents:
diff changeset
54 return true;
a61af66fc99e Initial load
duke
parents:
diff changeset
55 }
a61af66fc99e Initial load
duke
parents:
diff changeset
56
a61af66fc99e Initial load
duke
parents:
diff changeset
57 /////////////////////// MaxHeap //////////////////////
a61af66fc99e Initial load
duke
parents:
diff changeset
58
a61af66fc99e Initial load
duke
parents:
diff changeset
59 LRUMaxHeapPolicy::LRUMaxHeapPolicy() {
457
27a80744a83b 6778647: snap(), snap_policy() should be renamed setup(), setup_policy()
ysr
parents: 453
diff changeset
60 setup();
453
c96030fff130 6684579: SoftReference processing can be made more efficient
ysr
parents: 0
diff changeset
61 }
c96030fff130 6684579: SoftReference processing can be made more efficient
ysr
parents: 0
diff changeset
62
c96030fff130 6684579: SoftReference processing can be made more efficient
ysr
parents: 0
diff changeset
63 // Capture state (of-the-VM) information needed to evaluate the policy
457
27a80744a83b 6778647: snap(), snap_policy() should be renamed setup(), setup_policy()
ysr
parents: 453
diff changeset
64 void LRUMaxHeapPolicy::setup() {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
65 size_t max_heap = MaxHeapSize;
a61af66fc99e Initial load
duke
parents:
diff changeset
66 max_heap -= Universe::get_heap_used_at_last_gc();
a61af66fc99e Initial load
duke
parents:
diff changeset
67 max_heap /= M;
a61af66fc99e Initial load
duke
parents:
diff changeset
68
a61af66fc99e Initial load
duke
parents:
diff changeset
69 _max_interval = max_heap * SoftRefLRUPolicyMSPerMB;
a61af66fc99e Initial load
duke
parents:
diff changeset
70 assert(_max_interval >= 0,"Sanity check");
a61af66fc99e Initial load
duke
parents:
diff changeset
71 }
a61af66fc99e Initial load
duke
parents:
diff changeset
72
a61af66fc99e Initial load
duke
parents:
diff changeset
73 // The oop passed in is the SoftReference object, and not
a61af66fc99e Initial load
duke
parents:
diff changeset
74 // the object the SoftReference points to.
3992
d1bdeef3e3e2 7098282: G1: assert(interval >= 0) failed: Sanity check, referencePolicy.cpp: 76
johnc
parents: 1972
diff changeset
75 bool LRUMaxHeapPolicy::should_clear_reference(oop p,
d1bdeef3e3e2 7098282: G1: assert(interval >= 0) failed: Sanity check, referencePolicy.cpp: 76
johnc
parents: 1972
diff changeset
76 jlong timestamp_clock) {
d1bdeef3e3e2 7098282: G1: assert(interval >= 0) failed: Sanity check, referencePolicy.cpp: 76
johnc
parents: 1972
diff changeset
77 jlong interval = timestamp_clock - java_lang_ref_SoftReference::timestamp(p);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
78 assert(interval >= 0, "Sanity check");
a61af66fc99e Initial load
duke
parents:
diff changeset
79
a61af66fc99e Initial load
duke
parents:
diff changeset
80 // The interval will be zero if the ref was accessed since the last scavenge/gc.
a61af66fc99e Initial load
duke
parents:
diff changeset
81 if(interval <= _max_interval) {
a61af66fc99e Initial load
duke
parents:
diff changeset
82 return false;
a61af66fc99e Initial load
duke
parents:
diff changeset
83 }
a61af66fc99e Initial load
duke
parents:
diff changeset
84
a61af66fc99e Initial load
duke
parents:
diff changeset
85 return true;
a61af66fc99e Initial load
duke
parents:
diff changeset
86 }