annotate graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/phases/AheadOfTimeVerificationPhase.java @ 18288:feef9ed5fc56

added HotSpotObjectConstant.isInternedString()
author Doug Simon <doug.simon@oracle.com>
date Thu, 06 Nov 2014 13:57:43 +0100
parents f7d45e2426d4
children 0f4813e0b4a9
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
10015
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
1 /*
18187
9619ba4daf4c Rename Constant to JavaConstant.
Roland Schatz <roland.schatz@oracle.com>
parents: 17064
diff changeset
2 * Copyright (c) 2013, 2014, Oracle and/or its affiliates. All rights reserved.
10015
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
4 *
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
5 * This code is free software; you can redistribute it and/or modify it
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
6 * under the terms of the GNU General Public License version 2 only, as
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
7 * published by the Free Software Foundation.
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
8 *
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
9 * This code is distributed in the hope that it will be useful, but WITHOUT
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
12 * version 2 for more details (a copy is included in the LICENSE file that
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
13 * accompanied this code).
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
14 *
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
15 * You should have received a copy of the GNU General Public License version
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
16 * 2 along with this work; if not, write to the Free Software Foundation,
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
18 *
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
20 * or visit www.oracle.com if you need additional information or have any
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
21 * questions.
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
22 */
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
23 package com.oracle.graal.hotspot.phases;
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
24
12655
2c4aa758ee18 made ConstantNodes external to a Graph (GRAAL-508)
Doug Simon <doug.simon@oracle.com>
parents: 12573
diff changeset
25 import static com.oracle.graal.nodes.ConstantNode.*;
2c4aa758ee18 made ConstantNodes external to a Graph (GRAAL-508)
Doug Simon <doug.simon@oracle.com>
parents: 12573
diff changeset
26
10015
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
27 import com.oracle.graal.api.meta.*;
15018
db4254246f9a Remove Constant.forObject and Constant.asObject to improve compiler/VM separation
Christian Wimmer <christian.wimmer@oracle.com>
parents: 14776
diff changeset
28 import com.oracle.graal.hotspot.meta.*;
10015
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
29 import com.oracle.graal.nodes.*;
15154
d708c2fc5cba Allow DirectMethodHandles references in immutable code
Gilles Duboscq <duboscq@ssw.jku.at>
parents: 15018
diff changeset
30 import com.oracle.graal.nodes.type.*;
10015
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
31 import com.oracle.graal.phases.*;
10937
87d9b5518065 Move VerifyUsageWithEquals phases into HighTier.
Roland Schatz <roland.schatz@oracle.com>
parents: 10421
diff changeset
32 import com.oracle.graal.phases.tiers.*;
10015
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
33
10074
e8fbc5fd3440 aot: add/fix some javadoc
Bernhard Urban <bernhard.urban@jku.at>
parents: 10062
diff changeset
34 /**
10421
1669d8b5863a aot verify: check if string constant is really a interned string; javadoc updates
Bernhard Urban <bernhard.urban@jku.at>
parents: 10074
diff changeset
35 * Checks for illegal object constants in a graph processed for AOT compilation. The only legal
1669d8b5863a aot verify: check if string constant is really a interned string; javadoc updates
Bernhard Urban <bernhard.urban@jku.at>
parents: 10074
diff changeset
36 * object constants are {@linkplain String#intern() interned} strings as they will be installed in
1669d8b5863a aot verify: check if string constant is really a interned string; javadoc updates
Bernhard Urban <bernhard.urban@jku.at>
parents: 10074
diff changeset
37 * the Class Data Sharing (CDS) space.
14776
07dd21c7d533 revived use of FindBugs annotations
Doug Simon <doug.simon@oracle.com>
parents: 14633
diff changeset
38 *
10074
e8fbc5fd3440 aot: add/fix some javadoc
Bernhard Urban <bernhard.urban@jku.at>
parents: 10062
diff changeset
39 * @see LoadJavaMirrorWithKlassPhase
e8fbc5fd3440 aot: add/fix some javadoc
Bernhard Urban <bernhard.urban@jku.at>
parents: 10062
diff changeset
40 */
10937
87d9b5518065 Move VerifyUsageWithEquals phases into HighTier.
Roland Schatz <roland.schatz@oracle.com>
parents: 10421
diff changeset
41 public class AheadOfTimeVerificationPhase extends VerifyPhase<PhaseContext> {
10015
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
42
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
43 @Override
10937
87d9b5518065 Move VerifyUsageWithEquals phases into HighTier.
Roland Schatz <roland.schatz@oracle.com>
parents: 10421
diff changeset
44 protected boolean verify(StructuredGraph graph, PhaseContext context) {
12655
2c4aa758ee18 made ConstantNodes external to a Graph (GRAAL-508)
Doug Simon <doug.simon@oracle.com>
parents: 12573
diff changeset
45 for (ConstantNode node : getConstantNodes(graph)) {
17064
3c54a098455f removed Node.recordsUsages()
Doug Simon <doug.simon@oracle.com>
parents: 16073
diff changeset
46 if (isObject(node) && !isNullReference(node) && !isInternedString(node) && !isDirectMethodHandle(node) && !isBoundMethodHandle(node)) {
3c54a098455f removed Node.recordsUsages()
Doug Simon <doug.simon@oracle.com>
parents: 16073
diff changeset
47 throw new VerificationError("illegal object constant: " + node);
12573
6332050441eb fixed tests that need to take into account ConstantNodes not recording their usages (GRAAL-508)
Doug Simon <doug.simon@oracle.com>
parents: 10937
diff changeset
48 }
10015
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
49 }
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
50 return true;
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
51 }
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
52
10421
1669d8b5863a aot verify: check if string constant is really a interned string; javadoc updates
Bernhard Urban <bernhard.urban@jku.at>
parents: 10074
diff changeset
53 private static boolean isObject(ConstantNode node) {
14633
da2431cc1506 Rename ValueNode kind() to getKind().
Josef Eisl <josef.eisl@jku.at>
parents: 14166
diff changeset
54 return node.getKind() == Kind.Object;
10015
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
55 }
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
56
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
57 private static boolean isNullReference(ConstantNode node) {
18187
9619ba4daf4c Rename Constant to JavaConstant.
Roland Schatz <roland.schatz@oracle.com>
parents: 17064
diff changeset
58 return isObject(node) && node.asJavaConstant().isNull();
10015
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
59 }
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
60
15154
d708c2fc5cba Allow DirectMethodHandles references in immutable code
Gilles Duboscq <duboscq@ssw.jku.at>
parents: 15018
diff changeset
61 private static boolean isDirectMethodHandle(ConstantNode node) {
d708c2fc5cba Allow DirectMethodHandles references in immutable code
Gilles Duboscq <duboscq@ssw.jku.at>
parents: 15018
diff changeset
62 if (!isObject(node)) {
d708c2fc5cba Allow DirectMethodHandles references in immutable code
Gilles Duboscq <duboscq@ssw.jku.at>
parents: 15018
diff changeset
63 return false;
d708c2fc5cba Allow DirectMethodHandles references in immutable code
Gilles Duboscq <duboscq@ssw.jku.at>
parents: 15018
diff changeset
64 }
15260
61363577a184 Move static helpers from ObjectStamp to StampTool.
Josef Eisl <josef.eisl@jku.at>
parents: 15154
diff changeset
65 return "Ljava/lang/invoke/DirectMethodHandle;".equals(StampTool.typeOrNull(node).getName());
15154
d708c2fc5cba Allow DirectMethodHandles references in immutable code
Gilles Duboscq <duboscq@ssw.jku.at>
parents: 15018
diff changeset
66 }
d708c2fc5cba Allow DirectMethodHandles references in immutable code
Gilles Duboscq <duboscq@ssw.jku.at>
parents: 15018
diff changeset
67
15469
5c05f3666abf allow BoundMethodHandles in AheadOfTime verification
Lukas Stadler <lukas.stadler@oracle.com>
parents: 15260
diff changeset
68 private static boolean isBoundMethodHandle(ConstantNode node) {
5c05f3666abf allow BoundMethodHandles in AheadOfTime verification
Lukas Stadler <lukas.stadler@oracle.com>
parents: 15260
diff changeset
69 if (!isObject(node)) {
5c05f3666abf allow BoundMethodHandles in AheadOfTime verification
Lukas Stadler <lukas.stadler@oracle.com>
parents: 15260
diff changeset
70 return false;
5c05f3666abf allow BoundMethodHandles in AheadOfTime verification
Lukas Stadler <lukas.stadler@oracle.com>
parents: 15260
diff changeset
71 }
5c05f3666abf allow BoundMethodHandles in AheadOfTime verification
Lukas Stadler <lukas.stadler@oracle.com>
parents: 15260
diff changeset
72 return StampTool.typeOrNull(node).getName().startsWith("Ljava/lang/invoke/BoundMethodHandle");
5c05f3666abf allow BoundMethodHandles in AheadOfTime verification
Lukas Stadler <lukas.stadler@oracle.com>
parents: 15260
diff changeset
73 }
5c05f3666abf allow BoundMethodHandles in AheadOfTime verification
Lukas Stadler <lukas.stadler@oracle.com>
parents: 15260
diff changeset
74
10421
1669d8b5863a aot verify: check if string constant is really a interned string; javadoc updates
Bernhard Urban <bernhard.urban@jku.at>
parents: 10074
diff changeset
75 private static boolean isInternedString(ConstantNode node) {
1669d8b5863a aot verify: check if string constant is really a interned string; javadoc updates
Bernhard Urban <bernhard.urban@jku.at>
parents: 10074
diff changeset
76 if (!isObject(node)) {
1669d8b5863a aot verify: check if string constant is really a interned string; javadoc updates
Bernhard Urban <bernhard.urban@jku.at>
parents: 10074
diff changeset
77 return false;
1669d8b5863a aot verify: check if string constant is really a interned string; javadoc updates
Bernhard Urban <bernhard.urban@jku.at>
parents: 10074
diff changeset
78 }
1669d8b5863a aot verify: check if string constant is really a interned string; javadoc updates
Bernhard Urban <bernhard.urban@jku.at>
parents: 10074
diff changeset
79
18288
feef9ed5fc56 added HotSpotObjectConstant.isInternedString()
Doug Simon <doug.simon@oracle.com>
parents: 18262
diff changeset
80 HotSpotObjectConstant c = (HotSpotObjectConstant) node.asConstant();
feef9ed5fc56 added HotSpotObjectConstant.isInternedString()
Doug Simon <doug.simon@oracle.com>
parents: 18262
diff changeset
81 return c.isInternedString();
10015
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
82 }
deb5bd841422 aot: add verification phase
Bernhard Urban <bernhard.urban@jku.at>
parents:
diff changeset
83 }