Mercurial > hg > truffle

changeset 14777:10c6700908ef

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
mx: removed use of exclusion filter files from findbugs command
author Doug Simon <doug.simon@oracle.com>
date Wed, 26 Mar 2014 22:20:23 +0100
parents 07dd21c7d533
children 5720104b54ba
files graal/findbugsExcludeFilter.xml mx/mx_graal.py
diffstat 2 files changed, 1 insertions(+), 47 deletions(-) [+]
line wrap: on
line diff
--- a/graal/findbugsExcludeFilter.xml	Wed Mar 26 22:19:33 2014 +0100
+++ /dev/null	Thu Jan 01 00:00:00 1970 +0000
@@ -1,41 +0,0 @@
-<FindBugsFilter>
-
-  <Match>
-    <Class name="com.oracle.graal.hotspot.CompilationTask" />
-    <Method name="run" />
-    <Bug pattern="NN_NAKED_NOTIFY" />
-  </Match>
-
-  <!-- justification = "concurrent abstraction calls are in synchronized block" -->
-  <Match>
-    <Class name="com.oracle.graal.hotspot.debug.BenchmarkCounters" />
-    <Method name="getIndex" />
-    <Bug pattern="AT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION" />
-  </Match>
-
-  <!-- justification = "counters are only used for statistics" -->
-  <Match>
-    <Class name="com.oracle.graal.hotspot.meta.HotSpotGraphCache" />
-    <Or>
-      <Method name="get" />
-      <Method name="put" />
-      <Method name="removeGraphs" />
-    </Or>
-    <Bug pattern="VO_VOLATILE_INCREMENT" />
-  </Match>
-
-  <!-- justification = "reference equality on the receiver is what we want" -->
-  <Match>
-    <Class name="com.oracle.graal.replacements.StringSubstitutions" />
-    <Method name="equals" />
-    <Bug pattern="ES_COMPARING_PARAMETER_STRING_WITH_EQ" />
-  </Match>
-
-  <!-- justification = "reference equality to test whether string is interned" -->
-  <Match>
-    <Class name="com.oracle.graal.hotspot.phases.AheadOfTimeVerificationPhase" />
-    <Method name="isInternedString" />
-    <Bug pattern="ES_COMPARING_STRINGS_WITH_EQ" />
-  </Match>
-
-</FindBugsFilter>
--- a/mx/mx_graal.py	Wed Mar 26 22:19:33 2014 +0100
+++ b/mx/mx_graal.py	Wed Mar 26 22:20:23 2014 +0100
@@ -1701,12 +1701,7 @@
     outputDirs = [p.output_dir() for p in nonTestProjects]
     findbugsResults = join(_graal_home, 'findbugs.results')
 
-    cmd = ['-jar', findbugsJar, '-textui', '-low', '-maxRank', '15', '-exclude', join(_graal_home, 'graal', 'findbugsExcludeFilter.xml')]
-    for s in mx.suites():
-        filt = join(s.dir, 'findbugsExcludeFilter.xml')
-        if exists(filt):
-            cmd.append('-exclude')
-            cmd.append(filt)
+    cmd = ['-jar', findbugsJar, '-textui', '-low', '-maxRank', '15']
     if sys.stdout.isatty():
         cmd.append('-progress')
     cmd = cmd + ['-auxclasspath', mx.classpath([p.name for p in nonTestProjects]), '-output', findbugsResults, '-progress', '-exitcode'] + args + outputDirs