Mercurial > hg > truffle
changeset 7417:1b1e16471e46
8005002: Crash because of a raw oop in ClassLoaderData::add_dependency
Summary: Move the handelization of 'last' to a point before the GC might enter.
Reviewed-by: dholmes, sspitsyn, coleenp
author | stefank |
---|---|
date | Wed, 12 Dec 2012 22:41:13 +0100 |
parents | a70c88896791 |
children | 3c433d080bae |
files | src/share/vm/classfile/classLoaderData.cpp |
diffstat | 1 files changed, 5 insertions(+), 3 deletions(-) [+] |
line wrap: on
line diff
--- a/src/share/vm/classfile/classLoaderData.cpp Thu Dec 13 17:27:55 2012 -0800 +++ b/src/share/vm/classfile/classLoaderData.cpp Wed Dec 12 22:41:13 2012 +0100 @@ -167,16 +167,18 @@ ok = (objArrayOop)ok->obj_at(1); } + // Must handle over GC points + assert (last != NULL, "dependencies should be initialized"); + objArrayHandle last_handle(THREAD, last); + // Create a new dependency node with fields for (class_loader or mirror, next) objArrayOop deps = oopFactory::new_objectArray(2, CHECK); deps->obj_at_put(0, dependency()); - // Must handle over more GC points + // Must handle over GC points objArrayHandle new_dependency(THREAD, deps); // Add the dependency under lock - assert (last != NULL, "dependencies should be initialized"); - objArrayHandle last_handle(THREAD, last); locked_add_dependency(last_handle, new_dependency); }