Mercurial > hg > truffle
changeset 5057:3d7e78f17df5
more comments tag updates
| author | Gilles Duboscq <duboscq@ssw.jku.at> |
|---|---|
| date | Thu, 08 Mar 2012 15:06:59 +0100 |
| parents | 2f2c6347fce4 |
| children | 26f8371c229c |
| files | graal/com.oracle.max.graal.compiler/src/com/oracle/max/graal/compiler/phases/IntrinsificationPhase.java graal/com.oracle.max.graal.compiler/src/com/oracle/max/graal/compiler/util/InliningUtil.java graal/com.oracle.max.graal.hotspot/src/com/oracle/max/graal/hotspot/ri/HotSpotField.java graal/com.oracle.max.graal.hotspot/src/com/oracle/max/graal/hotspot/ri/HotSpotMethodData.java graal/com.oracle.max.graal.nodes/src/com/oracle/max/graal/nodes/extended/ReadHubNode.java src/share/vm/oops/methodDataOop.cpp |
| diffstat | 6 files changed, 7 insertions(+), 7 deletions(-) [+] |
line wrap: on
line diff
--- a/graal/com.oracle.max.graal.compiler/src/com/oracle/max/graal/compiler/phases/IntrinsificationPhase.java Thu Mar 08 15:01:19 2012 +0100 +++ b/graal/com.oracle.max.graal.compiler/src/com/oracle/max/graal/compiler/phases/IntrinsificationPhase.java Thu Mar 08 15:06:59 2012 +0100 @@ -69,7 +69,7 @@ private static StructuredGraph getIntrinsicGraph(Invoke invoke, RiResolvedMethod target, GraalRuntime runtime) { StructuredGraph intrinsicGraph = (StructuredGraph) target.compilerStorage().get(Graph.class); if (intrinsicGraph == null) { - // TODO (ph) remove once all intrinsics are available via compilerStorage + // TODO remove once all intrinsics are available via compilerStorage intrinsicGraph = runtime.intrinsicGraph(invoke.stateAfter().method(), invoke.bci(), target, invoke.callTarget().arguments()); } return intrinsicGraph;
--- a/graal/com.oracle.max.graal.compiler/src/com/oracle/max/graal/compiler/util/InliningUtil.java Thu Mar 08 15:01:19 2012 +0100 +++ b/graal/com.oracle.max.graal.compiler/src/com/oracle/max/graal/compiler/util/InliningUtil.java Thu Mar 08 15:06:59 2012 +0100 @@ -619,13 +619,13 @@ } else { invoke.setMegamorph(true); if (GraalOptions.InlinePolymorphicCalls && notRecordedTypeProbability == 0 || GraalOptions.InlineMegamorphicCalls && notRecordedTypeProbability > 0) { - // TODO (ch) inlining of multiple methods should work differently + // TODO (chaeubl) inlining of multiple methods should work differently // 1. check which methods can be inlined // 2. for those methods, use weight and probability to compute which of them should be inlined // 3. do the inlining // a) all seen methods can be inlined -> do so and guard with deopt // b) some methods can be inlined -> inline them and fall back to invocation if violated - // TODO (ch) sort types by probability + // TODO (chaeubl) sort types by probability // determine concrete methods and map type to specific method ArrayList<RiResolvedMethod> concreteMethods = new ArrayList<>();
--- a/graal/com.oracle.max.graal.hotspot/src/com/oracle/max/graal/hotspot/ri/HotSpotField.java Thu Mar 08 15:01:19 2012 +0100 +++ b/graal/com.oracle.max.graal.hotspot/src/com/oracle/max/graal/hotspot/ri/HotSpotField.java Thu Mar 08 15:06:59 2012 +0100 @@ -79,7 +79,7 @@ return constant; } else { assert !Modifier.isStatic(accessFlags); - // TODO (ch) HotSpot does not trust final non-static fields (see ciField.cpp) + // TODO (chaeubl) HotSpot does not trust final non-static fields (see ciField.cpp) if (Modifier.isFinal(accessFlags())) { return this.kind(false).readUnsafeConstant(receiver.asObject(), offset); }
--- a/graal/com.oracle.max.graal.hotspot/src/com/oracle/max/graal/hotspot/ri/HotSpotMethodData.java Thu Mar 08 15:01:19 2012 +0100 +++ b/graal/com.oracle.max.graal.hotspot/src/com/oracle/max/graal/hotspot/ri/HotSpotMethodData.java Thu Mar 08 15:06:59 2012 +0100 @@ -43,7 +43,7 @@ config = CompilerImpl.getInstance().getConfig(); } - // TODO (ch) use same logic as in NodeClass? + // TODO (chaeubl) use same logic as in NodeClass? private static final Unsafe unsafe = Unsafe.getUnsafe(); private static final HotSpotMethodDataAccessor NO_DATA_NO_EXCEPTION_ACCESSOR = new NoMethodData(RiExceptionSeen.FALSE); private static final HotSpotMethodDataAccessor NO_DATA_EXCEPTION_POSSIBLY_NOT_RECORDED_ACCESSOR = new NoMethodData(RiExceptionSeen.NOT_SUPPORTED);
--- a/graal/com.oracle.max.graal.nodes/src/com/oracle/max/graal/nodes/extended/ReadHubNode.java Thu Mar 08 15:01:19 2012 +0100 +++ b/graal/com.oracle.max.graal.nodes/src/com/oracle/max/graal/nodes/extended/ReadHubNode.java Thu Mar 08 15:06:59 2012 +0100 @@ -28,7 +28,7 @@ import com.oracle.max.graal.nodes.spi.*; import com.oracle.max.graal.nodes.type.*; -// TODO (ch) this should be a FloatingNode but Lowering is not possible in that case +// TODO (chaeubl) this should be a FloatingNode but Lowering is not possible in that case public final class ReadHubNode extends FixedWithNextNode implements Lowerable { @Input private ValueNode object;
--- a/src/share/vm/oops/methodDataOop.cpp Thu Mar 08 15:01:19 2012 +0100 +++ b/src/share/vm/oops/methodDataOop.cpp Thu Mar 08 15:06:59 2012 +0100 @@ -865,7 +865,7 @@ _nof_decompiles += 1; if (decompile_count() > (uint)PerMethodRecompilationCutoff) { #ifdef GRAAL - // TODO (ch) enable this in the fastdebug build only once we are more stable + // TODO (chaeubl) enable this in the fastdebug build only once we are more stable ResourceMark m; tty->print_cr("WARN: endless recompilation of %s. Method was set to not compilable.", method()->name_and_sig_as_C_string()); //ShouldNotReachHere();