changeset 15773:56689688067a

[inlining-4] privatizing methods that can be made private
author Miguel Garcia <miguel.m.garcia@oracle.com>
date Mon, 19 May 2014 16:52:10 +0200
parents 3813fb9e3e24
children 402a74c6bc14
files graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/inlining/walker/InliningData.java
diffstat 1 files changed, 11 insertions(+), 11 deletions(-) [+]
line wrap: on
line diff
--- a/graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/inlining/walker/InliningData.java	Mon May 19 16:45:11 2014 +0200
+++ b/graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/inlining/walker/InliningData.java	Mon May 19 16:52:10 2014 +0200
@@ -97,7 +97,7 @@
      * @param invoke the invoke that should be inlined
      * @return an instance of InlineInfo, or null if no inlining is possible at the given invoke
      */
-    public InlineInfo getInlineInfo(Invoke invoke, Assumptions assumptions) {
+    private InlineInfo getInlineInfo(Invoke invoke, Assumptions assumptions) {
         final String failureMessage = InliningUtil.checkInvokeConditions(invoke);
         if (failureMessage != null) {
             InliningUtil.logNotInlinedMethod(invoke, failureMessage);
@@ -165,7 +165,7 @@
         return getTypeCheckedInlineInfo(invoke, targetMethod);
     }
 
-    public InlineInfo getTypeCheckedInlineInfo(Invoke invoke, ResolvedJavaMethod targetMethod) {
+    private InlineInfo getTypeCheckedInlineInfo(Invoke invoke, ResolvedJavaMethod targetMethod) {
         JavaTypeProfile typeProfile;
         ValueNode receiver = invoke.callTarget().arguments().get(0);
         if (receiver instanceof TypeProfileProxyNode) {
@@ -290,7 +290,7 @@
         }
     }
 
-    public InlineInfo getAssumptionInlineInfo(Invoke invoke, ResolvedJavaMethod concrete, Assumptions.Assumption takenAssumption) {
+    private InlineInfo getAssumptionInlineInfo(Invoke invoke, ResolvedJavaMethod concrete, Assumptions.Assumption takenAssumption) {
         assert !concrete.isAbstract();
         if (!InliningUtil.checkTargetConditions(this, context.getReplacements(), invoke, concrete, context.getOptimisticOptimizations())) {
             return null;
@@ -298,7 +298,7 @@
         return new AssumptionInlineInfo(invoke, concrete, takenAssumption);
     }
 
-    public InlineInfo getExactInlineInfo(Invoke invoke, ResolvedJavaMethod targetMethod) {
+    private InlineInfo getExactInlineInfo(Invoke invoke, ResolvedJavaMethod targetMethod) {
         assert !targetMethod.isAbstract();
         if (!InliningUtil.checkTargetConditions(this, context.getReplacements(), invoke, targetMethod, context.getOptimisticOptimizations())) {
             return null;
@@ -366,7 +366,7 @@
     /**
      * Process the next invoke and enqueue all its graphs for processing.
      */
-    void processNextInvoke() {
+    private void processNextInvoke() {
         CallsiteHolder callsiteHolder = currentGraph();
         Invoke invoke = callsiteHolder.popInvoke();
         MethodInvocation callerInvocation = currentInvocation();
@@ -410,16 +410,16 @@
         return !graphQueue.isEmpty();
     }
 
-    public CallsiteHolder currentGraph() {
+    private CallsiteHolder currentGraph() {
         return graphQueue.peek();
     }
 
-    public void popGraph() {
+    private void popGraph() {
         graphQueue.pop();
         assert graphQueue.size() <= maxGraphs;
     }
 
-    public void popGraphs(int count) {
+    private void popGraphs(int count) {
         assert count >= 0;
         for (int i = 0; i < count; i++) {
             graphQueue.pop();
@@ -431,7 +431,7 @@
     /**
      * Gets the call hierarchy of this inlining from outer most call to inner most callee.
      */
-    public Object[] inliningContext() {
+    private Object[] inliningContext() {
         if (!Debug.isDumpEnabled()) {
             return NO_CONTEXT;
         }
@@ -443,7 +443,7 @@
         return result;
     }
 
-    public MethodInvocation currentInvocation() {
+    private MethodInvocation currentInvocation() {
         return invocationQueue.peekFirst();
     }
 
@@ -455,7 +455,7 @@
         return methodInvocation;
     }
 
-    public void popInvocation() {
+    private void popInvocation() {
         maxGraphs -= invocationQueue.peekFirst().callee().numberOfMethods();
         assert graphQueue.size() <= maxGraphs;
         invocationQueue.removeFirst();