Mercurial > hg > truffle
changeset 4285:9770cb8164b7
IdealGraphVisualizer: don't internalize strings from parsed graphs, it's expensive and can lead to OutOfMemoryErrors in the perm gen space for huge graphs
| author | Peter Hofer <peter.hofer@jku.at> |
|---|---|
| date | Mon, 16 Jan 2012 15:35:33 +0100 |
| parents | 1339f1817d28 |
| children | 152f3b514618 ff0ac17dc0aa |
| files | src/share/tools/IdealGraphVisualizer/BatikSVGProxy/nbproject/genfiles.properties src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/serialization/Parser.java src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/serialization/XMLParser.java src/share/tools/IdealGraphVisualizer/Graal/src/com/sun/hotspot/igv/graal/filters/callgraph.filter |
| diffstat | 4 files changed, 9 insertions(+), 11 deletions(-) [+] |
line wrap: on
line diff
--- a/src/share/tools/IdealGraphVisualizer/BatikSVGProxy/nbproject/genfiles.properties Fri Jan 13 16:26:37 2012 +0100 +++ b/src/share/tools/IdealGraphVisualizer/BatikSVGProxy/nbproject/genfiles.properties Mon Jan 16 15:35:33 2012 +0100 @@ -2,4 +2,4 @@ # Do not edit this file. You may delete it but then the IDE will never regenerate such files for you. nbproject/build-impl.xml.data.CRC32=ebcf0422 nbproject/build-impl.xml.script.CRC32=42ef3ff6 -nbproject/build-impl.xml.stylesheet.CRC32=238281d1@1.45.1 +nbproject/build-impl.xml.stylesheet.CRC32=238281d1@2.47.1
--- a/src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/serialization/Parser.java Fri Jan 13 16:26:37 2012 +0100 +++ b/src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/serialization/Parser.java Mon Jan 16 15:35:33 2012 +0100 @@ -293,7 +293,7 @@ @Override protected InputBlock start() throws SAXException { InputGraph graph = getParentObject(); - String name = readRequiredAttribute(BLOCK_NAME_PROPERTY).intern(); + String name = readRequiredAttribute(BLOCK_NAME_PROPERTY); InputBlock b = graph.addBlock(name); for (InputNode n : b.getNodes()) { assert graph.getBlock(n).equals(b); @@ -447,12 +447,12 @@ @Override public String start() throws SAXException { - return readRequiredAttribute(PROPERTY_NAME_PROPERTY).intern(); + return readRequiredAttribute(PROPERTY_NAME_PROPERTY); } @Override public void end(String text) { - getParentObject().getProperties().setProperty(getObject(), text.trim().intern()); + getParentObject().getProperties().setProperty(getObject(), text.trim()); } };
--- a/src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/serialization/XMLParser.java Fri Jan 13 16:26:37 2012 +0100 +++ b/src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/serialization/XMLParser.java Mon Jan 16 15:35:33 2012 +0100 @@ -150,8 +150,8 @@ public void processAttributesAsProperties(Properties p) { int length = attr.getLength(); for (int i = 0; i < length; i++) { - String val = attr.getValue(i).intern(); - String localName = attr.getLocalName(i).intern(); + String val = attr.getValue(i); + String localName = attr.getLocalName(i); p.setProperty(val, localName); } }
--- a/src/share/tools/IdealGraphVisualizer/Graal/src/com/sun/hotspot/igv/graal/filters/callgraph.filter Fri Jan 13 16:26:37 2012 +0100 +++ b/src/share/tools/IdealGraphVisualizer/Graal/src/com/sun/hotspot/igv/graal/filters/callgraph.filter Mon Jan 16 15:35:33 2012 +0100 @@ -1,5 +1,3 @@ -colorize("abstract", "1", yellow); -colorize("leaf", "1", lightGray); - -var f = new com.sun.hotspot.igv.filter.EdgeColorIndexFilter("INPUTS", [black, pink]); -f.apply(graph); +colorize("name", "<init>.*", yellow); +colorize("name", "<clinit>.*", pink); +colorize("leaf", "1", red);