changeset 17603:a2ad508b8723

ValuePosition: reduce interface.
author Josef Eisl <josef.eisl@jku.at>
date Wed, 15 Oct 2014 17:31:48 +0200
parents ad52f96395bb
children 35ae3e916582
files graal/com.oracle.graal.lir/src/com/oracle/graal/lir/CompositeValueClass.java graal/com.oracle.graal.lir/src/com/oracle/graal/lir/ValuePosition.java
diffstat 2 files changed, 3 insertions(+), 24 deletions(-) [+]
line wrap: on
line diff
--- a/graal/com.oracle.graal.lir/src/com/oracle/graal/lir/CompositeValueClass.java	Wed Oct 15 17:24:59 2014 +0200
+++ b/graal/com.oracle.graal.lir/src/com/oracle/graal/lir/CompositeValueClass.java	Wed Oct 15 17:31:48 2014 +0200
@@ -121,10 +121,6 @@
         return result.toString();
     }
 
-    EnumSet<OperandFlag> getFlags(ValuePosition pos) {
-        return values.getFlags(pos.getIndex());
-    }
-
     void copyValueArrays(CompositeValue compositeValue) {
         for (int i = values.getDirectCount(); i < values.getCount(); i++) {
             Value[] valueArray = values.getValueArray(compositeValue, i);
--- a/graal/com.oracle.graal.lir/src/com/oracle/graal/lir/ValuePosition.java	Wed Oct 15 17:24:59 2014 +0200
+++ b/graal/com.oracle.graal.lir/src/com/oracle/graal/lir/ValuePosition.java	Wed Oct 15 17:31:48 2014 +0200
@@ -52,7 +52,8 @@
      */
     private final int subIndex;
     /**
-     * @see #getOuterPosition()
+     * The {@link ValuePosition} of the containing {@link CompositeValue} if this value is part of a
+     * {@link CompositeValue}, otherwise {@link #ROOT_VALUE_POSITION}.
      */
     private final ValuePosition outerPosition;
 
@@ -70,7 +71,7 @@
      * @return True if the value denoted by this {@linkplain ValuePosition position} is part of a
      *         {@link CompositeValue}.
      */
-    public boolean isCompositePosition() {
+    private boolean isCompositePosition() {
         return outerPosition != ROOT_VALUE_POSITION;
     }
 
@@ -110,14 +111,6 @@
         }
     }
 
-    int getSubIndex() {
-        return subIndex;
-    }
-
-    int getIndex() {
-        return index;
-    }
-
     /**
      * @return The flags associated with the value denoted by this {@linkplain ValuePosition
      *         position}.
@@ -126,16 +119,6 @@
         return values.getFlags(index);
     }
 
-    /**
-     * @return The {@link ValuePosition} of the containing {@link CompositeValue} if this value is
-     *         part of a {@link CompositeValue}, otherwise {@link #ROOT_VALUE_POSITION}.
-     *
-     * @see #isCompositePosition()
-     */
-    public ValuePosition getOuterPosition() {
-        return outerPosition;
-    }
-
     @Override
     public String toString() {
         String str = "(" + index + (subIndex < 0 ? "" : "/" + subIndex) + ")";