Mercurial > hg > truffle

changeset 11267:ceb2703b40b8

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Re-introduce canonicalization when the stamp represents a singleton using Stamp.asConstant
author Gilles Duboscq <duboscq@ssw.jku.at>
date Thu, 08 Aug 2013 18:59:09 +0200
parents 2290f6b53429
children ac59bdde1194
files graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/CanonicalizerPhase.java
diffstat 1 files changed, 18 insertions(+), 9 deletions(-) [+]
line wrap: on
line diff
--- a/graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/CanonicalizerPhase.java	Thu Aug 08 16:00:07 2013 +0200
+++ b/graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/CanonicalizerPhase.java	Thu Aug 08 18:59:09 2013 +0200
@@ -158,9 +158,17 @@
                 int mark = graph.getMark();
                 if (!tryKillUnused(node)) {
                     if (!tryCanonicalize(node)) {
-                        if (tryInferStamp(node)) {
-                            // the improved stamp may enable additional canonicalization
-                            tryCanonicalize(node);
+                        if (node instanceof ValueNode) {
+                            ValueNode valueNode = (ValueNode) node;
+                            if (tryInferStamp(valueNode)) {
+                                Constant constant = valueNode.stamp().asConstant();
+                                if (constant != null) {
+                                    performReplacement(valueNode, ConstantNode.forConstant(constant, runtime, valueNode.graph()));
+                                } else {
+                                    // the improved stamp may enable additional canonicalization
+                                    tryCanonicalize(valueNode);
+                                }
+                            }
                         }
                     }
                 }
@@ -296,15 +304,16 @@
 
         /**
          * Calls {@link ValueNode#inferStamp()} on the node and, if it returns true (which means
-         * that the stamp has changed), re-queues the node's usages.
+         * that the stamp has changed), re-queues the node's usages. If the stamp has changed then
+         * this method also checks if the stamp now describes a constant integer value, in which
+         * case the node is replaced with a constant.
          */
-        private boolean tryInferStamp(Node node) {
-            if (node.isAlive() && node instanceof ValueNode) {
-                ValueNode valueNode = (ValueNode) node;
+        private boolean tryInferStamp(ValueNode node) {
+            if (node.isAlive()) {
                 METRIC_INFER_STAMP_CALLED.increment();
-                if (valueNode.inferStamp()) {
+                if (node.inferStamp()) {
                     METRIC_STAMP_CHANGED.increment();
-                    for (Node usage : valueNode.usages()) {
+                    for (Node usage : node.usages()) {
                         workList.addAgain(usage);
                     }
                     return true;