Mercurial > hg > truffle

changeset 20503:fa56205f142c

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
8057799: Unnecessary NULL check in G1KeepAliveClosure Reviewed-by: tschatzl, stefank
author tonyp
date Wed, 10 Sep 2014 11:55:33 +0200
parents 13dbe89e447c
children 6948da6d7c13
files src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
diffstat 1 files changed, 2 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp	Fri Sep 26 20:09:02 2014 -0700
+++ b/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp	Wed Sep 10 11:55:33 2014 +0200
@@ -5358,9 +5358,10 @@
   void do_oop(narrowOop* p) { guarantee(false, "Not needed"); }
   void do_oop(oop* p) {
     oop obj = *p;
+    assert(obj != NULL, "the caller should have filtered out NULL values");
 
     G1CollectedHeap::in_cset_state_t cset_state = _g1->in_cset_state(obj);
-    if (obj == NULL || cset_state == G1CollectedHeap::InNeither) {
+    if (cset_state == G1CollectedHeap::InNeither) {
       return;
     }
     if (cset_state == G1CollectedHeap::InCSet) {