Mercurial > hg > graal-compiler
annotate src/share/vm/opto/loopnode.cpp @ 2445:08eb13460b3a
7004535: Clone loop predicate during loop unswitch
Summary: Clone loop predicate for clonned loops
Reviewed-by: never
| author | kvn |
|---|---|
| date | Sat, 02 Apr 2011 10:54:15 -0700 |
| parents | 1927db75dd85 |
| children | 3af54845df98 |
| rev | line source |
|---|---|
| 0 | 1 /* |
|
2248
194c9fdee631
7017240: C2: native memory leak in nsk/regression/b4675027 on windows-x86 in comp mode with G1
kvn
parents:
1972
diff
changeset
|
2 * Copyright (c) 1998, 2011, Oracle and/or its affiliates. All rights reserved. |
| 0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1172
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1172
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1172
diff
changeset
|
21 * questions. |
| 0 | 22 * |
| 23 */ | |
| 24 | |
| 1972 | 25 #include "precompiled.hpp" |
| 26 #include "ci/ciMethodData.hpp" | |
| 27 #include "compiler/compileLog.hpp" | |
| 28 #include "libadt/vectset.hpp" | |
| 29 #include "memory/allocation.inline.hpp" | |
| 30 #include "opto/addnode.hpp" | |
| 31 #include "opto/callnode.hpp" | |
| 32 #include "opto/connode.hpp" | |
| 33 #include "opto/divnode.hpp" | |
| 34 #include "opto/idealGraphPrinter.hpp" | |
| 35 #include "opto/loopnode.hpp" | |
| 36 #include "opto/mulnode.hpp" | |
| 37 #include "opto/rootnode.hpp" | |
| 38 #include "opto/superword.hpp" | |
| 0 | 39 |
| 40 //============================================================================= | |
| 41 //------------------------------is_loop_iv------------------------------------- | |
| 42 // Determine if a node is Counted loop induction variable. | |
| 43 // The method is declared in node.hpp. | |
| 44 const Node* Node::is_loop_iv() const { | |
| 45 if (this->is_Phi() && !this->as_Phi()->is_copy() && | |
| 46 this->as_Phi()->region()->is_CountedLoop() && | |
| 47 this->as_Phi()->region()->as_CountedLoop()->phi() == this) { | |
| 48 return this; | |
| 49 } else { | |
| 50 return NULL; | |
| 51 } | |
| 52 } | |
| 53 | |
| 54 //============================================================================= | |
| 55 //------------------------------dump_spec-------------------------------------- | |
| 56 // Dump special per-node info | |
| 57 #ifndef PRODUCT | |
| 58 void LoopNode::dump_spec(outputStream *st) const { | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
59 if (is_inner_loop()) st->print( "inner " ); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
60 if (is_partial_peel_loop()) st->print( "partial_peel " ); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
61 if (partial_peel_has_failed()) st->print( "partial_peel_failed " ); |
| 0 | 62 } |
| 63 #endif | |
| 64 | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
65 //------------------------------is_valid_counted_loop------------------------- |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
66 bool LoopNode::is_valid_counted_loop() const { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
67 if (is_CountedLoop()) { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
68 CountedLoopNode* l = as_CountedLoop(); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
69 CountedLoopEndNode* le = l->loopexit(); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
70 if (le != NULL && |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
71 le->proj_out(1 /* true */) == l->in(LoopNode::LoopBackControl)) { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
72 Node* phi = l->phi(); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
73 Node* exit = le->proj_out(0 /* false */); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
74 if (exit != NULL && exit->Opcode() == Op_IfFalse && |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
75 phi != NULL && phi->is_Phi() && |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
76 phi->in(LoopNode::LoopBackControl) == l->incr() && |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
77 le->loopnode() == l && le->stride_is_con()) { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
78 return true; |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
79 } |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
80 } |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
81 } |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
82 return false; |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
83 } |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
84 |
| 0 | 85 //------------------------------get_early_ctrl--------------------------------- |
| 86 // Compute earliest legal control | |
| 87 Node *PhaseIdealLoop::get_early_ctrl( Node *n ) { | |
| 88 assert( !n->is_Phi() && !n->is_CFG(), "this code only handles data nodes" ); | |
| 89 uint i; | |
| 90 Node *early; | |
| 91 if( n->in(0) ) { | |
| 92 early = n->in(0); | |
| 93 if( !early->is_CFG() ) // Might be a non-CFG multi-def | |
| 94 early = get_ctrl(early); // So treat input as a straight data input | |
| 95 i = 1; | |
| 96 } else { | |
| 97 early = get_ctrl(n->in(1)); | |
| 98 i = 2; | |
| 99 } | |
| 100 uint e_d = dom_depth(early); | |
| 101 assert( early, "" ); | |
| 102 for( ; i < n->req(); i++ ) { | |
| 103 Node *cin = get_ctrl(n->in(i)); | |
| 104 assert( cin, "" ); | |
| 105 // Keep deepest dominator depth | |
| 106 uint c_d = dom_depth(cin); | |
| 107 if( c_d > e_d ) { // Deeper guy? | |
| 108 early = cin; // Keep deepest found so far | |
| 109 e_d = c_d; | |
| 110 } else if( c_d == e_d && // Same depth? | |
| 111 early != cin ) { // If not equal, must use slower algorithm | |
| 112 // If same depth but not equal, one _must_ dominate the other | |
| 113 // and we want the deeper (i.e., dominated) guy. | |
| 114 Node *n1 = early; | |
| 115 Node *n2 = cin; | |
| 116 while( 1 ) { | |
| 117 n1 = idom(n1); // Walk up until break cycle | |
| 118 n2 = idom(n2); | |
| 119 if( n1 == cin || // Walked early up to cin | |
| 120 dom_depth(n2) < c_d ) | |
| 121 break; // early is deeper; keep him | |
| 122 if( n2 == early || // Walked cin up to early | |
| 123 dom_depth(n1) < c_d ) { | |
| 124 early = cin; // cin is deeper; keep him | |
| 125 break; | |
| 126 } | |
| 127 } | |
| 128 e_d = dom_depth(early); // Reset depth register cache | |
| 129 } | |
| 130 } | |
| 131 | |
| 132 // Return earliest legal location | |
| 133 assert(early == find_non_split_ctrl(early), "unexpected early control"); | |
| 134 | |
| 135 return early; | |
| 136 } | |
| 137 | |
| 138 //------------------------------set_early_ctrl--------------------------------- | |
| 139 // Set earliest legal control | |
| 140 void PhaseIdealLoop::set_early_ctrl( Node *n ) { | |
| 141 Node *early = get_early_ctrl(n); | |
| 142 | |
| 143 // Record earliest legal location | |
| 144 set_ctrl(n, early); | |
| 145 } | |
| 146 | |
| 147 //------------------------------set_subtree_ctrl------------------------------- | |
| 148 // set missing _ctrl entries on new nodes | |
| 149 void PhaseIdealLoop::set_subtree_ctrl( Node *n ) { | |
| 150 // Already set? Get out. | |
| 151 if( _nodes[n->_idx] ) return; | |
| 152 // Recursively set _nodes array to indicate where the Node goes | |
| 153 uint i; | |
| 154 for( i = 0; i < n->req(); ++i ) { | |
| 155 Node *m = n->in(i); | |
| 156 if( m && m != C->root() ) | |
| 157 set_subtree_ctrl( m ); | |
| 158 } | |
| 159 | |
| 160 // Fixup self | |
| 161 set_early_ctrl( n ); | |
| 162 } | |
| 163 | |
| 164 //------------------------------is_counted_loop-------------------------------- | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
165 bool PhaseIdealLoop::is_counted_loop( Node *x, IdealLoopTree *loop ) { |
| 0 | 166 PhaseGVN *gvn = &_igvn; |
| 167 | |
| 168 // Counted loop head must be a good RegionNode with only 3 not NULL | |
| 169 // control input edges: Self, Entry, LoopBack. | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
170 if (x->in(LoopNode::Self) == NULL || x->req() != 3) |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
171 return false; |
| 0 | 172 |
| 173 Node *init_control = x->in(LoopNode::EntryControl); | |
| 174 Node *back_control = x->in(LoopNode::LoopBackControl); | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
175 if (init_control == NULL || back_control == NULL) // Partially dead |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
176 return false; |
| 0 | 177 // Must also check for TOP when looking for a dead loop |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
178 if (init_control->is_top() || back_control->is_top()) |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
179 return false; |
| 0 | 180 |
| 181 // Allow funny placement of Safepoint | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
182 if (back_control->Opcode() == Op_SafePoint) |
| 0 | 183 back_control = back_control->in(TypeFunc::Control); |
| 184 | |
| 185 // Controlling test for loop | |
| 186 Node *iftrue = back_control; | |
| 187 uint iftrue_op = iftrue->Opcode(); | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
188 if (iftrue_op != Op_IfTrue && |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
189 iftrue_op != Op_IfFalse) |
| 0 | 190 // I have a weird back-control. Probably the loop-exit test is in |
| 191 // the middle of the loop and I am looking at some trailing control-flow | |
| 192 // merge point. To fix this I would have to partially peel the loop. | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
193 return false; // Obscure back-control |
| 0 | 194 |
| 195 // Get boolean guarding loop-back test | |
| 196 Node *iff = iftrue->in(0); | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
197 if (get_loop(iff) != loop || !iff->in(1)->is_Bool()) |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
198 return false; |
| 0 | 199 BoolNode *test = iff->in(1)->as_Bool(); |
| 200 BoolTest::mask bt = test->_test._test; | |
| 201 float cl_prob = iff->as_If()->_prob; | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
202 if (iftrue_op == Op_IfFalse) { |
| 0 | 203 bt = BoolTest(bt).negate(); |
| 204 cl_prob = 1.0 - cl_prob; | |
| 205 } | |
| 206 // Get backedge compare | |
| 207 Node *cmp = test->in(1); | |
| 208 int cmp_op = cmp->Opcode(); | |
| 209 if( cmp_op != Op_CmpI ) | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
210 return false; // Avoid pointer & float compares |
| 0 | 211 |
| 212 // Find the trip-counter increment & limit. Limit must be loop invariant. | |
| 213 Node *incr = cmp->in(1); | |
| 214 Node *limit = cmp->in(2); | |
| 215 | |
| 216 // --------- | |
| 217 // need 'loop()' test to tell if limit is loop invariant | |
| 218 // --------- | |
| 219 | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
220 if (!is_member(loop, get_ctrl(incr))) { // Swapped trip counter and limit? |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
221 Node *tmp = incr; // Then reverse order into the CmpI |
| 0 | 222 incr = limit; |
| 223 limit = tmp; | |
| 224 bt = BoolTest(bt).commute(); // And commute the exit test | |
| 225 } | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
226 if (is_member(loop, get_ctrl(limit))) // Limit must be loop-invariant |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
227 return false; |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
228 if (!is_member(loop, get_ctrl(incr))) // Trip counter must be loop-variant |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
229 return false; |
| 0 | 230 |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
231 Node* phi_incr = NULL; |
| 0 | 232 // Trip-counter increment must be commutative & associative. |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
233 if (incr->is_Phi()) { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
234 if (incr->as_Phi()->region() != x || incr->req() != 3) |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
235 return false; // Not simple trip counter expression |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
236 phi_incr = incr; |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
237 incr = phi_incr->in(LoopNode::LoopBackControl); // Assume incr is on backedge of Phi |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
238 if (!is_member(loop, get_ctrl(incr))) // Trip counter must be loop-variant |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
239 return false; |
| 0 | 240 } |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
241 |
| 0 | 242 Node* trunc1 = NULL; |
| 243 Node* trunc2 = NULL; | |
| 244 const TypeInt* iv_trunc_t = NULL; | |
| 245 if (!(incr = CountedLoopNode::match_incr_with_optional_truncation(incr, &trunc1, &trunc2, &iv_trunc_t))) { | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
246 return false; // Funny increment opcode |
| 0 | 247 } |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
248 assert(incr->Opcode() == Op_AddI, "wrong increment code"); |
| 0 | 249 |
| 250 // Get merge point | |
| 251 Node *xphi = incr->in(1); | |
| 252 Node *stride = incr->in(2); | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
253 if (!stride->is_Con()) { // Oops, swap these |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
254 if (!xphi->is_Con()) // Is the other guy a constant? |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
255 return false; // Nope, unknown stride, bail out |
| 0 | 256 Node *tmp = xphi; // 'incr' is commutative, so ok to swap |
| 257 xphi = stride; | |
| 258 stride = tmp; | |
| 259 } | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
260 // Stride must be constant |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
261 int stride_con = stride->get_int(); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
262 assert(stride_con != 0, "missed some peephole opt"); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
263 |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
264 if (!xphi->is_Phi()) |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
265 return false; // Too much math on the trip counter |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
266 if (phi_incr != NULL && phi_incr != xphi) |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
267 return false; |
| 0 | 268 PhiNode *phi = xphi->as_Phi(); |
| 269 | |
| 270 // Phi must be of loop header; backedge must wrap to increment | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
271 if (phi->region() != x) |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
272 return false; |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
273 if (trunc1 == NULL && phi->in(LoopNode::LoopBackControl) != incr || |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
274 trunc1 != NULL && phi->in(LoopNode::LoopBackControl) != trunc1) { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
275 return false; |
| 0 | 276 } |
| 277 Node *init_trip = phi->in(LoopNode::EntryControl); | |
| 278 | |
| 279 // If iv trunc type is smaller than int, check for possible wrap. | |
| 280 if (!TypeInt::INT->higher_equal(iv_trunc_t)) { | |
| 281 assert(trunc1 != NULL, "must have found some truncation"); | |
| 282 | |
| 283 // Get a better type for the phi (filtered thru if's) | |
| 284 const TypeInt* phi_ft = filtered_type(phi); | |
| 285 | |
| 286 // Can iv take on a value that will wrap? | |
| 287 // | |
| 288 // Ensure iv's limit is not within "stride" of the wrap value. | |
| 289 // | |
| 290 // Example for "short" type | |
| 291 // Truncation ensures value is in the range -32768..32767 (iv_trunc_t) | |
| 292 // If the stride is +10, then the last value of the induction | |
| 293 // variable before the increment (phi_ft->_hi) must be | |
| 294 // <= 32767 - 10 and (phi_ft->_lo) must be >= -32768 to | |
| 295 // ensure no truncation occurs after the increment. | |
| 296 | |
| 297 if (stride_con > 0) { | |
| 298 if (iv_trunc_t->_hi - phi_ft->_hi < stride_con || | |
| 299 iv_trunc_t->_lo > phi_ft->_lo) { | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
300 return false; // truncation may occur |
| 0 | 301 } |
| 302 } else if (stride_con < 0) { | |
| 303 if (iv_trunc_t->_lo - phi_ft->_lo > stride_con || | |
| 304 iv_trunc_t->_hi < phi_ft->_hi) { | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
305 return false; // truncation may occur |
| 0 | 306 } |
| 307 } | |
| 308 // No possibility of wrap so truncation can be discarded | |
| 309 // Promote iv type to Int | |
| 310 } else { | |
| 311 assert(trunc1 == NULL && trunc2 == NULL, "no truncation for int"); | |
| 312 } | |
| 313 | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
314 // If the condition is inverted and we will be rolling |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
315 // through MININT to MAXINT, then bail out. |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
316 if (bt == BoolTest::eq || // Bail out, but this loop trips at most twice! |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
317 // Odd stride |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
318 bt == BoolTest::ne && stride_con != 1 && stride_con != -1 || |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
319 // Count down loop rolls through MAXINT |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
320 (bt == BoolTest::le || bt == BoolTest::lt) && stride_con < 0 || |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
321 // Count up loop rolls through MININT |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
322 (bt == BoolTest::ge || bt == BoolTest::gt) && stride_con > 0 ) { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
323 return false; // Bail out |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
324 } |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
325 |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
326 const TypeInt* init_t = gvn->type(init_trip)->is_int(); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
327 const TypeInt* limit_t = gvn->type(limit)->is_int(); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
328 |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
329 if (stride_con > 0) { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
330 long init_p = (long)init_t->_lo + stride_con; |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
331 if (init_p > (long)max_jint || init_p > (long)limit_t->_hi) |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
332 return false; // cyclic loop or this loop trips only once |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
333 } else { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
334 long init_p = (long)init_t->_hi + stride_con; |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
335 if (init_p < (long)min_jint || init_p < (long)limit_t->_lo) |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
336 return false; // cyclic loop or this loop trips only once |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
337 } |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
338 |
| 0 | 339 // ================================================= |
| 340 // ---- SUCCESS! Found A Trip-Counted Loop! ----- | |
| 341 // | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
342 assert(x->Opcode() == Op_Loop, "regular loops only"); |
| 0 | 343 C->print_method("Before CountedLoop", 3); |
| 2445 | 344 #ifndef PRODUCT |
| 345 if (TraceLoopOpts) { | |
| 346 tty->print("Counted "); | |
| 347 loop->dump_head(); | |
| 348 } | |
| 349 #endif | |
| 0 | 350 // If compare points to incr, we are ok. Otherwise the compare |
| 351 // can directly point to the phi; in this case adjust the compare so that | |
| 605 | 352 // it points to the incr by adjusting the limit. |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
353 if (cmp->in(1) == phi || cmp->in(2) == phi) |
| 0 | 354 limit = gvn->transform(new (C, 3) AddINode(limit,stride)); |
| 355 | |
| 356 // trip-count for +-tive stride should be: (limit - init_trip + stride - 1)/stride. | |
| 357 // Final value for iterator should be: trip_count * stride + init_trip. | |
| 358 Node *one_p = gvn->intcon( 1); | |
| 359 Node *one_m = gvn->intcon(-1); | |
| 360 | |
| 361 Node *trip_count = NULL; | |
| 362 Node *hook = new (C, 6) Node(6); | |
| 363 switch( bt ) { | |
| 364 case BoolTest::eq: | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
365 ShouldNotReachHere(); |
| 0 | 366 case BoolTest::ne: // Ahh, the case we desire |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
367 if (stride_con == 1) |
| 0 | 368 trip_count = gvn->transform(new (C, 3) SubINode(limit,init_trip)); |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
369 else if (stride_con == -1) |
| 0 | 370 trip_count = gvn->transform(new (C, 3) SubINode(init_trip,limit)); |
| 371 else | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
372 ShouldNotReachHere(); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
373 set_subtree_ctrl(trip_count); |
| 0 | 374 //_loop.map(trip_count->_idx,loop(limit)); |
| 375 break; | |
| 376 case BoolTest::le: // Maybe convert to '<' case | |
| 377 limit = gvn->transform(new (C, 3) AddINode(limit,one_p)); | |
| 378 set_subtree_ctrl( limit ); | |
| 379 hook->init_req(4, limit); | |
| 380 | |
| 381 bt = BoolTest::lt; | |
| 382 // Make the new limit be in the same loop nest as the old limit | |
| 383 //_loop.map(limit->_idx,limit_loop); | |
| 384 // Fall into next case | |
| 385 case BoolTest::lt: { // Maybe convert to '!=' case | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
386 if (stride_con < 0) // Count down loop rolls through MAXINT |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
387 ShouldNotReachHere(); |
| 0 | 388 Node *range = gvn->transform(new (C, 3) SubINode(limit,init_trip)); |
| 389 set_subtree_ctrl( range ); | |
| 390 hook->init_req(0, range); | |
| 391 | |
| 392 Node *bias = gvn->transform(new (C, 3) AddINode(range,stride)); | |
| 393 set_subtree_ctrl( bias ); | |
| 394 hook->init_req(1, bias); | |
| 395 | |
| 396 Node *bias1 = gvn->transform(new (C, 3) AddINode(bias,one_m)); | |
| 397 set_subtree_ctrl( bias1 ); | |
| 398 hook->init_req(2, bias1); | |
| 399 | |
| 400 trip_count = gvn->transform(new (C, 3) DivINode(0,bias1,stride)); | |
| 401 set_subtree_ctrl( trip_count ); | |
| 402 hook->init_req(3, trip_count); | |
| 403 break; | |
| 404 } | |
| 405 | |
| 406 case BoolTest::ge: // Maybe convert to '>' case | |
| 407 limit = gvn->transform(new (C, 3) AddINode(limit,one_m)); | |
| 408 set_subtree_ctrl( limit ); | |
| 409 hook->init_req(4 ,limit); | |
| 410 | |
| 411 bt = BoolTest::gt; | |
| 412 // Make the new limit be in the same loop nest as the old limit | |
| 413 //_loop.map(limit->_idx,limit_loop); | |
| 414 // Fall into next case | |
| 415 case BoolTest::gt: { // Maybe convert to '!=' case | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
416 if (stride_con > 0) // count up loop rolls through MININT |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
417 ShouldNotReachHere(); |
| 0 | 418 Node *range = gvn->transform(new (C, 3) SubINode(limit,init_trip)); |
| 419 set_subtree_ctrl( range ); | |
| 420 hook->init_req(0, range); | |
| 421 | |
| 422 Node *bias = gvn->transform(new (C, 3) AddINode(range,stride)); | |
| 423 set_subtree_ctrl( bias ); | |
| 424 hook->init_req(1, bias); | |
| 425 | |
| 426 Node *bias1 = gvn->transform(new (C, 3) AddINode(bias,one_p)); | |
| 427 set_subtree_ctrl( bias1 ); | |
| 428 hook->init_req(2, bias1); | |
| 429 | |
| 430 trip_count = gvn->transform(new (C, 3) DivINode(0,bias1,stride)); | |
| 431 set_subtree_ctrl( trip_count ); | |
| 432 hook->init_req(3, trip_count); | |
| 433 break; | |
| 434 } | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
435 } // switch( bt ) |
| 0 | 436 |
| 437 Node *span = gvn->transform(new (C, 3) MulINode(trip_count,stride)); | |
| 438 set_subtree_ctrl( span ); | |
| 439 hook->init_req(5, span); | |
| 440 | |
| 441 limit = gvn->transform(new (C, 3) AddINode(span,init_trip)); | |
| 442 set_subtree_ctrl( limit ); | |
| 443 | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
444 // Check for SafePoint on backedge and remove |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
445 Node *sfpt = x->in(LoopNode::LoopBackControl); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
446 if (sfpt->Opcode() == Op_SafePoint && is_deleteable_safept(sfpt)) { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
447 lazy_replace( sfpt, iftrue ); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
448 loop->_tail = iftrue; |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
449 } |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
450 |
| 0 | 451 // Build a canonical trip test. |
| 452 // Clone code, as old values may be in use. | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
453 Node* nphi = PhiNode::make(x, init_trip, TypeInt::INT); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
454 nphi = _igvn.register_new_node_with_optimizer(nphi); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
455 set_ctrl(nphi, get_ctrl(phi)); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
456 |
| 0 | 457 incr = incr->clone(); |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
458 incr->set_req(1,nphi); |
| 0 | 459 incr->set_req(2,stride); |
| 460 incr = _igvn.register_new_node_with_optimizer(incr); | |
| 461 set_early_ctrl( incr ); | |
| 462 | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
463 nphi->set_req(LoopNode::LoopBackControl, incr); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
464 _igvn.replace_node(phi, nphi); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
465 phi = nphi->as_Phi(); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
466 |
| 0 | 467 cmp = cmp->clone(); |
| 468 cmp->set_req(1,incr); | |
| 469 cmp->set_req(2,limit); | |
| 470 cmp = _igvn.register_new_node_with_optimizer(cmp); | |
| 471 set_ctrl(cmp, iff->in(0)); | |
| 472 | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
473 test = test->clone()->as_Bool(); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
474 (*(BoolTest*)&test->_test)._test = bt; |
| 0 | 475 test->set_req(1,cmp); |
| 476 _igvn.register_new_node_with_optimizer(test); | |
| 477 set_ctrl(test, iff->in(0)); | |
| 478 | |
| 479 // Replace the old IfNode with a new LoopEndNode | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
480 Node *lex = _igvn.register_new_node_with_optimizer(new (C, 2) CountedLoopEndNode( iff->in(0), test, cl_prob, iff->as_If()->_fcnt )); |
| 0 | 481 IfNode *le = lex->as_If(); |
| 482 uint dd = dom_depth(iff); | |
| 483 set_idom(le, le->in(0), dd); // Update dominance for loop exit | |
| 484 set_loop(le, loop); | |
| 485 | |
| 486 // Get the loop-exit control | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
487 Node *iffalse = iff->as_If()->proj_out(!(iftrue_op == Op_IfTrue)); |
| 0 | 488 |
| 489 // Need to swap loop-exit and loop-back control? | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
490 if (iftrue_op == Op_IfFalse) { |
| 0 | 491 Node *ift2=_igvn.register_new_node_with_optimizer(new (C, 1) IfTrueNode (le)); |
| 492 Node *iff2=_igvn.register_new_node_with_optimizer(new (C, 1) IfFalseNode(le)); | |
| 493 | |
| 494 loop->_tail = back_control = ift2; | |
| 495 set_loop(ift2, loop); | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
496 set_loop(iff2, get_loop(iffalse)); |
| 0 | 497 |
| 498 // Lazy update of 'get_ctrl' mechanism. | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
499 lazy_replace_proj( iffalse, iff2 ); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
500 lazy_replace_proj( iftrue, ift2 ); |
| 0 | 501 |
| 502 // Swap names | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
503 iffalse = iff2; |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
504 iftrue = ift2; |
| 0 | 505 } else { |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
506 _igvn.hash_delete(iffalse); |
| 0 | 507 _igvn.hash_delete(iftrue); |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
508 iffalse->set_req_X( 0, le, &_igvn ); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
509 iftrue ->set_req_X( 0, le, &_igvn ); |
| 0 | 510 } |
| 511 | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
512 set_idom(iftrue, le, dd+1); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
513 set_idom(iffalse, le, dd+1); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
514 assert(iff->outcnt() == 0, "should be dead now"); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
515 lazy_replace( iff, le ); // fix 'get_ctrl' |
| 0 | 516 |
| 517 // Now setup a new CountedLoopNode to replace the existing LoopNode | |
| 518 CountedLoopNode *l = new (C, 3) CountedLoopNode(init_control, back_control); | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
519 l->set_unswitch_count(x->as_Loop()->unswitch_count()); // Preserve |
| 0 | 520 // The following assert is approximately true, and defines the intention |
| 521 // of can_be_counted_loop. It fails, however, because phase->type | |
| 522 // is not yet initialized for this loop and its parts. | |
| 523 //assert(l->can_be_counted_loop(this), "sanity"); | |
| 524 _igvn.register_new_node_with_optimizer(l); | |
| 525 set_loop(l, loop); | |
| 526 loop->_head = l; | |
| 527 // Fix all data nodes placed at the old loop head. | |
| 528 // Uses the lazy-update mechanism of 'get_ctrl'. | |
| 529 lazy_replace( x, l ); | |
| 530 set_idom(l, init_control, dom_depth(x)); | |
| 531 | |
| 605 | 532 // Check for immediately preceding SafePoint and remove |
| 0 | 533 Node *sfpt2 = le->in(0); |
| 534 if( sfpt2->Opcode() == Op_SafePoint && is_deleteable_safept(sfpt2)) | |
| 535 lazy_replace( sfpt2, sfpt2->in(TypeFunc::Control)); | |
| 536 | |
| 537 // Free up intermediate goo | |
| 538 _igvn.remove_dead_node(hook); | |
| 539 | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
540 #ifdef ASSERT |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
541 assert(l->is_valid_counted_loop(), "counted loop shape is messed up"); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
542 assert(l == loop->_head && l->phi() == phi && l->loopexit() == lex, "" ); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
543 #endif |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
544 |
| 0 | 545 C->print_method("After CountedLoop", 3); |
| 546 | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
547 return true; |
| 0 | 548 } |
| 549 | |
| 550 | |
| 551 //------------------------------Ideal------------------------------------------ | |
| 552 // Return a node which is more "ideal" than the current node. | |
| 553 // Attempt to convert into a counted-loop. | |
| 554 Node *LoopNode::Ideal(PhaseGVN *phase, bool can_reshape) { | |
| 555 if (!can_be_counted_loop(phase)) { | |
| 556 phase->C->set_major_progress(); | |
| 557 } | |
| 558 return RegionNode::Ideal(phase, can_reshape); | |
| 559 } | |
| 560 | |
| 561 | |
| 562 //============================================================================= | |
| 563 //------------------------------Ideal------------------------------------------ | |
| 564 // Return a node which is more "ideal" than the current node. | |
| 565 // Attempt to convert into a counted-loop. | |
| 566 Node *CountedLoopNode::Ideal(PhaseGVN *phase, bool can_reshape) { | |
| 567 return RegionNode::Ideal(phase, can_reshape); | |
| 568 } | |
| 569 | |
| 570 //------------------------------dump_spec-------------------------------------- | |
| 571 // Dump special per-node info | |
| 572 #ifndef PRODUCT | |
| 573 void CountedLoopNode::dump_spec(outputStream *st) const { | |
| 574 LoopNode::dump_spec(st); | |
| 575 if( stride_is_con() ) { | |
| 576 st->print("stride: %d ",stride_con()); | |
| 577 } else { | |
| 578 st->print("stride: not constant "); | |
| 579 } | |
| 580 if( is_pre_loop () ) st->print("pre of N%d" , _main_idx ); | |
| 581 if( is_main_loop() ) st->print("main of N%d", _idx ); | |
| 582 if( is_post_loop() ) st->print("post of N%d", _main_idx ); | |
| 583 } | |
| 584 #endif | |
| 585 | |
| 586 //============================================================================= | |
| 587 int CountedLoopEndNode::stride_con() const { | |
| 588 return stride()->bottom_type()->is_int()->get_con(); | |
| 589 } | |
| 590 | |
| 591 | |
| 592 //----------------------match_incr_with_optional_truncation-------------------- | |
| 593 // Match increment with optional truncation: | |
| 594 // CHAR: (i+1)&0x7fff, BYTE: ((i+1)<<8)>>8, or SHORT: ((i+1)<<16)>>16 | |
| 595 // Return NULL for failure. Success returns the increment node. | |
| 596 Node* CountedLoopNode::match_incr_with_optional_truncation( | |
| 597 Node* expr, Node** trunc1, Node** trunc2, const TypeInt** trunc_type) { | |
| 598 // Quick cutouts: | |
| 599 if (expr == NULL || expr->req() != 3) return false; | |
| 600 | |
| 601 Node *t1 = NULL; | |
| 602 Node *t2 = NULL; | |
| 603 const TypeInt* trunc_t = TypeInt::INT; | |
| 604 Node* n1 = expr; | |
| 605 int n1op = n1->Opcode(); | |
| 606 | |
| 607 // Try to strip (n1 & M) or (n1 << N >> N) from n1. | |
| 608 if (n1op == Op_AndI && | |
| 609 n1->in(2)->is_Con() && | |
| 610 n1->in(2)->bottom_type()->is_int()->get_con() == 0x7fff) { | |
| 611 // %%% This check should match any mask of 2**K-1. | |
| 612 t1 = n1; | |
| 613 n1 = t1->in(1); | |
| 614 n1op = n1->Opcode(); | |
| 615 trunc_t = TypeInt::CHAR; | |
| 616 } else if (n1op == Op_RShiftI && | |
| 617 n1->in(1) != NULL && | |
| 618 n1->in(1)->Opcode() == Op_LShiftI && | |
| 619 n1->in(2) == n1->in(1)->in(2) && | |
| 620 n1->in(2)->is_Con()) { | |
| 621 jint shift = n1->in(2)->bottom_type()->is_int()->get_con(); | |
| 622 // %%% This check should match any shift in [1..31]. | |
| 623 if (shift == 16 || shift == 8) { | |
| 624 t1 = n1; | |
| 625 t2 = t1->in(1); | |
| 626 n1 = t2->in(1); | |
| 627 n1op = n1->Opcode(); | |
| 628 if (shift == 16) { | |
| 629 trunc_t = TypeInt::SHORT; | |
| 630 } else if (shift == 8) { | |
| 631 trunc_t = TypeInt::BYTE; | |
| 632 } | |
| 633 } | |
| 634 } | |
| 635 | |
| 636 // If (maybe after stripping) it is an AddI, we won: | |
| 637 if (n1op == Op_AddI) { | |
| 638 *trunc1 = t1; | |
| 639 *trunc2 = t2; | |
| 640 *trunc_type = trunc_t; | |
| 641 return n1; | |
| 642 } | |
| 643 | |
| 644 // failed | |
| 645 return NULL; | |
| 646 } | |
| 647 | |
| 648 | |
| 649 //------------------------------filtered_type-------------------------------- | |
| 650 // Return a type based on condition control flow | |
| 651 // A successful return will be a type that is restricted due | |
| 652 // to a series of dominating if-tests, such as: | |
| 653 // if (i < 10) { | |
| 654 // if (i > 0) { | |
| 655 // here: "i" type is [1..10) | |
| 656 // } | |
| 657 // } | |
| 658 // or a control flow merge | |
| 659 // if (i < 10) { | |
| 660 // do { | |
| 661 // phi( , ) -- at top of loop type is [min_int..10) | |
| 662 // i = ? | |
| 663 // } while ( i < 10) | |
| 664 // | |
| 665 const TypeInt* PhaseIdealLoop::filtered_type( Node *n, Node* n_ctrl) { | |
| 666 assert(n && n->bottom_type()->is_int(), "must be int"); | |
| 667 const TypeInt* filtered_t = NULL; | |
| 668 if (!n->is_Phi()) { | |
| 669 assert(n_ctrl != NULL || n_ctrl == C->top(), "valid control"); | |
| 670 filtered_t = filtered_type_from_dominators(n, n_ctrl); | |
| 671 | |
| 672 } else { | |
| 673 Node* phi = n->as_Phi(); | |
| 674 Node* region = phi->in(0); | |
| 675 assert(n_ctrl == NULL || n_ctrl == region, "ctrl parameter must be region"); | |
| 676 if (region && region != C->top()) { | |
| 677 for (uint i = 1; i < phi->req(); i++) { | |
| 678 Node* val = phi->in(i); | |
| 679 Node* use_c = region->in(i); | |
| 680 const TypeInt* val_t = filtered_type_from_dominators(val, use_c); | |
| 681 if (val_t != NULL) { | |
| 682 if (filtered_t == NULL) { | |
| 683 filtered_t = val_t; | |
| 684 } else { | |
| 685 filtered_t = filtered_t->meet(val_t)->is_int(); | |
| 686 } | |
| 687 } | |
| 688 } | |
| 689 } | |
| 690 } | |
| 691 const TypeInt* n_t = _igvn.type(n)->is_int(); | |
| 692 if (filtered_t != NULL) { | |
| 693 n_t = n_t->join(filtered_t)->is_int(); | |
| 694 } | |
| 695 return n_t; | |
| 696 } | |
| 697 | |
| 698 | |
| 699 //------------------------------filtered_type_from_dominators-------------------------------- | |
| 700 // Return a possibly more restrictive type for val based on condition control flow of dominators | |
| 701 const TypeInt* PhaseIdealLoop::filtered_type_from_dominators( Node* val, Node *use_ctrl) { | |
| 702 if (val->is_Con()) { | |
| 703 return val->bottom_type()->is_int(); | |
| 704 } | |
| 705 uint if_limit = 10; // Max number of dominating if's visited | |
| 706 const TypeInt* rtn_t = NULL; | |
| 707 | |
| 708 if (use_ctrl && use_ctrl != C->top()) { | |
| 709 Node* val_ctrl = get_ctrl(val); | |
| 710 uint val_dom_depth = dom_depth(val_ctrl); | |
| 711 Node* pred = use_ctrl; | |
| 712 uint if_cnt = 0; | |
| 713 while (if_cnt < if_limit) { | |
| 714 if ((pred->Opcode() == Op_IfTrue || pred->Opcode() == Op_IfFalse)) { | |
| 715 if_cnt++; | |
|
17
ff5961f4c095
6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents:
0
diff
changeset
|
716 const TypeInt* if_t = IfNode::filtered_int_type(&_igvn, val, pred); |
| 0 | 717 if (if_t != NULL) { |
| 718 if (rtn_t == NULL) { | |
| 719 rtn_t = if_t; | |
| 720 } else { | |
| 721 rtn_t = rtn_t->join(if_t)->is_int(); | |
| 722 } | |
| 723 } | |
| 724 } | |
| 725 pred = idom(pred); | |
| 726 if (pred == NULL || pred == C->top()) { | |
| 727 break; | |
| 728 } | |
| 729 // Stop if going beyond definition block of val | |
| 730 if (dom_depth(pred) < val_dom_depth) { | |
| 731 break; | |
| 732 } | |
| 733 } | |
| 734 } | |
| 735 return rtn_t; | |
| 736 } | |
| 737 | |
| 738 | |
| 739 //------------------------------dump_spec-------------------------------------- | |
| 740 // Dump special per-node info | |
| 741 #ifndef PRODUCT | |
| 742 void CountedLoopEndNode::dump_spec(outputStream *st) const { | |
| 743 if( in(TestValue)->is_Bool() ) { | |
| 744 BoolTest bt( test_trip()); // Added this for g++. | |
| 745 | |
| 746 st->print("["); | |
| 747 bt.dump_on(st); | |
| 748 st->print("]"); | |
| 749 } | |
| 750 st->print(" "); | |
| 751 IfNode::dump_spec(st); | |
| 752 } | |
| 753 #endif | |
| 754 | |
| 755 //============================================================================= | |
| 756 //------------------------------is_member-------------------------------------- | |
| 757 // Is 'l' a member of 'this'? | |
| 758 int IdealLoopTree::is_member( const IdealLoopTree *l ) const { | |
| 759 while( l->_nest > _nest ) l = l->_parent; | |
| 760 return l == this; | |
| 761 } | |
| 762 | |
| 763 //------------------------------set_nest--------------------------------------- | |
| 764 // Set loop tree nesting depth. Accumulate _has_call bits. | |
| 765 int IdealLoopTree::set_nest( uint depth ) { | |
| 766 _nest = depth; | |
| 767 int bits = _has_call; | |
| 768 if( _child ) bits |= _child->set_nest(depth+1); | |
| 769 if( bits ) _has_call = 1; | |
| 770 if( _next ) bits |= _next ->set_nest(depth ); | |
| 771 return bits; | |
| 772 } | |
| 773 | |
| 774 //------------------------------split_fall_in---------------------------------- | |
| 775 // Split out multiple fall-in edges from the loop header. Move them to a | |
| 776 // private RegionNode before the loop. This becomes the loop landing pad. | |
| 777 void IdealLoopTree::split_fall_in( PhaseIdealLoop *phase, int fall_in_cnt ) { | |
| 778 PhaseIterGVN &igvn = phase->_igvn; | |
| 779 uint i; | |
| 780 | |
| 781 // Make a new RegionNode to be the landing pad. | |
| 782 Node *landing_pad = new (phase->C, fall_in_cnt+1) RegionNode( fall_in_cnt+1 ); | |
| 783 phase->set_loop(landing_pad,_parent); | |
| 784 // Gather all the fall-in control paths into the landing pad | |
| 785 uint icnt = fall_in_cnt; | |
| 786 uint oreq = _head->req(); | |
| 787 for( i = oreq-1; i>0; i-- ) | |
| 788 if( !phase->is_member( this, _head->in(i) ) ) | |
| 789 landing_pad->set_req(icnt--,_head->in(i)); | |
| 790 | |
| 791 // Peel off PhiNode edges as well | |
| 792 for (DUIterator_Fast jmax, j = _head->fast_outs(jmax); j < jmax; j++) { | |
| 793 Node *oj = _head->fast_out(j); | |
| 794 if( oj->is_Phi() ) { | |
| 795 PhiNode* old_phi = oj->as_Phi(); | |
| 796 assert( old_phi->region() == _head, "" ); | |
| 797 igvn.hash_delete(old_phi); // Yank from hash before hacking edges | |
| 798 Node *p = PhiNode::make_blank(landing_pad, old_phi); | |
| 799 uint icnt = fall_in_cnt; | |
| 800 for( i = oreq-1; i>0; i-- ) { | |
| 801 if( !phase->is_member( this, _head->in(i) ) ) { | |
| 802 p->init_req(icnt--, old_phi->in(i)); | |
| 803 // Go ahead and clean out old edges from old phi | |
| 804 old_phi->del_req(i); | |
| 805 } | |
| 806 } | |
| 807 // Search for CSE's here, because ZKM.jar does a lot of | |
| 808 // loop hackery and we need to be a little incremental | |
| 809 // with the CSE to avoid O(N^2) node blow-up. | |
| 810 Node *p2 = igvn.hash_find_insert(p); // Look for a CSE | |
| 811 if( p2 ) { // Found CSE | |
| 812 p->destruct(); // Recover useless new node | |
| 813 p = p2; // Use old node | |
| 814 } else { | |
| 815 igvn.register_new_node_with_optimizer(p, old_phi); | |
| 816 } | |
| 817 // Make old Phi refer to new Phi. | |
| 818 old_phi->add_req(p); | |
| 819 // Check for the special case of making the old phi useless and | |
| 820 // disappear it. In JavaGrande I have a case where this useless | |
| 821 // Phi is the loop limit and prevents recognizing a CountedLoop | |
| 822 // which in turn prevents removing an empty loop. | |
| 823 Node *id_old_phi = old_phi->Identity( &igvn ); | |
| 824 if( id_old_phi != old_phi ) { // Found a simple identity? | |
|
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
825 // Note that I cannot call 'replace_node' here, because |
| 0 | 826 // that will yank the edge from old_phi to the Region and |
| 827 // I'm mid-iteration over the Region's uses. | |
| 828 for (DUIterator_Last imin, i = old_phi->last_outs(imin); i >= imin; ) { | |
| 829 Node* use = old_phi->last_out(i); | |
| 830 igvn.hash_delete(use); | |
| 831 igvn._worklist.push(use); | |
| 832 uint uses_found = 0; | |
| 833 for (uint j = 0; j < use->len(); j++) { | |
| 834 if (use->in(j) == old_phi) { | |
| 835 if (j < use->req()) use->set_req (j, id_old_phi); | |
| 836 else use->set_prec(j, id_old_phi); | |
| 837 uses_found++; | |
| 838 } | |
| 839 } | |
| 840 i -= uses_found; // we deleted 1 or more copies of this edge | |
| 841 } | |
| 842 } | |
| 843 igvn._worklist.push(old_phi); | |
| 844 } | |
| 845 } | |
| 846 // Finally clean out the fall-in edges from the RegionNode | |
| 847 for( i = oreq-1; i>0; i-- ) { | |
| 848 if( !phase->is_member( this, _head->in(i) ) ) { | |
| 849 _head->del_req(i); | |
| 850 } | |
| 851 } | |
| 852 // Transform landing pad | |
| 853 igvn.register_new_node_with_optimizer(landing_pad, _head); | |
| 854 // Insert landing pad into the header | |
| 855 _head->add_req(landing_pad); | |
| 856 } | |
| 857 | |
| 858 //------------------------------split_outer_loop------------------------------- | |
| 859 // Split out the outermost loop from this shared header. | |
| 860 void IdealLoopTree::split_outer_loop( PhaseIdealLoop *phase ) { | |
| 861 PhaseIterGVN &igvn = phase->_igvn; | |
| 862 | |
| 863 // Find index of outermost loop; it should also be my tail. | |
| 864 uint outer_idx = 1; | |
| 865 while( _head->in(outer_idx) != _tail ) outer_idx++; | |
| 866 | |
| 867 // Make a LoopNode for the outermost loop. | |
| 868 Node *ctl = _head->in(LoopNode::EntryControl); | |
| 869 Node *outer = new (phase->C, 3) LoopNode( ctl, _head->in(outer_idx) ); | |
| 870 outer = igvn.register_new_node_with_optimizer(outer, _head); | |
| 871 phase->set_created_loop_node(); | |
| 2445 | 872 |
| 873 Node* pred = phase->clone_loop_predicates(ctl, outer); | |
| 0 | 874 // Outermost loop falls into '_head' loop |
| 2445 | 875 _head->set_req(LoopNode::EntryControl, pred); |
| 0 | 876 _head->del_req(outer_idx); |
| 877 // Split all the Phis up between '_head' loop and 'outer' loop. | |
| 878 for (DUIterator_Fast jmax, j = _head->fast_outs(jmax); j < jmax; j++) { | |
| 879 Node *out = _head->fast_out(j); | |
| 880 if( out->is_Phi() ) { | |
| 881 PhiNode *old_phi = out->as_Phi(); | |
| 882 assert( old_phi->region() == _head, "" ); | |
| 883 Node *phi = PhiNode::make_blank(outer, old_phi); | |
| 884 phi->init_req(LoopNode::EntryControl, old_phi->in(LoopNode::EntryControl)); | |
| 885 phi->init_req(LoopNode::LoopBackControl, old_phi->in(outer_idx)); | |
| 886 phi = igvn.register_new_node_with_optimizer(phi, old_phi); | |
| 887 // Make old Phi point to new Phi on the fall-in path | |
| 888 igvn.hash_delete(old_phi); | |
| 889 old_phi->set_req(LoopNode::EntryControl, phi); | |
| 890 old_phi->del_req(outer_idx); | |
| 891 igvn._worklist.push(old_phi); | |
| 892 } | |
| 893 } | |
| 894 | |
| 895 // Use the new loop head instead of the old shared one | |
| 896 _head = outer; | |
| 897 phase->set_loop(_head, this); | |
| 898 } | |
| 899 | |
| 900 //------------------------------fix_parent------------------------------------- | |
| 901 static void fix_parent( IdealLoopTree *loop, IdealLoopTree *parent ) { | |
| 902 loop->_parent = parent; | |
| 903 if( loop->_child ) fix_parent( loop->_child, loop ); | |
| 904 if( loop->_next ) fix_parent( loop->_next , parent ); | |
| 905 } | |
| 906 | |
| 907 //------------------------------estimate_path_freq----------------------------- | |
| 908 static float estimate_path_freq( Node *n ) { | |
| 909 // Try to extract some path frequency info | |
| 910 IfNode *iff; | |
| 911 for( int i = 0; i < 50; i++ ) { // Skip through a bunch of uncommon tests | |
| 912 uint nop = n->Opcode(); | |
| 913 if( nop == Op_SafePoint ) { // Skip any safepoint | |
| 914 n = n->in(0); | |
| 915 continue; | |
| 916 } | |
| 917 if( nop == Op_CatchProj ) { // Get count from a prior call | |
| 918 // Assume call does not always throw exceptions: means the call-site | |
| 919 // count is also the frequency of the fall-through path. | |
| 920 assert( n->is_CatchProj(), "" ); | |
| 921 if( ((CatchProjNode*)n)->_con != CatchProjNode::fall_through_index ) | |
| 922 return 0.0f; // Assume call exception path is rare | |
| 923 Node *call = n->in(0)->in(0)->in(0); | |
| 924 assert( call->is_Call(), "expect a call here" ); | |
| 925 const JVMState *jvms = ((CallNode*)call)->jvms(); | |
| 926 ciMethodData* methodData = jvms->method()->method_data(); | |
| 927 if (!methodData->is_mature()) return 0.0f; // No call-site data | |
| 928 ciProfileData* data = methodData->bci_to_data(jvms->bci()); | |
| 929 if ((data == NULL) || !data->is_CounterData()) { | |
| 930 // no call profile available, try call's control input | |
| 931 n = n->in(0); | |
| 932 continue; | |
| 933 } | |
| 934 return data->as_CounterData()->count()/FreqCountInvocations; | |
| 935 } | |
| 936 // See if there's a gating IF test | |
| 937 Node *n_c = n->in(0); | |
| 938 if( !n_c->is_If() ) break; // No estimate available | |
| 939 iff = n_c->as_If(); | |
| 940 if( iff->_fcnt != COUNT_UNKNOWN ) // Have a valid count? | |
| 941 // Compute how much count comes on this path | |
| 942 return ((nop == Op_IfTrue) ? iff->_prob : 1.0f - iff->_prob) * iff->_fcnt; | |
| 943 // Have no count info. Skip dull uncommon-trap like branches. | |
| 944 if( (nop == Op_IfTrue && iff->_prob < PROB_LIKELY_MAG(5)) || | |
| 945 (nop == Op_IfFalse && iff->_prob > PROB_UNLIKELY_MAG(5)) ) | |
| 946 break; | |
| 947 // Skip through never-taken branch; look for a real loop exit. | |
| 948 n = iff->in(0); | |
| 949 } | |
| 950 return 0.0f; // No estimate available | |
| 951 } | |
| 952 | |
| 953 //------------------------------merge_many_backedges--------------------------- | |
| 954 // Merge all the backedges from the shared header into a private Region. | |
| 955 // Feed that region as the one backedge to this loop. | |
| 956 void IdealLoopTree::merge_many_backedges( PhaseIdealLoop *phase ) { | |
| 957 uint i; | |
| 958 | |
| 959 // Scan for the top 2 hottest backedges | |
| 960 float hotcnt = 0.0f; | |
| 961 float warmcnt = 0.0f; | |
| 962 uint hot_idx = 0; | |
| 963 // Loop starts at 2 because slot 1 is the fall-in path | |
| 964 for( i = 2; i < _head->req(); i++ ) { | |
| 965 float cnt = estimate_path_freq(_head->in(i)); | |
| 966 if( cnt > hotcnt ) { // Grab hottest path | |
| 967 warmcnt = hotcnt; | |
| 968 hotcnt = cnt; | |
| 969 hot_idx = i; | |
| 970 } else if( cnt > warmcnt ) { // And 2nd hottest path | |
| 971 warmcnt = cnt; | |
| 972 } | |
| 973 } | |
| 974 | |
| 975 // See if the hottest backedge is worthy of being an inner loop | |
| 976 // by being much hotter than the next hottest backedge. | |
| 977 if( hotcnt <= 0.0001 || | |
| 978 hotcnt < 2.0*warmcnt ) hot_idx = 0;// No hot backedge | |
| 979 | |
| 980 // Peel out the backedges into a private merge point; peel | |
| 981 // them all except optionally hot_idx. | |
| 982 PhaseIterGVN &igvn = phase->_igvn; | |
| 983 | |
| 984 Node *hot_tail = NULL; | |
| 985 // Make a Region for the merge point | |
| 986 Node *r = new (phase->C, 1) RegionNode(1); | |
| 987 for( i = 2; i < _head->req(); i++ ) { | |
| 988 if( i != hot_idx ) | |
| 989 r->add_req( _head->in(i) ); | |
| 990 else hot_tail = _head->in(i); | |
| 991 } | |
| 992 igvn.register_new_node_with_optimizer(r, _head); | |
| 993 // Plug region into end of loop _head, followed by hot_tail | |
| 994 while( _head->req() > 3 ) _head->del_req( _head->req()-1 ); | |
| 995 _head->set_req(2, r); | |
| 996 if( hot_idx ) _head->add_req(hot_tail); | |
| 997 | |
| 998 // Split all the Phis up between '_head' loop and the Region 'r' | |
| 999 for (DUIterator_Fast jmax, j = _head->fast_outs(jmax); j < jmax; j++) { | |
| 1000 Node *out = _head->fast_out(j); | |
| 1001 if( out->is_Phi() ) { | |
| 1002 PhiNode* n = out->as_Phi(); | |
| 1003 igvn.hash_delete(n); // Delete from hash before hacking edges | |
| 1004 Node *hot_phi = NULL; | |
| 1005 Node *phi = new (phase->C, r->req()) PhiNode(r, n->type(), n->adr_type()); | |
| 1006 // Check all inputs for the ones to peel out | |
| 1007 uint j = 1; | |
| 1008 for( uint i = 2; i < n->req(); i++ ) { | |
| 1009 if( i != hot_idx ) | |
| 1010 phi->set_req( j++, n->in(i) ); | |
| 1011 else hot_phi = n->in(i); | |
| 1012 } | |
| 1013 // Register the phi but do not transform until whole place transforms | |
| 1014 igvn.register_new_node_with_optimizer(phi, n); | |
| 1015 // Add the merge phi to the old Phi | |
| 1016 while( n->req() > 3 ) n->del_req( n->req()-1 ); | |
| 1017 n->set_req(2, phi); | |
| 1018 if( hot_idx ) n->add_req(hot_phi); | |
| 1019 } | |
| 1020 } | |
| 1021 | |
| 1022 | |
| 1023 // Insert a new IdealLoopTree inserted below me. Turn it into a clone | |
| 1024 // of self loop tree. Turn self into a loop headed by _head and with | |
| 1025 // tail being the new merge point. | |
| 1026 IdealLoopTree *ilt = new IdealLoopTree( phase, _head, _tail ); | |
| 1027 phase->set_loop(_tail,ilt); // Adjust tail | |
| 1028 _tail = r; // Self's tail is new merge point | |
| 1029 phase->set_loop(r,this); | |
| 1030 ilt->_child = _child; // New guy has my children | |
| 1031 _child = ilt; // Self has new guy as only child | |
| 1032 ilt->_parent = this; // new guy has self for parent | |
| 1033 ilt->_nest = _nest; // Same nesting depth (for now) | |
| 1034 | |
| 1035 // Starting with 'ilt', look for child loop trees using the same shared | |
| 1036 // header. Flatten these out; they will no longer be loops in the end. | |
| 1037 IdealLoopTree **pilt = &_child; | |
| 1038 while( ilt ) { | |
| 1039 if( ilt->_head == _head ) { | |
| 1040 uint i; | |
| 1041 for( i = 2; i < _head->req(); i++ ) | |
| 1042 if( _head->in(i) == ilt->_tail ) | |
| 1043 break; // Still a loop | |
| 1044 if( i == _head->req() ) { // No longer a loop | |
| 1045 // Flatten ilt. Hang ilt's "_next" list from the end of | |
| 1046 // ilt's '_child' list. Move the ilt's _child up to replace ilt. | |
| 1047 IdealLoopTree **cp = &ilt->_child; | |
| 1048 while( *cp ) cp = &(*cp)->_next; // Find end of child list | |
| 1049 *cp = ilt->_next; // Hang next list at end of child list | |
| 1050 *pilt = ilt->_child; // Move child up to replace ilt | |
| 1051 ilt->_head = NULL; // Flag as a loop UNIONED into parent | |
| 1052 ilt = ilt->_child; // Repeat using new ilt | |
| 1053 continue; // do not advance over ilt->_child | |
| 1054 } | |
| 1055 assert( ilt->_tail == hot_tail, "expected to only find the hot inner loop here" ); | |
| 1056 phase->set_loop(_head,ilt); | |
| 1057 } | |
| 1058 pilt = &ilt->_child; // Advance to next | |
| 1059 ilt = *pilt; | |
| 1060 } | |
| 1061 | |
| 1062 if( _child ) fix_parent( _child, this ); | |
| 1063 } | |
| 1064 | |
| 1065 //------------------------------beautify_loops--------------------------------- | |
| 1066 // Split shared headers and insert loop landing pads. | |
| 1067 // Insert a LoopNode to replace the RegionNode. | |
| 1068 // Return TRUE if loop tree is structurally changed. | |
| 1069 bool IdealLoopTree::beautify_loops( PhaseIdealLoop *phase ) { | |
| 1070 bool result = false; | |
| 1071 // Cache parts in locals for easy | |
| 1072 PhaseIterGVN &igvn = phase->_igvn; | |
| 1073 | |
| 1074 igvn.hash_delete(_head); // Yank from hash before hacking edges | |
| 1075 | |
| 1076 // Check for multiple fall-in paths. Peel off a landing pad if need be. | |
| 1077 int fall_in_cnt = 0; | |
| 1078 for( uint i = 1; i < _head->req(); i++ ) | |
| 1079 if( !phase->is_member( this, _head->in(i) ) ) | |
| 1080 fall_in_cnt++; | |
| 1081 assert( fall_in_cnt, "at least 1 fall-in path" ); | |
| 1082 if( fall_in_cnt > 1 ) // Need a loop landing pad to merge fall-ins | |
| 1083 split_fall_in( phase, fall_in_cnt ); | |
| 1084 | |
| 1085 // Swap inputs to the _head and all Phis to move the fall-in edge to | |
| 1086 // the left. | |
| 1087 fall_in_cnt = 1; | |
| 1088 while( phase->is_member( this, _head->in(fall_in_cnt) ) ) | |
| 1089 fall_in_cnt++; | |
| 1090 if( fall_in_cnt > 1 ) { | |
| 1091 // Since I am just swapping inputs I do not need to update def-use info | |
| 1092 Node *tmp = _head->in(1); | |
| 1093 _head->set_req( 1, _head->in(fall_in_cnt) ); | |
| 1094 _head->set_req( fall_in_cnt, tmp ); | |
| 1095 // Swap also all Phis | |
| 1096 for (DUIterator_Fast imax, i = _head->fast_outs(imax); i < imax; i++) { | |
| 1097 Node* phi = _head->fast_out(i); | |
| 1098 if( phi->is_Phi() ) { | |
| 1099 igvn.hash_delete(phi); // Yank from hash before hacking edges | |
| 1100 tmp = phi->in(1); | |
| 1101 phi->set_req( 1, phi->in(fall_in_cnt) ); | |
| 1102 phi->set_req( fall_in_cnt, tmp ); | |
| 1103 } | |
| 1104 } | |
| 1105 } | |
| 1106 assert( !phase->is_member( this, _head->in(1) ), "left edge is fall-in" ); | |
| 1107 assert( phase->is_member( this, _head->in(2) ), "right edge is loop" ); | |
| 1108 | |
| 1109 // If I am a shared header (multiple backedges), peel off the many | |
| 1110 // backedges into a private merge point and use the merge point as | |
| 1111 // the one true backedge. | |
| 1112 if( _head->req() > 3 ) { | |
| 2445 | 1113 // Merge the many backedges into a single backedge but leave |
| 1114 // the hottest backedge as separate edge for the following peel. | |
| 0 | 1115 merge_many_backedges( phase ); |
| 1116 result = true; | |
| 1117 } | |
| 1118 | |
| 2445 | 1119 // If I have one hot backedge, peel off myself loop. |
| 0 | 1120 // I better be the outermost loop. |
| 1121 if( _head->req() > 3 ) { | |
| 1122 split_outer_loop( phase ); | |
| 1123 result = true; | |
| 1124 | |
| 1125 } else if( !_head->is_Loop() && !_irreducible ) { | |
| 1126 // Make a new LoopNode to replace the old loop head | |
| 1127 Node *l = new (phase->C, 3) LoopNode( _head->in(1), _head->in(2) ); | |
| 1128 l = igvn.register_new_node_with_optimizer(l, _head); | |
| 1129 phase->set_created_loop_node(); | |
| 1130 // Go ahead and replace _head | |
|
1621
6027dddc26c6
6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents:
1552
diff
changeset
|
1131 phase->_igvn.replace_node( _head, l ); |
| 0 | 1132 _head = l; |
| 1133 phase->set_loop(_head, this); | |
| 1134 } | |
| 1135 | |
| 1136 // Now recursively beautify nested loops | |
| 1137 if( _child ) result |= _child->beautify_loops( phase ); | |
| 1138 if( _next ) result |= _next ->beautify_loops( phase ); | |
| 1139 return result; | |
| 1140 } | |
| 1141 | |
| 1142 //------------------------------allpaths_check_safepts---------------------------- | |
| 1143 // Allpaths backwards scan from loop tail, terminating each path at first safepoint | |
| 1144 // encountered. Helper for check_safepts. | |
| 1145 void IdealLoopTree::allpaths_check_safepts(VectorSet &visited, Node_List &stack) { | |
| 1146 assert(stack.size() == 0, "empty stack"); | |
| 1147 stack.push(_tail); | |
| 1148 visited.Clear(); | |
| 1149 visited.set(_tail->_idx); | |
| 1150 while (stack.size() > 0) { | |
| 1151 Node* n = stack.pop(); | |
| 1152 if (n->is_Call() && n->as_Call()->guaranteed_safepoint()) { | |
| 1153 // Terminate this path | |
| 1154 } else if (n->Opcode() == Op_SafePoint) { | |
| 1155 if (_phase->get_loop(n) != this) { | |
| 1156 if (_required_safept == NULL) _required_safept = new Node_List(); | |
| 1157 _required_safept->push(n); // save the one closest to the tail | |
| 1158 } | |
| 1159 // Terminate this path | |
| 1160 } else { | |
| 1161 uint start = n->is_Region() ? 1 : 0; | |
| 1162 uint end = n->is_Region() && !n->is_Loop() ? n->req() : start + 1; | |
| 1163 for (uint i = start; i < end; i++) { | |
| 1164 Node* in = n->in(i); | |
| 1165 assert(in->is_CFG(), "must be"); | |
| 1166 if (!visited.test_set(in->_idx) && is_member(_phase->get_loop(in))) { | |
| 1167 stack.push(in); | |
| 1168 } | |
| 1169 } | |
| 1170 } | |
| 1171 } | |
| 1172 } | |
| 1173 | |
| 1174 //------------------------------check_safepts---------------------------- | |
| 1175 // Given dominators, try to find loops with calls that must always be | |
| 1176 // executed (call dominates loop tail). These loops do not need non-call | |
| 1177 // safepoints (ncsfpt). | |
| 1178 // | |
| 1179 // A complication is that a safepoint in a inner loop may be needed | |
| 1180 // by an outer loop. In the following, the inner loop sees it has a | |
| 1181 // call (block 3) on every path from the head (block 2) to the | |
| 1182 // backedge (arc 3->2). So it deletes the ncsfpt (non-call safepoint) | |
| 1183 // in block 2, _but_ this leaves the outer loop without a safepoint. | |
| 1184 // | |
| 1185 // entry 0 | |
| 1186 // | | |
| 1187 // v | |
| 1188 // outer 1,2 +->1 | |
| 1189 // | | | |
| 1190 // | v | |
| 1191 // | 2<---+ ncsfpt in 2 | |
| 1192 // |_/|\ | | |
| 1193 // | v | | |
| 1194 // inner 2,3 / 3 | call in 3 | |
| 1195 // / | | | |
| 1196 // v +--+ | |
| 1197 // exit 4 | |
| 1198 // | |
| 1199 // | |
| 1200 // This method creates a list (_required_safept) of ncsfpt nodes that must | |
| 1201 // be protected is created for each loop. When a ncsfpt maybe deleted, it | |
| 1202 // is first looked for in the lists for the outer loops of the current loop. | |
| 1203 // | |
| 1204 // The insights into the problem: | |
| 1205 // A) counted loops are okay | |
| 1206 // B) innermost loops are okay (only an inner loop can delete | |
| 1207 // a ncsfpt needed by an outer loop) | |
| 1208 // C) a loop is immune from an inner loop deleting a safepoint | |
| 1209 // if the loop has a call on the idom-path | |
| 1210 // D) a loop is also immune if it has a ncsfpt (non-call safepoint) on the | |
| 1211 // idom-path that is not in a nested loop | |
| 1212 // E) otherwise, an ncsfpt on the idom-path that is nested in an inner | |
| 1213 // loop needs to be prevented from deletion by an inner loop | |
| 1214 // | |
| 1215 // There are two analyses: | |
| 1216 // 1) The first, and cheaper one, scans the loop body from | |
| 1217 // tail to head following the idom (immediate dominator) | |
| 1218 // chain, looking for the cases (C,D,E) above. | |
| 1219 // Since inner loops are scanned before outer loops, there is summary | |
| 1220 // information about inner loops. Inner loops can be skipped over | |
| 1221 // when the tail of an inner loop is encountered. | |
| 1222 // | |
| 1223 // 2) The second, invoked if the first fails to find a call or ncsfpt on | |
| 1224 // the idom path (which is rare), scans all predecessor control paths | |
| 1225 // from the tail to the head, terminating a path when a call or sfpt | |
| 1226 // is encountered, to find the ncsfpt's that are closest to the tail. | |
| 1227 // | |
| 1228 void IdealLoopTree::check_safepts(VectorSet &visited, Node_List &stack) { | |
| 1229 // Bottom up traversal | |
| 1230 IdealLoopTree* ch = _child; | |
| 1231 while (ch != NULL) { | |
| 1232 ch->check_safepts(visited, stack); | |
| 1233 ch = ch->_next; | |
| 1234 } | |
| 1235 | |
| 1236 if (!_head->is_CountedLoop() && !_has_sfpt && _parent != NULL && !_irreducible) { | |
| 1237 bool has_call = false; // call on dom-path | |
| 1238 bool has_local_ncsfpt = false; // ncsfpt on dom-path at this loop depth | |
| 1239 Node* nonlocal_ncsfpt = NULL; // ncsfpt on dom-path at a deeper depth | |
| 1240 // Scan the dom-path nodes from tail to head | |
| 1241 for (Node* n = tail(); n != _head; n = _phase->idom(n)) { | |
| 1242 if (n->is_Call() && n->as_Call()->guaranteed_safepoint()) { | |
| 1243 has_call = true; | |
| 1244 _has_sfpt = 1; // Then no need for a safept! | |
| 1245 break; | |
| 1246 } else if (n->Opcode() == Op_SafePoint) { | |
| 1247 if (_phase->get_loop(n) == this) { | |
| 1248 has_local_ncsfpt = true; | |
| 1249 break; | |
| 1250 } | |
| 1251 if (nonlocal_ncsfpt == NULL) { | |
| 1252 nonlocal_ncsfpt = n; // save the one closest to the tail | |
| 1253 } | |
| 1254 } else { | |
| 1255 IdealLoopTree* nlpt = _phase->get_loop(n); | |
| 1256 if (this != nlpt) { | |
| 1257 // If at an inner loop tail, see if the inner loop has already | |
| 1258 // recorded seeing a call on the dom-path (and stop.) If not, | |
| 1259 // jump to the head of the inner loop. | |
| 1260 assert(is_member(nlpt), "nested loop"); | |
| 1261 Node* tail = nlpt->_tail; | |
| 1262 if (tail->in(0)->is_If()) tail = tail->in(0); | |
| 1263 if (n == tail) { | |
| 1264 // If inner loop has call on dom-path, so does outer loop | |
| 1265 if (nlpt->_has_sfpt) { | |
| 1266 has_call = true; | |
| 1267 _has_sfpt = 1; | |
| 1268 break; | |
| 1269 } | |
| 1270 // Skip to head of inner loop | |
| 1271 assert(_phase->is_dominator(_head, nlpt->_head), "inner head dominated by outer head"); | |
| 1272 n = nlpt->_head; | |
| 1273 } | |
| 1274 } | |
| 1275 } | |
| 1276 } | |
| 1277 // Record safept's that this loop needs preserved when an | |
| 1278 // inner loop attempts to delete it's safepoints. | |
| 1279 if (_child != NULL && !has_call && !has_local_ncsfpt) { | |
| 1280 if (nonlocal_ncsfpt != NULL) { | |
| 1281 if (_required_safept == NULL) _required_safept = new Node_List(); | |
| 1282 _required_safept->push(nonlocal_ncsfpt); | |
| 1283 } else { | |
| 1284 // Failed to find a suitable safept on the dom-path. Now use | |
| 1285 // an all paths walk from tail to head, looking for safepoints to preserve. | |
| 1286 allpaths_check_safepts(visited, stack); | |
| 1287 } | |
| 1288 } | |
| 1289 } | |
| 1290 } | |
| 1291 | |
| 1292 //---------------------------is_deleteable_safept---------------------------- | |
| 1293 // Is safept not required by an outer loop? | |
| 1294 bool PhaseIdealLoop::is_deleteable_safept(Node* sfpt) { | |
| 1295 assert(sfpt->Opcode() == Op_SafePoint, ""); | |
| 1296 IdealLoopTree* lp = get_loop(sfpt)->_parent; | |
| 1297 while (lp != NULL) { | |
| 1298 Node_List* sfpts = lp->_required_safept; | |
| 1299 if (sfpts != NULL) { | |
| 1300 for (uint i = 0; i < sfpts->size(); i++) { | |
| 1301 if (sfpt == sfpts->at(i)) | |
| 1302 return false; | |
| 1303 } | |
| 1304 } | |
| 1305 lp = lp->_parent; | |
| 1306 } | |
| 1307 return true; | |
| 1308 } | |
| 1309 | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1310 //---------------------------replace_parallel_iv------------------------------- |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1311 // Replace parallel induction variable (parallel to trip counter) |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1312 void PhaseIdealLoop::replace_parallel_iv(IdealLoopTree *loop) { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1313 assert(loop->_head->is_CountedLoop(), ""); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1314 CountedLoopNode *cl = loop->_head->as_CountedLoop(); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1315 Node *incr = cl->incr(); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1316 if (incr == NULL) |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1317 return; // Dead loop? |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1318 Node *init = cl->init_trip(); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1319 Node *phi = cl->phi(); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1320 // protect against stride not being a constant |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1321 if (!cl->stride_is_con()) |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1322 return; |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1323 int stride_con = cl->stride_con(); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1324 |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1325 PhaseGVN *gvn = &_igvn; |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1326 |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1327 // Visit all children, looking for Phis |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1328 for (DUIterator i = cl->outs(); cl->has_out(i); i++) { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1329 Node *out = cl->out(i); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1330 // Look for other phis (secondary IVs). Skip dead ones |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1331 if (!out->is_Phi() || out == phi || !has_node(out)) |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1332 continue; |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1333 PhiNode* phi2 = out->as_Phi(); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1334 Node *incr2 = phi2->in( LoopNode::LoopBackControl ); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1335 // Look for induction variables of the form: X += constant |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1336 if (phi2->region() != loop->_head || |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1337 incr2->req() != 3 || |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1338 incr2->in(1) != phi2 || |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1339 incr2 == incr || |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1340 incr2->Opcode() != Op_AddI || |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1341 !incr2->in(2)->is_Con()) |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1342 continue; |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1343 |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1344 // Check for parallel induction variable (parallel to trip counter) |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1345 // via an affine function. In particular, count-down loops with |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1346 // count-up array indices are common. We only RCE references off |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1347 // the trip-counter, so we need to convert all these to trip-counter |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1348 // expressions. |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1349 Node *init2 = phi2->in( LoopNode::EntryControl ); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1350 int stride_con2 = incr2->in(2)->get_int(); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1351 |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1352 // The general case here gets a little tricky. We want to find the |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1353 // GCD of all possible parallel IV's and make a new IV using this |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1354 // GCD for the loop. Then all possible IVs are simple multiples of |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1355 // the GCD. In practice, this will cover very few extra loops. |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1356 // Instead we require 'stride_con2' to be a multiple of 'stride_con', |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1357 // where +/-1 is the common case, but other integer multiples are |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1358 // also easy to handle. |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1359 int ratio_con = stride_con2/stride_con; |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1360 |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1361 if ((ratio_con * stride_con) == stride_con2) { // Check for exact |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1362 // Convert to using the trip counter. The parallel induction |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1363 // variable differs from the trip counter by a loop-invariant |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1364 // amount, the difference between their respective initial values. |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1365 // It is scaled by the 'ratio_con'. |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1366 // Perform local Ideal transformation since in most cases ratio == 1. |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1367 Node* ratio = _igvn.intcon(ratio_con); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1368 set_ctrl(ratio, C->root()); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1369 Node* hook = new (C, 3) Node(3); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1370 Node* ratio_init = gvn->transform(new (C, 3) MulINode(init, ratio)); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1371 hook->init_req(0, ratio_init); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1372 Node* diff = gvn->transform(new (C, 3) SubINode(init2, ratio_init)); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1373 hook->init_req(1, diff); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1374 Node* ratio_idx = gvn->transform(new (C, 3) MulINode(phi, ratio)); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1375 hook->init_req(2, ratio_idx); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1376 Node* add = gvn->transform(new (C, 3) AddINode(ratio_idx, diff)); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1377 set_subtree_ctrl(add); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1378 _igvn.replace_node( phi2, add ); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1379 // Free up intermediate goo |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1380 _igvn.remove_dead_node(hook); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1381 // Sometimes an induction variable is unused |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1382 if (add->outcnt() == 0) { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1383 _igvn.remove_dead_node(add); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1384 } |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1385 --i; // deleted this phi; rescan starting with next position |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1386 continue; |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1387 } |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1388 } |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1389 } |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1390 |
| 0 | 1391 //------------------------------counted_loop----------------------------------- |
| 1392 // Convert to counted loops where possible | |
| 1393 void IdealLoopTree::counted_loop( PhaseIdealLoop *phase ) { | |
| 1394 | |
| 1395 // For grins, set the inner-loop flag here | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1396 if (!_child) { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1397 if (_head->is_Loop()) _head->as_Loop()->set_inner_loop(); |
| 0 | 1398 } |
| 1399 | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1400 if (_head->is_CountedLoop() || |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1401 phase->is_counted_loop(_head, this)) { |
| 0 | 1402 _has_sfpt = 1; // Indicate we do not need a safepoint here |
| 1403 | |
| 1404 // Look for a safepoint to remove | |
| 1405 for (Node* n = tail(); n != _head; n = phase->idom(n)) | |
| 1406 if (n->Opcode() == Op_SafePoint && phase->get_loop(n) == this && | |
| 1407 phase->is_deleteable_safept(n)) | |
| 1408 phase->lazy_replace(n,n->in(TypeFunc::Control)); | |
| 1409 | |
| 1410 // Look for induction variables | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1411 phase->replace_parallel_iv(this); |
| 0 | 1412 |
| 1413 } else if (_parent != NULL && !_irreducible) { | |
| 1414 // Not a counted loop. | |
| 1415 // Look for a safepoint on the idom-path to remove, preserving the first one | |
| 1416 bool found = false; | |
| 1417 Node* n = tail(); | |
| 1418 for (; n != _head && !found; n = phase->idom(n)) { | |
| 1419 if (n->Opcode() == Op_SafePoint && phase->get_loop(n) == this) | |
| 1420 found = true; // Found one | |
| 1421 } | |
| 1422 // Skip past it and delete the others | |
| 1423 for (; n != _head; n = phase->idom(n)) { | |
| 1424 if (n->Opcode() == Op_SafePoint && phase->get_loop(n) == this && | |
| 1425 phase->is_deleteable_safept(n)) | |
| 1426 phase->lazy_replace(n,n->in(TypeFunc::Control)); | |
| 1427 } | |
| 1428 } | |
| 1429 | |
| 1430 // Recursively | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1431 if (_child) _child->counted_loop( phase ); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1432 if (_next) _next ->counted_loop( phase ); |
| 0 | 1433 } |
| 1434 | |
| 1435 #ifndef PRODUCT | |
| 1436 //------------------------------dump_head-------------------------------------- | |
| 1437 // Dump 1 liner for loop header info | |
| 1438 void IdealLoopTree::dump_head( ) const { | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1439 for (uint i=0; i<_nest; i++) |
| 0 | 1440 tty->print(" "); |
| 1441 tty->print("Loop: N%d/N%d ",_head->_idx,_tail->_idx); | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1442 if (_irreducible) tty->print(" IRREDUCIBLE"); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1443 if (UseLoopPredicate) { |
| 2445 | 1444 Node* entry = PhaseIdealLoop::find_predicate_insertion_point(_head->in(LoopNode::EntryControl), |
| 1445 Deoptimization::Reason_predicate); | |
| 1446 if (entry != NULL) { | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1447 tty->print(" predicated"); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1448 } |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1449 } |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1450 if (_head->is_CountedLoop()) { |
| 0 | 1451 CountedLoopNode *cl = _head->as_CountedLoop(); |
| 1452 tty->print(" counted"); | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1453 if (cl->is_pre_loop ()) tty->print(" pre" ); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1454 if (cl->is_main_loop()) tty->print(" main"); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1455 if (cl->is_post_loop()) tty->print(" post"); |
| 0 | 1456 } |
| 1457 tty->cr(); | |
| 1458 } | |
| 1459 | |
| 1460 //------------------------------dump------------------------------------------- | |
| 1461 // Dump loops by loop tree | |
| 1462 void IdealLoopTree::dump( ) const { | |
| 1463 dump_head(); | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1464 if (_child) _child->dump(); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1465 if (_next) _next ->dump(); |
| 0 | 1466 } |
| 1467 | |
| 1468 #endif | |
| 1469 | |
|
367
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1470 static void log_loop_tree(IdealLoopTree* root, IdealLoopTree* loop, CompileLog* log) { |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1471 if (loop == root) { |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1472 if (loop->_child != NULL) { |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1473 log->begin_head("loop_tree"); |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1474 log->end_head(); |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1475 if( loop->_child ) log_loop_tree(root, loop->_child, log); |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1476 log->tail("loop_tree"); |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1477 assert(loop->_next == NULL, "what?"); |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1478 } |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1479 } else { |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1480 Node* head = loop->_head; |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1481 log->begin_head("loop"); |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1482 log->print(" idx='%d' ", head->_idx); |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1483 if (loop->_irreducible) log->print("irreducible='1' "); |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1484 if (head->is_Loop()) { |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1485 if (head->as_Loop()->is_inner_loop()) log->print("inner_loop='1' "); |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1486 if (head->as_Loop()->is_partial_peel_loop()) log->print("partial_peel_loop='1' "); |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1487 } |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1488 if (head->is_CountedLoop()) { |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1489 CountedLoopNode* cl = head->as_CountedLoop(); |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1490 if (cl->is_pre_loop()) log->print("pre_loop='%d' ", cl->main_idx()); |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1491 if (cl->is_main_loop()) log->print("main_loop='%d' ", cl->_idx); |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1492 if (cl->is_post_loop()) log->print("post_loop='%d' ", cl->main_idx()); |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1493 } |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1494 log->end_head(); |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1495 if( loop->_child ) log_loop_tree(root, loop->_child, log); |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1496 log->tail("loop"); |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1497 if( loop->_next ) log_loop_tree(root, loop->_next, log); |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1498 } |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1499 } |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1500 |
| 1172 | 1501 //---------------------collect_potentially_useful_predicates----------------------- |
| 1502 // Helper function to collect potentially useful predicates to prevent them from | |
| 1503 // being eliminated by PhaseIdealLoop::eliminate_useless_predicates | |
| 1504 void PhaseIdealLoop::collect_potentially_useful_predicates( | |
| 1505 IdealLoopTree * loop, Unique_Node_List &useful_predicates) { | |
| 1506 if (loop->_child) { // child | |
| 1507 collect_potentially_useful_predicates(loop->_child, useful_predicates); | |
| 1508 } | |
| 1509 | |
| 1510 // self (only loops that we can apply loop predication may use their predicates) | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1511 if (loop->_head->is_Loop() && |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1512 !loop->_irreducible && |
| 1172 | 1513 !loop->tail()->is_top()) { |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1514 LoopNode* lpn = loop->_head->as_Loop(); |
| 1172 | 1515 Node* entry = lpn->in(LoopNode::EntryControl); |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1516 Node* predicate_proj = find_predicate(entry); |
| 1172 | 1517 if (predicate_proj != NULL ) { // right pattern that can be used by loop predication |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1518 assert(entry->in(0)->in(1)->in(1)->Opcode() == Op_Opaque1, "must be"); |
| 1172 | 1519 useful_predicates.push(entry->in(0)->in(1)->in(1)); // good one |
| 1520 } | |
| 1521 } | |
| 1522 | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1523 if (loop->_next) { // sibling |
| 1172 | 1524 collect_potentially_useful_predicates(loop->_next, useful_predicates); |
| 1525 } | |
| 1526 } | |
| 1527 | |
| 1528 //------------------------eliminate_useless_predicates----------------------------- | |
| 1529 // Eliminate all inserted predicates if they could not be used by loop predication. | |
| 1530 void PhaseIdealLoop::eliminate_useless_predicates() { | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1531 if (C->predicate_count() == 0) |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1532 return; // no predicate left |
| 1172 | 1533 |
| 1534 Unique_Node_List useful_predicates; // to store useful predicates | |
| 1535 if (C->has_loops()) { | |
| 1536 collect_potentially_useful_predicates(_ltree_root->_child, useful_predicates); | |
| 1537 } | |
| 1538 | |
| 1539 for (int i = C->predicate_count(); i > 0; i--) { | |
| 1540 Node * n = C->predicate_opaque1_node(i-1); | |
| 1541 assert(n->Opcode() == Op_Opaque1, "must be"); | |
| 1542 if (!useful_predicates.member(n)) { // not in the useful list | |
| 1543 _igvn.replace_node(n, n->in(1)); | |
| 1544 } | |
| 1545 } | |
| 1546 } | |
| 1547 | |
| 0 | 1548 //============================================================================= |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1549 //----------------------------build_and_optimize------------------------------- |
| 0 | 1550 // Create a PhaseLoop. Build the ideal Loop tree. Map each Ideal Node to |
| 1551 // its corresponding LoopNode. If 'optimize' is true, do some loop cleanups. | |
| 2445 | 1552 void PhaseIdealLoop::build_and_optimize(bool do_split_ifs) { |
|
2248
194c9fdee631
7017240: C2: native memory leak in nsk/regression/b4675027 on windows-x86 in comp mode with G1
kvn
parents:
1972
diff
changeset
|
1553 ResourceMark rm; |
|
194c9fdee631
7017240: C2: native memory leak in nsk/regression/b4675027 on windows-x86 in comp mode with G1
kvn
parents:
1972
diff
changeset
|
1554 |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1555 int old_progress = C->major_progress(); |
| 2403 | 1556 uint orig_worklist_size = _igvn._worklist.size(); |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1557 |
| 0 | 1558 // Reset major-progress flag for the driver's heuristics |
| 1559 C->clear_major_progress(); | |
| 1560 | |
| 1561 #ifndef PRODUCT | |
| 1562 // Capture for later assert | |
| 1563 uint unique = C->unique(); | |
| 1564 _loop_invokes++; | |
| 1565 _loop_work += unique; | |
| 1566 #endif | |
| 1567 | |
| 1568 // True if the method has at least 1 irreducible loop | |
| 1569 _has_irreducible_loops = false; | |
| 1570 | |
| 1571 _created_loop_node = false; | |
| 1572 | |
| 1573 Arena *a = Thread::current()->resource_area(); | |
| 1574 VectorSet visited(a); | |
| 1575 // Pre-grow the mapping from Nodes to IdealLoopTrees. | |
| 1576 _nodes.map(C->unique(), NULL); | |
| 1577 memset(_nodes.adr(), 0, wordSize * C->unique()); | |
| 1578 | |
| 1579 // Pre-build the top-level outermost loop tree entry | |
| 1580 _ltree_root = new IdealLoopTree( this, C->root(), C->root() ); | |
| 1581 // Do not need a safepoint at the top level | |
| 1582 _ltree_root->_has_sfpt = 1; | |
| 1583 | |
| 2445 | 1584 // Initialize Dominators. |
| 1585 // Checked in clone_loop_predicate() during beautify_loops(). | |
| 1586 _idom_size = 0; | |
| 1587 _idom = NULL; | |
| 1588 _dom_depth = NULL; | |
| 1589 _dom_stk = NULL; | |
| 1590 | |
| 0 | 1591 // Empty pre-order array |
| 1592 allocate_preorders(); | |
| 1593 | |
| 1594 // Build a loop tree on the fly. Build a mapping from CFG nodes to | |
| 1595 // IdealLoopTree entries. Data nodes are NOT walked. | |
| 1596 build_loop_tree(); | |
| 1597 // Check for bailout, and return | |
| 1598 if (C->failing()) { | |
| 1599 return; | |
| 1600 } | |
| 1601 | |
| 1602 // No loops after all | |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1603 if( !_ltree_root->_child && !_verify_only ) C->set_has_loops(false); |
| 0 | 1604 |
| 1605 // There should always be an outer loop containing the Root and Return nodes. | |
| 1606 // If not, we have a degenerate empty program. Bail out in this case. | |
| 1607 if (!has_node(C->root())) { | |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1608 if (!_verify_only) { |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1609 C->clear_major_progress(); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1610 C->record_method_not_compilable("empty program detected during loop optimization"); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1611 } |
| 0 | 1612 return; |
| 1613 } | |
| 1614 | |
| 1615 // Nothing to do, so get out | |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1616 if( !C->has_loops() && !do_split_ifs && !_verify_me && !_verify_only ) { |
| 0 | 1617 _igvn.optimize(); // Cleanup NeverBranches |
| 1618 return; | |
| 1619 } | |
| 1620 | |
| 1621 // Set loop nesting depth | |
| 1622 _ltree_root->set_nest( 0 ); | |
| 1623 | |
| 1624 // Split shared headers and insert loop landing pads. | |
| 1625 // Do not bother doing this on the Root loop of course. | |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1626 if( !_verify_me && !_verify_only && _ltree_root->_child ) { |
| 2403 | 1627 C->print_method("Before beautify loops", 3); |
| 0 | 1628 if( _ltree_root->_child->beautify_loops( this ) ) { |
| 1629 // Re-build loop tree! | |
| 1630 _ltree_root->_child = NULL; | |
| 1631 _nodes.clear(); | |
| 1632 reallocate_preorders(); | |
| 1633 build_loop_tree(); | |
| 1634 // Check for bailout, and return | |
| 1635 if (C->failing()) { | |
| 1636 return; | |
| 1637 } | |
| 1638 // Reset loop nesting depth | |
| 1639 _ltree_root->set_nest( 0 ); | |
| 222 | 1640 |
| 1641 C->print_method("After beautify loops", 3); | |
| 0 | 1642 } |
| 1643 } | |
| 1644 | |
| 1645 // Build Dominators for elision of NULL checks & loop finding. | |
| 1646 // Since nodes do not have a slot for immediate dominator, make | |
| 605 | 1647 // a persistent side array for that info indexed on node->_idx. |
| 0 | 1648 _idom_size = C->unique(); |
| 1649 _idom = NEW_RESOURCE_ARRAY( Node*, _idom_size ); | |
| 1650 _dom_depth = NEW_RESOURCE_ARRAY( uint, _idom_size ); | |
| 1651 _dom_stk = NULL; // Allocated on demand in recompute_dom_depth | |
| 1652 memset( _dom_depth, 0, _idom_size * sizeof(uint) ); | |
| 1653 | |
| 1654 Dominators(); | |
| 1655 | |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1656 if (!_verify_only) { |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1657 // As a side effect, Dominators removed any unreachable CFG paths |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1658 // into RegionNodes. It doesn't do this test against Root, so |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1659 // we do it here. |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1660 for( uint i = 1; i < C->root()->req(); i++ ) { |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1661 if( !_nodes[C->root()->in(i)->_idx] ) { // Dead path into Root? |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1662 _igvn.hash_delete(C->root()); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1663 C->root()->del_req(i); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1664 _igvn._worklist.push(C->root()); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1665 i--; // Rerun same iteration on compressed edges |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1666 } |
| 0 | 1667 } |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1668 |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1669 // Given dominators, try to find inner loops with calls that must |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1670 // always be executed (call dominates loop tail). These loops do |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1671 // not need a separate safepoint. |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1672 Node_List cisstack(a); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1673 _ltree_root->check_safepts(visited, cisstack); |
| 0 | 1674 } |
| 1675 | |
| 1676 // Walk the DATA nodes and place into loops. Find earliest control | |
| 1677 // node. For CFG nodes, the _nodes array starts out and remains | |
| 1678 // holding the associated IdealLoopTree pointer. For DATA nodes, the | |
| 1679 // _nodes array holds the earliest legal controlling CFG node. | |
| 1680 | |
| 1681 // Allocate stack with enough space to avoid frequent realloc | |
| 1682 int stack_size = (C->unique() >> 1) + 16; // (unique>>1)+16 from Java2D stats | |
| 1683 Node_Stack nstack( a, stack_size ); | |
| 1684 | |
| 1685 visited.Clear(); | |
| 1686 Node_List worklist(a); | |
| 1687 // Don't need C->root() on worklist since | |
| 1688 // it will be processed among C->top() inputs | |
| 1689 worklist.push( C->top() ); | |
| 1690 visited.set( C->top()->_idx ); // Set C->top() as visited now | |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1691 build_loop_early( visited, worklist, nstack ); |
| 0 | 1692 |
| 1693 // Given early legal placement, try finding counted loops. This placement | |
| 1694 // is good enough to discover most loop invariants. | |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1695 if( !_verify_me && !_verify_only ) |
| 0 | 1696 _ltree_root->counted_loop( this ); |
| 1697 | |
| 1698 // Find latest loop placement. Find ideal loop placement. | |
| 1699 visited.Clear(); | |
| 1700 init_dom_lca_tags(); | |
| 1701 // Need C->root() on worklist when processing outs | |
| 1702 worklist.push( C->root() ); | |
| 1703 NOT_PRODUCT( C->verify_graph_edges(); ) | |
| 1704 worklist.push( C->top() ); | |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1705 build_loop_late( visited, worklist, nstack ); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1706 |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1707 if (_verify_only) { |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1708 // restore major progress flag |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1709 for (int i = 0; i < old_progress; i++) |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1710 C->set_major_progress(); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1711 assert(C->unique() == unique, "verification mode made Nodes? ? ?"); |
| 2403 | 1712 assert(_igvn._worklist.size() == orig_worklist_size, "shouldn't push anything"); |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1713 return; |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1714 } |
| 0 | 1715 |
| 2445 | 1716 // Some parser-inserted loop predicates could never be used by loop |
| 1717 // predication or they were moved away from loop during some optimizations. | |
| 1718 // For example, peeling. Eliminate them before next loop optimizations. | |
| 1172 | 1719 if (UseLoopPredicate) { |
| 1720 eliminate_useless_predicates(); | |
| 1721 } | |
| 1722 | |
| 0 | 1723 // clear out the dead code |
| 1724 while(_deadlist.size()) { | |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1725 _igvn.remove_globally_dead_node(_deadlist.pop()); |
| 0 | 1726 } |
| 1727 | |
| 1728 #ifndef PRODUCT | |
| 1729 C->verify_graph_edges(); | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1730 if (_verify_me) { // Nested verify pass? |
| 0 | 1731 // Check to see if the verify mode is broken |
| 1732 assert(C->unique() == unique, "non-optimize mode made Nodes? ? ?"); | |
| 1733 return; | |
| 1734 } | |
|
2383
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1735 if(VerifyLoopOptimizations) verify(); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1736 if(TraceLoopOpts && C->has_loops()) { |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1737 _ltree_root->dump(); |
|
9dc311b8473e
7008866: Missing loop predicate for loop with multiple entries
kvn
parents:
2248
diff
changeset
|
1738 } |
| 0 | 1739 #endif |
| 1740 | |
| 1741 if (ReassociateInvariants) { | |
| 1742 // Reassociate invariants and prep for split_thru_phi | |
| 1743 for (LoopTreeIterator iter(_ltree_root); !iter.done(); iter.next()) { | |
| 1744 IdealLoopTree* lpt = iter.current(); | |
| 1745 if (!lpt->is_counted() || !lpt->is_inner()) continue; | |
| 1746 | |
| 1747 lpt->reassociate_invariants(this); | |
| 1748 | |
| 1749 // Because RCE opportunities can be masked by split_thru_phi, | |
| 1750 // look for RCE candidates and inhibit split_thru_phi | |
| 1751 // on just their loop-phi's for this pass of loop opts | |
| 1172 | 1752 if (SplitIfBlocks && do_split_ifs) { |
| 0 | 1753 if (lpt->policy_range_check(this)) { |
|
39
76256d272075
6667612: (Escape Analysis) disable loop cloning if it has a scalar replaceable allocation
kvn
parents:
17
diff
changeset
|
1754 lpt->_rce_candidate = 1; // = true |
| 0 | 1755 } |
| 1756 } | |
| 1757 } | |
| 1758 } | |
| 1759 | |
| 1760 // Check for aggressive application of split-if and other transforms | |
| 1761 // that require basic-block info (like cloning through Phi's) | |
| 1762 if( SplitIfBlocks && do_split_ifs ) { | |
| 1763 visited.Clear(); | |
| 1764 split_if_with_blocks( visited, nstack ); | |
| 1765 NOT_PRODUCT( if( VerifyLoopOptimizations ) verify(); ); | |
| 1766 } | |
| 1767 | |
| 1172 | 1768 // Perform loop predication before iteration splitting |
| 2445 | 1769 if (C->has_loops() && !C->major_progress() && (C->predicate_count() > 0)) { |
| 1172 | 1770 _ltree_root->_child->loop_predication(this); |
| 1771 } | |
| 1772 | |
| 1763 | 1773 if (OptimizeFill && UseLoopPredicate && C->has_loops() && !C->major_progress()) { |
| 1774 if (do_intrinsify_fill()) { | |
| 1775 C->set_major_progress(); | |
| 1776 } | |
| 1777 } | |
| 1778 | |
| 0 | 1779 // Perform iteration-splitting on inner loops. Split iterations to avoid |
| 1780 // range checks or one-shot null checks. | |
| 1781 | |
| 1782 // If split-if's didn't hack the graph too bad (no CFG changes) | |
| 1783 // then do loop opts. | |
| 1172 | 1784 if (C->has_loops() && !C->major_progress()) { |
| 0 | 1785 memset( worklist.adr(), 0, worklist.Size()*sizeof(Node*) ); |
| 1786 _ltree_root->_child->iteration_split( this, worklist ); | |
| 1787 // No verify after peeling! GCM has hoisted code out of the loop. | |
| 1788 // After peeling, the hoisted code could sink inside the peeled area. | |
| 1789 // The peeling code does not try to recompute the best location for | |
| 1790 // all the code before the peeled area, so the verify pass will always | |
| 1791 // complain about it. | |
| 1792 } | |
| 1793 // Do verify graph edges in any case | |
| 1794 NOT_PRODUCT( C->verify_graph_edges(); ); | |
| 1795 | |
| 1172 | 1796 if (!do_split_ifs) { |
| 0 | 1797 // We saw major progress in Split-If to get here. We forced a |
| 1798 // pass with unrolling and not split-if, however more split-if's | |
| 1799 // might make progress. If the unrolling didn't make progress | |
| 1800 // then the major-progress flag got cleared and we won't try | |
| 1801 // another round of Split-If. In particular the ever-common | |
| 1802 // instance-of/check-cast pattern requires at least 2 rounds of | |
| 1803 // Split-If to clear out. | |
| 1804 C->set_major_progress(); | |
| 1805 } | |
| 1806 | |
| 1807 // Repeat loop optimizations if new loops were seen | |
| 1808 if (created_loop_node()) { | |
| 1809 C->set_major_progress(); | |
| 1810 } | |
| 1811 | |
| 2445 | 1812 // Keep loop predicates and perform optimizations with them |
| 1813 // until no more loop optimizations could be done. | |
| 1814 // After that switch predicates off and do more loop optimizations. | |
| 1815 if (!C->major_progress() && (C->predicate_count() > 0)) { | |
| 1816 C->cleanup_loop_predicates(_igvn); | |
| 1817 #ifndef PRODUCT | |
| 1818 if (TraceLoopOpts) { | |
| 1819 tty->print_cr("PredicatesOff"); | |
| 1820 } | |
| 1821 #endif | |
| 1822 C->set_major_progress(); | |
| 1823 } | |
| 0 | 1824 |
| 2445 | 1825 // Convert scalar to superword operations at the end of all loop opts. |
| 0 | 1826 if (UseSuperWord && C->has_loops() && !C->major_progress()) { |
| 1827 // SuperWord transform | |
| 1828 SuperWord sw(this); | |
| 1829 for (LoopTreeIterator iter(_ltree_root); !iter.done(); iter.next()) { | |
| 1830 IdealLoopTree* lpt = iter.current(); | |
| 1831 if (lpt->is_counted()) { | |
| 1832 sw.transform_loop(lpt); | |
| 1833 } | |
| 1834 } | |
| 1835 } | |
| 1836 | |
| 1837 // Cleanup any modified bits | |
| 1838 _igvn.optimize(); | |
| 1839 | |
|
367
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1840 // disable assert until issue with split_flow_path is resolved (6742111) |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1841 // assert(!_has_irreducible_loops || C->parsed_irreducible_loop() || C->is_osr_compilation(), |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1842 // "shouldn't introduce irreducible loops"); |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1843 |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1844 if (C->log() != NULL) { |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1845 log_loop_tree(_ltree_root, _ltree_root, C->log()); |
|
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
1846 } |
| 0 | 1847 } |
| 1848 | |
| 1849 #ifndef PRODUCT | |
| 1850 //------------------------------print_statistics------------------------------- | |
| 1851 int PhaseIdealLoop::_loop_invokes=0;// Count of PhaseIdealLoop invokes | |
| 1852 int PhaseIdealLoop::_loop_work=0; // Sum of PhaseIdealLoop x unique | |
| 1853 void PhaseIdealLoop::print_statistics() { | |
| 1854 tty->print_cr("PhaseIdealLoop=%d, sum _unique=%d", _loop_invokes, _loop_work); | |
| 1855 } | |
| 1856 | |
| 1857 //------------------------------verify----------------------------------------- | |
| 1858 // Build a verify-only PhaseIdealLoop, and see that it agrees with me. | |
| 1859 static int fail; // debug only, so its multi-thread dont care | |
| 1860 void PhaseIdealLoop::verify() const { | |
| 1861 int old_progress = C->major_progress(); | |
| 1862 ResourceMark rm; | |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
1863 PhaseIdealLoop loop_verify( _igvn, this ); |
| 0 | 1864 VectorSet visited(Thread::current()->resource_area()); |
| 1865 | |
| 1866 fail = 0; | |
| 1867 verify_compare( C->root(), &loop_verify, visited ); | |
| 1868 assert( fail == 0, "verify loops failed" ); | |
| 1869 // Verify loop structure is the same | |
| 1870 _ltree_root->verify_tree(loop_verify._ltree_root, NULL); | |
| 1871 // Reset major-progress. It was cleared by creating a verify version of | |
| 1872 // PhaseIdealLoop. | |
| 1873 for( int i=0; i<old_progress; i++ ) | |
| 1874 C->set_major_progress(); | |
| 1875 } | |
| 1876 | |
| 1877 //------------------------------verify_compare--------------------------------- | |
| 1878 // Make sure me and the given PhaseIdealLoop agree on key data structures | |
| 1879 void PhaseIdealLoop::verify_compare( Node *n, const PhaseIdealLoop *loop_verify, VectorSet &visited ) const { | |
| 1880 if( !n ) return; | |
| 1881 if( visited.test_set( n->_idx ) ) return; | |
| 1882 if( !_nodes[n->_idx] ) { // Unreachable | |
| 1883 assert( !loop_verify->_nodes[n->_idx], "both should be unreachable" ); | |
| 1884 return; | |
| 1885 } | |
| 1886 | |
| 1887 uint i; | |
| 1888 for( i = 0; i < n->req(); i++ ) | |
| 1889 verify_compare( n->in(i), loop_verify, visited ); | |
| 1890 | |
| 1891 // Check the '_nodes' block/loop structure | |
| 1892 i = n->_idx; | |
| 1893 if( has_ctrl(n) ) { // We have control; verify has loop or ctrl | |
| 1894 if( _nodes[i] != loop_verify->_nodes[i] && | |
| 1895 get_ctrl_no_update(n) != loop_verify->get_ctrl_no_update(n) ) { | |
| 1896 tty->print("Mismatched control setting for: "); | |
| 1897 n->dump(); | |
| 1898 if( fail++ > 10 ) return; | |
| 1899 Node *c = get_ctrl_no_update(n); | |
| 1900 tty->print("We have it as: "); | |
| 1901 if( c->in(0) ) c->dump(); | |
| 1902 else tty->print_cr("N%d",c->_idx); | |
| 1903 tty->print("Verify thinks: "); | |
| 1904 if( loop_verify->has_ctrl(n) ) | |
| 1905 loop_verify->get_ctrl_no_update(n)->dump(); | |
| 1906 else | |
| 1907 loop_verify->get_loop_idx(n)->dump(); | |
| 1908 tty->cr(); | |
| 1909 } | |
| 1910 } else { // We have a loop | |
| 1911 IdealLoopTree *us = get_loop_idx(n); | |
| 1912 if( loop_verify->has_ctrl(n) ) { | |
| 1913 tty->print("Mismatched loop setting for: "); | |
| 1914 n->dump(); | |
| 1915 if( fail++ > 10 ) return; | |
| 1916 tty->print("We have it as: "); | |
| 1917 us->dump(); | |
| 1918 tty->print("Verify thinks: "); | |
| 1919 loop_verify->get_ctrl_no_update(n)->dump(); | |
| 1920 tty->cr(); | |
| 1921 } else if (!C->major_progress()) { | |
| 1922 // Loop selection can be messed up if we did a major progress | |
| 1923 // operation, like split-if. Do not verify in that case. | |
| 1924 IdealLoopTree *them = loop_verify->get_loop_idx(n); | |
| 1925 if( us->_head != them->_head || us->_tail != them->_tail ) { | |
| 1926 tty->print("Unequals loops for: "); | |
| 1927 n->dump(); | |
| 1928 if( fail++ > 10 ) return; | |
| 1929 tty->print("We have it as: "); | |
| 1930 us->dump(); | |
| 1931 tty->print("Verify thinks: "); | |
| 1932 them->dump(); | |
| 1933 tty->cr(); | |
| 1934 } | |
| 1935 } | |
| 1936 } | |
| 1937 | |
| 1938 // Check for immediate dominators being equal | |
| 1939 if( i >= _idom_size ) { | |
| 1940 if( !n->is_CFG() ) return; | |
| 1941 tty->print("CFG Node with no idom: "); | |
| 1942 n->dump(); | |
| 1943 return; | |
| 1944 } | |
| 1945 if( !n->is_CFG() ) return; | |
| 1946 if( n == C->root() ) return; // No IDOM here | |
| 1947 | |
| 1948 assert(n->_idx == i, "sanity"); | |
| 1949 Node *id = idom_no_update(n); | |
| 1950 if( id != loop_verify->idom_no_update(n) ) { | |
| 1951 tty->print("Unequals idoms for: "); | |
| 1952 n->dump(); | |
| 1953 if( fail++ > 10 ) return; | |
| 1954 tty->print("We have it as: "); | |
| 1955 id->dump(); | |
| 1956 tty->print("Verify thinks: "); | |
| 1957 loop_verify->idom_no_update(n)->dump(); | |
| 1958 tty->cr(); | |
| 1959 } | |
| 1960 | |
| 1961 } | |
| 1962 | |
| 1963 //------------------------------verify_tree------------------------------------ | |
| 1964 // Verify that tree structures match. Because the CFG can change, siblings | |
| 1965 // within the loop tree can be reordered. We attempt to deal with that by | |
| 1966 // reordering the verify's loop tree if possible. | |
| 1967 void IdealLoopTree::verify_tree(IdealLoopTree *loop, const IdealLoopTree *parent) const { | |
| 1968 assert( _parent == parent, "Badly formed loop tree" ); | |
| 1969 | |
| 1970 // Siblings not in same order? Attempt to re-order. | |
| 1971 if( _head != loop->_head ) { | |
| 1972 // Find _next pointer to update | |
| 1973 IdealLoopTree **pp = &loop->_parent->_child; | |
| 1974 while( *pp != loop ) | |
| 1975 pp = &((*pp)->_next); | |
| 1976 // Find proper sibling to be next | |
| 1977 IdealLoopTree **nn = &loop->_next; | |
| 1978 while( (*nn) && (*nn)->_head != _head ) | |
| 1979 nn = &((*nn)->_next); | |
| 1980 | |
| 1981 // Check for no match. | |
| 1982 if( !(*nn) ) { | |
| 1983 // Annoyingly, irreducible loops can pick different headers | |
| 1984 // after a major_progress operation, so the rest of the loop | |
| 1985 // tree cannot be matched. | |
| 1986 if (_irreducible && Compile::current()->major_progress()) return; | |
| 1987 assert( 0, "failed to match loop tree" ); | |
| 1988 } | |
| 1989 | |
| 1990 // Move (*nn) to (*pp) | |
| 1991 IdealLoopTree *hit = *nn; | |
| 1992 *nn = hit->_next; | |
| 1993 hit->_next = loop; | |
| 1994 *pp = loop; | |
| 1995 loop = hit; | |
| 1996 // Now try again to verify | |
| 1997 } | |
| 1998 | |
| 1999 assert( _head == loop->_head , "mismatched loop head" ); | |
| 2000 Node *tail = _tail; // Inline a non-updating version of | |
| 2001 while( !tail->in(0) ) // the 'tail()' call. | |
| 2002 tail = tail->in(1); | |
| 2003 assert( tail == loop->_tail, "mismatched loop tail" ); | |
| 2004 | |
| 2005 // Counted loops that are guarded should be able to find their guards | |
| 2006 if( _head->is_CountedLoop() && _head->as_CountedLoop()->is_main_loop() ) { | |
| 2007 CountedLoopNode *cl = _head->as_CountedLoop(); | |
| 2008 Node *init = cl->init_trip(); | |
| 2009 Node *ctrl = cl->in(LoopNode::EntryControl); | |
| 2010 assert( ctrl->Opcode() == Op_IfTrue || ctrl->Opcode() == Op_IfFalse, "" ); | |
| 2011 Node *iff = ctrl->in(0); | |
| 2012 assert( iff->Opcode() == Op_If, "" ); | |
| 2013 Node *bol = iff->in(1); | |
| 2014 assert( bol->Opcode() == Op_Bool, "" ); | |
| 2015 Node *cmp = bol->in(1); | |
| 2016 assert( cmp->Opcode() == Op_CmpI, "" ); | |
| 2017 Node *add = cmp->in(1); | |
| 2018 Node *opaq; | |
| 2019 if( add->Opcode() == Op_Opaque1 ) { | |
| 2020 opaq = add; | |
| 2021 } else { | |
| 2022 assert( add->Opcode() == Op_AddI || add->Opcode() == Op_ConI , "" ); | |
| 2023 assert( add == init, "" ); | |
| 2024 opaq = cmp->in(2); | |
| 2025 } | |
| 2026 assert( opaq->Opcode() == Op_Opaque1, "" ); | |
| 2027 | |
| 2028 } | |
| 2029 | |
| 2030 if (_child != NULL) _child->verify_tree(loop->_child, this); | |
| 2031 if (_next != NULL) _next ->verify_tree(loop->_next, parent); | |
| 2032 // Innermost loops need to verify loop bodies, | |
| 2033 // but only if no 'major_progress' | |
| 2034 int fail = 0; | |
| 2035 if (!Compile::current()->major_progress() && _child == NULL) { | |
| 2036 for( uint i = 0; i < _body.size(); i++ ) { | |
| 2037 Node *n = _body.at(i); | |
| 2038 if (n->outcnt() == 0) continue; // Ignore dead | |
| 2039 uint j; | |
| 2040 for( j = 0; j < loop->_body.size(); j++ ) | |
| 2041 if( loop->_body.at(j) == n ) | |
| 2042 break; | |
| 2043 if( j == loop->_body.size() ) { // Not found in loop body | |
| 2044 // Last ditch effort to avoid assertion: Its possible that we | |
| 2045 // have some users (so outcnt not zero) but are still dead. | |
| 2046 // Try to find from root. | |
| 2047 if (Compile::current()->root()->find(n->_idx)) { | |
| 2048 fail++; | |
| 2049 tty->print("We have that verify does not: "); | |
| 2050 n->dump(); | |
| 2051 } | |
| 2052 } | |
| 2053 } | |
| 2054 for( uint i2 = 0; i2 < loop->_body.size(); i2++ ) { | |
| 2055 Node *n = loop->_body.at(i2); | |
| 2056 if (n->outcnt() == 0) continue; // Ignore dead | |
| 2057 uint j; | |
| 2058 for( j = 0; j < _body.size(); j++ ) | |
| 2059 if( _body.at(j) == n ) | |
| 2060 break; | |
| 2061 if( j == _body.size() ) { // Not found in loop body | |
| 2062 // Last ditch effort to avoid assertion: Its possible that we | |
| 2063 // have some users (so outcnt not zero) but are still dead. | |
| 2064 // Try to find from root. | |
| 2065 if (Compile::current()->root()->find(n->_idx)) { | |
| 2066 fail++; | |
| 2067 tty->print("Verify has that we do not: "); | |
| 2068 n->dump(); | |
| 2069 } | |
| 2070 } | |
| 2071 } | |
| 2072 assert( !fail, "loop body mismatch" ); | |
| 2073 } | |
| 2074 } | |
| 2075 | |
| 2076 #endif | |
| 2077 | |
| 2078 //------------------------------set_idom--------------------------------------- | |
| 2079 void PhaseIdealLoop::set_idom(Node* d, Node* n, uint dom_depth) { | |
| 2080 uint idx = d->_idx; | |
| 2081 if (idx >= _idom_size) { | |
| 2082 uint newsize = _idom_size<<1; | |
| 2083 while( idx >= newsize ) { | |
| 2084 newsize <<= 1; | |
| 2085 } | |
| 2086 _idom = REALLOC_RESOURCE_ARRAY( Node*, _idom,_idom_size,newsize); | |
| 2087 _dom_depth = REALLOC_RESOURCE_ARRAY( uint, _dom_depth,_idom_size,newsize); | |
| 2088 memset( _dom_depth + _idom_size, 0, (newsize - _idom_size) * sizeof(uint) ); | |
| 2089 _idom_size = newsize; | |
| 2090 } | |
| 2091 _idom[idx] = n; | |
| 2092 _dom_depth[idx] = dom_depth; | |
| 2093 } | |
| 2094 | |
| 2095 //------------------------------recompute_dom_depth--------------------------------------- | |
| 2096 // The dominator tree is constructed with only parent pointers. | |
| 2097 // This recomputes the depth in the tree by first tagging all | |
| 2098 // nodes as "no depth yet" marker. The next pass then runs up | |
| 2099 // the dom tree from each node marked "no depth yet", and computes | |
| 2100 // the depth on the way back down. | |
| 2101 void PhaseIdealLoop::recompute_dom_depth() { | |
| 2102 uint no_depth_marker = C->unique(); | |
| 2103 uint i; | |
| 2104 // Initialize depth to "no depth yet" | |
| 2105 for (i = 0; i < _idom_size; i++) { | |
| 2106 if (_dom_depth[i] > 0 && _idom[i] != NULL) { | |
| 2107 _dom_depth[i] = no_depth_marker; | |
| 2108 } | |
| 2109 } | |
| 2110 if (_dom_stk == NULL) { | |
| 2111 uint init_size = C->unique() / 100; // Guess that 1/100 is a reasonable initial size. | |
| 2112 if (init_size < 10) init_size = 10; | |
|
2248
194c9fdee631
7017240: C2: native memory leak in nsk/regression/b4675027 on windows-x86 in comp mode with G1
kvn
parents:
1972
diff
changeset
|
2113 _dom_stk = new GrowableArray<uint>(init_size); |
| 0 | 2114 } |
| 2115 // Compute new depth for each node. | |
| 2116 for (i = 0; i < _idom_size; i++) { | |
| 2117 uint j = i; | |
| 2118 // Run up the dom tree to find a node with a depth | |
| 2119 while (_dom_depth[j] == no_depth_marker) { | |
| 2120 _dom_stk->push(j); | |
| 2121 j = _idom[j]->_idx; | |
| 2122 } | |
| 2123 // Compute the depth on the way back down this tree branch | |
| 2124 uint dd = _dom_depth[j] + 1; | |
| 2125 while (_dom_stk->length() > 0) { | |
| 2126 uint j = _dom_stk->pop(); | |
| 2127 _dom_depth[j] = dd; | |
| 2128 dd++; | |
| 2129 } | |
| 2130 } | |
| 2131 } | |
| 2132 | |
| 2133 //------------------------------sort------------------------------------------- | |
| 2134 // Insert 'loop' into the existing loop tree. 'innermost' is a leaf of the | |
| 2135 // loop tree, not the root. | |
| 2136 IdealLoopTree *PhaseIdealLoop::sort( IdealLoopTree *loop, IdealLoopTree *innermost ) { | |
| 2137 if( !innermost ) return loop; // New innermost loop | |
| 2138 | |
| 2139 int loop_preorder = get_preorder(loop->_head); // Cache pre-order number | |
| 2140 assert( loop_preorder, "not yet post-walked loop" ); | |
| 2141 IdealLoopTree **pp = &innermost; // Pointer to previous next-pointer | |
| 2142 IdealLoopTree *l = *pp; // Do I go before or after 'l'? | |
| 2143 | |
| 2144 // Insert at start of list | |
| 2145 while( l ) { // Insertion sort based on pre-order | |
| 2146 if( l == loop ) return innermost; // Already on list! | |
| 2147 int l_preorder = get_preorder(l->_head); // Cache pre-order number | |
| 2148 assert( l_preorder, "not yet post-walked l" ); | |
| 2149 // Check header pre-order number to figure proper nesting | |
| 2150 if( loop_preorder > l_preorder ) | |
| 2151 break; // End of insertion | |
| 2152 // If headers tie (e.g., shared headers) check tail pre-order numbers. | |
| 2153 // Since I split shared headers, you'd think this could not happen. | |
| 2154 // BUT: I must first do the preorder numbering before I can discover I | |
| 2155 // have shared headers, so the split headers all get the same preorder | |
| 2156 // number as the RegionNode they split from. | |
| 2157 if( loop_preorder == l_preorder && | |
| 2158 get_preorder(loop->_tail) < get_preorder(l->_tail) ) | |
| 2159 break; // Also check for shared headers (same pre#) | |
| 2160 pp = &l->_parent; // Chain up list | |
| 2161 l = *pp; | |
| 2162 } | |
| 2163 // Link into list | |
| 2164 // Point predecessor to me | |
| 2165 *pp = loop; | |
| 2166 // Point me to successor | |
| 2167 IdealLoopTree *p = loop->_parent; | |
| 2168 loop->_parent = l; // Point me to successor | |
| 2169 if( p ) sort( p, innermost ); // Insert my parents into list as well | |
| 2170 return innermost; | |
| 2171 } | |
| 2172 | |
| 2173 //------------------------------build_loop_tree-------------------------------- | |
| 2174 // I use a modified Vick/Tarjan algorithm. I need pre- and a post- visit | |
| 2175 // bits. The _nodes[] array is mapped by Node index and holds a NULL for | |
| 2176 // not-yet-pre-walked, pre-order # for pre-but-not-post-walked and holds the | |
| 2177 // tightest enclosing IdealLoopTree for post-walked. | |
| 2178 // | |
| 2179 // During my forward walk I do a short 1-layer lookahead to see if I can find | |
| 2180 // a loop backedge with that doesn't have any work on the backedge. This | |
| 2181 // helps me construct nested loops with shared headers better. | |
| 2182 // | |
| 2183 // Once I've done the forward recursion, I do the post-work. For each child | |
| 2184 // I check to see if there is a backedge. Backedges define a loop! I | |
| 2185 // insert an IdealLoopTree at the target of the backedge. | |
| 2186 // | |
| 2187 // During the post-work I also check to see if I have several children | |
| 2188 // belonging to different loops. If so, then this Node is a decision point | |
| 2189 // where control flow can choose to change loop nests. It is at this | |
| 2190 // decision point where I can figure out how loops are nested. At this | |
| 2191 // time I can properly order the different loop nests from my children. | |
| 2192 // Note that there may not be any backedges at the decision point! | |
| 2193 // | |
| 2194 // Since the decision point can be far removed from the backedges, I can't | |
| 2195 // order my loops at the time I discover them. Thus at the decision point | |
| 2196 // I need to inspect loop header pre-order numbers to properly nest my | |
| 2197 // loops. This means I need to sort my childrens' loops by pre-order. | |
| 2198 // The sort is of size number-of-control-children, which generally limits | |
| 2199 // it to size 2 (i.e., I just choose between my 2 target loops). | |
| 2200 void PhaseIdealLoop::build_loop_tree() { | |
| 2201 // Allocate stack of size C->unique()/2 to avoid frequent realloc | |
| 2202 GrowableArray <Node *> bltstack(C->unique() >> 1); | |
| 2203 Node *n = C->root(); | |
| 2204 bltstack.push(n); | |
| 2205 int pre_order = 1; | |
| 2206 int stack_size; | |
| 2207 | |
| 2208 while ( ( stack_size = bltstack.length() ) != 0 ) { | |
| 2209 n = bltstack.top(); // Leave node on stack | |
| 2210 if ( !is_visited(n) ) { | |
| 2211 // ---- Pre-pass Work ---- | |
| 2212 // Pre-walked but not post-walked nodes need a pre_order number. | |
| 2213 | |
| 2214 set_preorder_visited( n, pre_order ); // set as visited | |
| 2215 | |
| 2216 // ---- Scan over children ---- | |
| 2217 // Scan first over control projections that lead to loop headers. | |
| 2218 // This helps us find inner-to-outer loops with shared headers better. | |
| 2219 | |
| 2220 // Scan children's children for loop headers. | |
| 2221 for ( int i = n->outcnt() - 1; i >= 0; --i ) { | |
| 2222 Node* m = n->raw_out(i); // Child | |
| 2223 if( m->is_CFG() && !is_visited(m) ) { // Only for CFG children | |
| 2224 // Scan over children's children to find loop | |
| 2225 for (DUIterator_Fast jmax, j = m->fast_outs(jmax); j < jmax; j++) { | |
| 2226 Node* l = m->fast_out(j); | |
| 2227 if( is_visited(l) && // Been visited? | |
| 2228 !is_postvisited(l) && // But not post-visited | |
| 2229 get_preorder(l) < pre_order ) { // And smaller pre-order | |
| 2230 // Found! Scan the DFS down this path before doing other paths | |
| 2231 bltstack.push(m); | |
| 2232 break; | |
| 2233 } | |
| 2234 } | |
| 2235 } | |
| 2236 } | |
| 2237 pre_order++; | |
| 2238 } | |
| 2239 else if ( !is_postvisited(n) ) { | |
| 2240 // Note: build_loop_tree_impl() adds out edges on rare occasions, | |
| 2241 // such as com.sun.rsasign.am::a. | |
| 2242 // For non-recursive version, first, process current children. | |
| 2243 // On next iteration, check if additional children were added. | |
| 2244 for ( int k = n->outcnt() - 1; k >= 0; --k ) { | |
| 2245 Node* u = n->raw_out(k); | |
| 2246 if ( u->is_CFG() && !is_visited(u) ) { | |
| 2247 bltstack.push(u); | |
| 2248 } | |
| 2249 } | |
| 2250 if ( bltstack.length() == stack_size ) { | |
| 2251 // There were no additional children, post visit node now | |
| 2252 (void)bltstack.pop(); // Remove node from stack | |
| 2253 pre_order = build_loop_tree_impl( n, pre_order ); | |
| 2254 // Check for bailout | |
| 2255 if (C->failing()) { | |
| 2256 return; | |
| 2257 } | |
| 2258 // Check to grow _preorders[] array for the case when | |
| 2259 // build_loop_tree_impl() adds new nodes. | |
| 2260 check_grow_preorders(); | |
| 2261 } | |
| 2262 } | |
| 2263 else { | |
| 2264 (void)bltstack.pop(); // Remove post-visited node from stack | |
| 2265 } | |
| 2266 } | |
| 2267 } | |
| 2268 | |
| 2269 //------------------------------build_loop_tree_impl--------------------------- | |
| 2270 int PhaseIdealLoop::build_loop_tree_impl( Node *n, int pre_order ) { | |
| 2271 // ---- Post-pass Work ---- | |
| 2272 // Pre-walked but not post-walked nodes need a pre_order number. | |
| 2273 | |
| 2274 // Tightest enclosing loop for this Node | |
| 2275 IdealLoopTree *innermost = NULL; | |
| 2276 | |
| 2277 // For all children, see if any edge is a backedge. If so, make a loop | |
| 2278 // for it. Then find the tightest enclosing loop for the self Node. | |
| 2279 for (DUIterator_Fast imax, i = n->fast_outs(imax); i < imax; i++) { | |
| 2280 Node* m = n->fast_out(i); // Child | |
| 2281 if( n == m ) continue; // Ignore control self-cycles | |
| 2282 if( !m->is_CFG() ) continue;// Ignore non-CFG edges | |
| 2283 | |
| 2284 IdealLoopTree *l; // Child's loop | |
| 2285 if( !is_postvisited(m) ) { // Child visited but not post-visited? | |
| 2286 // Found a backedge | |
| 2287 assert( get_preorder(m) < pre_order, "should be backedge" ); | |
| 2288 // Check for the RootNode, which is already a LoopNode and is allowed | |
| 2289 // to have multiple "backedges". | |
| 2290 if( m == C->root()) { // Found the root? | |
| 2291 l = _ltree_root; // Root is the outermost LoopNode | |
| 2292 } else { // Else found a nested loop | |
| 2293 // Insert a LoopNode to mark this loop. | |
| 2294 l = new IdealLoopTree(this, m, n); | |
| 2295 } // End of Else found a nested loop | |
| 2296 if( !has_loop(m) ) // If 'm' does not already have a loop set | |
| 2297 set_loop(m, l); // Set loop header to loop now | |
| 2298 | |
| 2299 } else { // Else not a nested loop | |
| 2300 if( !_nodes[m->_idx] ) continue; // Dead code has no loop | |
| 2301 l = get_loop(m); // Get previously determined loop | |
| 2302 // If successor is header of a loop (nest), move up-loop till it | |
| 2303 // is a member of some outer enclosing loop. Since there are no | |
| 2304 // shared headers (I've split them already) I only need to go up | |
| 2305 // at most 1 level. | |
| 2306 while( l && l->_head == m ) // Successor heads loop? | |
| 2307 l = l->_parent; // Move up 1 for me | |
| 2308 // If this loop is not properly parented, then this loop | |
| 2309 // has no exit path out, i.e. its an infinite loop. | |
| 2310 if( !l ) { | |
| 2311 // Make loop "reachable" from root so the CFG is reachable. Basically | |
| 2312 // insert a bogus loop exit that is never taken. 'm', the loop head, | |
| 2313 // points to 'n', one (of possibly many) fall-in paths. There may be | |
| 2314 // many backedges as well. | |
| 2315 | |
| 2316 // Here I set the loop to be the root loop. I could have, after | |
| 2317 // inserting a bogus loop exit, restarted the recursion and found my | |
| 2318 // new loop exit. This would make the infinite loop a first-class | |
| 2319 // loop and it would then get properly optimized. What's the use of | |
| 2320 // optimizing an infinite loop? | |
| 2321 l = _ltree_root; // Oops, found infinite loop | |
| 2322 | |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2323 if (!_verify_only) { |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2324 // Insert the NeverBranch between 'm' and it's control user. |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2325 NeverBranchNode *iff = new (C, 1) NeverBranchNode( m ); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2326 _igvn.register_new_node_with_optimizer(iff); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2327 set_loop(iff, l); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2328 Node *if_t = new (C, 1) CProjNode( iff, 0 ); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2329 _igvn.register_new_node_with_optimizer(if_t); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2330 set_loop(if_t, l); |
| 0 | 2331 |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2332 Node* cfg = NULL; // Find the One True Control User of m |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2333 for (DUIterator_Fast jmax, j = m->fast_outs(jmax); j < jmax; j++) { |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2334 Node* x = m->fast_out(j); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2335 if (x->is_CFG() && x != m && x != iff) |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2336 { cfg = x; break; } |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2337 } |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2338 assert(cfg != NULL, "must find the control user of m"); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2339 uint k = 0; // Probably cfg->in(0) |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2340 while( cfg->in(k) != m ) k++; // But check incase cfg is a Region |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2341 cfg->set_req( k, if_t ); // Now point to NeverBranch |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2342 |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2343 // Now create the never-taken loop exit |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2344 Node *if_f = new (C, 1) CProjNode( iff, 1 ); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2345 _igvn.register_new_node_with_optimizer(if_f); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2346 set_loop(if_f, l); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2347 // Find frame ptr for Halt. Relies on the optimizer |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2348 // V-N'ing. Easier and quicker than searching through |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2349 // the program structure. |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2350 Node *frame = new (C, 1) ParmNode( C->start(), TypeFunc::FramePtr ); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2351 _igvn.register_new_node_with_optimizer(frame); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2352 // Halt & Catch Fire |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2353 Node *halt = new (C, TypeFunc::Parms) HaltNode( if_f, frame ); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2354 _igvn.register_new_node_with_optimizer(halt); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2355 set_loop(halt, l); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2356 C->root()->add_req(halt); |
| 0 | 2357 } |
| 2358 set_loop(C->root(), _ltree_root); | |
| 2359 } | |
| 2360 } | |
| 2361 // Weeny check for irreducible. This child was already visited (this | |
| 2362 // IS the post-work phase). Is this child's loop header post-visited | |
| 2363 // as well? If so, then I found another entry into the loop. | |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2364 if (!_verify_only) { |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2365 while( is_postvisited(l->_head) ) { |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2366 // found irreducible |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2367 l->_irreducible = 1; // = true |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2368 l = l->_parent; |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2369 _has_irreducible_loops = true; |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2370 // Check for bad CFG here to prevent crash, and bailout of compile |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2371 if (l == NULL) { |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2372 C->record_method_not_compilable("unhandled CFG detected during loop optimization"); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2373 return pre_order; |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2374 } |
| 0 | 2375 } |
| 2376 } | |
| 2377 | |
| 2378 // This Node might be a decision point for loops. It is only if | |
| 2379 // it's children belong to several different loops. The sort call | |
| 2380 // does a trivial amount of work if there is only 1 child or all | |
| 2381 // children belong to the same loop. If however, the children | |
| 2382 // belong to different loops, the sort call will properly set the | |
| 2383 // _parent pointers to show how the loops nest. | |
| 2384 // | |
| 2385 // In any case, it returns the tightest enclosing loop. | |
| 2386 innermost = sort( l, innermost ); | |
| 2387 } | |
| 2388 | |
| 2389 // Def-use info will have some dead stuff; dead stuff will have no | |
| 2390 // loop decided on. | |
| 2391 | |
| 2392 // Am I a loop header? If so fix up my parent's child and next ptrs. | |
| 2393 if( innermost && innermost->_head == n ) { | |
| 2394 assert( get_loop(n) == innermost, "" ); | |
| 2395 IdealLoopTree *p = innermost->_parent; | |
| 2396 IdealLoopTree *l = innermost; | |
| 2397 while( p && l->_head == n ) { | |
| 2398 l->_next = p->_child; // Put self on parents 'next child' | |
| 2399 p->_child = l; // Make self as first child of parent | |
| 2400 l = p; // Now walk up the parent chain | |
| 2401 p = l->_parent; | |
| 2402 } | |
| 2403 } else { | |
| 2404 // Note that it is possible for a LoopNode to reach here, if the | |
| 2405 // backedge has been made unreachable (hence the LoopNode no longer | |
| 2406 // denotes a Loop, and will eventually be removed). | |
| 2407 | |
| 2408 // Record tightest enclosing loop for self. Mark as post-visited. | |
| 2409 set_loop(n, innermost); | |
| 2410 // Also record has_call flag early on | |
| 2411 if( innermost ) { | |
| 2412 if( n->is_Call() && !n->is_CallLeaf() && !n->is_macro() ) { | |
| 2413 // Do not count uncommon calls | |
| 2414 if( !n->is_CallStaticJava() || !n->as_CallStaticJava()->_name ) { | |
| 2415 Node *iff = n->in(0)->in(0); | |
| 2416 if( !iff->is_If() || | |
| 2417 (n->in(0)->Opcode() == Op_IfFalse && | |
| 2418 (1.0 - iff->as_If()->_prob) >= 0.01) || | |
| 2419 (iff->as_If()->_prob >= 0.01) ) | |
| 2420 innermost->_has_call = 1; | |
| 2421 } | |
|
39
76256d272075
6667612: (Escape Analysis) disable loop cloning if it has a scalar replaceable allocation
kvn
parents:
17
diff
changeset
|
2422 } else if( n->is_Allocate() && n->as_Allocate()->_is_scalar_replaceable ) { |
|
76256d272075
6667612: (Escape Analysis) disable loop cloning if it has a scalar replaceable allocation
kvn
parents:
17
diff
changeset
|
2423 // Disable loop optimizations if the loop has a scalar replaceable |
|
76256d272075
6667612: (Escape Analysis) disable loop cloning if it has a scalar replaceable allocation
kvn
parents:
17
diff
changeset
|
2424 // allocation. This disabling may cause a potential performance lost |
|
76256d272075
6667612: (Escape Analysis) disable loop cloning if it has a scalar replaceable allocation
kvn
parents:
17
diff
changeset
|
2425 // if the allocation is not eliminated for some reason. |
|
76256d272075
6667612: (Escape Analysis) disable loop cloning if it has a scalar replaceable allocation
kvn
parents:
17
diff
changeset
|
2426 innermost->_allow_optimizations = false; |
|
76256d272075
6667612: (Escape Analysis) disable loop cloning if it has a scalar replaceable allocation
kvn
parents:
17
diff
changeset
|
2427 innermost->_has_call = 1; // = true |
| 0 | 2428 } |
| 2429 } | |
| 2430 } | |
| 2431 | |
| 2432 // Flag as post-visited now | |
| 2433 set_postvisited(n); | |
| 2434 return pre_order; | |
| 2435 } | |
| 2436 | |
| 2437 | |
| 2438 //------------------------------build_loop_early------------------------------- | |
| 2439 // Put Data nodes into some loop nest, by setting the _nodes[]->loop mapping. | |
| 2440 // First pass computes the earliest controlling node possible. This is the | |
| 2441 // controlling input with the deepest dominating depth. | |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2442 void PhaseIdealLoop::build_loop_early( VectorSet &visited, Node_List &worklist, Node_Stack &nstack ) { |
| 0 | 2443 while (worklist.size() != 0) { |
| 2444 // Use local variables nstack_top_n & nstack_top_i to cache values | |
| 2445 // on nstack's top. | |
| 2446 Node *nstack_top_n = worklist.pop(); | |
| 2447 uint nstack_top_i = 0; | |
| 2448 //while_nstack_nonempty: | |
| 2449 while (true) { | |
| 2450 // Get parent node and next input's index from stack's top. | |
| 2451 Node *n = nstack_top_n; | |
| 2452 uint i = nstack_top_i; | |
| 2453 uint cnt = n->req(); // Count of inputs | |
| 2454 if (i == 0) { // Pre-process the node. | |
| 2455 if( has_node(n) && // Have either loop or control already? | |
| 2456 !has_ctrl(n) ) { // Have loop picked out already? | |
| 2457 // During "merge_many_backedges" we fold up several nested loops | |
| 2458 // into a single loop. This makes the members of the original | |
| 2459 // loop bodies pointing to dead loops; they need to move up | |
| 2460 // to the new UNION'd larger loop. I set the _head field of these | |
| 2461 // dead loops to NULL and the _parent field points to the owning | |
| 2462 // loop. Shades of UNION-FIND algorithm. | |
| 2463 IdealLoopTree *ilt; | |
| 2464 while( !(ilt = get_loop(n))->_head ) { | |
| 2465 // Normally I would use a set_loop here. But in this one special | |
| 2466 // case, it is legal (and expected) to change what loop a Node | |
| 2467 // belongs to. | |
| 2468 _nodes.map(n->_idx, (Node*)(ilt->_parent) ); | |
| 2469 } | |
| 2470 // Remove safepoints ONLY if I've already seen I don't need one. | |
| 2471 // (the old code here would yank a 2nd safepoint after seeing a | |
| 2472 // first one, even though the 1st did not dominate in the loop body | |
| 2473 // and thus could be avoided indefinitely) | |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2474 if( !_verify_only && !_verify_me && ilt->_has_sfpt && n->Opcode() == Op_SafePoint && |
| 0 | 2475 is_deleteable_safept(n)) { |
| 2476 Node *in = n->in(TypeFunc::Control); | |
| 2477 lazy_replace(n,in); // Pull safepoint now | |
| 2478 // Carry on with the recursion "as if" we are walking | |
| 2479 // only the control input | |
| 2480 if( !visited.test_set( in->_idx ) ) { | |
| 2481 worklist.push(in); // Visit this guy later, using worklist | |
| 2482 } | |
| 2483 // Get next node from nstack: | |
| 2484 // - skip n's inputs processing by setting i > cnt; | |
| 2485 // - we also will not call set_early_ctrl(n) since | |
| 2486 // has_node(n) == true (see the condition above). | |
| 2487 i = cnt + 1; | |
| 2488 } | |
| 2489 } | |
| 2490 } // if (i == 0) | |
| 2491 | |
| 2492 // Visit all inputs | |
| 2493 bool done = true; // Assume all n's inputs will be processed | |
| 2494 while (i < cnt) { | |
| 2495 Node *in = n->in(i); | |
| 2496 ++i; | |
| 2497 if (in == NULL) continue; | |
| 2498 if (in->pinned() && !in->is_CFG()) | |
| 2499 set_ctrl(in, in->in(0)); | |
| 2500 int is_visited = visited.test_set( in->_idx ); | |
| 2501 if (!has_node(in)) { // No controlling input yet? | |
| 2502 assert( !in->is_CFG(), "CFG Node with no controlling input?" ); | |
| 2503 assert( !is_visited, "visit only once" ); | |
| 2504 nstack.push(n, i); // Save parent node and next input's index. | |
| 2505 nstack_top_n = in; // Process current input now. | |
| 2506 nstack_top_i = 0; | |
| 2507 done = false; // Not all n's inputs processed. | |
| 2508 break; // continue while_nstack_nonempty; | |
| 2509 } else if (!is_visited) { | |
| 2510 // This guy has a location picked out for him, but has not yet | |
| 2511 // been visited. Happens to all CFG nodes, for instance. | |
| 2512 // Visit him using the worklist instead of recursion, to break | |
| 2513 // cycles. Since he has a location already we do not need to | |
| 2514 // find his location before proceeding with the current Node. | |
| 2515 worklist.push(in); // Visit this guy later, using worklist | |
| 2516 } | |
| 2517 } | |
| 2518 if (done) { | |
| 2519 // All of n's inputs have been processed, complete post-processing. | |
| 2520 | |
| 605 | 2521 // Compute earliest point this Node can go. |
| 0 | 2522 // CFG, Phi, pinned nodes already know their controlling input. |
| 2523 if (!has_node(n)) { | |
| 2524 // Record earliest legal location | |
| 2525 set_early_ctrl( n ); | |
| 2526 } | |
| 2527 if (nstack.is_empty()) { | |
| 2528 // Finished all nodes on stack. | |
| 2529 // Process next node on the worklist. | |
| 2530 break; | |
| 2531 } | |
| 2532 // Get saved parent node and next input's index. | |
| 2533 nstack_top_n = nstack.node(); | |
| 2534 nstack_top_i = nstack.index(); | |
| 2535 nstack.pop(); | |
| 2536 } | |
| 2537 } // while (true) | |
| 2538 } | |
| 2539 } | |
| 2540 | |
| 2541 //------------------------------dom_lca_internal-------------------------------- | |
| 2542 // Pair-wise LCA | |
| 2543 Node *PhaseIdealLoop::dom_lca_internal( Node *n1, Node *n2 ) const { | |
| 2544 if( !n1 ) return n2; // Handle NULL original LCA | |
| 2545 assert( n1->is_CFG(), "" ); | |
| 2546 assert( n2->is_CFG(), "" ); | |
| 2547 // find LCA of all uses | |
| 2548 uint d1 = dom_depth(n1); | |
| 2549 uint d2 = dom_depth(n2); | |
| 2550 while (n1 != n2) { | |
| 2551 if (d1 > d2) { | |
| 2552 n1 = idom(n1); | |
| 2553 d1 = dom_depth(n1); | |
| 2554 } else if (d1 < d2) { | |
| 2555 n2 = idom(n2); | |
| 2556 d2 = dom_depth(n2); | |
| 2557 } else { | |
| 2558 // Here d1 == d2. Due to edits of the dominator-tree, sections | |
| 2559 // of the tree might have the same depth. These sections have | |
| 2560 // to be searched more carefully. | |
| 2561 | |
| 2562 // Scan up all the n1's with equal depth, looking for n2. | |
| 2563 Node *t1 = idom(n1); | |
| 2564 while (dom_depth(t1) == d1) { | |
| 2565 if (t1 == n2) return n2; | |
| 2566 t1 = idom(t1); | |
| 2567 } | |
| 2568 // Scan up all the n2's with equal depth, looking for n1. | |
| 2569 Node *t2 = idom(n2); | |
| 2570 while (dom_depth(t2) == d2) { | |
| 2571 if (t2 == n1) return n1; | |
| 2572 t2 = idom(t2); | |
| 2573 } | |
| 2574 // Move up to a new dominator-depth value as well as up the dom-tree. | |
| 2575 n1 = t1; | |
| 2576 n2 = t2; | |
| 2577 d1 = dom_depth(n1); | |
| 2578 d2 = dom_depth(n2); | |
| 2579 } | |
| 2580 } | |
| 2581 return n1; | |
| 2582 } | |
| 2583 | |
| 2584 //------------------------------compute_idom----------------------------------- | |
| 2585 // Locally compute IDOM using dom_lca call. Correct only if the incoming | |
| 2586 // IDOMs are correct. | |
| 2587 Node *PhaseIdealLoop::compute_idom( Node *region ) const { | |
| 2588 assert( region->is_Region(), "" ); | |
| 2589 Node *LCA = NULL; | |
| 2590 for( uint i = 1; i < region->req(); i++ ) { | |
| 2591 if( region->in(i) != C->top() ) | |
| 2592 LCA = dom_lca( LCA, region->in(i) ); | |
| 2593 } | |
| 2594 return LCA; | |
| 2595 } | |
| 2596 | |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2597 bool PhaseIdealLoop::verify_dominance(Node* n, Node* use, Node* LCA, Node* early) { |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2598 bool had_error = false; |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2599 #ifdef ASSERT |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2600 if (early != C->root()) { |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2601 // Make sure that there's a dominance path from use to LCA |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2602 Node* d = use; |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2603 while (d != LCA) { |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2604 d = idom(d); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2605 if (d == C->root()) { |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2606 tty->print_cr("*** Use %d isn't dominated by def %s", use->_idx, n->_idx); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2607 n->dump(); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2608 use->dump(); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2609 had_error = true; |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2610 break; |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2611 } |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2612 } |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2613 } |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2614 #endif |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2615 return had_error; |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2616 } |
| 0 | 2617 |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2618 |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2619 Node* PhaseIdealLoop::compute_lca_of_uses(Node* n, Node* early, bool verify) { |
| 0 | 2620 // Compute LCA over list of uses |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2621 bool had_error = false; |
| 0 | 2622 Node *LCA = NULL; |
| 2623 for (DUIterator_Fast imax, i = n->fast_outs(imax); i < imax && LCA != early; i++) { | |
| 2624 Node* c = n->fast_out(i); | |
| 2625 if (_nodes[c->_idx] == NULL) | |
| 2626 continue; // Skip the occasional dead node | |
| 2627 if( c->is_Phi() ) { // For Phis, we must land above on the path | |
| 2628 for( uint j=1; j<c->req(); j++ ) {// For all inputs | |
| 2629 if( c->in(j) == n ) { // Found matching input? | |
| 2630 Node *use = c->in(0)->in(j); | |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2631 if (_verify_only && use->is_top()) continue; |
| 0 | 2632 LCA = dom_lca_for_get_late_ctrl( LCA, use, n ); |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2633 if (verify) had_error = verify_dominance(n, use, LCA, early) || had_error; |
| 0 | 2634 } |
| 2635 } | |
| 2636 } else { | |
| 2637 // For CFG data-users, use is in the block just prior | |
| 2638 Node *use = has_ctrl(c) ? get_ctrl(c) : c->in(0); | |
| 2639 LCA = dom_lca_for_get_late_ctrl( LCA, use, n ); | |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2640 if (verify) had_error = verify_dominance(n, use, LCA, early) || had_error; |
| 0 | 2641 } |
| 2642 } | |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2643 assert(!had_error, "bad dominance"); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2644 return LCA; |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2645 } |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2646 |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2647 //------------------------------get_late_ctrl---------------------------------- |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2648 // Compute latest legal control. |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2649 Node *PhaseIdealLoop::get_late_ctrl( Node *n, Node *early ) { |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2650 assert(early != NULL, "early control should not be NULL"); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2651 |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2652 Node* LCA = compute_lca_of_uses(n, early); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2653 #ifdef ASSERT |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2654 if (LCA == C->root() && LCA != early) { |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2655 // def doesn't dominate uses so print some useful debugging output |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2656 compute_lca_of_uses(n, early, true); |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2657 } |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2658 #endif |
| 0 | 2659 |
| 2660 // if this is a load, check for anti-dependent stores | |
| 2661 // We use a conservative algorithm to identify potential interfering | |
| 2662 // instructions and for rescheduling the load. The users of the memory | |
| 2663 // input of this load are examined. Any use which is not a load and is | |
| 2664 // dominated by early is considered a potentially interfering store. | |
| 2665 // This can produce false positives. | |
| 2666 if (n->is_Load() && LCA != early) { | |
| 2667 Node_List worklist; | |
| 2668 | |
| 2669 Node *mem = n->in(MemNode::Memory); | |
| 2670 for (DUIterator_Fast imax, i = mem->fast_outs(imax); i < imax; i++) { | |
| 2671 Node* s = mem->fast_out(i); | |
| 2672 worklist.push(s); | |
| 2673 } | |
| 2674 while(worklist.size() != 0 && LCA != early) { | |
| 2675 Node* s = worklist.pop(); | |
| 2676 if (s->is_Load()) { | |
| 2677 continue; | |
| 2678 } else if (s->is_MergeMem()) { | |
| 2679 for (DUIterator_Fast imax, i = s->fast_outs(imax); i < imax; i++) { | |
| 2680 Node* s1 = s->fast_out(i); | |
| 2681 worklist.push(s1); | |
| 2682 } | |
| 2683 } else { | |
| 2684 Node *sctrl = has_ctrl(s) ? get_ctrl(s) : s->in(0); | |
| 2685 assert(sctrl != NULL || s->outcnt() == 0, "must have control"); | |
| 2686 if (sctrl != NULL && !sctrl->is_top() && is_dominator(early, sctrl)) { | |
| 2687 LCA = dom_lca_for_get_late_ctrl(LCA, sctrl, n); | |
| 2688 } | |
| 2689 } | |
| 2690 } | |
| 2691 } | |
| 2692 | |
| 2693 assert(LCA == find_non_split_ctrl(LCA), "unexpected late control"); | |
| 2694 return LCA; | |
| 2695 } | |
| 2696 | |
| 2697 // true if CFG node d dominates CFG node n | |
| 2698 bool PhaseIdealLoop::is_dominator(Node *d, Node *n) { | |
| 2699 if (d == n) | |
| 2700 return true; | |
| 2701 assert(d->is_CFG() && n->is_CFG(), "must have CFG nodes"); | |
| 2702 uint dd = dom_depth(d); | |
| 2703 while (dom_depth(n) >= dd) { | |
| 2704 if (n == d) | |
| 2705 return true; | |
| 2706 n = idom(n); | |
| 2707 } | |
| 2708 return false; | |
| 2709 } | |
| 2710 | |
| 2711 //------------------------------dom_lca_for_get_late_ctrl_internal------------- | |
| 2712 // Pair-wise LCA with tags. | |
| 2713 // Tag each index with the node 'tag' currently being processed | |
| 2714 // before advancing up the dominator chain using idom(). | |
| 2715 // Later calls that find a match to 'tag' know that this path has already | |
| 2716 // been considered in the current LCA (which is input 'n1' by convention). | |
| 2717 // Since get_late_ctrl() is only called once for each node, the tag array | |
| 2718 // does not need to be cleared between calls to get_late_ctrl(). | |
| 2719 // Algorithm trades a larger constant factor for better asymptotic behavior | |
| 2720 // | |
| 2721 Node *PhaseIdealLoop::dom_lca_for_get_late_ctrl_internal( Node *n1, Node *n2, Node *tag ) { | |
| 2722 uint d1 = dom_depth(n1); | |
| 2723 uint d2 = dom_depth(n2); | |
| 2724 | |
| 2725 do { | |
| 2726 if (d1 > d2) { | |
| 2727 // current lca is deeper than n2 | |
| 2728 _dom_lca_tags.map(n1->_idx, tag); | |
| 2729 n1 = idom(n1); | |
| 2730 d1 = dom_depth(n1); | |
| 2731 } else if (d1 < d2) { | |
| 2732 // n2 is deeper than current lca | |
| 2733 Node *memo = _dom_lca_tags[n2->_idx]; | |
| 2734 if( memo == tag ) { | |
| 2735 return n1; // Return the current LCA | |
| 2736 } | |
| 2737 _dom_lca_tags.map(n2->_idx, tag); | |
| 2738 n2 = idom(n2); | |
| 2739 d2 = dom_depth(n2); | |
| 2740 } else { | |
| 2741 // Here d1 == d2. Due to edits of the dominator-tree, sections | |
| 2742 // of the tree might have the same depth. These sections have | |
| 2743 // to be searched more carefully. | |
| 2744 | |
| 2745 // Scan up all the n1's with equal depth, looking for n2. | |
| 2746 _dom_lca_tags.map(n1->_idx, tag); | |
| 2747 Node *t1 = idom(n1); | |
| 2748 while (dom_depth(t1) == d1) { | |
| 2749 if (t1 == n2) return n2; | |
| 2750 _dom_lca_tags.map(t1->_idx, tag); | |
| 2751 t1 = idom(t1); | |
| 2752 } | |
| 2753 // Scan up all the n2's with equal depth, looking for n1. | |
| 2754 _dom_lca_tags.map(n2->_idx, tag); | |
| 2755 Node *t2 = idom(n2); | |
| 2756 while (dom_depth(t2) == d2) { | |
| 2757 if (t2 == n1) return n1; | |
| 2758 _dom_lca_tags.map(t2->_idx, tag); | |
| 2759 t2 = idom(t2); | |
| 2760 } | |
| 2761 // Move up to a new dominator-depth value as well as up the dom-tree. | |
| 2762 n1 = t1; | |
| 2763 n2 = t2; | |
| 2764 d1 = dom_depth(n1); | |
| 2765 d2 = dom_depth(n2); | |
| 2766 } | |
| 2767 } while (n1 != n2); | |
| 2768 return n1; | |
| 2769 } | |
| 2770 | |
| 2771 //------------------------------init_dom_lca_tags------------------------------ | |
| 2772 // Tag could be a node's integer index, 32bits instead of 64bits in some cases | |
| 2773 // Intended use does not involve any growth for the array, so it could | |
| 2774 // be of fixed size. | |
| 2775 void PhaseIdealLoop::init_dom_lca_tags() { | |
| 2776 uint limit = C->unique() + 1; | |
| 2777 _dom_lca_tags.map( limit, NULL ); | |
| 2778 #ifdef ASSERT | |
| 2779 for( uint i = 0; i < limit; ++i ) { | |
| 2780 assert(_dom_lca_tags[i] == NULL, "Must be distinct from each node pointer"); | |
| 2781 } | |
| 2782 #endif // ASSERT | |
| 2783 } | |
| 2784 | |
| 2785 //------------------------------clear_dom_lca_tags------------------------------ | |
| 2786 // Tag could be a node's integer index, 32bits instead of 64bits in some cases | |
| 2787 // Intended use does not involve any growth for the array, so it could | |
| 2788 // be of fixed size. | |
| 2789 void PhaseIdealLoop::clear_dom_lca_tags() { | |
| 2790 uint limit = C->unique() + 1; | |
| 2791 _dom_lca_tags.map( limit, NULL ); | |
| 2792 _dom_lca_tags.clear(); | |
| 2793 #ifdef ASSERT | |
| 2794 for( uint i = 0; i < limit; ++i ) { | |
| 2795 assert(_dom_lca_tags[i] == NULL, "Must be distinct from each node pointer"); | |
| 2796 } | |
| 2797 #endif // ASSERT | |
| 2798 } | |
| 2799 | |
| 2800 //------------------------------build_loop_late-------------------------------- | |
| 2801 // Put Data nodes into some loop nest, by setting the _nodes[]->loop mapping. | |
| 2802 // Second pass finds latest legal placement, and ideal loop placement. | |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2803 void PhaseIdealLoop::build_loop_late( VectorSet &visited, Node_List &worklist, Node_Stack &nstack ) { |
| 0 | 2804 while (worklist.size() != 0) { |
| 2805 Node *n = worklist.pop(); | |
| 2806 // Only visit once | |
| 2807 if (visited.test_set(n->_idx)) continue; | |
| 2808 uint cnt = n->outcnt(); | |
| 2809 uint i = 0; | |
| 2810 while (true) { | |
| 2811 assert( _nodes[n->_idx], "no dead nodes" ); | |
| 2812 // Visit all children | |
| 2813 if (i < cnt) { | |
| 2814 Node* use = n->raw_out(i); | |
| 2815 ++i; | |
| 2816 // Check for dead uses. Aggressively prune such junk. It might be | |
| 2817 // dead in the global sense, but still have local uses so I cannot | |
| 2818 // easily call 'remove_dead_node'. | |
| 2819 if( _nodes[use->_idx] != NULL || use->is_top() ) { // Not dead? | |
| 2820 // Due to cycles, we might not hit the same fixed point in the verify | |
| 2821 // pass as we do in the regular pass. Instead, visit such phis as | |
| 2822 // simple uses of the loop head. | |
| 2823 if( use->in(0) && (use->is_CFG() || use->is_Phi()) ) { | |
| 2824 if( !visited.test(use->_idx) ) | |
| 2825 worklist.push(use); | |
| 2826 } else if( !visited.test_set(use->_idx) ) { | |
| 2827 nstack.push(n, i); // Save parent and next use's index. | |
| 2828 n = use; // Process all children of current use. | |
| 2829 cnt = use->outcnt(); | |
| 2830 i = 0; | |
| 2831 } | |
| 2832 } else { | |
| 2833 // Do not visit around the backedge of loops via data edges. | |
| 2834 // push dead code onto a worklist | |
| 2835 _deadlist.push(use); | |
| 2836 } | |
| 2837 } else { | |
| 2838 // All of n's children have been processed, complete post-processing. | |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2839 build_loop_late_post(n); |
| 0 | 2840 if (nstack.is_empty()) { |
| 2841 // Finished all nodes on stack. | |
| 2842 // Process next node on the worklist. | |
| 2843 break; | |
| 2844 } | |
| 2845 // Get saved parent node and next use's index. Visit the rest of uses. | |
| 2846 n = nstack.node(); | |
| 2847 cnt = n->outcnt(); | |
| 2848 i = nstack.index(); | |
| 2849 nstack.pop(); | |
| 2850 } | |
| 2851 } | |
| 2852 } | |
| 2853 } | |
| 2854 | |
| 2855 //------------------------------build_loop_late_post--------------------------- | |
| 2856 // Put Data nodes into some loop nest, by setting the _nodes[]->loop mapping. | |
| 2857 // Second pass finds latest legal placement, and ideal loop placement. | |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2858 void PhaseIdealLoop::build_loop_late_post( Node *n ) { |
| 0 | 2859 |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2860 if (n->req() == 2 && n->Opcode() == Op_ConvI2L && !C->major_progress() && !_verify_only) { |
| 0 | 2861 _igvn._worklist.push(n); // Maybe we'll normalize it, if no more loops. |
| 2862 } | |
| 2863 | |
| 2864 // CFG and pinned nodes already handled | |
| 2865 if( n->in(0) ) { | |
| 2866 if( n->in(0)->is_top() ) return; // Dead? | |
| 2867 | |
| 2868 // We'd like +VerifyLoopOptimizations to not believe that Mod's/Loads | |
| 2869 // _must_ be pinned (they have to observe their control edge of course). | |
| 2870 // Unlike Stores (which modify an unallocable resource, the memory | |
| 2871 // state), Mods/Loads can float around. So free them up. | |
| 2872 bool pinned = true; | |
| 2873 switch( n->Opcode() ) { | |
| 2874 case Op_DivI: | |
| 2875 case Op_DivF: | |
| 2876 case Op_DivD: | |
| 2877 case Op_ModI: | |
| 2878 case Op_ModF: | |
| 2879 case Op_ModD: | |
| 2880 case Op_LoadB: // Same with Loads; they can sink | |
|
558
3b5ac9e7e6ea
6796746: rename LoadC (char) opcode class to LoadUS (unsigned short)
twisti
parents:
367
diff
changeset
|
2881 case Op_LoadUS: // during loop optimizations. |
| 0 | 2882 case Op_LoadD: |
| 2883 case Op_LoadF: | |
| 2884 case Op_LoadI: | |
| 2885 case Op_LoadKlass: | |
|
293
c3e045194476
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
235
diff
changeset
|
2886 case Op_LoadNKlass: |
| 0 | 2887 case Op_LoadL: |
| 2888 case Op_LoadS: | |
| 2889 case Op_LoadP: | |
|
293
c3e045194476
6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents:
235
diff
changeset
|
2890 case Op_LoadN: |
| 0 | 2891 case Op_LoadRange: |
| 2892 case Op_LoadD_unaligned: | |
| 2893 case Op_LoadL_unaligned: | |
| 2894 case Op_StrComp: // Does a bunch of load-like effects | |
| 681 | 2895 case Op_StrEquals: |
| 2896 case Op_StrIndexOf: | |
|
169
9148c65abefc
6695049: (coll) Create an x86 intrinsic for Arrays.equals
rasbold
parents:
39
diff
changeset
|
2897 case Op_AryEq: |
| 0 | 2898 pinned = false; |
| 2899 } | |
| 2900 if( pinned ) { | |
| 605 | 2901 IdealLoopTree *chosen_loop = get_loop(n->is_CFG() ? n : get_ctrl(n)); |
| 2902 if( !chosen_loop->_child ) // Inner loop? | |
| 2903 chosen_loop->_body.push(n); // Collect inner loops | |
| 0 | 2904 return; |
| 2905 } | |
| 2906 } else { // No slot zero | |
| 2907 if( n->is_CFG() ) { // CFG with no slot 0 is dead | |
| 2908 _nodes.map(n->_idx,0); // No block setting, it's globally dead | |
| 2909 return; | |
| 2910 } | |
| 2911 assert(!n->is_CFG() || n->outcnt() == 0, ""); | |
| 2912 } | |
| 2913 | |
| 2914 // Do I have a "safe range" I can select over? | |
| 2915 Node *early = get_ctrl(n);// Early location already computed | |
| 2916 | |
| 2917 // Compute latest point this Node can go | |
| 2918 Node *LCA = get_late_ctrl( n, early ); | |
| 2919 // LCA is NULL due to uses being dead | |
| 2920 if( LCA == NULL ) { | |
| 2921 #ifdef ASSERT | |
| 2922 for (DUIterator i1 = n->outs(); n->has_out(i1); i1++) { | |
| 2923 assert( _nodes[n->out(i1)->_idx] == NULL, "all uses must also be dead"); | |
| 2924 } | |
| 2925 #endif | |
| 2926 _nodes.map(n->_idx, 0); // This node is useless | |
| 2927 _deadlist.push(n); | |
| 2928 return; | |
| 2929 } | |
| 2930 assert(LCA != NULL && !LCA->is_top(), "no dead nodes"); | |
| 2931 | |
| 2932 Node *legal = LCA; // Walk 'legal' up the IDOM chain | |
| 2933 Node *least = legal; // Best legal position so far | |
| 2934 while( early != legal ) { // While not at earliest legal | |
| 1172 | 2935 #ifdef ASSERT |
| 2936 if (legal->is_Start() && !early->is_Root()) { | |
| 2937 // Bad graph. Print idom path and fail. | |
| 2938 tty->print_cr( "Bad graph detected in build_loop_late"); | |
| 2939 tty->print("n: ");n->dump(); tty->cr(); | |
| 2940 tty->print("early: ");early->dump(); tty->cr(); | |
| 2941 int ct = 0; | |
| 2942 Node *dbg_legal = LCA; | |
| 2943 while(!dbg_legal->is_Start() && ct < 100) { | |
| 2944 tty->print("idom[%d] ",ct); dbg_legal->dump(); tty->cr(); | |
| 2945 ct++; | |
| 2946 dbg_legal = idom(dbg_legal); | |
| 2947 } | |
| 2948 assert(false, "Bad graph detected in build_loop_late"); | |
| 2949 } | |
| 2950 #endif | |
| 0 | 2951 // Find least loop nesting depth |
| 2952 legal = idom(legal); // Bump up the IDOM tree | |
| 2953 // Check for lower nesting depth | |
| 2954 if( get_loop(legal)->_nest < get_loop(least)->_nest ) | |
| 2955 least = legal; | |
| 2956 } | |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2957 assert(early == legal || legal != C->root(), "bad dominance of inputs"); |
| 0 | 2958 |
| 2959 // Try not to place code on a loop entry projection | |
| 2960 // which can inhibit range check elimination. | |
| 2961 if (least != early) { | |
| 2962 Node* ctrl_out = least->unique_ctrl_out(); | |
| 2963 if (ctrl_out && ctrl_out->is_CountedLoop() && | |
| 2964 least == ctrl_out->in(LoopNode::EntryControl)) { | |
| 2965 Node* least_dom = idom(least); | |
| 2966 if (get_loop(least_dom)->is_member(get_loop(least))) { | |
| 2967 least = least_dom; | |
| 2968 } | |
| 2969 } | |
| 2970 } | |
| 2971 | |
| 2972 #ifdef ASSERT | |
| 2973 // If verifying, verify that 'verify_me' has a legal location | |
| 2974 // and choose it as our location. | |
|
921
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2975 if( _verify_me ) { |
|
046932b72aa2
6862956: PhaseIdealLoop should have a CFG verification mode
never
parents:
681
diff
changeset
|
2976 Node *v_ctrl = _verify_me->get_ctrl_no_update(n); |
| 0 | 2977 Node *legal = LCA; |
| 2978 while( early != legal ) { // While not at earliest legal | |
| 2979 if( legal == v_ctrl ) break; // Check for prior good location | |
| 2980 legal = idom(legal) ;// Bump up the IDOM tree | |
| 2981 } | |
| 2982 // Check for prior good location | |
| 2983 if( legal == v_ctrl ) least = legal; // Keep prior if found | |
| 2984 } | |
| 2985 #endif | |
| 2986 | |
| 2987 // Assign discovered "here or above" point | |
| 2988 least = find_non_split_ctrl(least); | |
| 2989 set_ctrl(n, least); | |
| 2990 | |
| 2991 // Collect inner loop bodies | |
| 605 | 2992 IdealLoopTree *chosen_loop = get_loop(least); |
| 2993 if( !chosen_loop->_child ) // Inner loop? | |
| 2994 chosen_loop->_body.push(n);// Collect inner loops | |
| 0 | 2995 } |
| 2996 | |
| 2997 #ifndef PRODUCT | |
| 2998 //------------------------------dump------------------------------------------- | |
| 2999 void PhaseIdealLoop::dump( ) const { | |
| 3000 ResourceMark rm; | |
| 3001 Arena* arena = Thread::current()->resource_area(); | |
| 3002 Node_Stack stack(arena, C->unique() >> 2); | |
| 3003 Node_List rpo_list; | |
| 3004 VectorSet visited(arena); | |
| 3005 visited.set(C->top()->_idx); | |
| 3006 rpo( C->root(), stack, visited, rpo_list ); | |
| 3007 // Dump root loop indexed by last element in PO order | |
| 3008 dump( _ltree_root, rpo_list.size(), rpo_list ); | |
| 3009 } | |
| 3010 | |
| 3011 void PhaseIdealLoop::dump( IdealLoopTree *loop, uint idx, Node_List &rpo_list ) const { | |
|
367
194b8e3a2fc4
6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents:
293
diff
changeset
|
3012 loop->dump_head(); |
| 0 | 3013 |
| 3014 // Now scan for CFG nodes in the same loop | |
| 3015 for( uint j=idx; j > 0; j-- ) { | |
| 3016 Node *n = rpo_list[j-1]; | |
| 3017 if( !_nodes[n->_idx] ) // Skip dead nodes | |
| 3018 continue; | |
| 3019 if( get_loop(n) != loop ) { // Wrong loop nest | |
| 3020 if( get_loop(n)->_head == n && // Found nested loop? | |
| 3021 get_loop(n)->_parent == loop ) | |
| 3022 dump(get_loop(n),rpo_list.size(),rpo_list); // Print it nested-ly | |
| 3023 continue; | |
| 3024 } | |
| 3025 | |
| 3026 // Dump controlling node | |
| 3027 for( uint x = 0; x < loop->_nest; x++ ) | |
| 3028 tty->print(" "); | |
| 3029 tty->print("C"); | |
| 3030 if( n == C->root() ) { | |
| 3031 n->dump(); | |
| 3032 } else { | |
| 3033 Node* cached_idom = idom_no_update(n); | |
| 3034 Node *computed_idom = n->in(0); | |
| 3035 if( n->is_Region() ) { | |
| 3036 computed_idom = compute_idom(n); | |
| 3037 // computed_idom() will return n->in(0) when idom(n) is an IfNode (or | |
| 3038 // any MultiBranch ctrl node), so apply a similar transform to | |
| 3039 // the cached idom returned from idom_no_update. | |
| 3040 cached_idom = find_non_split_ctrl(cached_idom); | |
| 3041 } | |
| 3042 tty->print(" ID:%d",computed_idom->_idx); | |
| 3043 n->dump(); | |
| 3044 if( cached_idom != computed_idom ) { | |
| 3045 tty->print_cr("*** BROKEN IDOM! Computed as: %d, cached as: %d", | |
| 3046 computed_idom->_idx, cached_idom->_idx); | |
| 3047 } | |
| 3048 } | |
| 3049 // Dump nodes it controls | |
| 3050 for( uint k = 0; k < _nodes.Size(); k++ ) { | |
| 3051 // (k < C->unique() && get_ctrl(find(k)) == n) | |
| 3052 if (k < C->unique() && _nodes[k] == (Node*)((intptr_t)n + 1)) { | |
| 3053 Node *m = C->root()->find(k); | |
| 3054 if( m && m->outcnt() > 0 ) { | |
| 3055 if (!(has_ctrl(m) && get_ctrl_no_update(m) == n)) { | |
| 3056 tty->print_cr("*** BROKEN CTRL ACCESSOR! _nodes[k] is %p, ctrl is %p", | |
| 3057 _nodes[k], has_ctrl(m) ? get_ctrl_no_update(m) : NULL); | |
| 3058 } | |
| 3059 for( uint j = 0; j < loop->_nest; j++ ) | |
| 3060 tty->print(" "); | |
| 3061 tty->print(" "); | |
| 3062 m->dump(); | |
| 3063 } | |
| 3064 } | |
| 3065 } | |
| 3066 } | |
| 3067 } | |
| 3068 | |
| 3069 // Collect a R-P-O for the whole CFG. | |
| 3070 // Result list is in post-order (scan backwards for RPO) | |
| 3071 void PhaseIdealLoop::rpo( Node *start, Node_Stack &stk, VectorSet &visited, Node_List &rpo_list ) const { | |
| 3072 stk.push(start, 0); | |
| 3073 visited.set(start->_idx); | |
| 3074 | |
| 3075 while (stk.is_nonempty()) { | |
| 3076 Node* m = stk.node(); | |
| 3077 uint idx = stk.index(); | |
| 3078 if (idx < m->outcnt()) { | |
| 3079 stk.set_index(idx + 1); | |
| 3080 Node* n = m->raw_out(idx); | |
| 3081 if (n->is_CFG() && !visited.test_set(n->_idx)) { | |
| 3082 stk.push(n, 0); | |
| 3083 } | |
| 3084 } else { | |
| 3085 rpo_list.push(m); | |
| 3086 stk.pop(); | |
| 3087 } | |
| 3088 } | |
| 3089 } | |
| 3090 #endif | |
| 3091 | |
| 3092 | |
| 3093 //============================================================================= | |
| 3094 //------------------------------LoopTreeIterator----------------------------------- | |
| 3095 | |
| 3096 // Advance to next loop tree using a preorder, left-to-right traversal. | |
| 3097 void LoopTreeIterator::next() { | |
| 3098 assert(!done(), "must not be done."); | |
| 3099 if (_curnt->_child != NULL) { | |
| 3100 _curnt = _curnt->_child; | |
| 3101 } else if (_curnt->_next != NULL) { | |
| 3102 _curnt = _curnt->_next; | |
| 3103 } else { | |
| 3104 while (_curnt != _root && _curnt->_next == NULL) { | |
| 3105 _curnt = _curnt->_parent; | |
| 3106 } | |
| 3107 if (_curnt == _root) { | |
| 3108 _curnt = NULL; | |
| 3109 assert(done(), "must be done."); | |
| 3110 } else { | |
| 3111 assert(_curnt->_next != NULL, "must be more to do"); | |
| 3112 _curnt = _curnt->_next; | |
| 3113 } | |
| 3114 } | |
| 3115 } |