Mercurial > hg > truffle
annotate src/share/vm/memory/referencePolicy.cpp @ 12301:2c022e432e10
8024974: Incorrect use of GC_locker::is_active()
Summary: SymbolTable and StringTable can make calls to GC_locker::is_active() outside a safepoint. This isn't safe because the GC_locker active state (lock count) is only updated at a safepoint and only remains valid as long as _needs_gc is true. However, outside a safepoint_needs_gc can change to false at any time, which makes it impossible to do a correct call to is_active() in that context. In this case these calls can just be removed since the input argument to basic_add() should never be on the heap and so there's no need to check the GC_locker state. This change also adjusts the assert() in is_active() to makes sure all calls to this function are always done under a safepoint.
Reviewed-by: brutisso, dcubed
Contributed-by: per.liden@oracle.com
| author | stefank |
|---|---|
| date | Fri, 20 Sep 2013 10:53:28 +0200 |
| parents | d1bdeef3e3e2 |
| children |
| rev | line source |
|---|---|
| 0 | 1 /* |
|
3992
d1bdeef3e3e2
7098282: G1: assert(interval >= 0) failed: Sanity check, referencePolicy.cpp: 76
johnc
parents:
1972
diff
changeset
|
2 * Copyright (c) 2000, 2011, Oracle and/or its affiliates. All rights reserved. |
| 0 | 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| 4 * | |
| 5 * This code is free software; you can redistribute it and/or modify it | |
| 6 * under the terms of the GNU General Public License version 2 only, as | |
| 7 * published by the Free Software Foundation. | |
| 8 * | |
| 9 * This code is distributed in the hope that it will be useful, but WITHOUT | |
| 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | |
| 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | |
| 12 * version 2 for more details (a copy is included in the LICENSE file that | |
| 13 * accompanied this code). | |
| 14 * | |
| 15 * You should have received a copy of the GNU General Public License version | |
| 16 * 2 along with this work; if not, write to the Free Software Foundation, | |
| 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | |
| 18 * | |
|
1552
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
470
diff
changeset
|
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
470
diff
changeset
|
20 * or visit www.oracle.com if you need additional information or have any |
|
c18cbe5936b8
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
470
diff
changeset
|
21 * questions. |
| 0 | 22 * |
| 23 */ | |
| 24 | |
| 1972 | 25 #include "precompiled.hpp" |
| 26 #include "classfile/javaClasses.hpp" | |
| 27 #include "memory/referencePolicy.hpp" | |
| 28 #include "memory/universe.hpp" | |
| 29 #include "runtime/arguments.hpp" | |
| 30 #include "runtime/globals.hpp" | |
| 0 | 31 |
| 32 LRUCurrentHeapPolicy::LRUCurrentHeapPolicy() { | |
|
457
27a80744a83b
6778647: snap(), snap_policy() should be renamed setup(), setup_policy()
ysr
parents:
453
diff
changeset
|
33 setup(); |
|
453
c96030fff130
6684579: SoftReference processing can be made more efficient
ysr
parents:
0
diff
changeset
|
34 } |
|
c96030fff130
6684579: SoftReference processing can be made more efficient
ysr
parents:
0
diff
changeset
|
35 |
|
c96030fff130
6684579: SoftReference processing can be made more efficient
ysr
parents:
0
diff
changeset
|
36 // Capture state (of-the-VM) information needed to evaluate the policy |
|
457
27a80744a83b
6778647: snap(), snap_policy() should be renamed setup(), setup_policy()
ysr
parents:
453
diff
changeset
|
37 void LRUCurrentHeapPolicy::setup() { |
| 0 | 38 _max_interval = (Universe::get_heap_free_at_last_gc() / M) * SoftRefLRUPolicyMSPerMB; |
| 39 assert(_max_interval >= 0,"Sanity check"); | |
| 40 } | |
| 41 | |
| 42 // The oop passed in is the SoftReference object, and not | |
| 43 // the object the SoftReference points to. | |
|
3992
d1bdeef3e3e2
7098282: G1: assert(interval >= 0) failed: Sanity check, referencePolicy.cpp: 76
johnc
parents:
1972
diff
changeset
|
44 bool LRUCurrentHeapPolicy::should_clear_reference(oop p, |
|
d1bdeef3e3e2
7098282: G1: assert(interval >= 0) failed: Sanity check, referencePolicy.cpp: 76
johnc
parents:
1972
diff
changeset
|
45 jlong timestamp_clock) { |
|
d1bdeef3e3e2
7098282: G1: assert(interval >= 0) failed: Sanity check, referencePolicy.cpp: 76
johnc
parents:
1972
diff
changeset
|
46 jlong interval = timestamp_clock - java_lang_ref_SoftReference::timestamp(p); |
| 0 | 47 assert(interval >= 0, "Sanity check"); |
| 48 | |
| 49 // The interval will be zero if the ref was accessed since the last scavenge/gc. | |
| 50 if(interval <= _max_interval) { | |
| 51 return false; | |
| 52 } | |
| 53 | |
| 54 return true; | |
| 55 } | |
| 56 | |
| 57 /////////////////////// MaxHeap ////////////////////// | |
| 58 | |
| 59 LRUMaxHeapPolicy::LRUMaxHeapPolicy() { | |
|
457
27a80744a83b
6778647: snap(), snap_policy() should be renamed setup(), setup_policy()
ysr
parents:
453
diff
changeset
|
60 setup(); |
|
453
c96030fff130
6684579: SoftReference processing can be made more efficient
ysr
parents:
0
diff
changeset
|
61 } |
|
c96030fff130
6684579: SoftReference processing can be made more efficient
ysr
parents:
0
diff
changeset
|
62 |
|
c96030fff130
6684579: SoftReference processing can be made more efficient
ysr
parents:
0
diff
changeset
|
63 // Capture state (of-the-VM) information needed to evaluate the policy |
|
457
27a80744a83b
6778647: snap(), snap_policy() should be renamed setup(), setup_policy()
ysr
parents:
453
diff
changeset
|
64 void LRUMaxHeapPolicy::setup() { |
| 0 | 65 size_t max_heap = MaxHeapSize; |
| 66 max_heap -= Universe::get_heap_used_at_last_gc(); | |
| 67 max_heap /= M; | |
| 68 | |
| 69 _max_interval = max_heap * SoftRefLRUPolicyMSPerMB; | |
| 70 assert(_max_interval >= 0,"Sanity check"); | |
| 71 } | |
| 72 | |
| 73 // The oop passed in is the SoftReference object, and not | |
| 74 // the object the SoftReference points to. | |
|
3992
d1bdeef3e3e2
7098282: G1: assert(interval >= 0) failed: Sanity check, referencePolicy.cpp: 76
johnc
parents:
1972
diff
changeset
|
75 bool LRUMaxHeapPolicy::should_clear_reference(oop p, |
|
d1bdeef3e3e2
7098282: G1: assert(interval >= 0) failed: Sanity check, referencePolicy.cpp: 76
johnc
parents:
1972
diff
changeset
|
76 jlong timestamp_clock) { |
|
d1bdeef3e3e2
7098282: G1: assert(interval >= 0) failed: Sanity check, referencePolicy.cpp: 76
johnc
parents:
1972
diff
changeset
|
77 jlong interval = timestamp_clock - java_lang_ref_SoftReference::timestamp(p); |
| 0 | 78 assert(interval >= 0, "Sanity check"); |
| 79 | |
| 80 // The interval will be zero if the ref was accessed since the last scavenge/gc. | |
| 81 if(interval <= _max_interval) { | |
| 82 return false; | |
| 83 } | |
| 84 | |
| 85 return true; | |
| 86 } |