annotate src/share/vm/opto/loopnode.cpp @ 4064:670a74b863fc

7107042: assert(no_dead_loop) failed: dead loop detected Summary: Use dead nodes elimination code in PhaseIdealLoop before executing EA. Reviewed-by: never, twisti
author kvn
date Wed, 09 Nov 2011 07:25:51 -0800
parents 2c24ef16533d
children e8fdaf4a66cb
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1 /*
2248
194c9fdee631 7017240: C2: native memory leak in nsk/regression/b4675027 on windows-x86 in comp mode with G1
kvn
parents: 1972
diff changeset
2 * Copyright (c) 1998, 2011, Oracle and/or its affiliates. All rights reserved.
0
a61af66fc99e Initial load
duke
parents:
diff changeset
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
a61af66fc99e Initial load
duke
parents:
diff changeset
4 *
a61af66fc99e Initial load
duke
parents:
diff changeset
5 * This code is free software; you can redistribute it and/or modify it
a61af66fc99e Initial load
duke
parents:
diff changeset
6 * under the terms of the GNU General Public License version 2 only, as
a61af66fc99e Initial load
duke
parents:
diff changeset
7 * published by the Free Software Foundation.
a61af66fc99e Initial load
duke
parents:
diff changeset
8 *
a61af66fc99e Initial load
duke
parents:
diff changeset
9 * This code is distributed in the hope that it will be useful, but WITHOUT
a61af66fc99e Initial load
duke
parents:
diff changeset
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
a61af66fc99e Initial load
duke
parents:
diff changeset
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
a61af66fc99e Initial load
duke
parents:
diff changeset
12 * version 2 for more details (a copy is included in the LICENSE file that
a61af66fc99e Initial load
duke
parents:
diff changeset
13 * accompanied this code).
a61af66fc99e Initial load
duke
parents:
diff changeset
14 *
a61af66fc99e Initial load
duke
parents:
diff changeset
15 * You should have received a copy of the GNU General Public License version
a61af66fc99e Initial load
duke
parents:
diff changeset
16 * 2 along with this work; if not, write to the Free Software Foundation,
a61af66fc99e Initial load
duke
parents:
diff changeset
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
a61af66fc99e Initial load
duke
parents:
diff changeset
18 *
1552
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 1172
diff changeset
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 1172
diff changeset
20 * or visit www.oracle.com if you need additional information or have any
c18cbe5936b8 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 1172
diff changeset
21 * questions.
0
a61af66fc99e Initial load
duke
parents:
diff changeset
22 *
a61af66fc99e Initial load
duke
parents:
diff changeset
23 */
a61af66fc99e Initial load
duke
parents:
diff changeset
24
1972
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1763
diff changeset
25 #include "precompiled.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1763
diff changeset
26 #include "ci/ciMethodData.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1763
diff changeset
27 #include "compiler/compileLog.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1763
diff changeset
28 #include "libadt/vectset.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1763
diff changeset
29 #include "memory/allocation.inline.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1763
diff changeset
30 #include "opto/addnode.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1763
diff changeset
31 #include "opto/callnode.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1763
diff changeset
32 #include "opto/connode.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1763
diff changeset
33 #include "opto/divnode.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1763
diff changeset
34 #include "opto/idealGraphPrinter.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1763
diff changeset
35 #include "opto/loopnode.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1763
diff changeset
36 #include "opto/mulnode.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1763
diff changeset
37 #include "opto/rootnode.hpp"
f95d63e2154a 6989984: Use standard include model for Hospot
stefank
parents: 1763
diff changeset
38 #include "opto/superword.hpp"
0
a61af66fc99e Initial load
duke
parents:
diff changeset
39
a61af66fc99e Initial load
duke
parents:
diff changeset
40 //=============================================================================
a61af66fc99e Initial load
duke
parents:
diff changeset
41 //------------------------------is_loop_iv-------------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
42 // Determine if a node is Counted loop induction variable.
a61af66fc99e Initial load
duke
parents:
diff changeset
43 // The method is declared in node.hpp.
a61af66fc99e Initial load
duke
parents:
diff changeset
44 const Node* Node::is_loop_iv() const {
a61af66fc99e Initial load
duke
parents:
diff changeset
45 if (this->is_Phi() && !this->as_Phi()->is_copy() &&
a61af66fc99e Initial load
duke
parents:
diff changeset
46 this->as_Phi()->region()->is_CountedLoop() &&
a61af66fc99e Initial load
duke
parents:
diff changeset
47 this->as_Phi()->region()->as_CountedLoop()->phi() == this) {
a61af66fc99e Initial load
duke
parents:
diff changeset
48 return this;
a61af66fc99e Initial load
duke
parents:
diff changeset
49 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
50 return NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
51 }
a61af66fc99e Initial load
duke
parents:
diff changeset
52 }
a61af66fc99e Initial load
duke
parents:
diff changeset
53
a61af66fc99e Initial load
duke
parents:
diff changeset
54 //=============================================================================
a61af66fc99e Initial load
duke
parents:
diff changeset
55 //------------------------------dump_spec--------------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
56 // Dump special per-node info
a61af66fc99e Initial load
duke
parents:
diff changeset
57 #ifndef PRODUCT
a61af66fc99e Initial load
duke
parents:
diff changeset
58 void LoopNode::dump_spec(outputStream *st) const {
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
59 if (is_inner_loop()) st->print( "inner " );
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
60 if (is_partial_peel_loop()) st->print( "partial_peel " );
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
61 if (partial_peel_has_failed()) st->print( "partial_peel_failed " );
0
a61af66fc99e Initial load
duke
parents:
diff changeset
62 }
a61af66fc99e Initial load
duke
parents:
diff changeset
63 #endif
a61af66fc99e Initial load
duke
parents:
diff changeset
64
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
65 //------------------------------is_valid_counted_loop-------------------------
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
66 bool LoopNode::is_valid_counted_loop() const {
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
67 if (is_CountedLoop()) {
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
68 CountedLoopNode* l = as_CountedLoop();
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
69 CountedLoopEndNode* le = l->loopexit();
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
70 if (le != NULL &&
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
71 le->proj_out(1 /* true */) == l->in(LoopNode::LoopBackControl)) {
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
72 Node* phi = l->phi();
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
73 Node* exit = le->proj_out(0 /* false */);
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
74 if (exit != NULL && exit->Opcode() == Op_IfFalse &&
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
75 phi != NULL && phi->is_Phi() &&
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
76 phi->in(LoopNode::LoopBackControl) == l->incr() &&
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
77 le->loopnode() == l && le->stride_is_con()) {
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
78 return true;
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
79 }
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
80 }
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
81 }
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
82 return false;
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
83 }
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
84
0
a61af66fc99e Initial load
duke
parents:
diff changeset
85 //------------------------------get_early_ctrl---------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
86 // Compute earliest legal control
a61af66fc99e Initial load
duke
parents:
diff changeset
87 Node *PhaseIdealLoop::get_early_ctrl( Node *n ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
88 assert( !n->is_Phi() && !n->is_CFG(), "this code only handles data nodes" );
a61af66fc99e Initial load
duke
parents:
diff changeset
89 uint i;
a61af66fc99e Initial load
duke
parents:
diff changeset
90 Node *early;
a61af66fc99e Initial load
duke
parents:
diff changeset
91 if( n->in(0) ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
92 early = n->in(0);
a61af66fc99e Initial load
duke
parents:
diff changeset
93 if( !early->is_CFG() ) // Might be a non-CFG multi-def
a61af66fc99e Initial load
duke
parents:
diff changeset
94 early = get_ctrl(early); // So treat input as a straight data input
a61af66fc99e Initial load
duke
parents:
diff changeset
95 i = 1;
a61af66fc99e Initial load
duke
parents:
diff changeset
96 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
97 early = get_ctrl(n->in(1));
a61af66fc99e Initial load
duke
parents:
diff changeset
98 i = 2;
a61af66fc99e Initial load
duke
parents:
diff changeset
99 }
a61af66fc99e Initial load
duke
parents:
diff changeset
100 uint e_d = dom_depth(early);
a61af66fc99e Initial load
duke
parents:
diff changeset
101 assert( early, "" );
a61af66fc99e Initial load
duke
parents:
diff changeset
102 for( ; i < n->req(); i++ ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
103 Node *cin = get_ctrl(n->in(i));
a61af66fc99e Initial load
duke
parents:
diff changeset
104 assert( cin, "" );
a61af66fc99e Initial load
duke
parents:
diff changeset
105 // Keep deepest dominator depth
a61af66fc99e Initial load
duke
parents:
diff changeset
106 uint c_d = dom_depth(cin);
a61af66fc99e Initial load
duke
parents:
diff changeset
107 if( c_d > e_d ) { // Deeper guy?
a61af66fc99e Initial load
duke
parents:
diff changeset
108 early = cin; // Keep deepest found so far
a61af66fc99e Initial load
duke
parents:
diff changeset
109 e_d = c_d;
a61af66fc99e Initial load
duke
parents:
diff changeset
110 } else if( c_d == e_d && // Same depth?
a61af66fc99e Initial load
duke
parents:
diff changeset
111 early != cin ) { // If not equal, must use slower algorithm
a61af66fc99e Initial load
duke
parents:
diff changeset
112 // If same depth but not equal, one _must_ dominate the other
a61af66fc99e Initial load
duke
parents:
diff changeset
113 // and we want the deeper (i.e., dominated) guy.
a61af66fc99e Initial load
duke
parents:
diff changeset
114 Node *n1 = early;
a61af66fc99e Initial load
duke
parents:
diff changeset
115 Node *n2 = cin;
a61af66fc99e Initial load
duke
parents:
diff changeset
116 while( 1 ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
117 n1 = idom(n1); // Walk up until break cycle
a61af66fc99e Initial load
duke
parents:
diff changeset
118 n2 = idom(n2);
a61af66fc99e Initial load
duke
parents:
diff changeset
119 if( n1 == cin || // Walked early up to cin
a61af66fc99e Initial load
duke
parents:
diff changeset
120 dom_depth(n2) < c_d )
a61af66fc99e Initial load
duke
parents:
diff changeset
121 break; // early is deeper; keep him
a61af66fc99e Initial load
duke
parents:
diff changeset
122 if( n2 == early || // Walked cin up to early
a61af66fc99e Initial load
duke
parents:
diff changeset
123 dom_depth(n1) < c_d ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
124 early = cin; // cin is deeper; keep him
a61af66fc99e Initial load
duke
parents:
diff changeset
125 break;
a61af66fc99e Initial load
duke
parents:
diff changeset
126 }
a61af66fc99e Initial load
duke
parents:
diff changeset
127 }
a61af66fc99e Initial load
duke
parents:
diff changeset
128 e_d = dom_depth(early); // Reset depth register cache
a61af66fc99e Initial load
duke
parents:
diff changeset
129 }
a61af66fc99e Initial load
duke
parents:
diff changeset
130 }
a61af66fc99e Initial load
duke
parents:
diff changeset
131
a61af66fc99e Initial load
duke
parents:
diff changeset
132 // Return earliest legal location
a61af66fc99e Initial load
duke
parents:
diff changeset
133 assert(early == find_non_split_ctrl(early), "unexpected early control");
a61af66fc99e Initial load
duke
parents:
diff changeset
134
a61af66fc99e Initial load
duke
parents:
diff changeset
135 return early;
a61af66fc99e Initial load
duke
parents:
diff changeset
136 }
a61af66fc99e Initial load
duke
parents:
diff changeset
137
a61af66fc99e Initial load
duke
parents:
diff changeset
138 //------------------------------set_early_ctrl---------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
139 // Set earliest legal control
a61af66fc99e Initial load
duke
parents:
diff changeset
140 void PhaseIdealLoop::set_early_ctrl( Node *n ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
141 Node *early = get_early_ctrl(n);
a61af66fc99e Initial load
duke
parents:
diff changeset
142
a61af66fc99e Initial load
duke
parents:
diff changeset
143 // Record earliest legal location
a61af66fc99e Initial load
duke
parents:
diff changeset
144 set_ctrl(n, early);
a61af66fc99e Initial load
duke
parents:
diff changeset
145 }
a61af66fc99e Initial load
duke
parents:
diff changeset
146
a61af66fc99e Initial load
duke
parents:
diff changeset
147 //------------------------------set_subtree_ctrl-------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
148 // set missing _ctrl entries on new nodes
a61af66fc99e Initial load
duke
parents:
diff changeset
149 void PhaseIdealLoop::set_subtree_ctrl( Node *n ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
150 // Already set? Get out.
a61af66fc99e Initial load
duke
parents:
diff changeset
151 if( _nodes[n->_idx] ) return;
a61af66fc99e Initial load
duke
parents:
diff changeset
152 // Recursively set _nodes array to indicate where the Node goes
a61af66fc99e Initial load
duke
parents:
diff changeset
153 uint i;
a61af66fc99e Initial load
duke
parents:
diff changeset
154 for( i = 0; i < n->req(); ++i ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
155 Node *m = n->in(i);
a61af66fc99e Initial load
duke
parents:
diff changeset
156 if( m && m != C->root() )
a61af66fc99e Initial load
duke
parents:
diff changeset
157 set_subtree_ctrl( m );
a61af66fc99e Initial load
duke
parents:
diff changeset
158 }
a61af66fc99e Initial load
duke
parents:
diff changeset
159
a61af66fc99e Initial load
duke
parents:
diff changeset
160 // Fixup self
a61af66fc99e Initial load
duke
parents:
diff changeset
161 set_early_ctrl( n );
a61af66fc99e Initial load
duke
parents:
diff changeset
162 }
a61af66fc99e Initial load
duke
parents:
diff changeset
163
a61af66fc99e Initial load
duke
parents:
diff changeset
164 //------------------------------is_counted_loop--------------------------------
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
165 bool PhaseIdealLoop::is_counted_loop( Node *x, IdealLoopTree *loop ) {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
166 PhaseGVN *gvn = &_igvn;
a61af66fc99e Initial load
duke
parents:
diff changeset
167
a61af66fc99e Initial load
duke
parents:
diff changeset
168 // Counted loop head must be a good RegionNode with only 3 not NULL
a61af66fc99e Initial load
duke
parents:
diff changeset
169 // control input edges: Self, Entry, LoopBack.
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
170 if (x->in(LoopNode::Self) == NULL || x->req() != 3)
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
171 return false;
0
a61af66fc99e Initial load
duke
parents:
diff changeset
172
a61af66fc99e Initial load
duke
parents:
diff changeset
173 Node *init_control = x->in(LoopNode::EntryControl);
a61af66fc99e Initial load
duke
parents:
diff changeset
174 Node *back_control = x->in(LoopNode::LoopBackControl);
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
175 if (init_control == NULL || back_control == NULL) // Partially dead
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
176 return false;
0
a61af66fc99e Initial load
duke
parents:
diff changeset
177 // Must also check for TOP when looking for a dead loop
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
178 if (init_control->is_top() || back_control->is_top())
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
179 return false;
0
a61af66fc99e Initial load
duke
parents:
diff changeset
180
a61af66fc99e Initial load
duke
parents:
diff changeset
181 // Allow funny placement of Safepoint
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
182 if (back_control->Opcode() == Op_SafePoint)
0
a61af66fc99e Initial load
duke
parents:
diff changeset
183 back_control = back_control->in(TypeFunc::Control);
a61af66fc99e Initial load
duke
parents:
diff changeset
184
a61af66fc99e Initial load
duke
parents:
diff changeset
185 // Controlling test for loop
a61af66fc99e Initial load
duke
parents:
diff changeset
186 Node *iftrue = back_control;
a61af66fc99e Initial load
duke
parents:
diff changeset
187 uint iftrue_op = iftrue->Opcode();
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
188 if (iftrue_op != Op_IfTrue &&
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
189 iftrue_op != Op_IfFalse)
0
a61af66fc99e Initial load
duke
parents:
diff changeset
190 // I have a weird back-control. Probably the loop-exit test is in
a61af66fc99e Initial load
duke
parents:
diff changeset
191 // the middle of the loop and I am looking at some trailing control-flow
a61af66fc99e Initial load
duke
parents:
diff changeset
192 // merge point. To fix this I would have to partially peel the loop.
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
193 return false; // Obscure back-control
0
a61af66fc99e Initial load
duke
parents:
diff changeset
194
a61af66fc99e Initial load
duke
parents:
diff changeset
195 // Get boolean guarding loop-back test
a61af66fc99e Initial load
duke
parents:
diff changeset
196 Node *iff = iftrue->in(0);
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
197 if (get_loop(iff) != loop || !iff->in(1)->is_Bool())
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
198 return false;
0
a61af66fc99e Initial load
duke
parents:
diff changeset
199 BoolNode *test = iff->in(1)->as_Bool();
a61af66fc99e Initial load
duke
parents:
diff changeset
200 BoolTest::mask bt = test->_test._test;
a61af66fc99e Initial load
duke
parents:
diff changeset
201 float cl_prob = iff->as_If()->_prob;
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
202 if (iftrue_op == Op_IfFalse) {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
203 bt = BoolTest(bt).negate();
a61af66fc99e Initial load
duke
parents:
diff changeset
204 cl_prob = 1.0 - cl_prob;
a61af66fc99e Initial load
duke
parents:
diff changeset
205 }
a61af66fc99e Initial load
duke
parents:
diff changeset
206 // Get backedge compare
a61af66fc99e Initial load
duke
parents:
diff changeset
207 Node *cmp = test->in(1);
a61af66fc99e Initial load
duke
parents:
diff changeset
208 int cmp_op = cmp->Opcode();
3345
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
209 if (cmp_op != Op_CmpI)
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
210 return false; // Avoid pointer & float compares
0
a61af66fc99e Initial load
duke
parents:
diff changeset
211
a61af66fc99e Initial load
duke
parents:
diff changeset
212 // Find the trip-counter increment & limit. Limit must be loop invariant.
a61af66fc99e Initial load
duke
parents:
diff changeset
213 Node *incr = cmp->in(1);
a61af66fc99e Initial load
duke
parents:
diff changeset
214 Node *limit = cmp->in(2);
a61af66fc99e Initial load
duke
parents:
diff changeset
215
a61af66fc99e Initial load
duke
parents:
diff changeset
216 // ---------
a61af66fc99e Initial load
duke
parents:
diff changeset
217 // need 'loop()' test to tell if limit is loop invariant
a61af66fc99e Initial load
duke
parents:
diff changeset
218 // ---------
a61af66fc99e Initial load
duke
parents:
diff changeset
219
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
220 if (!is_member(loop, get_ctrl(incr))) { // Swapped trip counter and limit?
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
221 Node *tmp = incr; // Then reverse order into the CmpI
0
a61af66fc99e Initial load
duke
parents:
diff changeset
222 incr = limit;
a61af66fc99e Initial load
duke
parents:
diff changeset
223 limit = tmp;
a61af66fc99e Initial load
duke
parents:
diff changeset
224 bt = BoolTest(bt).commute(); // And commute the exit test
a61af66fc99e Initial load
duke
parents:
diff changeset
225 }
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
226 if (is_member(loop, get_ctrl(limit))) // Limit must be loop-invariant
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
227 return false;
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
228 if (!is_member(loop, get_ctrl(incr))) // Trip counter must be loop-variant
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
229 return false;
0
a61af66fc99e Initial load
duke
parents:
diff changeset
230
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
231 Node* phi_incr = NULL;
0
a61af66fc99e Initial load
duke
parents:
diff changeset
232 // Trip-counter increment must be commutative & associative.
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
233 if (incr->is_Phi()) {
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
234 if (incr->as_Phi()->region() != x || incr->req() != 3)
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
235 return false; // Not simple trip counter expression
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
236 phi_incr = incr;
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
237 incr = phi_incr->in(LoopNode::LoopBackControl); // Assume incr is on backedge of Phi
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
238 if (!is_member(loop, get_ctrl(incr))) // Trip counter must be loop-variant
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
239 return false;
0
a61af66fc99e Initial load
duke
parents:
diff changeset
240 }
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
241
0
a61af66fc99e Initial load
duke
parents:
diff changeset
242 Node* trunc1 = NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
243 Node* trunc2 = NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
244 const TypeInt* iv_trunc_t = NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
245 if (!(incr = CountedLoopNode::match_incr_with_optional_truncation(incr, &trunc1, &trunc2, &iv_trunc_t))) {
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
246 return false; // Funny increment opcode
0
a61af66fc99e Initial load
duke
parents:
diff changeset
247 }
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
248 assert(incr->Opcode() == Op_AddI, "wrong increment code");
0
a61af66fc99e Initial load
duke
parents:
diff changeset
249
a61af66fc99e Initial load
duke
parents:
diff changeset
250 // Get merge point
a61af66fc99e Initial load
duke
parents:
diff changeset
251 Node *xphi = incr->in(1);
a61af66fc99e Initial load
duke
parents:
diff changeset
252 Node *stride = incr->in(2);
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
253 if (!stride->is_Con()) { // Oops, swap these
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
254 if (!xphi->is_Con()) // Is the other guy a constant?
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
255 return false; // Nope, unknown stride, bail out
0
a61af66fc99e Initial load
duke
parents:
diff changeset
256 Node *tmp = xphi; // 'incr' is commutative, so ok to swap
a61af66fc99e Initial load
duke
parents:
diff changeset
257 xphi = stride;
a61af66fc99e Initial load
duke
parents:
diff changeset
258 stride = tmp;
a61af66fc99e Initial load
duke
parents:
diff changeset
259 }
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
260 // Stride must be constant
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
261 int stride_con = stride->get_int();
3345
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
262 if (stride_con == 0)
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
263 return false; // missed some peephole opt
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
264
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
265 if (!xphi->is_Phi())
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
266 return false; // Too much math on the trip counter
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
267 if (phi_incr != NULL && phi_incr != xphi)
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
268 return false;
0
a61af66fc99e Initial load
duke
parents:
diff changeset
269 PhiNode *phi = xphi->as_Phi();
a61af66fc99e Initial load
duke
parents:
diff changeset
270
a61af66fc99e Initial load
duke
parents:
diff changeset
271 // Phi must be of loop header; backedge must wrap to increment
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
272 if (phi->region() != x)
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
273 return false;
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
274 if (trunc1 == NULL && phi->in(LoopNode::LoopBackControl) != incr ||
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
275 trunc1 != NULL && phi->in(LoopNode::LoopBackControl) != trunc1) {
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
276 return false;
0
a61af66fc99e Initial load
duke
parents:
diff changeset
277 }
a61af66fc99e Initial load
duke
parents:
diff changeset
278 Node *init_trip = phi->in(LoopNode::EntryControl);
a61af66fc99e Initial load
duke
parents:
diff changeset
279
a61af66fc99e Initial load
duke
parents:
diff changeset
280 // If iv trunc type is smaller than int, check for possible wrap.
a61af66fc99e Initial load
duke
parents:
diff changeset
281 if (!TypeInt::INT->higher_equal(iv_trunc_t)) {
a61af66fc99e Initial load
duke
parents:
diff changeset
282 assert(trunc1 != NULL, "must have found some truncation");
a61af66fc99e Initial load
duke
parents:
diff changeset
283
a61af66fc99e Initial load
duke
parents:
diff changeset
284 // Get a better type for the phi (filtered thru if's)
a61af66fc99e Initial load
duke
parents:
diff changeset
285 const TypeInt* phi_ft = filtered_type(phi);
a61af66fc99e Initial load
duke
parents:
diff changeset
286
a61af66fc99e Initial load
duke
parents:
diff changeset
287 // Can iv take on a value that will wrap?
a61af66fc99e Initial load
duke
parents:
diff changeset
288 //
a61af66fc99e Initial load
duke
parents:
diff changeset
289 // Ensure iv's limit is not within "stride" of the wrap value.
a61af66fc99e Initial load
duke
parents:
diff changeset
290 //
a61af66fc99e Initial load
duke
parents:
diff changeset
291 // Example for "short" type
a61af66fc99e Initial load
duke
parents:
diff changeset
292 // Truncation ensures value is in the range -32768..32767 (iv_trunc_t)
a61af66fc99e Initial load
duke
parents:
diff changeset
293 // If the stride is +10, then the last value of the induction
a61af66fc99e Initial load
duke
parents:
diff changeset
294 // variable before the increment (phi_ft->_hi) must be
a61af66fc99e Initial load
duke
parents:
diff changeset
295 // <= 32767 - 10 and (phi_ft->_lo) must be >= -32768 to
a61af66fc99e Initial load
duke
parents:
diff changeset
296 // ensure no truncation occurs after the increment.
a61af66fc99e Initial load
duke
parents:
diff changeset
297
a61af66fc99e Initial load
duke
parents:
diff changeset
298 if (stride_con > 0) {
a61af66fc99e Initial load
duke
parents:
diff changeset
299 if (iv_trunc_t->_hi - phi_ft->_hi < stride_con ||
a61af66fc99e Initial load
duke
parents:
diff changeset
300 iv_trunc_t->_lo > phi_ft->_lo) {
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
301 return false; // truncation may occur
0
a61af66fc99e Initial load
duke
parents:
diff changeset
302 }
a61af66fc99e Initial load
duke
parents:
diff changeset
303 } else if (stride_con < 0) {
a61af66fc99e Initial load
duke
parents:
diff changeset
304 if (iv_trunc_t->_lo - phi_ft->_lo > stride_con ||
a61af66fc99e Initial load
duke
parents:
diff changeset
305 iv_trunc_t->_hi < phi_ft->_hi) {
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
306 return false; // truncation may occur
0
a61af66fc99e Initial load
duke
parents:
diff changeset
307 }
a61af66fc99e Initial load
duke
parents:
diff changeset
308 }
a61af66fc99e Initial load
duke
parents:
diff changeset
309 // No possibility of wrap so truncation can be discarded
a61af66fc99e Initial load
duke
parents:
diff changeset
310 // Promote iv type to Int
a61af66fc99e Initial load
duke
parents:
diff changeset
311 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
312 assert(trunc1 == NULL && trunc2 == NULL, "no truncation for int");
a61af66fc99e Initial load
duke
parents:
diff changeset
313 }
a61af66fc99e Initial load
duke
parents:
diff changeset
314
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
315 // If the condition is inverted and we will be rolling
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
316 // through MININT to MAXINT, then bail out.
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
317 if (bt == BoolTest::eq || // Bail out, but this loop trips at most twice!
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
318 // Odd stride
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
319 bt == BoolTest::ne && stride_con != 1 && stride_con != -1 ||
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
320 // Count down loop rolls through MAXINT
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
321 (bt == BoolTest::le || bt == BoolTest::lt) && stride_con < 0 ||
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
322 // Count up loop rolls through MININT
3345
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
323 (bt == BoolTest::ge || bt == BoolTest::gt) && stride_con > 0) {
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
324 return false; // Bail out
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
325 }
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
326
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
327 const TypeInt* init_t = gvn->type(init_trip)->is_int();
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
328 const TypeInt* limit_t = gvn->type(limit)->is_int();
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
329
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
330 if (stride_con > 0) {
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
331 long init_p = (long)init_t->_lo + stride_con;
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
332 if (init_p > (long)max_jint || init_p > (long)limit_t->_hi)
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
333 return false; // cyclic loop or this loop trips only once
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
334 } else {
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
335 long init_p = (long)init_t->_hi + stride_con;
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
336 if (init_p < (long)min_jint || init_p < (long)limit_t->_lo)
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
337 return false; // cyclic loop or this loop trips only once
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
338 }
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
339
0
a61af66fc99e Initial load
duke
parents:
diff changeset
340 // =================================================
a61af66fc99e Initial load
duke
parents:
diff changeset
341 // ---- SUCCESS! Found A Trip-Counted Loop! -----
a61af66fc99e Initial load
duke
parents:
diff changeset
342 //
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
343 assert(x->Opcode() == Op_Loop, "regular loops only");
0
a61af66fc99e Initial load
duke
parents:
diff changeset
344 C->print_method("Before CountedLoop", 3);
3345
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
345
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
346 Node *hook = new (C, 6) Node(6);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
347
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
348 if (LoopLimitCheck) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
349
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
350 // ===================================================
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
351 // Generate loop limit check to avoid integer overflow
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
352 // in cases like next (cyclic loops):
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
353 //
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
354 // for (i=0; i <= max_jint; i++) {}
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
355 // for (i=0; i < max_jint; i+=2) {}
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
356 //
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
357 //
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
358 // Limit check predicate depends on the loop test:
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
359 //
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
360 // for(;i != limit; i++) --> limit <= (max_jint)
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
361 // for(;i < limit; i+=stride) --> limit <= (max_jint - stride + 1)
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
362 // for(;i <= limit; i+=stride) --> limit <= (max_jint - stride )
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
363 //
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
364
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
365 // Check if limit is excluded to do more precise int overflow check.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
366 bool incl_limit = (bt == BoolTest::le || bt == BoolTest::ge);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
367 int stride_m = stride_con - (incl_limit ? 0 : (stride_con > 0 ? 1 : -1));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
368
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
369 // If compare points directly to the phi we need to adjust
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
370 // the compare so that it points to the incr. Limit have
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
371 // to be adjusted to keep trip count the same and the
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
372 // adjusted limit should be checked for int overflow.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
373 if (phi_incr != NULL) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
374 stride_m += stride_con;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
375 }
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
376
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
377 if (limit->is_Con()) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
378 int limit_con = limit->get_int();
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
379 if ((stride_con > 0 && limit_con > (max_jint - stride_m)) ||
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
380 (stride_con < 0 && limit_con < (min_jint - stride_m))) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
381 // Bailout: it could be integer overflow.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
382 return false;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
383 }
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
384 } else if ((stride_con > 0 && limit_t->_hi <= (max_jint - stride_m)) ||
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
385 (stride_con < 0 && limit_t->_lo >= (min_jint - stride_m))) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
386 // Limit's type may satisfy the condition, for example,
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
387 // when it is an array length.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
388 } else {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
389 // Generate loop's limit check.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
390 // Loop limit check predicate should be near the loop.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
391 ProjNode *limit_check_proj = find_predicate_insertion_point(init_control, Deoptimization::Reason_loop_limit_check);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
392 if (!limit_check_proj) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
393 // The limit check predicate is not generated if this method trapped here before.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
394 #ifdef ASSERT
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
395 if (TraceLoopLimitCheck) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
396 tty->print("missing loop limit check:");
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
397 loop->dump_head();
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
398 x->dump(1);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
399 }
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
400 #endif
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
401 return false;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
402 }
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
403
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
404 IfNode* check_iff = limit_check_proj->in(0)->as_If();
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
405 Node* cmp_limit;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
406 Node* bol;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
407
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
408 if (stride_con > 0) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
409 cmp_limit = new (C, 3) CmpINode(limit, _igvn.intcon(max_jint - stride_m));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
410 bol = new (C, 2) BoolNode(cmp_limit, BoolTest::le);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
411 } else {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
412 cmp_limit = new (C, 3) CmpINode(limit, _igvn.intcon(min_jint - stride_m));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
413 bol = new (C, 2) BoolNode(cmp_limit, BoolTest::ge);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
414 }
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
415 cmp_limit = _igvn.register_new_node_with_optimizer(cmp_limit);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
416 bol = _igvn.register_new_node_with_optimizer(bol);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
417 set_subtree_ctrl(bol);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
418
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
419 // Replace condition in original predicate but preserve Opaque node
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
420 // so that previous predicates could be found.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
421 assert(check_iff->in(1)->Opcode() == Op_Conv2B &&
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
422 check_iff->in(1)->in(1)->Opcode() == Op_Opaque1, "");
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
423 Node* opq = check_iff->in(1)->in(1);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
424 _igvn.hash_delete(opq);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
425 opq->set_req(1, bol);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
426 // Update ctrl.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
427 set_ctrl(opq, check_iff->in(0));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
428 set_ctrl(check_iff->in(1), check_iff->in(0));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
429
2445
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
430 #ifndef PRODUCT
3345
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
431 // report that the loop predication has been actually performed
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
432 // for this loop
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
433 if (TraceLoopLimitCheck) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
434 tty->print_cr("Counted Loop Limit Check generated:");
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
435 debug_only( bol->dump(2); )
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
436 }
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
437 #endif
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
438 }
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
439
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
440 if (phi_incr != NULL) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
441 // If compare points directly to the phi we need to adjust
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
442 // the compare so that it points to the incr. Limit have
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
443 // to be adjusted to keep trip count the same and we
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
444 // should avoid int overflow.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
445 //
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
446 // i = init; do {} while(i++ < limit);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
447 // is converted to
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
448 // i = init; do {} while(++i < limit+1);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
449 //
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
450 limit = gvn->transform(new (C, 3) AddINode(limit, stride));
2445
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
451 }
3345
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
452
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
453 // Now we need to canonicalize loop condition.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
454 if (bt == BoolTest::ne) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
455 assert(stride_con == 1 || stride_con == -1, "simple increment only");
3782
aacaff365100 7052494: Eclipse test fails on JDK 7 b142
kvn
parents: 3345
diff changeset
456 // 'ne' can be replaced with 'lt' only when init < limit.
aacaff365100 7052494: Eclipse test fails on JDK 7 b142
kvn
parents: 3345
diff changeset
457 if (stride_con > 0 && init_t->_hi < limit_t->_lo)
aacaff365100 7052494: Eclipse test fails on JDK 7 b142
kvn
parents: 3345
diff changeset
458 bt = BoolTest::lt;
aacaff365100 7052494: Eclipse test fails on JDK 7 b142
kvn
parents: 3345
diff changeset
459 // 'ne' can be replaced with 'gt' only when init > limit.
aacaff365100 7052494: Eclipse test fails on JDK 7 b142
kvn
parents: 3345
diff changeset
460 if (stride_con < 0 && init_t->_lo > limit_t->_hi)
aacaff365100 7052494: Eclipse test fails on JDK 7 b142
kvn
parents: 3345
diff changeset
461 bt = BoolTest::gt;
3345
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
462 }
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
463
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
464 if (incl_limit) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
465 // The limit check guaranties that 'limit <= (max_jint - stride)' so
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
466 // we can convert 'i <= limit' to 'i < limit+1' since stride != 0.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
467 //
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
468 Node* one = (stride_con > 0) ? gvn->intcon( 1) : gvn->intcon(-1);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
469 limit = gvn->transform(new (C, 3) AddINode(limit, one));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
470 if (bt == BoolTest::le)
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
471 bt = BoolTest::lt;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
472 else if (bt == BoolTest::ge)
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
473 bt = BoolTest::gt;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
474 else
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
475 ShouldNotReachHere();
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
476 }
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
477 set_subtree_ctrl( limit );
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
478
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
479 } else { // LoopLimitCheck
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
480
0
a61af66fc99e Initial load
duke
parents:
diff changeset
481 // If compare points to incr, we are ok. Otherwise the compare
a61af66fc99e Initial load
duke
parents:
diff changeset
482 // can directly point to the phi; in this case adjust the compare so that
605
98cb887364d3 6810672: Comment typos
twisti
parents: 558
diff changeset
483 // it points to the incr by adjusting the limit.
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
484 if (cmp->in(1) == phi || cmp->in(2) == phi)
0
a61af66fc99e Initial load
duke
parents:
diff changeset
485 limit = gvn->transform(new (C, 3) AddINode(limit,stride));
a61af66fc99e Initial load
duke
parents:
diff changeset
486
a61af66fc99e Initial load
duke
parents:
diff changeset
487 // trip-count for +-tive stride should be: (limit - init_trip + stride - 1)/stride.
a61af66fc99e Initial load
duke
parents:
diff changeset
488 // Final value for iterator should be: trip_count * stride + init_trip.
a61af66fc99e Initial load
duke
parents:
diff changeset
489 Node *one_p = gvn->intcon( 1);
a61af66fc99e Initial load
duke
parents:
diff changeset
490 Node *one_m = gvn->intcon(-1);
a61af66fc99e Initial load
duke
parents:
diff changeset
491
a61af66fc99e Initial load
duke
parents:
diff changeset
492 Node *trip_count = NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
493 switch( bt ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
494 case BoolTest::eq:
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
495 ShouldNotReachHere();
0
a61af66fc99e Initial load
duke
parents:
diff changeset
496 case BoolTest::ne: // Ahh, the case we desire
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
497 if (stride_con == 1)
0
a61af66fc99e Initial load
duke
parents:
diff changeset
498 trip_count = gvn->transform(new (C, 3) SubINode(limit,init_trip));
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
499 else if (stride_con == -1)
0
a61af66fc99e Initial load
duke
parents:
diff changeset
500 trip_count = gvn->transform(new (C, 3) SubINode(init_trip,limit));
a61af66fc99e Initial load
duke
parents:
diff changeset
501 else
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
502 ShouldNotReachHere();
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
503 set_subtree_ctrl(trip_count);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
504 //_loop.map(trip_count->_idx,loop(limit));
a61af66fc99e Initial load
duke
parents:
diff changeset
505 break;
a61af66fc99e Initial load
duke
parents:
diff changeset
506 case BoolTest::le: // Maybe convert to '<' case
a61af66fc99e Initial load
duke
parents:
diff changeset
507 limit = gvn->transform(new (C, 3) AddINode(limit,one_p));
a61af66fc99e Initial load
duke
parents:
diff changeset
508 set_subtree_ctrl( limit );
a61af66fc99e Initial load
duke
parents:
diff changeset
509 hook->init_req(4, limit);
a61af66fc99e Initial load
duke
parents:
diff changeset
510
a61af66fc99e Initial load
duke
parents:
diff changeset
511 bt = BoolTest::lt;
a61af66fc99e Initial load
duke
parents:
diff changeset
512 // Make the new limit be in the same loop nest as the old limit
a61af66fc99e Initial load
duke
parents:
diff changeset
513 //_loop.map(limit->_idx,limit_loop);
a61af66fc99e Initial load
duke
parents:
diff changeset
514 // Fall into next case
a61af66fc99e Initial load
duke
parents:
diff changeset
515 case BoolTest::lt: { // Maybe convert to '!=' case
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
516 if (stride_con < 0) // Count down loop rolls through MAXINT
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
517 ShouldNotReachHere();
0
a61af66fc99e Initial load
duke
parents:
diff changeset
518 Node *range = gvn->transform(new (C, 3) SubINode(limit,init_trip));
a61af66fc99e Initial load
duke
parents:
diff changeset
519 set_subtree_ctrl( range );
a61af66fc99e Initial load
duke
parents:
diff changeset
520 hook->init_req(0, range);
a61af66fc99e Initial load
duke
parents:
diff changeset
521
a61af66fc99e Initial load
duke
parents:
diff changeset
522 Node *bias = gvn->transform(new (C, 3) AddINode(range,stride));
a61af66fc99e Initial load
duke
parents:
diff changeset
523 set_subtree_ctrl( bias );
a61af66fc99e Initial load
duke
parents:
diff changeset
524 hook->init_req(1, bias);
a61af66fc99e Initial load
duke
parents:
diff changeset
525
a61af66fc99e Initial load
duke
parents:
diff changeset
526 Node *bias1 = gvn->transform(new (C, 3) AddINode(bias,one_m));
a61af66fc99e Initial load
duke
parents:
diff changeset
527 set_subtree_ctrl( bias1 );
a61af66fc99e Initial load
duke
parents:
diff changeset
528 hook->init_req(2, bias1);
a61af66fc99e Initial load
duke
parents:
diff changeset
529
a61af66fc99e Initial load
duke
parents:
diff changeset
530 trip_count = gvn->transform(new (C, 3) DivINode(0,bias1,stride));
a61af66fc99e Initial load
duke
parents:
diff changeset
531 set_subtree_ctrl( trip_count );
a61af66fc99e Initial load
duke
parents:
diff changeset
532 hook->init_req(3, trip_count);
a61af66fc99e Initial load
duke
parents:
diff changeset
533 break;
a61af66fc99e Initial load
duke
parents:
diff changeset
534 }
a61af66fc99e Initial load
duke
parents:
diff changeset
535
a61af66fc99e Initial load
duke
parents:
diff changeset
536 case BoolTest::ge: // Maybe convert to '>' case
a61af66fc99e Initial load
duke
parents:
diff changeset
537 limit = gvn->transform(new (C, 3) AddINode(limit,one_m));
a61af66fc99e Initial load
duke
parents:
diff changeset
538 set_subtree_ctrl( limit );
a61af66fc99e Initial load
duke
parents:
diff changeset
539 hook->init_req(4 ,limit);
a61af66fc99e Initial load
duke
parents:
diff changeset
540
a61af66fc99e Initial load
duke
parents:
diff changeset
541 bt = BoolTest::gt;
a61af66fc99e Initial load
duke
parents:
diff changeset
542 // Make the new limit be in the same loop nest as the old limit
a61af66fc99e Initial load
duke
parents:
diff changeset
543 //_loop.map(limit->_idx,limit_loop);
a61af66fc99e Initial load
duke
parents:
diff changeset
544 // Fall into next case
a61af66fc99e Initial load
duke
parents:
diff changeset
545 case BoolTest::gt: { // Maybe convert to '!=' case
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
546 if (stride_con > 0) // count up loop rolls through MININT
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
547 ShouldNotReachHere();
0
a61af66fc99e Initial load
duke
parents:
diff changeset
548 Node *range = gvn->transform(new (C, 3) SubINode(limit,init_trip));
a61af66fc99e Initial load
duke
parents:
diff changeset
549 set_subtree_ctrl( range );
a61af66fc99e Initial load
duke
parents:
diff changeset
550 hook->init_req(0, range);
a61af66fc99e Initial load
duke
parents:
diff changeset
551
a61af66fc99e Initial load
duke
parents:
diff changeset
552 Node *bias = gvn->transform(new (C, 3) AddINode(range,stride));
a61af66fc99e Initial load
duke
parents:
diff changeset
553 set_subtree_ctrl( bias );
a61af66fc99e Initial load
duke
parents:
diff changeset
554 hook->init_req(1, bias);
a61af66fc99e Initial load
duke
parents:
diff changeset
555
a61af66fc99e Initial load
duke
parents:
diff changeset
556 Node *bias1 = gvn->transform(new (C, 3) AddINode(bias,one_p));
a61af66fc99e Initial load
duke
parents:
diff changeset
557 set_subtree_ctrl( bias1 );
a61af66fc99e Initial load
duke
parents:
diff changeset
558 hook->init_req(2, bias1);
a61af66fc99e Initial load
duke
parents:
diff changeset
559
a61af66fc99e Initial load
duke
parents:
diff changeset
560 trip_count = gvn->transform(new (C, 3) DivINode(0,bias1,stride));
a61af66fc99e Initial load
duke
parents:
diff changeset
561 set_subtree_ctrl( trip_count );
a61af66fc99e Initial load
duke
parents:
diff changeset
562 hook->init_req(3, trip_count);
a61af66fc99e Initial load
duke
parents:
diff changeset
563 break;
a61af66fc99e Initial load
duke
parents:
diff changeset
564 }
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
565 } // switch( bt )
0
a61af66fc99e Initial load
duke
parents:
diff changeset
566
a61af66fc99e Initial load
duke
parents:
diff changeset
567 Node *span = gvn->transform(new (C, 3) MulINode(trip_count,stride));
a61af66fc99e Initial load
duke
parents:
diff changeset
568 set_subtree_ctrl( span );
a61af66fc99e Initial load
duke
parents:
diff changeset
569 hook->init_req(5, span);
a61af66fc99e Initial load
duke
parents:
diff changeset
570
a61af66fc99e Initial load
duke
parents:
diff changeset
571 limit = gvn->transform(new (C, 3) AddINode(span,init_trip));
a61af66fc99e Initial load
duke
parents:
diff changeset
572 set_subtree_ctrl( limit );
a61af66fc99e Initial load
duke
parents:
diff changeset
573
3345
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
574 } // LoopLimitCheck
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
575
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
576 // Check for SafePoint on backedge and remove
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
577 Node *sfpt = x->in(LoopNode::LoopBackControl);
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
578 if (sfpt->Opcode() == Op_SafePoint && is_deleteable_safept(sfpt)) {
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
579 lazy_replace( sfpt, iftrue );
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
580 loop->_tail = iftrue;
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
581 }
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
582
0
a61af66fc99e Initial load
duke
parents:
diff changeset
583 // Build a canonical trip test.
a61af66fc99e Initial load
duke
parents:
diff changeset
584 // Clone code, as old values may be in use.
a61af66fc99e Initial load
duke
parents:
diff changeset
585 incr = incr->clone();
3936
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
586 incr->set_req(1,phi);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
587 incr->set_req(2,stride);
a61af66fc99e Initial load
duke
parents:
diff changeset
588 incr = _igvn.register_new_node_with_optimizer(incr);
a61af66fc99e Initial load
duke
parents:
diff changeset
589 set_early_ctrl( incr );
3936
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
590 _igvn.hash_delete(phi);
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
591 phi->set_req_X( LoopNode::LoopBackControl, incr, &_igvn );
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
592
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
593 // If phi type is more restrictive than Int, raise to
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
594 // Int to prevent (almost) infinite recursion in igvn
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
595 // which can only handle integer types for constants or minint..maxint.
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
596 if (!TypeInt::INT->higher_equal(phi->bottom_type())) {
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
597 Node* nphi = PhiNode::make(phi->in(0), phi->in(LoopNode::EntryControl), TypeInt::INT);
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
598 nphi->set_req(LoopNode::LoopBackControl, phi->in(LoopNode::LoopBackControl));
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
599 nphi = _igvn.register_new_node_with_optimizer(nphi);
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
600 set_ctrl(nphi, get_ctrl(phi));
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
601 _igvn.replace_node(phi, nphi);
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
602 phi = nphi->as_Phi();
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
603 }
0
a61af66fc99e Initial load
duke
parents:
diff changeset
604 cmp = cmp->clone();
a61af66fc99e Initial load
duke
parents:
diff changeset
605 cmp->set_req(1,incr);
a61af66fc99e Initial load
duke
parents:
diff changeset
606 cmp->set_req(2,limit);
a61af66fc99e Initial load
duke
parents:
diff changeset
607 cmp = _igvn.register_new_node_with_optimizer(cmp);
a61af66fc99e Initial load
duke
parents:
diff changeset
608 set_ctrl(cmp, iff->in(0));
a61af66fc99e Initial load
duke
parents:
diff changeset
609
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
610 test = test->clone()->as_Bool();
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
611 (*(BoolTest*)&test->_test)._test = bt;
0
a61af66fc99e Initial load
duke
parents:
diff changeset
612 test->set_req(1,cmp);
a61af66fc99e Initial load
duke
parents:
diff changeset
613 _igvn.register_new_node_with_optimizer(test);
a61af66fc99e Initial load
duke
parents:
diff changeset
614 set_ctrl(test, iff->in(0));
a61af66fc99e Initial load
duke
parents:
diff changeset
615
a61af66fc99e Initial load
duke
parents:
diff changeset
616 // Replace the old IfNode with a new LoopEndNode
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
617 Node *lex = _igvn.register_new_node_with_optimizer(new (C, 2) CountedLoopEndNode( iff->in(0), test, cl_prob, iff->as_If()->_fcnt ));
0
a61af66fc99e Initial load
duke
parents:
diff changeset
618 IfNode *le = lex->as_If();
a61af66fc99e Initial load
duke
parents:
diff changeset
619 uint dd = dom_depth(iff);
a61af66fc99e Initial load
duke
parents:
diff changeset
620 set_idom(le, le->in(0), dd); // Update dominance for loop exit
a61af66fc99e Initial load
duke
parents:
diff changeset
621 set_loop(le, loop);
a61af66fc99e Initial load
duke
parents:
diff changeset
622
a61af66fc99e Initial load
duke
parents:
diff changeset
623 // Get the loop-exit control
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
624 Node *iffalse = iff->as_If()->proj_out(!(iftrue_op == Op_IfTrue));
0
a61af66fc99e Initial load
duke
parents:
diff changeset
625
a61af66fc99e Initial load
duke
parents:
diff changeset
626 // Need to swap loop-exit and loop-back control?
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
627 if (iftrue_op == Op_IfFalse) {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
628 Node *ift2=_igvn.register_new_node_with_optimizer(new (C, 1) IfTrueNode (le));
a61af66fc99e Initial load
duke
parents:
diff changeset
629 Node *iff2=_igvn.register_new_node_with_optimizer(new (C, 1) IfFalseNode(le));
a61af66fc99e Initial load
duke
parents:
diff changeset
630
a61af66fc99e Initial load
duke
parents:
diff changeset
631 loop->_tail = back_control = ift2;
a61af66fc99e Initial load
duke
parents:
diff changeset
632 set_loop(ift2, loop);
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
633 set_loop(iff2, get_loop(iffalse));
0
a61af66fc99e Initial load
duke
parents:
diff changeset
634
a61af66fc99e Initial load
duke
parents:
diff changeset
635 // Lazy update of 'get_ctrl' mechanism.
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
636 lazy_replace_proj( iffalse, iff2 );
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
637 lazy_replace_proj( iftrue, ift2 );
0
a61af66fc99e Initial load
duke
parents:
diff changeset
638
a61af66fc99e Initial load
duke
parents:
diff changeset
639 // Swap names
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
640 iffalse = iff2;
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
641 iftrue = ift2;
0
a61af66fc99e Initial load
duke
parents:
diff changeset
642 } else {
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
643 _igvn.hash_delete(iffalse);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
644 _igvn.hash_delete(iftrue);
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
645 iffalse->set_req_X( 0, le, &_igvn );
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
646 iftrue ->set_req_X( 0, le, &_igvn );
0
a61af66fc99e Initial load
duke
parents:
diff changeset
647 }
a61af66fc99e Initial load
duke
parents:
diff changeset
648
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
649 set_idom(iftrue, le, dd+1);
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
650 set_idom(iffalse, le, dd+1);
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
651 assert(iff->outcnt() == 0, "should be dead now");
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
652 lazy_replace( iff, le ); // fix 'get_ctrl'
0
a61af66fc99e Initial load
duke
parents:
diff changeset
653
a61af66fc99e Initial load
duke
parents:
diff changeset
654 // Now setup a new CountedLoopNode to replace the existing LoopNode
a61af66fc99e Initial load
duke
parents:
diff changeset
655 CountedLoopNode *l = new (C, 3) CountedLoopNode(init_control, back_control);
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
656 l->set_unswitch_count(x->as_Loop()->unswitch_count()); // Preserve
0
a61af66fc99e Initial load
duke
parents:
diff changeset
657 // The following assert is approximately true, and defines the intention
a61af66fc99e Initial load
duke
parents:
diff changeset
658 // of can_be_counted_loop. It fails, however, because phase->type
a61af66fc99e Initial load
duke
parents:
diff changeset
659 // is not yet initialized for this loop and its parts.
a61af66fc99e Initial load
duke
parents:
diff changeset
660 //assert(l->can_be_counted_loop(this), "sanity");
a61af66fc99e Initial load
duke
parents:
diff changeset
661 _igvn.register_new_node_with_optimizer(l);
a61af66fc99e Initial load
duke
parents:
diff changeset
662 set_loop(l, loop);
a61af66fc99e Initial load
duke
parents:
diff changeset
663 loop->_head = l;
a61af66fc99e Initial load
duke
parents:
diff changeset
664 // Fix all data nodes placed at the old loop head.
a61af66fc99e Initial load
duke
parents:
diff changeset
665 // Uses the lazy-update mechanism of 'get_ctrl'.
a61af66fc99e Initial load
duke
parents:
diff changeset
666 lazy_replace( x, l );
a61af66fc99e Initial load
duke
parents:
diff changeset
667 set_idom(l, init_control, dom_depth(x));
a61af66fc99e Initial load
duke
parents:
diff changeset
668
605
98cb887364d3 6810672: Comment typos
twisti
parents: 558
diff changeset
669 // Check for immediately preceding SafePoint and remove
0
a61af66fc99e Initial load
duke
parents:
diff changeset
670 Node *sfpt2 = le->in(0);
3345
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
671 if (sfpt2->Opcode() == Op_SafePoint && is_deleteable_safept(sfpt2))
0
a61af66fc99e Initial load
duke
parents:
diff changeset
672 lazy_replace( sfpt2, sfpt2->in(TypeFunc::Control));
a61af66fc99e Initial load
duke
parents:
diff changeset
673
a61af66fc99e Initial load
duke
parents:
diff changeset
674 // Free up intermediate goo
a61af66fc99e Initial load
duke
parents:
diff changeset
675 _igvn.remove_dead_node(hook);
a61af66fc99e Initial load
duke
parents:
diff changeset
676
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
677 #ifdef ASSERT
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
678 assert(l->is_valid_counted_loop(), "counted loop shape is messed up");
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
679 assert(l == loop->_head && l->phi() == phi && l->loopexit() == lex, "" );
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
680 #endif
3345
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
681 #ifndef PRODUCT
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
682 if (TraceLoopOpts) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
683 tty->print("Counted ");
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
684 loop->dump_head();
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
685 }
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
686 #endif
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
687
0
a61af66fc99e Initial load
duke
parents:
diff changeset
688 C->print_method("After CountedLoop", 3);
a61af66fc99e Initial load
duke
parents:
diff changeset
689
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
690 return true;
0
a61af66fc99e Initial load
duke
parents:
diff changeset
691 }
a61af66fc99e Initial load
duke
parents:
diff changeset
692
3345
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
693 //----------------------exact_limit-------------------------------------------
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
694 Node* PhaseIdealLoop::exact_limit( IdealLoopTree *loop ) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
695 assert(loop->_head->is_CountedLoop(), "");
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
696 CountedLoopNode *cl = loop->_head->as_CountedLoop();
3850
6987871cfb9b 7077439: Possible reference through NULL in loopPredicate.cpp:726
kvn
parents: 3845
diff changeset
697 assert(cl->is_valid_counted_loop(), "");
3345
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
698
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
699 if (!LoopLimitCheck || ABS(cl->stride_con()) == 1 ||
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
700 cl->limit()->Opcode() == Op_LoopLimit) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
701 // Old code has exact limit (it could be incorrect in case of int overflow).
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
702 // Loop limit is exact with stride == 1. And loop may already have exact limit.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
703 return cl->limit();
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
704 }
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
705 Node *limit = NULL;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
706 #ifdef ASSERT
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
707 BoolTest::mask bt = cl->loopexit()->test_trip();
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
708 assert(bt == BoolTest::lt || bt == BoolTest::gt, "canonical test is expected");
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
709 #endif
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
710 if (cl->has_exact_trip_count()) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
711 // Simple case: loop has constant boundaries.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
712 // Use longs to avoid integer overflow.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
713 int stride_con = cl->stride_con();
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
714 long init_con = cl->init_trip()->get_int();
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
715 long limit_con = cl->limit()->get_int();
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
716 julong trip_cnt = cl->trip_count();
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
717 long final_con = init_con + trip_cnt*stride_con;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
718 final_con -= stride_con;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
719 int final_int = (int)final_con;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
720 // The final value should be in integer range since the loop
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
721 // is counted and the limit was checked for overflow.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
722 assert(final_con == (long)final_int, "final value should be integer");
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
723 limit = _igvn.intcon(final_int);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
724 } else {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
725 // Create new LoopLimit node to get exact limit (final iv value).
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
726 limit = new (C, 4) LoopLimitNode(C, cl->init_trip(), cl->limit(), cl->stride());
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
727 register_new_node(limit, cl->in(LoopNode::EntryControl));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
728 }
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
729 assert(limit != NULL, "sanity");
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
730 return limit;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
731 }
0
a61af66fc99e Initial load
duke
parents:
diff changeset
732
a61af66fc99e Initial load
duke
parents:
diff changeset
733 //------------------------------Ideal------------------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
734 // Return a node which is more "ideal" than the current node.
a61af66fc99e Initial load
duke
parents:
diff changeset
735 // Attempt to convert into a counted-loop.
a61af66fc99e Initial load
duke
parents:
diff changeset
736 Node *LoopNode::Ideal(PhaseGVN *phase, bool can_reshape) {
a61af66fc99e Initial load
duke
parents:
diff changeset
737 if (!can_be_counted_loop(phase)) {
a61af66fc99e Initial load
duke
parents:
diff changeset
738 phase->C->set_major_progress();
a61af66fc99e Initial load
duke
parents:
diff changeset
739 }
a61af66fc99e Initial load
duke
parents:
diff changeset
740 return RegionNode::Ideal(phase, can_reshape);
a61af66fc99e Initial load
duke
parents:
diff changeset
741 }
a61af66fc99e Initial load
duke
parents:
diff changeset
742
a61af66fc99e Initial load
duke
parents:
diff changeset
743
a61af66fc99e Initial load
duke
parents:
diff changeset
744 //=============================================================================
a61af66fc99e Initial load
duke
parents:
diff changeset
745 //------------------------------Ideal------------------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
746 // Return a node which is more "ideal" than the current node.
a61af66fc99e Initial load
duke
parents:
diff changeset
747 // Attempt to convert into a counted-loop.
a61af66fc99e Initial load
duke
parents:
diff changeset
748 Node *CountedLoopNode::Ideal(PhaseGVN *phase, bool can_reshape) {
a61af66fc99e Initial load
duke
parents:
diff changeset
749 return RegionNode::Ideal(phase, can_reshape);
a61af66fc99e Initial load
duke
parents:
diff changeset
750 }
a61af66fc99e Initial load
duke
parents:
diff changeset
751
a61af66fc99e Initial load
duke
parents:
diff changeset
752 //------------------------------dump_spec--------------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
753 // Dump special per-node info
a61af66fc99e Initial load
duke
parents:
diff changeset
754 #ifndef PRODUCT
a61af66fc99e Initial load
duke
parents:
diff changeset
755 void CountedLoopNode::dump_spec(outputStream *st) const {
a61af66fc99e Initial load
duke
parents:
diff changeset
756 LoopNode::dump_spec(st);
3345
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
757 if (stride_is_con()) {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
758 st->print("stride: %d ",stride_con());
a61af66fc99e Initial load
duke
parents:
diff changeset
759 }
3345
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
760 if (is_pre_loop ()) st->print("pre of N%d" , _main_idx);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
761 if (is_main_loop()) st->print("main of N%d", _idx);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
762 if (is_post_loop()) st->print("post of N%d", _main_idx);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
763 }
a61af66fc99e Initial load
duke
parents:
diff changeset
764 #endif
a61af66fc99e Initial load
duke
parents:
diff changeset
765
a61af66fc99e Initial load
duke
parents:
diff changeset
766 //=============================================================================
a61af66fc99e Initial load
duke
parents:
diff changeset
767 int CountedLoopEndNode::stride_con() const {
a61af66fc99e Initial load
duke
parents:
diff changeset
768 return stride()->bottom_type()->is_int()->get_con();
a61af66fc99e Initial load
duke
parents:
diff changeset
769 }
a61af66fc99e Initial load
duke
parents:
diff changeset
770
3345
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
771 //=============================================================================
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
772 //------------------------------Value-----------------------------------------
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
773 const Type *LoopLimitNode::Value( PhaseTransform *phase ) const {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
774 const Type* init_t = phase->type(in(Init));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
775 const Type* limit_t = phase->type(in(Limit));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
776 const Type* stride_t = phase->type(in(Stride));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
777 // Either input is TOP ==> the result is TOP
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
778 if (init_t == Type::TOP) return Type::TOP;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
779 if (limit_t == Type::TOP) return Type::TOP;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
780 if (stride_t == Type::TOP) return Type::TOP;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
781
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
782 int stride_con = stride_t->is_int()->get_con();
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
783 if (stride_con == 1)
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
784 return NULL; // Identity
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
785
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
786 if (init_t->is_int()->is_con() && limit_t->is_int()->is_con()) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
787 // Use longs to avoid integer overflow.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
788 long init_con = init_t->is_int()->get_con();
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
789 long limit_con = limit_t->is_int()->get_con();
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
790 int stride_m = stride_con - (stride_con > 0 ? 1 : -1);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
791 long trip_count = (limit_con - init_con + stride_m)/stride_con;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
792 long final_con = init_con + stride_con*trip_count;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
793 int final_int = (int)final_con;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
794 // The final value should be in integer range since the loop
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
795 // is counted and the limit was checked for overflow.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
796 assert(final_con == (long)final_int, "final value should be integer");
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
797 return TypeInt::make(final_int);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
798 }
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
799
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
800 return bottom_type(); // TypeInt::INT
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
801 }
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
802
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
803 //------------------------------Ideal------------------------------------------
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
804 // Return a node which is more "ideal" than the current node.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
805 Node *LoopLimitNode::Ideal(PhaseGVN *phase, bool can_reshape) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
806 if (phase->type(in(Init)) == Type::TOP ||
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
807 phase->type(in(Limit)) == Type::TOP ||
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
808 phase->type(in(Stride)) == Type::TOP)
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
809 return NULL; // Dead
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
810
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
811 int stride_con = phase->type(in(Stride))->is_int()->get_con();
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
812 if (stride_con == 1)
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
813 return NULL; // Identity
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
814
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
815 if (in(Init)->is_Con() && in(Limit)->is_Con())
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
816 return NULL; // Value
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
817
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
818 // Delay following optimizations until all loop optimizations
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
819 // done to keep Ideal graph simple.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
820 if (!can_reshape || phase->C->major_progress())
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
821 return NULL;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
822
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
823 const TypeInt* init_t = phase->type(in(Init) )->is_int();
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
824 const TypeInt* limit_t = phase->type(in(Limit))->is_int();
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
825 int stride_p;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
826 long lim, ini;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
827 julong max;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
828 if (stride_con > 0) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
829 stride_p = stride_con;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
830 lim = limit_t->_hi;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
831 ini = init_t->_lo;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
832 max = (julong)max_jint;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
833 } else {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
834 stride_p = -stride_con;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
835 lim = init_t->_hi;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
836 ini = limit_t->_lo;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
837 max = (julong)min_jint;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
838 }
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
839 julong range = lim - ini + stride_p;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
840 if (range <= max) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
841 // Convert to integer expression if it is not overflow.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
842 Node* stride_m = phase->intcon(stride_con - (stride_con > 0 ? 1 : -1));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
843 Node *range = phase->transform(new (phase->C, 3) SubINode(in(Limit), in(Init)));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
844 Node *bias = phase->transform(new (phase->C, 3) AddINode(range, stride_m));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
845 Node *trip = phase->transform(new (phase->C, 3) DivINode(0, bias, in(Stride)));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
846 Node *span = phase->transform(new (phase->C, 3) MulINode(trip, in(Stride)));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
847 return new (phase->C, 3) AddINode(span, in(Init)); // exact limit
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
848 }
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
849
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
850 if (is_power_of_2(stride_p) || // divisor is 2^n
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
851 !Matcher::has_match_rule(Op_LoopLimit)) { // or no specialized Mach node?
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
852 // Convert to long expression to avoid integer overflow
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
853 // and let igvn optimizer convert this division.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
854 //
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
855 Node* init = phase->transform( new (phase->C, 2) ConvI2LNode(in(Init)));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
856 Node* limit = phase->transform( new (phase->C, 2) ConvI2LNode(in(Limit)));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
857 Node* stride = phase->longcon(stride_con);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
858 Node* stride_m = phase->longcon(stride_con - (stride_con > 0 ? 1 : -1));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
859
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
860 Node *range = phase->transform(new (phase->C, 3) SubLNode(limit, init));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
861 Node *bias = phase->transform(new (phase->C, 3) AddLNode(range, stride_m));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
862 Node *span;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
863 if (stride_con > 0 && is_power_of_2(stride_p)) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
864 // bias >= 0 if stride >0, so if stride is 2^n we can use &(-stride)
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
865 // and avoid generating rounding for division. Zero trip guard should
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
866 // guarantee that init < limit but sometimes the guard is missing and
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
867 // we can get situation when init > limit. Note, for the empty loop
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
868 // optimization zero trip guard is generated explicitly which leaves
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
869 // only RCE predicate where exact limit is used and the predicate
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
870 // will simply fail forcing recompilation.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
871 Node* neg_stride = phase->longcon(-stride_con);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
872 span = phase->transform(new (phase->C, 3) AndLNode(bias, neg_stride));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
873 } else {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
874 Node *trip = phase->transform(new (phase->C, 3) DivLNode(0, bias, stride));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
875 span = phase->transform(new (phase->C, 3) MulLNode(trip, stride));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
876 }
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
877 // Convert back to int
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
878 Node *span_int = phase->transform(new (phase->C, 2) ConvL2INode(span));
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
879 return new (phase->C, 3) AddINode(span_int, in(Init)); // exact limit
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
880 }
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
881
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
882 return NULL; // No progress
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
883 }
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
884
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
885 //------------------------------Identity---------------------------------------
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
886 // If stride == 1 return limit node.
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
887 Node *LoopLimitNode::Identity( PhaseTransform *phase ) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
888 int stride_con = phase->type(in(Stride))->is_int()->get_con();
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
889 if (stride_con == 1 || stride_con == -1)
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
890 return in(Limit);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
891 return this;
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
892 }
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
893
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
894 //=============================================================================
0
a61af66fc99e Initial load
duke
parents:
diff changeset
895 //----------------------match_incr_with_optional_truncation--------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
896 // Match increment with optional truncation:
a61af66fc99e Initial load
duke
parents:
diff changeset
897 // CHAR: (i+1)&0x7fff, BYTE: ((i+1)<<8)>>8, or SHORT: ((i+1)<<16)>>16
a61af66fc99e Initial load
duke
parents:
diff changeset
898 // Return NULL for failure. Success returns the increment node.
a61af66fc99e Initial load
duke
parents:
diff changeset
899 Node* CountedLoopNode::match_incr_with_optional_truncation(
a61af66fc99e Initial load
duke
parents:
diff changeset
900 Node* expr, Node** trunc1, Node** trunc2, const TypeInt** trunc_type) {
a61af66fc99e Initial load
duke
parents:
diff changeset
901 // Quick cutouts:
a61af66fc99e Initial load
duke
parents:
diff changeset
902 if (expr == NULL || expr->req() != 3) return false;
a61af66fc99e Initial load
duke
parents:
diff changeset
903
a61af66fc99e Initial load
duke
parents:
diff changeset
904 Node *t1 = NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
905 Node *t2 = NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
906 const TypeInt* trunc_t = TypeInt::INT;
a61af66fc99e Initial load
duke
parents:
diff changeset
907 Node* n1 = expr;
a61af66fc99e Initial load
duke
parents:
diff changeset
908 int n1op = n1->Opcode();
a61af66fc99e Initial load
duke
parents:
diff changeset
909
a61af66fc99e Initial load
duke
parents:
diff changeset
910 // Try to strip (n1 & M) or (n1 << N >> N) from n1.
a61af66fc99e Initial load
duke
parents:
diff changeset
911 if (n1op == Op_AndI &&
a61af66fc99e Initial load
duke
parents:
diff changeset
912 n1->in(2)->is_Con() &&
a61af66fc99e Initial load
duke
parents:
diff changeset
913 n1->in(2)->bottom_type()->is_int()->get_con() == 0x7fff) {
a61af66fc99e Initial load
duke
parents:
diff changeset
914 // %%% This check should match any mask of 2**K-1.
a61af66fc99e Initial load
duke
parents:
diff changeset
915 t1 = n1;
a61af66fc99e Initial load
duke
parents:
diff changeset
916 n1 = t1->in(1);
a61af66fc99e Initial load
duke
parents:
diff changeset
917 n1op = n1->Opcode();
a61af66fc99e Initial load
duke
parents:
diff changeset
918 trunc_t = TypeInt::CHAR;
a61af66fc99e Initial load
duke
parents:
diff changeset
919 } else if (n1op == Op_RShiftI &&
a61af66fc99e Initial load
duke
parents:
diff changeset
920 n1->in(1) != NULL &&
a61af66fc99e Initial load
duke
parents:
diff changeset
921 n1->in(1)->Opcode() == Op_LShiftI &&
a61af66fc99e Initial load
duke
parents:
diff changeset
922 n1->in(2) == n1->in(1)->in(2) &&
a61af66fc99e Initial load
duke
parents:
diff changeset
923 n1->in(2)->is_Con()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
924 jint shift = n1->in(2)->bottom_type()->is_int()->get_con();
a61af66fc99e Initial load
duke
parents:
diff changeset
925 // %%% This check should match any shift in [1..31].
a61af66fc99e Initial load
duke
parents:
diff changeset
926 if (shift == 16 || shift == 8) {
a61af66fc99e Initial load
duke
parents:
diff changeset
927 t1 = n1;
a61af66fc99e Initial load
duke
parents:
diff changeset
928 t2 = t1->in(1);
a61af66fc99e Initial load
duke
parents:
diff changeset
929 n1 = t2->in(1);
a61af66fc99e Initial load
duke
parents:
diff changeset
930 n1op = n1->Opcode();
a61af66fc99e Initial load
duke
parents:
diff changeset
931 if (shift == 16) {
a61af66fc99e Initial load
duke
parents:
diff changeset
932 trunc_t = TypeInt::SHORT;
a61af66fc99e Initial load
duke
parents:
diff changeset
933 } else if (shift == 8) {
a61af66fc99e Initial load
duke
parents:
diff changeset
934 trunc_t = TypeInt::BYTE;
a61af66fc99e Initial load
duke
parents:
diff changeset
935 }
a61af66fc99e Initial load
duke
parents:
diff changeset
936 }
a61af66fc99e Initial load
duke
parents:
diff changeset
937 }
a61af66fc99e Initial load
duke
parents:
diff changeset
938
a61af66fc99e Initial load
duke
parents:
diff changeset
939 // If (maybe after stripping) it is an AddI, we won:
a61af66fc99e Initial load
duke
parents:
diff changeset
940 if (n1op == Op_AddI) {
a61af66fc99e Initial load
duke
parents:
diff changeset
941 *trunc1 = t1;
a61af66fc99e Initial load
duke
parents:
diff changeset
942 *trunc2 = t2;
a61af66fc99e Initial load
duke
parents:
diff changeset
943 *trunc_type = trunc_t;
a61af66fc99e Initial load
duke
parents:
diff changeset
944 return n1;
a61af66fc99e Initial load
duke
parents:
diff changeset
945 }
a61af66fc99e Initial load
duke
parents:
diff changeset
946
a61af66fc99e Initial load
duke
parents:
diff changeset
947 // failed
a61af66fc99e Initial load
duke
parents:
diff changeset
948 return NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
949 }
a61af66fc99e Initial load
duke
parents:
diff changeset
950
a61af66fc99e Initial load
duke
parents:
diff changeset
951
a61af66fc99e Initial load
duke
parents:
diff changeset
952 //------------------------------filtered_type--------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
953 // Return a type based on condition control flow
a61af66fc99e Initial load
duke
parents:
diff changeset
954 // A successful return will be a type that is restricted due
a61af66fc99e Initial load
duke
parents:
diff changeset
955 // to a series of dominating if-tests, such as:
a61af66fc99e Initial load
duke
parents:
diff changeset
956 // if (i < 10) {
a61af66fc99e Initial load
duke
parents:
diff changeset
957 // if (i > 0) {
a61af66fc99e Initial load
duke
parents:
diff changeset
958 // here: "i" type is [1..10)
a61af66fc99e Initial load
duke
parents:
diff changeset
959 // }
a61af66fc99e Initial load
duke
parents:
diff changeset
960 // }
a61af66fc99e Initial load
duke
parents:
diff changeset
961 // or a control flow merge
a61af66fc99e Initial load
duke
parents:
diff changeset
962 // if (i < 10) {
a61af66fc99e Initial load
duke
parents:
diff changeset
963 // do {
a61af66fc99e Initial load
duke
parents:
diff changeset
964 // phi( , ) -- at top of loop type is [min_int..10)
a61af66fc99e Initial load
duke
parents:
diff changeset
965 // i = ?
a61af66fc99e Initial load
duke
parents:
diff changeset
966 // } while ( i < 10)
a61af66fc99e Initial load
duke
parents:
diff changeset
967 //
a61af66fc99e Initial load
duke
parents:
diff changeset
968 const TypeInt* PhaseIdealLoop::filtered_type( Node *n, Node* n_ctrl) {
a61af66fc99e Initial load
duke
parents:
diff changeset
969 assert(n && n->bottom_type()->is_int(), "must be int");
a61af66fc99e Initial load
duke
parents:
diff changeset
970 const TypeInt* filtered_t = NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
971 if (!n->is_Phi()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
972 assert(n_ctrl != NULL || n_ctrl == C->top(), "valid control");
a61af66fc99e Initial load
duke
parents:
diff changeset
973 filtered_t = filtered_type_from_dominators(n, n_ctrl);
a61af66fc99e Initial load
duke
parents:
diff changeset
974
a61af66fc99e Initial load
duke
parents:
diff changeset
975 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
976 Node* phi = n->as_Phi();
a61af66fc99e Initial load
duke
parents:
diff changeset
977 Node* region = phi->in(0);
a61af66fc99e Initial load
duke
parents:
diff changeset
978 assert(n_ctrl == NULL || n_ctrl == region, "ctrl parameter must be region");
a61af66fc99e Initial load
duke
parents:
diff changeset
979 if (region && region != C->top()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
980 for (uint i = 1; i < phi->req(); i++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
981 Node* val = phi->in(i);
a61af66fc99e Initial load
duke
parents:
diff changeset
982 Node* use_c = region->in(i);
a61af66fc99e Initial load
duke
parents:
diff changeset
983 const TypeInt* val_t = filtered_type_from_dominators(val, use_c);
a61af66fc99e Initial load
duke
parents:
diff changeset
984 if (val_t != NULL) {
a61af66fc99e Initial load
duke
parents:
diff changeset
985 if (filtered_t == NULL) {
a61af66fc99e Initial load
duke
parents:
diff changeset
986 filtered_t = val_t;
a61af66fc99e Initial load
duke
parents:
diff changeset
987 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
988 filtered_t = filtered_t->meet(val_t)->is_int();
a61af66fc99e Initial load
duke
parents:
diff changeset
989 }
a61af66fc99e Initial load
duke
parents:
diff changeset
990 }
a61af66fc99e Initial load
duke
parents:
diff changeset
991 }
a61af66fc99e Initial load
duke
parents:
diff changeset
992 }
a61af66fc99e Initial load
duke
parents:
diff changeset
993 }
a61af66fc99e Initial load
duke
parents:
diff changeset
994 const TypeInt* n_t = _igvn.type(n)->is_int();
a61af66fc99e Initial load
duke
parents:
diff changeset
995 if (filtered_t != NULL) {
a61af66fc99e Initial load
duke
parents:
diff changeset
996 n_t = n_t->join(filtered_t)->is_int();
a61af66fc99e Initial load
duke
parents:
diff changeset
997 }
a61af66fc99e Initial load
duke
parents:
diff changeset
998 return n_t;
a61af66fc99e Initial load
duke
parents:
diff changeset
999 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1000
a61af66fc99e Initial load
duke
parents:
diff changeset
1001
a61af66fc99e Initial load
duke
parents:
diff changeset
1002 //------------------------------filtered_type_from_dominators--------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
1003 // Return a possibly more restrictive type for val based on condition control flow of dominators
a61af66fc99e Initial load
duke
parents:
diff changeset
1004 const TypeInt* PhaseIdealLoop::filtered_type_from_dominators( Node* val, Node *use_ctrl) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1005 if (val->is_Con()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1006 return val->bottom_type()->is_int();
a61af66fc99e Initial load
duke
parents:
diff changeset
1007 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1008 uint if_limit = 10; // Max number of dominating if's visited
a61af66fc99e Initial load
duke
parents:
diff changeset
1009 const TypeInt* rtn_t = NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
1010
a61af66fc99e Initial load
duke
parents:
diff changeset
1011 if (use_ctrl && use_ctrl != C->top()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1012 Node* val_ctrl = get_ctrl(val);
a61af66fc99e Initial load
duke
parents:
diff changeset
1013 uint val_dom_depth = dom_depth(val_ctrl);
a61af66fc99e Initial load
duke
parents:
diff changeset
1014 Node* pred = use_ctrl;
a61af66fc99e Initial load
duke
parents:
diff changeset
1015 uint if_cnt = 0;
a61af66fc99e Initial load
duke
parents:
diff changeset
1016 while (if_cnt < if_limit) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1017 if ((pred->Opcode() == Op_IfTrue || pred->Opcode() == Op_IfFalse)) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1018 if_cnt++;
17
ff5961f4c095 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 0
diff changeset
1019 const TypeInt* if_t = IfNode::filtered_int_type(&_igvn, val, pred);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1020 if (if_t != NULL) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1021 if (rtn_t == NULL) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1022 rtn_t = if_t;
a61af66fc99e Initial load
duke
parents:
diff changeset
1023 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
1024 rtn_t = rtn_t->join(if_t)->is_int();
a61af66fc99e Initial load
duke
parents:
diff changeset
1025 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1026 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1027 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1028 pred = idom(pred);
a61af66fc99e Initial load
duke
parents:
diff changeset
1029 if (pred == NULL || pred == C->top()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1030 break;
a61af66fc99e Initial load
duke
parents:
diff changeset
1031 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1032 // Stop if going beyond definition block of val
a61af66fc99e Initial load
duke
parents:
diff changeset
1033 if (dom_depth(pred) < val_dom_depth) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1034 break;
a61af66fc99e Initial load
duke
parents:
diff changeset
1035 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1036 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1037 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1038 return rtn_t;
a61af66fc99e Initial load
duke
parents:
diff changeset
1039 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1040
a61af66fc99e Initial load
duke
parents:
diff changeset
1041
a61af66fc99e Initial load
duke
parents:
diff changeset
1042 //------------------------------dump_spec--------------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
1043 // Dump special per-node info
a61af66fc99e Initial load
duke
parents:
diff changeset
1044 #ifndef PRODUCT
a61af66fc99e Initial load
duke
parents:
diff changeset
1045 void CountedLoopEndNode::dump_spec(outputStream *st) const {
a61af66fc99e Initial load
duke
parents:
diff changeset
1046 if( in(TestValue)->is_Bool() ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1047 BoolTest bt( test_trip()); // Added this for g++.
a61af66fc99e Initial load
duke
parents:
diff changeset
1048
a61af66fc99e Initial load
duke
parents:
diff changeset
1049 st->print("[");
a61af66fc99e Initial load
duke
parents:
diff changeset
1050 bt.dump_on(st);
a61af66fc99e Initial load
duke
parents:
diff changeset
1051 st->print("]");
a61af66fc99e Initial load
duke
parents:
diff changeset
1052 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1053 st->print(" ");
a61af66fc99e Initial load
duke
parents:
diff changeset
1054 IfNode::dump_spec(st);
a61af66fc99e Initial load
duke
parents:
diff changeset
1055 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1056 #endif
a61af66fc99e Initial load
duke
parents:
diff changeset
1057
a61af66fc99e Initial load
duke
parents:
diff changeset
1058 //=============================================================================
a61af66fc99e Initial load
duke
parents:
diff changeset
1059 //------------------------------is_member--------------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
1060 // Is 'l' a member of 'this'?
a61af66fc99e Initial load
duke
parents:
diff changeset
1061 int IdealLoopTree::is_member( const IdealLoopTree *l ) const {
a61af66fc99e Initial load
duke
parents:
diff changeset
1062 while( l->_nest > _nest ) l = l->_parent;
a61af66fc99e Initial load
duke
parents:
diff changeset
1063 return l == this;
a61af66fc99e Initial load
duke
parents:
diff changeset
1064 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1065
a61af66fc99e Initial load
duke
parents:
diff changeset
1066 //------------------------------set_nest---------------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
1067 // Set loop tree nesting depth. Accumulate _has_call bits.
a61af66fc99e Initial load
duke
parents:
diff changeset
1068 int IdealLoopTree::set_nest( uint depth ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1069 _nest = depth;
a61af66fc99e Initial load
duke
parents:
diff changeset
1070 int bits = _has_call;
a61af66fc99e Initial load
duke
parents:
diff changeset
1071 if( _child ) bits |= _child->set_nest(depth+1);
a61af66fc99e Initial load
duke
parents:
diff changeset
1072 if( bits ) _has_call = 1;
a61af66fc99e Initial load
duke
parents:
diff changeset
1073 if( _next ) bits |= _next ->set_nest(depth );
a61af66fc99e Initial load
duke
parents:
diff changeset
1074 return bits;
a61af66fc99e Initial load
duke
parents:
diff changeset
1075 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1076
a61af66fc99e Initial load
duke
parents:
diff changeset
1077 //------------------------------split_fall_in----------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
1078 // Split out multiple fall-in edges from the loop header. Move them to a
a61af66fc99e Initial load
duke
parents:
diff changeset
1079 // private RegionNode before the loop. This becomes the loop landing pad.
a61af66fc99e Initial load
duke
parents:
diff changeset
1080 void IdealLoopTree::split_fall_in( PhaseIdealLoop *phase, int fall_in_cnt ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1081 PhaseIterGVN &igvn = phase->_igvn;
a61af66fc99e Initial load
duke
parents:
diff changeset
1082 uint i;
a61af66fc99e Initial load
duke
parents:
diff changeset
1083
a61af66fc99e Initial load
duke
parents:
diff changeset
1084 // Make a new RegionNode to be the landing pad.
a61af66fc99e Initial load
duke
parents:
diff changeset
1085 Node *landing_pad = new (phase->C, fall_in_cnt+1) RegionNode( fall_in_cnt+1 );
a61af66fc99e Initial load
duke
parents:
diff changeset
1086 phase->set_loop(landing_pad,_parent);
a61af66fc99e Initial load
duke
parents:
diff changeset
1087 // Gather all the fall-in control paths into the landing pad
a61af66fc99e Initial load
duke
parents:
diff changeset
1088 uint icnt = fall_in_cnt;
a61af66fc99e Initial load
duke
parents:
diff changeset
1089 uint oreq = _head->req();
a61af66fc99e Initial load
duke
parents:
diff changeset
1090 for( i = oreq-1; i>0; i-- )
a61af66fc99e Initial load
duke
parents:
diff changeset
1091 if( !phase->is_member( this, _head->in(i) ) )
a61af66fc99e Initial load
duke
parents:
diff changeset
1092 landing_pad->set_req(icnt--,_head->in(i));
a61af66fc99e Initial load
duke
parents:
diff changeset
1093
a61af66fc99e Initial load
duke
parents:
diff changeset
1094 // Peel off PhiNode edges as well
a61af66fc99e Initial load
duke
parents:
diff changeset
1095 for (DUIterator_Fast jmax, j = _head->fast_outs(jmax); j < jmax; j++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1096 Node *oj = _head->fast_out(j);
a61af66fc99e Initial load
duke
parents:
diff changeset
1097 if( oj->is_Phi() ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1098 PhiNode* old_phi = oj->as_Phi();
a61af66fc99e Initial load
duke
parents:
diff changeset
1099 assert( old_phi->region() == _head, "" );
a61af66fc99e Initial load
duke
parents:
diff changeset
1100 igvn.hash_delete(old_phi); // Yank from hash before hacking edges
a61af66fc99e Initial load
duke
parents:
diff changeset
1101 Node *p = PhiNode::make_blank(landing_pad, old_phi);
a61af66fc99e Initial load
duke
parents:
diff changeset
1102 uint icnt = fall_in_cnt;
a61af66fc99e Initial load
duke
parents:
diff changeset
1103 for( i = oreq-1; i>0; i-- ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1104 if( !phase->is_member( this, _head->in(i) ) ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1105 p->init_req(icnt--, old_phi->in(i));
a61af66fc99e Initial load
duke
parents:
diff changeset
1106 // Go ahead and clean out old edges from old phi
a61af66fc99e Initial load
duke
parents:
diff changeset
1107 old_phi->del_req(i);
a61af66fc99e Initial load
duke
parents:
diff changeset
1108 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1109 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1110 // Search for CSE's here, because ZKM.jar does a lot of
a61af66fc99e Initial load
duke
parents:
diff changeset
1111 // loop hackery and we need to be a little incremental
a61af66fc99e Initial load
duke
parents:
diff changeset
1112 // with the CSE to avoid O(N^2) node blow-up.
a61af66fc99e Initial load
duke
parents:
diff changeset
1113 Node *p2 = igvn.hash_find_insert(p); // Look for a CSE
a61af66fc99e Initial load
duke
parents:
diff changeset
1114 if( p2 ) { // Found CSE
a61af66fc99e Initial load
duke
parents:
diff changeset
1115 p->destruct(); // Recover useless new node
a61af66fc99e Initial load
duke
parents:
diff changeset
1116 p = p2; // Use old node
a61af66fc99e Initial load
duke
parents:
diff changeset
1117 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
1118 igvn.register_new_node_with_optimizer(p, old_phi);
a61af66fc99e Initial load
duke
parents:
diff changeset
1119 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1120 // Make old Phi refer to new Phi.
a61af66fc99e Initial load
duke
parents:
diff changeset
1121 old_phi->add_req(p);
a61af66fc99e Initial load
duke
parents:
diff changeset
1122 // Check for the special case of making the old phi useless and
a61af66fc99e Initial load
duke
parents:
diff changeset
1123 // disappear it. In JavaGrande I have a case where this useless
a61af66fc99e Initial load
duke
parents:
diff changeset
1124 // Phi is the loop limit and prevents recognizing a CountedLoop
a61af66fc99e Initial load
duke
parents:
diff changeset
1125 // which in turn prevents removing an empty loop.
a61af66fc99e Initial load
duke
parents:
diff changeset
1126 Node *id_old_phi = old_phi->Identity( &igvn );
a61af66fc99e Initial load
duke
parents:
diff changeset
1127 if( id_old_phi != old_phi ) { // Found a simple identity?
1621
6027dddc26c6 6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents: 1552
diff changeset
1128 // Note that I cannot call 'replace_node' here, because
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1129 // that will yank the edge from old_phi to the Region and
a61af66fc99e Initial load
duke
parents:
diff changeset
1130 // I'm mid-iteration over the Region's uses.
a61af66fc99e Initial load
duke
parents:
diff changeset
1131 for (DUIterator_Last imin, i = old_phi->last_outs(imin); i >= imin; ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1132 Node* use = old_phi->last_out(i);
a61af66fc99e Initial load
duke
parents:
diff changeset
1133 igvn.hash_delete(use);
a61af66fc99e Initial load
duke
parents:
diff changeset
1134 igvn._worklist.push(use);
a61af66fc99e Initial load
duke
parents:
diff changeset
1135 uint uses_found = 0;
a61af66fc99e Initial load
duke
parents:
diff changeset
1136 for (uint j = 0; j < use->len(); j++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1137 if (use->in(j) == old_phi) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1138 if (j < use->req()) use->set_req (j, id_old_phi);
a61af66fc99e Initial load
duke
parents:
diff changeset
1139 else use->set_prec(j, id_old_phi);
a61af66fc99e Initial load
duke
parents:
diff changeset
1140 uses_found++;
a61af66fc99e Initial load
duke
parents:
diff changeset
1141 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1142 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1143 i -= uses_found; // we deleted 1 or more copies of this edge
a61af66fc99e Initial load
duke
parents:
diff changeset
1144 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1145 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1146 igvn._worklist.push(old_phi);
a61af66fc99e Initial load
duke
parents:
diff changeset
1147 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1148 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1149 // Finally clean out the fall-in edges from the RegionNode
a61af66fc99e Initial load
duke
parents:
diff changeset
1150 for( i = oreq-1; i>0; i-- ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1151 if( !phase->is_member( this, _head->in(i) ) ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1152 _head->del_req(i);
a61af66fc99e Initial load
duke
parents:
diff changeset
1153 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1154 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1155 // Transform landing pad
a61af66fc99e Initial load
duke
parents:
diff changeset
1156 igvn.register_new_node_with_optimizer(landing_pad, _head);
a61af66fc99e Initial load
duke
parents:
diff changeset
1157 // Insert landing pad into the header
a61af66fc99e Initial load
duke
parents:
diff changeset
1158 _head->add_req(landing_pad);
a61af66fc99e Initial load
duke
parents:
diff changeset
1159 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1160
a61af66fc99e Initial load
duke
parents:
diff changeset
1161 //------------------------------split_outer_loop-------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
1162 // Split out the outermost loop from this shared header.
a61af66fc99e Initial load
duke
parents:
diff changeset
1163 void IdealLoopTree::split_outer_loop( PhaseIdealLoop *phase ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1164 PhaseIterGVN &igvn = phase->_igvn;
a61af66fc99e Initial load
duke
parents:
diff changeset
1165
a61af66fc99e Initial load
duke
parents:
diff changeset
1166 // Find index of outermost loop; it should also be my tail.
a61af66fc99e Initial load
duke
parents:
diff changeset
1167 uint outer_idx = 1;
a61af66fc99e Initial load
duke
parents:
diff changeset
1168 while( _head->in(outer_idx) != _tail ) outer_idx++;
a61af66fc99e Initial load
duke
parents:
diff changeset
1169
a61af66fc99e Initial load
duke
parents:
diff changeset
1170 // Make a LoopNode for the outermost loop.
a61af66fc99e Initial load
duke
parents:
diff changeset
1171 Node *ctl = _head->in(LoopNode::EntryControl);
a61af66fc99e Initial load
duke
parents:
diff changeset
1172 Node *outer = new (phase->C, 3) LoopNode( ctl, _head->in(outer_idx) );
a61af66fc99e Initial load
duke
parents:
diff changeset
1173 outer = igvn.register_new_node_with_optimizer(outer, _head);
a61af66fc99e Initial load
duke
parents:
diff changeset
1174 phase->set_created_loop_node();
2445
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
1175
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1176 // Outermost loop falls into '_head' loop
3845
c96c3eb1efae 7068051: SIGSEGV in PhaseIdealLoop::build_loop_late_post
kvn
parents: 3782
diff changeset
1177 _head->set_req(LoopNode::EntryControl, outer);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1178 _head->del_req(outer_idx);
a61af66fc99e Initial load
duke
parents:
diff changeset
1179 // Split all the Phis up between '_head' loop and 'outer' loop.
a61af66fc99e Initial load
duke
parents:
diff changeset
1180 for (DUIterator_Fast jmax, j = _head->fast_outs(jmax); j < jmax; j++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1181 Node *out = _head->fast_out(j);
a61af66fc99e Initial load
duke
parents:
diff changeset
1182 if( out->is_Phi() ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1183 PhiNode *old_phi = out->as_Phi();
a61af66fc99e Initial load
duke
parents:
diff changeset
1184 assert( old_phi->region() == _head, "" );
a61af66fc99e Initial load
duke
parents:
diff changeset
1185 Node *phi = PhiNode::make_blank(outer, old_phi);
a61af66fc99e Initial load
duke
parents:
diff changeset
1186 phi->init_req(LoopNode::EntryControl, old_phi->in(LoopNode::EntryControl));
a61af66fc99e Initial load
duke
parents:
diff changeset
1187 phi->init_req(LoopNode::LoopBackControl, old_phi->in(outer_idx));
a61af66fc99e Initial load
duke
parents:
diff changeset
1188 phi = igvn.register_new_node_with_optimizer(phi, old_phi);
a61af66fc99e Initial load
duke
parents:
diff changeset
1189 // Make old Phi point to new Phi on the fall-in path
a61af66fc99e Initial load
duke
parents:
diff changeset
1190 igvn.hash_delete(old_phi);
a61af66fc99e Initial load
duke
parents:
diff changeset
1191 old_phi->set_req(LoopNode::EntryControl, phi);
a61af66fc99e Initial load
duke
parents:
diff changeset
1192 old_phi->del_req(outer_idx);
a61af66fc99e Initial load
duke
parents:
diff changeset
1193 igvn._worklist.push(old_phi);
a61af66fc99e Initial load
duke
parents:
diff changeset
1194 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1195 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1196
a61af66fc99e Initial load
duke
parents:
diff changeset
1197 // Use the new loop head instead of the old shared one
a61af66fc99e Initial load
duke
parents:
diff changeset
1198 _head = outer;
a61af66fc99e Initial load
duke
parents:
diff changeset
1199 phase->set_loop(_head, this);
a61af66fc99e Initial load
duke
parents:
diff changeset
1200 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1201
a61af66fc99e Initial load
duke
parents:
diff changeset
1202 //------------------------------fix_parent-------------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
1203 static void fix_parent( IdealLoopTree *loop, IdealLoopTree *parent ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1204 loop->_parent = parent;
a61af66fc99e Initial load
duke
parents:
diff changeset
1205 if( loop->_child ) fix_parent( loop->_child, loop );
a61af66fc99e Initial load
duke
parents:
diff changeset
1206 if( loop->_next ) fix_parent( loop->_next , parent );
a61af66fc99e Initial load
duke
parents:
diff changeset
1207 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1208
a61af66fc99e Initial load
duke
parents:
diff changeset
1209 //------------------------------estimate_path_freq-----------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
1210 static float estimate_path_freq( Node *n ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1211 // Try to extract some path frequency info
a61af66fc99e Initial load
duke
parents:
diff changeset
1212 IfNode *iff;
a61af66fc99e Initial load
duke
parents:
diff changeset
1213 for( int i = 0; i < 50; i++ ) { // Skip through a bunch of uncommon tests
a61af66fc99e Initial load
duke
parents:
diff changeset
1214 uint nop = n->Opcode();
a61af66fc99e Initial load
duke
parents:
diff changeset
1215 if( nop == Op_SafePoint ) { // Skip any safepoint
a61af66fc99e Initial load
duke
parents:
diff changeset
1216 n = n->in(0);
a61af66fc99e Initial load
duke
parents:
diff changeset
1217 continue;
a61af66fc99e Initial load
duke
parents:
diff changeset
1218 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1219 if( nop == Op_CatchProj ) { // Get count from a prior call
a61af66fc99e Initial load
duke
parents:
diff changeset
1220 // Assume call does not always throw exceptions: means the call-site
a61af66fc99e Initial load
duke
parents:
diff changeset
1221 // count is also the frequency of the fall-through path.
a61af66fc99e Initial load
duke
parents:
diff changeset
1222 assert( n->is_CatchProj(), "" );
a61af66fc99e Initial load
duke
parents:
diff changeset
1223 if( ((CatchProjNode*)n)->_con != CatchProjNode::fall_through_index )
a61af66fc99e Initial load
duke
parents:
diff changeset
1224 return 0.0f; // Assume call exception path is rare
a61af66fc99e Initial load
duke
parents:
diff changeset
1225 Node *call = n->in(0)->in(0)->in(0);
a61af66fc99e Initial load
duke
parents:
diff changeset
1226 assert( call->is_Call(), "expect a call here" );
a61af66fc99e Initial load
duke
parents:
diff changeset
1227 const JVMState *jvms = ((CallNode*)call)->jvms();
a61af66fc99e Initial load
duke
parents:
diff changeset
1228 ciMethodData* methodData = jvms->method()->method_data();
a61af66fc99e Initial load
duke
parents:
diff changeset
1229 if (!methodData->is_mature()) return 0.0f; // No call-site data
a61af66fc99e Initial load
duke
parents:
diff changeset
1230 ciProfileData* data = methodData->bci_to_data(jvms->bci());
a61af66fc99e Initial load
duke
parents:
diff changeset
1231 if ((data == NULL) || !data->is_CounterData()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1232 // no call profile available, try call's control input
a61af66fc99e Initial load
duke
parents:
diff changeset
1233 n = n->in(0);
a61af66fc99e Initial load
duke
parents:
diff changeset
1234 continue;
a61af66fc99e Initial load
duke
parents:
diff changeset
1235 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1236 return data->as_CounterData()->count()/FreqCountInvocations;
a61af66fc99e Initial load
duke
parents:
diff changeset
1237 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1238 // See if there's a gating IF test
a61af66fc99e Initial load
duke
parents:
diff changeset
1239 Node *n_c = n->in(0);
a61af66fc99e Initial load
duke
parents:
diff changeset
1240 if( !n_c->is_If() ) break; // No estimate available
a61af66fc99e Initial load
duke
parents:
diff changeset
1241 iff = n_c->as_If();
a61af66fc99e Initial load
duke
parents:
diff changeset
1242 if( iff->_fcnt != COUNT_UNKNOWN ) // Have a valid count?
a61af66fc99e Initial load
duke
parents:
diff changeset
1243 // Compute how much count comes on this path
a61af66fc99e Initial load
duke
parents:
diff changeset
1244 return ((nop == Op_IfTrue) ? iff->_prob : 1.0f - iff->_prob) * iff->_fcnt;
a61af66fc99e Initial load
duke
parents:
diff changeset
1245 // Have no count info. Skip dull uncommon-trap like branches.
a61af66fc99e Initial load
duke
parents:
diff changeset
1246 if( (nop == Op_IfTrue && iff->_prob < PROB_LIKELY_MAG(5)) ||
a61af66fc99e Initial load
duke
parents:
diff changeset
1247 (nop == Op_IfFalse && iff->_prob > PROB_UNLIKELY_MAG(5)) )
a61af66fc99e Initial load
duke
parents:
diff changeset
1248 break;
a61af66fc99e Initial load
duke
parents:
diff changeset
1249 // Skip through never-taken branch; look for a real loop exit.
a61af66fc99e Initial load
duke
parents:
diff changeset
1250 n = iff->in(0);
a61af66fc99e Initial load
duke
parents:
diff changeset
1251 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1252 return 0.0f; // No estimate available
a61af66fc99e Initial load
duke
parents:
diff changeset
1253 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1254
a61af66fc99e Initial load
duke
parents:
diff changeset
1255 //------------------------------merge_many_backedges---------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
1256 // Merge all the backedges from the shared header into a private Region.
a61af66fc99e Initial load
duke
parents:
diff changeset
1257 // Feed that region as the one backedge to this loop.
a61af66fc99e Initial load
duke
parents:
diff changeset
1258 void IdealLoopTree::merge_many_backedges( PhaseIdealLoop *phase ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1259 uint i;
a61af66fc99e Initial load
duke
parents:
diff changeset
1260
a61af66fc99e Initial load
duke
parents:
diff changeset
1261 // Scan for the top 2 hottest backedges
a61af66fc99e Initial load
duke
parents:
diff changeset
1262 float hotcnt = 0.0f;
a61af66fc99e Initial load
duke
parents:
diff changeset
1263 float warmcnt = 0.0f;
a61af66fc99e Initial load
duke
parents:
diff changeset
1264 uint hot_idx = 0;
a61af66fc99e Initial load
duke
parents:
diff changeset
1265 // Loop starts at 2 because slot 1 is the fall-in path
a61af66fc99e Initial load
duke
parents:
diff changeset
1266 for( i = 2; i < _head->req(); i++ ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1267 float cnt = estimate_path_freq(_head->in(i));
a61af66fc99e Initial load
duke
parents:
diff changeset
1268 if( cnt > hotcnt ) { // Grab hottest path
a61af66fc99e Initial load
duke
parents:
diff changeset
1269 warmcnt = hotcnt;
a61af66fc99e Initial load
duke
parents:
diff changeset
1270 hotcnt = cnt;
a61af66fc99e Initial load
duke
parents:
diff changeset
1271 hot_idx = i;
a61af66fc99e Initial load
duke
parents:
diff changeset
1272 } else if( cnt > warmcnt ) { // And 2nd hottest path
a61af66fc99e Initial load
duke
parents:
diff changeset
1273 warmcnt = cnt;
a61af66fc99e Initial load
duke
parents:
diff changeset
1274 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1275 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1276
a61af66fc99e Initial load
duke
parents:
diff changeset
1277 // See if the hottest backedge is worthy of being an inner loop
a61af66fc99e Initial load
duke
parents:
diff changeset
1278 // by being much hotter than the next hottest backedge.
a61af66fc99e Initial load
duke
parents:
diff changeset
1279 if( hotcnt <= 0.0001 ||
a61af66fc99e Initial load
duke
parents:
diff changeset
1280 hotcnt < 2.0*warmcnt ) hot_idx = 0;// No hot backedge
a61af66fc99e Initial load
duke
parents:
diff changeset
1281
a61af66fc99e Initial load
duke
parents:
diff changeset
1282 // Peel out the backedges into a private merge point; peel
a61af66fc99e Initial load
duke
parents:
diff changeset
1283 // them all except optionally hot_idx.
a61af66fc99e Initial load
duke
parents:
diff changeset
1284 PhaseIterGVN &igvn = phase->_igvn;
a61af66fc99e Initial load
duke
parents:
diff changeset
1285
a61af66fc99e Initial load
duke
parents:
diff changeset
1286 Node *hot_tail = NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
1287 // Make a Region for the merge point
a61af66fc99e Initial load
duke
parents:
diff changeset
1288 Node *r = new (phase->C, 1) RegionNode(1);
a61af66fc99e Initial load
duke
parents:
diff changeset
1289 for( i = 2; i < _head->req(); i++ ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1290 if( i != hot_idx )
a61af66fc99e Initial load
duke
parents:
diff changeset
1291 r->add_req( _head->in(i) );
a61af66fc99e Initial load
duke
parents:
diff changeset
1292 else hot_tail = _head->in(i);
a61af66fc99e Initial load
duke
parents:
diff changeset
1293 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1294 igvn.register_new_node_with_optimizer(r, _head);
a61af66fc99e Initial load
duke
parents:
diff changeset
1295 // Plug region into end of loop _head, followed by hot_tail
a61af66fc99e Initial load
duke
parents:
diff changeset
1296 while( _head->req() > 3 ) _head->del_req( _head->req()-1 );
a61af66fc99e Initial load
duke
parents:
diff changeset
1297 _head->set_req(2, r);
a61af66fc99e Initial load
duke
parents:
diff changeset
1298 if( hot_idx ) _head->add_req(hot_tail);
a61af66fc99e Initial load
duke
parents:
diff changeset
1299
a61af66fc99e Initial load
duke
parents:
diff changeset
1300 // Split all the Phis up between '_head' loop and the Region 'r'
a61af66fc99e Initial load
duke
parents:
diff changeset
1301 for (DUIterator_Fast jmax, j = _head->fast_outs(jmax); j < jmax; j++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1302 Node *out = _head->fast_out(j);
a61af66fc99e Initial load
duke
parents:
diff changeset
1303 if( out->is_Phi() ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1304 PhiNode* n = out->as_Phi();
a61af66fc99e Initial load
duke
parents:
diff changeset
1305 igvn.hash_delete(n); // Delete from hash before hacking edges
a61af66fc99e Initial load
duke
parents:
diff changeset
1306 Node *hot_phi = NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
1307 Node *phi = new (phase->C, r->req()) PhiNode(r, n->type(), n->adr_type());
a61af66fc99e Initial load
duke
parents:
diff changeset
1308 // Check all inputs for the ones to peel out
a61af66fc99e Initial load
duke
parents:
diff changeset
1309 uint j = 1;
a61af66fc99e Initial load
duke
parents:
diff changeset
1310 for( uint i = 2; i < n->req(); i++ ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1311 if( i != hot_idx )
a61af66fc99e Initial load
duke
parents:
diff changeset
1312 phi->set_req( j++, n->in(i) );
a61af66fc99e Initial load
duke
parents:
diff changeset
1313 else hot_phi = n->in(i);
a61af66fc99e Initial load
duke
parents:
diff changeset
1314 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1315 // Register the phi but do not transform until whole place transforms
a61af66fc99e Initial load
duke
parents:
diff changeset
1316 igvn.register_new_node_with_optimizer(phi, n);
a61af66fc99e Initial load
duke
parents:
diff changeset
1317 // Add the merge phi to the old Phi
a61af66fc99e Initial load
duke
parents:
diff changeset
1318 while( n->req() > 3 ) n->del_req( n->req()-1 );
a61af66fc99e Initial load
duke
parents:
diff changeset
1319 n->set_req(2, phi);
a61af66fc99e Initial load
duke
parents:
diff changeset
1320 if( hot_idx ) n->add_req(hot_phi);
a61af66fc99e Initial load
duke
parents:
diff changeset
1321 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1322 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1323
a61af66fc99e Initial load
duke
parents:
diff changeset
1324
a61af66fc99e Initial load
duke
parents:
diff changeset
1325 // Insert a new IdealLoopTree inserted below me. Turn it into a clone
a61af66fc99e Initial load
duke
parents:
diff changeset
1326 // of self loop tree. Turn self into a loop headed by _head and with
a61af66fc99e Initial load
duke
parents:
diff changeset
1327 // tail being the new merge point.
a61af66fc99e Initial load
duke
parents:
diff changeset
1328 IdealLoopTree *ilt = new IdealLoopTree( phase, _head, _tail );
a61af66fc99e Initial load
duke
parents:
diff changeset
1329 phase->set_loop(_tail,ilt); // Adjust tail
a61af66fc99e Initial load
duke
parents:
diff changeset
1330 _tail = r; // Self's tail is new merge point
a61af66fc99e Initial load
duke
parents:
diff changeset
1331 phase->set_loop(r,this);
a61af66fc99e Initial load
duke
parents:
diff changeset
1332 ilt->_child = _child; // New guy has my children
a61af66fc99e Initial load
duke
parents:
diff changeset
1333 _child = ilt; // Self has new guy as only child
a61af66fc99e Initial load
duke
parents:
diff changeset
1334 ilt->_parent = this; // new guy has self for parent
a61af66fc99e Initial load
duke
parents:
diff changeset
1335 ilt->_nest = _nest; // Same nesting depth (for now)
a61af66fc99e Initial load
duke
parents:
diff changeset
1336
a61af66fc99e Initial load
duke
parents:
diff changeset
1337 // Starting with 'ilt', look for child loop trees using the same shared
a61af66fc99e Initial load
duke
parents:
diff changeset
1338 // header. Flatten these out; they will no longer be loops in the end.
a61af66fc99e Initial load
duke
parents:
diff changeset
1339 IdealLoopTree **pilt = &_child;
a61af66fc99e Initial load
duke
parents:
diff changeset
1340 while( ilt ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1341 if( ilt->_head == _head ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1342 uint i;
a61af66fc99e Initial load
duke
parents:
diff changeset
1343 for( i = 2; i < _head->req(); i++ )
a61af66fc99e Initial load
duke
parents:
diff changeset
1344 if( _head->in(i) == ilt->_tail )
a61af66fc99e Initial load
duke
parents:
diff changeset
1345 break; // Still a loop
a61af66fc99e Initial load
duke
parents:
diff changeset
1346 if( i == _head->req() ) { // No longer a loop
a61af66fc99e Initial load
duke
parents:
diff changeset
1347 // Flatten ilt. Hang ilt's "_next" list from the end of
a61af66fc99e Initial load
duke
parents:
diff changeset
1348 // ilt's '_child' list. Move the ilt's _child up to replace ilt.
a61af66fc99e Initial load
duke
parents:
diff changeset
1349 IdealLoopTree **cp = &ilt->_child;
a61af66fc99e Initial load
duke
parents:
diff changeset
1350 while( *cp ) cp = &(*cp)->_next; // Find end of child list
a61af66fc99e Initial load
duke
parents:
diff changeset
1351 *cp = ilt->_next; // Hang next list at end of child list
a61af66fc99e Initial load
duke
parents:
diff changeset
1352 *pilt = ilt->_child; // Move child up to replace ilt
a61af66fc99e Initial load
duke
parents:
diff changeset
1353 ilt->_head = NULL; // Flag as a loop UNIONED into parent
a61af66fc99e Initial load
duke
parents:
diff changeset
1354 ilt = ilt->_child; // Repeat using new ilt
a61af66fc99e Initial load
duke
parents:
diff changeset
1355 continue; // do not advance over ilt->_child
a61af66fc99e Initial load
duke
parents:
diff changeset
1356 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1357 assert( ilt->_tail == hot_tail, "expected to only find the hot inner loop here" );
a61af66fc99e Initial load
duke
parents:
diff changeset
1358 phase->set_loop(_head,ilt);
a61af66fc99e Initial load
duke
parents:
diff changeset
1359 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1360 pilt = &ilt->_child; // Advance to next
a61af66fc99e Initial load
duke
parents:
diff changeset
1361 ilt = *pilt;
a61af66fc99e Initial load
duke
parents:
diff changeset
1362 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1363
a61af66fc99e Initial load
duke
parents:
diff changeset
1364 if( _child ) fix_parent( _child, this );
a61af66fc99e Initial load
duke
parents:
diff changeset
1365 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1366
a61af66fc99e Initial load
duke
parents:
diff changeset
1367 //------------------------------beautify_loops---------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
1368 // Split shared headers and insert loop landing pads.
a61af66fc99e Initial load
duke
parents:
diff changeset
1369 // Insert a LoopNode to replace the RegionNode.
a61af66fc99e Initial load
duke
parents:
diff changeset
1370 // Return TRUE if loop tree is structurally changed.
a61af66fc99e Initial load
duke
parents:
diff changeset
1371 bool IdealLoopTree::beautify_loops( PhaseIdealLoop *phase ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1372 bool result = false;
a61af66fc99e Initial load
duke
parents:
diff changeset
1373 // Cache parts in locals for easy
a61af66fc99e Initial load
duke
parents:
diff changeset
1374 PhaseIterGVN &igvn = phase->_igvn;
a61af66fc99e Initial load
duke
parents:
diff changeset
1375
a61af66fc99e Initial load
duke
parents:
diff changeset
1376 igvn.hash_delete(_head); // Yank from hash before hacking edges
a61af66fc99e Initial load
duke
parents:
diff changeset
1377
a61af66fc99e Initial load
duke
parents:
diff changeset
1378 // Check for multiple fall-in paths. Peel off a landing pad if need be.
a61af66fc99e Initial load
duke
parents:
diff changeset
1379 int fall_in_cnt = 0;
a61af66fc99e Initial load
duke
parents:
diff changeset
1380 for( uint i = 1; i < _head->req(); i++ )
a61af66fc99e Initial load
duke
parents:
diff changeset
1381 if( !phase->is_member( this, _head->in(i) ) )
a61af66fc99e Initial load
duke
parents:
diff changeset
1382 fall_in_cnt++;
a61af66fc99e Initial load
duke
parents:
diff changeset
1383 assert( fall_in_cnt, "at least 1 fall-in path" );
a61af66fc99e Initial load
duke
parents:
diff changeset
1384 if( fall_in_cnt > 1 ) // Need a loop landing pad to merge fall-ins
a61af66fc99e Initial load
duke
parents:
diff changeset
1385 split_fall_in( phase, fall_in_cnt );
a61af66fc99e Initial load
duke
parents:
diff changeset
1386
a61af66fc99e Initial load
duke
parents:
diff changeset
1387 // Swap inputs to the _head and all Phis to move the fall-in edge to
a61af66fc99e Initial load
duke
parents:
diff changeset
1388 // the left.
a61af66fc99e Initial load
duke
parents:
diff changeset
1389 fall_in_cnt = 1;
a61af66fc99e Initial load
duke
parents:
diff changeset
1390 while( phase->is_member( this, _head->in(fall_in_cnt) ) )
a61af66fc99e Initial load
duke
parents:
diff changeset
1391 fall_in_cnt++;
a61af66fc99e Initial load
duke
parents:
diff changeset
1392 if( fall_in_cnt > 1 ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1393 // Since I am just swapping inputs I do not need to update def-use info
a61af66fc99e Initial load
duke
parents:
diff changeset
1394 Node *tmp = _head->in(1);
a61af66fc99e Initial load
duke
parents:
diff changeset
1395 _head->set_req( 1, _head->in(fall_in_cnt) );
a61af66fc99e Initial load
duke
parents:
diff changeset
1396 _head->set_req( fall_in_cnt, tmp );
a61af66fc99e Initial load
duke
parents:
diff changeset
1397 // Swap also all Phis
a61af66fc99e Initial load
duke
parents:
diff changeset
1398 for (DUIterator_Fast imax, i = _head->fast_outs(imax); i < imax; i++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1399 Node* phi = _head->fast_out(i);
a61af66fc99e Initial load
duke
parents:
diff changeset
1400 if( phi->is_Phi() ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1401 igvn.hash_delete(phi); // Yank from hash before hacking edges
a61af66fc99e Initial load
duke
parents:
diff changeset
1402 tmp = phi->in(1);
a61af66fc99e Initial load
duke
parents:
diff changeset
1403 phi->set_req( 1, phi->in(fall_in_cnt) );
a61af66fc99e Initial load
duke
parents:
diff changeset
1404 phi->set_req( fall_in_cnt, tmp );
a61af66fc99e Initial load
duke
parents:
diff changeset
1405 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1406 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1407 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1408 assert( !phase->is_member( this, _head->in(1) ), "left edge is fall-in" );
a61af66fc99e Initial load
duke
parents:
diff changeset
1409 assert( phase->is_member( this, _head->in(2) ), "right edge is loop" );
a61af66fc99e Initial load
duke
parents:
diff changeset
1410
a61af66fc99e Initial load
duke
parents:
diff changeset
1411 // If I am a shared header (multiple backedges), peel off the many
a61af66fc99e Initial load
duke
parents:
diff changeset
1412 // backedges into a private merge point and use the merge point as
a61af66fc99e Initial load
duke
parents:
diff changeset
1413 // the one true backedge.
a61af66fc99e Initial load
duke
parents:
diff changeset
1414 if( _head->req() > 3 ) {
2445
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
1415 // Merge the many backedges into a single backedge but leave
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
1416 // the hottest backedge as separate edge for the following peel.
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1417 merge_many_backedges( phase );
a61af66fc99e Initial load
duke
parents:
diff changeset
1418 result = true;
a61af66fc99e Initial load
duke
parents:
diff changeset
1419 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1420
2445
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
1421 // If I have one hot backedge, peel off myself loop.
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1422 // I better be the outermost loop.
a61af66fc99e Initial load
duke
parents:
diff changeset
1423 if( _head->req() > 3 ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1424 split_outer_loop( phase );
a61af66fc99e Initial load
duke
parents:
diff changeset
1425 result = true;
a61af66fc99e Initial load
duke
parents:
diff changeset
1426
a61af66fc99e Initial load
duke
parents:
diff changeset
1427 } else if( !_head->is_Loop() && !_irreducible ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1428 // Make a new LoopNode to replace the old loop head
a61af66fc99e Initial load
duke
parents:
diff changeset
1429 Node *l = new (phase->C, 3) LoopNode( _head->in(1), _head->in(2) );
a61af66fc99e Initial load
duke
parents:
diff changeset
1430 l = igvn.register_new_node_with_optimizer(l, _head);
a61af66fc99e Initial load
duke
parents:
diff changeset
1431 phase->set_created_loop_node();
a61af66fc99e Initial load
duke
parents:
diff changeset
1432 // Go ahead and replace _head
1621
6027dddc26c6 6677629: PhaseIterGVN::subsume_node() should call hash_delete() and add_users_to_worklist()
kvn
parents: 1552
diff changeset
1433 phase->_igvn.replace_node( _head, l );
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1434 _head = l;
a61af66fc99e Initial load
duke
parents:
diff changeset
1435 phase->set_loop(_head, this);
a61af66fc99e Initial load
duke
parents:
diff changeset
1436 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1437
a61af66fc99e Initial load
duke
parents:
diff changeset
1438 // Now recursively beautify nested loops
a61af66fc99e Initial load
duke
parents:
diff changeset
1439 if( _child ) result |= _child->beautify_loops( phase );
a61af66fc99e Initial load
duke
parents:
diff changeset
1440 if( _next ) result |= _next ->beautify_loops( phase );
a61af66fc99e Initial load
duke
parents:
diff changeset
1441 return result;
a61af66fc99e Initial load
duke
parents:
diff changeset
1442 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1443
a61af66fc99e Initial load
duke
parents:
diff changeset
1444 //------------------------------allpaths_check_safepts----------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
1445 // Allpaths backwards scan from loop tail, terminating each path at first safepoint
a61af66fc99e Initial load
duke
parents:
diff changeset
1446 // encountered. Helper for check_safepts.
a61af66fc99e Initial load
duke
parents:
diff changeset
1447 void IdealLoopTree::allpaths_check_safepts(VectorSet &visited, Node_List &stack) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1448 assert(stack.size() == 0, "empty stack");
a61af66fc99e Initial load
duke
parents:
diff changeset
1449 stack.push(_tail);
a61af66fc99e Initial load
duke
parents:
diff changeset
1450 visited.Clear();
a61af66fc99e Initial load
duke
parents:
diff changeset
1451 visited.set(_tail->_idx);
a61af66fc99e Initial load
duke
parents:
diff changeset
1452 while (stack.size() > 0) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1453 Node* n = stack.pop();
a61af66fc99e Initial load
duke
parents:
diff changeset
1454 if (n->is_Call() && n->as_Call()->guaranteed_safepoint()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1455 // Terminate this path
a61af66fc99e Initial load
duke
parents:
diff changeset
1456 } else if (n->Opcode() == Op_SafePoint) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1457 if (_phase->get_loop(n) != this) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1458 if (_required_safept == NULL) _required_safept = new Node_List();
a61af66fc99e Initial load
duke
parents:
diff changeset
1459 _required_safept->push(n); // save the one closest to the tail
a61af66fc99e Initial load
duke
parents:
diff changeset
1460 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1461 // Terminate this path
a61af66fc99e Initial load
duke
parents:
diff changeset
1462 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
1463 uint start = n->is_Region() ? 1 : 0;
a61af66fc99e Initial load
duke
parents:
diff changeset
1464 uint end = n->is_Region() && !n->is_Loop() ? n->req() : start + 1;
a61af66fc99e Initial load
duke
parents:
diff changeset
1465 for (uint i = start; i < end; i++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1466 Node* in = n->in(i);
a61af66fc99e Initial load
duke
parents:
diff changeset
1467 assert(in->is_CFG(), "must be");
a61af66fc99e Initial load
duke
parents:
diff changeset
1468 if (!visited.test_set(in->_idx) && is_member(_phase->get_loop(in))) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1469 stack.push(in);
a61af66fc99e Initial load
duke
parents:
diff changeset
1470 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1471 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1472 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1473 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1474 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1475
a61af66fc99e Initial load
duke
parents:
diff changeset
1476 //------------------------------check_safepts----------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
1477 // Given dominators, try to find loops with calls that must always be
a61af66fc99e Initial load
duke
parents:
diff changeset
1478 // executed (call dominates loop tail). These loops do not need non-call
a61af66fc99e Initial load
duke
parents:
diff changeset
1479 // safepoints (ncsfpt).
a61af66fc99e Initial load
duke
parents:
diff changeset
1480 //
a61af66fc99e Initial load
duke
parents:
diff changeset
1481 // A complication is that a safepoint in a inner loop may be needed
a61af66fc99e Initial load
duke
parents:
diff changeset
1482 // by an outer loop. In the following, the inner loop sees it has a
a61af66fc99e Initial load
duke
parents:
diff changeset
1483 // call (block 3) on every path from the head (block 2) to the
a61af66fc99e Initial load
duke
parents:
diff changeset
1484 // backedge (arc 3->2). So it deletes the ncsfpt (non-call safepoint)
a61af66fc99e Initial load
duke
parents:
diff changeset
1485 // in block 2, _but_ this leaves the outer loop without a safepoint.
a61af66fc99e Initial load
duke
parents:
diff changeset
1486 //
a61af66fc99e Initial load
duke
parents:
diff changeset
1487 // entry 0
a61af66fc99e Initial load
duke
parents:
diff changeset
1488 // |
a61af66fc99e Initial load
duke
parents:
diff changeset
1489 // v
a61af66fc99e Initial load
duke
parents:
diff changeset
1490 // outer 1,2 +->1
a61af66fc99e Initial load
duke
parents:
diff changeset
1491 // | |
a61af66fc99e Initial load
duke
parents:
diff changeset
1492 // | v
a61af66fc99e Initial load
duke
parents:
diff changeset
1493 // | 2<---+ ncsfpt in 2
a61af66fc99e Initial load
duke
parents:
diff changeset
1494 // |_/|\ |
a61af66fc99e Initial load
duke
parents:
diff changeset
1495 // | v |
a61af66fc99e Initial load
duke
parents:
diff changeset
1496 // inner 2,3 / 3 | call in 3
a61af66fc99e Initial load
duke
parents:
diff changeset
1497 // / | |
a61af66fc99e Initial load
duke
parents:
diff changeset
1498 // v +--+
a61af66fc99e Initial load
duke
parents:
diff changeset
1499 // exit 4
a61af66fc99e Initial load
duke
parents:
diff changeset
1500 //
a61af66fc99e Initial load
duke
parents:
diff changeset
1501 //
a61af66fc99e Initial load
duke
parents:
diff changeset
1502 // This method creates a list (_required_safept) of ncsfpt nodes that must
a61af66fc99e Initial load
duke
parents:
diff changeset
1503 // be protected is created for each loop. When a ncsfpt maybe deleted, it
a61af66fc99e Initial load
duke
parents:
diff changeset
1504 // is first looked for in the lists for the outer loops of the current loop.
a61af66fc99e Initial load
duke
parents:
diff changeset
1505 //
a61af66fc99e Initial load
duke
parents:
diff changeset
1506 // The insights into the problem:
a61af66fc99e Initial load
duke
parents:
diff changeset
1507 // A) counted loops are okay
a61af66fc99e Initial load
duke
parents:
diff changeset
1508 // B) innermost loops are okay (only an inner loop can delete
a61af66fc99e Initial load
duke
parents:
diff changeset
1509 // a ncsfpt needed by an outer loop)
a61af66fc99e Initial load
duke
parents:
diff changeset
1510 // C) a loop is immune from an inner loop deleting a safepoint
a61af66fc99e Initial load
duke
parents:
diff changeset
1511 // if the loop has a call on the idom-path
a61af66fc99e Initial load
duke
parents:
diff changeset
1512 // D) a loop is also immune if it has a ncsfpt (non-call safepoint) on the
a61af66fc99e Initial load
duke
parents:
diff changeset
1513 // idom-path that is not in a nested loop
a61af66fc99e Initial load
duke
parents:
diff changeset
1514 // E) otherwise, an ncsfpt on the idom-path that is nested in an inner
a61af66fc99e Initial load
duke
parents:
diff changeset
1515 // loop needs to be prevented from deletion by an inner loop
a61af66fc99e Initial load
duke
parents:
diff changeset
1516 //
a61af66fc99e Initial load
duke
parents:
diff changeset
1517 // There are two analyses:
a61af66fc99e Initial load
duke
parents:
diff changeset
1518 // 1) The first, and cheaper one, scans the loop body from
a61af66fc99e Initial load
duke
parents:
diff changeset
1519 // tail to head following the idom (immediate dominator)
a61af66fc99e Initial load
duke
parents:
diff changeset
1520 // chain, looking for the cases (C,D,E) above.
a61af66fc99e Initial load
duke
parents:
diff changeset
1521 // Since inner loops are scanned before outer loops, there is summary
a61af66fc99e Initial load
duke
parents:
diff changeset
1522 // information about inner loops. Inner loops can be skipped over
a61af66fc99e Initial load
duke
parents:
diff changeset
1523 // when the tail of an inner loop is encountered.
a61af66fc99e Initial load
duke
parents:
diff changeset
1524 //
a61af66fc99e Initial load
duke
parents:
diff changeset
1525 // 2) The second, invoked if the first fails to find a call or ncsfpt on
a61af66fc99e Initial load
duke
parents:
diff changeset
1526 // the idom path (which is rare), scans all predecessor control paths
a61af66fc99e Initial load
duke
parents:
diff changeset
1527 // from the tail to the head, terminating a path when a call or sfpt
a61af66fc99e Initial load
duke
parents:
diff changeset
1528 // is encountered, to find the ncsfpt's that are closest to the tail.
a61af66fc99e Initial load
duke
parents:
diff changeset
1529 //
a61af66fc99e Initial load
duke
parents:
diff changeset
1530 void IdealLoopTree::check_safepts(VectorSet &visited, Node_List &stack) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1531 // Bottom up traversal
a61af66fc99e Initial load
duke
parents:
diff changeset
1532 IdealLoopTree* ch = _child;
a61af66fc99e Initial load
duke
parents:
diff changeset
1533 while (ch != NULL) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1534 ch->check_safepts(visited, stack);
a61af66fc99e Initial load
duke
parents:
diff changeset
1535 ch = ch->_next;
a61af66fc99e Initial load
duke
parents:
diff changeset
1536 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1537
a61af66fc99e Initial load
duke
parents:
diff changeset
1538 if (!_head->is_CountedLoop() && !_has_sfpt && _parent != NULL && !_irreducible) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1539 bool has_call = false; // call on dom-path
a61af66fc99e Initial load
duke
parents:
diff changeset
1540 bool has_local_ncsfpt = false; // ncsfpt on dom-path at this loop depth
a61af66fc99e Initial load
duke
parents:
diff changeset
1541 Node* nonlocal_ncsfpt = NULL; // ncsfpt on dom-path at a deeper depth
a61af66fc99e Initial load
duke
parents:
diff changeset
1542 // Scan the dom-path nodes from tail to head
a61af66fc99e Initial load
duke
parents:
diff changeset
1543 for (Node* n = tail(); n != _head; n = _phase->idom(n)) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1544 if (n->is_Call() && n->as_Call()->guaranteed_safepoint()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1545 has_call = true;
a61af66fc99e Initial load
duke
parents:
diff changeset
1546 _has_sfpt = 1; // Then no need for a safept!
a61af66fc99e Initial load
duke
parents:
diff changeset
1547 break;
a61af66fc99e Initial load
duke
parents:
diff changeset
1548 } else if (n->Opcode() == Op_SafePoint) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1549 if (_phase->get_loop(n) == this) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1550 has_local_ncsfpt = true;
a61af66fc99e Initial load
duke
parents:
diff changeset
1551 break;
a61af66fc99e Initial load
duke
parents:
diff changeset
1552 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1553 if (nonlocal_ncsfpt == NULL) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1554 nonlocal_ncsfpt = n; // save the one closest to the tail
a61af66fc99e Initial load
duke
parents:
diff changeset
1555 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1556 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
1557 IdealLoopTree* nlpt = _phase->get_loop(n);
a61af66fc99e Initial load
duke
parents:
diff changeset
1558 if (this != nlpt) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1559 // If at an inner loop tail, see if the inner loop has already
a61af66fc99e Initial load
duke
parents:
diff changeset
1560 // recorded seeing a call on the dom-path (and stop.) If not,
a61af66fc99e Initial load
duke
parents:
diff changeset
1561 // jump to the head of the inner loop.
a61af66fc99e Initial load
duke
parents:
diff changeset
1562 assert(is_member(nlpt), "nested loop");
a61af66fc99e Initial load
duke
parents:
diff changeset
1563 Node* tail = nlpt->_tail;
a61af66fc99e Initial load
duke
parents:
diff changeset
1564 if (tail->in(0)->is_If()) tail = tail->in(0);
a61af66fc99e Initial load
duke
parents:
diff changeset
1565 if (n == tail) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1566 // If inner loop has call on dom-path, so does outer loop
a61af66fc99e Initial load
duke
parents:
diff changeset
1567 if (nlpt->_has_sfpt) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1568 has_call = true;
a61af66fc99e Initial load
duke
parents:
diff changeset
1569 _has_sfpt = 1;
a61af66fc99e Initial load
duke
parents:
diff changeset
1570 break;
a61af66fc99e Initial load
duke
parents:
diff changeset
1571 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1572 // Skip to head of inner loop
a61af66fc99e Initial load
duke
parents:
diff changeset
1573 assert(_phase->is_dominator(_head, nlpt->_head), "inner head dominated by outer head");
a61af66fc99e Initial load
duke
parents:
diff changeset
1574 n = nlpt->_head;
a61af66fc99e Initial load
duke
parents:
diff changeset
1575 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1576 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1577 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1578 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1579 // Record safept's that this loop needs preserved when an
a61af66fc99e Initial load
duke
parents:
diff changeset
1580 // inner loop attempts to delete it's safepoints.
a61af66fc99e Initial load
duke
parents:
diff changeset
1581 if (_child != NULL && !has_call && !has_local_ncsfpt) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1582 if (nonlocal_ncsfpt != NULL) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1583 if (_required_safept == NULL) _required_safept = new Node_List();
a61af66fc99e Initial load
duke
parents:
diff changeset
1584 _required_safept->push(nonlocal_ncsfpt);
a61af66fc99e Initial load
duke
parents:
diff changeset
1585 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
1586 // Failed to find a suitable safept on the dom-path. Now use
a61af66fc99e Initial load
duke
parents:
diff changeset
1587 // an all paths walk from tail to head, looking for safepoints to preserve.
a61af66fc99e Initial load
duke
parents:
diff changeset
1588 allpaths_check_safepts(visited, stack);
a61af66fc99e Initial load
duke
parents:
diff changeset
1589 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1590 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1591 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1592 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1593
a61af66fc99e Initial load
duke
parents:
diff changeset
1594 //---------------------------is_deleteable_safept----------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
1595 // Is safept not required by an outer loop?
a61af66fc99e Initial load
duke
parents:
diff changeset
1596 bool PhaseIdealLoop::is_deleteable_safept(Node* sfpt) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1597 assert(sfpt->Opcode() == Op_SafePoint, "");
a61af66fc99e Initial load
duke
parents:
diff changeset
1598 IdealLoopTree* lp = get_loop(sfpt)->_parent;
a61af66fc99e Initial load
duke
parents:
diff changeset
1599 while (lp != NULL) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1600 Node_List* sfpts = lp->_required_safept;
a61af66fc99e Initial load
duke
parents:
diff changeset
1601 if (sfpts != NULL) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1602 for (uint i = 0; i < sfpts->size(); i++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1603 if (sfpt == sfpts->at(i))
a61af66fc99e Initial load
duke
parents:
diff changeset
1604 return false;
a61af66fc99e Initial load
duke
parents:
diff changeset
1605 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1606 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1607 lp = lp->_parent;
a61af66fc99e Initial load
duke
parents:
diff changeset
1608 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1609 return true;
a61af66fc99e Initial load
duke
parents:
diff changeset
1610 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1611
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1612 //---------------------------replace_parallel_iv-------------------------------
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1613 // Replace parallel induction variable (parallel to trip counter)
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1614 void PhaseIdealLoop::replace_parallel_iv(IdealLoopTree *loop) {
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1615 assert(loop->_head->is_CountedLoop(), "");
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1616 CountedLoopNode *cl = loop->_head->as_CountedLoop();
3850
6987871cfb9b 7077439: Possible reference through NULL in loopPredicate.cpp:726
kvn
parents: 3845
diff changeset
1617 if (!cl->is_valid_counted_loop())
6987871cfb9b 7077439: Possible reference through NULL in loopPredicate.cpp:726
kvn
parents: 3845
diff changeset
1618 return; // skip malformed counted loop
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1619 Node *incr = cl->incr();
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1620 if (incr == NULL)
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1621 return; // Dead loop?
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1622 Node *init = cl->init_trip();
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1623 Node *phi = cl->phi();
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1624 int stride_con = cl->stride_con();
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1625
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1626 // Visit all children, looking for Phis
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1627 for (DUIterator i = cl->outs(); cl->has_out(i); i++) {
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1628 Node *out = cl->out(i);
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1629 // Look for other phis (secondary IVs). Skip dead ones
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1630 if (!out->is_Phi() || out == phi || !has_node(out))
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1631 continue;
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1632 PhiNode* phi2 = out->as_Phi();
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1633 Node *incr2 = phi2->in( LoopNode::LoopBackControl );
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1634 // Look for induction variables of the form: X += constant
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1635 if (phi2->region() != loop->_head ||
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1636 incr2->req() != 3 ||
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1637 incr2->in(1) != phi2 ||
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1638 incr2 == incr ||
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1639 incr2->Opcode() != Op_AddI ||
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1640 !incr2->in(2)->is_Con())
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1641 continue;
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1642
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1643 // Check for parallel induction variable (parallel to trip counter)
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1644 // via an affine function. In particular, count-down loops with
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1645 // count-up array indices are common. We only RCE references off
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1646 // the trip-counter, so we need to convert all these to trip-counter
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1647 // expressions.
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1648 Node *init2 = phi2->in( LoopNode::EntryControl );
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1649 int stride_con2 = incr2->in(2)->get_int();
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1650
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1651 // The general case here gets a little tricky. We want to find the
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1652 // GCD of all possible parallel IV's and make a new IV using this
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1653 // GCD for the loop. Then all possible IVs are simple multiples of
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1654 // the GCD. In practice, this will cover very few extra loops.
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1655 // Instead we require 'stride_con2' to be a multiple of 'stride_con',
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1656 // where +/-1 is the common case, but other integer multiples are
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1657 // also easy to handle.
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1658 int ratio_con = stride_con2/stride_con;
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1659
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1660 if ((ratio_con * stride_con) == stride_con2) { // Check for exact
3936
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
1661 #ifndef PRODUCT
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
1662 if (TraceLoopOpts) {
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
1663 tty->print("Parallel IV: %d ", phi2->_idx);
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
1664 loop->dump_head();
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
1665 }
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
1666 #endif
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1667 // Convert to using the trip counter. The parallel induction
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1668 // variable differs from the trip counter by a loop-invariant
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1669 // amount, the difference between their respective initial values.
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1670 // It is scaled by the 'ratio_con'.
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1671 Node* ratio = _igvn.intcon(ratio_con);
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1672 set_ctrl(ratio, C->root());
3936
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
1673 Node* ratio_init = new (C, 3) MulINode(init, ratio);
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
1674 _igvn.register_new_node_with_optimizer(ratio_init, init);
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
1675 set_early_ctrl(ratio_init);
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
1676 Node* diff = new (C, 3) SubINode(init2, ratio_init);
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
1677 _igvn.register_new_node_with_optimizer(diff, init2);
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
1678 set_early_ctrl(diff);
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
1679 Node* ratio_idx = new (C, 3) MulINode(phi, ratio);
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
1680 _igvn.register_new_node_with_optimizer(ratio_idx, phi);
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
1681 set_ctrl(ratio_idx, cl);
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
1682 Node* add = new (C, 3) AddINode(ratio_idx, diff);
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
1683 _igvn.register_new_node_with_optimizer(add);
2c24ef16533d 7035946: Up to 15% regression on JDK 7 b136 vs b135 on specjvm2008.crypto.rsa on x64
kvn
parents: 3850
diff changeset
1684 set_ctrl(add, cl);
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1685 _igvn.replace_node( phi2, add );
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1686 // Sometimes an induction variable is unused
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1687 if (add->outcnt() == 0) {
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1688 _igvn.remove_dead_node(add);
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1689 }
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1690 --i; // deleted this phi; rescan starting with next position
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1691 continue;
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1692 }
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1693 }
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1694 }
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1695
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1696 //------------------------------counted_loop-----------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
1697 // Convert to counted loops where possible
a61af66fc99e Initial load
duke
parents:
diff changeset
1698 void IdealLoopTree::counted_loop( PhaseIdealLoop *phase ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1699
a61af66fc99e Initial load
duke
parents:
diff changeset
1700 // For grins, set the inner-loop flag here
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1701 if (!_child) {
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1702 if (_head->is_Loop()) _head->as_Loop()->set_inner_loop();
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1703 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1704
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1705 if (_head->is_CountedLoop() ||
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1706 phase->is_counted_loop(_head, this)) {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1707 _has_sfpt = 1; // Indicate we do not need a safepoint here
a61af66fc99e Initial load
duke
parents:
diff changeset
1708
a61af66fc99e Initial load
duke
parents:
diff changeset
1709 // Look for a safepoint to remove
a61af66fc99e Initial load
duke
parents:
diff changeset
1710 for (Node* n = tail(); n != _head; n = phase->idom(n))
a61af66fc99e Initial load
duke
parents:
diff changeset
1711 if (n->Opcode() == Op_SafePoint && phase->get_loop(n) == this &&
a61af66fc99e Initial load
duke
parents:
diff changeset
1712 phase->is_deleteable_safept(n))
a61af66fc99e Initial load
duke
parents:
diff changeset
1713 phase->lazy_replace(n,n->in(TypeFunc::Control));
a61af66fc99e Initial load
duke
parents:
diff changeset
1714
a61af66fc99e Initial load
duke
parents:
diff changeset
1715 // Look for induction variables
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1716 phase->replace_parallel_iv(this);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1717
a61af66fc99e Initial load
duke
parents:
diff changeset
1718 } else if (_parent != NULL && !_irreducible) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1719 // Not a counted loop.
a61af66fc99e Initial load
duke
parents:
diff changeset
1720 // Look for a safepoint on the idom-path to remove, preserving the first one
a61af66fc99e Initial load
duke
parents:
diff changeset
1721 bool found = false;
a61af66fc99e Initial load
duke
parents:
diff changeset
1722 Node* n = tail();
a61af66fc99e Initial load
duke
parents:
diff changeset
1723 for (; n != _head && !found; n = phase->idom(n)) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1724 if (n->Opcode() == Op_SafePoint && phase->get_loop(n) == this)
a61af66fc99e Initial load
duke
parents:
diff changeset
1725 found = true; // Found one
a61af66fc99e Initial load
duke
parents:
diff changeset
1726 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1727 // Skip past it and delete the others
a61af66fc99e Initial load
duke
parents:
diff changeset
1728 for (; n != _head; n = phase->idom(n)) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1729 if (n->Opcode() == Op_SafePoint && phase->get_loop(n) == this &&
a61af66fc99e Initial load
duke
parents:
diff changeset
1730 phase->is_deleteable_safept(n))
a61af66fc99e Initial load
duke
parents:
diff changeset
1731 phase->lazy_replace(n,n->in(TypeFunc::Control));
a61af66fc99e Initial load
duke
parents:
diff changeset
1732 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1733 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1734
a61af66fc99e Initial load
duke
parents:
diff changeset
1735 // Recursively
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1736 if (_child) _child->counted_loop( phase );
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1737 if (_next) _next ->counted_loop( phase );
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1738 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1739
a61af66fc99e Initial load
duke
parents:
diff changeset
1740 #ifndef PRODUCT
a61af66fc99e Initial load
duke
parents:
diff changeset
1741 //------------------------------dump_head--------------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
1742 // Dump 1 liner for loop header info
a61af66fc99e Initial load
duke
parents:
diff changeset
1743 void IdealLoopTree::dump_head( ) const {
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1744 for (uint i=0; i<_nest; i++)
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1745 tty->print(" ");
a61af66fc99e Initial load
duke
parents:
diff changeset
1746 tty->print("Loop: N%d/N%d ",_head->_idx,_tail->_idx);
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1747 if (_irreducible) tty->print(" IRREDUCIBLE");
3345
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
1748 Node* entry = _head->in(LoopNode::EntryControl);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
1749 if (LoopLimitCheck) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
1750 Node* predicate = PhaseIdealLoop::find_predicate_insertion_point(entry, Deoptimization::Reason_loop_limit_check);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
1751 if (predicate != NULL ) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
1752 tty->print(" limit_check");
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
1753 entry = entry->in(0)->in(0);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
1754 }
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
1755 }
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1756 if (UseLoopPredicate) {
3345
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
1757 entry = PhaseIdealLoop::find_predicate_insertion_point(entry, Deoptimization::Reason_predicate);
2445
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
1758 if (entry != NULL) {
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1759 tty->print(" predicated");
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1760 }
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1761 }
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1762 if (_head->is_CountedLoop()) {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1763 CountedLoopNode *cl = _head->as_CountedLoop();
a61af66fc99e Initial load
duke
parents:
diff changeset
1764 tty->print(" counted");
2465
3af54845df98 7004555: Add new policy for one iteration loops
kvn
parents: 2445
diff changeset
1765
3af54845df98 7004555: Add new policy for one iteration loops
kvn
parents: 2445
diff changeset
1766 Node* init_n = cl->init_trip();
3af54845df98 7004555: Add new policy for one iteration loops
kvn
parents: 2445
diff changeset
1767 if (init_n != NULL && init_n->is_Con())
3af54845df98 7004555: Add new policy for one iteration loops
kvn
parents: 2445
diff changeset
1768 tty->print(" [%d,", cl->init_trip()->get_int());
3af54845df98 7004555: Add new policy for one iteration loops
kvn
parents: 2445
diff changeset
1769 else
3af54845df98 7004555: Add new policy for one iteration loops
kvn
parents: 2445
diff changeset
1770 tty->print(" [int,");
3af54845df98 7004555: Add new policy for one iteration loops
kvn
parents: 2445
diff changeset
1771 Node* limit_n = cl->limit();
3af54845df98 7004555: Add new policy for one iteration loops
kvn
parents: 2445
diff changeset
1772 if (limit_n != NULL && limit_n->is_Con())
3af54845df98 7004555: Add new policy for one iteration loops
kvn
parents: 2445
diff changeset
1773 tty->print("%d),", cl->limit()->get_int());
3af54845df98 7004555: Add new policy for one iteration loops
kvn
parents: 2445
diff changeset
1774 else
3af54845df98 7004555: Add new policy for one iteration loops
kvn
parents: 2445
diff changeset
1775 tty->print("int),");
3af54845df98 7004555: Add new policy for one iteration loops
kvn
parents: 2445
diff changeset
1776 int stride_con = cl->stride_con();
3af54845df98 7004555: Add new policy for one iteration loops
kvn
parents: 2445
diff changeset
1777 if (stride_con > 0) tty->print("+");
3af54845df98 7004555: Add new policy for one iteration loops
kvn
parents: 2445
diff changeset
1778 tty->print("%d", stride_con);
3af54845df98 7004555: Add new policy for one iteration loops
kvn
parents: 2445
diff changeset
1779
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1780 if (cl->is_pre_loop ()) tty->print(" pre" );
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1781 if (cl->is_main_loop()) tty->print(" main");
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1782 if (cl->is_post_loop()) tty->print(" post");
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1783 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1784 tty->cr();
a61af66fc99e Initial load
duke
parents:
diff changeset
1785 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1786
a61af66fc99e Initial load
duke
parents:
diff changeset
1787 //------------------------------dump-------------------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
1788 // Dump loops by loop tree
a61af66fc99e Initial load
duke
parents:
diff changeset
1789 void IdealLoopTree::dump( ) const {
a61af66fc99e Initial load
duke
parents:
diff changeset
1790 dump_head();
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1791 if (_child) _child->dump();
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1792 if (_next) _next ->dump();
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1793 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1794
a61af66fc99e Initial load
duke
parents:
diff changeset
1795 #endif
a61af66fc99e Initial load
duke
parents:
diff changeset
1796
367
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1797 static void log_loop_tree(IdealLoopTree* root, IdealLoopTree* loop, CompileLog* log) {
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1798 if (loop == root) {
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1799 if (loop->_child != NULL) {
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1800 log->begin_head("loop_tree");
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1801 log->end_head();
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1802 if( loop->_child ) log_loop_tree(root, loop->_child, log);
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1803 log->tail("loop_tree");
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1804 assert(loop->_next == NULL, "what?");
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1805 }
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1806 } else {
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1807 Node* head = loop->_head;
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1808 log->begin_head("loop");
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1809 log->print(" idx='%d' ", head->_idx);
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1810 if (loop->_irreducible) log->print("irreducible='1' ");
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1811 if (head->is_Loop()) {
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1812 if (head->as_Loop()->is_inner_loop()) log->print("inner_loop='1' ");
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1813 if (head->as_Loop()->is_partial_peel_loop()) log->print("partial_peel_loop='1' ");
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1814 }
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1815 if (head->is_CountedLoop()) {
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1816 CountedLoopNode* cl = head->as_CountedLoop();
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1817 if (cl->is_pre_loop()) log->print("pre_loop='%d' ", cl->main_idx());
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1818 if (cl->is_main_loop()) log->print("main_loop='%d' ", cl->_idx);
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1819 if (cl->is_post_loop()) log->print("post_loop='%d' ", cl->main_idx());
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1820 }
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1821 log->end_head();
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1822 if( loop->_child ) log_loop_tree(root, loop->_child, log);
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1823 log->tail("loop");
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1824 if( loop->_next ) log_loop_tree(root, loop->_next, log);
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1825 }
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1826 }
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
1827
1172
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1828 //---------------------collect_potentially_useful_predicates-----------------------
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1829 // Helper function to collect potentially useful predicates to prevent them from
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1830 // being eliminated by PhaseIdealLoop::eliminate_useless_predicates
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1831 void PhaseIdealLoop::collect_potentially_useful_predicates(
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1832 IdealLoopTree * loop, Unique_Node_List &useful_predicates) {
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1833 if (loop->_child) { // child
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1834 collect_potentially_useful_predicates(loop->_child, useful_predicates);
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1835 }
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1836
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1837 // self (only loops that we can apply loop predication may use their predicates)
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1838 if (loop->_head->is_Loop() &&
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1839 !loop->_irreducible &&
1172
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1840 !loop->tail()->is_top()) {
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1841 LoopNode* lpn = loop->_head->as_Loop();
1172
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1842 Node* entry = lpn->in(LoopNode::EntryControl);
3345
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
1843 Node* predicate_proj = find_predicate(entry); // loop_limit_check first
1172
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1844 if (predicate_proj != NULL ) { // right pattern that can be used by loop predication
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1845 assert(entry->in(0)->in(1)->in(1)->Opcode() == Op_Opaque1, "must be");
1172
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1846 useful_predicates.push(entry->in(0)->in(1)->in(1)); // good one
3345
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
1847 entry = entry->in(0)->in(0);
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
1848 }
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
1849 predicate_proj = find_predicate(entry); // Predicate
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
1850 if (predicate_proj != NULL ) {
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
1851 useful_predicates.push(entry->in(0)->in(1)->in(1)); // good one
1172
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1852 }
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1853 }
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1854
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1855 if (loop->_next) { // sibling
1172
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1856 collect_potentially_useful_predicates(loop->_next, useful_predicates);
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1857 }
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1858 }
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1859
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1860 //------------------------eliminate_useless_predicates-----------------------------
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1861 // Eliminate all inserted predicates if they could not be used by loop predication.
3345
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
1862 // Note: it will also eliminates loop limits check predicate since it also uses
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
1863 // Opaque1 node (see Parse::add_predicate()).
1172
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1864 void PhaseIdealLoop::eliminate_useless_predicates() {
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1865 if (C->predicate_count() == 0)
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
1866 return; // no predicate left
1172
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1867
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1868 Unique_Node_List useful_predicates; // to store useful predicates
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1869 if (C->has_loops()) {
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1870 collect_potentially_useful_predicates(_ltree_root->_child, useful_predicates);
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1871 }
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1872
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1873 for (int i = C->predicate_count(); i > 0; i--) {
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1874 Node * n = C->predicate_opaque1_node(i-1);
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1875 assert(n->Opcode() == Op_Opaque1, "must be");
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1876 if (!useful_predicates.member(n)) { // not in the useful list
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1877 _igvn.replace_node(n, n->in(1));
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1878 }
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1879 }
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1880 }
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
1881
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1882 //=============================================================================
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
1883 //----------------------------build_and_optimize-------------------------------
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1884 // Create a PhaseLoop. Build the ideal Loop tree. Map each Ideal Node to
a61af66fc99e Initial load
duke
parents:
diff changeset
1885 // its corresponding LoopNode. If 'optimize' is true, do some loop cleanups.
4064
670a74b863fc 7107042: assert(no_dead_loop) failed: dead loop detected
kvn
parents: 3936
diff changeset
1886 void PhaseIdealLoop::build_and_optimize(bool do_split_ifs, bool skip_loop_opts) {
2248
194c9fdee631 7017240: C2: native memory leak in nsk/regression/b4675027 on windows-x86 in comp mode with G1
kvn
parents: 1972
diff changeset
1887 ResourceMark rm;
194c9fdee631 7017240: C2: native memory leak in nsk/regression/b4675027 on windows-x86 in comp mode with G1
kvn
parents: 1972
diff changeset
1888
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
1889 int old_progress = C->major_progress();
2403
1927db75dd85 7024475: loop doesn't terminate when compiled
never
parents: 2383
diff changeset
1890 uint orig_worklist_size = _igvn._worklist.size();
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
1891
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1892 // Reset major-progress flag for the driver's heuristics
a61af66fc99e Initial load
duke
parents:
diff changeset
1893 C->clear_major_progress();
a61af66fc99e Initial load
duke
parents:
diff changeset
1894
a61af66fc99e Initial load
duke
parents:
diff changeset
1895 #ifndef PRODUCT
a61af66fc99e Initial load
duke
parents:
diff changeset
1896 // Capture for later assert
a61af66fc99e Initial load
duke
parents:
diff changeset
1897 uint unique = C->unique();
a61af66fc99e Initial load
duke
parents:
diff changeset
1898 _loop_invokes++;
a61af66fc99e Initial load
duke
parents:
diff changeset
1899 _loop_work += unique;
a61af66fc99e Initial load
duke
parents:
diff changeset
1900 #endif
a61af66fc99e Initial load
duke
parents:
diff changeset
1901
a61af66fc99e Initial load
duke
parents:
diff changeset
1902 // True if the method has at least 1 irreducible loop
a61af66fc99e Initial load
duke
parents:
diff changeset
1903 _has_irreducible_loops = false;
a61af66fc99e Initial load
duke
parents:
diff changeset
1904
a61af66fc99e Initial load
duke
parents:
diff changeset
1905 _created_loop_node = false;
a61af66fc99e Initial load
duke
parents:
diff changeset
1906
a61af66fc99e Initial load
duke
parents:
diff changeset
1907 Arena *a = Thread::current()->resource_area();
a61af66fc99e Initial load
duke
parents:
diff changeset
1908 VectorSet visited(a);
a61af66fc99e Initial load
duke
parents:
diff changeset
1909 // Pre-grow the mapping from Nodes to IdealLoopTrees.
a61af66fc99e Initial load
duke
parents:
diff changeset
1910 _nodes.map(C->unique(), NULL);
a61af66fc99e Initial load
duke
parents:
diff changeset
1911 memset(_nodes.adr(), 0, wordSize * C->unique());
a61af66fc99e Initial load
duke
parents:
diff changeset
1912
a61af66fc99e Initial load
duke
parents:
diff changeset
1913 // Pre-build the top-level outermost loop tree entry
a61af66fc99e Initial load
duke
parents:
diff changeset
1914 _ltree_root = new IdealLoopTree( this, C->root(), C->root() );
a61af66fc99e Initial load
duke
parents:
diff changeset
1915 // Do not need a safepoint at the top level
a61af66fc99e Initial load
duke
parents:
diff changeset
1916 _ltree_root->_has_sfpt = 1;
a61af66fc99e Initial load
duke
parents:
diff changeset
1917
2445
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
1918 // Initialize Dominators.
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
1919 // Checked in clone_loop_predicate() during beautify_loops().
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
1920 _idom_size = 0;
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
1921 _idom = NULL;
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
1922 _dom_depth = NULL;
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
1923 _dom_stk = NULL;
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
1924
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1925 // Empty pre-order array
a61af66fc99e Initial load
duke
parents:
diff changeset
1926 allocate_preorders();
a61af66fc99e Initial load
duke
parents:
diff changeset
1927
a61af66fc99e Initial load
duke
parents:
diff changeset
1928 // Build a loop tree on the fly. Build a mapping from CFG nodes to
a61af66fc99e Initial load
duke
parents:
diff changeset
1929 // IdealLoopTree entries. Data nodes are NOT walked.
a61af66fc99e Initial load
duke
parents:
diff changeset
1930 build_loop_tree();
a61af66fc99e Initial load
duke
parents:
diff changeset
1931 // Check for bailout, and return
a61af66fc99e Initial load
duke
parents:
diff changeset
1932 if (C->failing()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1933 return;
a61af66fc99e Initial load
duke
parents:
diff changeset
1934 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1935
a61af66fc99e Initial load
duke
parents:
diff changeset
1936 // No loops after all
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
1937 if( !_ltree_root->_child && !_verify_only ) C->set_has_loops(false);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1938
a61af66fc99e Initial load
duke
parents:
diff changeset
1939 // There should always be an outer loop containing the Root and Return nodes.
a61af66fc99e Initial load
duke
parents:
diff changeset
1940 // If not, we have a degenerate empty program. Bail out in this case.
a61af66fc99e Initial load
duke
parents:
diff changeset
1941 if (!has_node(C->root())) {
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
1942 if (!_verify_only) {
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
1943 C->clear_major_progress();
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
1944 C->record_method_not_compilable("empty program detected during loop optimization");
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
1945 }
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1946 return;
a61af66fc99e Initial load
duke
parents:
diff changeset
1947 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1948
a61af66fc99e Initial load
duke
parents:
diff changeset
1949 // Nothing to do, so get out
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
1950 if( !C->has_loops() && !do_split_ifs && !_verify_me && !_verify_only ) {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1951 _igvn.optimize(); // Cleanup NeverBranches
a61af66fc99e Initial load
duke
parents:
diff changeset
1952 return;
a61af66fc99e Initial load
duke
parents:
diff changeset
1953 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1954
a61af66fc99e Initial load
duke
parents:
diff changeset
1955 // Set loop nesting depth
a61af66fc99e Initial load
duke
parents:
diff changeset
1956 _ltree_root->set_nest( 0 );
a61af66fc99e Initial load
duke
parents:
diff changeset
1957
a61af66fc99e Initial load
duke
parents:
diff changeset
1958 // Split shared headers and insert loop landing pads.
a61af66fc99e Initial load
duke
parents:
diff changeset
1959 // Do not bother doing this on the Root loop of course.
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
1960 if( !_verify_me && !_verify_only && _ltree_root->_child ) {
2403
1927db75dd85 7024475: loop doesn't terminate when compiled
never
parents: 2383
diff changeset
1961 C->print_method("Before beautify loops", 3);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1962 if( _ltree_root->_child->beautify_loops( this ) ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1963 // Re-build loop tree!
a61af66fc99e Initial load
duke
parents:
diff changeset
1964 _ltree_root->_child = NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
1965 _nodes.clear();
a61af66fc99e Initial load
duke
parents:
diff changeset
1966 reallocate_preorders();
a61af66fc99e Initial load
duke
parents:
diff changeset
1967 build_loop_tree();
a61af66fc99e Initial load
duke
parents:
diff changeset
1968 // Check for bailout, and return
a61af66fc99e Initial load
duke
parents:
diff changeset
1969 if (C->failing()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
1970 return;
a61af66fc99e Initial load
duke
parents:
diff changeset
1971 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1972 // Reset loop nesting depth
a61af66fc99e Initial load
duke
parents:
diff changeset
1973 _ltree_root->set_nest( 0 );
222
2a1a77d3458f 6718676: putback for 6604014 is incomplete
never
parents: 169
diff changeset
1974
2a1a77d3458f 6718676: putback for 6604014 is incomplete
never
parents: 169
diff changeset
1975 C->print_method("After beautify loops", 3);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1976 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1977 }
a61af66fc99e Initial load
duke
parents:
diff changeset
1978
a61af66fc99e Initial load
duke
parents:
diff changeset
1979 // Build Dominators for elision of NULL checks & loop finding.
a61af66fc99e Initial load
duke
parents:
diff changeset
1980 // Since nodes do not have a slot for immediate dominator, make
605
98cb887364d3 6810672: Comment typos
twisti
parents: 558
diff changeset
1981 // a persistent side array for that info indexed on node->_idx.
0
a61af66fc99e Initial load
duke
parents:
diff changeset
1982 _idom_size = C->unique();
a61af66fc99e Initial load
duke
parents:
diff changeset
1983 _idom = NEW_RESOURCE_ARRAY( Node*, _idom_size );
a61af66fc99e Initial load
duke
parents:
diff changeset
1984 _dom_depth = NEW_RESOURCE_ARRAY( uint, _idom_size );
a61af66fc99e Initial load
duke
parents:
diff changeset
1985 _dom_stk = NULL; // Allocated on demand in recompute_dom_depth
a61af66fc99e Initial load
duke
parents:
diff changeset
1986 memset( _dom_depth, 0, _idom_size * sizeof(uint) );
a61af66fc99e Initial load
duke
parents:
diff changeset
1987
a61af66fc99e Initial load
duke
parents:
diff changeset
1988 Dominators();
a61af66fc99e Initial load
duke
parents:
diff changeset
1989
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
1990 if (!_verify_only) {
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
1991 // As a side effect, Dominators removed any unreachable CFG paths
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
1992 // into RegionNodes. It doesn't do this test against Root, so
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
1993 // we do it here.
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
1994 for( uint i = 1; i < C->root()->req(); i++ ) {
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
1995 if( !_nodes[C->root()->in(i)->_idx] ) { // Dead path into Root?
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
1996 _igvn.hash_delete(C->root());
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
1997 C->root()->del_req(i);
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
1998 _igvn._worklist.push(C->root());
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
1999 i--; // Rerun same iteration on compressed edges
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2000 }
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2001 }
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2002
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2003 // Given dominators, try to find inner loops with calls that must
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2004 // always be executed (call dominates loop tail). These loops do
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2005 // not need a separate safepoint.
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2006 Node_List cisstack(a);
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2007 _ltree_root->check_safepts(visited, cisstack);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2008 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2009
a61af66fc99e Initial load
duke
parents:
diff changeset
2010 // Walk the DATA nodes and place into loops. Find earliest control
a61af66fc99e Initial load
duke
parents:
diff changeset
2011 // node. For CFG nodes, the _nodes array starts out and remains
a61af66fc99e Initial load
duke
parents:
diff changeset
2012 // holding the associated IdealLoopTree pointer. For DATA nodes, the
a61af66fc99e Initial load
duke
parents:
diff changeset
2013 // _nodes array holds the earliest legal controlling CFG node.
a61af66fc99e Initial load
duke
parents:
diff changeset
2014
a61af66fc99e Initial load
duke
parents:
diff changeset
2015 // Allocate stack with enough space to avoid frequent realloc
a61af66fc99e Initial load
duke
parents:
diff changeset
2016 int stack_size = (C->unique() >> 1) + 16; // (unique>>1)+16 from Java2D stats
a61af66fc99e Initial load
duke
parents:
diff changeset
2017 Node_Stack nstack( a, stack_size );
a61af66fc99e Initial load
duke
parents:
diff changeset
2018
a61af66fc99e Initial load
duke
parents:
diff changeset
2019 visited.Clear();
a61af66fc99e Initial load
duke
parents:
diff changeset
2020 Node_List worklist(a);
a61af66fc99e Initial load
duke
parents:
diff changeset
2021 // Don't need C->root() on worklist since
a61af66fc99e Initial load
duke
parents:
diff changeset
2022 // it will be processed among C->top() inputs
a61af66fc99e Initial load
duke
parents:
diff changeset
2023 worklist.push( C->top() );
a61af66fc99e Initial load
duke
parents:
diff changeset
2024 visited.set( C->top()->_idx ); // Set C->top() as visited now
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2025 build_loop_early( visited, worklist, nstack );
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2026
a61af66fc99e Initial load
duke
parents:
diff changeset
2027 // Given early legal placement, try finding counted loops. This placement
a61af66fc99e Initial load
duke
parents:
diff changeset
2028 // is good enough to discover most loop invariants.
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2029 if( !_verify_me && !_verify_only )
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2030 _ltree_root->counted_loop( this );
a61af66fc99e Initial load
duke
parents:
diff changeset
2031
a61af66fc99e Initial load
duke
parents:
diff changeset
2032 // Find latest loop placement. Find ideal loop placement.
a61af66fc99e Initial load
duke
parents:
diff changeset
2033 visited.Clear();
a61af66fc99e Initial load
duke
parents:
diff changeset
2034 init_dom_lca_tags();
a61af66fc99e Initial load
duke
parents:
diff changeset
2035 // Need C->root() on worklist when processing outs
a61af66fc99e Initial load
duke
parents:
diff changeset
2036 worklist.push( C->root() );
a61af66fc99e Initial load
duke
parents:
diff changeset
2037 NOT_PRODUCT( C->verify_graph_edges(); )
a61af66fc99e Initial load
duke
parents:
diff changeset
2038 worklist.push( C->top() );
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2039 build_loop_late( visited, worklist, nstack );
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2040
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2041 if (_verify_only) {
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2042 // restore major progress flag
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2043 for (int i = 0; i < old_progress; i++)
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2044 C->set_major_progress();
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2045 assert(C->unique() == unique, "verification mode made Nodes? ? ?");
2403
1927db75dd85 7024475: loop doesn't terminate when compiled
never
parents: 2383
diff changeset
2046 assert(_igvn._worklist.size() == orig_worklist_size, "shouldn't push anything");
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2047 return;
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2048 }
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2049
2445
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
2050 // Some parser-inserted loop predicates could never be used by loop
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
2051 // predication or they were moved away from loop during some optimizations.
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
2052 // For example, peeling. Eliminate them before next loop optimizations.
3345
bad7ecd0b6ed 5091921: Sign flip issues in loop optimizer
kvn
parents: 2465
diff changeset
2053 if (UseLoopPredicate || LoopLimitCheck) {
1172
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
2054 eliminate_useless_predicates();
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
2055 }
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
2056
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2057 // clear out the dead code
a61af66fc99e Initial load
duke
parents:
diff changeset
2058 while(_deadlist.size()) {
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2059 _igvn.remove_globally_dead_node(_deadlist.pop());
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2060 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2061
a61af66fc99e Initial load
duke
parents:
diff changeset
2062 #ifndef PRODUCT
a61af66fc99e Initial load
duke
parents:
diff changeset
2063 C->verify_graph_edges();
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
2064 if (_verify_me) { // Nested verify pass?
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2065 // Check to see if the verify mode is broken
a61af66fc99e Initial load
duke
parents:
diff changeset
2066 assert(C->unique() == unique, "non-optimize mode made Nodes? ? ?");
a61af66fc99e Initial load
duke
parents:
diff changeset
2067 return;
a61af66fc99e Initial load
duke
parents:
diff changeset
2068 }
2383
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
2069 if(VerifyLoopOptimizations) verify();
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
2070 if(TraceLoopOpts && C->has_loops()) {
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
2071 _ltree_root->dump();
9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 2248
diff changeset
2072 }
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2073 #endif
a61af66fc99e Initial load
duke
parents:
diff changeset
2074
4064
670a74b863fc 7107042: assert(no_dead_loop) failed: dead loop detected
kvn
parents: 3936
diff changeset
2075 if (skip_loop_opts) {
670a74b863fc 7107042: assert(no_dead_loop) failed: dead loop detected
kvn
parents: 3936
diff changeset
2076 // Cleanup any modified bits
670a74b863fc 7107042: assert(no_dead_loop) failed: dead loop detected
kvn
parents: 3936
diff changeset
2077 _igvn.optimize();
670a74b863fc 7107042: assert(no_dead_loop) failed: dead loop detected
kvn
parents: 3936
diff changeset
2078
670a74b863fc 7107042: assert(no_dead_loop) failed: dead loop detected
kvn
parents: 3936
diff changeset
2079 if (C->log() != NULL) {
670a74b863fc 7107042: assert(no_dead_loop) failed: dead loop detected
kvn
parents: 3936
diff changeset
2080 log_loop_tree(_ltree_root, _ltree_root, C->log());
670a74b863fc 7107042: assert(no_dead_loop) failed: dead loop detected
kvn
parents: 3936
diff changeset
2081 }
670a74b863fc 7107042: assert(no_dead_loop) failed: dead loop detected
kvn
parents: 3936
diff changeset
2082 return;
670a74b863fc 7107042: assert(no_dead_loop) failed: dead loop detected
kvn
parents: 3936
diff changeset
2083 }
670a74b863fc 7107042: assert(no_dead_loop) failed: dead loop detected
kvn
parents: 3936
diff changeset
2084
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2085 if (ReassociateInvariants) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2086 // Reassociate invariants and prep for split_thru_phi
a61af66fc99e Initial load
duke
parents:
diff changeset
2087 for (LoopTreeIterator iter(_ltree_root); !iter.done(); iter.next()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2088 IdealLoopTree* lpt = iter.current();
a61af66fc99e Initial load
duke
parents:
diff changeset
2089 if (!lpt->is_counted() || !lpt->is_inner()) continue;
a61af66fc99e Initial load
duke
parents:
diff changeset
2090
a61af66fc99e Initial load
duke
parents:
diff changeset
2091 lpt->reassociate_invariants(this);
a61af66fc99e Initial load
duke
parents:
diff changeset
2092
a61af66fc99e Initial load
duke
parents:
diff changeset
2093 // Because RCE opportunities can be masked by split_thru_phi,
a61af66fc99e Initial load
duke
parents:
diff changeset
2094 // look for RCE candidates and inhibit split_thru_phi
a61af66fc99e Initial load
duke
parents:
diff changeset
2095 // on just their loop-phi's for this pass of loop opts
1172
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
2096 if (SplitIfBlocks && do_split_ifs) {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2097 if (lpt->policy_range_check(this)) {
39
76256d272075 6667612: (Escape Analysis) disable loop cloning if it has a scalar replaceable allocation
kvn
parents: 17
diff changeset
2098 lpt->_rce_candidate = 1; // = true
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2099 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2100 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2101 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2102 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2103
a61af66fc99e Initial load
duke
parents:
diff changeset
2104 // Check for aggressive application of split-if and other transforms
a61af66fc99e Initial load
duke
parents:
diff changeset
2105 // that require basic-block info (like cloning through Phi's)
a61af66fc99e Initial load
duke
parents:
diff changeset
2106 if( SplitIfBlocks && do_split_ifs ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2107 visited.Clear();
a61af66fc99e Initial load
duke
parents:
diff changeset
2108 split_if_with_blocks( visited, nstack );
a61af66fc99e Initial load
duke
parents:
diff changeset
2109 NOT_PRODUCT( if( VerifyLoopOptimizations ) verify(); );
a61af66fc99e Initial load
duke
parents:
diff changeset
2110 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2111
1172
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
2112 // Perform loop predication before iteration splitting
2445
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
2113 if (C->has_loops() && !C->major_progress() && (C->predicate_count() > 0)) {
1172
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
2114 _ltree_root->_child->loop_predication(this);
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
2115 }
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
2116
1763
d6f45b55c972 4809552: Optimize Arrays.fill(...)
never
parents: 1621
diff changeset
2117 if (OptimizeFill && UseLoopPredicate && C->has_loops() && !C->major_progress()) {
d6f45b55c972 4809552: Optimize Arrays.fill(...)
never
parents: 1621
diff changeset
2118 if (do_intrinsify_fill()) {
d6f45b55c972 4809552: Optimize Arrays.fill(...)
never
parents: 1621
diff changeset
2119 C->set_major_progress();
d6f45b55c972 4809552: Optimize Arrays.fill(...)
never
parents: 1621
diff changeset
2120 }
d6f45b55c972 4809552: Optimize Arrays.fill(...)
never
parents: 1621
diff changeset
2121 }
d6f45b55c972 4809552: Optimize Arrays.fill(...)
never
parents: 1621
diff changeset
2122
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2123 // Perform iteration-splitting on inner loops. Split iterations to avoid
a61af66fc99e Initial load
duke
parents:
diff changeset
2124 // range checks or one-shot null checks.
a61af66fc99e Initial load
duke
parents:
diff changeset
2125
a61af66fc99e Initial load
duke
parents:
diff changeset
2126 // If split-if's didn't hack the graph too bad (no CFG changes)
a61af66fc99e Initial load
duke
parents:
diff changeset
2127 // then do loop opts.
1172
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
2128 if (C->has_loops() && !C->major_progress()) {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2129 memset( worklist.adr(), 0, worklist.Size()*sizeof(Node*) );
a61af66fc99e Initial load
duke
parents:
diff changeset
2130 _ltree_root->_child->iteration_split( this, worklist );
a61af66fc99e Initial load
duke
parents:
diff changeset
2131 // No verify after peeling! GCM has hoisted code out of the loop.
a61af66fc99e Initial load
duke
parents:
diff changeset
2132 // After peeling, the hoisted code could sink inside the peeled area.
a61af66fc99e Initial load
duke
parents:
diff changeset
2133 // The peeling code does not try to recompute the best location for
a61af66fc99e Initial load
duke
parents:
diff changeset
2134 // all the code before the peeled area, so the verify pass will always
a61af66fc99e Initial load
duke
parents:
diff changeset
2135 // complain about it.
a61af66fc99e Initial load
duke
parents:
diff changeset
2136 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2137 // Do verify graph edges in any case
a61af66fc99e Initial load
duke
parents:
diff changeset
2138 NOT_PRODUCT( C->verify_graph_edges(); );
a61af66fc99e Initial load
duke
parents:
diff changeset
2139
1172
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
2140 if (!do_split_ifs) {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2141 // We saw major progress in Split-If to get here. We forced a
a61af66fc99e Initial load
duke
parents:
diff changeset
2142 // pass with unrolling and not split-if, however more split-if's
a61af66fc99e Initial load
duke
parents:
diff changeset
2143 // might make progress. If the unrolling didn't make progress
a61af66fc99e Initial load
duke
parents:
diff changeset
2144 // then the major-progress flag got cleared and we won't try
a61af66fc99e Initial load
duke
parents:
diff changeset
2145 // another round of Split-If. In particular the ever-common
a61af66fc99e Initial load
duke
parents:
diff changeset
2146 // instance-of/check-cast pattern requires at least 2 rounds of
a61af66fc99e Initial load
duke
parents:
diff changeset
2147 // Split-If to clear out.
a61af66fc99e Initial load
duke
parents:
diff changeset
2148 C->set_major_progress();
a61af66fc99e Initial load
duke
parents:
diff changeset
2149 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2150
a61af66fc99e Initial load
duke
parents:
diff changeset
2151 // Repeat loop optimizations if new loops were seen
a61af66fc99e Initial load
duke
parents:
diff changeset
2152 if (created_loop_node()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2153 C->set_major_progress();
a61af66fc99e Initial load
duke
parents:
diff changeset
2154 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2155
2445
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
2156 // Keep loop predicates and perform optimizations with them
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
2157 // until no more loop optimizations could be done.
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
2158 // After that switch predicates off and do more loop optimizations.
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
2159 if (!C->major_progress() && (C->predicate_count() > 0)) {
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
2160 C->cleanup_loop_predicates(_igvn);
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
2161 #ifndef PRODUCT
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
2162 if (TraceLoopOpts) {
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
2163 tty->print_cr("PredicatesOff");
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
2164 }
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
2165 #endif
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
2166 C->set_major_progress();
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
2167 }
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2168
2445
08eb13460b3a 7004535: Clone loop predicate during loop unswitch
kvn
parents: 2403
diff changeset
2169 // Convert scalar to superword operations at the end of all loop opts.
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2170 if (UseSuperWord && C->has_loops() && !C->major_progress()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2171 // SuperWord transform
a61af66fc99e Initial load
duke
parents:
diff changeset
2172 SuperWord sw(this);
a61af66fc99e Initial load
duke
parents:
diff changeset
2173 for (LoopTreeIterator iter(_ltree_root); !iter.done(); iter.next()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2174 IdealLoopTree* lpt = iter.current();
a61af66fc99e Initial load
duke
parents:
diff changeset
2175 if (lpt->is_counted()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2176 sw.transform_loop(lpt);
a61af66fc99e Initial load
duke
parents:
diff changeset
2177 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2178 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2179 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2180
a61af66fc99e Initial load
duke
parents:
diff changeset
2181 // Cleanup any modified bits
a61af66fc99e Initial load
duke
parents:
diff changeset
2182 _igvn.optimize();
a61af66fc99e Initial load
duke
parents:
diff changeset
2183
367
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
2184 // disable assert until issue with split_flow_path is resolved (6742111)
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
2185 // assert(!_has_irreducible_loops || C->parsed_irreducible_loop() || C->is_osr_compilation(),
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
2186 // "shouldn't introduce irreducible loops");
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
2187
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
2188 if (C->log() != NULL) {
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
2189 log_loop_tree(_ltree_root, _ltree_root, C->log());
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
2190 }
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2191 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2192
a61af66fc99e Initial load
duke
parents:
diff changeset
2193 #ifndef PRODUCT
a61af66fc99e Initial load
duke
parents:
diff changeset
2194 //------------------------------print_statistics-------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
2195 int PhaseIdealLoop::_loop_invokes=0;// Count of PhaseIdealLoop invokes
a61af66fc99e Initial load
duke
parents:
diff changeset
2196 int PhaseIdealLoop::_loop_work=0; // Sum of PhaseIdealLoop x unique
a61af66fc99e Initial load
duke
parents:
diff changeset
2197 void PhaseIdealLoop::print_statistics() {
a61af66fc99e Initial load
duke
parents:
diff changeset
2198 tty->print_cr("PhaseIdealLoop=%d, sum _unique=%d", _loop_invokes, _loop_work);
a61af66fc99e Initial load
duke
parents:
diff changeset
2199 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2200
a61af66fc99e Initial load
duke
parents:
diff changeset
2201 //------------------------------verify-----------------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
2202 // Build a verify-only PhaseIdealLoop, and see that it agrees with me.
a61af66fc99e Initial load
duke
parents:
diff changeset
2203 static int fail; // debug only, so its multi-thread dont care
a61af66fc99e Initial load
duke
parents:
diff changeset
2204 void PhaseIdealLoop::verify() const {
a61af66fc99e Initial load
duke
parents:
diff changeset
2205 int old_progress = C->major_progress();
a61af66fc99e Initial load
duke
parents:
diff changeset
2206 ResourceMark rm;
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2207 PhaseIdealLoop loop_verify( _igvn, this );
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2208 VectorSet visited(Thread::current()->resource_area());
a61af66fc99e Initial load
duke
parents:
diff changeset
2209
a61af66fc99e Initial load
duke
parents:
diff changeset
2210 fail = 0;
a61af66fc99e Initial load
duke
parents:
diff changeset
2211 verify_compare( C->root(), &loop_verify, visited );
a61af66fc99e Initial load
duke
parents:
diff changeset
2212 assert( fail == 0, "verify loops failed" );
a61af66fc99e Initial load
duke
parents:
diff changeset
2213 // Verify loop structure is the same
a61af66fc99e Initial load
duke
parents:
diff changeset
2214 _ltree_root->verify_tree(loop_verify._ltree_root, NULL);
a61af66fc99e Initial load
duke
parents:
diff changeset
2215 // Reset major-progress. It was cleared by creating a verify version of
a61af66fc99e Initial load
duke
parents:
diff changeset
2216 // PhaseIdealLoop.
a61af66fc99e Initial load
duke
parents:
diff changeset
2217 for( int i=0; i<old_progress; i++ )
a61af66fc99e Initial load
duke
parents:
diff changeset
2218 C->set_major_progress();
a61af66fc99e Initial load
duke
parents:
diff changeset
2219 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2220
a61af66fc99e Initial load
duke
parents:
diff changeset
2221 //------------------------------verify_compare---------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
2222 // Make sure me and the given PhaseIdealLoop agree on key data structures
a61af66fc99e Initial load
duke
parents:
diff changeset
2223 void PhaseIdealLoop::verify_compare( Node *n, const PhaseIdealLoop *loop_verify, VectorSet &visited ) const {
a61af66fc99e Initial load
duke
parents:
diff changeset
2224 if( !n ) return;
a61af66fc99e Initial load
duke
parents:
diff changeset
2225 if( visited.test_set( n->_idx ) ) return;
a61af66fc99e Initial load
duke
parents:
diff changeset
2226 if( !_nodes[n->_idx] ) { // Unreachable
a61af66fc99e Initial load
duke
parents:
diff changeset
2227 assert( !loop_verify->_nodes[n->_idx], "both should be unreachable" );
a61af66fc99e Initial load
duke
parents:
diff changeset
2228 return;
a61af66fc99e Initial load
duke
parents:
diff changeset
2229 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2230
a61af66fc99e Initial load
duke
parents:
diff changeset
2231 uint i;
a61af66fc99e Initial load
duke
parents:
diff changeset
2232 for( i = 0; i < n->req(); i++ )
a61af66fc99e Initial load
duke
parents:
diff changeset
2233 verify_compare( n->in(i), loop_verify, visited );
a61af66fc99e Initial load
duke
parents:
diff changeset
2234
a61af66fc99e Initial load
duke
parents:
diff changeset
2235 // Check the '_nodes' block/loop structure
a61af66fc99e Initial load
duke
parents:
diff changeset
2236 i = n->_idx;
a61af66fc99e Initial load
duke
parents:
diff changeset
2237 if( has_ctrl(n) ) { // We have control; verify has loop or ctrl
a61af66fc99e Initial load
duke
parents:
diff changeset
2238 if( _nodes[i] != loop_verify->_nodes[i] &&
a61af66fc99e Initial load
duke
parents:
diff changeset
2239 get_ctrl_no_update(n) != loop_verify->get_ctrl_no_update(n) ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2240 tty->print("Mismatched control setting for: ");
a61af66fc99e Initial load
duke
parents:
diff changeset
2241 n->dump();
a61af66fc99e Initial load
duke
parents:
diff changeset
2242 if( fail++ > 10 ) return;
a61af66fc99e Initial load
duke
parents:
diff changeset
2243 Node *c = get_ctrl_no_update(n);
a61af66fc99e Initial load
duke
parents:
diff changeset
2244 tty->print("We have it as: ");
a61af66fc99e Initial load
duke
parents:
diff changeset
2245 if( c->in(0) ) c->dump();
a61af66fc99e Initial load
duke
parents:
diff changeset
2246 else tty->print_cr("N%d",c->_idx);
a61af66fc99e Initial load
duke
parents:
diff changeset
2247 tty->print("Verify thinks: ");
a61af66fc99e Initial load
duke
parents:
diff changeset
2248 if( loop_verify->has_ctrl(n) )
a61af66fc99e Initial load
duke
parents:
diff changeset
2249 loop_verify->get_ctrl_no_update(n)->dump();
a61af66fc99e Initial load
duke
parents:
diff changeset
2250 else
a61af66fc99e Initial load
duke
parents:
diff changeset
2251 loop_verify->get_loop_idx(n)->dump();
a61af66fc99e Initial load
duke
parents:
diff changeset
2252 tty->cr();
a61af66fc99e Initial load
duke
parents:
diff changeset
2253 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2254 } else { // We have a loop
a61af66fc99e Initial load
duke
parents:
diff changeset
2255 IdealLoopTree *us = get_loop_idx(n);
a61af66fc99e Initial load
duke
parents:
diff changeset
2256 if( loop_verify->has_ctrl(n) ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2257 tty->print("Mismatched loop setting for: ");
a61af66fc99e Initial load
duke
parents:
diff changeset
2258 n->dump();
a61af66fc99e Initial load
duke
parents:
diff changeset
2259 if( fail++ > 10 ) return;
a61af66fc99e Initial load
duke
parents:
diff changeset
2260 tty->print("We have it as: ");
a61af66fc99e Initial load
duke
parents:
diff changeset
2261 us->dump();
a61af66fc99e Initial load
duke
parents:
diff changeset
2262 tty->print("Verify thinks: ");
a61af66fc99e Initial load
duke
parents:
diff changeset
2263 loop_verify->get_ctrl_no_update(n)->dump();
a61af66fc99e Initial load
duke
parents:
diff changeset
2264 tty->cr();
a61af66fc99e Initial load
duke
parents:
diff changeset
2265 } else if (!C->major_progress()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2266 // Loop selection can be messed up if we did a major progress
a61af66fc99e Initial load
duke
parents:
diff changeset
2267 // operation, like split-if. Do not verify in that case.
a61af66fc99e Initial load
duke
parents:
diff changeset
2268 IdealLoopTree *them = loop_verify->get_loop_idx(n);
a61af66fc99e Initial load
duke
parents:
diff changeset
2269 if( us->_head != them->_head || us->_tail != them->_tail ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2270 tty->print("Unequals loops for: ");
a61af66fc99e Initial load
duke
parents:
diff changeset
2271 n->dump();
a61af66fc99e Initial load
duke
parents:
diff changeset
2272 if( fail++ > 10 ) return;
a61af66fc99e Initial load
duke
parents:
diff changeset
2273 tty->print("We have it as: ");
a61af66fc99e Initial load
duke
parents:
diff changeset
2274 us->dump();
a61af66fc99e Initial load
duke
parents:
diff changeset
2275 tty->print("Verify thinks: ");
a61af66fc99e Initial load
duke
parents:
diff changeset
2276 them->dump();
a61af66fc99e Initial load
duke
parents:
diff changeset
2277 tty->cr();
a61af66fc99e Initial load
duke
parents:
diff changeset
2278 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2279 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2280 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2281
a61af66fc99e Initial load
duke
parents:
diff changeset
2282 // Check for immediate dominators being equal
a61af66fc99e Initial load
duke
parents:
diff changeset
2283 if( i >= _idom_size ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2284 if( !n->is_CFG() ) return;
a61af66fc99e Initial load
duke
parents:
diff changeset
2285 tty->print("CFG Node with no idom: ");
a61af66fc99e Initial load
duke
parents:
diff changeset
2286 n->dump();
a61af66fc99e Initial load
duke
parents:
diff changeset
2287 return;
a61af66fc99e Initial load
duke
parents:
diff changeset
2288 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2289 if( !n->is_CFG() ) return;
a61af66fc99e Initial load
duke
parents:
diff changeset
2290 if( n == C->root() ) return; // No IDOM here
a61af66fc99e Initial load
duke
parents:
diff changeset
2291
a61af66fc99e Initial load
duke
parents:
diff changeset
2292 assert(n->_idx == i, "sanity");
a61af66fc99e Initial load
duke
parents:
diff changeset
2293 Node *id = idom_no_update(n);
a61af66fc99e Initial load
duke
parents:
diff changeset
2294 if( id != loop_verify->idom_no_update(n) ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2295 tty->print("Unequals idoms for: ");
a61af66fc99e Initial load
duke
parents:
diff changeset
2296 n->dump();
a61af66fc99e Initial load
duke
parents:
diff changeset
2297 if( fail++ > 10 ) return;
a61af66fc99e Initial load
duke
parents:
diff changeset
2298 tty->print("We have it as: ");
a61af66fc99e Initial load
duke
parents:
diff changeset
2299 id->dump();
a61af66fc99e Initial load
duke
parents:
diff changeset
2300 tty->print("Verify thinks: ");
a61af66fc99e Initial load
duke
parents:
diff changeset
2301 loop_verify->idom_no_update(n)->dump();
a61af66fc99e Initial load
duke
parents:
diff changeset
2302 tty->cr();
a61af66fc99e Initial load
duke
parents:
diff changeset
2303 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2304
a61af66fc99e Initial load
duke
parents:
diff changeset
2305 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2306
a61af66fc99e Initial load
duke
parents:
diff changeset
2307 //------------------------------verify_tree------------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
2308 // Verify that tree structures match. Because the CFG can change, siblings
a61af66fc99e Initial load
duke
parents:
diff changeset
2309 // within the loop tree can be reordered. We attempt to deal with that by
a61af66fc99e Initial load
duke
parents:
diff changeset
2310 // reordering the verify's loop tree if possible.
a61af66fc99e Initial load
duke
parents:
diff changeset
2311 void IdealLoopTree::verify_tree(IdealLoopTree *loop, const IdealLoopTree *parent) const {
a61af66fc99e Initial load
duke
parents:
diff changeset
2312 assert( _parent == parent, "Badly formed loop tree" );
a61af66fc99e Initial load
duke
parents:
diff changeset
2313
a61af66fc99e Initial load
duke
parents:
diff changeset
2314 // Siblings not in same order? Attempt to re-order.
a61af66fc99e Initial load
duke
parents:
diff changeset
2315 if( _head != loop->_head ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2316 // Find _next pointer to update
a61af66fc99e Initial load
duke
parents:
diff changeset
2317 IdealLoopTree **pp = &loop->_parent->_child;
a61af66fc99e Initial load
duke
parents:
diff changeset
2318 while( *pp != loop )
a61af66fc99e Initial load
duke
parents:
diff changeset
2319 pp = &((*pp)->_next);
a61af66fc99e Initial load
duke
parents:
diff changeset
2320 // Find proper sibling to be next
a61af66fc99e Initial load
duke
parents:
diff changeset
2321 IdealLoopTree **nn = &loop->_next;
a61af66fc99e Initial load
duke
parents:
diff changeset
2322 while( (*nn) && (*nn)->_head != _head )
a61af66fc99e Initial load
duke
parents:
diff changeset
2323 nn = &((*nn)->_next);
a61af66fc99e Initial load
duke
parents:
diff changeset
2324
a61af66fc99e Initial load
duke
parents:
diff changeset
2325 // Check for no match.
a61af66fc99e Initial load
duke
parents:
diff changeset
2326 if( !(*nn) ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2327 // Annoyingly, irreducible loops can pick different headers
a61af66fc99e Initial load
duke
parents:
diff changeset
2328 // after a major_progress operation, so the rest of the loop
a61af66fc99e Initial load
duke
parents:
diff changeset
2329 // tree cannot be matched.
a61af66fc99e Initial load
duke
parents:
diff changeset
2330 if (_irreducible && Compile::current()->major_progress()) return;
a61af66fc99e Initial load
duke
parents:
diff changeset
2331 assert( 0, "failed to match loop tree" );
a61af66fc99e Initial load
duke
parents:
diff changeset
2332 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2333
a61af66fc99e Initial load
duke
parents:
diff changeset
2334 // Move (*nn) to (*pp)
a61af66fc99e Initial load
duke
parents:
diff changeset
2335 IdealLoopTree *hit = *nn;
a61af66fc99e Initial load
duke
parents:
diff changeset
2336 *nn = hit->_next;
a61af66fc99e Initial load
duke
parents:
diff changeset
2337 hit->_next = loop;
a61af66fc99e Initial load
duke
parents:
diff changeset
2338 *pp = loop;
a61af66fc99e Initial load
duke
parents:
diff changeset
2339 loop = hit;
a61af66fc99e Initial load
duke
parents:
diff changeset
2340 // Now try again to verify
a61af66fc99e Initial load
duke
parents:
diff changeset
2341 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2342
a61af66fc99e Initial load
duke
parents:
diff changeset
2343 assert( _head == loop->_head , "mismatched loop head" );
a61af66fc99e Initial load
duke
parents:
diff changeset
2344 Node *tail = _tail; // Inline a non-updating version of
a61af66fc99e Initial load
duke
parents:
diff changeset
2345 while( !tail->in(0) ) // the 'tail()' call.
a61af66fc99e Initial load
duke
parents:
diff changeset
2346 tail = tail->in(1);
a61af66fc99e Initial load
duke
parents:
diff changeset
2347 assert( tail == loop->_tail, "mismatched loop tail" );
a61af66fc99e Initial load
duke
parents:
diff changeset
2348
a61af66fc99e Initial load
duke
parents:
diff changeset
2349 // Counted loops that are guarded should be able to find their guards
a61af66fc99e Initial load
duke
parents:
diff changeset
2350 if( _head->is_CountedLoop() && _head->as_CountedLoop()->is_main_loop() ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2351 CountedLoopNode *cl = _head->as_CountedLoop();
a61af66fc99e Initial load
duke
parents:
diff changeset
2352 Node *init = cl->init_trip();
a61af66fc99e Initial load
duke
parents:
diff changeset
2353 Node *ctrl = cl->in(LoopNode::EntryControl);
a61af66fc99e Initial load
duke
parents:
diff changeset
2354 assert( ctrl->Opcode() == Op_IfTrue || ctrl->Opcode() == Op_IfFalse, "" );
a61af66fc99e Initial load
duke
parents:
diff changeset
2355 Node *iff = ctrl->in(0);
a61af66fc99e Initial load
duke
parents:
diff changeset
2356 assert( iff->Opcode() == Op_If, "" );
a61af66fc99e Initial load
duke
parents:
diff changeset
2357 Node *bol = iff->in(1);
a61af66fc99e Initial load
duke
parents:
diff changeset
2358 assert( bol->Opcode() == Op_Bool, "" );
a61af66fc99e Initial load
duke
parents:
diff changeset
2359 Node *cmp = bol->in(1);
a61af66fc99e Initial load
duke
parents:
diff changeset
2360 assert( cmp->Opcode() == Op_CmpI, "" );
a61af66fc99e Initial load
duke
parents:
diff changeset
2361 Node *add = cmp->in(1);
a61af66fc99e Initial load
duke
parents:
diff changeset
2362 Node *opaq;
a61af66fc99e Initial load
duke
parents:
diff changeset
2363 if( add->Opcode() == Op_Opaque1 ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2364 opaq = add;
a61af66fc99e Initial load
duke
parents:
diff changeset
2365 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
2366 assert( add->Opcode() == Op_AddI || add->Opcode() == Op_ConI , "" );
a61af66fc99e Initial load
duke
parents:
diff changeset
2367 assert( add == init, "" );
a61af66fc99e Initial load
duke
parents:
diff changeset
2368 opaq = cmp->in(2);
a61af66fc99e Initial load
duke
parents:
diff changeset
2369 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2370 assert( opaq->Opcode() == Op_Opaque1, "" );
a61af66fc99e Initial load
duke
parents:
diff changeset
2371
a61af66fc99e Initial load
duke
parents:
diff changeset
2372 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2373
a61af66fc99e Initial load
duke
parents:
diff changeset
2374 if (_child != NULL) _child->verify_tree(loop->_child, this);
a61af66fc99e Initial load
duke
parents:
diff changeset
2375 if (_next != NULL) _next ->verify_tree(loop->_next, parent);
a61af66fc99e Initial load
duke
parents:
diff changeset
2376 // Innermost loops need to verify loop bodies,
a61af66fc99e Initial load
duke
parents:
diff changeset
2377 // but only if no 'major_progress'
a61af66fc99e Initial load
duke
parents:
diff changeset
2378 int fail = 0;
a61af66fc99e Initial load
duke
parents:
diff changeset
2379 if (!Compile::current()->major_progress() && _child == NULL) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2380 for( uint i = 0; i < _body.size(); i++ ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2381 Node *n = _body.at(i);
a61af66fc99e Initial load
duke
parents:
diff changeset
2382 if (n->outcnt() == 0) continue; // Ignore dead
a61af66fc99e Initial load
duke
parents:
diff changeset
2383 uint j;
a61af66fc99e Initial load
duke
parents:
diff changeset
2384 for( j = 0; j < loop->_body.size(); j++ )
a61af66fc99e Initial load
duke
parents:
diff changeset
2385 if( loop->_body.at(j) == n )
a61af66fc99e Initial load
duke
parents:
diff changeset
2386 break;
a61af66fc99e Initial load
duke
parents:
diff changeset
2387 if( j == loop->_body.size() ) { // Not found in loop body
a61af66fc99e Initial load
duke
parents:
diff changeset
2388 // Last ditch effort to avoid assertion: Its possible that we
a61af66fc99e Initial load
duke
parents:
diff changeset
2389 // have some users (so outcnt not zero) but are still dead.
a61af66fc99e Initial load
duke
parents:
diff changeset
2390 // Try to find from root.
a61af66fc99e Initial load
duke
parents:
diff changeset
2391 if (Compile::current()->root()->find(n->_idx)) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2392 fail++;
a61af66fc99e Initial load
duke
parents:
diff changeset
2393 tty->print("We have that verify does not: ");
a61af66fc99e Initial load
duke
parents:
diff changeset
2394 n->dump();
a61af66fc99e Initial load
duke
parents:
diff changeset
2395 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2396 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2397 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2398 for( uint i2 = 0; i2 < loop->_body.size(); i2++ ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2399 Node *n = loop->_body.at(i2);
a61af66fc99e Initial load
duke
parents:
diff changeset
2400 if (n->outcnt() == 0) continue; // Ignore dead
a61af66fc99e Initial load
duke
parents:
diff changeset
2401 uint j;
a61af66fc99e Initial load
duke
parents:
diff changeset
2402 for( j = 0; j < _body.size(); j++ )
a61af66fc99e Initial load
duke
parents:
diff changeset
2403 if( _body.at(j) == n )
a61af66fc99e Initial load
duke
parents:
diff changeset
2404 break;
a61af66fc99e Initial load
duke
parents:
diff changeset
2405 if( j == _body.size() ) { // Not found in loop body
a61af66fc99e Initial load
duke
parents:
diff changeset
2406 // Last ditch effort to avoid assertion: Its possible that we
a61af66fc99e Initial load
duke
parents:
diff changeset
2407 // have some users (so outcnt not zero) but are still dead.
a61af66fc99e Initial load
duke
parents:
diff changeset
2408 // Try to find from root.
a61af66fc99e Initial load
duke
parents:
diff changeset
2409 if (Compile::current()->root()->find(n->_idx)) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2410 fail++;
a61af66fc99e Initial load
duke
parents:
diff changeset
2411 tty->print("Verify has that we do not: ");
a61af66fc99e Initial load
duke
parents:
diff changeset
2412 n->dump();
a61af66fc99e Initial load
duke
parents:
diff changeset
2413 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2414 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2415 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2416 assert( !fail, "loop body mismatch" );
a61af66fc99e Initial load
duke
parents:
diff changeset
2417 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2418 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2419
a61af66fc99e Initial load
duke
parents:
diff changeset
2420 #endif
a61af66fc99e Initial load
duke
parents:
diff changeset
2421
a61af66fc99e Initial load
duke
parents:
diff changeset
2422 //------------------------------set_idom---------------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
2423 void PhaseIdealLoop::set_idom(Node* d, Node* n, uint dom_depth) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2424 uint idx = d->_idx;
a61af66fc99e Initial load
duke
parents:
diff changeset
2425 if (idx >= _idom_size) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2426 uint newsize = _idom_size<<1;
a61af66fc99e Initial load
duke
parents:
diff changeset
2427 while( idx >= newsize ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2428 newsize <<= 1;
a61af66fc99e Initial load
duke
parents:
diff changeset
2429 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2430 _idom = REALLOC_RESOURCE_ARRAY( Node*, _idom,_idom_size,newsize);
a61af66fc99e Initial load
duke
parents:
diff changeset
2431 _dom_depth = REALLOC_RESOURCE_ARRAY( uint, _dom_depth,_idom_size,newsize);
a61af66fc99e Initial load
duke
parents:
diff changeset
2432 memset( _dom_depth + _idom_size, 0, (newsize - _idom_size) * sizeof(uint) );
a61af66fc99e Initial load
duke
parents:
diff changeset
2433 _idom_size = newsize;
a61af66fc99e Initial load
duke
parents:
diff changeset
2434 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2435 _idom[idx] = n;
a61af66fc99e Initial load
duke
parents:
diff changeset
2436 _dom_depth[idx] = dom_depth;
a61af66fc99e Initial load
duke
parents:
diff changeset
2437 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2438
a61af66fc99e Initial load
duke
parents:
diff changeset
2439 //------------------------------recompute_dom_depth---------------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
2440 // The dominator tree is constructed with only parent pointers.
a61af66fc99e Initial load
duke
parents:
diff changeset
2441 // This recomputes the depth in the tree by first tagging all
a61af66fc99e Initial load
duke
parents:
diff changeset
2442 // nodes as "no depth yet" marker. The next pass then runs up
a61af66fc99e Initial load
duke
parents:
diff changeset
2443 // the dom tree from each node marked "no depth yet", and computes
a61af66fc99e Initial load
duke
parents:
diff changeset
2444 // the depth on the way back down.
a61af66fc99e Initial load
duke
parents:
diff changeset
2445 void PhaseIdealLoop::recompute_dom_depth() {
a61af66fc99e Initial load
duke
parents:
diff changeset
2446 uint no_depth_marker = C->unique();
a61af66fc99e Initial load
duke
parents:
diff changeset
2447 uint i;
a61af66fc99e Initial load
duke
parents:
diff changeset
2448 // Initialize depth to "no depth yet"
a61af66fc99e Initial load
duke
parents:
diff changeset
2449 for (i = 0; i < _idom_size; i++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2450 if (_dom_depth[i] > 0 && _idom[i] != NULL) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2451 _dom_depth[i] = no_depth_marker;
a61af66fc99e Initial load
duke
parents:
diff changeset
2452 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2453 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2454 if (_dom_stk == NULL) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2455 uint init_size = C->unique() / 100; // Guess that 1/100 is a reasonable initial size.
a61af66fc99e Initial load
duke
parents:
diff changeset
2456 if (init_size < 10) init_size = 10;
2248
194c9fdee631 7017240: C2: native memory leak in nsk/regression/b4675027 on windows-x86 in comp mode with G1
kvn
parents: 1972
diff changeset
2457 _dom_stk = new GrowableArray<uint>(init_size);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2458 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2459 // Compute new depth for each node.
a61af66fc99e Initial load
duke
parents:
diff changeset
2460 for (i = 0; i < _idom_size; i++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2461 uint j = i;
a61af66fc99e Initial load
duke
parents:
diff changeset
2462 // Run up the dom tree to find a node with a depth
a61af66fc99e Initial load
duke
parents:
diff changeset
2463 while (_dom_depth[j] == no_depth_marker) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2464 _dom_stk->push(j);
a61af66fc99e Initial load
duke
parents:
diff changeset
2465 j = _idom[j]->_idx;
a61af66fc99e Initial load
duke
parents:
diff changeset
2466 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2467 // Compute the depth on the way back down this tree branch
a61af66fc99e Initial load
duke
parents:
diff changeset
2468 uint dd = _dom_depth[j] + 1;
a61af66fc99e Initial load
duke
parents:
diff changeset
2469 while (_dom_stk->length() > 0) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2470 uint j = _dom_stk->pop();
a61af66fc99e Initial load
duke
parents:
diff changeset
2471 _dom_depth[j] = dd;
a61af66fc99e Initial load
duke
parents:
diff changeset
2472 dd++;
a61af66fc99e Initial load
duke
parents:
diff changeset
2473 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2474 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2475 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2476
a61af66fc99e Initial load
duke
parents:
diff changeset
2477 //------------------------------sort-------------------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
2478 // Insert 'loop' into the existing loop tree. 'innermost' is a leaf of the
a61af66fc99e Initial load
duke
parents:
diff changeset
2479 // loop tree, not the root.
a61af66fc99e Initial load
duke
parents:
diff changeset
2480 IdealLoopTree *PhaseIdealLoop::sort( IdealLoopTree *loop, IdealLoopTree *innermost ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2481 if( !innermost ) return loop; // New innermost loop
a61af66fc99e Initial load
duke
parents:
diff changeset
2482
a61af66fc99e Initial load
duke
parents:
diff changeset
2483 int loop_preorder = get_preorder(loop->_head); // Cache pre-order number
a61af66fc99e Initial load
duke
parents:
diff changeset
2484 assert( loop_preorder, "not yet post-walked loop" );
a61af66fc99e Initial load
duke
parents:
diff changeset
2485 IdealLoopTree **pp = &innermost; // Pointer to previous next-pointer
a61af66fc99e Initial load
duke
parents:
diff changeset
2486 IdealLoopTree *l = *pp; // Do I go before or after 'l'?
a61af66fc99e Initial load
duke
parents:
diff changeset
2487
a61af66fc99e Initial load
duke
parents:
diff changeset
2488 // Insert at start of list
a61af66fc99e Initial load
duke
parents:
diff changeset
2489 while( l ) { // Insertion sort based on pre-order
a61af66fc99e Initial load
duke
parents:
diff changeset
2490 if( l == loop ) return innermost; // Already on list!
a61af66fc99e Initial load
duke
parents:
diff changeset
2491 int l_preorder = get_preorder(l->_head); // Cache pre-order number
a61af66fc99e Initial load
duke
parents:
diff changeset
2492 assert( l_preorder, "not yet post-walked l" );
a61af66fc99e Initial load
duke
parents:
diff changeset
2493 // Check header pre-order number to figure proper nesting
a61af66fc99e Initial load
duke
parents:
diff changeset
2494 if( loop_preorder > l_preorder )
a61af66fc99e Initial load
duke
parents:
diff changeset
2495 break; // End of insertion
a61af66fc99e Initial load
duke
parents:
diff changeset
2496 // If headers tie (e.g., shared headers) check tail pre-order numbers.
a61af66fc99e Initial load
duke
parents:
diff changeset
2497 // Since I split shared headers, you'd think this could not happen.
a61af66fc99e Initial load
duke
parents:
diff changeset
2498 // BUT: I must first do the preorder numbering before I can discover I
a61af66fc99e Initial load
duke
parents:
diff changeset
2499 // have shared headers, so the split headers all get the same preorder
a61af66fc99e Initial load
duke
parents:
diff changeset
2500 // number as the RegionNode they split from.
a61af66fc99e Initial load
duke
parents:
diff changeset
2501 if( loop_preorder == l_preorder &&
a61af66fc99e Initial load
duke
parents:
diff changeset
2502 get_preorder(loop->_tail) < get_preorder(l->_tail) )
a61af66fc99e Initial load
duke
parents:
diff changeset
2503 break; // Also check for shared headers (same pre#)
a61af66fc99e Initial load
duke
parents:
diff changeset
2504 pp = &l->_parent; // Chain up list
a61af66fc99e Initial load
duke
parents:
diff changeset
2505 l = *pp;
a61af66fc99e Initial load
duke
parents:
diff changeset
2506 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2507 // Link into list
a61af66fc99e Initial load
duke
parents:
diff changeset
2508 // Point predecessor to me
a61af66fc99e Initial load
duke
parents:
diff changeset
2509 *pp = loop;
a61af66fc99e Initial load
duke
parents:
diff changeset
2510 // Point me to successor
a61af66fc99e Initial load
duke
parents:
diff changeset
2511 IdealLoopTree *p = loop->_parent;
a61af66fc99e Initial load
duke
parents:
diff changeset
2512 loop->_parent = l; // Point me to successor
a61af66fc99e Initial load
duke
parents:
diff changeset
2513 if( p ) sort( p, innermost ); // Insert my parents into list as well
a61af66fc99e Initial load
duke
parents:
diff changeset
2514 return innermost;
a61af66fc99e Initial load
duke
parents:
diff changeset
2515 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2516
a61af66fc99e Initial load
duke
parents:
diff changeset
2517 //------------------------------build_loop_tree--------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
2518 // I use a modified Vick/Tarjan algorithm. I need pre- and a post- visit
a61af66fc99e Initial load
duke
parents:
diff changeset
2519 // bits. The _nodes[] array is mapped by Node index and holds a NULL for
a61af66fc99e Initial load
duke
parents:
diff changeset
2520 // not-yet-pre-walked, pre-order # for pre-but-not-post-walked and holds the
a61af66fc99e Initial load
duke
parents:
diff changeset
2521 // tightest enclosing IdealLoopTree for post-walked.
a61af66fc99e Initial load
duke
parents:
diff changeset
2522 //
a61af66fc99e Initial load
duke
parents:
diff changeset
2523 // During my forward walk I do a short 1-layer lookahead to see if I can find
a61af66fc99e Initial load
duke
parents:
diff changeset
2524 // a loop backedge with that doesn't have any work on the backedge. This
a61af66fc99e Initial load
duke
parents:
diff changeset
2525 // helps me construct nested loops with shared headers better.
a61af66fc99e Initial load
duke
parents:
diff changeset
2526 //
a61af66fc99e Initial load
duke
parents:
diff changeset
2527 // Once I've done the forward recursion, I do the post-work. For each child
a61af66fc99e Initial load
duke
parents:
diff changeset
2528 // I check to see if there is a backedge. Backedges define a loop! I
a61af66fc99e Initial load
duke
parents:
diff changeset
2529 // insert an IdealLoopTree at the target of the backedge.
a61af66fc99e Initial load
duke
parents:
diff changeset
2530 //
a61af66fc99e Initial load
duke
parents:
diff changeset
2531 // During the post-work I also check to see if I have several children
a61af66fc99e Initial load
duke
parents:
diff changeset
2532 // belonging to different loops. If so, then this Node is a decision point
a61af66fc99e Initial load
duke
parents:
diff changeset
2533 // where control flow can choose to change loop nests. It is at this
a61af66fc99e Initial load
duke
parents:
diff changeset
2534 // decision point where I can figure out how loops are nested. At this
a61af66fc99e Initial load
duke
parents:
diff changeset
2535 // time I can properly order the different loop nests from my children.
a61af66fc99e Initial load
duke
parents:
diff changeset
2536 // Note that there may not be any backedges at the decision point!
a61af66fc99e Initial load
duke
parents:
diff changeset
2537 //
a61af66fc99e Initial load
duke
parents:
diff changeset
2538 // Since the decision point can be far removed from the backedges, I can't
a61af66fc99e Initial load
duke
parents:
diff changeset
2539 // order my loops at the time I discover them. Thus at the decision point
a61af66fc99e Initial load
duke
parents:
diff changeset
2540 // I need to inspect loop header pre-order numbers to properly nest my
a61af66fc99e Initial load
duke
parents:
diff changeset
2541 // loops. This means I need to sort my childrens' loops by pre-order.
a61af66fc99e Initial load
duke
parents:
diff changeset
2542 // The sort is of size number-of-control-children, which generally limits
a61af66fc99e Initial load
duke
parents:
diff changeset
2543 // it to size 2 (i.e., I just choose between my 2 target loops).
a61af66fc99e Initial load
duke
parents:
diff changeset
2544 void PhaseIdealLoop::build_loop_tree() {
a61af66fc99e Initial load
duke
parents:
diff changeset
2545 // Allocate stack of size C->unique()/2 to avoid frequent realloc
a61af66fc99e Initial load
duke
parents:
diff changeset
2546 GrowableArray <Node *> bltstack(C->unique() >> 1);
a61af66fc99e Initial load
duke
parents:
diff changeset
2547 Node *n = C->root();
a61af66fc99e Initial load
duke
parents:
diff changeset
2548 bltstack.push(n);
a61af66fc99e Initial load
duke
parents:
diff changeset
2549 int pre_order = 1;
a61af66fc99e Initial load
duke
parents:
diff changeset
2550 int stack_size;
a61af66fc99e Initial load
duke
parents:
diff changeset
2551
a61af66fc99e Initial load
duke
parents:
diff changeset
2552 while ( ( stack_size = bltstack.length() ) != 0 ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2553 n = bltstack.top(); // Leave node on stack
a61af66fc99e Initial load
duke
parents:
diff changeset
2554 if ( !is_visited(n) ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2555 // ---- Pre-pass Work ----
a61af66fc99e Initial load
duke
parents:
diff changeset
2556 // Pre-walked but not post-walked nodes need a pre_order number.
a61af66fc99e Initial load
duke
parents:
diff changeset
2557
a61af66fc99e Initial load
duke
parents:
diff changeset
2558 set_preorder_visited( n, pre_order ); // set as visited
a61af66fc99e Initial load
duke
parents:
diff changeset
2559
a61af66fc99e Initial load
duke
parents:
diff changeset
2560 // ---- Scan over children ----
a61af66fc99e Initial load
duke
parents:
diff changeset
2561 // Scan first over control projections that lead to loop headers.
a61af66fc99e Initial load
duke
parents:
diff changeset
2562 // This helps us find inner-to-outer loops with shared headers better.
a61af66fc99e Initial load
duke
parents:
diff changeset
2563
a61af66fc99e Initial load
duke
parents:
diff changeset
2564 // Scan children's children for loop headers.
a61af66fc99e Initial load
duke
parents:
diff changeset
2565 for ( int i = n->outcnt() - 1; i >= 0; --i ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2566 Node* m = n->raw_out(i); // Child
a61af66fc99e Initial load
duke
parents:
diff changeset
2567 if( m->is_CFG() && !is_visited(m) ) { // Only for CFG children
a61af66fc99e Initial load
duke
parents:
diff changeset
2568 // Scan over children's children to find loop
a61af66fc99e Initial load
duke
parents:
diff changeset
2569 for (DUIterator_Fast jmax, j = m->fast_outs(jmax); j < jmax; j++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2570 Node* l = m->fast_out(j);
a61af66fc99e Initial load
duke
parents:
diff changeset
2571 if( is_visited(l) && // Been visited?
a61af66fc99e Initial load
duke
parents:
diff changeset
2572 !is_postvisited(l) && // But not post-visited
a61af66fc99e Initial load
duke
parents:
diff changeset
2573 get_preorder(l) < pre_order ) { // And smaller pre-order
a61af66fc99e Initial load
duke
parents:
diff changeset
2574 // Found! Scan the DFS down this path before doing other paths
a61af66fc99e Initial load
duke
parents:
diff changeset
2575 bltstack.push(m);
a61af66fc99e Initial load
duke
parents:
diff changeset
2576 break;
a61af66fc99e Initial load
duke
parents:
diff changeset
2577 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2578 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2579 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2580 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2581 pre_order++;
a61af66fc99e Initial load
duke
parents:
diff changeset
2582 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2583 else if ( !is_postvisited(n) ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2584 // Note: build_loop_tree_impl() adds out edges on rare occasions,
a61af66fc99e Initial load
duke
parents:
diff changeset
2585 // such as com.sun.rsasign.am::a.
a61af66fc99e Initial load
duke
parents:
diff changeset
2586 // For non-recursive version, first, process current children.
a61af66fc99e Initial load
duke
parents:
diff changeset
2587 // On next iteration, check if additional children were added.
a61af66fc99e Initial load
duke
parents:
diff changeset
2588 for ( int k = n->outcnt() - 1; k >= 0; --k ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2589 Node* u = n->raw_out(k);
a61af66fc99e Initial load
duke
parents:
diff changeset
2590 if ( u->is_CFG() && !is_visited(u) ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2591 bltstack.push(u);
a61af66fc99e Initial load
duke
parents:
diff changeset
2592 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2593 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2594 if ( bltstack.length() == stack_size ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2595 // There were no additional children, post visit node now
a61af66fc99e Initial load
duke
parents:
diff changeset
2596 (void)bltstack.pop(); // Remove node from stack
a61af66fc99e Initial load
duke
parents:
diff changeset
2597 pre_order = build_loop_tree_impl( n, pre_order );
a61af66fc99e Initial load
duke
parents:
diff changeset
2598 // Check for bailout
a61af66fc99e Initial load
duke
parents:
diff changeset
2599 if (C->failing()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2600 return;
a61af66fc99e Initial load
duke
parents:
diff changeset
2601 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2602 // Check to grow _preorders[] array for the case when
a61af66fc99e Initial load
duke
parents:
diff changeset
2603 // build_loop_tree_impl() adds new nodes.
a61af66fc99e Initial load
duke
parents:
diff changeset
2604 check_grow_preorders();
a61af66fc99e Initial load
duke
parents:
diff changeset
2605 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2606 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2607 else {
a61af66fc99e Initial load
duke
parents:
diff changeset
2608 (void)bltstack.pop(); // Remove post-visited node from stack
a61af66fc99e Initial load
duke
parents:
diff changeset
2609 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2610 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2611 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2612
a61af66fc99e Initial load
duke
parents:
diff changeset
2613 //------------------------------build_loop_tree_impl---------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
2614 int PhaseIdealLoop::build_loop_tree_impl( Node *n, int pre_order ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2615 // ---- Post-pass Work ----
a61af66fc99e Initial load
duke
parents:
diff changeset
2616 // Pre-walked but not post-walked nodes need a pre_order number.
a61af66fc99e Initial load
duke
parents:
diff changeset
2617
a61af66fc99e Initial load
duke
parents:
diff changeset
2618 // Tightest enclosing loop for this Node
a61af66fc99e Initial load
duke
parents:
diff changeset
2619 IdealLoopTree *innermost = NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
2620
a61af66fc99e Initial load
duke
parents:
diff changeset
2621 // For all children, see if any edge is a backedge. If so, make a loop
a61af66fc99e Initial load
duke
parents:
diff changeset
2622 // for it. Then find the tightest enclosing loop for the self Node.
a61af66fc99e Initial load
duke
parents:
diff changeset
2623 for (DUIterator_Fast imax, i = n->fast_outs(imax); i < imax; i++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2624 Node* m = n->fast_out(i); // Child
a61af66fc99e Initial load
duke
parents:
diff changeset
2625 if( n == m ) continue; // Ignore control self-cycles
a61af66fc99e Initial load
duke
parents:
diff changeset
2626 if( !m->is_CFG() ) continue;// Ignore non-CFG edges
a61af66fc99e Initial load
duke
parents:
diff changeset
2627
a61af66fc99e Initial load
duke
parents:
diff changeset
2628 IdealLoopTree *l; // Child's loop
a61af66fc99e Initial load
duke
parents:
diff changeset
2629 if( !is_postvisited(m) ) { // Child visited but not post-visited?
a61af66fc99e Initial load
duke
parents:
diff changeset
2630 // Found a backedge
a61af66fc99e Initial load
duke
parents:
diff changeset
2631 assert( get_preorder(m) < pre_order, "should be backedge" );
a61af66fc99e Initial load
duke
parents:
diff changeset
2632 // Check for the RootNode, which is already a LoopNode and is allowed
a61af66fc99e Initial load
duke
parents:
diff changeset
2633 // to have multiple "backedges".
a61af66fc99e Initial load
duke
parents:
diff changeset
2634 if( m == C->root()) { // Found the root?
a61af66fc99e Initial load
duke
parents:
diff changeset
2635 l = _ltree_root; // Root is the outermost LoopNode
a61af66fc99e Initial load
duke
parents:
diff changeset
2636 } else { // Else found a nested loop
a61af66fc99e Initial load
duke
parents:
diff changeset
2637 // Insert a LoopNode to mark this loop.
a61af66fc99e Initial load
duke
parents:
diff changeset
2638 l = new IdealLoopTree(this, m, n);
a61af66fc99e Initial load
duke
parents:
diff changeset
2639 } // End of Else found a nested loop
a61af66fc99e Initial load
duke
parents:
diff changeset
2640 if( !has_loop(m) ) // If 'm' does not already have a loop set
a61af66fc99e Initial load
duke
parents:
diff changeset
2641 set_loop(m, l); // Set loop header to loop now
a61af66fc99e Initial load
duke
parents:
diff changeset
2642
a61af66fc99e Initial load
duke
parents:
diff changeset
2643 } else { // Else not a nested loop
a61af66fc99e Initial load
duke
parents:
diff changeset
2644 if( !_nodes[m->_idx] ) continue; // Dead code has no loop
a61af66fc99e Initial load
duke
parents:
diff changeset
2645 l = get_loop(m); // Get previously determined loop
a61af66fc99e Initial load
duke
parents:
diff changeset
2646 // If successor is header of a loop (nest), move up-loop till it
a61af66fc99e Initial load
duke
parents:
diff changeset
2647 // is a member of some outer enclosing loop. Since there are no
a61af66fc99e Initial load
duke
parents:
diff changeset
2648 // shared headers (I've split them already) I only need to go up
a61af66fc99e Initial load
duke
parents:
diff changeset
2649 // at most 1 level.
a61af66fc99e Initial load
duke
parents:
diff changeset
2650 while( l && l->_head == m ) // Successor heads loop?
a61af66fc99e Initial load
duke
parents:
diff changeset
2651 l = l->_parent; // Move up 1 for me
a61af66fc99e Initial load
duke
parents:
diff changeset
2652 // If this loop is not properly parented, then this loop
a61af66fc99e Initial load
duke
parents:
diff changeset
2653 // has no exit path out, i.e. its an infinite loop.
a61af66fc99e Initial load
duke
parents:
diff changeset
2654 if( !l ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2655 // Make loop "reachable" from root so the CFG is reachable. Basically
a61af66fc99e Initial load
duke
parents:
diff changeset
2656 // insert a bogus loop exit that is never taken. 'm', the loop head,
a61af66fc99e Initial load
duke
parents:
diff changeset
2657 // points to 'n', one (of possibly many) fall-in paths. There may be
a61af66fc99e Initial load
duke
parents:
diff changeset
2658 // many backedges as well.
a61af66fc99e Initial load
duke
parents:
diff changeset
2659
a61af66fc99e Initial load
duke
parents:
diff changeset
2660 // Here I set the loop to be the root loop. I could have, after
a61af66fc99e Initial load
duke
parents:
diff changeset
2661 // inserting a bogus loop exit, restarted the recursion and found my
a61af66fc99e Initial load
duke
parents:
diff changeset
2662 // new loop exit. This would make the infinite loop a first-class
a61af66fc99e Initial load
duke
parents:
diff changeset
2663 // loop and it would then get properly optimized. What's the use of
a61af66fc99e Initial load
duke
parents:
diff changeset
2664 // optimizing an infinite loop?
a61af66fc99e Initial load
duke
parents:
diff changeset
2665 l = _ltree_root; // Oops, found infinite loop
a61af66fc99e Initial load
duke
parents:
diff changeset
2666
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2667 if (!_verify_only) {
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2668 // Insert the NeverBranch between 'm' and it's control user.
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2669 NeverBranchNode *iff = new (C, 1) NeverBranchNode( m );
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2670 _igvn.register_new_node_with_optimizer(iff);
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2671 set_loop(iff, l);
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2672 Node *if_t = new (C, 1) CProjNode( iff, 0 );
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2673 _igvn.register_new_node_with_optimizer(if_t);
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2674 set_loop(if_t, l);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2675
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2676 Node* cfg = NULL; // Find the One True Control User of m
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2677 for (DUIterator_Fast jmax, j = m->fast_outs(jmax); j < jmax; j++) {
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2678 Node* x = m->fast_out(j);
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2679 if (x->is_CFG() && x != m && x != iff)
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2680 { cfg = x; break; }
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2681 }
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2682 assert(cfg != NULL, "must find the control user of m");
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2683 uint k = 0; // Probably cfg->in(0)
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2684 while( cfg->in(k) != m ) k++; // But check incase cfg is a Region
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2685 cfg->set_req( k, if_t ); // Now point to NeverBranch
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2686
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2687 // Now create the never-taken loop exit
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2688 Node *if_f = new (C, 1) CProjNode( iff, 1 );
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2689 _igvn.register_new_node_with_optimizer(if_f);
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2690 set_loop(if_f, l);
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2691 // Find frame ptr for Halt. Relies on the optimizer
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2692 // V-N'ing. Easier and quicker than searching through
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2693 // the program structure.
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2694 Node *frame = new (C, 1) ParmNode( C->start(), TypeFunc::FramePtr );
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2695 _igvn.register_new_node_with_optimizer(frame);
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2696 // Halt & Catch Fire
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2697 Node *halt = new (C, TypeFunc::Parms) HaltNode( if_f, frame );
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2698 _igvn.register_new_node_with_optimizer(halt);
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2699 set_loop(halt, l);
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2700 C->root()->add_req(halt);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2701 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2702 set_loop(C->root(), _ltree_root);
a61af66fc99e Initial load
duke
parents:
diff changeset
2703 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2704 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2705 // Weeny check for irreducible. This child was already visited (this
a61af66fc99e Initial load
duke
parents:
diff changeset
2706 // IS the post-work phase). Is this child's loop header post-visited
a61af66fc99e Initial load
duke
parents:
diff changeset
2707 // as well? If so, then I found another entry into the loop.
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2708 if (!_verify_only) {
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2709 while( is_postvisited(l->_head) ) {
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2710 // found irreducible
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2711 l->_irreducible = 1; // = true
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2712 l = l->_parent;
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2713 _has_irreducible_loops = true;
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2714 // Check for bad CFG here to prevent crash, and bailout of compile
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2715 if (l == NULL) {
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2716 C->record_method_not_compilable("unhandled CFG detected during loop optimization");
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2717 return pre_order;
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2718 }
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2719 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2720 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2721
a61af66fc99e Initial load
duke
parents:
diff changeset
2722 // This Node might be a decision point for loops. It is only if
a61af66fc99e Initial load
duke
parents:
diff changeset
2723 // it's children belong to several different loops. The sort call
a61af66fc99e Initial load
duke
parents:
diff changeset
2724 // does a trivial amount of work if there is only 1 child or all
a61af66fc99e Initial load
duke
parents:
diff changeset
2725 // children belong to the same loop. If however, the children
a61af66fc99e Initial load
duke
parents:
diff changeset
2726 // belong to different loops, the sort call will properly set the
a61af66fc99e Initial load
duke
parents:
diff changeset
2727 // _parent pointers to show how the loops nest.
a61af66fc99e Initial load
duke
parents:
diff changeset
2728 //
a61af66fc99e Initial load
duke
parents:
diff changeset
2729 // In any case, it returns the tightest enclosing loop.
a61af66fc99e Initial load
duke
parents:
diff changeset
2730 innermost = sort( l, innermost );
a61af66fc99e Initial load
duke
parents:
diff changeset
2731 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2732
a61af66fc99e Initial load
duke
parents:
diff changeset
2733 // Def-use info will have some dead stuff; dead stuff will have no
a61af66fc99e Initial load
duke
parents:
diff changeset
2734 // loop decided on.
a61af66fc99e Initial load
duke
parents:
diff changeset
2735
a61af66fc99e Initial load
duke
parents:
diff changeset
2736 // Am I a loop header? If so fix up my parent's child and next ptrs.
a61af66fc99e Initial load
duke
parents:
diff changeset
2737 if( innermost && innermost->_head == n ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2738 assert( get_loop(n) == innermost, "" );
a61af66fc99e Initial load
duke
parents:
diff changeset
2739 IdealLoopTree *p = innermost->_parent;
a61af66fc99e Initial load
duke
parents:
diff changeset
2740 IdealLoopTree *l = innermost;
a61af66fc99e Initial load
duke
parents:
diff changeset
2741 while( p && l->_head == n ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2742 l->_next = p->_child; // Put self on parents 'next child'
a61af66fc99e Initial load
duke
parents:
diff changeset
2743 p->_child = l; // Make self as first child of parent
a61af66fc99e Initial load
duke
parents:
diff changeset
2744 l = p; // Now walk up the parent chain
a61af66fc99e Initial load
duke
parents:
diff changeset
2745 p = l->_parent;
a61af66fc99e Initial load
duke
parents:
diff changeset
2746 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2747 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
2748 // Note that it is possible for a LoopNode to reach here, if the
a61af66fc99e Initial load
duke
parents:
diff changeset
2749 // backedge has been made unreachable (hence the LoopNode no longer
a61af66fc99e Initial load
duke
parents:
diff changeset
2750 // denotes a Loop, and will eventually be removed).
a61af66fc99e Initial load
duke
parents:
diff changeset
2751
a61af66fc99e Initial load
duke
parents:
diff changeset
2752 // Record tightest enclosing loop for self. Mark as post-visited.
a61af66fc99e Initial load
duke
parents:
diff changeset
2753 set_loop(n, innermost);
a61af66fc99e Initial load
duke
parents:
diff changeset
2754 // Also record has_call flag early on
a61af66fc99e Initial load
duke
parents:
diff changeset
2755 if( innermost ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2756 if( n->is_Call() && !n->is_CallLeaf() && !n->is_macro() ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2757 // Do not count uncommon calls
a61af66fc99e Initial load
duke
parents:
diff changeset
2758 if( !n->is_CallStaticJava() || !n->as_CallStaticJava()->_name ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2759 Node *iff = n->in(0)->in(0);
a61af66fc99e Initial load
duke
parents:
diff changeset
2760 if( !iff->is_If() ||
a61af66fc99e Initial load
duke
parents:
diff changeset
2761 (n->in(0)->Opcode() == Op_IfFalse &&
a61af66fc99e Initial load
duke
parents:
diff changeset
2762 (1.0 - iff->as_If()->_prob) >= 0.01) ||
a61af66fc99e Initial load
duke
parents:
diff changeset
2763 (iff->as_If()->_prob >= 0.01) )
a61af66fc99e Initial load
duke
parents:
diff changeset
2764 innermost->_has_call = 1;
a61af66fc99e Initial load
duke
parents:
diff changeset
2765 }
39
76256d272075 6667612: (Escape Analysis) disable loop cloning if it has a scalar replaceable allocation
kvn
parents: 17
diff changeset
2766 } else if( n->is_Allocate() && n->as_Allocate()->_is_scalar_replaceable ) {
76256d272075 6667612: (Escape Analysis) disable loop cloning if it has a scalar replaceable allocation
kvn
parents: 17
diff changeset
2767 // Disable loop optimizations if the loop has a scalar replaceable
76256d272075 6667612: (Escape Analysis) disable loop cloning if it has a scalar replaceable allocation
kvn
parents: 17
diff changeset
2768 // allocation. This disabling may cause a potential performance lost
76256d272075 6667612: (Escape Analysis) disable loop cloning if it has a scalar replaceable allocation
kvn
parents: 17
diff changeset
2769 // if the allocation is not eliminated for some reason.
76256d272075 6667612: (Escape Analysis) disable loop cloning if it has a scalar replaceable allocation
kvn
parents: 17
diff changeset
2770 innermost->_allow_optimizations = false;
76256d272075 6667612: (Escape Analysis) disable loop cloning if it has a scalar replaceable allocation
kvn
parents: 17
diff changeset
2771 innermost->_has_call = 1; // = true
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2772 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2773 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2774 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2775
a61af66fc99e Initial load
duke
parents:
diff changeset
2776 // Flag as post-visited now
a61af66fc99e Initial load
duke
parents:
diff changeset
2777 set_postvisited(n);
a61af66fc99e Initial load
duke
parents:
diff changeset
2778 return pre_order;
a61af66fc99e Initial load
duke
parents:
diff changeset
2779 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2780
a61af66fc99e Initial load
duke
parents:
diff changeset
2781
a61af66fc99e Initial load
duke
parents:
diff changeset
2782 //------------------------------build_loop_early-------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
2783 // Put Data nodes into some loop nest, by setting the _nodes[]->loop mapping.
a61af66fc99e Initial load
duke
parents:
diff changeset
2784 // First pass computes the earliest controlling node possible. This is the
a61af66fc99e Initial load
duke
parents:
diff changeset
2785 // controlling input with the deepest dominating depth.
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2786 void PhaseIdealLoop::build_loop_early( VectorSet &visited, Node_List &worklist, Node_Stack &nstack ) {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2787 while (worklist.size() != 0) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2788 // Use local variables nstack_top_n & nstack_top_i to cache values
a61af66fc99e Initial load
duke
parents:
diff changeset
2789 // on nstack's top.
a61af66fc99e Initial load
duke
parents:
diff changeset
2790 Node *nstack_top_n = worklist.pop();
a61af66fc99e Initial load
duke
parents:
diff changeset
2791 uint nstack_top_i = 0;
a61af66fc99e Initial load
duke
parents:
diff changeset
2792 //while_nstack_nonempty:
a61af66fc99e Initial load
duke
parents:
diff changeset
2793 while (true) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2794 // Get parent node and next input's index from stack's top.
a61af66fc99e Initial load
duke
parents:
diff changeset
2795 Node *n = nstack_top_n;
a61af66fc99e Initial load
duke
parents:
diff changeset
2796 uint i = nstack_top_i;
a61af66fc99e Initial load
duke
parents:
diff changeset
2797 uint cnt = n->req(); // Count of inputs
a61af66fc99e Initial load
duke
parents:
diff changeset
2798 if (i == 0) { // Pre-process the node.
a61af66fc99e Initial load
duke
parents:
diff changeset
2799 if( has_node(n) && // Have either loop or control already?
a61af66fc99e Initial load
duke
parents:
diff changeset
2800 !has_ctrl(n) ) { // Have loop picked out already?
a61af66fc99e Initial load
duke
parents:
diff changeset
2801 // During "merge_many_backedges" we fold up several nested loops
a61af66fc99e Initial load
duke
parents:
diff changeset
2802 // into a single loop. This makes the members of the original
a61af66fc99e Initial load
duke
parents:
diff changeset
2803 // loop bodies pointing to dead loops; they need to move up
a61af66fc99e Initial load
duke
parents:
diff changeset
2804 // to the new UNION'd larger loop. I set the _head field of these
a61af66fc99e Initial load
duke
parents:
diff changeset
2805 // dead loops to NULL and the _parent field points to the owning
a61af66fc99e Initial load
duke
parents:
diff changeset
2806 // loop. Shades of UNION-FIND algorithm.
a61af66fc99e Initial load
duke
parents:
diff changeset
2807 IdealLoopTree *ilt;
a61af66fc99e Initial load
duke
parents:
diff changeset
2808 while( !(ilt = get_loop(n))->_head ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2809 // Normally I would use a set_loop here. But in this one special
a61af66fc99e Initial load
duke
parents:
diff changeset
2810 // case, it is legal (and expected) to change what loop a Node
a61af66fc99e Initial load
duke
parents:
diff changeset
2811 // belongs to.
a61af66fc99e Initial load
duke
parents:
diff changeset
2812 _nodes.map(n->_idx, (Node*)(ilt->_parent) );
a61af66fc99e Initial load
duke
parents:
diff changeset
2813 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2814 // Remove safepoints ONLY if I've already seen I don't need one.
a61af66fc99e Initial load
duke
parents:
diff changeset
2815 // (the old code here would yank a 2nd safepoint after seeing a
a61af66fc99e Initial load
duke
parents:
diff changeset
2816 // first one, even though the 1st did not dominate in the loop body
a61af66fc99e Initial load
duke
parents:
diff changeset
2817 // and thus could be avoided indefinitely)
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2818 if( !_verify_only && !_verify_me && ilt->_has_sfpt && n->Opcode() == Op_SafePoint &&
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2819 is_deleteable_safept(n)) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2820 Node *in = n->in(TypeFunc::Control);
a61af66fc99e Initial load
duke
parents:
diff changeset
2821 lazy_replace(n,in); // Pull safepoint now
a61af66fc99e Initial load
duke
parents:
diff changeset
2822 // Carry on with the recursion "as if" we are walking
a61af66fc99e Initial load
duke
parents:
diff changeset
2823 // only the control input
a61af66fc99e Initial load
duke
parents:
diff changeset
2824 if( !visited.test_set( in->_idx ) ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2825 worklist.push(in); // Visit this guy later, using worklist
a61af66fc99e Initial load
duke
parents:
diff changeset
2826 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2827 // Get next node from nstack:
a61af66fc99e Initial load
duke
parents:
diff changeset
2828 // - skip n's inputs processing by setting i > cnt;
a61af66fc99e Initial load
duke
parents:
diff changeset
2829 // - we also will not call set_early_ctrl(n) since
a61af66fc99e Initial load
duke
parents:
diff changeset
2830 // has_node(n) == true (see the condition above).
a61af66fc99e Initial load
duke
parents:
diff changeset
2831 i = cnt + 1;
a61af66fc99e Initial load
duke
parents:
diff changeset
2832 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2833 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2834 } // if (i == 0)
a61af66fc99e Initial load
duke
parents:
diff changeset
2835
a61af66fc99e Initial load
duke
parents:
diff changeset
2836 // Visit all inputs
a61af66fc99e Initial load
duke
parents:
diff changeset
2837 bool done = true; // Assume all n's inputs will be processed
a61af66fc99e Initial load
duke
parents:
diff changeset
2838 while (i < cnt) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2839 Node *in = n->in(i);
a61af66fc99e Initial load
duke
parents:
diff changeset
2840 ++i;
a61af66fc99e Initial load
duke
parents:
diff changeset
2841 if (in == NULL) continue;
a61af66fc99e Initial load
duke
parents:
diff changeset
2842 if (in->pinned() && !in->is_CFG())
a61af66fc99e Initial load
duke
parents:
diff changeset
2843 set_ctrl(in, in->in(0));
a61af66fc99e Initial load
duke
parents:
diff changeset
2844 int is_visited = visited.test_set( in->_idx );
a61af66fc99e Initial load
duke
parents:
diff changeset
2845 if (!has_node(in)) { // No controlling input yet?
a61af66fc99e Initial load
duke
parents:
diff changeset
2846 assert( !in->is_CFG(), "CFG Node with no controlling input?" );
a61af66fc99e Initial load
duke
parents:
diff changeset
2847 assert( !is_visited, "visit only once" );
a61af66fc99e Initial load
duke
parents:
diff changeset
2848 nstack.push(n, i); // Save parent node and next input's index.
a61af66fc99e Initial load
duke
parents:
diff changeset
2849 nstack_top_n = in; // Process current input now.
a61af66fc99e Initial load
duke
parents:
diff changeset
2850 nstack_top_i = 0;
a61af66fc99e Initial load
duke
parents:
diff changeset
2851 done = false; // Not all n's inputs processed.
a61af66fc99e Initial load
duke
parents:
diff changeset
2852 break; // continue while_nstack_nonempty;
a61af66fc99e Initial load
duke
parents:
diff changeset
2853 } else if (!is_visited) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2854 // This guy has a location picked out for him, but has not yet
a61af66fc99e Initial load
duke
parents:
diff changeset
2855 // been visited. Happens to all CFG nodes, for instance.
a61af66fc99e Initial load
duke
parents:
diff changeset
2856 // Visit him using the worklist instead of recursion, to break
a61af66fc99e Initial load
duke
parents:
diff changeset
2857 // cycles. Since he has a location already we do not need to
a61af66fc99e Initial load
duke
parents:
diff changeset
2858 // find his location before proceeding with the current Node.
a61af66fc99e Initial load
duke
parents:
diff changeset
2859 worklist.push(in); // Visit this guy later, using worklist
a61af66fc99e Initial load
duke
parents:
diff changeset
2860 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2861 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2862 if (done) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2863 // All of n's inputs have been processed, complete post-processing.
a61af66fc99e Initial load
duke
parents:
diff changeset
2864
605
98cb887364d3 6810672: Comment typos
twisti
parents: 558
diff changeset
2865 // Compute earliest point this Node can go.
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2866 // CFG, Phi, pinned nodes already know their controlling input.
a61af66fc99e Initial load
duke
parents:
diff changeset
2867 if (!has_node(n)) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2868 // Record earliest legal location
a61af66fc99e Initial load
duke
parents:
diff changeset
2869 set_early_ctrl( n );
a61af66fc99e Initial load
duke
parents:
diff changeset
2870 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2871 if (nstack.is_empty()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2872 // Finished all nodes on stack.
a61af66fc99e Initial load
duke
parents:
diff changeset
2873 // Process next node on the worklist.
a61af66fc99e Initial load
duke
parents:
diff changeset
2874 break;
a61af66fc99e Initial load
duke
parents:
diff changeset
2875 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2876 // Get saved parent node and next input's index.
a61af66fc99e Initial load
duke
parents:
diff changeset
2877 nstack_top_n = nstack.node();
a61af66fc99e Initial load
duke
parents:
diff changeset
2878 nstack_top_i = nstack.index();
a61af66fc99e Initial load
duke
parents:
diff changeset
2879 nstack.pop();
a61af66fc99e Initial load
duke
parents:
diff changeset
2880 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2881 } // while (true)
a61af66fc99e Initial load
duke
parents:
diff changeset
2882 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2883 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2884
a61af66fc99e Initial load
duke
parents:
diff changeset
2885 //------------------------------dom_lca_internal--------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
2886 // Pair-wise LCA
a61af66fc99e Initial load
duke
parents:
diff changeset
2887 Node *PhaseIdealLoop::dom_lca_internal( Node *n1, Node *n2 ) const {
a61af66fc99e Initial load
duke
parents:
diff changeset
2888 if( !n1 ) return n2; // Handle NULL original LCA
a61af66fc99e Initial load
duke
parents:
diff changeset
2889 assert( n1->is_CFG(), "" );
a61af66fc99e Initial load
duke
parents:
diff changeset
2890 assert( n2->is_CFG(), "" );
a61af66fc99e Initial load
duke
parents:
diff changeset
2891 // find LCA of all uses
a61af66fc99e Initial load
duke
parents:
diff changeset
2892 uint d1 = dom_depth(n1);
a61af66fc99e Initial load
duke
parents:
diff changeset
2893 uint d2 = dom_depth(n2);
a61af66fc99e Initial load
duke
parents:
diff changeset
2894 while (n1 != n2) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2895 if (d1 > d2) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2896 n1 = idom(n1);
a61af66fc99e Initial load
duke
parents:
diff changeset
2897 d1 = dom_depth(n1);
a61af66fc99e Initial load
duke
parents:
diff changeset
2898 } else if (d1 < d2) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2899 n2 = idom(n2);
a61af66fc99e Initial load
duke
parents:
diff changeset
2900 d2 = dom_depth(n2);
a61af66fc99e Initial load
duke
parents:
diff changeset
2901 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
2902 // Here d1 == d2. Due to edits of the dominator-tree, sections
a61af66fc99e Initial load
duke
parents:
diff changeset
2903 // of the tree might have the same depth. These sections have
a61af66fc99e Initial load
duke
parents:
diff changeset
2904 // to be searched more carefully.
a61af66fc99e Initial load
duke
parents:
diff changeset
2905
a61af66fc99e Initial load
duke
parents:
diff changeset
2906 // Scan up all the n1's with equal depth, looking for n2.
a61af66fc99e Initial load
duke
parents:
diff changeset
2907 Node *t1 = idom(n1);
a61af66fc99e Initial load
duke
parents:
diff changeset
2908 while (dom_depth(t1) == d1) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2909 if (t1 == n2) return n2;
a61af66fc99e Initial load
duke
parents:
diff changeset
2910 t1 = idom(t1);
a61af66fc99e Initial load
duke
parents:
diff changeset
2911 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2912 // Scan up all the n2's with equal depth, looking for n1.
a61af66fc99e Initial load
duke
parents:
diff changeset
2913 Node *t2 = idom(n2);
a61af66fc99e Initial load
duke
parents:
diff changeset
2914 while (dom_depth(t2) == d2) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2915 if (t2 == n1) return n1;
a61af66fc99e Initial load
duke
parents:
diff changeset
2916 t2 = idom(t2);
a61af66fc99e Initial load
duke
parents:
diff changeset
2917 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2918 // Move up to a new dominator-depth value as well as up the dom-tree.
a61af66fc99e Initial load
duke
parents:
diff changeset
2919 n1 = t1;
a61af66fc99e Initial load
duke
parents:
diff changeset
2920 n2 = t2;
a61af66fc99e Initial load
duke
parents:
diff changeset
2921 d1 = dom_depth(n1);
a61af66fc99e Initial load
duke
parents:
diff changeset
2922 d2 = dom_depth(n2);
a61af66fc99e Initial load
duke
parents:
diff changeset
2923 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2924 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2925 return n1;
a61af66fc99e Initial load
duke
parents:
diff changeset
2926 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2927
a61af66fc99e Initial load
duke
parents:
diff changeset
2928 //------------------------------compute_idom-----------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
2929 // Locally compute IDOM using dom_lca call. Correct only if the incoming
a61af66fc99e Initial load
duke
parents:
diff changeset
2930 // IDOMs are correct.
a61af66fc99e Initial load
duke
parents:
diff changeset
2931 Node *PhaseIdealLoop::compute_idom( Node *region ) const {
a61af66fc99e Initial load
duke
parents:
diff changeset
2932 assert( region->is_Region(), "" );
a61af66fc99e Initial load
duke
parents:
diff changeset
2933 Node *LCA = NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
2934 for( uint i = 1; i < region->req(); i++ ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2935 if( region->in(i) != C->top() )
a61af66fc99e Initial load
duke
parents:
diff changeset
2936 LCA = dom_lca( LCA, region->in(i) );
a61af66fc99e Initial load
duke
parents:
diff changeset
2937 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2938 return LCA;
a61af66fc99e Initial load
duke
parents:
diff changeset
2939 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2940
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2941 bool PhaseIdealLoop::verify_dominance(Node* n, Node* use, Node* LCA, Node* early) {
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2942 bool had_error = false;
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2943 #ifdef ASSERT
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2944 if (early != C->root()) {
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2945 // Make sure that there's a dominance path from use to LCA
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2946 Node* d = use;
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2947 while (d != LCA) {
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2948 d = idom(d);
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2949 if (d == C->root()) {
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2950 tty->print_cr("*** Use %d isn't dominated by def %s", use->_idx, n->_idx);
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2951 n->dump();
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2952 use->dump();
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2953 had_error = true;
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2954 break;
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2955 }
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2956 }
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2957 }
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2958 #endif
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2959 return had_error;
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2960 }
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2961
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2962
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2963 Node* PhaseIdealLoop::compute_lca_of_uses(Node* n, Node* early, bool verify) {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2964 // Compute LCA over list of uses
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2965 bool had_error = false;
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2966 Node *LCA = NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
2967 for (DUIterator_Fast imax, i = n->fast_outs(imax); i < imax && LCA != early; i++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
2968 Node* c = n->fast_out(i);
a61af66fc99e Initial load
duke
parents:
diff changeset
2969 if (_nodes[c->_idx] == NULL)
a61af66fc99e Initial load
duke
parents:
diff changeset
2970 continue; // Skip the occasional dead node
a61af66fc99e Initial load
duke
parents:
diff changeset
2971 if( c->is_Phi() ) { // For Phis, we must land above on the path
a61af66fc99e Initial load
duke
parents:
diff changeset
2972 for( uint j=1; j<c->req(); j++ ) {// For all inputs
a61af66fc99e Initial load
duke
parents:
diff changeset
2973 if( c->in(j) == n ) { // Found matching input?
a61af66fc99e Initial load
duke
parents:
diff changeset
2974 Node *use = c->in(0)->in(j);
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2975 if (_verify_only && use->is_top()) continue;
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2976 LCA = dom_lca_for_get_late_ctrl( LCA, use, n );
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2977 if (verify) had_error = verify_dominance(n, use, LCA, early) || had_error;
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2978 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2979 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2980 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
2981 // For CFG data-users, use is in the block just prior
a61af66fc99e Initial load
duke
parents:
diff changeset
2982 Node *use = has_ctrl(c) ? get_ctrl(c) : c->in(0);
a61af66fc99e Initial load
duke
parents:
diff changeset
2983 LCA = dom_lca_for_get_late_ctrl( LCA, use, n );
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2984 if (verify) had_error = verify_dominance(n, use, LCA, early) || had_error;
0
a61af66fc99e Initial load
duke
parents:
diff changeset
2985 }
a61af66fc99e Initial load
duke
parents:
diff changeset
2986 }
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2987 assert(!had_error, "bad dominance");
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2988 return LCA;
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2989 }
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2990
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2991 //------------------------------get_late_ctrl----------------------------------
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2992 // Compute latest legal control.
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2993 Node *PhaseIdealLoop::get_late_ctrl( Node *n, Node *early ) {
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2994 assert(early != NULL, "early control should not be NULL");
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2995
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2996 Node* LCA = compute_lca_of_uses(n, early);
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2997 #ifdef ASSERT
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2998 if (LCA == C->root() && LCA != early) {
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
2999 // def doesn't dominate uses so print some useful debugging output
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
3000 compute_lca_of_uses(n, early, true);
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
3001 }
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
3002 #endif
0
a61af66fc99e Initial load
duke
parents:
diff changeset
3003
a61af66fc99e Initial load
duke
parents:
diff changeset
3004 // if this is a load, check for anti-dependent stores
a61af66fc99e Initial load
duke
parents:
diff changeset
3005 // We use a conservative algorithm to identify potential interfering
a61af66fc99e Initial load
duke
parents:
diff changeset
3006 // instructions and for rescheduling the load. The users of the memory
a61af66fc99e Initial load
duke
parents:
diff changeset
3007 // input of this load are examined. Any use which is not a load and is
a61af66fc99e Initial load
duke
parents:
diff changeset
3008 // dominated by early is considered a potentially interfering store.
a61af66fc99e Initial load
duke
parents:
diff changeset
3009 // This can produce false positives.
a61af66fc99e Initial load
duke
parents:
diff changeset
3010 if (n->is_Load() && LCA != early) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3011 Node_List worklist;
a61af66fc99e Initial load
duke
parents:
diff changeset
3012
a61af66fc99e Initial load
duke
parents:
diff changeset
3013 Node *mem = n->in(MemNode::Memory);
a61af66fc99e Initial load
duke
parents:
diff changeset
3014 for (DUIterator_Fast imax, i = mem->fast_outs(imax); i < imax; i++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3015 Node* s = mem->fast_out(i);
a61af66fc99e Initial load
duke
parents:
diff changeset
3016 worklist.push(s);
a61af66fc99e Initial load
duke
parents:
diff changeset
3017 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3018 while(worklist.size() != 0 && LCA != early) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3019 Node* s = worklist.pop();
a61af66fc99e Initial load
duke
parents:
diff changeset
3020 if (s->is_Load()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3021 continue;
a61af66fc99e Initial load
duke
parents:
diff changeset
3022 } else if (s->is_MergeMem()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3023 for (DUIterator_Fast imax, i = s->fast_outs(imax); i < imax; i++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3024 Node* s1 = s->fast_out(i);
a61af66fc99e Initial load
duke
parents:
diff changeset
3025 worklist.push(s1);
a61af66fc99e Initial load
duke
parents:
diff changeset
3026 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3027 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
3028 Node *sctrl = has_ctrl(s) ? get_ctrl(s) : s->in(0);
a61af66fc99e Initial load
duke
parents:
diff changeset
3029 assert(sctrl != NULL || s->outcnt() == 0, "must have control");
a61af66fc99e Initial load
duke
parents:
diff changeset
3030 if (sctrl != NULL && !sctrl->is_top() && is_dominator(early, sctrl)) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3031 LCA = dom_lca_for_get_late_ctrl(LCA, sctrl, n);
a61af66fc99e Initial load
duke
parents:
diff changeset
3032 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3033 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3034 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3035 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3036
a61af66fc99e Initial load
duke
parents:
diff changeset
3037 assert(LCA == find_non_split_ctrl(LCA), "unexpected late control");
a61af66fc99e Initial load
duke
parents:
diff changeset
3038 return LCA;
a61af66fc99e Initial load
duke
parents:
diff changeset
3039 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3040
a61af66fc99e Initial load
duke
parents:
diff changeset
3041 // true if CFG node d dominates CFG node n
a61af66fc99e Initial load
duke
parents:
diff changeset
3042 bool PhaseIdealLoop::is_dominator(Node *d, Node *n) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3043 if (d == n)
a61af66fc99e Initial load
duke
parents:
diff changeset
3044 return true;
a61af66fc99e Initial load
duke
parents:
diff changeset
3045 assert(d->is_CFG() && n->is_CFG(), "must have CFG nodes");
a61af66fc99e Initial load
duke
parents:
diff changeset
3046 uint dd = dom_depth(d);
a61af66fc99e Initial load
duke
parents:
diff changeset
3047 while (dom_depth(n) >= dd) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3048 if (n == d)
a61af66fc99e Initial load
duke
parents:
diff changeset
3049 return true;
a61af66fc99e Initial load
duke
parents:
diff changeset
3050 n = idom(n);
a61af66fc99e Initial load
duke
parents:
diff changeset
3051 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3052 return false;
a61af66fc99e Initial load
duke
parents:
diff changeset
3053 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3054
a61af66fc99e Initial load
duke
parents:
diff changeset
3055 //------------------------------dom_lca_for_get_late_ctrl_internal-------------
a61af66fc99e Initial load
duke
parents:
diff changeset
3056 // Pair-wise LCA with tags.
a61af66fc99e Initial load
duke
parents:
diff changeset
3057 // Tag each index with the node 'tag' currently being processed
a61af66fc99e Initial load
duke
parents:
diff changeset
3058 // before advancing up the dominator chain using idom().
a61af66fc99e Initial load
duke
parents:
diff changeset
3059 // Later calls that find a match to 'tag' know that this path has already
a61af66fc99e Initial load
duke
parents:
diff changeset
3060 // been considered in the current LCA (which is input 'n1' by convention).
a61af66fc99e Initial load
duke
parents:
diff changeset
3061 // Since get_late_ctrl() is only called once for each node, the tag array
a61af66fc99e Initial load
duke
parents:
diff changeset
3062 // does not need to be cleared between calls to get_late_ctrl().
a61af66fc99e Initial load
duke
parents:
diff changeset
3063 // Algorithm trades a larger constant factor for better asymptotic behavior
a61af66fc99e Initial load
duke
parents:
diff changeset
3064 //
a61af66fc99e Initial load
duke
parents:
diff changeset
3065 Node *PhaseIdealLoop::dom_lca_for_get_late_ctrl_internal( Node *n1, Node *n2, Node *tag ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3066 uint d1 = dom_depth(n1);
a61af66fc99e Initial load
duke
parents:
diff changeset
3067 uint d2 = dom_depth(n2);
a61af66fc99e Initial load
duke
parents:
diff changeset
3068
a61af66fc99e Initial load
duke
parents:
diff changeset
3069 do {
a61af66fc99e Initial load
duke
parents:
diff changeset
3070 if (d1 > d2) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3071 // current lca is deeper than n2
a61af66fc99e Initial load
duke
parents:
diff changeset
3072 _dom_lca_tags.map(n1->_idx, tag);
a61af66fc99e Initial load
duke
parents:
diff changeset
3073 n1 = idom(n1);
a61af66fc99e Initial load
duke
parents:
diff changeset
3074 d1 = dom_depth(n1);
a61af66fc99e Initial load
duke
parents:
diff changeset
3075 } else if (d1 < d2) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3076 // n2 is deeper than current lca
a61af66fc99e Initial load
duke
parents:
diff changeset
3077 Node *memo = _dom_lca_tags[n2->_idx];
a61af66fc99e Initial load
duke
parents:
diff changeset
3078 if( memo == tag ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3079 return n1; // Return the current LCA
a61af66fc99e Initial load
duke
parents:
diff changeset
3080 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3081 _dom_lca_tags.map(n2->_idx, tag);
a61af66fc99e Initial load
duke
parents:
diff changeset
3082 n2 = idom(n2);
a61af66fc99e Initial load
duke
parents:
diff changeset
3083 d2 = dom_depth(n2);
a61af66fc99e Initial load
duke
parents:
diff changeset
3084 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
3085 // Here d1 == d2. Due to edits of the dominator-tree, sections
a61af66fc99e Initial load
duke
parents:
diff changeset
3086 // of the tree might have the same depth. These sections have
a61af66fc99e Initial load
duke
parents:
diff changeset
3087 // to be searched more carefully.
a61af66fc99e Initial load
duke
parents:
diff changeset
3088
a61af66fc99e Initial load
duke
parents:
diff changeset
3089 // Scan up all the n1's with equal depth, looking for n2.
a61af66fc99e Initial load
duke
parents:
diff changeset
3090 _dom_lca_tags.map(n1->_idx, tag);
a61af66fc99e Initial load
duke
parents:
diff changeset
3091 Node *t1 = idom(n1);
a61af66fc99e Initial load
duke
parents:
diff changeset
3092 while (dom_depth(t1) == d1) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3093 if (t1 == n2) return n2;
a61af66fc99e Initial load
duke
parents:
diff changeset
3094 _dom_lca_tags.map(t1->_idx, tag);
a61af66fc99e Initial load
duke
parents:
diff changeset
3095 t1 = idom(t1);
a61af66fc99e Initial load
duke
parents:
diff changeset
3096 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3097 // Scan up all the n2's with equal depth, looking for n1.
a61af66fc99e Initial load
duke
parents:
diff changeset
3098 _dom_lca_tags.map(n2->_idx, tag);
a61af66fc99e Initial load
duke
parents:
diff changeset
3099 Node *t2 = idom(n2);
a61af66fc99e Initial load
duke
parents:
diff changeset
3100 while (dom_depth(t2) == d2) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3101 if (t2 == n1) return n1;
a61af66fc99e Initial load
duke
parents:
diff changeset
3102 _dom_lca_tags.map(t2->_idx, tag);
a61af66fc99e Initial load
duke
parents:
diff changeset
3103 t2 = idom(t2);
a61af66fc99e Initial load
duke
parents:
diff changeset
3104 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3105 // Move up to a new dominator-depth value as well as up the dom-tree.
a61af66fc99e Initial load
duke
parents:
diff changeset
3106 n1 = t1;
a61af66fc99e Initial load
duke
parents:
diff changeset
3107 n2 = t2;
a61af66fc99e Initial load
duke
parents:
diff changeset
3108 d1 = dom_depth(n1);
a61af66fc99e Initial load
duke
parents:
diff changeset
3109 d2 = dom_depth(n2);
a61af66fc99e Initial load
duke
parents:
diff changeset
3110 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3111 } while (n1 != n2);
a61af66fc99e Initial load
duke
parents:
diff changeset
3112 return n1;
a61af66fc99e Initial load
duke
parents:
diff changeset
3113 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3114
a61af66fc99e Initial load
duke
parents:
diff changeset
3115 //------------------------------init_dom_lca_tags------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
3116 // Tag could be a node's integer index, 32bits instead of 64bits in some cases
a61af66fc99e Initial load
duke
parents:
diff changeset
3117 // Intended use does not involve any growth for the array, so it could
a61af66fc99e Initial load
duke
parents:
diff changeset
3118 // be of fixed size.
a61af66fc99e Initial load
duke
parents:
diff changeset
3119 void PhaseIdealLoop::init_dom_lca_tags() {
a61af66fc99e Initial load
duke
parents:
diff changeset
3120 uint limit = C->unique() + 1;
a61af66fc99e Initial load
duke
parents:
diff changeset
3121 _dom_lca_tags.map( limit, NULL );
a61af66fc99e Initial load
duke
parents:
diff changeset
3122 #ifdef ASSERT
a61af66fc99e Initial load
duke
parents:
diff changeset
3123 for( uint i = 0; i < limit; ++i ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3124 assert(_dom_lca_tags[i] == NULL, "Must be distinct from each node pointer");
a61af66fc99e Initial load
duke
parents:
diff changeset
3125 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3126 #endif // ASSERT
a61af66fc99e Initial load
duke
parents:
diff changeset
3127 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3128
a61af66fc99e Initial load
duke
parents:
diff changeset
3129 //------------------------------clear_dom_lca_tags------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
3130 // Tag could be a node's integer index, 32bits instead of 64bits in some cases
a61af66fc99e Initial load
duke
parents:
diff changeset
3131 // Intended use does not involve any growth for the array, so it could
a61af66fc99e Initial load
duke
parents:
diff changeset
3132 // be of fixed size.
a61af66fc99e Initial load
duke
parents:
diff changeset
3133 void PhaseIdealLoop::clear_dom_lca_tags() {
a61af66fc99e Initial load
duke
parents:
diff changeset
3134 uint limit = C->unique() + 1;
a61af66fc99e Initial load
duke
parents:
diff changeset
3135 _dom_lca_tags.map( limit, NULL );
a61af66fc99e Initial load
duke
parents:
diff changeset
3136 _dom_lca_tags.clear();
a61af66fc99e Initial load
duke
parents:
diff changeset
3137 #ifdef ASSERT
a61af66fc99e Initial load
duke
parents:
diff changeset
3138 for( uint i = 0; i < limit; ++i ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3139 assert(_dom_lca_tags[i] == NULL, "Must be distinct from each node pointer");
a61af66fc99e Initial load
duke
parents:
diff changeset
3140 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3141 #endif // ASSERT
a61af66fc99e Initial load
duke
parents:
diff changeset
3142 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3143
a61af66fc99e Initial load
duke
parents:
diff changeset
3144 //------------------------------build_loop_late--------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
3145 // Put Data nodes into some loop nest, by setting the _nodes[]->loop mapping.
a61af66fc99e Initial load
duke
parents:
diff changeset
3146 // Second pass finds latest legal placement, and ideal loop placement.
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
3147 void PhaseIdealLoop::build_loop_late( VectorSet &visited, Node_List &worklist, Node_Stack &nstack ) {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
3148 while (worklist.size() != 0) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3149 Node *n = worklist.pop();
a61af66fc99e Initial load
duke
parents:
diff changeset
3150 // Only visit once
a61af66fc99e Initial load
duke
parents:
diff changeset
3151 if (visited.test_set(n->_idx)) continue;
a61af66fc99e Initial load
duke
parents:
diff changeset
3152 uint cnt = n->outcnt();
a61af66fc99e Initial load
duke
parents:
diff changeset
3153 uint i = 0;
a61af66fc99e Initial load
duke
parents:
diff changeset
3154 while (true) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3155 assert( _nodes[n->_idx], "no dead nodes" );
a61af66fc99e Initial load
duke
parents:
diff changeset
3156 // Visit all children
a61af66fc99e Initial load
duke
parents:
diff changeset
3157 if (i < cnt) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3158 Node* use = n->raw_out(i);
a61af66fc99e Initial load
duke
parents:
diff changeset
3159 ++i;
a61af66fc99e Initial load
duke
parents:
diff changeset
3160 // Check for dead uses. Aggressively prune such junk. It might be
a61af66fc99e Initial load
duke
parents:
diff changeset
3161 // dead in the global sense, but still have local uses so I cannot
a61af66fc99e Initial load
duke
parents:
diff changeset
3162 // easily call 'remove_dead_node'.
a61af66fc99e Initial load
duke
parents:
diff changeset
3163 if( _nodes[use->_idx] != NULL || use->is_top() ) { // Not dead?
a61af66fc99e Initial load
duke
parents:
diff changeset
3164 // Due to cycles, we might not hit the same fixed point in the verify
a61af66fc99e Initial load
duke
parents:
diff changeset
3165 // pass as we do in the regular pass. Instead, visit such phis as
a61af66fc99e Initial load
duke
parents:
diff changeset
3166 // simple uses of the loop head.
a61af66fc99e Initial load
duke
parents:
diff changeset
3167 if( use->in(0) && (use->is_CFG() || use->is_Phi()) ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3168 if( !visited.test(use->_idx) )
a61af66fc99e Initial load
duke
parents:
diff changeset
3169 worklist.push(use);
a61af66fc99e Initial load
duke
parents:
diff changeset
3170 } else if( !visited.test_set(use->_idx) ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3171 nstack.push(n, i); // Save parent and next use's index.
a61af66fc99e Initial load
duke
parents:
diff changeset
3172 n = use; // Process all children of current use.
a61af66fc99e Initial load
duke
parents:
diff changeset
3173 cnt = use->outcnt();
a61af66fc99e Initial load
duke
parents:
diff changeset
3174 i = 0;
a61af66fc99e Initial load
duke
parents:
diff changeset
3175 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3176 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
3177 // Do not visit around the backedge of loops via data edges.
a61af66fc99e Initial load
duke
parents:
diff changeset
3178 // push dead code onto a worklist
a61af66fc99e Initial load
duke
parents:
diff changeset
3179 _deadlist.push(use);
a61af66fc99e Initial load
duke
parents:
diff changeset
3180 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3181 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
3182 // All of n's children have been processed, complete post-processing.
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
3183 build_loop_late_post(n);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
3184 if (nstack.is_empty()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3185 // Finished all nodes on stack.
a61af66fc99e Initial load
duke
parents:
diff changeset
3186 // Process next node on the worklist.
a61af66fc99e Initial load
duke
parents:
diff changeset
3187 break;
a61af66fc99e Initial load
duke
parents:
diff changeset
3188 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3189 // Get saved parent node and next use's index. Visit the rest of uses.
a61af66fc99e Initial load
duke
parents:
diff changeset
3190 n = nstack.node();
a61af66fc99e Initial load
duke
parents:
diff changeset
3191 cnt = n->outcnt();
a61af66fc99e Initial load
duke
parents:
diff changeset
3192 i = nstack.index();
a61af66fc99e Initial load
duke
parents:
diff changeset
3193 nstack.pop();
a61af66fc99e Initial load
duke
parents:
diff changeset
3194 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3195 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3196 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3197 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3198
a61af66fc99e Initial load
duke
parents:
diff changeset
3199 //------------------------------build_loop_late_post---------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
3200 // Put Data nodes into some loop nest, by setting the _nodes[]->loop mapping.
a61af66fc99e Initial load
duke
parents:
diff changeset
3201 // Second pass finds latest legal placement, and ideal loop placement.
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
3202 void PhaseIdealLoop::build_loop_late_post( Node *n ) {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
3203
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
3204 if (n->req() == 2 && n->Opcode() == Op_ConvI2L && !C->major_progress() && !_verify_only) {
0
a61af66fc99e Initial load
duke
parents:
diff changeset
3205 _igvn._worklist.push(n); // Maybe we'll normalize it, if no more loops.
a61af66fc99e Initial load
duke
parents:
diff changeset
3206 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3207
a61af66fc99e Initial load
duke
parents:
diff changeset
3208 // CFG and pinned nodes already handled
a61af66fc99e Initial load
duke
parents:
diff changeset
3209 if( n->in(0) ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3210 if( n->in(0)->is_top() ) return; // Dead?
a61af66fc99e Initial load
duke
parents:
diff changeset
3211
a61af66fc99e Initial load
duke
parents:
diff changeset
3212 // We'd like +VerifyLoopOptimizations to not believe that Mod's/Loads
a61af66fc99e Initial load
duke
parents:
diff changeset
3213 // _must_ be pinned (they have to observe their control edge of course).
a61af66fc99e Initial load
duke
parents:
diff changeset
3214 // Unlike Stores (which modify an unallocable resource, the memory
a61af66fc99e Initial load
duke
parents:
diff changeset
3215 // state), Mods/Loads can float around. So free them up.
a61af66fc99e Initial load
duke
parents:
diff changeset
3216 bool pinned = true;
a61af66fc99e Initial load
duke
parents:
diff changeset
3217 switch( n->Opcode() ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3218 case Op_DivI:
a61af66fc99e Initial load
duke
parents:
diff changeset
3219 case Op_DivF:
a61af66fc99e Initial load
duke
parents:
diff changeset
3220 case Op_DivD:
a61af66fc99e Initial load
duke
parents:
diff changeset
3221 case Op_ModI:
a61af66fc99e Initial load
duke
parents:
diff changeset
3222 case Op_ModF:
a61af66fc99e Initial load
duke
parents:
diff changeset
3223 case Op_ModD:
a61af66fc99e Initial load
duke
parents:
diff changeset
3224 case Op_LoadB: // Same with Loads; they can sink
558
3b5ac9e7e6ea 6796746: rename LoadC (char) opcode class to LoadUS (unsigned short)
twisti
parents: 367
diff changeset
3225 case Op_LoadUS: // during loop optimizations.
0
a61af66fc99e Initial load
duke
parents:
diff changeset
3226 case Op_LoadD:
a61af66fc99e Initial load
duke
parents:
diff changeset
3227 case Op_LoadF:
a61af66fc99e Initial load
duke
parents:
diff changeset
3228 case Op_LoadI:
a61af66fc99e Initial load
duke
parents:
diff changeset
3229 case Op_LoadKlass:
293
c3e045194476 6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents: 235
diff changeset
3230 case Op_LoadNKlass:
0
a61af66fc99e Initial load
duke
parents:
diff changeset
3231 case Op_LoadL:
a61af66fc99e Initial load
duke
parents:
diff changeset
3232 case Op_LoadS:
a61af66fc99e Initial load
duke
parents:
diff changeset
3233 case Op_LoadP:
293
c3e045194476 6731641: assert(m->adr_type() == mach->adr_type(),"matcher should not change adr type")
kvn
parents: 235
diff changeset
3234 case Op_LoadN:
0
a61af66fc99e Initial load
duke
parents:
diff changeset
3235 case Op_LoadRange:
a61af66fc99e Initial load
duke
parents:
diff changeset
3236 case Op_LoadD_unaligned:
a61af66fc99e Initial load
duke
parents:
diff changeset
3237 case Op_LoadL_unaligned:
a61af66fc99e Initial load
duke
parents:
diff changeset
3238 case Op_StrComp: // Does a bunch of load-like effects
681
fbde8ec322d0 6761600: Use sse 4.2 in intrinsics
cfang
parents: 628
diff changeset
3239 case Op_StrEquals:
fbde8ec322d0 6761600: Use sse 4.2 in intrinsics
cfang
parents: 628
diff changeset
3240 case Op_StrIndexOf:
169
9148c65abefc 6695049: (coll) Create an x86 intrinsic for Arrays.equals
rasbold
parents: 39
diff changeset
3241 case Op_AryEq:
0
a61af66fc99e Initial load
duke
parents:
diff changeset
3242 pinned = false;
a61af66fc99e Initial load
duke
parents:
diff changeset
3243 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3244 if( pinned ) {
605
98cb887364d3 6810672: Comment typos
twisti
parents: 558
diff changeset
3245 IdealLoopTree *chosen_loop = get_loop(n->is_CFG() ? n : get_ctrl(n));
98cb887364d3 6810672: Comment typos
twisti
parents: 558
diff changeset
3246 if( !chosen_loop->_child ) // Inner loop?
98cb887364d3 6810672: Comment typos
twisti
parents: 558
diff changeset
3247 chosen_loop->_body.push(n); // Collect inner loops
0
a61af66fc99e Initial load
duke
parents:
diff changeset
3248 return;
a61af66fc99e Initial load
duke
parents:
diff changeset
3249 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3250 } else { // No slot zero
a61af66fc99e Initial load
duke
parents:
diff changeset
3251 if( n->is_CFG() ) { // CFG with no slot 0 is dead
a61af66fc99e Initial load
duke
parents:
diff changeset
3252 _nodes.map(n->_idx,0); // No block setting, it's globally dead
a61af66fc99e Initial load
duke
parents:
diff changeset
3253 return;
a61af66fc99e Initial load
duke
parents:
diff changeset
3254 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3255 assert(!n->is_CFG() || n->outcnt() == 0, "");
a61af66fc99e Initial load
duke
parents:
diff changeset
3256 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3257
a61af66fc99e Initial load
duke
parents:
diff changeset
3258 // Do I have a "safe range" I can select over?
a61af66fc99e Initial load
duke
parents:
diff changeset
3259 Node *early = get_ctrl(n);// Early location already computed
a61af66fc99e Initial load
duke
parents:
diff changeset
3260
a61af66fc99e Initial load
duke
parents:
diff changeset
3261 // Compute latest point this Node can go
a61af66fc99e Initial load
duke
parents:
diff changeset
3262 Node *LCA = get_late_ctrl( n, early );
a61af66fc99e Initial load
duke
parents:
diff changeset
3263 // LCA is NULL due to uses being dead
a61af66fc99e Initial load
duke
parents:
diff changeset
3264 if( LCA == NULL ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3265 #ifdef ASSERT
a61af66fc99e Initial load
duke
parents:
diff changeset
3266 for (DUIterator i1 = n->outs(); n->has_out(i1); i1++) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3267 assert( _nodes[n->out(i1)->_idx] == NULL, "all uses must also be dead");
a61af66fc99e Initial load
duke
parents:
diff changeset
3268 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3269 #endif
a61af66fc99e Initial load
duke
parents:
diff changeset
3270 _nodes.map(n->_idx, 0); // This node is useless
a61af66fc99e Initial load
duke
parents:
diff changeset
3271 _deadlist.push(n);
a61af66fc99e Initial load
duke
parents:
diff changeset
3272 return;
a61af66fc99e Initial load
duke
parents:
diff changeset
3273 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3274 assert(LCA != NULL && !LCA->is_top(), "no dead nodes");
a61af66fc99e Initial load
duke
parents:
diff changeset
3275
a61af66fc99e Initial load
duke
parents:
diff changeset
3276 Node *legal = LCA; // Walk 'legal' up the IDOM chain
a61af66fc99e Initial load
duke
parents:
diff changeset
3277 Node *least = legal; // Best legal position so far
a61af66fc99e Initial load
duke
parents:
diff changeset
3278 while( early != legal ) { // While not at earliest legal
1172
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
3279 #ifdef ASSERT
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
3280 if (legal->is_Start() && !early->is_Root()) {
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
3281 // Bad graph. Print idom path and fail.
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
3282 tty->print_cr( "Bad graph detected in build_loop_late");
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
3283 tty->print("n: ");n->dump(); tty->cr();
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
3284 tty->print("early: ");early->dump(); tty->cr();
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
3285 int ct = 0;
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
3286 Node *dbg_legal = LCA;
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
3287 while(!dbg_legal->is_Start() && ct < 100) {
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
3288 tty->print("idom[%d] ",ct); dbg_legal->dump(); tty->cr();
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
3289 ct++;
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
3290 dbg_legal = idom(dbg_legal);
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
3291 }
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
3292 assert(false, "Bad graph detected in build_loop_late");
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
3293 }
b2b6a9bf6238 6894779: Loop Predication for Loop Optimizer in C2
cfang
parents: 1083
diff changeset
3294 #endif
0
a61af66fc99e Initial load
duke
parents:
diff changeset
3295 // Find least loop nesting depth
a61af66fc99e Initial load
duke
parents:
diff changeset
3296 legal = idom(legal); // Bump up the IDOM tree
a61af66fc99e Initial load
duke
parents:
diff changeset
3297 // Check for lower nesting depth
a61af66fc99e Initial load
duke
parents:
diff changeset
3298 if( get_loop(legal)->_nest < get_loop(least)->_nest )
a61af66fc99e Initial load
duke
parents:
diff changeset
3299 least = legal;
a61af66fc99e Initial load
duke
parents:
diff changeset
3300 }
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
3301 assert(early == legal || legal != C->root(), "bad dominance of inputs");
0
a61af66fc99e Initial load
duke
parents:
diff changeset
3302
a61af66fc99e Initial load
duke
parents:
diff changeset
3303 // Try not to place code on a loop entry projection
a61af66fc99e Initial load
duke
parents:
diff changeset
3304 // which can inhibit range check elimination.
a61af66fc99e Initial load
duke
parents:
diff changeset
3305 if (least != early) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3306 Node* ctrl_out = least->unique_ctrl_out();
a61af66fc99e Initial load
duke
parents:
diff changeset
3307 if (ctrl_out && ctrl_out->is_CountedLoop() &&
a61af66fc99e Initial load
duke
parents:
diff changeset
3308 least == ctrl_out->in(LoopNode::EntryControl)) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3309 Node* least_dom = idom(least);
a61af66fc99e Initial load
duke
parents:
diff changeset
3310 if (get_loop(least_dom)->is_member(get_loop(least))) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3311 least = least_dom;
a61af66fc99e Initial load
duke
parents:
diff changeset
3312 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3313 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3314 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3315
a61af66fc99e Initial load
duke
parents:
diff changeset
3316 #ifdef ASSERT
a61af66fc99e Initial load
duke
parents:
diff changeset
3317 // If verifying, verify that 'verify_me' has a legal location
a61af66fc99e Initial load
duke
parents:
diff changeset
3318 // and choose it as our location.
921
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
3319 if( _verify_me ) {
046932b72aa2 6862956: PhaseIdealLoop should have a CFG verification mode
never
parents: 681
diff changeset
3320 Node *v_ctrl = _verify_me->get_ctrl_no_update(n);
0
a61af66fc99e Initial load
duke
parents:
diff changeset
3321 Node *legal = LCA;
a61af66fc99e Initial load
duke
parents:
diff changeset
3322 while( early != legal ) { // While not at earliest legal
a61af66fc99e Initial load
duke
parents:
diff changeset
3323 if( legal == v_ctrl ) break; // Check for prior good location
a61af66fc99e Initial load
duke
parents:
diff changeset
3324 legal = idom(legal) ;// Bump up the IDOM tree
a61af66fc99e Initial load
duke
parents:
diff changeset
3325 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3326 // Check for prior good location
a61af66fc99e Initial load
duke
parents:
diff changeset
3327 if( legal == v_ctrl ) least = legal; // Keep prior if found
a61af66fc99e Initial load
duke
parents:
diff changeset
3328 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3329 #endif
a61af66fc99e Initial load
duke
parents:
diff changeset
3330
a61af66fc99e Initial load
duke
parents:
diff changeset
3331 // Assign discovered "here or above" point
a61af66fc99e Initial load
duke
parents:
diff changeset
3332 least = find_non_split_ctrl(least);
a61af66fc99e Initial load
duke
parents:
diff changeset
3333 set_ctrl(n, least);
a61af66fc99e Initial load
duke
parents:
diff changeset
3334
a61af66fc99e Initial load
duke
parents:
diff changeset
3335 // Collect inner loop bodies
605
98cb887364d3 6810672: Comment typos
twisti
parents: 558
diff changeset
3336 IdealLoopTree *chosen_loop = get_loop(least);
98cb887364d3 6810672: Comment typos
twisti
parents: 558
diff changeset
3337 if( !chosen_loop->_child ) // Inner loop?
98cb887364d3 6810672: Comment typos
twisti
parents: 558
diff changeset
3338 chosen_loop->_body.push(n);// Collect inner loops
0
a61af66fc99e Initial load
duke
parents:
diff changeset
3339 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3340
a61af66fc99e Initial load
duke
parents:
diff changeset
3341 #ifndef PRODUCT
a61af66fc99e Initial load
duke
parents:
diff changeset
3342 //------------------------------dump-------------------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
3343 void PhaseIdealLoop::dump( ) const {
a61af66fc99e Initial load
duke
parents:
diff changeset
3344 ResourceMark rm;
a61af66fc99e Initial load
duke
parents:
diff changeset
3345 Arena* arena = Thread::current()->resource_area();
a61af66fc99e Initial load
duke
parents:
diff changeset
3346 Node_Stack stack(arena, C->unique() >> 2);
a61af66fc99e Initial load
duke
parents:
diff changeset
3347 Node_List rpo_list;
a61af66fc99e Initial load
duke
parents:
diff changeset
3348 VectorSet visited(arena);
a61af66fc99e Initial load
duke
parents:
diff changeset
3349 visited.set(C->top()->_idx);
a61af66fc99e Initial load
duke
parents:
diff changeset
3350 rpo( C->root(), stack, visited, rpo_list );
a61af66fc99e Initial load
duke
parents:
diff changeset
3351 // Dump root loop indexed by last element in PO order
a61af66fc99e Initial load
duke
parents:
diff changeset
3352 dump( _ltree_root, rpo_list.size(), rpo_list );
a61af66fc99e Initial load
duke
parents:
diff changeset
3353 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3354
a61af66fc99e Initial load
duke
parents:
diff changeset
3355 void PhaseIdealLoop::dump( IdealLoopTree *loop, uint idx, Node_List &rpo_list ) const {
367
194b8e3a2fc4 6384206: Phis which are later unneeded are impairing our ability to inline based on static types
never
parents: 293
diff changeset
3356 loop->dump_head();
0
a61af66fc99e Initial load
duke
parents:
diff changeset
3357
a61af66fc99e Initial load
duke
parents:
diff changeset
3358 // Now scan for CFG nodes in the same loop
a61af66fc99e Initial load
duke
parents:
diff changeset
3359 for( uint j=idx; j > 0; j-- ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3360 Node *n = rpo_list[j-1];
a61af66fc99e Initial load
duke
parents:
diff changeset
3361 if( !_nodes[n->_idx] ) // Skip dead nodes
a61af66fc99e Initial load
duke
parents:
diff changeset
3362 continue;
a61af66fc99e Initial load
duke
parents:
diff changeset
3363 if( get_loop(n) != loop ) { // Wrong loop nest
a61af66fc99e Initial load
duke
parents:
diff changeset
3364 if( get_loop(n)->_head == n && // Found nested loop?
a61af66fc99e Initial load
duke
parents:
diff changeset
3365 get_loop(n)->_parent == loop )
a61af66fc99e Initial load
duke
parents:
diff changeset
3366 dump(get_loop(n),rpo_list.size(),rpo_list); // Print it nested-ly
a61af66fc99e Initial load
duke
parents:
diff changeset
3367 continue;
a61af66fc99e Initial load
duke
parents:
diff changeset
3368 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3369
a61af66fc99e Initial load
duke
parents:
diff changeset
3370 // Dump controlling node
a61af66fc99e Initial load
duke
parents:
diff changeset
3371 for( uint x = 0; x < loop->_nest; x++ )
a61af66fc99e Initial load
duke
parents:
diff changeset
3372 tty->print(" ");
a61af66fc99e Initial load
duke
parents:
diff changeset
3373 tty->print("C");
a61af66fc99e Initial load
duke
parents:
diff changeset
3374 if( n == C->root() ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3375 n->dump();
a61af66fc99e Initial load
duke
parents:
diff changeset
3376 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
3377 Node* cached_idom = idom_no_update(n);
a61af66fc99e Initial load
duke
parents:
diff changeset
3378 Node *computed_idom = n->in(0);
a61af66fc99e Initial load
duke
parents:
diff changeset
3379 if( n->is_Region() ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3380 computed_idom = compute_idom(n);
a61af66fc99e Initial load
duke
parents:
diff changeset
3381 // computed_idom() will return n->in(0) when idom(n) is an IfNode (or
a61af66fc99e Initial load
duke
parents:
diff changeset
3382 // any MultiBranch ctrl node), so apply a similar transform to
a61af66fc99e Initial load
duke
parents:
diff changeset
3383 // the cached idom returned from idom_no_update.
a61af66fc99e Initial load
duke
parents:
diff changeset
3384 cached_idom = find_non_split_ctrl(cached_idom);
a61af66fc99e Initial load
duke
parents:
diff changeset
3385 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3386 tty->print(" ID:%d",computed_idom->_idx);
a61af66fc99e Initial load
duke
parents:
diff changeset
3387 n->dump();
a61af66fc99e Initial load
duke
parents:
diff changeset
3388 if( cached_idom != computed_idom ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3389 tty->print_cr("*** BROKEN IDOM! Computed as: %d, cached as: %d",
a61af66fc99e Initial load
duke
parents:
diff changeset
3390 computed_idom->_idx, cached_idom->_idx);
a61af66fc99e Initial load
duke
parents:
diff changeset
3391 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3392 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3393 // Dump nodes it controls
a61af66fc99e Initial load
duke
parents:
diff changeset
3394 for( uint k = 0; k < _nodes.Size(); k++ ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3395 // (k < C->unique() && get_ctrl(find(k)) == n)
a61af66fc99e Initial load
duke
parents:
diff changeset
3396 if (k < C->unique() && _nodes[k] == (Node*)((intptr_t)n + 1)) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3397 Node *m = C->root()->find(k);
a61af66fc99e Initial load
duke
parents:
diff changeset
3398 if( m && m->outcnt() > 0 ) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3399 if (!(has_ctrl(m) && get_ctrl_no_update(m) == n)) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3400 tty->print_cr("*** BROKEN CTRL ACCESSOR! _nodes[k] is %p, ctrl is %p",
a61af66fc99e Initial load
duke
parents:
diff changeset
3401 _nodes[k], has_ctrl(m) ? get_ctrl_no_update(m) : NULL);
a61af66fc99e Initial load
duke
parents:
diff changeset
3402 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3403 for( uint j = 0; j < loop->_nest; j++ )
a61af66fc99e Initial load
duke
parents:
diff changeset
3404 tty->print(" ");
a61af66fc99e Initial load
duke
parents:
diff changeset
3405 tty->print(" ");
a61af66fc99e Initial load
duke
parents:
diff changeset
3406 m->dump();
a61af66fc99e Initial load
duke
parents:
diff changeset
3407 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3408 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3409 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3410 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3411 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3412
a61af66fc99e Initial load
duke
parents:
diff changeset
3413 // Collect a R-P-O for the whole CFG.
a61af66fc99e Initial load
duke
parents:
diff changeset
3414 // Result list is in post-order (scan backwards for RPO)
a61af66fc99e Initial load
duke
parents:
diff changeset
3415 void PhaseIdealLoop::rpo( Node *start, Node_Stack &stk, VectorSet &visited, Node_List &rpo_list ) const {
a61af66fc99e Initial load
duke
parents:
diff changeset
3416 stk.push(start, 0);
a61af66fc99e Initial load
duke
parents:
diff changeset
3417 visited.set(start->_idx);
a61af66fc99e Initial load
duke
parents:
diff changeset
3418
a61af66fc99e Initial load
duke
parents:
diff changeset
3419 while (stk.is_nonempty()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3420 Node* m = stk.node();
a61af66fc99e Initial load
duke
parents:
diff changeset
3421 uint idx = stk.index();
a61af66fc99e Initial load
duke
parents:
diff changeset
3422 if (idx < m->outcnt()) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3423 stk.set_index(idx + 1);
a61af66fc99e Initial load
duke
parents:
diff changeset
3424 Node* n = m->raw_out(idx);
a61af66fc99e Initial load
duke
parents:
diff changeset
3425 if (n->is_CFG() && !visited.test_set(n->_idx)) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3426 stk.push(n, 0);
a61af66fc99e Initial load
duke
parents:
diff changeset
3427 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3428 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
3429 rpo_list.push(m);
a61af66fc99e Initial load
duke
parents:
diff changeset
3430 stk.pop();
a61af66fc99e Initial load
duke
parents:
diff changeset
3431 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3432 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3433 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3434 #endif
a61af66fc99e Initial load
duke
parents:
diff changeset
3435
a61af66fc99e Initial load
duke
parents:
diff changeset
3436
a61af66fc99e Initial load
duke
parents:
diff changeset
3437 //=============================================================================
a61af66fc99e Initial load
duke
parents:
diff changeset
3438 //------------------------------LoopTreeIterator-----------------------------------
a61af66fc99e Initial load
duke
parents:
diff changeset
3439
a61af66fc99e Initial load
duke
parents:
diff changeset
3440 // Advance to next loop tree using a preorder, left-to-right traversal.
a61af66fc99e Initial load
duke
parents:
diff changeset
3441 void LoopTreeIterator::next() {
a61af66fc99e Initial load
duke
parents:
diff changeset
3442 assert(!done(), "must not be done.");
a61af66fc99e Initial load
duke
parents:
diff changeset
3443 if (_curnt->_child != NULL) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3444 _curnt = _curnt->_child;
a61af66fc99e Initial load
duke
parents:
diff changeset
3445 } else if (_curnt->_next != NULL) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3446 _curnt = _curnt->_next;
a61af66fc99e Initial load
duke
parents:
diff changeset
3447 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
3448 while (_curnt != _root && _curnt->_next == NULL) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3449 _curnt = _curnt->_parent;
a61af66fc99e Initial load
duke
parents:
diff changeset
3450 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3451 if (_curnt == _root) {
a61af66fc99e Initial load
duke
parents:
diff changeset
3452 _curnt = NULL;
a61af66fc99e Initial load
duke
parents:
diff changeset
3453 assert(done(), "must be done.");
a61af66fc99e Initial load
duke
parents:
diff changeset
3454 } else {
a61af66fc99e Initial load
duke
parents:
diff changeset
3455 assert(_curnt->_next != NULL, "must be more to do");
a61af66fc99e Initial load
duke
parents:
diff changeset
3456 _curnt = _curnt->_next;
a61af66fc99e Initial load
duke
parents:
diff changeset
3457 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3458 }
a61af66fc99e Initial load
duke
parents:
diff changeset
3459 }